Senthil Kumaran added the comment:
I have made the suggested specific changes, but while reviewing the entire doc,
I realized that much improvements can be made. Keeping the documentation more
helpful aligned with the cgi.py APIs. I shall keep bug report to update the cgi
docs further
Senthil Kumaran added the comment:
Hello Xavier,
This issue required some tracing through the calls and I see the problem that
you have mentioned and patch fixes the problem.
One comment on the patch, for the tests in the module, this line -
self.frame_returning = None
does not seem to
Senthil Kumaran added the comment:
Hello Xavier,
Thanks for the explanation. Understood the reason for setting the
frame_returning to None. The patch is committed in all python versions and the
issue is fixed now. Thanks for the patch and prodding through this.
--
Senthil
Senthil Kumaran added the comment:
Fixed again with replacing print with pass.
But it is strange behavior that "stepping through" enters print in Windows and
does not so in Unix. What's the difference in windows that could cause this?
Not sure if this was ex
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue8077>
___
___
Python-bugs-list mai
> Georg Brandl added the comment:
>
> Should be fixed now.
Thanks for the commit fix, Georg. The comment on buildbot failures had
escaped my attention. Sorry for that.
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/opti
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue14767>
___
___
Python-bugs-list mai
Senthil Kumaran added the comment:
Hi Ezio,
The patch is fine and the check is correct. I was thinking if by removing int()
based verification are we missing out anything on port number check. But looks
like we wont as the int() previously is done to find the proper scheme and url
part for
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue14809>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
this issue is taken care. Both in accepting unquoted Realm for basic auth
leniently and then raising a UserWarning when encountering this case.
--
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -&g
Senthil Kumaran added the comment:
Thanks for raising this issue, Nick. Yes, I verified in both RFC 3986 and 2396
and realized we can safely adopt a generic parsing system for query and
fragment portions of the urls for any scheme. Since it was supported in earlier
versions too, I felt it
Senthil Kumaran added the comment:
The rule for content-length seems, if there is a body for a request, even if
the body is "" ( empty body), then you should send the Content-Length.
The mistake in the Python httplib was, the set_content_length was called with
this condition.
i
Senthil Kumaran added the comment:
This is fixed in all the branches. Thanks!
--
assignee: -> orsenthil
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python
Senthil Kumaran added the comment:
Actually, the claim is correct, there is no dash separated expiry dates even in
the real world. Tested with couple of sites like gmail, wikipedia and few more.
--
___
Python tracker
<http://bugs.python.
Senthil Kumaran added the comment:
This is fixed in all the branches. Note here - the test change is actually not
the coverage because Cookie tests cover the scenarios of SimpleCookie class of
both loading the formatted date and setting the formatted date. It is only
testing the setting of
Senthil Kumaran added the comment:
I am not sure if anything should be done to this request. Saying that
int("99",10) is converting to
99L in Python2.7 it is a bug/security issue is
hypothetical. Practically, such high port numbers ca
Senthil Kumaran added the comment:
pass_to_cython(urlparse("http://google.de:99**99[to be
calculated]").port)
is no different than sending
pass_to_cython(99**99[to be calculated])
In that case, would the former make a security loop hole in urlparse? Looks
pretty
Senthil Kumaran added the comment:
This is taken care. I was not really convinced on the need as likely seemed a
non issue from "urlparse" standpoint, But still there is no harm in returning
valid port as semantically the attribute stands for a port.
Thanks!
-
Senthil Kumaran added the comment:
I have fixed the help to include only ascii characters ( represented in hex) so
that conversion to bytes is represented in the help and also the terminal whose
LANG is C is able to display them too.
On Ubuntu, when I had LANG=C, locale gave the following o
New submission from Senthil Kumaran :
python3 -m http.server enables you to serve with SimpleHTTPRequestHandler
serving as http server. If the cgi-bin paths are present those are *not treated
as cgi paths*. Previously in Python2, python -m CGIHTTPServer enabled the
sever to run it as CGI
Senthil Kumaran added the comment:
I have added this in 3.3, I am not sure if adding to 3.2 is a good idea. To
some, it may look like a feature.
--
resolution: -> fixed
stage: needs patch -> committed/rejected
___
Python tracker
Senthil Kumaran added the comment:
That's surprising! I shall test it with http debug mode and see what's
happening.
--
assignee: -> orsenthil
___
Python tracker
<http://bugs.pytho
Senthil Kumaran added the comment:
Thanks for sharing your views, Éric. I guess, RDM has +1 too ( since he closed
it). Let this be only in 3.3+ then.
--
___
Python tracker
<http://bugs.python.org/issue14
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue15009>
___
___
Python-bugs-list mai
Senthil Kumaran added the comment:
Thanks for the patch, Forest Bond.
However, the way I look at this feature, it could be added into urllib.request
as a separate handler called MultiPostHandler and request object when it
requires it should be able to add it and then use it.
Here is a
Senthil Kumaran added the comment:
I think, the transparent compression should work at http.client level. I also
agree with other points made by Serhiy:
- transparent decompression should delete headers Content-Encoding and
Content-Length (this is as per RFC too)
- Should not do another
Changes by Senthil Kumaran :
--
title: argparse does not sanitize help strings for % signs -> argparse update
help msg for % signs
___
Python tracker
<http://bugs.python.org/issu
Changes by Senthil Kumaran :
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Senthil Kumaran added the comment:
Adding link to pdb source may be not be suitable. Readers may require to
understand the states which pdb goes through. Docs here are better, IMO. -1
vote from me.
--
nosy: +orsenthil
___
Python tracker
<h
Senthil Kumaran added the comment:
The docs are fixed now.
--
nosy: +orsenthil
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Senthil Kumaran added the comment:
Right now, I do not see the problem mentioned in this report.
http://www.python.org/doc/ point to a page which has reference docs to both 2.7
and 3.0.
The left hand side, Other Resources Link are generic too.
docs.python.org pointing to py2.7 is a python
Senthil Kumaran added the comment:
Let me address this one thing at a time, the point on smb really confused me
and I got into thinking that how smb (being more common), the issue was not
raised. Looks smb url will always start with smb:// (// are the requirements
for identified netloc
Senthil Kumaran added the comment:
Look at the following two bugs which dwelt on similar issues: Issue8339 and
Issue7904 and in one message particular, msg102737, I seem to have come to a
conclusion that " I don't see that 'x://' and 'x:///y' qualifies as valid U
Senthil Kumaran added the comment:
On Sun, Jul 1, 2012 at 1:16 AM, Richard Oudkerk wrote:
> Then I doubt this is a bug in Python.
I guess, you meant, this is NOT a bug in Python.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.pyth
Senthil Kumaran added the comment:
Thanks for the patch Jeff and thanks for the guidance, Nick.
Committed this in all branches.
--
nosy: +orsenthil
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
_
Senthil Kumaran added the comment:
I have fixed this in the changeset 34e705fa4da4.
SERVER_SOFTWARE term can be made more specific to note the implementation as
various suggestions say. I personally think, it is worthy to make change in 3.3
itself as its been open from a long time and it is
Changes by Senthil Kumaran :
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
versions: +Python 3.3 -Python 3.4
___
Python tracker
<http://bugs.python.o
Changes by Senthil Kumaran :
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
versions: +Python 2.7, Python 3.2
___
Python tracker
<http://bugs.python.or
Senthil Kumaran added the comment:
Thanks for the patch, Stephen.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue14826>
___
___
Python-bug
Senthil Kumaran added the comment:
It seems to me that toBytes in urllib was introduce to restrict the
allowance of urls which were sent as unicode strings. We wanted urls
to be ascii strings in Python2.
http://mail.python.org/pipermail/python-bugs-list/2000-November/002779.html
And quoting
Senthil Kumaran added the comment:
Yeah, I am thinking so as well in that case, the test_cookielib.py
test case may need a change.
--
___
Python tracker
<http://bugs.python.org/issue14
Senthil Kumaran added the comment:
The last change should settle the buildbots, But I would like to come
back to this issue again tomorrow with focus - 3.3to see if we can
deal with removing to_bytes and then in 2.7 to see if something can
done to test_cookielib.py test case
Senthil Kumaran added the comment:
I think, the ``source bin/activate`` should be mentioned in the Docs
at least. It should not require that a person carries this knowledge
from somewhere else. At the moment, I do not see mention of it in the
docs either -
http://docs.python.org/dev/library
Senthil Kumaran added the comment:
On Sun, Jul 8, 2012 at 2:30 AM, Antoine Pitrou wrote:
>
> Senthil, do you read python-dev? I think this change was prematurate from the
> start (nevermind the fact that you didn't run the test suite before
> committing).
I thought that
Senthil Kumaran added the comment:
On Sun, Jul 8, 2012 at 9:42 AM, Christian Heimes wrote:
> I vote for reverting the chances as they break the API. You could improve the
> docs and emphasize that URLs must be quoted correctly as the module doesn't
> implement browser magic.
Senthil Kumaran added the comment:
Yes, this is fixed as part of issue12541
--
resolution: -> duplicate
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue15310>
___
___
Python-bugs-list mai
Senthil Kumaran added the comment:
On Mon, Jul 9, 2012 at 8:50 PM, Chris Jerdonek wrote:>
> Sure, if someone is open to reviewing it.
Yes, please go ahead. I can review it and I believe others should be
able to as well. As a first short, I think, it may be a good idea to
just replaci
Senthil Kumaran added the comment:
The patch seems good. I apologize that this has been sitting stale for a long
time. Since this is a new feature, I am not sure if putting to 3.3 might be a
good idea. This is a feature for httplib, so it may not make it to 2.7.x, but
can make it to 3.4
Senthil Kumaran added the comment:
I had a discussion with Anrs on this, and it went along these lines -
I confused the buffering issue (encountered with streaming data) of urllib2
with chunked transfer encoding.
The flow will be blocked in the case at the socket level waiting for 8192
Senthil Kumaran added the comment:
I am with Éric on this. Looking at json/decoder.py and json/encoder.py, I too
feel that source link may not be helpful as much as it is helpful for others.
Docs are best here. I am closing this report. Thanks!
--
nosy: +orsenthil
resolution
Senthil Kumaran added the comment:
Given that we have self.left_list and self.left_only ( and self.right_list and
self.right_only), I am not sure how adding self.left/self.right is going to add
more meaning? It would simply point to the dir1 and dir2 arguments that are
being passed.
Also
Senthil Kumaran added the comment:
Thanks for this report. I saw that filecmp.rst could be improved a bit further
too. I added some additional improvements to the docs in addition to the one
you mentioned in the patch.
--
assignee: docs@python -> orsenthil
nosy: +orsenthil
Added f
Senthil Kumaran added the comment:
If by attribution, if you mean, proper mention of credits/ acks, during the
commit, I shall add it. Also, I agree that "shallow" should be documented.
But there were few more places which were lacking, so I ended up with
expanding docs after readin
Senthil Kumaran added the comment:
Hi Chris, your patch looks good. I shall commit it now. The rest of the
documentation changes can go in another patch. Thanks!
--
___
Python tracker
<http://bugs.python.org/issue15
New submission from Senthil Kumaran :
filecmp.rst could see some improvements which are easy and useful too. It was
discussed in Issue15250 and a patch is attached.
--
assignee: orsenthil
components: Documentation
files: Issue15250.patch
keywords: easy, patch
messages: 166200
nosy
Senthil Kumaran added the comment:
This is taken care. Rest of documentation improvements could be dealt with in
Issue15430. Thanks, Chris.
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Pytho
Changes by Senthil Kumaran :
--
resolution: -> invalid
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.o
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
___
Python tracker
<http://bugs.python.org/issue15350>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue15564>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
Thanks for raising this issue, Serhiy and thanks for the patch, Daniel. It is
committed now.
--
nosy: +orsenthil
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue15593>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
Thanks for the patch, Daniel. Fixed in all versions.
--
nosy: +orsenthil
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
type: -> behavior
___
Python tracker
<http://
Senthil Kumaran added the comment:
Hi Chris & Eli, - Sorry that I missed this issue.
Chris - agree to your rationale. I can see how having self.left and self.right
documented can add value, The diff example was useful. Initially, I did have
some doubts in terms how it could be useful when
Senthil Kumaran added the comment:
As this is not adding any feature, but just an additional clarification to the
existing attribute together with some useful documentation, I believe this can
go in 2.7, 3.2 and 3.3
Please correct me if I am wrong here.
--
versions: +Python 2.7
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue15743>
___
___
Python-bugs-list mai
Senthil Kumaran added the comment:
The patch looks good to me. Thanks Jeff.
--
___
Python tracker
<http://bugs.python.org/issue15743>
___
___
Python-bugs-list m
Senthil Kumaran added the comment:
One change. get_method has only been changed not deprecated. Those test cases
should not change and moreover the current change to assert against .method
results in a failure too. get_method would return "GET" when .method is None
Senthil Kumaran added the comment:
I could verify this bug and also looks like a tricky one. Because when we are
sending the cacert (the second time), we create a new HTTPSHandler and then
build the opener again using that handler.
I thought, we can use the existing opener object itself like
Senthil Kumaran added the comment:
Oops. I had not seen Eric and Mattiahs comment to this issue, which
pointed out to the problem. Sorry for not acting on this.
Thanks Georg for adding those module attributes back.
On Fri, Aug 24, 2012 at 9:17 AM, Roundup Robot wrote:
>
> Roundup Robot
Senthil Kumaran added the comment:
On Thu, Aug 30, 2012 at 11:17 AM, mastahyeti wrote:
>
> When parsing a url with urlparse.urlparse, the return type is non-mutable
> (named tuple). This is really inconvenient, because one of the most common
> (imop) use cases for urlparse is to
Senthil Kumaran added the comment:
Okay, this is funny. first info is invoking addinfourl of urllib, which would
return headers. But in urllib2, the headers are self.hdrs
I would side with the documentation that info is advertised method for
HTTPError object. In 2.7, I guess just docs could
Senthil Kumaran added the comment:
Hello Eduardo,
I fail to see the bug in here. Robotparser module is for reading and
parsing the robot.txt file, the module responsible for fetching it
could urllib. robots.txt is always available from web-server and you
can download the robot.txt by any means
Senthil Kumaran added the comment:
Hi Eduardo,
I tested further and do observe some very strange oddities.
On Mon, Sep 10, 2012 at 10:45 PM, Eduardo A. Bustamante López
wrote:
> Also, I'm aware that you shouldn't normally worry about setting a specific
> user-agent to fet
Senthil Kumaran added the comment:
This is a feature request. urlencode tries to prepare the data in the form
items are submitted. It has been like form is list of key,value pairs and
that's what is reflect in the current behavior. That said, I am not -1 if see
if some frameworks ado
Senthil Kumaran added the comment:
2012/9/10 Jesús Cea Avión :
>
> Ping!.
Guess, it is still for 3.4.
--
___
Python tracker
<http://bugs.python.org/i
Senthil Kumaran added the comment:
Thanks!. Verified the patch, it is fine and can be applied directly on
3.2 and 3.3 branch. Tested it as well. On 2.7, some changes would be
required.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.
Senthil Kumaran added the comment:
I shall make the changes 2.7, keeping this open for that.
--
___
Python tracker
<http://bugs.python.org/issue15899>
___
___
Changes by Senthil Kumaran :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue15899>
___
___
Python-bugs-list
Changes by Senthil Kumaran :
--
stage: patch review -> committed/rejected
___
Python tracker
<http://bugs.python.org/issue15899>
___
___
Python-bugs-list mai
Senthil Kumaran added the comment:
Have a look at the ProxyHandler example in the Examples here -
http://docs.python.org/library/urllib2.html#examples
Also, construct the full url properly with urlencoded data as params.
Your report does not give any details of problem.
--
nosy
Changes by Senthil Kumaran :
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue15928>
___
___
Python-bugs-list mailing list
Unsubscri
Senthil Kumaran added the comment:
The patch looks good and is doing the right thing, that is, when the, strict
mode is passed, it fails and without strict mode, it is printing the parsed
list.
--
nosy: +orsenthil
___
Python tracker
<h
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue16095>
___
___
Python-bugs-list mai
Senthil Kumaran added the comment:
Personally, I want to do away with all those scheme specific stuff, if we can.
I have tried previously, but failed due to some backwards incompatibility. 3.4
gives a good chance/time to make those changes to get rid of those scheme
specific stuff (again
Senthil Kumaran added the comment:
issue9374 - another related one which should be taken care. Which is simply
reverting this:
http://hg.python.org/cpython/diff/a0b3cb52816e/Lib/urllib/parse.py and
informing in the DOCs that those globals are not available anymore. (But this
should also be
Changes by Senthil Kumaran :
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Senthil Kumaran added the comment:
+1 to this change. It may be helpful in the cases like issue15991.
--
___
Python tracker
<http://bugs.python.org/issue16
Senthil Kumaran added the comment:
I took the privilege of testing, adding news and docs and committing it.
Thank you!
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bug
Senthil Kumaran added the comment:
Only the classes which are marked as deprecated are allowed removed in
the next release.
So the ones which we marked as deprecated in 3.3 can safely go in 3.4.
URLopener and FancyURLopener AFAIR had some dependency/ usage,
deprecating those may require some
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue16250>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
@Ezio, regarding msg172988. That's embarrassing. It should be fixed soon.
Review on the patch, how about having the strerror and filename from the
exception?
-raise URLError(e.errno, e.strerror, e.filename)
+raise URLError(e.str
Senthil Kumaran added the comment:
Here is the patch which captures both HTTPError and URLError at the open_file
and thus preventing multiple exceptions to be raised ( URLError and next
IOError). This can go in 3.4 and since this is bug, where correct exception is
not being caught and wrong
Senthil Kumaran added the comment:
This one is fixed in 3.4. I can see the previous versions raised IOError
exception and it is not a good idea to change by backporting. But the wrong
arguments on URLError should be fixed tough.
--
___
Python
Senthil Kumaran added the comment:
This patch fixed these URLError wrong invocation issue and adds some tests for
testing those it.
I noticed that some of these were in the dead-end of the code, like checking if
url is not a str (it is always, unwrap makes it a str if otherwise). Those will
Senthil Kumaran added the comment:
The URLError changes gone in as part of fix for issue10836 should give
e.filename and e.reason.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue16
Senthil Kumaran added the comment:
This is fixed in 3.4. I shall backport to other branches.
--
___
Python tracker
<http://bugs.python.org/issue16250>
___
___
New submission from Senthil Kumaran:
>From the Buildbot failure -
>http://buildbot.python.org/all/builders/x86%20XP-4%203.x/builds/7573/steps/test/logs/stdio
I remember that we restricted the access for file:// scheme to localhost only
for Windows/Cygwin. In terms of exception raised it
New submission from Senthil Kumaran:
localhost() returns a string and thishost() returns tuple. In
urllib/request.py, for file:// protocol, there is a verification to check to if
the host is in the localhost and check happens:
socket.gethostbyname(host) in (localhost() + thishost())):
This
Senthil Kumaran added the comment:
thanks for the bug-report/patch.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue16302>
___
___
Python-bug
1301 - 1400 of 2044 matches
Mail list logo
