Senthil Kumaran added the comment:
New changeset 505b6015a1579fc50d9697e4a285ecc64976397a by Senthil Kumaran in
branch '3.7':
Revert "bpo-27657: Fix urlparse() with numeric paths (GH-661)" (#18526)
https://github.com/python/cpython/commit/505b6015a1579fc50d96
Senthil Kumaran added the comment:
New changeset ea316fd21527dec53e704a5b04833ac462ce3863 by Senthil Kumaran in
branch '3.8':
Revert "[3.8] bpo-27657: Fix urlparse() with numeric paths (GH-16839)"
(GH-18525)
https://github.com/python/cpython/commit/ea316fd21527dec53e70
Senthil Kumaran added the comment:
Hi Łukasz, There was a concern raised by python core-devs about behavior in
3.9. I plan to address that point raised in this issue and close this ticket.
--
___
Python tracker
<https://bugs.python.org/issue27
Senthil Kumaran added the comment:
New changeset 5e260e0fde211829fcb67060cfd602f4b679f802 by Stephen Balousek in
branch 'master':
bpo-39548: Fix handling of 'WWW-Authenticate' header for Digest Auth (GH-18338)
https://github.com/python/cpython/commit/5e260e0fde211829fcb6
Change by Senthil Kumaran :
--
assignee: -> orsenthil
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python
Change by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
___
Python tracker
<https://bugs.python.org/issue38976>
___
___
Python-bugs-list mai
Change by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<https://bugs.python.org/issue40291>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Senthil Kumaran :
--
keywords: +patch
pull_requests: +22473
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/23604
___
Python tracker
<https://bugs.python.org/issu
Senthil Kumaran added the comment:
I spent some time reviewing and researching the specification. It also says
The server is not required to create meta-variables for all the
header fields that it receives.
And this in issue, open since 2010, we have issue two different set of
Change by Senthil Kumaran :
--
assignee: -> orsenthil
versions: +Python 3.10, Python 3.9 -Python 2.6, Python 2.7, Python 3.1, Python
3.2
___
Python tracker
<https://bugs.python.org/iss
Change by Senthil Kumaran :
--
pull_requests: +22506
pull_request: https://github.com/python/cpython/pull/23638
___
Python tracker
<https://bugs.python.org/issue5
Change by Senthil Kumaran :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.o
Senthil Kumaran added the comment:
This was also resolved in 3.10 https://github.com/python/cpython/pull/23638
--
___
Python tracker
<https://bugs.python.org/issue5
Change by Senthil Kumaran :
--
versions: +Python 3.10 -Python 2.7, Python 3.5, Python 3.6
___
Python tracker
<https://bugs.python.org/issue18140>
___
___
Pytho
Senthil Kumaran added the comment:
Not a bug. The message #msg375109 explains how to quote and unquote the '#' in
the password field, and demonstrates how urllib parses it correctly.
I guess, it was set to open as a mistake. Closing it again.
--
stage: -> resolved
Change by Senthil Kumaran :
--
title: urllib2 fails for proxy credentials that contain a '/' character ->
urllib.request fails for proxy credentials that contain a '/' character
versions: +Python 3.10 -Python 2.7
___
Senthil Kumaran added the comment:
This is resolved by Issue 31122 and code now raises SSLEOFError instead of
OSError.
The reason for OSError in the first place was PySSL_SetError function had the
following call s->errorhandler();
https://github.com/python/cpython/blob/3.7/Modules/_ss
Change by Senthil Kumaran :
--
components: +Library (Lib) -Documentation
versions: +Python 3.10, Python 3.9
___
Python tracker
<https://bugs.python.org/issue41
Change by Senthil Kumaran :
--
keywords: +patch
pull_requests: +22818
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/23973
___
Python tracker
<https://bugs.python.org/issu
Senthil Kumaran added the comment:
https://github.com/python/cpython/pull/23973 will resolve this issue. The
issue was localized to _parse_proxy method in urllib2.
--
___
Python tracker
<https://bugs.python.org/issue23
Change by Senthil Kumaran :
--
keywords: -easy
versions: +Python 3.10 -Python 2.6
___
Python tracker
<https://bugs.python.org/issue1398781>
___
___
Python-bug
Change by Senthil Kumaran :
--
versions: +Python 3.10 -Python 2.6, Python 2.7, Python 3.1, Python 3.2
___
Python tracker
<https://bugs.python.org/issue8
Senthil Kumaran added the comment:
This is a not a bug, it asks for parameter types to explained. API
documentation reference should provide the guidance.
--
nosy: +orsenthil
resolution: -> wont fix
stage: -> resolved
status: open -> closed
versions: +Python 3.10 -P
Change by Senthil Kumaran :
--
assignee: docs@python -> orsenthil
versions: +Python 3.10 -Python 2.6, Python 2.7, Python 3.1
___
Python tracker
<https://bugs.python.org/iss
Change by Senthil Kumaran :
--
versions: +Python 3.8, Python 3.9
___
Python tracker
<https://bugs.python.org/issue23328>
___
___
Python-bugs-list mailin
Senthil Kumaran added the comment:
Merged in
3.10 -
https://github.com/python/cpython/commit/030a713183084594659aefd77b76fe30178e23c8
3.9 -
https://github.com/python/cpython/commit/df794406a8803e3d6062af8404d7564833f9af28
3.8 -
https://github.com/python/cpython/commit
Change by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<https://bugs.python.org/issue42967>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
> IMO we should disable ASAN (handling of signals) at runtime when we trigger a
> crash on purpose (ex: faulthandler._sigsegv()).
> ASAN_OPTIONS="handle_segv=0".
Both sound reasonable. But not sure if they will resolve this crash toug
Senthil Kumaran added the comment:
Ken, Please don't close your PR. I will review it. It has a CLA signed
which is helpful.
On Fri, Jan 22, 2021 at 4:53 AM Ken Jin wrote:
>
> Ken Jin added the comment:
>
> Adam, I linked a PR 2 days ago here
> https://github.com/pytho
Senthil Kumaran added the comment:
+1. The suggested fix looks good to me.
--
___
Python tracker
<https://bugs.python.org/issue43075>
___
___
Python-bugs-list m
Senthil Kumaran added the comment:
Ned, and others watching.
In future versions of Python, we can use only "&" based separator. But I am not
certain what should be proposed for the older releases of Python.
Adam's Patch is a good one to specify explicitly specify th
Change by Senthil Kumaran :
--
assignee: -> orsenthil
___
Python tracker
<https://bugs.python.org/issue42967>
___
___
Python-bugs-list mailing list
Unsubscrib
Senthil Kumaran added the comment:
Sorry for that, Ned. I will take a decision on this by Saturday (13-Feb).
I did some research, but could come way conclusively. I have not heard any
opinions (+ves or -ves) on this. This will be a breaking change, so necessary
to support it with
Senthil Kumaran added the comment:
I meant, "I did some research, but couldn't come away conclusively".
--
___
Python tracker
<https://bugs.pyt
Senthil Kumaran added the comment:
I finished reviewing this PR https://github.com/python/cpython/pull/24297
With the contexts given in W3C recommendation, Synk.io Security Report and
pattern of usage in libraries like werkzeug and bottle, instead of ignoring
this and letting this behavior
Senthil Kumaran added the comment:
Éric, I considered the possibility of bringing it in python-dev, but thought it
could be decided in this ticket itself.
1. This was already brought up by multiple Release Managers in Python-dev, and
some conversation seems to have happened there previously
Senthil Kumaran added the comment:
New changeset fcbe0cb04d35189401c0c880ebfb4311e952d776 by Adam Goldschmidt in
branch 'master':
bpo-42967: only use '&' as a query string separator (#24297)
https://github.com/python/cpython/commit/fcbe0cb04d351894
Change by Senthil Kumaran :
--
pull_requests: +23315
pull_request: https://github.com/python/cpython/pull/24528
___
Python tracker
<https://bugs.python.org/issue42
Change by Senthil Kumaran :
--
pull_requests: +23316
pull_request: https://github.com/python/cpython/pull/24529
___
Python tracker
<https://bugs.python.org/issue42
Change by Senthil Kumaran :
--
pull_requests: +23318
pull_request: https://github.com/python/cpython/pull/24531
___
Python tracker
<https://bugs.python.org/issue42
Change by Senthil Kumaran :
--
pull_requests: +23319
pull_request: https://github.com/python/cpython/pull/24532
___
Python tracker
<https://bugs.python.org/issue42
Senthil Kumaran added the comment:
New changeset a2f0654b0a5b4c4f726155620002cc1f5f2d206a by Ken Jin in branch
'master':
bpo-42967: Fix urllib.parse docs and make logic clearer (GH-24536)
https://github.com/python/cpython/commit/a2f0654b0a5b4c4f726155620002cc
Senthil Kumaran added the comment:
New changeset c9f07813ab8e664d8c34413c4fc2d4f86c061a92 by Senthil Kumaran in
branch '3.9':
[3.9] bpo-42967: only use '&' as a query string separator (GH-24297) (#24528)
https://github.com/python/cpython/commit/c9f07813ab8e664d
Senthil Kumaran added the comment:
This is resolved in all version of Python now.
Thank you all for your contributions!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
title: [security] urllib.parse.parse_qsl(): Web cache poisoning - `; ` as
Senthil Kumaran added the comment:
Alex, https://bugs.python.org/issue23740 is identified as a dependency on this
issue. We will have to resolve that first, and come back to this. And yes, if
you contribute on other's patch, both the contributions will be included and
appropriately cre
Senthil Kumaran added the comment:
Yes, the point number 5. We will have to evaluate if sendfile side-steps and
avoids the issues noted in issue23740
--
___
Python tracker
<https://bugs.python.org/issue13
Change by Senthil Kumaran :
--
versions: -Python 3.6, Python 3.7
___
Python tracker
<https://bugs.python.org/issue42782>
___
___
Python-bugs-list mailin
Change by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
___
Python tracker
<https://bugs.python.org/issue42782>
___
___
Python-bugs-list mai
Senthil Kumaran added the comment:
New changeset 132131b404e06ee1a19b040a1f96cd1118abed0c by Winson Luk in branch
'master':
bpo-42782: Fail fast for permission errors in shutil.move() (GH-24001)
https://github.com/python/cpython/commit/132131b404e06ee1a19b040a1f96cd
Senthil Kumaran added the comment:
New changeset 3a87e562ea21a5083e9f168e02e8ec3e6611e167 by Nathan Beals in
branch 'master':
bpo-42994: Add MIME types for opus, AAC, 3gpp and 3gpp2 (#24287)
https://github.com/python/cpython/commit/3a87e562ea21a5083e9f168e02e8ec3e6611e167
-
Senthil Kumaran added the comment:
Thanks for the this contribution, Nathan.
--
assignee: -> orsenthil
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python
Change by Senthil Kumaran :
--
assignee: -> nascheme
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.10, Python 3.9
___
Python tracker
<https://bugs.python
Change by Senthil Kumaran :
--
keywords: +easy (C)
___
Python tracker
<https://bugs.python.org/issue43075>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Senthil Kumaran :
--
pull_requests: +23498
pull_request: https://github.com/python/cpython/pull/24725
___
Python tracker
<https://bugs.python.org/issue42
Senthil Kumaran added the comment:
New changeset bf566847f5a97e6ce391f8fb94185ee756cb94a2 by Senthil Kumaran in
branch '3.9':
[3.9] bpo-42782: Fail fast for permission errors in shutil.move() (GH-24001)
(#24725)
https://github.com/python/cpyt
Change by Senthil Kumaran :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Senthil Kumaran :
--
stage: resolved -> patch review
___
Python tracker
<https://bugs.python.org/issue42782>
___
___
Python-bugs-list mailing list
Un
Change by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
___
Python tracker
<https://bugs.python.org/issue22708>
___
___
Python-bugs-list mai
Change by Senthil Kumaran :
--
versions: +Python 3.8, Python 3.9
___
Python tracker
<https://bugs.python.org/issue43332>
___
___
Python-bugs-list mailin
Change by Senthil Kumaran :
--
stage: commit review -> resolved
___
Python tracker
<https://bugs.python.org/issue43332>
___
___
Python-bugs-list mai
Senthil Kumaran added the comment:
Hello Pandu,
Thank you for this patch and the explanation. Does client blocking on repeated
challenge from the server (using of while loop) look okay here?
The conversation here indicates to me that it is fine. Is there any
recommendation or
Senthil Kumaran added the comment:
Petr, thank you. Let's treat it as a new issue linked to this.
--
___
Python tracker
<https://bugs.python.org/is
Change by Senthil Kumaran :
--
versions: +Python 3.10 -Python 3.5, Python 3.6, Python 3.7
___
Python tracker
<https://bugs.python.org/issue40837>
___
___
Pytho
Senthil Kumaran added the comment:
This will be a breaking change to the clients relying on current broken
behavior, setting the fix version to 3.10 (current active).
--
nosy: +orsenthil
___
Python tracker
<https://bugs.python.org/issue40
Change by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: -Python 3.5, Python 3.6
___
Python tracker
<https://bugs.python
Change by Senthil Kumaran :
--
versions: +Python 3.10, Python 3.7, Python 3.8
___
Python tracker
<https://bugs.python.org/issue40471>
___
___
Python-bugs-list m
Change by Senthil Kumaran :
--
versions: +Python 3.10
___
Python tracker
<https://bugs.python.org/issue39314>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
Hi All,
On the previous message.
> I plan to address that point raised in this issue and close this ticket.
My intention was to close the bug.
1) The Issue was originally a regression in 3.8, and 3.7, And this been be
resolved.
The change introduced
Senthil Kumaran added the comment:
Michał, for this particular issue, to rely on the expected and consistent
parsing behavior, it might easier to add "scheme" to URLs in the client code.
That will be less confusing IMO. Not sure if __future__ is a good idea.
Personally, I am
Senthil Kumaran added the comment:
Chris, my understanding of the primary objection in your previous post was with
a violation of backward compatibility. It was resolved by reverting.
The 3.9+ changes are useful ones, particularly when well-defined behaviors are
listed for URLs with the
Senthil Kumaran added the comment:
> The problem is: double slashes are perfectly legal in a URI/URL, and for
> reasons I don't understand, they are in use in the wild
And what is the de-facto behavior of browsers, when double URL is used?
As far as I know, the browsers remove th
Senthil Kumaran added the comment:
Hi Tal,
Thank you. To be specific, it is about parsing behavior, specifically urljoin
behavior,
There is no question about the validity of the double-slash in the URL.
If we find a source (like libcurl) which exhibits parsing behavior different
than
Senthil Kumaran added the comment:
I will spend time on this on 12-June or 13-June, 2020.
At the very least, if no changes are required, I will document this for 3.7 and
higher versions.
--
assignee: docs@python -> orsenthil
___
Python trac
Change by Senthil Kumaran :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.10, Python 3.9
___
Python tracker
<https://bugs.python.or
Senthil Kumaran added the comment:
This is now fixed in all active versions of python. No documentation changes
required for this change.
--
___
Python tracker
<https://bugs.python.org/issue34
Senthil Kumaran added the comment:
> How did you test them?
https://about.google//products/
https://www.google.com///search?q=something
Were redirecting, and collapsing multiple slashes to single.
Now, when I try this on:
> https://en.wikipedia.org/w//index.php?search=foobar+somethin
Senthil Kumaran added the comment:
Hugo, please go ahead and a test for this patch.
--
assignee: -> orsenthil
___
Python tracker
<https://bugs.python.org/issu
Senthil Kumaran added the comment:
Hugo, I'd welcome such a change.
--
___
Python tracker
<https://bugs.python.org/issue24955>
___
___
Python-bugs-list m
Senthil Kumaran added the comment:
Hello Maarten,
> Using cgitb, I found out that the webdriver expects the environment variable
> `HTTP_X_URWID_METHOD` to be set. The javascript sets the "X-Urwid-Method"
> header (using XmlHttpRequest), but these are not visible by the C
Senthil Kumaran added the comment:
Irit, yes. Serhiy's patch could be converted to a GitHub PR and it can be
merged.
--
nosy: +orsenthil
___
Python tracker
<https://bugs.python.org/is
Senthil Kumaran added the comment:
Hi James, I will give another look at it tonight or latest by Sunday PST ,
since I was involved in this and PRs. If we can make a decision within this
context, great, otherwise we can open it up to python-dev
On Sat, Oct 17, 2020 at 3:30 PM James Addison
Senthil Kumaran added the comment:
New changeset 16ee68da6e12bb2d79751b32cc37523fe4f4bb48 by Jacob Neil Taylor in
branch 'master':
bpo-38976: Add support for HTTP Only flag in MozillaCookieJar (#17471)
https://github.com/python/cpython/commit/16ee68da6e12bb2d79751b32cc3752
Change by Senthil Kumaran :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.10 -Python 3.9
___
Python tracker
<https://bugs.python.or
Senthil Kumaran added the comment:
> so was this fixed?
Irit, not really. This is adding another hook called "progress hook" in
addition to the "report hook". We need to evaluate if this is really required.
--
status: pending -> open
Senthil Kumaran added the comment:
Yes. The required 'feature' was introduced through
https://github.com/python/cpython/pull/17471/ even as the patches were slightly
different. But keeping https://github.com/python/cpython/pull/17471/ seems fine
and we can close this ticket
Change by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<https://bugs.python.org/issue1635741>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Senthil Kumaran :
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue13294>
___
___
Python-bugs-list mailing list
Unsubscri
Senthil Kumaran added the comment:
Eric - noted the point. :)
--
___
Python tracker
<http://bugs.python.org/issue13294>
___
___
Python-bugs-list mailin
Senthil Kumaran added the comment:
I add -o as a short form for --slow. regrtest was using getopt and this
conflicting option was not caught. I see it is a bug than a feature so the
change is made in 3.2 and 3.3
default: b84f61fdcb4c and 6797e7458ad0
Thanks for catching this bug, Erno Tukia
Senthil Kumaran added the comment:
Here we go! I thought the problem did not exist in py3k, but good that the
tests caught them and we have a fix now.
Thanks for the complete patch, Joonas. I hope it was easy to port the patch to
3k. The encoding part may perhaps be the only thing to careful
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue13766>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
Fixed now. Thanks!
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
___
Python tracker
<http://bugs.python.org/issue13736>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Senthil Kumaran :
--
title: urlparse.urlunsplit() can't handle relative files (for urllib*.open() ->
Disallow relative files paths in urllib*.open()
___
Python tracker
<http://bugs.python.or
Changes by Senthil Kumaran :
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
type: performance -> behavior
versions: +Python 2.7, Python 3.2, Python 3.3
___
Python tracker
<http://bugs.pytho
Senthil Kumaran added the comment:
Actually, I saw this as a bug with urllib.urlopen and urllib2 had
exhibited proper behaviour previously. Now, both behaviour will be
consistent now.
But, you are right that an *incorrect* usage of urllib.urlopen would
break in 2.7.2.
If we need to be
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue13856>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
Thanks for submitting the patch. Couple of comments.
1. This is a new feature, so the patch should be addressed against 3.x.
2. The patch lacks tests and documentation and hence it is not complete.
You could take a look at http/client.py or ssl.py (with
Senthil Kumaran added the comment:
>>> urljoin("http://";, "//somedomain.com")
results in "http://somedomain.com";
So, I wonder if this way to specify the relative url properly and not the
base-url.
The test suite of urlparse tries to follow all th
Senthil Kumaran added the comment:
On Sun, Jan 29, 2012 at 10:48:35PM +, Martin v. Löwis wrote:
> orsenthil: I don't fully understand your question (what kind of "carrying"
> should the clients do);
By that I mean, sending the ca_file and cert_reqs from the client,
1001 - 1100 of 2044 matches
Mail list logo
