Neil Girdhar added the comment:
Ready for a code review:
Blocked f(*x for x…) as requested.
Polished up parsermodule.c.
--
Added file: http://bugs.python.org/file37920/starunpack26.diff
___
Python tracker
<http://bugs.python.org/issue2
Neil Girdhar added the comment:
Fixed a bug and added a test.
--
Added file: http://bugs.python.org/file37921/starunpack27.diff
___
Python tracker
<http://bugs.python.org/issue2
Neil Girdhar added the comment:
Is it possible to edit the PEP to reflect the current design decisions?
Specifically:
* Remove: "Because of the new levity for * and ** unpackings, it may be
advisable to lift some or all of these restrictions." (in both abstract and
specification
Changes by Neil Girdhar :
Added file: http://bugs.python.org/file37925/starunpack28.diff
___
Python tracker
<http://bugs.python.org/issue2292>
___
___
Python-bugs-list m
Neil Girdhar added the comment:
Fixed a bug in ceval.c; added a test to test_unpack_ex.
--
___
Python tracker
<http://bugs.python.org/issue2292>
___
___
Python-bug
Changes by Neil Girdhar :
Added file: http://bugs.python.org/file37924/starunpack28.diff
___
Python tracker
<http://bugs.python.org/issue2292>
___
___
Python-bugs-list m
Changes by Neil Girdhar :
Removed file: http://bugs.python.org/file37924/starunpack28.diff
___
Python tracker
<http://bugs.python.org/issue2292>
___
___
Python-bugs-list m
Neil Girdhar added the comment:
Another bug, another test.
--
Added file: http://bugs.python.org/file37926/starunpack29.diff
___
Python tracker
<http://bugs.python.org/issue2
Changes by Neil Girdhar :
Added file: http://bugs.python.org/file38062/starunpack31.diff
___
Python tracker
<http://bugs.python.org/issue2292>
___
___
Python-bugs-list m
Neil Girdhar added the comment:
Thank you, Benjamin.
It's my nature to keep code consistent/clean, but I realize that I can get
carried away. Should I revert all incidental PEP 7 style changes?
Regarding the args/keywords, where do you mean? If you're talking about
compile.c
Neil Girdhar added the comment:
Removed incidental PEP 7 changes and reran tests.
--
Added file: http://bugs.python.org/file38070/starunpack32.diff
___
Python tracker
<http://bugs.python.org/issue2
Neil Girdhar added the comment:
Simplified functools.partial documentation.
--
Added file: http://bugs.python.org/file39561/wn2.diff
___
Python tracker
<http://bugs.python.org/issue24
Changes by Neil Girdhar :
Added file: http://bugs.python.org/file39562/wn2.diff
___
Python tracker
<http://bugs.python.org/issue24136>
___
___
Python-bugs-list mailin
Neil Girdhar added the comment:
I don't receive emails from the tracker anymore either and I have no idea why
that is.
--
___
Python tracker
<http://bugs.python.org/is
Neil Girdhar added the comment:
Copied from closed issue 24240:
Since Grammar/Grammar relies on semantic postprocessing in ast.c,
it would be nice to have an update of the (human readable) Grammar
in the language reference docs.
--
___
Python
New submission from Neil Girdhar:
In the description of the consume recipe:
def consume(iterator, n):
"Advance the iterator n-steps ahead. If n is none, consume entirely."
# Use functions that consume iterators at C speed.
if n is None:
# feed the entire iterator i
Neil Girdhar added the comment:
Ah, good point.
--
___
Python tracker
<http://bugs.python.org/issue24624>
___
___
Python-bugs-list mailing list
Unsubscribe:
Neil Girdhar added the comment:
I'm also looking for bisect with a key argument (numpy array of records, want
to search on one element). However, I don't see bisect in the what's new:
https://docs.python.org/3.6/whatsnew/3.6.html ? Any luck with the
implementation?
-
Neil Girdhar added the comment:
Also, please add the following test: "{*{True, 1}}"
Should be True.
--
___
Python tracker
<http://bugs.python.o
Neil Girdhar added the comment:
Please don't forget to fix BUILD_SET_UNPACK to match.
--
___
Python tracker
<http://bugs.python.org/issue26020>
___
___
Pytho
Neil Girdhar added the comment:
Ah, sorry, I somehow went cross-eyed. Not sure offhand which test would test
the BUILD_TUPLE_UNPACK, but I think you're right Serhiy. Could just add both?
--
___
Python tracker
<http://bugs.python.org/is
Neil Girdhar added the comment:
New changelist for updated patch (before merging changes).
--
Added file: http://bugs.python.org/file38252/starunpack33.diff
___
Python tracker
<http://bugs.python.org/issue2
Neil Girdhar added the comment:
Finished merge.
--
Added file: http://bugs.python.org/file38253/starunpack34.diff
___
Python tracker
<http://bugs.python.org/issue2
Neil Girdhar added the comment:
FWIW I looked at the changes. Does it make sense to run tests before there are
actual tests in lib/Test? I'll happily run all tests when some new ones are
added.
--
nosy: +neil.g
___
Python tracker
Neil Girdhar added the comment:
Removed dead code. Awaiting code review! :)
--
Added file: http://bugs.python.org/file38341/starunpack35.diff
___
Python tracker
<http://bugs.python.org/issue2
Neil Girdhar added the comment:
Nice work Alexander. I believe what's left is for it to work with complex
numbers.
--
nosy: +neil.g
___
Python tracker
<http://bugs.python.org/is
Changes by Neil Girdhar :
Added file: http://bugs.python.org/file38395/starunpack36.diff
___
Python tracker
<http://bugs.python.org/issue2292>
___
___
Python-bugs-list m
Changes by Neil Girdhar :
Added file: http://bugs.python.org/file38429/starunpack37.diff
___
Python tracker
<http://bugs.python.org/issue2292>
___
___
Python-bugs-list m
Changes by Neil Girdhar :
Added file: http://bugs.python.org/file38611/starunpack38.diff
___
Python tracker
<http://bugs.python.org/issue2292>
___
___
Python-bugs-list m
Neil Girdhar added the comment:
Removed a confusing and outdated comment in Lib/importlib/_bootstrap.py
--
Added file: http://bugs.python.org/file38613/starunpack39.diff
___
Python tracker
<http://bugs.python.org/issue2
Changes by Neil Girdhar :
Added file: http://bugs.python.org/file38856/starunpack40.diff
___
Python tracker
<http://bugs.python.org/issue2292>
___
___
Python-bugs-list m
Changes by Neil Girdhar :
Added file: http://bugs.python.org/file39059/starunpack41.diff
___
Python tracker
<http://bugs.python.org/issue2292>
___
___
Python-bugs-list m
Neil Girdhar added the comment:
Hi Steve:
I have limited expertise in most of these areas, but I looked at
starunpack40.diff and have these comments:
* tests look to have good coverage of the feature (can't speak to coverage of
the parser/compiler code)
* parsermodule.c changes comprehe
Neil Girdhar added the comment:
All tests pass. All reviewer comments addressed. Please let me know if
anything else needs to be done from my end.
--
Added file: http://bugs.python.org/file39230/starunpack42.diff
___
Python tracker
<h
Neil Girdhar added the comment:
Just updated the "what's new". Also, thank you for adding my name to
Misc/Acks. Should we also add Joshua Landau's name? He helped me quite a bit
with the implementation, and he wrote the PEP.
--
keywords: +patch
nosy: +nei
New submission from Neil Girdhar:
Minimum working example:
class MyMetaclass(type):
pass
class OtherMetaclass(type):
pass
def metaclass_callable(name, bases, namespace):
return OtherMetaclass(name, bases, namespace)
class MyClass(metaclass=MyMetaclass):
pass
try:
class
Neil Girdhar added the comment:
Oops, I meant:
MyDerived = new_class("MyDerived", (MyClass,),
dict(metaclass=metaclass_callable))
Nevertheless, the exception line number is totally off because it's tripping in
the C code rather than in the Python code of th
Neil Girdhar added the comment:
The documentation suggests that you can have a metaclass that does is not the
"most derived metaclass" provided you specify one that is not an instance of
type. This doesn't work in CPython, so I would suggest fixing the
documentation using the
Neil Girdhar added the comment:
>From your comment:
>>> MyDerivedDynamic = new_class("MyDerivedDynamic", (MyClass,),
>>> dict(metaclass=metaclass_callable))
Traceback (most recent call last):
File "", line 1, in
File "/usr/lib64/python3.5/ty
Neil Girdhar added the comment:
"As a result of this, *both* implementations include a conditional check for a
more derived metaclass in their namespace preparation logic, as well as an
unconditional call to that metaclass derivation logic from type_new if the
calculated metaclass is e
Neil Girdhar added the comment:
Thanks for taking the time to explain, but it's still not working for me:
from types import new_class
class MyMetaclass(type):
pass
class OtherMetaclass(type):
pass
def metaclass_callable(name, bases, namespace):
return new_class(name, bases,
Neil Girdhar added the comment:
Okay, I understand what you're saying, but I it says in the documentation that
"if an explicit metaclass is given and it is not an instance of type(), then it
is used directly as the metaclass". My recent updated "metaclass_callable" is
101 - 142 of 142 matches
Mail list logo
