Larry Hastings added the comment:
> Please look at http://bugs.python.org/issue25779.
You closed that one and marked it "not a bug"...?
--
___
Python tracker
<http://bugs.pytho
Larry Hastings added the comment:
Fixed in 3.5.1 final.
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Larry Hastings added the comment:
I don't agree that a reference cycle counts as a release blocker.
--
nosy: +larry
priority: release blocker -> normal
___
Python tracker
<http://bugs.python.org
Larry Hastings added the comment:
I'm not going to hold up 3.5.1 for this.
--
priority: release blocker -> high
___
Python tracker
<http://bugs.python.org
Larry Hastings added the comment:
I cherry-picked this for 3.5.1.
--
___
Python tracker
<http://bugs.python.org/issue25709>
___
___
Python-bugs-list mailin
Larry Hastings added the comment:
You're a little late; 3.5.1 was released two days ago.
--
___
Python tracker
<http://bugs.python.org/issue24931>
___
___
Larry Hastings added the comment:
Like I said--no.
--
___
Python tracker
<http://bugs.python.org/issue25624>
___
___
Python-bugs-list mailing list
Unsubscribe:
Larry Hastings added the comment:
I'm assuming this is a configuration issue on the buildbots.
--
priority: release blocker -> low
___
Python tracker
<http://bugs.python.org
Larry Hastings added the comment:
I hear your plea. But isn't it almost as easy to just leave it alone? 3.4
won't get many checkins from now on, so it won't actually kick off many tasks.
But it would mean the "check the buildbots" step of making a release would be
Larry Hastings added the comment:
Unless you can explain what bugs this is causing, I don't see any need to
change the behavior.
--
resolution: -> not a bug
status: open -> closed
___
Python tracker
<http://bugs.python.
Larry Hastings added the comment:
How does it break? Maybe you could explain more.
--
___
Python tracker
<http://bugs.python.org/issue25930>
___
___
Python-bug
Larry Hastings added the comment:
Even if this was a good idea, it's too late to change the behavior of the
builtin function.
--
resolution: -> rejected
stage: -> resolved
status: open -> closed
___
Python tracker
<http:
Larry Hastings added the comment:
Nope. Argument Clinic was merged in 3.4, and in 3.3 pwd.getpwuid wouldn't
accept strings. So this isn't a bug introduced in the Clinic conversion in
3.4, this is historical behavior, and we can't change it now.
If anything, I'd pre
Larry Hastings added the comment:
Yeah, change "curl" to "curly". If you commit the fix without a test case I'd
forgive you. Or I can do it if that makes you nervous.
--
___
Python tracker
<http:
Larry Hastings added the comment:
>Modules/_opcode.c: Issue 19674 (3.4). Only one function I can see there
> (Larry’s original post says two sites).
I produced the post with a big grep through the codebase. Which was quite a
while ago now. Code changes and moves around; if you ca
Larry Hastings added the comment:
Christian: Is that CVE the same crash as reported by mail by Gustavo Grieco?
--
___
Python tracker
<http://bugs.python.org/issue26
Larry Hastings added the comment:
I approve in principle, but this patch isn't ready.
If we compile on Win32, and allow_fd is on, and they pass in an invalid fd,
your patched code will reach line 914 "length = PyBytes_GET_SIZE(bytes);" but
bytes will b
Larry Hastings added the comment:
Can you post the updated patch please?
--
___
Python tracker
<http://bugs.python.org/issue26671>
___
___
Python-bugs-list mailin
Larry Hastings added the comment:
LGTM.
--
___
Python tracker
<http://bugs.python.org/issue26671>
___
___
Python-bugs-list mailing list
Unsubscribe:
Larry Hastings added the comment:
You should find a different reviewer. I don't really care about "const". I'll
live with it if it's there but I'm not going to go around adding it.
--
___
Python tracker
<
New submission from Larry Hastings:
Obmalloc now has theoretical support for locking. I say theoretical because
I'm not convinced it's ever been used.
The interface is defined through five macros:
SIMPLELOCK_DECL
SIMPLELOCK_INIT
SIMPLELOCK_FINI
SIMPL
Larry Hastings added the comment:
There's already a comment saying that the macros are empty because the GIL
protects obmalloc from parallelization.
I'd be happy to improve the code and add calls for LOCK_INIT and LOCK_FINI in
the proper places. You don't have to do it. S
Larry Hastings added the comment:
FWIW, the patch still cleanly applies, but now a couple tests in posix fail
because the assertion text has changed.
--
___
Python tracker
<http://bugs.python.org/issue24
New submission from Larry Hastings:
Right now the atomic access fence macros in pyatomic.h are unconditional. This
means that they're active even even when you "./configure --without-threads".
If Python thread support is disabled, surely we don't need to ensure atomic
Larry Hastings added the comment:
Patch attached. The basics were okay; however, there was no locking around
access to a static variable (_Py_AllocatedBlocks) so I added some. The way the
code managed _Py_AllocatedBlocks was a bit odd; this approach resulted in fewer
lines, but it was hard
Larry Hastings added the comment:
Oy veh, in editing the issue I dropped the attached file. Here it is.
--
keywords: +patch
Added file:
http://bugs.python.org/file42479/larry.refresh.lock.macros.for.obmalloc.diff
___
Python tracker
<h
Larry Hastings added the comment:
Yes, I've been working on a patch to do this as well. I called the calling
convention METH_RAW, to go alongside METH_ZERO METH_O etc. My calling
convention was exactly the same as yours: PyObject *(PyObject *o, PyObject
**stack, int na, int nk). I onl
Larry Hastings added the comment:
I did the path_converter change. IIRC some functions supported bytearray, some
did not, and in my quest for consistency I took the superset of functionality
and supported bytearray for everything.
Sounds to me like bytearray support should be dropped, but
Changes by Larry Hastings :
--
nosy: -larry
___
Python tracker
<http://bugs.python.org/issue26825>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Larry Hastings:
So here's a strange one.
I want to do some mysterious experiments with CPython. So I disabled refcount
changes in CPython.
I changed Py_INCR and Py_DECR so they expand to nothing. I had to change some
other macros to match (SETREF, XSETREF, an
Changes by Larry Hastings :
--
versions: +Python 3.6
___
Python tracker
<http://bugs.python.org/issue26891>
___
___
Python-bugs-list mailing list
Unsubscribe:
Larry Hastings added the comment:
I did as you suggested. I also discovered that _Py_NewReference is usually a
macro, and I'd only fixed the version in Objects/object.c (the one not being
used). When I fixed both those things, and switched the makefile so it uses a
different P
Larry Hastings added the comment:
Here is my theory: if the code asserts that it's true, and the code normally
runs fine, then it's normally true, and therefore I can remove the assertion
and the code will run correctly. I haven't hit that assertion in the peephole
optimiz
Larry Hastings added the comment:
I will admit that even during development I rarely used Clinic's test suite.
My test suite is: make a change, then run Clinic over all of CPython and do a
diff. If nothing changed then Clinic is still wo
Larry Hastings added the comment:
This is caused by your "meth_o inline" code, which isn't checked in yet. A
clean checkout of CPython trunk generates this correct code:
if (!PyArg_Parse(arg, "O&:test", PyUnicode_FSConverter, &path))
Maybe you don'
Larry Hastings added the comment:
I'm not excited by this new addition to PEP 7, so I'm excusing myself from this
issue.
--
___
Python tracker
<http://bugs.python.o
Larry Hastings added the comment:
Why is this dependent on #26305?
--
___
Python tracker
<http://bugs.python.org/issue23867>
___
___
Python-bugs-list mailin
Larry Hastings added the comment:
This has nothing to do with Argument Clinic, which is an internal tool used in
the Python 3.x series.
--
components: -Argument Clinic
nosy: -859911096
___
Python tracker
<http://bugs.python.org/issue26
Larry Hastings added the comment:
Christian: any interest in proposing this for 2.7? We could ask Benjamin. It
could still make 2.7.11--rc1 should be tagged in about a month.
--
___
Python tracker
<http://bugs.python.org/issue16
Larry Hastings added the comment:
Summary: read Matt's original message on the bug.
Status: still broken. Some people think it should be left that way.
Proposed fix: it's straightforward to fix. You wrote a patch, I modified yours
a little. The patch is short and ea
Larry Hastings added the comment:
Updated patch based on feedback from Serihy. Thanks for the ping.
--
Added file:
http://bugs.python.org/file42860/larry.make.file_read.use.size_t.2.diff
___
Python tracker
<http://bugs.python.org/issue21
Larry Hastings added the comment:
Martin said:
> Josh: it's not as simple as just changing the type code and variable type.
> Systems used to require all kinds of types in the length parameter of read(2)
> and fread(3), including int, long, and size_t. If it was int, passing s
Larry Hastings added the comment:
Can you give me a test case?
--
___
Python tracker
<http://bugs.python.org/issue23500>
___
___
Python-bugs-list mailin
Larry Hastings added the comment:
Perhaps, now that Guido allows us to redirect into a separate file, we should
simply abandon the two-pass approach.
--
___
Python tracker
<http://bugs.python.org/issue20
Larry Hastings added the comment:
This can wait for 3.5.
--
___
Python tracker
<http://bugs.python.org/issue19075>
___
___
Python-bugs-list mailing list
Unsub
Larry Hastings added the comment:
This is part of the release process. 3.4.3 was fine last I checked, so perhaps
some wonderful automated process broke it for me. 3.5, I think I simply didn't
upload the docs properly.
Anyway, this is my responsibility as RM for 3.4 and 3.5, so in the f
Larry Hastings added the comment:
I turned in my Windows developer badge in 2007. Can I recuse myself,
pretty-please?
How about Tim Golden or Zach Ware? Who I notice are conveniently already added
to the nosy list!
--
___
Python tracker
<h
Larry Hastings added the comment:
I think I've got them all working now. Please reopen if you discover new
breakage. (Or old breakage I guess if I didn't actually fix it...!)
--
resolution: -> fixed
stage: -> resolved
status
Larry Hastings added the comment:
You give me too much credit. I'm the chimp who put it there in the first
place. Though, admittedly, it was a copy&paste job based on the ancient
CObject.
My guess is this was very helpful in 1.4, or
Larry Hastings added the comment:
Yeah, I went ahead and checked this in. I'm living life on the *edge*.
To the EXTREME!
--
assignee: -> larry
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Pyth
Larry Hastings added the comment:
In your sample output we still get two #ifndef SPAM_METHODDEF stanzas.
Wouldn't it be better to only have one?
Maybe Clinic needs to be smarter about generating those anyway. Let me think
about it.
--
___
P
Larry Hastings added the comment:
I can live with that, if you're confident in it and you'll watch the buildbots.
--
___
Python tracker
<http://bugs.python.o
Larry Hastings added the comment:
FWIW I'm tagging alpha 2 somewhere around 24-36 hours from now.
--
___
Python tracker
<http://bugs.python.org/is
Larry Hastings added the comment:
Using it with 3.5.0a2, it still printed the "could not be processed" error
message, but there's a new wrinkle: the one executable it processed, it added
incorrectly. The "-amd64-webinstall" exe was identified as "Win
Larry Hastings added the comment:
Yup.
--
___
Python tracker
<http://bugs.python.org/issue23619>
___
___
Python-bugs-list mailing list
Unsubscribe:
Larry Hastings added the comment:
> Any idea how long until the CDN picks up the update?
curl -X PURGE https://www.python.org/ftp/python/2.7.5/Python-2.7.5.tar.xz
will explicitly tell the CDN to pick up the new binaries. Not sure if that
works from anywhere or just from dl-files.iad1.psf
Larry Hastings added the comment:
Okay, I refreshed the MD5 sums and sizes on the web site, and purged the old
files from the CDN.
--
___
Python tracker
<http://bugs.python.org/issue23
Larry Hastings added the comment:
My inclination is 3.5 only. Barry, do you want to argue for this going into
3.4?
--
___
Python tracker
<http://bugs.python.org/issue23
Larry Hastings added the comment:
Oh, I read the code. But it's a performance hack, and the rules say we only
accept security fixes and bug fixes at this stage of the release, and they're
the rules for good reasons.
--
___
Python trac
Larry Hastings added the comment:
How about this approach? Only ever emit the #ifndef stanza once per symbol.
--
Added file:
http://bugs.python.org/file38491/larry.ac_multiple_macro_definitions.diff.1.txt
___
Python tracker
<http://bugs.python.
Larry Hastings added the comment:
(see larry.ac_multiple_macro_definitions.diff.1.txt posted above)
--
___
Python tracker
<http://bugs.python.org/issue23
Larry Hastings added the comment:
Oops, I should have run "make clinic", so you could see all the changes that
result from this patch.
--
Added file:
http://bugs.python.org/file38492/larry.ac_multiple_macro_definitions.diff.2.txt
___
Pyth
Larry Hastings added the comment:
What do you think of this approach? Now a "Destination" object behaves like an
array of text accumulators. If you ask for one that doesn't exist it's created
for you. When the Destination is dumped, the output from each accumulator is
j
Larry Hastings added the comment:
I read it quickly. It looks basically okay, but I have one issue to discuss
right now. Changing from the format unit 'O!' and calling "getuchar" to the
format unit 'C' means a change in semantics. The text in the exceptio
Larry Hastings added the comment:
I want to redo it--it's smelly. I hope to get it done this week.
--
___
Python tracker
<http://bugs.python.org/is
Larry Hastings added the comment:
As promised, here's a cleaned-up version of the patch. The taxonomy of objects
now makes sense: a Destination contains a BufferSeries object, rather than
Destinations weirdly supporting __getitem__ to reference different objects.
I tripped over mys
Larry Hastings added the comment:
I did, I just didn't respond. I'll do that now.
--
___
Python tracker
<http://bugs.python.org/issue23500>
___
___
Larry Hastings added the comment:
Updated patch, removed all references to two-pass. Also realized I needed to
make the default behavior for methoddef_ifndef go to the end. And, finally, I
forgot to merge the "only print each #ifndef block once" code I wrote before
when I redid
Larry Hastings added the comment:
Does this really need a backport to 3.4?
--
___
Python tracker
<http://bugs.python.org/issue23500>
___
___
Python-bugs-list m
Larry Hastings added the comment:
Removing 3.4 from the version list as I close the bug, then. If we decide we
need it backported please reopen (or create a new bug, either is fine).
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
versions:
Larry Hastings added the comment:
Thanks! I've been meaning to follow up on this. I think CPython should be
consistent, one way or another. So I support this change.
--
___
Python tracker
<http://bugs.python.org/is
New submission from Larry Hastings:
I was staring at Clinic tonight and a thought came to me. We could express
"nullable=True" as "types='NoneType'". For example, the converter for 'Z'
could change from
Py_UNICODE(nullable=True)
to
Py_UNICOD
Larry Hastings added the comment:
Saying that "str" is redundant makes me think you don't understand what "types"
does. "types" accepts a text string listing all of the Python types the
converter accepts. You can accept the converter's default, or
New submission from Larry Hastings:
tl;dr: skipitem() in Python 3 still supports "w" and "w#", which were
abandoned. They should be removed.
--
If:
* you have an extension that parses its arguments with
PyArg_ParseTupleAndKeywords (or its cousins),
* you have
New submission from Larry Hastings:
tl;dr: skipitem() in Python/getsargs.c doesn't know about the 'w*' format unit,
which could lead to a crash. It should know about it.
--
If:
* you have an extension that parses its arguments with
PyArg_ParseTupleAndKeywords (or its cousi
Larry Hastings added the comment:
Would this qualify as an "easy" bug we could throw to a sprinter?
--
___
Python tracker
<http://bugs.python.o
Larry Hastings added the comment:
I finally talked to someone (Thomas Wouters) about this. For something going
into trunk that will be part of 3.5, this is fine.
Please include a mention that the exception's text messages changed in
Misc/NEWS. I can help you write this if you want.
New submission from Larry Hastings:
Clinic was previously pretty confused about what things accepted "bytes",
"bytearray", "buffer", "robuffer", and "rwbuffer". This is because the
documentation itself was somewhat confusing.
The docum
Larry Hastings added the comment:
Huh. Why didn't it attach my patch? Here it is.
--
Added file:
http://bugs.python.org/file38933/larry.clinic.buffer.conceptual.cleanup.1.txt
___
Python tracker
<http://bugs.python.org/is
Larry Hastings added the comment:
LGTM, just adding Antoine (the expert for the socket module). I'm ready to
commit over here.
--
nosy: +pitrou
___
Python tracker
<http://bugs.python.org/is
Larry Hastings added the comment:
Updated the patch a little, to make it enforce compatible "types" parameters.
The previous patch had some functions that would permit passing in "types='blah
de blah'" or other nonsense.
--
Added file:
ht
Larry Hastings added the comment:
Follow the instructions in this:
https://docs.python.org/devguide/docquality.html
And make it look something like this:
https://docs.python.org/3/library/socket.html#socket.CAN_BCM
--
___
Python tracker
<h
Larry Hastings added the comment:
Patch committed. Thanks, Joe!
--
assignee: -> larry
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python
Larry Hastings added the comment:
LGTM
--
assignee: -> zach.ware
___
Python tracker
<http://bugs.python.org/issue20586>
___
___
Python-bugs-list mai
Larry Hastings added the comment:
If you give me a test case I'll knock this out.
--
___
Python tracker
<http://bugs.python.org/issue23944>
___
___
Pytho
Larry Hastings added the comment:
Isn't this a "new feature"? 2.7 is maybe fair game, but 3.4 arguably is not.
It should be odd to have a field marked in the documentation as "New in 3.4.4."
--
___
Python tracker
<http:
Larry Hastings added the comment:
Benjamin, would you like CAN_RAW_FD_FRAMES in the next 2.7?
--
nosy: +benjamin.peterson
___
Python tracker
<http://bugs.python.org/issue22
New submission from Larry Hastings:
My laptop is running 64-bit Linux (14.10). It has 4.6GB of free disk space.
Naturally that's not enough to run test_mmap.
When I run the test suite, test_mmap consumes all available disk space, then
fails. (Hopefully freeing all its temporary files!
Larry Hastings added the comment:
New patch revision, including the new API change (the "types" argument to a
constructor must now be a set of strings).
--
Added file:
http://bugs.python.org/file39001/larry.clinic.buffer.conceptual.cle
Larry Hastings added the comment:
I wish the Python bug tracker had a way of attaching files to issues, so we
didn't have to just copy and paste into and out of the comments. Ah well,
wishful thinking!
--
___
Python tracker
Larry Hastings added the comment:
That's AMAZING, you mean the web site knew how to do that THE WHOLE TIME?
--
___
Python tracker
<http://bugs.python.org/is
Larry Hastings added the comment:
Attached is a patch. This causes a lot of churn, darn.
Should I copy & paste the patch into this text box too? Maybe that would be
more convenient!
--
Added file:
http://bugs.python.org/file39008/larry.clinic.wrap.long.impl.decls.1
Larry Hastings added the comment:
Okay, this patch is about half the size. I had a bug that was throwing away
some important syntax. With this patch applied, Python builds and the test
suite is as reasonable as usual.
I swear, C compilers are so fussy sometimes!
--
Added file
Changes by Larry Hastings :
--
assignee: -> larry
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python
Larry Hastings added the comment:
ZFS.
--
___
Python tracker
<http://bugs.python.org/issue23953>
___
___
Python-bugs-list mailing list
Unsubscribe:
Larry Hastings added the comment:
Wall time was 3 minutes 38 seconds.
% time ./python -m test test_mmap
[1/1] test_mmap
test test_mmap failed -- multiple errors occurred; run in verbose mode for
details
1 test failed:
test_mmap
./python -m test test_mmap 0.40s user 22.41s system 10% cpu 3
Larry Hastings added the comment:
In the case of namedtuple and Enum, the parameter represents a sequence of
strings--order is significant. With the 'types' parameter for converters, the
internal model was always meant to be a *set* of strings. The order was
explicitly *not* s
Larry Hastings added the comment:
Latest patch, with another round of lovely comments from Serhiy.
--
Added file:
http://bugs.python.org/file39030/larry.clinic.buffer.conceptual.cleanup.4.txt
___
Python tracker
<http://bugs.python.org/issue23
Larry Hastings added the comment:
If
* the diff looks clean
* it compiles without any *new* (sigh) errors, and
* it passes the unit test suite without any *new* (sigh) failures,
then the Clinic conversion can generally be considered a success
New submission from Larry Hastings:
Peter's working on converting socket to use Argument Clinic. He had a default
that really should look like this:
min(SOME_SOCKET_MODULE_CONSTANT, 128)
"min" wasn't something we'd needed before. I thought about it and rea
2201 - 2300 of 2415 matches
Mail list logo
