Larry Hastings added the comment:
Anything happening with this? We tag 3.5.0rc3 in about 36 hours.
--
___
Python tracker
<http://bugs.python.org/issue24
Larry Hastings added the comment:
Anything happening with this? We tag 3.5.0rc3 in about 36 hours.
--
___
Python tracker
<http://bugs.python.org/issue24
Larry Hastings added the comment:
I've remarked it as "normal" priority and moved it to 3.6. Not my problem
anymore! :D
--
priority: deferred blocker -> normal
versions: +Python 3.6 -Python 3.4, Python 3.5
___
Pyt
Changes by Larry Hastings :
--
nosy: -larry
___
Python tracker
<http://bugs.python.org/issue21998>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Larry Hastings :
--
priority: deferred blocker -> high
___
Python tracker
<http://bugs.python.org/issue24635>
___
___
Python-bugs-list mai
Larry Hastings added the comment:
The pull requests are numbered by creation order, not by merge order.
Normally I'd expect that yes, Serhiy's merge would include yours. But it
didn't work out that way. If you look at the changeset graph:
https://bitbucket.org/larry/cpython
Larry Hastings added the comment:
There won't be conflicts with Serhiy's merge--just the opposite. His pull
request was merged first, so it's perfect that he did his forward merge first.
He's already resolved any conflicts with his merge, and so when you merge
you
Larry Hastings added the comment:
Pull request accepted. Please forward merge, thanks!
And, yes, this will be a null merge because you already separately committed it
to 3.5.
--
assignee: larry -> gvanrossum
stage: needs patch -> resolved
status: open -&g
Larry Hastings added the comment:
Yes, I'd like this fix in 3.5.0.
One bit of feedback on the patch: outbuf is a char * (or wchar_t *), therefore
outbuf[1] is a char (or wchar_t). You shouldn't compare it to NULL. I'm not
sure we still support any compilers that define NU
Larry Hastings added the comment:
Rather than debating about how various platforms handle malformed format
strings for strftime(), and whether or not they crash, we should simply prevent
the native strftime() function from seeing them in the first place.
I'd like the "v3" pa
Larry Hastings added the comment:
Okay. Right now creating server-side clones is broken. So I have repurposed
one of my existing (old, dead) server-side clones for testing this. It's
called "ssh://h...@hg.python.org/larry/path_error2".
I just fired off this change on
Larry Hastings added the comment:
Because the BDFL asked that it be so.
--
___
Python tracker
<http://bugs.python.org/issue24912>
___
___
Python-bugs-list mailin
Larry Hastings added the comment:
Pull request accepted. Please forward-merge. Thanks!
--
___
Python tracker
<http://bugs.python.org/issue24917>
___
___
Pytho
Larry Hastings added the comment:
Pull request accepted. I had to do it manually, as I got a Misc/NEWS merge
conflict. But from where I'm sitting it looks like Bitbucket understands the
pull request was accepted and merged.
Please forward-merge. T
Changes by Larry Hastings :
--
assignee: -> ncoghlan
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python
Larry Hastings added the comment:
The tests from this patch fail on Linux.
-
First: There is no trailing % test on Linux, and glibc's strftime() happily
ignores a trailing %, so no ValueError is raised.
Python should do either one or the other of the following:
1) Python should en
Larry Hastings added the comment:
The starting curly brace goes on the same line as the statement starting the
block. Keywords followed by a left parenthesis get a space between the keyword
and the parenthesis. It's a small matter, I'm really much more interested in
reconciling th
Larry Hastings added the comment:
Sorry, maybe you inherited those violations. I was in a hurry and not in a
charitable frame of mind.
--
___
Python tracker
<http://bugs.python.org/issue24
Larry Hastings added the comment:
I have convinced myself that disallowing trailing % marks on all platforms is
the right thing to do. Whether or not the underlying platform tolerates it, it
is never *valid* input to strftime.
I have a patch incubating at home. I'll put it up for r
Larry Hastings added the comment:
Oh, maybe it was all like that before. Sorry, I was in a hurry and not in a
charitable frame of mind.
--
___
Python tracker
<http://bugs.python.org/issue24
Larry Hastings added the comment:
I'm going to back this out of 3.5.0rc3. I'm still willing to discuss accepting
it into 3.5.0 final in some form, but for now I don't want to hold up the
release.
Steve: it should never be possible to crash the Python interpreter with
well-for
Larry Hastings added the comment:
It was basically okay on the buildbots--no worse than cpython would have been
before the checkin. (A lot of the buildbots are... wonky.)
I checked it in to cpython350 directly. I'll do the forward merge after
3.5.0rc3 goes out the
Changes by Larry Hastings :
--
priority: release blocker -> deferred blocker
___
Python tracker
<http://bugs.python.org/issue24917>
___
___
Python-bugs-list mai
Larry Hastings added the comment:
Marking as closed for now. If we decide it's a problem we can reopen later.
--
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.
Larry Hastings added the comment:
I don't think it'd be appropriate to backport to 3.4--that ship has sailed.
3.4 requires a stacklevel=8 and that's that.
If we backported it and it shipped in 3.4.4, "correct" code would have to use a
stacklevel=8 for 3.4.0 throug
Changes by Larry Hastings :
--
priority: release blocker -> deferred blocker
___
Python tracker
<http://bugs.python.org/issue25005>
___
___
Python-bugs-list mai
Larry Hastings added the comment:
Marking this as deferred, as I'm not convinced I should ship either of those
patches in 3.5.0rc3.
--
nosy: +larry
___
Python tracker
<http://bugs.python.org/is
Larry Hastings added the comment:
What happened with this?
--
___
Python tracker
<http://bugs.python.org/issue24585>
___
___
Python-bugs-list mailing list
Unsub
Larry Hastings added the comment:
Yes, I saw that. That doesn't mean we should change the interface they are
using (incorrectly) eighteen months after it shipped. We take
backwards-compatibility pretty seriously here in the Python world, bugs an
Larry Hastings added the comment:
Unless I'm overruled, yes.
--
___
Python tracker
<http://bugs.python.org/issue24305>
___
___
Python-bugs-list mailing list
Larry Hastings added the comment:
Having slept on it, I agree with Steve. We should make the minimal change
necessary in order to not crash.
However, it still needs a regression test. The test can use JohnLeitch's
proposed test as a good starting point, but it must accept either succe
Larry Hastings added the comment:
I want to ship something, but I don't think it'll be either of those patches in
their current form.
Maybe I'm dense, but I don't feel like I understand these patches. They have
very different approaches.
The first one attempts to rehab
Larry Hastings added the comment:
Steve, did you confirm that the test triggers the array bounds bug when the
patch *isn't* applied? I want to confirm both that a) the test exercises the
bug, and b) the fix fixes the bug. I assume you ran the test suite with the
patch applied, so
Larry Hastings added the comment:
Okay, I think *I* reproduced it.
1) I pulled your cpython350 fork down locally.
2) I updated to your checkin that fixed the bug. (c31dad22c80d)
3) I reverted the change to Modules/timemodule.c to put the bug back:
% hg cat -r 97393 Modules/timemodule.c
Larry Hastings added the comment:
So is this considered broken enough that I need to accept a fix for 3.5.0? And
has a consensus been reached about exactly what that fix would be?
--
___
Python tracker
<http://bugs.python.org/issue23
Larry Hastings added the comment:
Reassigning to 3.6.
--
priority: deferred blocker -> release blocker
versions: +Python 3.6 -Python 3.4, Python 3.5
___
Python tracker
<http://bugs.python.org/issu
Larry Hastings added the comment:
I'm leaving this open just because we're apparently waiting on some "What's
New" docs.
--
___
Python tracker
<http:
Larry Hastings added the comment:
Well, I'm already holding up rc3 on one other issue, might as well fix this
too. Can somebody make me a pull request?
--
___
Python tracker
<http://bugs.python.org/is
Larry Hastings added the comment:
I suspect we're not fixing this in 3.4, so I'm removing 3.4 from the version
list.
--
versions: -Python 3.4
___
Python tracker
<http://bugs.python.o
Larry Hastings added the comment:
So, whatever the security hole is that subprocess.call(shell=True) leaves open,
os.startfile() doesn't have? os.startfile() doesn't use a shell? (How does it
find the full path to the executable?)
--
Larry Hastings added the comment:
Well, so, what do you recommend I do here?
--
___
Python tracker
<http://bugs.python.org/issue25005>
___
___
Python-bugs-list m
Larry Hastings added the comment:
Backout pull request merged, please forward-merge, thanks!
--
___
Python tracker
<http://bugs.python.org/issue24917>
___
___
Larry Hastings added the comment:
Backout pull request merged, please forward-merge, thanks!
--
___
Python tracker
<http://bugs.python.org/issue25005>
___
___
Larry Hastings added the comment:
(I meant, just normal pull request. I did your two pull requests right in a
row and got my wires crossed.)
--
___
Python tracker
<http://bugs.python.org/issue24
Larry Hastings added the comment:
Okay, this is literally the only thing rc3 is waiting on now.
--
___
Python tracker
<http://bugs.python.org/issue23517>
___
___
Changes by Larry Hastings :
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Larry Hastings :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue25005>
___
___
Larry Hastings added the comment:
This was backed out of 3.5, as we discovered it introduced a security hole just
before 3.5.0 shipped. (See issue 25005 for more.)
Since it's been backed out, I've reopened the issue. However I've moved it
forward to 3.6, as it's no lon
Changes by Larry Hastings :
--
nosy: -larry
___
Python tracker
<http://bugs.python.org/issue8232>
___
___
Python-bugs-list mailing list
Unsubscribe:
Larry Hastings added the comment:
Is it appropriate to make this change as a "bug fix", in already-released
versions of Python? Would you be happy or sad if you updated your Python from
3.x.y to 3.x.y+1 and the rounding method used when converting floats to
datetime stam
Larry Hastings added the comment:
Well, for now I assume it really truly genuinely isn't going in 3.5.0. I
suppose we can debate about 3.4.x and 3.5.1 later, once we have a fix everybody
is happy with.
--
___
Python tracker
Larry Hastings added the comment:
If the guy doing the work says "don't merge it in 3.5.0", and we're at the
final release candidate before 3.5.0 final ships, and we don't even have a
patch that everyone likes yet... it does seem like it's not going to happen fo
Larry Hastings added the comment:
Doc fixes are always welcome. Barring mishaps I should tag 3.5.0 final on
Saturday; it'd be sweet if you could get me your diff no later than Friday
night.
--
___
Python tracker
<http://bugs.python.org/is
Larry Hastings added the comment:
I fixed it. My original attempted hack had bad regular expressions. Once my
regular expressions worked properly it was all fine.
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -&g
Larry Hastings added the comment:
This is your wheelhouse, Steve.
--
assignee: -> steve.dower
___
Python tracker
<http://bugs.python.org/issue25027>
___
___
Py
Larry Hastings added the comment:
Any clue here? Is this unaligned access?
--
___
Python tracker
<http://bugs.python.org/issue25029>
___
___
Python-bugs-list m
Larry Hastings added the comment:
I'm the author of capsulethunk.h, and I am happy to relicense it under MIT.
How would you feel about leaving capsulethunk.h there, for posterity's sakes,
but adding "for updates please see py3c"? We could even update the
capsulethunk.h th
Larry Hastings added the comment:
I wish people wouldn't remove old patches. There's no harm in leaving them,
and it may be a useful historical record.
--
___
Python tracker
<http://bugs.python.o
Larry Hastings added the comment:
Does this need a Misc/NEWS entry?
--
___
Python tracker
<http://bugs.python.org/issue25029>
___
___
Python-bugs-list mailin
Changes by Larry Hastings :
--
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue25027>
___
___
Python-bugs-list mailing list
Unsubscrib
Larry Hastings added the comment:
Given Victor's reluctance to get this in to 3.5.0, this can't even be marked as
a "deferred blocker" anymore. Demoting to normal priority.
--
priority: deferred blocker -> normal
__
Larry Hastings added the comment:
Here's an attempt at a What's New section for this change. I expect it's
wrong! Maybe someone can fix it. Maybe it's actually better than not having
one at all.
Can we maybe get a round or two of edits on this and get somethi
Larry Hastings added the comment:
Given Victor's reluctance to get this in to 3.5.0, this can't even be marked as
a "deferred blocker" anymore. Demoting to normal priority.
--
priority: deferred blocker -> normal
__
Larry Hastings added the comment:
The Misc/NEWS entry for this was added under Python 3.5.0rc3. But, since no
pull request has been made for this change, this change hasn't been merged into
3.5.0. It will ship as part of Python 3.5.1. I've moved the Misc/NEWS entry
a
Larry Hastings added the comment:
Pull request accepted! Please forward-merge, thanks!
--
___
Python tracker
<http://bugs.python.org/issue24272>
___
___
Pytho
Larry Hastings added the comment:
Pull request approved. Hopefully the last one for 3.5.0! Please forward-merge.
--
___
Python tracker
<http://bugs.python.org/issue25
Larry Hastings added the comment:
Pull request accepted. Please forward-merge, thanks!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Larry Hastings added the comment:
It's fixed! So it's finally closed.
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs
Larry Hastings added the comment:
You wait until the day of release for 3.5.0 final, then create a "release
blocker" because some items in the What's New documentation aren't
lexographically sorted?
We tagged the release yesterday. The installers are already built. I am
Larry Hastings added the comment:
First, the What's New on the website is generated from the 3.5 branch in
hg.python.org. So it's already up-to-date. That's the one most people will
refer to.
Second, if the What's New was really that horribly out of date, and we wanted
Larry Hastings added the comment:
I'm hoping to release 3.5.0 final in the next hour or two. I don't want to
hold up the release for your changes. However, when you're done making changes
to the document, and they're all checked in, let me know and I'll manually
bu
Larry Hastings added the comment:
The "Detailed Release Information" link is correct. You probably just have an
old cached copy of something.
I could add a "What's New" link somewhere.
Though both of these things are interesting, neither of them is relevant to
thi
Larry Hastings added the comment:
I don't know how to do it. I asked the Documentation Expert member of the
Python 3.5 release team, but it seems he's afk at the moment. I'm trying to
find someone else who knows how to do it.
--
___
Larry Hastings added the comment:
Tracebacks aren't my forte, but this does smell like a regression and something
that should be fixed.
My worry about things like this is that it isn't as much a "bug" as a "badly
implemented interface". As in, that's th
Larry Hastings added the comment:
Old version stuck in the CDN cache. I cleared the cache, it's fine now.
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.pyth
Larry Hastings added the comment:
When I built the documentation, I used
% release.py --export 3.5.0
(release.py coming from hg.python.org/release, a collection of release manager
tools.) I then installed this build as the 3.5.0 documentation, specifically
the build from "python-
Larry Hastings added the comment:
Python 3.5 is not supported on Windows XP.
The Python core dev team's policy is, a major Python version (e.g. 3.4, 3.5)
only supports the Windows versions that are currently supported by Microsoft at
the time of the initial release (e.g. 3.4.0 final,
Larry Hastings added the comment:
Is this a change (I hesitate to use the word "regression") as of Python 3.5.0?
--
nosy: +larry
___
Python tracker
<http://bugs.python.o
Larry Hastings added the comment:
That's an interesting thought, eryksun. I'll pass it along to the python.org
web developers.
Djoudi, it is mentioned on the Python web site, in the What's New In Python 3.5
document:
https://docs.python.org/3.5/whatsnew/3.5.html#unsupp
Larry Hastings added the comment:
Well, even if the Windows build was on fire and children were dying, we
couldn't do anything about it until next week--Steve's on vacation. I expect
he'll weigh in on this when he gets back.
--
___
Larry Hastings added the comment:
They don't go there, they go in https://docs.python.org/3.5/archives/
Where is the documentation that this
"https://www.python.org/ftp/python/doc/3.5.0/"; directory is an officially
supp
Larry Hastings added the comment:
The official way to download the documentation is from this page:
https://docs.python.org/3.5/download.html
which links to the "archives" directory.
When python.org changed to the new site, some things moved around. I guess
this was one of th
Changes by Larry Hastings :
--
nosy: +larry
___
Python tracker
<http://bugs.python.org/issue18967>
___
___
Python-bugs-list mailing list
Unsubscribe:
Larry Hastings added the comment:
Okay. I got tired of the constant Misc/NEWS merge conflicts, so I wrote a tool
to fix the problem. It's checked in to Bitbucket here:
https://bitbucket.org/larry/mergenews/
There's a readme, which you'll see rendered on that page.
I don&
Larry Hastings added the comment:
In case you're too lazy to go visit the link to my "mergenews" repository and
read the readme...
mergenews has three tools:
* splitnews, which splits the existing Misc/NEWS file into hundreds of
individual files,
* mergenews, which merges
Larry Hastings added the comment:
> [...] commit messages are for other developers, which news entries are
> ultimately for users. Some developers want (insist on) the freedom to
> make the two different, with different details.
That's easy enough to accommodate. I updated &q
Larry Hastings added the comment:
I don't agree that in all cases the Misc/NEWS entry and the checkin comment
must be wholly different. While I concur that that's called for now and again,
I believe this to be rare. Most checkins are small changes, and a single-line
summary for
Larry Hastings added the comment:
Why is this marked as a release blocker? It doesn't strike me as all that
major.
--
___
Python tracker
<http://bugs.python.org/is
Larry Hastings added the comment:
Describing this as a "security sensitive issue" is being facile. It's more
appropriate to describe this as a "new feature", aka, something that does not
go in after x.y.0 final.
Please only check this
Larry Hastings added the comment:
I should clarify, I don't speak for 2.7. The rules there are a little
different and it's up to Benjamin to decide. But please don't add new features
to 3.4 and 3.5.
--
___
Python tracker
<http
Larry Hastings added the comment:
I think it's about time to think about releasing 3.5.1. But since this bug is
marked as a "release blocker", 3.5.1 cannot be released until this is fixed.
Arguably I can't even really make a schedule for 3.5.1 until it's fixed, or
Larry Hastings added the comment:
Okay, I'm scheduling 3.5.1rc1 on the assumption that you'll check in by next
weekend. If you're going to slip please let me know and I'll slip accordingly.
--
___
Python tracker
<http://bug
Larry Hastings added the comment:
I don't plan to hold up 3.5.1 for this.
--
priority: release blocker -> normal
___
Python tracker
<http://bugs.python.org
Changes by Larry Hastings :
--
priority: release blocker -> normal
___
Python tracker
<http://bugs.python.org/issue25660>
___
___
Python-bugs-list mai
Larry Hastings added the comment:
The "release blocker" priority level is inappropriate for nice-to-have
features. Quoting PEP 101, the how-to-make-a-Python-release guide:
release blocker - Stops the release dead in its tracks. You may
not make any releas
Larry Hastings added the comment:
This change didn't make it into 3.5.1. It will be released with 3.5.2. I've
already updated the Misc/NEWS entry.
--
nosy: +larry
___
Python tracker
<http://bugs.python.o
Larry Hastings added the comment:
This change didn't make it into 3.5.1. It will be released with 3.5.2. I've
already updated the Misc/NEWS entry.
--
___
Python tracker
<http://bugs.python.o
Larry Hastings added the comment:
I read some comments here and on the patches. Serhiy's patch adds some code
and Victor says you can't call that macro on this object and wow this is badly
broken. Can someone explain in simpler terms what's so
Larry Hastings added the comment:
Is this going in soon? I want to cherry-pick this for 3.5.1, which I tag in
about 80 hours.
--
___
Python tracker
<http://bugs.python.org/issue25
Larry Hastings added the comment:
You can have it in 3.5.1, and we can negotiate about how to get it in.
--
___
Python tracker
<http://bugs.python.org/issue25
2101 - 2200 of 2415 matches
Mail list logo