Larry Hastings added the comment:
New changeset 2f2b69855d6524e15d12c15ddc0adce629e7de84 by larryhastings in
branch 'master':
bpo-43901: Lazy-create an empty annotations dict in all unannotated user
classes and modules (#25623)
https://github.com/python/cpyt
Larry Hastings added the comment:
Thanks for your feedback and reviews, everybody! Python just got an eensy
teensy tiny bit better.
--
assignee: -> larry
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
__
Larry Hastings added the comment:
Thanks for the review, Victor!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Larry Hastings added the comment:
New changeset 74613a46fc79cacc88d3eae4105b12691cd4ba20 by larryhastings in
branch 'master':
bpo-43817: Add inspect.get_annotations(). (#25522)
https://github.com/python/cpython/commit/74613a46fc79cacc88d3eae4105b12
Larry Hastings added the comment:
Thanks for your feedback, everybody! It's now checked in.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.pyth
New submission from Larry Hastings :
Dealing with annotations is complicated. I think there should be a section of
the Python documentation describing best practices for working
with annotations. So, here goes.
The best spot I found for it was as a new HOWTO. I added links to that HOWTO
Change by Larry Hastings :
--
keywords: +patch
pull_requests: +24436
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/25746
___
Python tracker
<https://bugs.python.org/issu
Change by Larry Hastings :
--
nosy: +Jelle Zijlstra
___
Python tracker
<https://bugs.python.org/issue43987>
___
___
Python-bugs-list mailing list
Unsubscribe:
Larry Hastings added the comment:
Gee whiz! Sorry about that. I swear, it works fine on my machine.
I'll incorporate import_helper.import_fresh_module helper into the test as you
suggest, and once I get it to work I'll send you a PR. I don't know how to
test fixing this
Change by Larry Hastings :
--
pull_requests: +24442
stage: resolved -> patch review
pull_request: https://github.com/python/cpython/pull/25752
___
Python tracker
<https://bugs.python.org/issu
Larry Hastings added the comment:
Eek! I swear I did a refleak check and got a clean bill of health. Again,
sorry about this!
--
___
Python tracker
<https://bugs.python.org/issue43
Larry Hastings added the comment:
You want a separate PR for the refleak fix, or should I roll them both up into
one?
--
___
Python tracker
<https://bugs.python.org/issue43
Larry Hastings added the comment:
Obviously the original assertion failure ("AssertionError: False is not true")
wasn't caused by the refleaks. So I'm still puzzled about why that test worked
on POSIX and failed on Windows. I admit I was pulling some wacky import
she
Larry Hastings added the comment:
Ah, I see. So it wasn't a Windows thing, it was a "we run the test multiple
times and that particular test assumed it was only run once" thing. And
reflink testing is guaranteed to run every test
Larry Hastings added the comment:
New changeset 49b26fa517165f991c35a4afcbef1fcb26836bec by larryhastings in
branch 'master':
bpo-43987: Add "Annotations Best Practices" HOWTO doc. (#25746)
https://github.com/python/cpython/commit/49b26fa517165f991c35
Larry Hastings added the comment:
Thanks to Jelle for an enormous amount of reviewing and re-reviewing! That was
just spiffy.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracke
Larry Hastings added the comment:
"Type hints" and "annotations" aren't the same thing. And type hints are more
opinionated about the values of annotations than would be appropriate for the
inspect module. For example, typing.get_type_hints() wraps strings with
Fo
Change by Larry Hastings :
--
nosy: -larry
___
Python tracker
<https://bugs.python.org/issue37923>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Larry Hastings :
--
nosy: -larry
___
Python tracker
<https://bugs.python.org/issue36216>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Larry Hastings :
--
nosy: -larry
___
Python tracker
<https://bugs.python.org/issue22018>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Larry Hastings :
--
nosy: -larry
___
Python tracker
<https://bugs.python.org/issue25782>
___
___
Python-bugs-list mailing list
Unsubscribe:
Larry Hastings added the comment:
This is not a bug, you are asking for programming help. Please don't use the
Python issue tracker for programming help. You won't get any, you'll just
waste people's time.
--
components: -Argument Clinic, FreeBSD, IO, Inter
Larry Hastings added the comment:
Since nobody's said so in so many words (so far in this thread anyway): the
prototype from Jeethu Rao in 2018 was a different technology than what Eric is
doing. The "Programs/_freeze_importlib.c" Eric's playing with essentially
inli
Larry Hastings added the comment:
There should be a boolean flag that enables/disables cached copies of .py files
from Lib/. You should be able to turn it off with either an environment
variable or a command-line option, and when it's off it skips all the internal
cached stuff and use
Larry Hastings added the comment:
> What the two approaches have in common is that they require rebuilding the
> python binary whenever you edit any of the changed modules. I heard somewhere
> (I'm sorry, I honestly don't recall who said it first, possibly Eric himsel
Larry Hastings added the comment:
Removing it makes sense to me. Not sure what I was thinking, way back when.
Thanks for catching--and volunteering to fix--this!
--
___
Python tracker
<https://bugs.python.org/issue45
Larry Hastings added the comment:
Nope. On Windows, os.path is "ntpath".
--
___
Python tracker
<https://bugs.python.org/issue45020>
___
___
Python-b
Larry Hastings added the comment:
FWIW the test still fails in exactly the same way. This was building with
main, on Pop!_OS 21.04 64-bit.
--
___
Python tracker
<https://bugs.python.org/issue31
Larry Hastings added the comment:
I finally have some bandwidth to look at this--sorry for being a bit slow.
I wasn't able to reproduce, because the patch didn't apply cleanly. I
downloaded the patch (
https://patch-diff.githubusercontent.com/raw/GrahamDumpleton/wrapt/pull/187.pa
Larry Hastings added the comment:
I got the PR locally, but the command-line you gave me fails, tox can't find
python3.10 despite it being on the path.
Rather than force me to reverse-engineer and recreate your build environment,
can you give me a straightforward command-line or
Larry Hastings added the comment:
(Preferably not using "tox". I don't know that tool.)
--
___
Python tracker
<https://bugs.python.org/issue45319>
___
__
New submission from Larry Hastings :
>From 3/4 of the team that brought you BLAKE2, now comes... BLAKE3!
https://github.com/BLAKE3-team/BLAKE3
BLAKE3 is a brand new hashing function. It's fast, it's paralellizeable, and
unlike BLAKE2 there's only one variant.
I've
Larry Hastings added the comment:
For what it's worth, I spent some time producing clean benchmarks. All these
were run on the same laptop, and all pre-load the same file (406668786 bytes)
and run one update() on the whole thing to minimize overhead. K12 and BLAKE3
are using a
Larry Hastings added the comment:
According to my order details it is a "8th Generation Intel Core i7-8650U".
--
___
Python tracker
<https://bugs.python.o
Larry Hastings added the comment:
I gave it a go. And yup, I see a definite improvement: it jumped from
1,583,326,242 bytes/sec to 2,376,741,703 bytes/sec on my Intel laptop using
AVX2. A 50% improvement!
I also *think* I'm seeing a 10% improvement in ARM using NEON. On my DE10
Larry Hastings added the comment:
I just tried it with clang, and uff-da! 2,737,446,868 bytes/sec!
p.s. I compiled with -O3 for both gcc and clang
--
___
Python tracker
<https://bugs.python.org/issue39
Larry Hastings added the comment:
I don't think this is fixable, because it's not exactly a bug. The problem is
we're running out of bits. In converting the time around, we've lost some
precision. So the times that come out of time.time() and time.time_ns() shoul
Larry Hastings added the comment:
(Oh, wow, Victor, you wrote all that while I was writing my reply. ;-)
--
___
Python tracker
<https://bugs.python.org/issue39
Larry Hastings added the comment:
> The problem is that there is a double rounding in
> time = float(time_ns) / 1e9
> 1. When convert time_ns to float.
> 2. When divide it by 1e9.
I'm pretty sure that in Python 3, if you say
c = a / b
and a and b are both "sing
Larry Hastings added the comment:
p.s. for what it's worth: I re-checked my math and as usual I goofed. It takes
*30* bits to store the non-fractional seconds part of the current time in a
double, leaving 23 bits for the fractional part, so we're *7*
Larry Hastings added the comment:
Yes, but you get the first 1 bit for free. So it actually only uses 30 bits of
storage inside the double.
This is apparently called "leading bit convention":
https://en.wikipedia.org/wiki/IEEE_754#Representation_and_encoding
Larry Hastings added the comment:
Aha! The crucial distinction is that IEEE 754 doubles have 52 bits of storage
for the mantissa, but folks (e.g. Wikipedia, Mark Dickinson) describe this as
"53 bits of precision" because that's easier saying "52 bits but you don't h
Larry Hastings added the comment:
> Anyway, it's better to leave it to the experts:
I'm not sure what you're suggesting here. I shouldn't try to understand how
floating-point numbers are stored?
--
___
Python tracker
&
Larry Hastings added the comment:
Personally I'm enjoying these BLAKE3 status updates, and I wouldn't mind at all
being kept up-to-date during BLAKE3's development via messages on this issue.
But, given the tenor of the conversation so far, I'm guessing Python is g
Larry Hastings added the comment:
> We should do that for each singletons:
>
> * None (Py_None)
> * True (Py_True)
> * False (Py_False)
> * Ellipsis (Py_Ellipsis)
Aren't there a couple more lurking in the interpreter? E.g. empty tuple, empty
frozenset.
> Th
Larry Hastings added the comment:
> The problem with having a single immortal `None`, is that it will
> cause data cache thrashing as two different CPUs modify the
> refcount on the shared `None` object.
That's a very reasonable theory. Personally, I find modern CPU architectur
Larry Hastings added the comment:
New changeset 8835f465fa94f114dcf865429c0410821d365dae by Ned Deily in branch
'3.5':
bpo-38945: UU Encoding: Don't let newline in filename corrupt the output format
(GH-17418) (GH-17444) (#17445)
https://github.com/python
Change by Larry Hastings :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Larry Hastings added the comment:
I need to do a little more reading on it, but I expect if you make an
equivalent PR for 3.5 I'll merge it. Thanks for taking this on, Victor!
--
___
Python tracker
<https://bugs.python.org/is
Larry Hastings added the comment:
Since explicit is better than implicit: yes, we do need backports. PRs against
3.5 are getting marked red because of automated codecov complaints.
--
nosy: +larry
___
Python tracker
<https://bugs.python.
Larry Hastings added the comment:
New changeset ed07522a5faa3101f68be8e4b8369310f60860f8 by Victor Stinner in
branch '3.5':
bpo-40156: Copy Codecov configuration from master (#19309)
https://github.com/python/cpython/commit/ed07522a5faa3101f68be8e4b83693
Larry Hastings added the comment:
New changeset 55a6a16a46239a71b635584e532feb8b17ae7fdf by Victor Stinner in
branch '3.5':
bpo-38804: Fix REDoS in http.cookiejar (GH-17157) (#17344)
https://github.com/python/cpython/commit/55a6a16a46239a71b635584e532feb
Larry Hastings added the comment:
Good catch, and thanks for submitting a patch too! I want to play with your
patch a little before I just say "yes of course".
--
___
Python tracker
<https://bugs.python.o
New submission from Larry Kuhn :
Running open with or without rU generates this message when reading a CSV file
with CR line endings:
DeprecationWarning: 'U' mode is deprecated
with open(csvfile, mode='rU', newline='') as cf:
Traceback (most recent call last):
Change by Larry Kuhn :
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue40473>
___
___
Change by Larry Hastings :
--
nosy: -larry
___
Python tracker
<https://bugs.python.org/issue42616>
___
___
Python-bugs-list mailing list
Unsubscribe:
Larry Hastings added the comment:
Stop adding me to this issue.
--
___
Python tracker
<https://bugs.python.org/issue42616>
___
___
Python-bugs-list mailin
Change by Larry Hastings :
--
nosy: -larry
___
Python tracker
<https://bugs.python.org/issue42616>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Larry Hastings :
--
nosy: -larry
___
Python tracker
<https://bugs.python.org/issue42616>
___
___
Python-bugs-list mailing list
Unsubscribe:
Larry Hastings added the comment:
Sorry, somehow bpo decided I added two people to this issue? Weird. Anyway I
have removed them (Ned and "froody").
--
nosy: +larry -froody, ned.deily
___
Python tracker
<https://bugs.python.o
New submission from Larry Hastings :
PEP 484 says:
(Note that the return type of __init__ ought to be annotated
with -> None. The reason for this is subtle. [...]
https://www.python.org/dev/peps/pep-0484/#the-meaning-of-annotations
If you follow this advice, then c
New submission from Larry Hastings :
You interested in me doing an editing pass / critique of your PEP? I
just poked around on Github, and I don't think I can do one of those
inline code review things until it's a PR.
Also, I'm a PEP editor, I can get it assigned a PEP num
Larry Hastings added the comment:
(Oops, meant to send that as a private email. Sorry for the noise, I'll try to
be more careful in the future.)
--
___
Python tracker
<https://bugs.python.org/is
New submission from Larry Hastings :
I'm building Python for a mildly-embedded ARM system. The system is running
Linux, but doesn't have a native toolchain installed. So I'm building in a
Docker container using a native toolchain (virtualizing the CPU).
The toolchain I'
Change by Larry Hastings :
--
nosy: -larry
___
Python tracker
<https://bugs.python.org/issue21309>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Larry Hastings :
--
components: +Interpreter Core -Argument Clinic, Documentation
nosy: -larry
___
Python tracker
<https://bugs.python.org/issue20
Change by Larry Hastings :
--
nosy: -larry
___
Python tracker
<https://bugs.python.org/issue28712>
___
___
Python-bugs-list mailing list
Unsubscribe:
Larry Hastings added the comment:
New changeset f88b578949a034f511dd1b4c1c161351b3ee0db8 by Inada Naoki in branch
'3.5':
bpo-39035: travis: Update image to xenial (#17623)
https://github.com/python/cpython/commit/f88b578949a034f511dd1b4c1c161351b3ee0db8
--
no
Larry Hastings added the comment:
New changeset f91a0b6df14d6c5133fe3d5889fad7d84fc0c046 by Victor Stinner in
branch '3.5':
bpo-39073: validate Address parts to disallow CRLF (#19007) (#20450)
https://github.com/python/cpython/commit/f91a0b6df14d6c5133fe3d5889fad7d84fc0c046
-
Larry Hastings added the comment:
New changeset 37fe316479e0b6906a74b0c0a5e495c55037fdfd by Victor Stinner in
branch '3.5':
bpo-39503: CVE-2020-8492: Fix AbstractBasicAuthHandler (GH-18284) (#19305)
https://github.com/python/cpython/commit/37fe316479e0b6906a74b0c0a5e495
Larry Hastings added the comment:
New changeset 09d8172837b6985c4ad90ee025f6b5a554a9f0ac by Tapas Kundu in branch
'3.5':
[3.5] closes bpo-38576: Disallow control characters in hostnames in
http.client. (#19300)
https://github.com/python/cpyt
Change by Larry Hastings :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Larry Hastings added the comment:
strnlen() isn't standard C, but an exciting new function strnlen_s() is, as of
C11.
https://en.cppreference.com/w/c/string/byte/strlen
(At this rate, we should be able to code CPython using that standard in about
2030.)
But! I found a 2005 thre
New submission from Larry Hastings :
I'm testing 3.5.10rc1 on a freshly installed Linux (Pop!_OS 20.04), and I'm
getting a lot of these test failures:
ssl.SSLError: [SSL: EE_KEY_TOO_SMALL] ee key too small (_ssl.c:2951)
Apparently the 2048 keys used in the tests are considered
Larry Hastings added the comment:
New changeset d565be84993a3d618add139cf21038e12c60a13e by Christian Heimes in
branch '3.5':
bpo-41183: Update test certs and keys (#21258)
https://github.com/python/cpython/commit/d565be84993a3d618add139cf21038
Larry Hastings added the comment:
New changeset d565be84993a3d618add139cf21038e12c60a13e by Christian Heimes in
branch '3.5':
bpo-41183: Update test certs and keys (#21258)
https://github.com/python/cpython/commit/d565be84993a3d618add139cf21038e12c60a13e
--
no
Larry Hastings added the comment:
Thanks for the backport!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Larry Hastings added the comment:
I also needed a backport of this to 3.5. See #41183.
Also, it looks like this issue should have been closed long ago, so I'll go
ahead and do that.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
ver
Larry Hastings added the comment:
Christian: Help! Again!
I merged your PR, pulled a fresh copy, built it, and ran the test suite. I get
seven failures in I think the same modules.
Most of the failures are either "ssl.SSLError: [SSL] internal error
(_ssl.c:728)", or some
Larry Hastings added the comment:
Upgrading to release blocker.
--
priority: high -> release blocker
resolution: fixed ->
stage: resolved -> needs patch
status: closed -> open
___
Python tracker
<https://bugs.python
Larry Hastings added the comment:
test_ssl was one of the seven modules that failed. But attached here is just
the output of
% ./python -m test -v test_ssl >& test_ssl_failure
--
Added file: https://bugs.python.org/file49287/test_ssl_
Larry Hastings added the comment:
The 3.6 branch of python/cpython fails as well on this machine. Output
attached.
--
Added file: https://bugs.python.org/file49288/test_ssl_36_branch
___
Python tracker
<https://bugs.python.org/issue41
Larry Hastings added the comment:
I assume this is building against the system OpenSSL. On this machine, the
"openssl", "libssl1.1", and "libssl-dev" packages are all version
"1.1.1f-1ubuntu2".
The OS is "Pop!_OS" version 20.04, which i
Larry Hastings added the comment:
./python -m test -v test_ssl >& test_ssl_verbose_36_master
--
Added file: https://bugs.python.org/file49290/test_ssl_verbose_36_master
___
Python tracker
<https://bugs.python.org/
Larry Hastings added the comment:
Do you need a temporary login on one of my Pop!_OS computers, in order to test?
--
___
Python tracker
<https://bugs.python.org/issue41
Larry Hastings added the comment:
Gotcha. Thanks for looking into it for me. I don't think the world is super
anxious about getting 3.5.10rc1 so it's not a big huge deal. But I will wait
to hear back from you. Thanks!
--
___
Pyth
Larry Hastings added the comment:
New changeset f52bf62fe12d46267e958f80dbe1f4425b55cd0f by Christian Heimes in
branch '3.5':
bpo-41183: Update finite DH params to 3072 bits (#21278)
https://github.com/python/cpython/commit/f52bf62fe12d46267e958f80dbe1f4
Larry Hastings added the comment:
Any news?
--
___
Python tracker
<https://bugs.python.org/issue41183>
___
___
Python-bugs-list mailing list
Unsubscribe:
Larry Hastings added the comment:
Yes, please. It's a simple low-risk fix. And 3.5.10rc1 is stuck waiting for a
fix anyway. Thanks!
--
___
Python tracker
<https://bugs.python.org/is
Larry Hastings added the comment:
Ping?
--
___
Python tracker
<https://bugs.python.org/issue41183>
___
___
Python-bugs-list mailing list
Unsubscribe:
Larry Hastings added the comment:
New changeset cac9ca8ed99bd98f4c0dcd1913a146192bf5ee84 by Petr Viktorin in
branch '3.5':
[3.5] bpo-39017: Avoid infinite loop in the tarfile module (GH-21454) (#21489)
https://github.com/python/cpython/commit/cac9ca8ed99bd98f4c0dcd1913a146
Change by Larry Hastings :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Larry Hastings added the comment:
I must have taken my stupid pills today. Why is this considered a "security"
"release blocker"? If you can put files in the root of the hard drive where
Windows was installed, surely you have other, e
Larry Hastings added the comment:
I still don't understand why this is considered a Python security problem. If
the user can put a malicious "python3.dll" at some arbitrary spot in the
filesystem (e.g. a USB flash drive), and fool Python.exe into loading it, then
surely th
Change by Larry Hastings :
--
nosy: -larry
___
Python tracker
<https://bugs.python.org/issue41459>
___
___
Python-bugs-list mailing list
Unsubscribe:
Larry Hastings added the comment:
New changeset f205f1000a2d7f8b044caf281041b3705f293480 by Steve Dower in branch
'3.5':
[3.5] bpo-29778: Ensure python3.dll is loaded from correct locations when
Python is embedded (GH-21297) (#21377)
https://github.com/python/cpyt
Larry Hastings added the comment:
New changeset 11d258ceafdf60ab3840f9a5700f2d0ad3e2e2d1 by Tapas Kundu in branch
'3.5':
[3.5] bpo-41004: Resolve hash collisions for IPv4Interface and IPv6Interface
(GH-21033) (#21233)
https://github.com/python/cpyt
Change by Larry Hastings :
--
assignee: eric.smith ->
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue41004>
___
___
Python-bugs-
Larry Hastings added the comment:
> Does testing with the environment variable OPENSSL_CONF=/non-existing-file
> workaround the remaining issues?
Sadly, no. I get the same failures whether or not that environment variable is
set. And I confirmed that the environment variable su
Larry Hastings added the comment:
New changeset 524b8de630036a29ca340bc2ae6fd6dc7dda8f40 by Victor Stinner in
branch '3.5':
bpo-39603: Prevent header injection in http methods (GH-18485) (#21946)
https://github.com/python/cpython/commit/524b8de630036a29ca340bc2ae6fd6
201 - 300 of 2415 matches
Mail list logo
