[issue27355] Strip out the last lingering vestiges of Windows CE support

2016-06-20 Thread Larry Hastings
Larry Hastings added the comment: Nosying two people who I know worked on the port originally, just in case they have an opinion about removing WinCE. (Remind me. Why is our private copy of libffi a divergent unmaintained fork? libffi still gets updates; last update was two years ago. Why

[issue27365] Allow non-ascii chars in IDLE NEWS.txt (for contributor names)

2016-06-22 Thread Larry Hastings
Larry Hastings added the comment: If the diff is literally changing two lines, I'll accept it. Guido relaxed the rules for IDLE changes. If it breaks something it's on *your* head ;-) Please just check it in normally. Either I'm going to use hg to cherry-pick the changes

[issue27365] Allow non-ascii chars in IDLE NEWS.txt (for contributor names)

2016-06-22 Thread Larry Hastings
Larry Hastings added the comment: You speak confidently, for a guy who hasn't seen any sort of schedule from the 3.5 RM. :-O After 3.6 comes out, I expect 3.5 to get one more "bug fix" release. And *then* it will transition to "security fixes only" mode. Six months

[issue26867] test_ssl test_options fails on ubuntu 16.04

2016-06-24 Thread Larry Hastings
Larry Hastings added the comment: Well, I want this fixed in 3.5.2 final. If nobody can propose a better patch in the next 24 hours then I'm going with Matthias's patch. -- ___ Python tracker <http://bugs.python.o

[issue27365] Allow non-ascii chars in IDLE NEWS.txt (for contributor names)

2016-06-25 Thread Larry Hastings
Larry Hastings added the comment: If this is fixed, and resolved, why is it still open? Closing. -- status: open -> closed ___ Python tracker <http://bugs.python.org/issu

[issue26867] test_ssl test_options fails on ubuntu 16.04

2016-06-25 Thread Larry Hastings
Larry Hastings added the comment: Well, as Donald Rumsfeld said in 2008: "As you know, you go to war with the army you have, not the army you might want or wish to have at a later time." 3.5.2 final and 3.4.5 final will ship with Matthias's patch as proposed. FWIW I'

[issue27401] Wrong FTP links in 3.5.2 installer

2016-06-27 Thread Larry Hastings
Larry Hastings added the comment: I can independently confirm that the "amd64" directory is in the proper place, and all relevant files & directories look like they have the correct permissions. I did that by logging in to the appropriate server and nosing around. Also, the

[issue19802] socket.SO_PRIORITY is missing

2016-06-28 Thread Larry Hastings
Larry Hastings added the comment: Sorry, this is now too late for 3.4. 3.4 is now in "security fixes only" mode. This is not a security fix, therefore 3.4 is now ineligible. Since this change was committed to 3.5, it's better to let the historical record reflect that. So I

[issue24557] Refactor LibreSSL / EGD detection

2016-07-05 Thread Larry Hastings
Changes by Larry Hastings : -- nosy: -larry ___ Python tracker <http://bugs.python.org/issue24557> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue24557] Refactor LibreSSL / EGD detection

2016-07-05 Thread Larry Hastings
Larry Hastings added the comment: At this point you're not adding this to 3.5. -- versions: -Python 3.5 ___ Python tracker <http://bugs.python.org/is

[issue26944] android: test_posix fails

2016-07-21 Thread Larry Hastings
Larry Hastings added the comment: Is there a plan to make Android a supported platform in 3.6? -- ___ Python tracker <http://bugs.python.org/issue26944> ___ ___

[issue25170] 3.4.4, 3.4.5, 3.5.0, 3.5.1, 3.5.2 documentation archives missing

2016-07-24 Thread Larry Hastings
Larry Hastings added the comment: I can fix it. Are instructions on how to update that in PEP 101 and I missed it? (Do you know where it is in the Django maze of twisty little passages?) -- ___ Python tracker <http://bugs.python.org/issue25

[issue25170] 3.4.4, 3.4.5, 3.5.0, 3.5.1, 3.5.2 documentation archives missing

2016-07-24 Thread Larry Hastings
Larry Hastings added the comment: Okay, I've updated the doc, and verified that the links work. The releases/3.5.0 directory had problems; it had bad permissions, and was stuck on 3.5.0a3 or something. I blew it away and installed the 3.5.0 final docs from the tarball and se

[issue20160] broken ctypes calling convention on MSVC / 64-bit Windows (large structs)

2016-08-05 Thread Larry Hastings
Larry Hastings added the comment: 3.4 is also in security-fixes-only mode, which also means it's in no-binary-installers mode. Good luck making the case that "this bugfix, which took us more than 2.5 years to finalize, is so critical that the release team must immediately is

[issue24648] Allocation of values array in split dicts should use small object allocator.

2016-08-16 Thread Larry Hastings
Changes by Larry Hastings : -- nosy: +aniawsz, larry ___ Python tracker <http://bugs.python.org/issue24648> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue24648] Allocation of values array in split dicts should use small object allocator.

2016-08-16 Thread Larry Hastings
Larry Hastings added the comment: Assigning to myself on behalf of "aniawsz". I actually want to assign it to her but for some reason I can't. (Maybe because she doesn't have the commit bit?) -- assignee: -> larry __

[issue17170] string method lookup is too slow

2013-02-13 Thread Larry Hastings
Larry Hastings added the comment: Argument Clinic has languished for lack of time. I didn't get much feedback, though a couple people were shouting for a PEP, which I was resisting. I figured, if they have something to say, they can go ahead and reply on the tracker issue, and if they

[issue17170] string method lookup is too slow

2013-02-13 Thread Larry Hastings
Larry Hastings added the comment: Oh, and, as to whether Argument Clinic would solve this problem, the answer is "not yet". Right now Argument Clinic literally generates calls to PyArg_ParseTupleAndKeywords. (In special cases it switches to PyArg_ParseTuple.) I'm mor

[issue16612] Integrate "Argument Clinic" specialized preprocessor into CPython trunk

2013-02-23 Thread Larry Hastings
Larry Hastings added the comment: Okay, I have finally addressed all the comments so far. Changes described below are my patch #2. They're also checked in to https://bitbucket.org/larry/python-clinic/ . * Antoine, Nick, et al: I've converted clinic.txt into a PEP. I've alr

[issue16801] Preserve original representation for integers / floats in docstrings

2013-02-24 Thread Larry Hastings
Larry Hastings added the comment: FWIW I think the octint class is a great idea. It's nice and localized, and it should have no performance impact and only a small maintenance impact. It'll also preserve the readability of the default if you pull it out with inspect.getf

[issue16612] Integrate "Argument Clinic" specialized preprocessor into CPython trunk

2013-02-25 Thread Larry Hastings
Larry Hastings added the comment: Argument Clinic is now PEP 436. http://www.python.org/dev/peps/pep-0436/ -- ___ Python tracker <http://bugs.python.org/issue16

[issue16612] Integrate "Argument Clinic" specialized preprocessor into CPython trunk

2013-02-25 Thread Larry Hastings
Larry Hastings added the comment: A quick note about the extension mechanism. Currently the only way to extend PyArg_Parse* is via O&. Therefore, any extended type you add will use O&, and will have a "converter". So internally all I did was say "if the parameter h

[issue16612] Integrate "Argument Clinic" specialized preprocessor into CPython trunk

2013-02-26 Thread Larry Hastings
Larry Hastings added the comment: As a rule I'm unlikely to mention things I haven't heard about. I've never used Cython, and I don't recall anyone mentioning this technology previously. Once skrah posts his alternative DSL proposal, I'll amend the PEP to discuss

[issue16612] Integrate "Argument Clinic" specialized preprocessor into CPython trunk

2013-02-26 Thread Larry Hastings
Larry Hastings added the comment: write_clinic_file tells Clinic to start writing to the clinic file, which I think is best to do at the very top of the file. include_clinic_file spits out the #include, which you probably want near the bottom of the file, just before the static module

[issue17324] SimpleHTTPServer serves files even if the URL has a trailing slash

2013-03-01 Thread Larry Hastings
New submission from Larry Hastings: To reproduce: 1) Create a file called "foo.txt" in the local directory, put whatever you like in it. 2) Run "python -m SimpleHTTPServer" or "python3 -m http.server". 3) Point your web browser at "http://127.0.0.1:8000/foo.

[issue17324] SimpleHTTPServer serves files even if the URL has a trailing slash

2013-03-01 Thread Larry Hastings
Changes by Larry Hastings : -- stage: -> test needed type: -> behavior ___ Python tracker <http://bugs.python.org/issue17324> ___ ___ Python-bugs-list

[issue16612] Integrate "Argument Clinic" specialized preprocessor into CPython trunk

2013-03-09 Thread Larry Hastings
Larry Hastings added the comment: Thanks for pointing that out! I've fixed it in my local branch, though I'm fooling around with some new syntax so I'm not ready to publish it yet. It's not a general problem, exactly; it's a problem with extension types. After j

[issue13477] tarfile module should have a command line

2013-03-19 Thread Larry Hastings
Larry Hastings added the comment: Modern tar programs don't need to be told the compression method--they infer it. If they can do it in C, we can do it in Python. So we should simply omit the "-bz2" stuff. As for what the interface should look like, I'm definitely in

[issue13477] tarfile module should have a command line

2013-03-19 Thread Larry Hastings
Larry Hastings added the comment: Huh. tar *can* infer it from the data itself. On the other hand, it chooses explicitly not to. % cat ~/Downloads/Python-3.3.0.tar.bz2| tar xvf - tar: Archive is compressed. Use -j option tar: Error is not recoverable: exiting now % cat ~/Downloads/Python

[issue17499] inspect.Signature and inspect.Parameter objects are mutable

2013-03-20 Thread Larry Hastings
New submission from Larry Hastings: The documentation for Inspect.Signature and Inspect.Parameter states that the objects are immutable. And they go to great lengths to provide a convenient interface allowing you to "replace" members. However, the objects make only a pathetic effor

[issue17499] inspect.Signature and inspect.Parameter objects are mutable

2013-03-20 Thread Larry Hastings
Larry Hastings added the comment: Yes, it seems I've been living in a fool's paradise, happy and ignorant. I thought that the behavior of garden-variety "immutable" objects was like tuple, where the implementor shored up the interface and the saboteur had to work *really

[issue17490] Use converter functions to implement ast.literal_eval

2013-03-20 Thread Larry Hastings
Larry Hastings added the comment: For what it's worth, here's what we're doing. The new Argument Clinic "parameter" line looks a great deal like the middle bit of a Python function declaration. So much so that we can do this: ast_string = "def x({}

[issue17206] Py_XDECREF() expands its argument multiple times

2013-03-31 Thread Larry Hastings
Larry Hastings added the comment: For the record: I care. Generally speaking CPython is a lovingly crafted source tree, and the choices its architects made are nearly always sensible and well-reasoned. When I see things like this, things that seem kind of dumb on first glance, I worry that

[issue17589] Make documentation about macros in C API explicit about rvalue vs statement

2013-03-31 Thread Larry Hastings
New submission from Larry Hastings: CPython API "functions" implemented as macros can expand into either rvalues or statements. Most expand into statements (often using the do {} while (0) syntactic sugar trick), but occasionally they're legal as rvalues. As of this writing Py_

[issue17589] Make documentation about macros in C API explicit about rvalue vs statement

2013-03-31 Thread Larry Hastings
Larry Hastings added the comment: > Py_INCREF usable as an rvalue sounds more like an accident > than a deliberate feature I'd go with "misfeature", but in no way is it accidental. The coding deliberately preserves the rvalue-ness of it, c.f

[issue17613] IDLE "AttributeError: 'NoneType' object has no attribute 'index'" from Delegator.py

2013-04-01 Thread Larry Hastings
Larry Hastings added the comment: When an issue is marked as "release blocker", the release managers of all affected versions are automatically added to the issue. I'm the release manager of 3.4, Georg is for 3.3. -- ___ Python

[issue17589] Make documentation about macros in C API explicit about rvalue vs statement

2013-04-08 Thread Larry Hastings
Larry Hastings added the comment: Amaury: I'd appreciate it if you'd bring those examples up on bug 17206. If we're going to change the semantics of Py_INCREF I'd prefer we did it with our eyes wide open. -- ___ P

[issue17589] Make documentation about macros in C API explicit about rvalue vs statement

2013-04-08 Thread Larry Hastings
Larry Hastings added the comment: Oh, and, yes, it's true that Py_RETURN_NONE currently takes advantage of Py_INCREF being an rvalue, and changing Py_INCREF to a statement would break the existing implementation. But Py_RETURN_NONE itself is of necessity a statement. We would simply c

[issue15301] os.chown: OverflowError: Python int too large to convert to C long

2013-04-14 Thread Larry Hastings
Larry Hastings added the comment: Oh...! Serhiy, I thought you already checked in the AsIndex stuff. Guess I was asleep at the switch. Certainly the patch should go in for trunk. I'd be comfortable with it going in for 3.3 as a bugfix but that's ultimately Georg's call.

[issue15301] os.chown: OverflowError: Python int too large to convert to C long

2013-04-15 Thread Larry Hastings
Larry Hastings added the comment: Okay, I got inspired and (in the words of Barry Warsaw) JFDI. Attached is my revised patch. I took Serhiy's patch and reworked it quite a bit: * I think it's now easier to follow. In particular: * The most common case (no overflow) is now

[issue15301] os.chown: OverflowError: Python int too large to convert to C long

2013-04-15 Thread Larry Hastings
Larry Hastings added the comment: See my comment above (dated 2013-04-14 04:30). I'm passing the buck. -- ___ Python tracker <http://bugs.python.org/is

[issue15301] os.chown: OverflowError: Python int too large to convert to C long

2013-04-16 Thread Larry Hastings
Changes by Larry Hastings : Added file: http://bugs.python.org/file29883/larry.chown.unsigned.uid.gid.3.diff ___ Python tracker <http://bugs.python.org/issue15

[issue15301] os.chown: OverflowError: Python int too large to convert to C long

2013-04-16 Thread Larry Hastings
Larry Hastings added the comment: Whoops, forgot to write something here. Updated patch (in previous edit to the issue) incorporating Serhiy's suggestions from Rietveld. -- ___ Python tracker <http://bugs.python.org/is

[issue15301] os.chown: OverflowError: Python int too large to convert to C long

2013-04-22 Thread Larry Hastings
Larry Hastings added the comment: Can I get an LGTM? -- ___ Python tracker <http://bugs.python.org/issue15301> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue15301] os.chown: OverflowError: Python int too large to convert to C long

2013-04-22 Thread Larry Hastings
Larry Hastings added the comment: Latest patch incorporating Serihy's comments. -- Added file: http://bugs.python.org/file29977/larry.chown.unsigned.uid.gid.4.diff ___ Python tracker <http://bugs.python.org/is

[issue15301] os.chown: OverflowError: Python int too large to convert to C long

2013-04-22 Thread Larry Hastings
Larry Hastings added the comment: Whoops, meant to throw in a Fraction too. Added that. Also hoisted the imports out of the function call, just to be a good guy. -- Added file: http://bugs.python.org/file29978/larry.chown.unsigned.uid.gid.5.diff

[issue15301] os.chown: OverflowError: Python int too large to convert to C long

2013-04-23 Thread Larry Hastings
Larry Hastings added the comment: Serhiy: Oh, I get it, your critique was about the "Note:" part at the bottom. It would have been helpful if you had inserted your feedback there, instead of at the top. Yeah, you're right, the note was incorrect. I considered adding a note

[issue17899] os.listdir() leaks FDs if invoked on FD pointing to a non-directory

2013-05-03 Thread Larry Hastings
Larry Hastings added the comment: Patch attached. I don't know how to make fdopendir fail, so I had to do it by inspection. While I was in there, I ifdef'd out the variable that should only be used if fdopendir is available. -- keywords: +patch stage: needs patch ->

[issue16024] Doc cleanup regarding path=fd, dir_fd, follow_symlinks, etc

2013-05-19 Thread Larry Hastings
Larry Hastings added the comment: I would, but I can't get it to apply cleanly, either to tip or to historical revisions back in Sepember. Kaleb, what revision is the branch that you generated the diff from? -- ___ Python tracker

[issue16024] Doc cleanup regarding path=fd, dir_fd, follow_symlinks, etc

2013-05-20 Thread Larry Hastings
Larry Hastings added the comment: p.s. Thanks for reviving the patch. I forgot about this one! -- ___ Python tracker <http://bugs.python.org/issue16024> ___ ___

[issue22568] Use of "utime" as variable name in Modules/posixmodule.c causes errors

2014-10-09 Thread Larry Hastings
Larry Hastings added the comment: Georg, you want to take a swing at it, be my guest. The current mess is my doing, and I claim this is an *improvement* over what came before. -- ___ Python tracker <http://bugs.python.org/issue22

[issue22568] Use of "utime" as variable name in Modules/posixmodule.c causes errors

2014-10-09 Thread Larry Hastings
Larry Hastings added the comment: I remember manually setting/unsetting #defines to force alternate compilation paths. But I think there were one or two that I didn't have library support for (testing on Linux and Windows). -- ___ Python tr

[issue22615] "make clinic" doesn't work

2014-10-11 Thread Larry Hastings
Larry Hastings added the comment: Patch attached. Brett was using a feature that didn't exist, so I'm not sure how it could have worked for him. But it was a reasonable implicit feature request, and easy to implement, so here we are. I'm not sure what's causing the chu

[issue22615] Argument Clinic doesn't support the "type" argument for the int converter

2014-10-13 Thread Larry Hastings
Changes by Larry Hastings : -- title: "make clinic" doesn't work -> Argument Clinic doesn't support the "type" argument for the int converter ___ Python tracker &

[issue22615] Argument Clinic doesn't support the "type" argument for the int converter

2014-10-13 Thread Larry Hastings
Changes by Larry Hastings : -- assignee: -> larry resolution: -> fixed status: open -> closed type: -> compile error ___ Python tracker <http://bugs.python

[issue22609] Constructors of some mapping classes don't accept `self` keyword argument

2014-10-13 Thread Larry Hastings
Larry Hastings added the comment: FWIW, I agree that it should be fixed: >>> dict(self=1) {'self': 1} -- nosy: +larry ___ Python tracker <http://bugs

[issue22823] Use set literals instead of creating a set from a list

2014-11-10 Thread Larry Hastings
Larry Hastings added the comment: Serhiy: set_literal_2.patch doesn't apply cleanly, so I don't get a "review" link. And apparently Raymond checked in some other changes separately. Could you redo your patch so it has the Clinic changes, and ensure I

[issue22823] Use set literals instead of creating a set from a list

2014-11-11 Thread Larry Hastings
Larry Hastings added the comment: The patch is totally fine. I wonder why it was like that in the first place! -- ___ Python tracker <http://bugs.python.org/issue22

[issue20662] Pydoc doesn't escape parameter defaults in html

2014-11-17 Thread Larry Hastings
Larry Hastings added the comment: LGTM -- ___ Python tracker <http://bugs.python.org/issue20662> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue20530] Change the text signature format (again) to be more robust

2014-11-27 Thread Larry Hastings
Larry Hastings added the comment: Actually this is the wrong issue for that observation. You want the issue where yselivanov added emitting the "/" to pydoc. -- ___ Python tracker <http://bugs.python.o

[issue23283] Backport Tools/clinic to 3.4

2015-01-20 Thread Larry Hastings
Larry Hastings added the comment: I would prefer the backport be more selective. There are other changes (set literals, fix "--converters") in trunk that aren't in 3.4 and I wouldn't want them pulled in willy-nilly. However, I'd accept this backport if the patc

[issue20709] os.utime(path_to_directory): wrong documentation for Windows.

2015-02-02 Thread Larry Hastings
Larry Hastings added the comment: I'm not sure we support 2.7 supports any versions of Windows earlier than XP. If so, we could drop the provision entirely. -- ___ Python tracker <http://bugs.python.org/is

[issue21354] PyCFunction_New no longer exposed by python DLL breaking bdist_wininst installers

2015-02-07 Thread Larry Hastings
Larry Hastings added the comment: Still not fixed! This has been marked as "release blocker" for most of a year. Should I just apply the patch? -- ___ Python tracker <http://bugs.python.o

[issue22634] importing _ctypes failed: undefined symbol: ffi_call_win32

2015-02-07 Thread Larry Hastings
Larry Hastings added the comment: What does "-m32" mean? -- ___ Python tracker <http://bugs.python.org/issue22634> ___ ___ Python-bugs-list mailing

[issue23415] add-to-pydotorg does not support .exe installers for Windows

2015-02-08 Thread Larry Hastings
New submission from Larry Hastings: Steve is using new technology to make the installers for Windows. He generates four installers now: * .exe for Win32 * -amd64.exe for Win64 * -webinstall.exe for Win32 web-based installers * -amd64-webinstall.exe for Win64 web-based installers add-to

[issue23415] add-to-pydotorg does not support .exe installers for Windows

2015-02-08 Thread Larry Hastings
Larry Hastings added the comment: I should add, adding the files by hand worked fine. (Which means that if you experiment with the script, when it blows away the files and re-adds them, you'll be blowing away the files I added by hand. So if you do so, it's up to you to ensure the

[issue23415] add-to-pydotorg does not support .exe installers for Windows

2015-02-09 Thread Larry Hastings
Larry Hastings added the comment: Attached for your reading pleasure. -- keywords: +patch Added file: http://bugs.python.org/file38060/larry.add-to-pydotorg.exe.support.1.diff ___ Python tracker <http://bugs.python.org/issue23

[issue23492] Argument Clinic: improve generated parser for 1-argument functions

2015-02-20 Thread Larry Hastings
Larry Hastings added the comment: I'm not opposed to the patch in principle. I assume your goal is to make Python faster--do you have any data on how much faster? I don't support immediately changing all uses of Argument Clinic to generate their code into a separate file. I wou

[issue23492] Argument Clinic: improve generated parser for 1-argument functions

2015-02-21 Thread Larry Hastings
Larry Hastings added the comment: Stefan: Serhiy's patch only affects functions taking a single positional-only parameter. -- ___ Python tracker <http://bugs.python.org/is

[issue23492] Argument Clinic: improve generated parser for 1-argument functions

2015-02-21 Thread Larry Hastings
Larry Hastings added the comment: lgtm -- ___ Python tracker <http://bugs.python.org/issue23492> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue24286] Should OrderedDict.viewitems compare equal to dict.viewitems when the items are equal?

2015-05-25 Thread Larry Hastings
Changes by Larry Hastings : -- nosy: +eric.snow ___ Python tracker <http://bugs.python.org/issue24286> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue24325] Speedup types.coroutine()

2015-05-29 Thread Larry Hastings
Larry Hastings added the comment: This looks big and complicated. I'd prefer this skipped 3.5 and just went into 3.6. -- ___ Python tracker <http://bugs.python.org/is

[issue24320] Remove a now-unnecessary workaround from importlib._bootstrap.

2015-06-02 Thread Larry Hastings
Larry Hastings added the comment: Sounds okay in theory. Is the bug in question now tested in our regression suite? -- ___ Python tracker <http://bugs.python.org/issue24

[issue24320] Remove a now-unnecessary workaround from importlib._bootstrap.

2015-06-02 Thread Larry Hastings
Larry Hastings added the comment: Then you may fire when ready. -- ___ Python tracker <http://bugs.python.org/issue24320> ___ ___ Python-bugs-list mailin

[issue18003] lzma module very slow with line-oriented reading.

2015-06-02 Thread Larry Hastings
Larry Hastings added the comment: Quoi? Je comprends que le français. -- ___ Python tracker <http://bugs.python.org/issue18003> ___ ___ Python-bugs-list mailin

[issue18003] lzma module very slow with line-oriented reading.

2015-06-02 Thread Larry Hastings
Larry Hastings added the comment: If I understand this correctly, I can ignore everything up to May 2015, as it has to do with line-reading a compressed binary file (!) being slow. Then, Martin Panter proposes a new optimization in May 2015, which is to simply add __iter__ methods to

[issue18003] lzma module very slow with line-oriented reading.

2015-06-03 Thread Larry Hastings
Larry Hastings added the comment: I don't see anything about "closed" in the patch you posted. -- ___ Python tracker <http://bugs.python.org/issue18003> ___ _

[issue8232] webbrowser.open incomplete on Windows

2015-06-04 Thread Larry Hastings
Larry Hastings added the comment: Go ahead for beta 3. -- ___ Python tracker <http://bugs.python.org/issue8232> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18003] lzma module very slow with line-oriented reading.

2015-06-06 Thread Larry Hastings
Larry Hastings added the comment: A small last-minute optimization is not a release-blocker. -- priority: release blocker -> normal ___ Python tracker <http://bugs.python.org/issu

[issue24391] Better repr for threading objects

2015-06-06 Thread Larry Hastings
Larry Hastings added the comment: I'll allow it. But I agree with Brett, I really would prefer that the type be the first thing in the repr. I'd rather fix the lock objects than compound our error. -- ___ Python tracker <http://bu

[issue24391] Better repr for threading objects

2015-06-06 Thread Larry Hastings
Larry Hastings added the comment: FWIW I find "unset" more obvious. I don't think it needs the module name. -- ___ Python tracker <http://bugs.pyt

[issue24391] Better repr for threading objects

2015-06-07 Thread Larry Hastings
Larry Hastings added the comment: The world of reprs already isn't particularly consistent. If you make your reprs consistent with module X, it'll be *inconsistent* with module Y, and vice versa. I say let's just worry about making it nice and readable for humans. That s

[issue18003] lzma module very slow with line-oriented reading.

2015-06-09 Thread Larry Hastings
Larry Hastings added the comment: Sounds good to me. -- ___ Python tracker <http://bugs.python.org/issue18003> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue15745] Numerous utime ns tests fail on FreeBSD w/ ZFS (update: and NetBSD w/ FFS, Solaris w/ UFS)

2015-06-11 Thread Larry Hastings
Larry Hastings added the comment: Of the two I prefer Harrison Grundy's patch, simply because it's shorter. What OS / filesystem did you run the test on, koobs? -- ___ Python tracker <http://bugs.python.o

[issue8232] webbrowser.open incomplete on Windows

2015-06-15 Thread Larry Hastings
Larry Hastings added the comment: Sorry, but I think this is more accurately described as a "new feature" than a "bugfix". Please don't backport this to 3.4. -- ___ Python tracker <http

[issue8232] webbrowser.open incomplete on Windows

2015-06-15 Thread Larry Hastings
Larry Hastings added the comment: This is not a bugfix to existing code. This is new code to implement a missing feature. -- ___ Python tracker <http://bugs.python.org/issue8

[issue8232] webbrowser.open incomplete on Windows

2015-06-15 Thread Larry Hastings
Larry Hastings added the comment: Rules like this are there for a reason. People rely on Python being consistent. We've added harmless new features to point releases in the past and broken people's code. So, we don't do it anymore. It's not because we don't care,

[issue8232] webbrowser.open incomplete on Windows

2015-06-15 Thread Larry Hastings
Larry Hastings added the comment: Yes, which is why I permitted a feature freeze exception for it for 3.5. But it's simply far, far too late to add a feature like this to 3.4. -- ___ Python tracker <http://bugs.python.org/i

[issue24468] Expose compiler flag constants as code object attributes

2015-06-18 Thread Larry Hastings
Larry Hastings added the comment: Probably, though I want to see a sample implementation before I agree to anything. -- ___ Python tracker <http://bugs.python.org/issue24

[issue24306] Backport py.exe to 3.4

2015-06-20 Thread Larry Hastings
Larry Hastings added the comment: "Last installed wins" isn't perfect, but at least it's predictable. Is it possible to make the 3.4 installer detect that 3.5+ is installed and not install the launcher? -- ___ P

[issue24483] Avoid repeated hash calculation in C implementation of functools.lru_cache()

2015-06-22 Thread Larry Hastings
Larry Hastings added the comment: I can accept this change, but I don't like that code. Is it really considered acceptable to have that much copy-and-paste code in the dict implementation for KnownHash calls? Could the common code be split off into a Py_LOCAL_INLINE fun

[issue24483] Avoid repeated hash calculation in C implementation of functools.lru_cache()

2015-06-22 Thread Larry Hastings
Larry Hastings added the comment: Patch doesn't build for me against current trunk: gcc -pthread -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes-Werror=declaration-after-statement -I. -IInclude -I./Include-DPy_BUILD_COR

[issue24483] Avoid repeated hash calculation in C implementation of functools.lru_cache()

2015-06-23 Thread Larry Hastings
Larry Hastings added the comment: I suggest that 20 lines of identical code copy-and-pasted between two functions is not the cleanest way to do it. Find attached my version of the patch, which splits this common code out into a static function. -- Added file: http://bugs.python.org

[issue24492] using custom objects as modules: AttributeErrors new in 3.5

2015-06-23 Thread Larry Hastings
Larry Hastings added the comment: What's a sensible approach to ameliorate the problem? Gracefully muddle through without a __name__ on the imported object? -- ___ Python tracker <http://bugs.python.org/is

[issue23517] datetime.utcfromtimestamp parses timestamps incorrectly

2015-07-02 Thread Larry Hastings
Larry Hastings added the comment: Yes, by all means, fix for 3.4, 3.5, and 3.6. If possible I'd appreciate you getting the fix checked in to 3.5 within the next 48 hours, as I'm tagging the next beta release of 3.5 around then, and it'd be nice if this fix went out i

[issue22516] Windows Installer won't - even when using "just for me"option

2015-07-02 Thread Larry Hastings
Changes by Larry Hastings : -- nosy: -larry ___ Python tracker <http://bugs.python.org/issue22516> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue24483] Avoid repeated hash calculation in C implementation of functools.lru_cache()

2015-07-02 Thread Larry Hastings
Larry Hastings added the comment: This can go in for 3.5 beta 3. -- ___ Python tracker <http://bugs.python.org/issue24483> ___ ___ Python-bugs-list mailin

[issue24492] using custom objects as modules: AttributeErrors new in 3.5

2015-07-02 Thread Larry Hastings
Larry Hastings added the comment: This is a) marked as release blocker, and b) is assigned to nobody. This is not tenable. While I want this fixed, I'm not going to hold up beta 3 for it. -- priority: release blocker -> deferred

[issue24450] Add cr_await calculated property to coroutine object

2015-07-02 Thread Larry Hastings
Larry Hastings added the comment: I'll accept it for 3.5. Can it go in for beta 3, tagged in 48 hours? -- ___ Python tracker <http://bugs.python.org/is

[issue19235] Add a dedicated subclass for recursion errors

2015-07-02 Thread Larry Hastings
Larry Hastings added the comment: This is fine for 3.5. -- ___ Python tracker <http://bugs.python.org/issue19235> ___ ___ Python-bugs-list mailing list Unsub

<    15   16   17   18   19   20   21   22   23   24   >