Larry Hastings added the comment:
Note that this appears to be in Windows-specific code ("CP_UTF8"), rather than
being cross-platform code which happens to only fail on Windows. So we need
someone who does both Windows and Unicode.
--
Larry Hastings added the comment:
Use #3.
--
___
Python tracker
<http://bugs.python.org/issue20283>
___
___
Python-bugs-list mailing list
Unsubscribe:
Larry Hastings added the comment:
"pattern" should be keyword-only, and if used the function should generate a
DeprecationWarning.
--
___
Python tracker
<http://bugs.python.o
Larry Hastings added the comment:
Added a test checking that the error messages show up properly.
--
assignee: -> larry
stage: needs patch -> patch review
Added file: http://bugs.python.org/file34005/larry.oserror.add.filename2.2.diff
___
Larry Hastings added the comment:
Serhiy said on IRC that he doesn't have a Windows development environment, so
he didn't think he could help.
--
___
Python tracker
<http://bugs.python.o
Larry Hastings added the comment:
There aren't any deprecation warnings in the code.
--
___
Python tracker
<http://bugs.python.org/issue20517>
___
___
Pytho
Larry Hastings added the comment:
But the PyErr_ functions that accept Py_UNICODE aren't marked deprecated.
http://docs.python.org/3.4/c-api/exceptions.html#unicode-exception-objects
--
___
Python tracker
<http://bugs.python.org/is
New submission from Larry Hastings:
I just realized that the signatures for builtin slot functions (__iadd__,
__delitem__, etc) only accept positional-only arguments. But when I added the
signatures by hand to all the slots I didn't mark them as positional-only. The
attached patch rem
Larry Hastings added the comment:
Attached is patch #3. This one has been tested on Linux, Windows 7 64-bit, and
Snow Leopard 64-bit. Windows Server 2008 32-bit and 64-bit
are running now, looking good so far.
Changes:
* The order of arguments for OSError is now:
(errno, string
Larry Hastings added the comment:
New patch incorporating Serhiy's suggestions. Thanks, Serhiy!
Did more testing with the buildbots. Windows Server 2008 32-bit and 64-bit
were both fine. So were ARMv7, OpenIndiana 64-bit, Gentoo 32-bit, FreeBSD 10
64-bit, and PowerLinux PPC 64-bit.
Larry Hastings added the comment:
One more tweak from Serhiy.
--
Added file: http://bugs.python.org/file34015/larry.oserror.add.filename2.5.diff
___
Python tracker
<http://bugs.python.org/issue20
Larry Hastings added the comment:
Okay. I have revived the Py_UNICODE functions I removed in patch #3. The
patch now works fine on my Ubuntu 13.10 64-bit box, and at least compiled on a
Windows buildbot. It's now building on nine buildbots.
Assuming the buildbots look good, can I
Larry Hastings added the comment:
It's in! And the buildbots look healthy.
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.pyth
Larry Hastings added the comment:
I used a different issue number in Misc/NEWS, but this was fixed in revision
28aef6e22736 checked in just a little while ago.
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -&g
Larry Hastings added the comment:
Talked it over with Victor in IRC. I agree it's best to only add the
WithFilenameObjects functions, as best practice requires using the original
PyObject * passed in when creating the OSError.
The attached patch removes all the new WithFilename
Larry Hastings added the comment:
Buildbots are basically happy with it. It's checked in. This was the last
checkin before 3.4.0rc1 was tagged!
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.
Larry Hastings added the comment:
This isn't a release blocker. And it's not really viable to remove it.
Since it's been in several releases, I suspect our only option is to throw a
deprecation warning. And, since deprecations aren't turned on by default,
maybe the be
Larry Hastings added the comment:
My suggestion for documenting it was to document the fact that it's
unsupported, unrecommended, deprecated, has poor semantics, etc. If a user
discovers it, and finds it's not documented, they'll probably think they can
get away with u
Larry Hastings added the comment:
Yes, this can go in.
--
___
Python tracker
<http://bugs.python.org/issue20594>
___
___
Python-bugs-list mailing list
Unsub
Larry Hastings added the comment:
Is this more than a theoretical problem?
--
___
Python tracker
<http://bugs.python.org/issue20595>
___
___
Python-bugs-list m
Larry Hastings added the comment:
Let's be a little smarter. PATH_MAX isn't used anymore. Just remove the
#defines entirely.
--
___
Python tracker
<http://bugs.python.o
Larry Hastings added the comment:
Assuming you keep an eye on the buildbots, this has my permission to go in.
Martin: While we don't officially support those compilers, I don't see the harm
of removing unused #defines, so I'm willing to ac
Larry Hastings added the comment:
What bad thing will happen if I don't accept this for 3.4?
--
___
Python tracker
<http://bugs.python.org/issue20414>
___
___
Larry Hastings added the comment:
I suggest that that documentation counts for starting the deprecation cycle,
however I would still also accept a patch adding a deprecation warning if the
parameter is used.
--
___
Python tracker
<h
Larry Hastings added the comment:
Some questions.
a) Is at least one of these Overlapped objects new in 3.4?
b) Which of these Overlapped objects is used by asyncio?
c) Is the goal of merging the two objects simple code hygiene, or is the merged
object going to work better somehow? Like, will
Larry Hastings added the comment:
Victor: at this point I'm cherry-picking all revisions that will go into rc2 /
final.
--
___
Python tracker
<http://bugs.python.org/is
Larry Hastings added the comment:
Since this is a problem in Cython, not in CPython, maybe you can fix it in
Cython?
--
___
Python tracker
<http://bugs.python.org/issue17
Larry Hastings added the comment:
Why would we mangle the names of arguments in the first place? What possible
use case is there?
--
___
Python tracker
<http://bugs.python.org/issue20
Larry Hastings added the comment:
I agree: definitely not for 3.5, maybe for 3.4.1.
--
nosy: +larry
___
Python tracker
<http://bugs.python.org/issue20637>
___
___
Larry Hastings added the comment:
Yeah, I considered getting fussy about "you didn't follow instructions". But
this actually is better for me, as it means I can apply the patches in
chronological order.
Like Guido said, I intend to be permissive when it comes to asyncio f
Larry Hastings added the comment:
Okay.
I'm holding off a couple days just to get all the requests lined up, so I can
apply them in chronological order--that'll cut down on the conflicts.
--
___
Python tracker
<http://bugs.python.o
Larry Hastings added the comment:
I created a cherry-pick issue (#20665) to track that separately.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
New submission from Larry Hastings:
Creating new issue from #20594 to track cherry-picking this into 3.4.0.
--
assignee: larry
components: Build
messages: 211439
nosy: larry
priority: release blocker
severity: normal
stage: commit review
status: open
title: 3.4 cherry-pick: 400a8e4599d9
Larry Hastings added the comment:
400a8e4599d9 is the revision.
--
___
Python tracker
<http://bugs.python.org/issue20665>
___
___
Python-bugs-list mailin
Larry Hastings added the comment:
Okay. I'll do the first round of cherry-picking Tuesday or Wednesday (my
time). I'm waiting for the list of requests to settle down so I can do them in
chronological order.
--
___
Python trac
Larry Hastings added the comment:
Okay.
--
___
Python tracker
<http://bugs.python.org/issue20645>
___
___
Python-bugs-list mailing list
Unsubscribe:
Larry Hastings added the comment:
This one worries me a little. Antoine, do you agree that this should be
cherry-picked for 3.4.0?
--
nosy: +pitrou
___
Python tracker
<http://bugs.python.org/issue20
Larry Hastings added the comment:
When you land this fix, please create the separate "3.4 cherry-pick" issue.
Those issues are helping me a lot with keeping track of everything.
--
___
Python tracker
<http://bugs.python.o
Larry Hastings added the comment:
key and default are keyword-only arguments, the signature should have a '*'.
--
___
Python tracker
<http://bugs.python.o
Larry Hastings added the comment:
For what it's worth I don't mind the noise, if indeed it's a false alarm. I'm
glad you're keeping an eye on the buildbots too.
--
___
Python tracker
<http:
Larry Hastings added the comment:
If you want this in 3.4.0, please create a "3.4 cherry-pick" issue for it.
Personally I would feel a lot more confident in the change if there was any
evidence of it being reviewed before it was checked in. All I see is a
four-minute window between
Larry Hastings added the comment:
ok.
--
___
Python tracker
<http://bugs.python.org/issue20647>
___
___
Python-bugs-list mailing list
Unsubscribe:
Larry Hastings added the comment:
(And obviously this is okay by me.)
--
___
Python tracker
<http://bugs.python.org/issue20665>
___
___
Python-bugs-list mailin
Larry Hastings added the comment:
ok.
--
___
Python tracker
<http://bugs.python.org/issue20675>
___
___
Python-bugs-list mailing list
Unsubscribe:
Larry Hastings added the comment:
ok.
--
___
Python tracker
<http://bugs.python.org/issue20670>
___
___
Python-bugs-list mailing list
Unsubscribe:
Larry Hastings added the comment:
I'd like a second opinion about this before it goes in, just due to the size of
the patch.
--
___
Python tracker
<http://bugs.python.org/is
Larry Hastings added the comment:
ok.
--
___
Python tracker
<http://bugs.python.org/issue20676>
___
___
Python-bugs-list mailing list
Unsubscribe:
Larry Hastings added the comment:
2e8a142dbccc just missed today's cherry-picking session. I'll add it tomorrow.
--
___
Python tracker
<http://bugs.python.o
Larry Hastings added the comment:
Perhaps, but if they request cherry-picking for revisions after 2e8a142dbccc,
skipping 2e8a142dbccc will make the cherry-picking a lot harder.
And I bet I haven't seen the last request for cherry-picking asyncio changes
for
Larry Hastings added the comment:
For what it's worth,
Lib/asyncio/*
Lib/test/test_asyncio/*
Doc/library/async*
are all exactly the same between default and the tarball I published this
evening. (Minus Yury's cleanup patch
Larry Hastings added the comment:
My only question: do they need to be independent flags? ISTM that they're
always either both True or both False.
--
___
Python tracker
<http://bugs.python.org/is
Larry Hastings added the comment:
Ok, I don't want general sadness. I prefer the sadness I sow to be highly
specifically targeted.
--
___
Python tracker
<http://bugs.python.org/is
Larry Hastings added the comment:
Title fix because *some* people can't follow directions, thus breaking my
search.
--
title: cherry-pick 0399e842073a -> 3.4 cherry-pick: 0399e842073a
___
Python tracker
<http://bugs.python.org
Changes by Larry Hastings :
--
priority: release blocker -> high
___
Python tracker
<http://bugs.python.org/issue20687>
___
___
Python-bugs-list mailing list
Un
Larry Hastings added the comment:
So here's the thing. It only works in Python 3.3 because testtools depends on
internal implementation details of unittest, specifically a private exception
("unittest.case._UnexpectedSuccess"). The public interface still works fine.
So I d
Larry Hastings added the comment:
This is not a release blocker. You guys can play with this for 3.5. FWIW I
prefer Serhiy's approach.
--
priority: release blocker -> normal
versions: +Python 3.5 -Python 3.4
___
Python tracke
Larry Hastings added the comment:
Any progress to report?
--
___
Python tracker
<http://bugs.python.org/issue20621>
___
___
Python-bugs-list mailing list
Unsub
New submission from Larry Hastings:
Benjamin, Barry: I take it #20261 should go in to 3.4.0?
--
assignee: larry
messages: 211693
nosy: barry, benjamin.peterson, larry
priority: release blocker
severity: normal
stage: commit review
status: open
title: 3.4 cherry-pick: b328f8ccbccf pickle
Larry Hastings added the comment:
Could someone merge this change from 3.3 into default? I would cherry-pick it
for 3.4.0 if they did.
--
___
Python tracker
<http://bugs.python.org/issue16
Larry Hastings added the comment:
Are there still changes needed for 3.4.0? Or is 3.4.0 okay? This is marked as
"release blocker".
--
___
Python tracker
<http://bugs.python.o
Larry Hastings added the comment:
Martin? Do you concur?
--
___
Python tracker
<http://bugs.python.org/issue20568>
___
___
Python-bugs-list mailing list
Unsub
Changes by Larry Hastings :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue20651>
___
___
Python-bugs-list
Changes by Larry Hastings :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue20645>
___
___
Python-bugs-list
Changes by Larry Hastings :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue20647>
___
___
Python-bugs-list
Changes by Larry Hastings :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue20665>
___
___
Python-bugs-list
Changes by Larry Hastings :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue20670>
___
___
Python-bugs-list
Changes by Larry Hastings :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue20675>
___
___
Python-bugs-list
Larry Hastings added the comment:
ok.
--
___
Python tracker
<http://bugs.python.org/issue20688>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Larry Hastings :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue20688>
___
___
Python-bugs-list
Larry Hastings added the comment:
ok. if there's more please open a new issue.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.
Changes by Larry Hastings :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue20697>
___
___
Python-bugs-list
Changes by Larry Hastings :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue20698>
___
___
Python-bugs-list
Larry Hastings added the comment:
*sigh* okay. Including 2e8a142dbccc from last night, that's eight new
revisions to cherry-pick in one day. I really hope this is slowing down.
--
___
Python tracker
<http://bugs.python.org/is
Larry Hastings added the comment:
There are a few diffs on the asyncio files right now. I went back and looked
and discovered a whole bunch of asyncio revisions post-rc1 that you haven't
asked to be cherry-picked yet:
20dc8d6430eb
75881b85695f
9c1840e8d643
a631b01d1715
360976a
Larry Hastings added the comment:
Also 6b850722849e
--
___
Python tracker
<http://bugs.python.org/issue20648>
___
___
Python-bugs-list mailing list
Unsubscribe:
Larry Hastings added the comment:
Then I'm marking this as 3.5 and clearing the regression keyword. From here we
can either fix it in 3.5 or not bother (and just close this issue as wontfix).
--
keywords: -3.4regression
priority: high -> normal
versions: +Python 3.5 -Py
Larry Hastings added the comment:
I finished the second preview of rc2 just before you posted 96e078663083.
That'll go in the third preview.
Also, I found another revision you forgot about (something about improving
debug info). With that, and the other revisions I mentioned, asyncio i
Changes by Larry Hastings :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue20707>
___
___
Python-bugs-list
Larry Hastings added the comment:
ok. it's a low-risk fix.
--
___
Python tracker
<http://bugs.python.org/issue20707>
___
___
Python-bugs-list mailing list
Larry Hastings added the comment:
ok.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue20685>
___
___
Pyth
New submission from Larry Hastings:
inspect has a bug:
* inspect.ismethod() returns False for bound methods on builtins.
If I fix that, that exposes a bug in pydoc:
* pydoc's two docroutine() functions assume that bound methods
have a __func__; bound builtins do not.
The only reason
Changes by Larry Hastings :
--
stage: -> patch review
type: -> behavior
___
Python tracker
<http://bugs.python.org/issue20710>
___
___
Python-bugs-list
Larry Hastings added the comment:
Whoops, the test suite hadn't finished when I posted that, and it had an error.
Here's an updated patch that fixes the tests.
Also, there's one more minor fix in the patch. pydoc has cut-and-pasted code
for HTML versus text rendering, and
Larry Hastings added the comment:
We discussed it in python-dev:
https://mail.python.org/pipermail/python-dev/2014-January/132051.html
And the overwhelming majority voted +1 for "don't show self for bound methods".
So I'd like to change it for 3.4. (I meant to get it i
Larry Hastings added the comment:
I'm not proposing to modify isbuiltin. Rather, I'm proposing to fix a bug in
ismethod.
--
___
Python tracker
<http://bugs.python.o
Larry Hastings added the comment:
So why is it necessary (and a release blocker) to fix a bug in
inspect._signature_fromstr, but a terrible idea to fix a bug in
inspect.ismethod?
--
___
Python tracker
<http://bugs.python.org/issue20
Larry Hastings added the comment:
Okay, that's a fair point. I checked, and the documentation specifically says
that ismethod only returns true on bound methods implemented in Python. I
think that's a bad API, it should be agnostic about the implementation
language. But I
New submission from Larry Hastings:
Some of the methods on the inspect module behave differently depending on
whether the callable passed in was implemented in C or in Python. For example,
ismethod() only returns True for bound methods implemented in Python.
I assert that the interface
Larry Hastings added the comment:
Here's a revised patch that doesn't modify inspect.
--
___
Python tracker
<http://bugs.python.org/issue20710>
___
___
Changes by Larry Hastings :
Added file:
http://bugs.python.org/file34165/larry.fix.help.on.bound.methods.3.diff
___
Python tracker
<http://bugs.python.org/issue20
Larry Hastings added the comment:
A slight tweak to the patch. Previously I was just using truth testing on the
value I got from "__self__", but that's wrong if the object is considered false
(e.g. ''.zfill). (Yury got this right in #20711, and I copied from him
Larry Hastings added the comment:
ok.
--
___
Python tracker
<http://bugs.python.org/issue20713>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Larry Hastings :
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Larry Hastings added the comment:
An even slighter tweak to the patch, just using De Morgan's law to make the
code easier to read.
--
Added file:
http://bugs.python.org/file34168/larry.fix.help.on.bound.methods.5.diff
___
Python tracker
Larry Hastings added the comment:
I bet you want this cherry-picked; please create a separate issue for that.
--
___
Python tracker
<http://bugs.python.org/issue20
Larry Hastings added the comment:
If you've committed something already, and want to change it, then please
request both revisions be cherry-picked.
--
___
Python tracker
<http://bugs.python.org/is
Larry Hastings added the comment:
Updated with tests. And I built without docstrings and it still passed. And
if I revert the change to Lib/pydoc.py the tests fail.
--
Added file:
http://bugs.python.org/file34170/larry.fix.help.on.bound.methods.6.diff
Larry Hastings added the comment:
We still have a couple of weeks left. Ethan, can you start a discussion in
python-dev about cherry-picking this for 3.4?
--
___
Python tracker
<http://bugs.python.org/issue20
Larry Hastings added the comment:
I went ahead and added tests for os.stat, and the unbound versions of the two
class methods. Total of five new tests now.
--
Added file:
http://bugs.python.org/file34171/larry.fix.help.on.bound.methods.7.diff
Larry Hastings added the comment:
You're right, that was the exact same test ;-)
So what I did was: move the other tests down into that test class, as that's a
better fit, and keep the new version of the test.
--
Added file:
http://bugs.python.org
1601 - 1700 of 2415 matches
Mail list logo
