[issue20170] Derby #1: Convert 137 sites to Argument Clinic in Modules/posixmodule.c

2014-08-04 Thread Larry Hastings
Larry Hastings added the comment: Gonna keep an eye on the buildbots and make sure I haven't caused any new breakage. Otherwise... fingers crossed, I think it's done! Thanks for the help everybody (particularly Zach!). -- ___ Pyth

[issue20170] Derby #1: Convert 137 sites to Argument Clinic in Modules/posixmodule.c

2014-08-04 Thread Larry Hastings
Changes by Larry Hastings : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue22120] Code Argument Clinic has a warning

2014-08-04 Thread Larry Hastings
Larry Hastings added the comment: The title for this bug was almost offensively generic; it was hard to find in my email. If this new one is inaccurate, fix it--but please pick something more specific. Attached is a patch for the "_return_value == -1" behavior for unsigned. --

[issue22120] Return converter code generated by Argument Clinic has a warning for unsigned types

2014-08-04 Thread Larry Hastings
Changes by Larry Hastings : -- title: Code Argument Clinic has a warning -> Return converter code generated by Argument Clinic has a warning for unsigned types ___ Python tracker <http://bugs.python.org/issu

[issue22120] Return converter code generated by Argument Clinic has a warning for unsigned types

2014-08-05 Thread Larry Hastings
Larry Hastings added the comment: Fixed and closed. I'm assuming Victor will break the other patch out into its own issue. Since IIUC there's no code in 3.4 that uses an unsigned integer return converter, I'm not backporting the fix. -- resolution: -> fixed st

[issue20291] Argument Clinic should understand *args and **kwargs parameters

2014-08-18 Thread Larry Hastings
Larry Hastings added the comment: So, let's think about this for a minute. What's the API that we *want* here? If your function has the signature (a, b, c=20, *args) and you call it with (1, 2, 3, 4, 5) should "args" be (4, 5), or (1, 2, 3, 4, 5)? I assert that the

[issue15237] Add capsule API to _decimal

2014-09-03 Thread Larry Hastings
Larry Hastings added the comment: I think #22194 is a duplicate issue. -- ___ Python tracker <http://bugs.python.org/issue15237> ___ ___ Python-bugs-list mailin

[issue22194] access to cdecimal / libmpdec API

2014-09-03 Thread Larry Hastings
Larry Hastings added the comment: I think this is a duplicate of #15237. -- nosy: +larry ___ Python tracker <http://bugs.python.org/issue22194> ___ ___ Python-bug

[issue22194] access to cdecimal / libmpdec API

2014-09-03 Thread Larry Hastings
Larry Hastings added the comment: Are there any other modules where the capsule API works in both CPython and PyPy? I thought capsule APIs were decidedly implementation-specific. Not that I'm not for it in theory. But this is some crazy uncharted hyper-compatibility territory we'

[issue21112] 3.4 regression: unittest.expectedFailure no longer works on TestCase subclasses

2014-09-07 Thread Larry Hastings
Larry Hastings added the comment: Note: current plan for 3.4.2 is to release at the end of the month. RC1 will be in about a week. -- ___ Python tracker <http://bugs.python.org/issue21

[issue21199] Python on 64-bit Windows uses signed 32-bit type for read length

2014-09-11 Thread Larry Hastings
Larry Hastings added the comment: Ping? -- ___ Python tracker <http://bugs.python.org/issue21199> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue22366] urllib.request.urlopen shoudl take a "context" (SSLContext) argument

2014-09-19 Thread Larry Hastings
Larry Hastings added the comment: Alex said he needed this in order to implement PEP 476, and I thought PEP 476 was going in to 3.4 (hopefully for 3.4.2, which I'm tagging in like 24 hours). -- nosy: +larry ___ Python tracker

[issue21354] PyCFunction_New no longer exposed by python DLL breaking bdist_wininst installers

2014-09-20 Thread Larry Hastings
Larry Hastings added the comment: This is still not fixed. -- ___ Python tracker <http://bugs.python.org/issue21354> ___ ___ Python-bugs-list mailing list Unsub

[issue22461] Test failure: Lib/test/test_pydoc.py line 851, "topic?key=def"

2014-09-22 Thread Larry Hastings
New submission from Larry Hastings: I get a test failure in the regression test suite. This appears to be the important bit: Traceback (most recent call last): File "/tmp/Python-3.4.2rc1/Lib/test/test_pydoc.py", line 851, in test_url_requests self.assertEqual(res

[issue22461] Test failure: Lib/test/test_pydoc.py line 851, "topic?key=def"

2014-09-22 Thread Larry Hastings
Larry Hastings added the comment: FWIW, 3.4.2rc1 is based on 7af0315bdfe0. (The release process creates a couple additional changesets.) The failure is on my laptop, Ubuntu 14.04 x64. -- ___ Python tracker <http://bugs.python.org/issue22

[issue21431] 3.4.1rc1 test_pydoc fails: pydoc_data.topics.topics values are type "bytes" not "str"

2014-09-22 Thread Larry Hastings
Larry Hastings added the comment: If this is fixed, then how come I hit it again today? -- ___ Python tracker <http://bugs.python.org/issue21431> ___ ___ Pytho

[issue21431] 3.4.1rc1 test_pydoc fails: pydoc_data.topics.topics values are type "bytes" not "str"

2014-09-22 Thread Larry Hastings
Larry Hastings added the comment: Oh, because it was only fixed today. As Emily Litella used to say... never mind! -- ___ Python tracker <http://bugs.python.org/issue21

[issue22203] inspect.getargspec() returns wrong spec for builtins

2014-09-26 Thread Larry Hastings
Larry Hastings added the comment: We should be able to get proper signatures for 3.5. For 3.4, probably the best thing is to prevent the signature / raise an error. -- ___ Python tracker <http://bugs.python.org/issue22

[issue22568] Use of "utime" as variable name in Modules/posixmodule.c causes errors

2014-10-06 Thread Larry Hastings
Larry Hastings added the comment: I don't understand. If utime is a *function*, then the local variable should simply take precedence. Do you possibly mean that utime is a *macro*? What compilation error do you get? -- ___ Python tracker

[issue19973] Deprecate pyio

2013-12-13 Thread Larry Hastings
New submission from Larry Hastings: Does it make sense to finally deprecate pyio, so we can eventually delete it? -- messages: 206060 nosy: larry priority: normal severity: normal status: open title: Deprecate pyio versions: Python 3.5 ___ Python

[issue19973] Deprecate pyio

2013-12-13 Thread Larry Hastings
Changes by Larry Hastings : -- nosy: +pitrou ___ Python tracker <http://bugs.python.org/issue19973> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19973] Deprecate pyio

2013-12-13 Thread Larry Hastings
Larry Hastings added the comment: I hadn't! I guess we're signed up to maintain two implementations of a bunch of things for eternity, then. -- resolution: -> wont fix stage: -> committed/rejected status: open -> closed ty

[issue19846] Python 3 raises Unicode errors with the C locale

2013-12-13 Thread Larry Hastings
Larry Hastings added the comment: > "The fact that write() -> open() relies on sys.getfilesystemencoding() > (respectively locale.getpreferredencoding()) at default as encoding is > either a defect or a bad design (I leave the decision to you)." > > Or am I overlo

[issue19973] Deprecate pyio

2013-12-13 Thread Larry Hastings
Larry Hastings added the comment: We tried a pure python implementation of io once. Didn't go so well. :p -- ___ Python tracker <http://bugs.python.org/is

[issue19976] Argument Clinic: generate second arg for METH_NOARGS

2013-12-13 Thread Larry Hastings
Larry Hastings added the comment: Stefan is right. I'll fix Clinic. -- ___ Python tracker <http://bugs.python.org/issue19976> ___ ___ Python-bugs-list m

[issue19973] Deprecate pyio

2013-12-13 Thread Larry Hastings
Larry Hastings added the comment: Yes, but it's a small utility. If it costs nothing to maintain _pyio then okay. But if we're spending measurable time on it but it's only a nice-to-have then we should drop it. (Full disclosure: I have no idea how much work goes into ma

[issue19976] Argument Clinic: generate second arg for METH_NOARGS

2013-12-13 Thread Larry Hastings
Larry Hastings added the comment: A quick google suggests: http://sourcefrog.net/weblog/software/languages/C/unused.html -- ___ Python tracker <http://bugs.python.org/issue19

[issue19976] Argument Clinic: generate second arg for METH_NOARGS

2013-12-13 Thread Larry Hastings
Larry Hastings added the comment: To do it properly with Clang requires a pragma: http://stackoverflow.com/questions/3417837/what-is-the-best-way-to-supress-unused-variable-x-warning/18724213#18724213 What a mess. -- ___ Python tracker <h

[issue19976] Argument Clinic: generate second arg for METH_NOARGS

2013-12-15 Thread Larry Hastings
Larry Hastings added the comment: Here's a first attempt at a patch. The Visual Studio pragma disables for the rest of the file, which is undesirable. Maybe we could turn it on and off inline, but it's not clear to me that that would have the desired effect of turning off the w

[issue19518] Add new PyRun_xxx() functions to not encode the filename

2013-12-17 Thread Larry Hastings
Larry Hastings added the comment: So all the PyRun_*Object functions are new in 3.4, and none of them are documented yet? Option 4 is silly--I don't think we should ship them as public APIs in 3.4 if we're planning to rename them. I prefer the previous options. p.s. fwiw I ha

[issue19702] Update pickle to take advantage of PEP 451

2013-12-17 Thread Larry Hastings
Larry Hastings added the comment: So far I agree that this should be postponed to 3.5. -- ___ Python tracker <http://bugs.python.org/issue19702> ___ ___ Python-bug

[issue19518] Add new PyRun_xxx() functions to not encode the filename

2013-12-17 Thread Larry Hastings
Larry Hastings added the comment: Are all the functions that use "Object" to indicate "Unicode object instead of string" new in 3.4? Of those, how many are undocumented? -- ___ Python tracker <http://bug

[issue19518] Add new PyRun_xxx() functions to not encode the filename

2013-12-17 Thread Larry Hastings
Larry Hastings added the comment: Are we proposing renaming any functions that are either a) not new in 3.4, or b) were documented as of 3.4 beta 1? -- ___ Python tracker <http://bugs.python.org/issue19

[issue19518] Add new PyRun_xxx() functions to not encode the filename

2013-12-17 Thread Larry Hastings
Larry Hastings added the comment: Are those five functions new in 3.4 and undocumented? -- ___ Python tracker <http://bugs.python.org/issue19518> ___ ___ Pytho

[issue19927] Path-based loaders lack a meaningful __eq__() implementation.

2013-12-21 Thread Larry Hastings
Larry Hastings added the comment: That's not how this works, Eric. I have to give you permission to add a new feature, which I remind you I have yet to do. -- ___ Python tracker <http://bugs.python.org/is

[issue19927] Path-based loaders lack a meaningful __eq__() implementation.

2013-12-21 Thread Larry Hastings
Larry Hastings added the comment: So can you tell me how this will make users' lives easier? I don't really understand the issues involved. But the only concrete thing I've seen mentioned is making testing easier, and that's not worth breaking

[issue19927] Path-based loaders lack a meaningful __eq__() implementation.

2013-12-22 Thread Larry Hastings
Larry Hastings added the comment: 1. Is this patch going to change best practice for working with ModuleSpec? 2. If we delayed it to 3.5, will users have to ignore it to work around the deficiencies of the ModuleSpec implementation in 3.4? I'm guessing the answer to both of these is &quo

[issue20075] help(open) eats first line

2013-12-27 Thread Larry Hastings
Larry Hastings added the comment: The best fix would be to convert the docstrings to something inspect can parse. Preferably by converting the functions to use Argument Clinic, though you could manually mark up the docstring by hand if necessary

[issue20075] help(open) eats first line

2013-12-27 Thread Larry Hastings
Larry Hastings added the comment: One of the relevant PEPs (PEP 8? PEP 7? the annotations PEP?) states that the Python standard library is not permitted to use annotations. And considering that Argument Clinic is an internal-only tool, we could probably justify the decision to not allow

[issue19995] %c, %o, %x, %X accept non-integer values instead of raising an exception

2013-12-30 Thread Larry Hastings
Larry Hastings added the comment: I wouldn't call this a new feature--it's definitely a bug fix. So the "feature freeze" rule does not automatically apply. I definitely wouldn't permit this once we reach release candidates, but we aren't there yet. I get the

[issue20107] Revert PEP 453 integration

2014-01-02 Thread Larry Hastings
Larry Hastings added the comment: I agree--though it would be better if you simply got it in before Saturday. -- ___ Python tracker <http://bugs.python.org/issue20

[issue19977] Use "surrogateescape" error handler for sys.stdin and sys.stdout on UNIX for the C locale

2014-01-04 Thread Larry Hastings
Larry Hastings added the comment: Yeah, unless there was a *huge* amount of support for changing this, it's way too late for 3.4. -- ___ Python tracker <http://bugs.python.org/is

[issue19927] Path-based loaders lack a meaningful __eq__() implementation.

2014-01-04 Thread Larry Hastings
Larry Hastings added the comment: So, not to yank your chain, but... I'm okay with checking this in. Yes, we're already in beta, but ModuleSpec is brand new, and the sense I get is that this use case is obscure even for ModuleSpec. The only installed base is beta 1 users, and

[issue15027] Faster UTF-32 encoding

2014-01-04 Thread Larry Hastings
Larry Hastings added the comment: Isn't this a new feature? -- nosy: +larry ___ Python tracker <http://bugs.python.org/issue15027> ___ ___ Python-bugs-list m

[issue19995] %c, %o, %x, %X accept non-integer values instead of raising an exception

2014-01-04 Thread Larry Hastings
Larry Hastings added the comment: I'm willing to risk it in 3.4. Can you check it in in the next twelve hours? (Sorry for the short notice, it slipped my mind until just now.) -- ___ Python tracker <http://bugs.python.org/is

[issue15027] Faster UTF-32 encoding

2014-01-04 Thread Larry Hastings
Larry Hastings added the comment: Would you describe it as a "bug fix" or a "security fix"? If it's neither of those things, then you need special permission to add it during beta. And given that this patch has the possibility of causing bugs, I'd prefer to n

[issue19659] Document Argument Clinic

2014-01-04 Thread Larry Hastings
Larry Hastings added the comment: I hid it in the howto directory. Nobody'll look in there! :D -- assignee: -> larry resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.p

[issue20123] pydoc.synopsis fails to load binary modules

2014-01-04 Thread Larry Hastings
Larry Hastings added the comment: Well please get a second opinion. I don't know why you added me, I'm not qualified. -- nosy: +brett.cannon, ncoghlan ___ Python tracker <http://bugs.python.o

[issue19659] Document Argument Clinic

2014-01-04 Thread Larry Hastings
Larry Hastings added the comment: Doesn't help on Windows, junior! -- ___ Python tracker <http://bugs.python.org/issue19659> ___ ___ Python-bugs-list m

[issue19927] Path-based loaders lack a meaningful __eq__() implementation.

2014-01-04 Thread Larry Hastings
Larry Hastings added the comment: You broke buildbots. Please fix. http://buildbot.python.org/all/builders/AMD64%20FreeBSD%2010.0%203.x/builds/1389 -- assignee: -> eric.snow priority: normal -> high resolution: fixed -> stage: committed/rejected -> needs patch status: cl

[issue19927] Path-based loaders lack a meaningful __eq__() implementation.

2014-01-04 Thread Larry Hastings
Larry Hastings added the comment: Hmm, hard to see how you caused that with the path loader change. Still please take a quick look. I fired off another build to see if it was a transient error, but that'll take a while. -- ___ Python tr

[issue20123] pydoc.synopsis fails to load binary modules

2014-01-04 Thread Larry Hastings
Larry Hastings added the comment: Thanks for seeing this through, Eric. -- ___ Python tracker <http://bugs.python.org/issue20123> ___ ___ Python-bugs-list mailin

[issue19713] Deprecate various things in importlib thanks to PEP 451

2014-01-05 Thread Larry Hastings
Larry Hastings added the comment: I can accept the fourth patch in its current state. Is that a rollup patch, including all the previous patches, or is it independent? Is there a patch I can look at for this new API? -- ___ Python tracker <h

[issue19995] %c, %o, %x, %X accept non-integer values instead of raising an exception

2014-01-05 Thread Larry Hastings
Larry Hastings added the comment: Antoine: I made the call to bite the bullet and fix it. If that's a terrible idea we can change it before RC1. But from my (admittedly dim) understanding of the issue, we're going to have to fix this sooner or later, and sooner is probably bett

[issue19995] %c, %o, %x, %X accept non-integer values instead of raising an exception

2014-01-05 Thread Larry Hastings
Larry Hastings added the comment: And, yes, Ethan's checkin missed the cutoff for beta 2. -- ___ Python tracker <http://bugs.python.org/issue19995> ___ ___

[issue20141] Argument Clinic: broken support for 'O!'

2014-01-06 Thread Larry Hastings
Larry Hastings added the comment: So a documentation error and having to manually specify "&" at the front of your string means it's "broken"? Nevertheless, I'll take a look at it. -- ___ Python tracker

[issue20144] Argument Clinic doesn't support named constants as default values

2014-01-06 Thread Larry Hastings
Larry Hastings added the comment: Here's the problem. Let's say I gave you a way of specifying a symbolic constant for the default value for C. What value should we use for the default value in Python? Keep in mind, it has to be expressed as a static value that can be stored as a

[issue18515] zipfile._ZipDecryptor generates wasteful crc32 table on import

2014-01-06 Thread Larry Hastings
Larry Hastings added the comment: Since this isn't a bugfix, it was inappropriate to check this in after feature-freeze for 3.4. However it looks harmless enough, so I'm not asking you to revert it at this time. I guess it's easier to get forgiveness than permission, huh.

[issue20144] Argument Clinic doesn't support named constants as default values

2014-01-06 Thread Larry Hastings
Larry Hastings added the comment: As an example, consider pattern_match() in _sre.c. This implements the match method on a pattern object; in other words, re.compile().match(). The third parameter, endpos, defaults to PY_SSIZE_T_MAX in C. What should inspect.Signature() report as the

[issue20144] Argument Clinic doesn't support named constants as default values

2014-01-06 Thread Larry Hastings
Larry Hastings added the comment: "sys.maxsize" won't work. inspect.Signature parses the __text_signature__ using ast.parse, and it only recognizes constant values and named constants (True/False/None) for the default value for parameters. Playing with ast, it looks li

[issue20141] Argument Clinic: broken support for 'O!'

2014-01-06 Thread Larry Hastings
Larry Hastings added the comment: Actually, the documentation (the "howto") states: Note that object() must explicitly support each Python type you specify for the type argument. Currently it only supports str. It should be easy to add more, just edit Tools/clinic/clinic.py, search

[issue20148] Convert the _sre module to use Argument Clinic

2014-01-06 Thread Larry Hastings
Larry Hastings added the comment: Obviously we can't live with manually editing the output from Argument Clinic, so I'll get you a fix for O! today. Maybe we could use a better literal value? Like 2**31 - 1? I don't understand the pydoc thing. Ca

[issue20142] Argument Clinic: Py_buffer parameters are not initialized

2014-01-06 Thread Larry Hastings
Larry Hastings added the comment: Here's a patch, please review. You can see how Py_buffer variables are initialized in zlibmodule.c in the patch. -- Added file: http://bugs.python.org/file0/larry.clinic.py_buffer.initialization.patch.

[issue20144] Argument Clinic doesn't support named constants as default values

2014-01-06 Thread Larry Hastings
Larry Hastings added the comment: Attached is an example of how we could support simple named constants in __text_signature__. The change to posixmodule.c is just a hack to exercise the code in inspect.Signature; I didn't have a good example handy. When I apply the patch and run &quo

[issue20142] Argument Clinic: Py_buffer parameters are not initialized

2014-01-06 Thread Larry Hastings
Changes by Larry Hastings : -- assignee: -> larry resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python

[issue20144] Argument Clinic doesn't support named constants as default values

2014-01-06 Thread Larry Hastings
Larry Hastings added the comment: Whoops, forgot to attach the file. here it is. -- Added file: http://bugs.python.org/file1/larry.simple.named.constants.in.text.signature.example ___ Python tracker <http://bugs.python.org/issue20

[issue20143] Argument Clinic: negative line numbers

2014-01-06 Thread Larry Hastings
Larry Hastings added the comment: I've seen the problem before, but was too busy to fix it. Give me a reproducable test case and I'll fix it. -- assignee: -> larry ___ Python tracker <http://bugs.pytho

[issue20143] Argument Clinic: negative line numbers

2014-01-06 Thread Larry Hastings
Larry Hastings added the comment: Oh, golly, this was one of those "what was I thinking?" sorts of bugs. The problem (and the fix) was obvious once I stared at it long enough. -- resolution: -> fixed stage: -> committed/rejected status

[issue20144] Argument Clinic doesn't support named constants as default values

2014-01-06 Thread Larry Hastings
Larry Hastings added the comment: It is unfortunate, but on the other hand that's what happens in Python too: >>> import sys >>> import inspect >>> def foo(blah=sys.maxsize): pass ... >>> str(inspect.signature(foo)) '(blah=

[issue20144] Argument Clinic doesn't support named constants as default values

2014-01-06 Thread Larry Hastings
Larry Hastings added the comment: Attached is a patch supporting simple symbolic constants. It works from beginning to end--you specify it in the Argument Clinic input and it shows up in the inspect.Signature and uses the constant in the generated C code. One complication: when using one of

[issue19723] Argument Clinic should add markers for humans

2014-01-06 Thread Larry Hastings
Larry Hastings added the comment: And for Python blocks would you suggest /*[python input] ... [python start generated code]*/ ... /*[python end generated code; checksum: da39a3ee5e6b4b0d3255bfef95601890afd80709]*/ To answer your question: no, it wouldn't be

[issue20144] Argument Clinic doesn't support named constants as default values

2014-01-06 Thread Larry Hastings
Larry Hastings added the comment: storchaka: You propose a result, not an approach. How do you propose we do that? In any case, I think making *that* work would be way too big a change for 3.4. Whatever you proposed would only be appropriate for 3.5

[issue19723] Argument Clinic should add markers for humans

2014-01-06 Thread Larry Hastings
Larry Hastings added the comment: If it's source code, programmers will need to examine it from time to time. A more important distinction imo: stringlib is type-parameterized like some sort of prehistoric C++ template specialization. Thankfully the gunk generated by Argument Clinic is

[issue20158] Argument Clinic: add --clean option

2014-01-07 Thread Larry Hastings
Larry Hastings added the comment: When would you want this? -- ___ Python tracker <http://bugs.python.org/issue20158> ___ ___ Python-bugs-list mailing list Unsub

[issue20157] Argument Clinic generates wrong keyword parameter name for "default"

2014-01-07 Thread Larry Hastings
Larry Hastings added the comment: I'll fix this but it's low priority for today. It's not a release blocker; we could release Python 3.4 with this bug. -- assignee: -> larry priority: release blocker -> normal ___

[issue20161] inspect.signature fails on some functions which use Argument Clinic

2014-01-07 Thread Larry Hastings
Larry Hastings added the comment: I already noticed this; it'll be fixed in the patch for #20144. But thanks for the report! -- ___ Python tracker <http://bugs.python.org/is

[issue20160] broken ctypes calling convention on MSVC / 64-bit Windows (large structs)

2014-01-07 Thread Larry Hastings
Larry Hastings added the comment: For the record, I'd be very happy to accept a patch for this into 3.4 at any time. -- nosy: +larry ___ Python tracker <http://bugs.python.org/is

[issue20158] Argument Clinic: add --clean option

2014-01-07 Thread Larry Hastings
Larry Hastings added the comment: I meant, under what circumstances would you want to use this? I don't know why you would ever want --clean. Removing the output from the Argument Clinic blocks would break any file using it. And Argument Clinic is sufficiently fast, if you were wo

[issue20144] Argument Clinic doesn't support named constants as default values

2014-01-07 Thread Larry Hastings
Larry Hastings added the comment: Here's a second patch; I think this is ready to go in I cleaned up the node parsing a lot. It now knows how to parse the following types of default values: * Number (this applies to both ints and floats) * String ('hello') * Attribu

[issue20144] Argument Clinic doesn't support named constants as default values

2014-01-07 Thread Larry Hastings
Larry Hastings added the comment: Oops! I forgot to actually attach the new patch. I'm dumb. -- Added file: http://bugs.python.org/file33340/larry.simple.symbolic.constant.default.values.diff.2.txt ___ Python tracker <http://bugs.py

[issue19723] Argument Clinic should add markers for humans

2014-01-07 Thread Larry Hastings
Larry Hastings added the comment: Antoine just suggested that, if we used this "accumulator" thing, we'd want a convention for where the generated text should go. I actually have an answer for that: near the end, below the implementations of the module / class methods

[issue20158] Argument Clinic: add --clean option

2014-01-07 Thread Larry Hastings
Larry Hastings added the comment: I don't think Argument Clinic should do this. It would leave the file in a broken state. But if it's an option on clinic.py it might tempt somebody into using it, then they'd be confused. If you want this functionality, please hack it up y

[issue20141] Argument Clinic: broken support for 'O!'

2014-01-07 Thread Larry Hastings
Larry Hastings added the comment: Attached is a new, simpler approach for supporting O!. The object() converter now takes two arguments: * type, which is the type you want the parameter declared as (e.g. "PyUnicodeObject *") * subclass_of, which is the PyTypeObject you want

[issue19723] Argument Clinic should add markers for humans

2014-01-07 Thread Larry Hastings
Larry Hastings added the comment: Patch attached. I tweaked the punctuation in the last line, from this: /*[clinic end generated code; checksum: {checksum}]*/ ^ ^ to this: | | v v

[issue20158] Argument Clinic: add --clean option

2014-01-07 Thread Larry Hastings
Larry Hastings added the comment: Consider: if you ran "clinic.py --clean" on a C file, then tried to use "make clinic", the makefile would first try to build the C file. But since the C file is now broken, the make would fail. And you can't use "make clinic&quo

[issue20141] Argument Clinic: broken support for 'O!'

2014-01-07 Thread Larry Hastings
Larry Hastings added the comment: There are lots of ways you can crash Python by giving erroneous input to Argument Clinic. Clinic has no visibility into the C type system, so it has no way of verifying whether or not the type objects you pass in are correct. That's unfixable and not r

[issue20144] Argument Clinic doesn't support named constants as default values

2014-01-07 Thread Larry Hastings
Larry Hastings added the comment: At Antoine's suggestion, I added a custom function to testcapi that exercises all the different possible types for default values in a text signature. Also the docs have been updated. LGTU? -- Added file: http://bugs.python.org/file

[issue20157] Argument Clinic generates wrong keyword parameter name for "default"

2014-01-07 Thread Larry Hastings
Larry Hastings added the comment: The problem was an easy fix. However, while fixing it I discovered another problem (if "[clinic]*/" was the last line, and it didn't have an eol, Clinic would append another "[clinic]*/"). I fixed that too and added

[issue20158] Argument Clinic: add --clean option

2014-01-07 Thread Larry Hastings
Larry Hastings added the comment: If you edit the Clinic input and don't run clinic.py on it, it's out-of-date but not broken. If you edit the Clinic output and make a mistake, it's *your* fault. If you ran clinic.py --clean, now you've broken your file *and* the normal

[issue20144] Argument Clinic doesn't support named constants as default values

2014-01-07 Thread Larry Hastings
Larry Hastings added the comment: Incorporated suggestions from Serhiy. Thanks, Serhiy! -- Added file: http://bugs.python.org/file33348/larry.simple.symbolic.constant.default.values.diff.4.txt ___ Python tracker <http://bugs.python.org/issue20

[issue20158] Argument Clinic: add --clean option

2014-01-07 Thread Larry Hastings
Larry Hastings added the comment: I must admit I am losing patience with this conversation. Argument Clinic is not going to provide an attractively-named option that breaks your build and requires fixing by hand. The bug is closed, the feature is not happening, it's my hope that we ca

[issue20144] Argument Clinic doesn't support named constants as default values

2014-01-07 Thread Larry Hastings
Larry Hastings added the comment: Argument Clinic now supports simple constants like "sys.maxsize" as default values for arguments for builtins. I'm assuming this gets you basically what you wanted; if this isn't sufficient please open a new issue. -- assignee:

[issue20141] Argument Clinic: broken support for 'O!'

2014-01-07 Thread Larry Hastings
Larry Hastings added the comment: Argument Clinic's support for "O!" is now simpler and more flexible. It's not as convenient as the previous API, but that API wasn't really sustainable. I'm assuming this fixes your problem; if not please open a new issue. --

[issue20157] Argument Clinic generates wrong keyword parameter name for "default"

2014-01-07 Thread Larry Hastings
Changes by Larry Hastings : -- resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python.or

[issue19723] Argument Clinic should add markers for humans

2014-01-07 Thread Larry Hastings
Larry Hastings added the comment: I'm assuming this is sufficient. If further bikeshedding is needed please reopen the issue. -- resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed ___ Python

[issue20161] inspect.signature fails on some functions which use Argument Clinic

2014-01-07 Thread Larry Hastings
Larry Hastings added the comment: Fixed as a side effect of fixing #20144. And by the way this was never a release blocker. -- assignee: -> larry priority: release blocker -> normal resolution: -> fixed stage: -> committed/rejected status: op

[issue20148] Derby: Convert the _sre module to use Argument Clinic

2014-01-07 Thread Larry Hastings
Larry Hastings added the comment: Can you refresh the patch? I think all the problems you cited are fixed, and also the comments Argument Clinic uses were all changed. I'll review when you have a fresh patch. -- title: Convert the _sre module to use Argument Clinic -> Derby:

[issue20133] Derby: Convert the audioop module to use Argument Clinic

2014-01-07 Thread Larry Hastings
Larry Hastings added the comment: Can you refresh the patch? I think all the problems you cited are fixed, and also the comments Argument Clinic uses were all changed. I'll review when you have a fresh patch. -- title: Convert the audioop module to use Argument Clinic -&g

[issue20151] Derby: Convert the binascii module to use Argument Clinic

2014-01-07 Thread Larry Hastings
Larry Hastings added the comment: Can you refresh the patch? The comments Argument Clinic uses were all changed. I'll review when you have a fresh patch. -- title: Convert the binascii module to use Argument Clinic -> Derby: Convert the binascii module to use Argumen

[issue20159] Derby: Convert the ElementTree module to use Argument Clinic

2014-01-07 Thread Larry Hastings
Larry Hastings added the comment: Can you refresh the patch? The comments Argument Clinic uses were all changed. I'll review when you have a fresh patch. And I'll look at __init__ and subelement then. -- title: Convert the ElementTree module to use Argument Clinic -> D

<    7   8   9   10   11   12   13   14   15   16   >