[issue35488] pathlib Path.match does not behave as described

2018-12-14 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +serhiy.storchaka ___ Python tracker <https://bugs.python.org/issue35488> ___ ___ Python-bugs-list mailin

[issue35508] array.index should take optional start and stop indices like for lists

2018-12-15 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Please see issue31956 that has an open PR and discussion. -- nosy: +xtreak ___ Python tracker <https://bugs.python.org/issue35

[issue35508] array.index should take optional start and stop indices like for lists

2018-12-15 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: No problem. I adding duplicate as resolution linking to issue31956. Feel free to add yourself on issue31956 to keep track of it. Thanks -- resolution: -> duplicate superseder: -> Add start and stop parameters to the array

[issue35510] pickling derived dataclasses

2018-12-15 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +eric.smith ___ Python tracker <https://bugs.python.org/issue35510> ___ ___ Python-bugs-list mailing list Unsub

[issue35500] Align expected and actual calls on mock.assert_called_with error message

2018-12-15 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Thanks Mario for the feedback. The alignment was just a personal preference of mine. I agree with you on adding "Expected call not found" next to AssertionError. I will wait if others have more feedback on this before proceeding

[issue31855] mock_open is not compatible with read(n) (and pickle.load)

2018-12-16 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Internally mock_open implementation uses line based iteration [0] to keep track of the state change between read calls. So readline too ignores the argument. There is issue25690 for an alternate mock_open implementation but the code change is

[issue25430] speed up ipaddress __contain__ method

2018-12-16 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Though this is out of the scope of the issue I tried converting num_addresses, __hash__, __getitem__ and __eq__ as per Serhiy's idea for IPv6Network replacing the stdlib implementation's int calls with _ip in a custom class. I can see

[issue35518] test_timeout uses blackhole.snakebite.net domain which doesn't exist anymore

2018-12-17 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Related : issue31562 -- nosy: +xtreak ___ Python tracker <https://bugs.python.org/issue35518> ___ ___ Python-bug

[issue35530] Counter-intuitive logging API

2018-12-19 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: The output is the same in 3.8. I think this is due to propagation to the root logger after logging.error call. When logger.error is called with no handler attached to it then root logger handler is called and root handler's format is used. Th

[issue35530] Counter-intuitive logging API

2018-12-19 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: > If you have 3.8 installed, feel free to test the code yourself and report > what happens. I tested it on master and it's the same as per the original report. ➜ cpython git:(master) cat ../backups/bpo35530_1.py import log

[issue35535] time.strptime() unexpectedly gives the same result for %U and %W for 2018

2018-12-19 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: The results from ruby are the same as Python master as a data point. From the docs %U - Week number of the year (Sunday as the first day of the week) as a zero padded decimal number. All days in a new year preceding the first Sunday are

[issue29081] time.strptime() return wrong result

2018-12-19 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: This causes the round trip to be a ValueError. ./python.exe Python 3.8.0a0 (heads/master:1dd035954b, Dec 18 2018, 10:12:34) [Clang 7.0.2 (clang-700.1.81)] on darwin Type "help", "copyright", "credits" or "licens

[issue35538] splitext does not seems to handle filepath ending in .

2018-12-19 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Is this similar to previous discussions about leading and trailing dots ? https://bugs.python.org/issue34931#msg328820 -- nosy: +xtreak ___ Python tracker <https://bugs.python.org/issue35

[issue30802] datetime.datetime.strptime('200722', '%Y%U')

2018-12-19 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +xtreak versions: +Python 3.7, Python 3.8 -Python 3.3, Python 3.4, Python 3.5, Python 3.6 ___ Python tracker <https://bugs.python.org/issue30

[issue35542] stack exhaustion in 3.6.7

2018-12-19 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Related older issue : issue1110055 https://docs.python.org/3/library/sys.html#sys.setrecursionlimit > The highest possible limit is platform-dependent. A user may need to set the > limit higher when they have a program that requires deep rec

[issue21478] mock calls don't propagate to parent (autospec)

2018-12-20 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: I think this should be handled in _check_and_set_parent where if value's type is FunctionType then value.mock should be used against which parent and name should be set since create_autospec returns function with mock attached to 'mock&

[issue21478] mock calls don't propagate to parent (autospec)

2018-12-20 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- keywords: +patch pull_requests: +10508 stage: needs patch -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue24928] mock.patch.dict spoils order of items in collections.OrderedDict

2018-12-20 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Thinking about it further the attached test is based on the ordering of dict and hence works only on 3.6 and above. But this test will be backported to mock on PyPI where this will fail on 2.7 and 3.4, 3.5. Is it okay to apply the fix that makes

[issue24928] mock.patch.dict spoils order of items in collections.OrderedDict

2018-12-21 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Thanks Mario, I will convert the unit test as a PR before closing the issue since I feel the test is a good one for inclusion and can help if dict order guarantee is changed in future. I will raise a backport PR to cabal's mock repo where th

[issue35557] Allow lowercase hexadecimal characters in base64.b16decode()

2018-12-21 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Thanks for the report. A couple of points as below : * This changes the interface of the function by removing a parameter. Thus it will break compatibility with Python 2 and also earlier versions of Python 3. Removing a parameter in the signature

[issue35559] Optimize base64.b16decode to use compiled regex

2018-12-21 Thread Karthikeyan Singaravelan
New submission from Karthikeyan Singaravelan : I came across this as a result of issue35557 and thought to make a new issue to keep the discussion separate. Currently the b16decode function uses a regex with re.search that can be compiled at the module level as a static variable to give up

[issue35559] Optimize base64.b16decode to use compiled regex

2018-12-22 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Thanks @scoder . I took the convention since most of the places I have seen capitalized variable ending with PAT but this looks more readable to me. I have made the changes in my PR. -- ___ Python

[issue35559] Optimize base64.b16decode to use compiled regex

2018-12-22 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: > How this affects the import time (use -X importtime)? Is there reliable way to benchmark this? On multiple runs with regex for python3 -X importtime -c 'import base64' import time: 677 | 11151 | base64 On multiple runs

[issue35009] argparse throws UnicodeEncodeError for printing help with unicode choices

2018-12-22 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Thanks Serhiy, I have limited knowledge of unicode and hence I thought this to be a fix. I am closing this as per msg332337 and the PR I opened for issue24307 (Feel free to close issue24307 as per Victor's resolution if n

[issue35559] Optimize base64.b16decode to use compiled regex

2018-12-22 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Thanks Serhiy, the other issue noted about performance improvement removing casefold and I thought re.search per call to be inefficient. My bad that I didn't consider the cost of moving the compilation to module level that affects import tim

[issue35560] format(float(123), "00") causes segfault in debug builds

2018-12-22 Thread Karthikeyan Singaravelan
New submission from Karthikeyan Singaravelan : I was looking into format issues and came across msg99839 . The example causes segfault in master, 3.7 and 3.6 branches. This used to pass in 3.7 and 3.6. I searched for open issues and cannot come across an issue for this. I guess this is

[issue35432] str.format and string.Formatter bug with French (and other) locale

2018-12-22 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +vstinner ___ Python tracker <https://bugs.python.org/issue35432> ___ ___ Python-bugs-list mailing list Unsub

[issue35121] Cookie domain check returns incorrect results

2018-12-22 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Looking further into this the domain validation makes it little more stricter and can have wider implications. For example requests library uses cookiejar to maintain cookies between sessions. One more case is that `domain` can be empty so only

[issue35500] Align expected and actual calls on mock.assert_called_with error message

2018-12-22 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Thanks for the feedback. I personally prefer 'expected' than 'expect' though it comes at the cost that this cannot be aligned with 'actual'. Other places use 'expected' and it r

[issue35560] format(float(123), "00") causes segfault in debug builds

2018-12-22 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Looking into the code min_width is returned as -2 and hence the assert fails. spec->n_min_width is passed as min_width to _PyUnicode_InsertThousandsGrouping that is used in the assert statement and I came across below comment that min_width can

[issue35560] format(float(123), "00") causes segfault in debug builds

2018-12-22 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Sure, I will create one shortly. There were some other cases with different values of negative numbers that I will add since I couldn't see any tests failing on my debug builds. * Are there chances that bugs like these are present since I

[issue35560] format(float(123), "00") causes segfault in debug builds

2018-12-22 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: > This bug is not new, and this is the first report for it. It can be treated > as a security issue if an application allows user to specify format string. > But using a format string from untrusted source causes a security issue > its

[issue35560] format(float(123), "00") causes segfault in debug builds

2018-12-22 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: > min_width сan be large negative number, and there are subtractions from it. > It may be safer to replace the assert with something like min_width = > Py_MAX(0, min_width). Or ensure that it is non-negative befor

[issue35563] Doc: warnings.rst - add links to references

2018-12-22 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- keywords: +patch pull_requests: +10514 stage: -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue35563] Doc: warnings.rst - add links to references

2018-12-22 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: @cheryl.sabella You're welcome. PR was not automatically added to couple of my issues too today though the PR description and issue number check was updated by bedevere-bot. I don't know if it's a random issue. -

[issue35563] Doc: warnings.rst - add links to references

2018-12-22 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: You can bring this up at https://python.zulipchat.com/#narrow/stream/116501-workflow and someone might help. -- ___ Python tracker <https://bugs.python.org/issue35

[issue33661] urllib may leak sensitive HTTP headers to a third-party web site

2018-12-22 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker <https://bugs.python.org/issue33661> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35564] [DOC] Sphinx 2.0 will require master_doc variable set in conf.py

2018-12-23 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +mdk ___ Python tracker <https://bugs.python.org/issue35564> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35570] 2to3 creates code using deprecated imp module

2018-12-23 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Seems this came up when the original version of fixer was added as noted in https://bugs.python.org/issue11797#msg206884 . Looking further this seems to be similar to https://bugs.python.org/issue21446 where it was fixed in 3.7 and master to use

[issue35573] is_HDN is returns false positive and false negative value for two test cases respectively

2018-12-23 Thread Karthikeyan Singaravelan
New submission from Karthikeyan Singaravelan : Can you please add a reproducible test case and a description to the issue explaining expected behavior and actual behavior? Thanks -- nosy: +xtreak ___ Python tracker <https://bugs.python.

[issue35576] function splitextTest does not return expected value

2018-12-23 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Thanks for the report > 1. For input ".blah." output is "." Please see issue35538 > 2. For input "..." output is "..." Please find the tests at https://github.com/python/cpython/blob/master/Lib

[issue35573] is_HDN is returns false positive and false negative value for two test cases respectively

2018-12-23 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: > What is the module "cookiejar" you are importing? Is that a third-party > module? It doesn't seem to be in the standard library. There is a module > `http.cookiejar` but it doesn't seem to have an `is_HDN` fu

[issue35581] Document @typing.type_check_only

2018-12-25 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +gvanrossum, levkivskyi ___ Python tracker <https://bugs.python.org/issue35581> ___ ___ Python-bugs-list mailin

[issue35559] Optimize base64.b16decode to use compiled regex

2018-12-26 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Thanks for the feedback. I am closing this as rejected since it's not worth the cost of increasing import time and for performance reasons there are other options as Serhiy noted in msg332339. -- resolution: -> rejected stag

[issue24928] mock.patch.dict spoils order of items in collections.OrderedDict

2018-12-26 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Hi Vaibhav, As noted in the thread the issue is fixed in 3.6 and above due to dict order being guaranteed. But it would be nice to have the test in the patch converted as a unit test. With respect to backport the fixes are backported to https

[issue35121] Cookie domain check returns incorrect results

2018-12-26 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Also looking at the docs for different frameworks like [Flask](http://flask.pocoo.org/docs/1.0/api/#flask.Response.set_cookie) and [Django](https://docs.djangoproject.com/en/2.1/ref/request-response/#django.http.HttpResponse.set_cookie) they

[issue35121] Cookie domain check returns incorrect results

2018-12-27 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: I have come across another behavior change between path checks while using the cookie jar implementation available in Python. This is related to incorrect cookie validation but with respect to path so let me know if this needs a separate ticket. I

[issue35587] Python 3.7.2 Embed - zipimport.ZipImportError (Cannot load python37.zip)

2018-12-27 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: This seems to be related to issue35596. -- nosy: +serhiy.storchaka, steve.dower, xtreak ___ Python tracker <https://bugs.python.org/issue35

[issue35603] table header in output of difflib.HtmlDiff.make_table is not escaped and can be rendered as code in the browser

2018-12-28 Thread Karthikeyan Singaravelan
New submission from Karthikeyan Singaravelan : HtmlDiff.make_table takes fromdesc and todesc that are not escaped causing problems while rendering html when they contain tags like fromdesc="", todesc="". There is no validation for them to be filenames so they could b

[issue35603] table header in output of difflib.HtmlDiff.make_table is not escaped and can be rendered as code in the browser

2018-12-28 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- keywords: +patch, patch pull_requests: +10624, 10625 stage: -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue35603] table header in output of difflib.HtmlDiff.make_table is not escaped and can be rendered as code in the browser

2018-12-28 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- keywords: +patch pull_requests: +10624 stage: -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue35603] table header in output of difflib.HtmlDiff.make_table is not escaped and can be rendered as code in the browser

2018-12-28 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- keywords: +patch, patch, patch pull_requests: +10624, 10625, 10626 stage: -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue35604] Is python used more than Java Nowadays?

2018-12-28 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Please add some context over what this has to do with performance and docs category. The tracker might not be the appropriate place to have language debates. Please specify the outcome of the issue since your description has no actionable item or

[issue35595] Add sys flag to always show full paths in stack traces (instead of relative paths)

2018-12-28 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker <https://bugs.python.org/issue35595> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

2018-12-28 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +mdk, steve.dower ___ Python tracker <https://bugs.python.org/issue35605> ___ ___ Python-bugs-list mailin

[issue35606] Add prod() function to the math module

2018-12-28 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker <https://bugs.python.org/issue35606> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35603] table header in output of difflib.HtmlDiff.make_table is not escaped and can be rendered as code in the browser

2018-12-29 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Yes, 2.7 is also affected at https://github.com/python/cpython/blob/befe3f7afdc5279b320af88a9e57f682c0172599/Lib/difflib.py#L2001 . I think it was missed during the initial addition in issue914575 and no one would be using it as a feature to have

[issue35603] table header in output of difflib.HtmlDiff.make_table is not escaped and can be rendered as code in the browser

2018-12-29 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Thanks Serhiy for the input. I initially thought this should be escaped since content was escaped and the same for header since user input taken directly could result in XSS. Maybe someone might using this undocumented feature intentionally that

[issue35618] Allow users to set suffix list in cookiejar policy

2018-12-30 Thread Karthikeyan Singaravelan
New submission from Karthikeyan Singaravelan : cookiejar has a fixed set of public suffixes [0] on which cookies cannot be set when strict_domain is enabled. rfc6265 recommends rejecting cookies being set directly on domain which are public suffixes. The current list was last updated at

[issue35623] Segfault in test_bigmem.ListTest.test_sort

2018-12-30 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +serhiy.storchaka ___ Python tracker <https://bugs.python.org/issue35623> ___ ___ Python-bugs-list mailin

[issue35647] Cookie path check returns incorrect results

2019-01-03 Thread Karthikeyan Singaravelan
New submission from Karthikeyan Singaravelan : I came across the issue during https://bugs.python.org/issue35121#msg332583 . I think this can be dealt as a separate issue not blocking the original report. I am classifying it as security but can be reclassified as a bug fix given the section

[issue35121] Cookie domain check returns incorrect results

2019-01-03 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: I have opened issue35647 for path related checks as a separate report. -- ___ Python tracker <https://bugs.python.org/issue35

[issue35218] decompressing and then re-compressing zipfiles with Python 3 zipfile loses flag_bits

2019-01-03 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +serhiy.storchaka ___ Python tracker <https://bugs.python.org/issue35218> ___ ___ Python-bugs-list mailin

[issue35325] imp.find_module() return value documentation discrepancy

2019-01-04 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +brett.cannon versions: -Python 3.4, Python 3.5, Python 3.6 ___ Python tracker <https://bugs.python.org/issue35

[issue34439] Expose venv --prompt value to an environment value

2019-01-04 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: issue35328 seems like a related issue with a PR that sets VIRTUAL_ENV_PROMPT. Also see issue35661 to store the venv prompt in config file. -- nosy: +xtreak versions: -Python 3.5, Python 3.6, Python 3.7

[issue35328] Set a environment variable for venv prompt

2019-01-04 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: issue34439 seems like a similar proposal. I am adding @vinay.sajip. Since this seems like a new feature I have removed 3.7 from the version list. -- components: +Library (Lib) nosy: +vinay.sajip, xtreak type: -> enhancement versi

[issue35647] Cookie path check returns incorrect results

2019-01-04 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- keywords: +patch, patch pull_requests: +10868, 10869 stage: -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue35647] Cookie path check returns incorrect results

2019-01-04 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- keywords: +patch pull_requests: +10868 stage: -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue35647] Cookie path check returns incorrect results

2019-01-04 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- keywords: +patch, patch, patch pull_requests: +10868, 10869, 10870 stage: -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue35634] kwargs regression when there are multiple entries with the same key

2019-01-05 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: > (Just curious, what does d['a'] return?) I was curious too and some results $ python Python 3.7.1rc2 (v3.7.1rc2:6c06ef7dc3, Oct 13 2018, 05:10:29) [Clang 6.0 (clang-600.0.57)] on darwin Type "help", "copyright"

[issue24928] mock.patch.dict spoils order of items in collections.OrderedDict

2019-01-05 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Can you please post the error and the command to run the test? On applying the patch on master I cannot see any errors with below commands : # Applying the patch with only test $ wget https://bugs.python.org/file40488/issue24928.patch $ git apply

[issue24928] mock.patch.dict spoils order of items in collections.OrderedDict

2019-01-05 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: No problem :) I think the test can use a context manager instead of using test() and a decorator but that can be discussed on the PR. Thanks! -- ___ Python tracker <https://bugs.python.org/issue24

[issue35603] table header in output of difflib.HtmlDiff.make_table is not escaped and can be rendered as code in the browser

2019-01-05 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- pull_requests: +10878, 10879 stage: needs patch -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue35603] table header in output of difflib.HtmlDiff.make_table is not escaped and can be rendered as code in the browser

2019-01-05 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- pull_requests: +10878, 10879, 10880 stage: needs patch -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue35603] table header in output of difflib.HtmlDiff.make_table is not escaped and can be rendered as code in the browser

2019-01-05 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- pull_requests: +10878 stage: needs patch -> patch review ___ Python tracker <https://bugs.python.org/issue35603> ___ _

[issue35603] table header in output of difflib.HtmlDiff.make_table is not escaped and can be rendered as code in the browser

2019-01-05 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: I have added a doc note under make_file docs which has docs for fromdesc and todesc. make_table refers to make_file for fromdesc and todesc docs. I have added a screenshot of the rendering using note and warning directive. I feel note directive is

[issue35669] tar symlink

2019-01-06 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Thanks for the report. Is this similar to issue21109? -- nosy: +xtreak ___ Python tracker <https://bugs.python.org/issue35

[issue35667] activate for venv containing apostrophe doesn't work in powershell

2019-01-06 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: >From the error I think the quotes are not properly escaped while doing text >replacement in venv activate file template at [0] while it's generated? On >linux/Mac double quotes are used and hence the error is not triggered with &g

[issue34173] [3.7] deadlock in /usr/lib/python3.7/concurrent/futures/thread.py

2019-01-07 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Thanks for the info. I am closing it as third party. -- resolution: -> third party stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue35676] unittest assert helper methods have incorrect signature in docs

2019-01-07 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Thanks for the report. Looking at git history it seems there were some changes done in issue10573 to use (actual, expected) for consistency and later changed to use (first, second) in the same issue at msg126911. Discussion for the issue : https

[issue26467] Add async magic method support to unittest.mock.Mock

2019-01-07 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker <https://bugs.python.org/issue26467> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35656] More matchers in unittest.mock

2019-01-07 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Looking at the code ANY is simply implemented with __eq__ always returning True at https://github.com/python/cpython/blob/e61cc481e02b758c8d8289163102c236d0658a55/Lib/unittest/mock.py#L1957 . I am not sure how APPROXIMATE can be implemented in

[issue35684] Windows "embedded" Python downloads are malformed

2019-01-08 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Seems this is fixed as part of related issue issue35596 -- nosy: +xtreak ___ Python tracker <https://bugs.python.org/issue35

[issue35684] Windows "embedded" Python downloads are malformed

2019-01-08 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- stage: -> resolved superseder: -> Fatal Python error: initfsencoding: unable to load the file system codec zipimport.ZipImportError: can't find module 'encodings' ___ P

[issue35686] memoryview contextmanager causing strange crash

2019-01-08 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Thanks for the report. Can you please add a simple reproducer in Python with what the test is trying to do without dependencies from the project? perhaps with a sample of relevant files used by the test in Travis. -- nosy: +xtreak

[issue35687] The unittest module diff is missing/forgetting/not putting newline before + and ? for some inputs

2019-01-08 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker <https://bugs.python.org/issue35687> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35687] The unittest module diff is missing/forgetting/not putting newline before + and ? for some inputs

2019-01-08 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: This seems to exist on master. Since they are multilines assertMultiLineEqual is used and is there something incorrect during the diff calculation using ndiff due to absence of '\n'? The current diff is calculated as below with difflib

[issue35687] The unittest module diff is missing/forgetting/not putting newline before + and ? for some inputs

2019-01-08 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Searching further this seems to be reported earlier with issue24780 with caret displayed wrongly which was also due to newline missing. But the sample case reported here is also listed at one of the examples in https://bugs.python.org/issue24780

[issue24780] difflib.ndiff produces unreadable output when input missing trailing newline

2019-01-08 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +xtreak versions: +Python 3.7, Python 3.8 -Python 3.5, Python 3.6 ___ Python tracker <https://bugs.python.org/issue24

[issue35691] cpython3.7.2 make test failed

2019-01-08 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Searching for the error message I reported a very similar one in the past issue34177 that is caused due to installed python causing some problem being imported in the test -- nosy: +xtreak ___ Python

[issue35692] pathlib.Path.exists() on non-existent drive raises WinError instead of returning False

2019-01-08 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +eryksun ___ Python tracker <https://bugs.python.org/issue35692> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue24780] difflib.ndiff produces unreadable output when input missing trailing newline

2019-01-08 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Looking at the patch and the relevant function this doesn't seem to be a problem with difflib.ndiff but with unittest's display algorithm. This causes confusion about the issue and I propose changing the subject to reflect this unle

[issue35688] "pip install --user numpy" fails on Python from the Windows Store

2019-01-08 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- title: "pip install --user numpy" fails on Python from the Windos Store -> "pip install --user numpy" fails on Python from the Windows Store ___ Python tracker <https://

[issue24780] unittest assertEqual difference output foiled by newlines

2019-01-09 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Thanks @chris.jerdonek. I have reverted the title to original report. Since CPython now accepts PR if any one of the original authors can convert their patch to a PR with tests then it will be great. -- title: difflib.ndiff produces

[issue35702] clock_gettime: Add new identifier CLOCK_UPTIME_RAW for Darwin

2019-01-10 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker <https://bugs.python.org/issue35702> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35705] libffi support is not there for windows on ARM64

2019-01-10 Thread Karthikeyan Singaravelan
New submission from Karthikeyan Singaravelan : https://bugs.python.org/issue33125#msg314311 seems to be a related ticket that tracks this. -- nosy: +steve.dower, xtreak, zach.ware ___ Python tracker <https://bugs.python.org/issue35

[issue35708] lib2to3 failed to convert as refactor's fixes not search.pyc files

2019-01-10 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +benjamin.peterson ___ Python tracker <https://bugs.python.org/issue35708> ___ ___ Python-bugs-list mailin

[issue35709] test_ssl fails on Fedora 29: test_min_max_version()

2019-01-10 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Seems related https://bugs.python.org/issue35045 -- nosy: +xtreak ___ Python tracker <https://bugs.python.org/issue35

[issue35712] Make NotImplemented unusable in boolean context

2019-01-10 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Seems related issue22978 -- nosy: +xtreak ___ Python tracker <https://bugs.python.org/issue35712> ___ ___ Python-bug

[issue35713] Fatal Python error: _PySys_BeginInit: can't initialize sys module

2019-01-10 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Please attach the full build log too along with the command executed. -- nosy: +xtreak ___ Python tracker <https://bugs.python.org/issue35

<    13   14   15   16   17   18   19   20   21   22   >