Change by Karthikeyan Singaravelan :
--
nosy: +serhiy.storchaka
___
Python tracker
<https://bugs.python.org/issue35488>
___
___
Python-bugs-list mailin
Karthikeyan Singaravelan added the comment:
Please see issue31956 that has an open PR and discussion.
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue35
Karthikeyan Singaravelan added the comment:
No problem. I adding duplicate as resolution linking to issue31956. Feel free
to add yourself on issue31956 to keep track of it.
Thanks
--
resolution: -> duplicate
superseder: -> Add start and stop parameters to the array
Change by Karthikeyan Singaravelan :
--
nosy: +eric.smith
___
Python tracker
<https://bugs.python.org/issue35510>
___
___
Python-bugs-list mailing list
Unsub
Karthikeyan Singaravelan added the comment:
Thanks Mario for the feedback. The alignment was just a personal preference of
mine. I agree with you on adding "Expected call not found" next to
AssertionError. I will wait if others have more feedback on this before
proceeding
Karthikeyan Singaravelan added the comment:
Internally mock_open implementation uses line based iteration [0] to keep track
of the state change between read calls. So readline too ignores the argument.
There is issue25690 for an alternate mock_open implementation but the code
change is
Karthikeyan Singaravelan added the comment:
Though this is out of the scope of the issue I tried converting num_addresses,
__hash__, __getitem__ and __eq__ as per Serhiy's idea for IPv6Network replacing
the stdlib implementation's int calls with _ip in a custom class. I can see
Karthikeyan Singaravelan added the comment:
Related : issue31562
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue35518>
___
___
Python-bug
Karthikeyan Singaravelan added the comment:
The output is the same in 3.8. I think this is due to propagation to the root
logger after logging.error call. When logger.error is called with no handler
attached to it then root logger handler is called and root handler's format is
used. Th
Karthikeyan Singaravelan added the comment:
> If you have 3.8 installed, feel free to test the code yourself and report
> what happens.
I tested it on master and it's the same as per the original report.
➜ cpython git:(master) cat ../backups/bpo35530_1.py
import log
Karthikeyan Singaravelan added the comment:
The results from ruby are the same as Python master as a data point. From the
docs
%U - Week number of the year (Sunday as the first day of the week) as a zero
padded decimal number. All days in a new year preceding the first Sunday are
Karthikeyan Singaravelan added the comment:
This causes the round trip to be a ValueError.
./python.exe
Python 3.8.0a0 (heads/master:1dd035954b, Dec 18 2018, 10:12:34)
[Clang 7.0.2 (clang-700.1.81)] on darwin
Type "help", "copyright", "credits" or "licens
Karthikeyan Singaravelan added the comment:
Is this similar to previous discussions about leading and trailing dots ?
https://bugs.python.org/issue34931#msg328820
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue35
Change by Karthikeyan Singaravelan :
--
nosy: +xtreak
versions: +Python 3.7, Python 3.8 -Python 3.3, Python 3.4, Python 3.5, Python
3.6
___
Python tracker
<https://bugs.python.org/issue30
Karthikeyan Singaravelan added the comment:
Related older issue : issue1110055
https://docs.python.org/3/library/sys.html#sys.setrecursionlimit
> The highest possible limit is platform-dependent. A user may need to set the
> limit higher when they have a program that requires deep rec
Karthikeyan Singaravelan added the comment:
I think this should be handled in _check_and_set_parent where if value's type
is FunctionType then value.mock should be used against which parent and name
should be set since create_autospec returns function with mock attached to
'mock&
Change by Karthikeyan Singaravelan :
--
keywords: +patch
pull_requests: +10508
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Karthikeyan Singaravelan added the comment:
Thinking about it further the attached test is based on the ordering of dict
and hence works only on 3.6 and above. But this test will be backported to mock
on PyPI where this will fail on 2.7 and 3.4, 3.5. Is it okay to apply the fix
that makes
Karthikeyan Singaravelan added the comment:
Thanks Mario, I will convert the unit test as a PR before closing the issue
since I feel the test is a good one for inclusion and can help if dict order
guarantee is changed in future. I will raise a backport PR to cabal's mock repo
where th
Karthikeyan Singaravelan added the comment:
Thanks for the report. A couple of points as below :
* This changes the interface of the function by removing a parameter. Thus it
will break compatibility with Python 2 and also earlier versions of Python 3.
Removing a parameter in the signature
New submission from Karthikeyan Singaravelan :
I came across this as a result of issue35557 and thought to make a new issue to
keep the discussion separate. Currently the b16decode function uses a regex
with re.search that can be compiled at the module level as a static variable to
give up
Karthikeyan Singaravelan added the comment:
Thanks @scoder . I took the convention since most of the places I have seen
capitalized variable ending with PAT but this looks more readable to me. I have
made the changes in my PR.
--
___
Python
Karthikeyan Singaravelan added the comment:
> How this affects the import time (use -X importtime)?
Is there reliable way to benchmark this?
On multiple runs with regex for python3 -X importtime -c 'import base64'
import time: 677 | 11151 | base64
On multiple runs
Karthikeyan Singaravelan added the comment:
Thanks Serhiy, I have limited knowledge of unicode and hence I thought this to
be a fix. I am closing this as per msg332337 and the PR I opened for issue24307
(Feel free to close issue24307 as per Victor's resolution if n
Karthikeyan Singaravelan added the comment:
Thanks Serhiy, the other issue noted about performance improvement removing
casefold and I thought re.search per call to be inefficient. My bad that I
didn't consider the cost of moving the compilation to module level that affects
import tim
New submission from Karthikeyan Singaravelan :
I was looking into format issues and came across msg99839 . The example causes
segfault in master, 3.7 and 3.6 branches. This used to pass in 3.7 and 3.6. I
searched for open issues and cannot come across an issue for this. I guess this
is
Change by Karthikeyan Singaravelan :
--
nosy: +vstinner
___
Python tracker
<https://bugs.python.org/issue35432>
___
___
Python-bugs-list mailing list
Unsub
Karthikeyan Singaravelan added the comment:
Looking further into this the domain validation makes it little more stricter
and can have wider implications. For example requests library uses cookiejar to
maintain cookies between sessions. One more case is that `domain` can be empty
so only
Karthikeyan Singaravelan added the comment:
Thanks for the feedback. I personally prefer 'expected' than 'expect' though it
comes at the cost that this cannot be aligned with 'actual'. Other places use
'expected' and it r
Karthikeyan Singaravelan added the comment:
Looking into the code min_width is returned as -2 and hence the assert fails.
spec->n_min_width is passed as min_width to _PyUnicode_InsertThousandsGrouping
that is used in the assert statement and I came across below comment that
min_width can
Karthikeyan Singaravelan added the comment:
Sure, I will create one shortly. There were some other cases with different
values of negative numbers that I will add since I couldn't see any tests
failing on my debug builds.
* Are there chances that bugs like these are present since I
Karthikeyan Singaravelan added the comment:
> This bug is not new, and this is the first report for it. It can be treated
> as a security issue if an application allows user to specify format string.
> But using a format string from untrusted source causes a security issue
> its
Karthikeyan Singaravelan added the comment:
> min_width сan be large negative number, and there are subtractions from it.
> It may be safer to replace the assert with something like min_width =
> Py_MAX(0, min_width). Or ensure that it is non-negative befor
Change by Karthikeyan Singaravelan :
--
keywords: +patch
pull_requests: +10514
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Karthikeyan Singaravelan added the comment:
@cheryl.sabella You're welcome. PR was not automatically added to couple of my
issues too today though the PR description and issue number check was updated
by bedevere-bot. I don't know if it's a random issue.
-
Karthikeyan Singaravelan added the comment:
You can bring this up at
https://python.zulipchat.com/#narrow/stream/116501-workflow and someone might
help.
--
___
Python tracker
<https://bugs.python.org/issue35
Change by Karthikeyan Singaravelan :
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue33661>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Karthikeyan Singaravelan :
--
nosy: +mdk
___
Python tracker
<https://bugs.python.org/issue35564>
___
___
Python-bugs-list mailing list
Unsubscribe:
Karthikeyan Singaravelan added the comment:
Seems this came up when the original version of fixer was added as noted in
https://bugs.python.org/issue11797#msg206884 . Looking further this seems to be
similar to https://bugs.python.org/issue21446 where it was fixed in 3.7 and
master to use
New submission from Karthikeyan Singaravelan :
Can you please add a reproducible test case and a description to the issue
explaining expected behavior and actual behavior?
Thanks
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.
Karthikeyan Singaravelan added the comment:
Thanks for the report
> 1. For input ".blah." output is "."
Please see issue35538
> 2. For input "..." output is "..."
Please find the tests at
https://github.com/python/cpython/blob/master/Lib
Karthikeyan Singaravelan added the comment:
> What is the module "cookiejar" you are importing? Is that a third-party
> module? It doesn't seem to be in the standard library. There is a module
> `http.cookiejar` but it doesn't seem to have an `is_HDN` fu
Change by Karthikeyan Singaravelan :
--
nosy: +gvanrossum, levkivskyi
___
Python tracker
<https://bugs.python.org/issue35581>
___
___
Python-bugs-list mailin
Karthikeyan Singaravelan added the comment:
Thanks for the feedback. I am closing this as rejected since it's not worth the
cost of increasing import time and for performance reasons there are other
options as Serhiy noted in msg332339.
--
resolution: -> rejected
stag
Karthikeyan Singaravelan added the comment:
Hi Vaibhav,
As noted in the thread the issue is fixed in 3.6 and above due to dict order
being guaranteed. But it would be nice to have the test in the patch converted
as a unit test. With respect to backport the fixes are backported to
https
Karthikeyan Singaravelan added the comment:
Also looking at the docs for different frameworks like
[Flask](http://flask.pocoo.org/docs/1.0/api/#flask.Response.set_cookie) and
[Django](https://docs.djangoproject.com/en/2.1/ref/request-response/#django.http.HttpResponse.set_cookie)
they
Karthikeyan Singaravelan added the comment:
I have come across another behavior change between path checks while using the
cookie jar implementation available in Python. This is related to incorrect
cookie validation but with respect to path so let me know if this needs a
separate ticket. I
Karthikeyan Singaravelan added the comment:
This seems to be related to issue35596.
--
nosy: +serhiy.storchaka, steve.dower, xtreak
___
Python tracker
<https://bugs.python.org/issue35
New submission from Karthikeyan Singaravelan :
HtmlDiff.make_table takes fromdesc and todesc that are not escaped causing
problems while rendering html when they contain tags like fromdesc="",
todesc="". There is no validation for them to be filenames so they could b
Change by Karthikeyan Singaravelan :
--
keywords: +patch, patch
pull_requests: +10624, 10625
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Karthikeyan Singaravelan :
--
keywords: +patch
pull_requests: +10624
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Karthikeyan Singaravelan :
--
keywords: +patch, patch, patch
pull_requests: +10624, 10625, 10626
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Karthikeyan Singaravelan added the comment:
Please add some context over what this has to do with performance and docs
category. The tracker might not be the appropriate place to have language
debates. Please specify the outcome of the issue since your description has no
actionable item or
Change by Karthikeyan Singaravelan :
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue35595>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Karthikeyan Singaravelan :
--
nosy: +mdk, steve.dower
___
Python tracker
<https://bugs.python.org/issue35605>
___
___
Python-bugs-list mailin
Change by Karthikeyan Singaravelan :
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue35606>
___
___
Python-bugs-list mailing list
Unsubscribe:
Karthikeyan Singaravelan added the comment:
Yes, 2.7 is also affected at
https://github.com/python/cpython/blob/befe3f7afdc5279b320af88a9e57f682c0172599/Lib/difflib.py#L2001
. I think it was missed during the initial addition in issue914575 and no one
would be using it as a feature to have
Karthikeyan Singaravelan added the comment:
Thanks Serhiy for the input. I initially thought this should be escaped since
content was escaped and the same for header since user input taken directly
could result in XSS. Maybe someone might using this undocumented feature
intentionally that
New submission from Karthikeyan Singaravelan :
cookiejar has a fixed set of public suffixes [0] on which cookies cannot be set
when strict_domain is enabled. rfc6265 recommends rejecting cookies being set
directly on domain which are public suffixes. The current list was last updated
at
Change by Karthikeyan Singaravelan :
--
nosy: +serhiy.storchaka
___
Python tracker
<https://bugs.python.org/issue35623>
___
___
Python-bugs-list mailin
New submission from Karthikeyan Singaravelan :
I came across the issue during https://bugs.python.org/issue35121#msg332583 . I
think this can be dealt as a separate issue not blocking the original report. I
am classifying it as security but can be reclassified as a bug fix given the
section
Karthikeyan Singaravelan added the comment:
I have opened issue35647 for path related checks as a separate report.
--
___
Python tracker
<https://bugs.python.org/issue35
Change by Karthikeyan Singaravelan :
--
nosy: +serhiy.storchaka
___
Python tracker
<https://bugs.python.org/issue35218>
___
___
Python-bugs-list mailin
Change by Karthikeyan Singaravelan :
--
nosy: +brett.cannon
versions: -Python 3.4, Python 3.5, Python 3.6
___
Python tracker
<https://bugs.python.org/issue35
Karthikeyan Singaravelan added the comment:
issue35328 seems like a related issue with a PR that sets VIRTUAL_ENV_PROMPT.
Also see issue35661 to store the venv prompt in config file.
--
nosy: +xtreak
versions: -Python 3.5, Python 3.6, Python 3.7
Karthikeyan Singaravelan added the comment:
issue34439 seems like a similar proposal. I am adding @vinay.sajip. Since this
seems like a new feature I have removed 3.7 from the version list.
--
components: +Library (Lib)
nosy: +vinay.sajip, xtreak
type: -> enhancement
versi
Change by Karthikeyan Singaravelan :
--
keywords: +patch, patch
pull_requests: +10868, 10869
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Karthikeyan Singaravelan :
--
keywords: +patch
pull_requests: +10868
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Karthikeyan Singaravelan :
--
keywords: +patch, patch, patch
pull_requests: +10868, 10869, 10870
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issu
Karthikeyan Singaravelan added the comment:
> (Just curious, what does d['a'] return?)
I was curious too and some results
$ python
Python 3.7.1rc2 (v3.7.1rc2:6c06ef7dc3, Oct 13 2018, 05:10:29)
[Clang 6.0 (clang-600.0.57)] on darwin
Type "help", "copyright"
Karthikeyan Singaravelan added the comment:
Can you please post the error and the command to run the test? On applying the
patch on master I cannot see any errors with below commands :
# Applying the patch with only test
$ wget https://bugs.python.org/file40488/issue24928.patch
$ git apply
Karthikeyan Singaravelan added the comment:
No problem :) I think the test can use a context manager instead of using
test() and a decorator but that can be discussed on the PR.
Thanks!
--
___
Python tracker
<https://bugs.python.org/issue24
Change by Karthikeyan Singaravelan :
--
pull_requests: +10878, 10879
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Karthikeyan Singaravelan :
--
pull_requests: +10878, 10879, 10880
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Karthikeyan Singaravelan :
--
pull_requests: +10878
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issue35603>
___
_
Karthikeyan Singaravelan added the comment:
I have added a doc note under make_file docs which has docs for fromdesc and
todesc. make_table refers to make_file for fromdesc and todesc docs. I have
added a screenshot of the rendering using note and warning directive. I feel
note directive is
Karthikeyan Singaravelan added the comment:
Thanks for the report. Is this similar to issue21109?
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue35
Karthikeyan Singaravelan added the comment:
>From the error I think the quotes are not properly escaped while doing text
>replacement in venv activate file template at [0] while it's generated? On
>linux/Mac double quotes are used and hence the error is not triggered with
&g
Karthikeyan Singaravelan added the comment:
Thanks for the info. I am closing it as third party.
--
resolution: -> third party
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Karthikeyan Singaravelan added the comment:
Thanks for the report. Looking at git history it seems there were some changes
done in issue10573 to use (actual, expected) for consistency and later changed
to use (first, second) in the same issue at msg126911. Discussion for the issue
: https
Change by Karthikeyan Singaravelan :
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue26467>
___
___
Python-bugs-list mailing list
Unsubscribe:
Karthikeyan Singaravelan added the comment:
Looking at the code ANY is simply implemented with __eq__ always returning True
at
https://github.com/python/cpython/blob/e61cc481e02b758c8d8289163102c236d0658a55/Lib/unittest/mock.py#L1957
. I am not sure how APPROXIMATE can be implemented in
Karthikeyan Singaravelan added the comment:
Seems this is fixed as part of related issue issue35596
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue35
Change by Karthikeyan Singaravelan :
--
stage: -> resolved
superseder: -> Fatal Python error: initfsencoding: unable to load the file
system codec zipimport.ZipImportError: can't find module 'encodings'
___
P
Karthikeyan Singaravelan added the comment:
Thanks for the report. Can you please add a simple reproducer in Python with
what the test is trying to do without dependencies from the project? perhaps
with a sample of relevant files used by the test in Travis.
--
nosy: +xtreak
Change by Karthikeyan Singaravelan :
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue35687>
___
___
Python-bugs-list mailing list
Unsubscribe:
Karthikeyan Singaravelan added the comment:
This seems to exist on master. Since they are multilines assertMultiLineEqual
is used and is there something incorrect during the diff calculation using
ndiff due to absence of '\n'? The current diff is calculated as below with
difflib
Karthikeyan Singaravelan added the comment:
Searching further this seems to be reported earlier with issue24780 with caret
displayed wrongly which was also due to newline missing. But the sample case
reported here is also listed at one of the examples in
https://bugs.python.org/issue24780
Change by Karthikeyan Singaravelan :
--
nosy: +xtreak
versions: +Python 3.7, Python 3.8 -Python 3.5, Python 3.6
___
Python tracker
<https://bugs.python.org/issue24
Karthikeyan Singaravelan added the comment:
Searching for the error message I reported a very similar one in the past
issue34177 that is caused due to installed python causing some problem being
imported in the test
--
nosy: +xtreak
___
Python
Change by Karthikeyan Singaravelan :
--
nosy: +eryksun
___
Python tracker
<https://bugs.python.org/issue35692>
___
___
Python-bugs-list mailing list
Unsubscribe:
Karthikeyan Singaravelan added the comment:
Looking at the patch and the relevant function this doesn't seem to be a
problem with difflib.ndiff but with unittest's display algorithm. This causes
confusion about the issue and I propose changing the subject to reflect this
unle
Change by Karthikeyan Singaravelan :
--
title: "pip install --user numpy" fails on Python from the Windos Store -> "pip
install --user numpy" fails on Python from the Windows Store
___
Python tracker
<https://
Karthikeyan Singaravelan added the comment:
Thanks @chris.jerdonek. I have reverted the title to original report. Since
CPython now accepts PR if any one of the original authors can convert their
patch to a PR with tests then it will be great.
--
title: difflib.ndiff produces
Change by Karthikeyan Singaravelan :
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue35702>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Karthikeyan Singaravelan :
https://bugs.python.org/issue33125#msg314311 seems to be a related ticket that
tracks this.
--
nosy: +steve.dower, xtreak, zach.ware
___
Python tracker
<https://bugs.python.org/issue35
Change by Karthikeyan Singaravelan :
--
nosy: +benjamin.peterson
___
Python tracker
<https://bugs.python.org/issue35708>
___
___
Python-bugs-list mailin
Karthikeyan Singaravelan added the comment:
Seems related https://bugs.python.org/issue35045
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue35
Karthikeyan Singaravelan added the comment:
Seems related issue22978
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue35712>
___
___
Python-bug
Karthikeyan Singaravelan added the comment:
Please attach the full build log too along with the command executed.
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue35
1701 - 1800 of 3092 matches
Mail list logo