[issue19217] Calling assertEquals for moderately long list takes too long

2021-07-28 Thread Jack DeVries
Jack DeVries added the comment: I'm going to go ahead and submit my PR under the assumption that Lukasz will probably prefer to actually be able to review it when he takes a look at this, and additionally we haven't heard from @eamanu. @eamanu, I'll close it if you would l

[issue19217] Calling assertEquals for moderately long list takes too long

2021-07-28 Thread Jack DeVries
Change by Jack DeVries : -- pull_requests: +25963 pull_request: https://github.com/python/cpython/pull/27434 ___ Python tracker <https://bugs.python.org/issue19

[issue43548] RecursionError depth exceptions break pdb's interactive tracing.

2021-07-28 Thread Jack DeVries
Jack DeVries added the comment: @behindthebrain, I noticed that this script behaves weirdly when I try to set breakpoints at various places. However, the problem goes away when I raise the recursion limit. Things in python will not work right if you set the recursion limit to a low value

[issue44393] segfault with sys.setrecursionlimit

2021-07-28 Thread Jack DeVries
Jack DeVries added the comment: What about low recursion limits? This program causes a segfault for me:: import sys sys.setrecursionlimit(4) print('goodbye, world') -- nosy: +jack__d ___ Python tracker <https://bu

[issue44658] No ValueError for duplicate key value in mapping patern when lengths do not match

2021-07-28 Thread Jack DeVries
Jack DeVries added the comment: @brandtbucher yeah, you can close it, this was a silly idea. -- ___ Python tracker <https://bugs.python.org/issue44658> ___ ___

[issue44788] Possibility to specify port in __init__ of ftplib.FTP

2021-07-30 Thread Jack DeVries
Jack DeVries added the comment: The only thing to consider is that connections are flakey, and the user might typically want to explicitly handle them in most cases. Therefore, it's a better API if the .connect() call appears in the user's code. If anything, it might be better t

[issue44788] Possibility to specify port in __init__ of ftplib.FTP

2021-07-30 Thread Jack DeVries
Jack DeVries added the comment: > user might typically want to explicitly handle them in most cases. *Explicitly handle exceptions -- ___ Python tracker <https://bugs.python.org/issu

[issue44790] Recursion causes Crash

2021-07-30 Thread Jack DeVries
Jack DeVries added the comment: The default recursion limit is 1,000; you're increasing it by a factor of 10. It is documented that raising the recursion limit can cause crashes. What kind of crash are you seeing? Segmentation fault or stack overflow? Also, provide more details about

[issue44790] Recursion causes Crash

2021-07-30 Thread Jack DeVries
Jack DeVries added the comment: Also, see related: bpo-44393 -- ___ Python tracker <https://bugs.python.org/issue44790> ___ ___ Python-bugs-list mailin

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

2021-08-03 Thread Jack DeVries
Jack DeVries added the comment: @petr.viktorin a whatsnew entry was added, what more notice could have been provided? I have an idea for an alternative that might be better. What if ``make clean`` deletes and restores the venv only if it already existed in the first place

[issue44756] In ./Doc, "make html" and "make build" should depend on "make venv"

2021-08-03 Thread Jack DeVries
Jack DeVries added the comment: Actually, I tested out that idea (https://github.com/python/cpython/compare/main...jdevries3133:bpo-44756-doc-make), and I don't think its as nice of a solution. I think it is valuable for new contributors to be able to type "make html" and hav

[issue44819] assertSequenceEqual does not use _getAssertEqualityFunc

2021-08-03 Thread Jack DeVries
Jack DeVries added the comment: Brian, can you be more specific about what problem is caused by the fact that assertSequenceEqual does not use _getAssertEqualityFunc? Also, I'm not sure what your example is trying to demonstrate. Can you provide a minimal example that shows the problem

[issue41946] Add concrete examples to os.path documentation

2021-08-05 Thread Jack DeVries
Jack DeVries added the comment: > Some examples were added since this issue was created See bpo-35183 -- nosy: +jack__d ___ Python tracker <https://bugs.python.org/issu

[issue44830] Broken Mozilla devguide link in "Dealing with Bugs" doc section

2021-08-05 Thread Jack DeVries
Jack DeVries added the comment: For reference, it looks like Wayback Machine has a snapshot of the old article for reference: https://web.archive.org/web/20210613191914/https://developer.mozilla.org/en-US/docs/Mozilla/QA/Bug_writing_guidelines @mark.dickinson, do you feel like that new

[issue44697] Memory leak when asyncio.open_connection raise

2021-08-05 Thread Jack DeVries
Change by Jack DeVries : -- keywords: +patch nosy: +jack__d nosy_count: 6.0 -> 7.0 pull_requests: +26111 stage: -> patch review pull_request: https://github.com/python/cpython/pull/27617 ___ Python tracker <https://bugs.python.org/i

[issue44697] Memory leak when asyncio.open_connection raise

2021-08-05 Thread Jack DeVries
Change by Jack DeVries : -- pull_requests: -26111 ___ Python tracker <https://bugs.python.org/issue44697> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue44679] unittest.mock.sentinel documentation typo

2021-08-05 Thread Jack DeVries
Change by Jack DeVries : -- keywords: +patch nosy: +jack__d nosy_count: 2.0 -> 3.0 pull_requests: +26112 stage: -> patch review pull_request: https://github.com/python/cpython/pull/27618 ___ Python tracker <https://bugs.python.org/i

[issue44679] unittest.mock.sentinel documentation typo

2021-08-05 Thread Jack DeVries
Jack DeVries added the comment: @gaydayav I agree. -- ___ Python tracker <https://bugs.python.org/issue44679> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33140] shutil.chown should not be defined in Windows

2021-08-05 Thread Jack DeVries
Jack DeVries added the comment: I'm pretty sure the 3.11 dev cycle started since this conversation, right? Can we introduce the deprecation warning now? Maybe something like what is in the attached diff? @andrei.avk, if it turns out that the time has come, you can go ahead and take t

[issue33140] shutil.chown should not be defined in Windows

2021-08-05 Thread Jack DeVries
Jack DeVries added the comment: Yes, I definitely get that, but that's what the deprecation cycle is for. Certainly hold off on a PR until we see what @steve.dower thinks. I personally feel that having a function that can be introspected with ``dir`` but which should not be us

[issue44830] Broken Mozilla devguide link in "Dealing with Bugs" doc section

2021-08-07 Thread Jack DeVries
Jack DeVries added the comment: I created a discourse thread for people to propose alternatives:: https://discuss.python.org/t/alternate-article-for-how-to-wite-good-bug-report/10040 It's be a good idea to merge @orsenthil's PR which just removes the broken link right away. Th

[issue44830] Broken Mozilla devguide link in "Dealing with Bugs" doc section

2021-08-08 Thread Jack DeVries
Jack DeVries added the comment: @mark.dickinson, Steven D'Aprano suggested just linking to the wayback machine on discuss.python.org. What do you think of that? https://discuss.python.org/t/alternate-article-for-how-to-wite-good-bug-report/10040/2?u=jdevrie

[issue44830] Broken Mozilla devguide link in "Dealing with Bugs" doc section

2021-08-08 Thread Jack DeVries
Jack DeVries added the comment: I'm pretty much a novice, Senthil, so I don't know how much a review from me is worth but removing the broken link seems best! -- ___ Python tracker <https://bugs.python.o

[issue39452] Improve the __main__ module documentation

2021-08-10 Thread Jack DeVries
Jack DeVries added the comment: Hi All, I'm pinging everyone here on the bpo because my GitHub PR has been through a lot of revision and review. Maybe it's close to being ready to merge (I hope)! Feel free to take a look if you are interested: https://github.com/python/cpython/

[issue44877] Python > 3.7 build fails with IBM XL compiler

2021-08-10 Thread Jack DeVries
Jack DeVries added the comment: There is a related failure message in the file name ".9" in the tarball (line 175): ./python -E -S -m sysconfig --generate-posix-vars ;\ if test $? -ne 0 ; then \ echo "generate-posix-vars failed" ; \ rm -f ./pybuilddir.tx

[issue44877] Python > 3.7 build fails with IBM XL compiler

2021-08-10 Thread Jack DeVries
Jack DeVries added the comment: I'm sure you are aware of this, but also note that the issue could be in pandas or ibm-db, which include C extensions. I'm pretty sure those are the only two dependencies you listed there that have C de

[issue44877] Python > 3.7 build fails with IBM XL compiler

2021-08-10 Thread Jack DeVries
Jack DeVries added the comment: Woah, oops, nevermind! I was confusing this with a different bpo in my head. Sorry for the noise! -- ___ Python tracker <https://bugs.python.org/issue44

[issue44902] [Doc] Changing 'Mac OS X'/'OS X' to 'macOS'

2021-08-12 Thread Jack DeVries
Jack DeVries added the comment: oops, the link was mutilated... maybe this will help:: ``<https://github.com/python/cpython/compare/main...jdevries3133:bpo-44902-macOS>`` -- ___ Python tracker <https://bugs.python.org/i

[issue44902] [Doc] Changing 'Mac OS X'/'OS X' to 'macOS'

2021-08-12 Thread Jack DeVries
Jack DeVries added the comment: I've done it. See the changes here: https://github.com/python/cpython/compare/main...jdevries3133:bpo-44902-macOS I'll hold off on a PR pending some feedback on whether this change is desirable. Also, I did not make changes to whatsnew document

[issue44902] [Doc] Changing 'Mac OS X'/'OS X' to 'macOS'

2021-08-12 Thread Jack DeVries
Jack DeVries added the comment: Ok, that was no help... I'll just upload the diff. -- keywords: +patch Added file: https://bugs.python.org/file50211/os_x_to_macos_fix.diff ___ Python tracker <https://bugs.python.org/is

[issue44902] [Doc] Changing 'Mac OS X'/'OS X' to 'macOS'

2021-08-12 Thread Jack DeVries
Jack DeVries added the comment: Oh yeah, sorry, it looks like this can be closed as duplicate. -- ___ Python tracker <https://bugs.python.org/issue44

[issue42649] RecursionError when parsing unwieldy expression (regression from 2.7 -> 3.x)

2021-08-13 Thread Jack DeVries
Jack DeVries added the comment: I spent some time experimenting with making the expression bigger and the recursion limit lower in python2. It seems like in python2, the depth that the compiler will recurse is unrelated to sys.recursionlimit. Then, I lowered resource limits on stack and

[issue42649] RecursionError when parsing unwieldy expression (regression from 2.7 -> 3.x)

2021-08-13 Thread Jack DeVries
Jack DeVries added the comment: edit; typo: **This document is the **closest** I can find -- ___ Python tracker <https://bugs.python.org/issue42649> ___ ___

[issue39039] zlib.error with tarfile.open

2021-08-13 Thread Jack DeVries
Change by Jack DeVries : -- keywords: +patch nosy: +jack__d nosy_count: 3.0 -> 4.0 pull_requests: +26242 stage: -> patch review pull_request: https://github.com/python/cpython/pull/27766 ___ Python tracker <https://bugs.python.org/i

[issue44921] dict subclassing is slow

2021-08-15 Thread Jack DeVries
Jack DeVries added the comment: There was a thorough discussion about the concerns associated with supporting dict subclasses in general here: bpo-32615 If I understand correctly, allowing dict subclasses to inherit __contains__ and __getitem__ will be a step towards supporting dict

[issue44830] Broken Mozilla devguide link in "Dealing with Bugs" doc section

2021-08-16 Thread Jack DeVries
Jack DeVries added the comment: I agree that linking to the wayback machine is clunky. I just sent a message out to the python-ideas mailing list to solicit more suggestions. The discourse thread didn't get much response. I guess that at some point, if there is no consensus, it wouldn&#

[issue44830] Broken Mozilla devguide link in "Dealing with Bugs" doc section

2021-08-16 Thread Jack DeVries
Jack DeVries added the comment: > If Jack wants to pick this up, I'd merge it. I might be interested but I'm not sure if I will have the time. I'm not "calling dibs" if anyone else wants to go ahead with this solution. -- __

[issue44830] Broken Mozilla devguide link in "Dealing with Bugs" doc section

2021-08-16 Thread Jack DeVries
Jack DeVries added the comment: I am pretty sure that Mozilla moved to a new content management system and they've been refreshing a lot of content on their site. I would assume that any lingering presence of this article is just growing pains and it'll all be removed in due time.

[issue39039] zlib.error with tarfile.open

2021-08-17 Thread Jack DeVries
Jack DeVries added the comment: @jvoisin I am able to reproduce the problem when I download your script, but I am having a hard time reproducing it by passing corrupt archives to `tarfile.open`. How exactly was this file corrupted? I am trying to figure out if there are any similar

[issue44830] Broken Mozilla devguide link in "Dealing with Bugs" doc section

2021-08-18 Thread Jack DeVries
Jack DeVries added the comment: All right, consider the needle in the haystack officially found. This page has the same content as the missing page: https://bugzilla.mozilla.org/page.cgi?id=bug-writing.html Thank you @buhtz for opening an issue with Mozilla; they are eventually going to

[issue44830] Broken Mozilla devguide link in "Dealing with Bugs" doc section

2021-08-18 Thread Jack DeVries
Change by Jack DeVries : -- pull_requests: +26283 pull_request: https://github.com/python/cpython/pull/27818 ___ Python tracker <https://bugs.python.org/issue44

[issue44830] Broken Mozilla devguide link in "Dealing with Bugs" doc section

2021-08-18 Thread Jack DeVries
Jack DeVries added the comment: @terry.reedy ok, a PR to restore the docs with the new link is open. -- ___ Python tracker <https://bugs.python.org/issue44

[issue17359] Mention "__main__.py" explicitly in command line docs

2021-08-22 Thread Jack DeVries
Change by Jack DeVries : -- keywords: +patch nosy: +jack__d nosy_count: 8.0 -> 9.0 pull_requests: +26356 stage: -> patch review pull_request: https://github.com/python/cpython/pull/26883 ___ Python tracker <https://bugs.python.org/i

[issue24632] Improve documentation about __main__.py

2021-08-22 Thread Jack DeVries
Change by Jack DeVries : -- keywords: +patch nosy: +jack__d nosy_count: 11.0 -> 12.0 pull_requests: +26357 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/26883 ___ Python tracker <https://bugs.p

[issue39452] Improve the __main__ module documentation

2021-08-31 Thread Jack DeVries
Jack DeVries added the comment: > Your docs seem to promote the second, whereas I've usually preferred the > former. Was this a considered choice on your part? First and foremost, stupid GitHub is not letting the permalink load for some reason, but yes; this was discussed in the c

[issue19217] Calling assertEquals for moderately long list takes too long

2021-11-06 Thread Jack DeVries
Jack DeVries added the comment: Hey all, I'm putting a ping on this issue. I think my fix is ready to merge, see GH-27434. Thanks for all the feedback on the PR so far! -- ___ Python tracker <https://bugs.python.org/is

[issue45799] Fix confusing wording in Doc/library/__main__.rst

2021-11-13 Thread Jack DeVries
New submission from Jack DeVries : I was reading this bit last night and thought it was a typo. In the light of day, I realized it wasn't *technically* a typo, but definitely confusing wording. This PR fixes the confusing sentence. -- assignee: docs@python components: Document

[issue45799] Fix confusing wording in Doc/library/__main__.rst

2021-11-13 Thread Jack DeVries
Change by Jack DeVries : -- keywords: +patch pull_requests: +27795 stage: -> patch review pull_request: https://github.com/python/cpython/pull/29546 ___ Python tracker <https://bugs.python.org/issu

<    1   2