Guido van Rossum added the comment:
> I've reviewed your patch and merged it was some pending changes of my
> own. The socket tests are passing on Windows. Great work :)
You didn't upload this though.
__
Tracker <[EMAIL PROTECTED]>
&
Guido van Rossum added the comment:
Looks good (after skimming). Some stylistic nits:
- Please fold lines >= 80 chars.
- Please strip trailing whitespace (for Python code, you won't be
allowed to submit with it present).
- You can fold long imports without using the dreaded backslash
Guido van Rossum added the comment:
- I'm hoping that Bill can submit his SSL changes first.
- If we make _dup() a module-level function, we can implement fromfd()
in Python. I'll do this now.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.p
Guido van Rossum added the comment:
> In release25-maint, PyErr_Print() should be replaced with
> PyErr_Clear() also.
Committed revision 58991.
_
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.o
Guido van Rossum added the comment:
If you haven't checked this in by tomorrow morning, I'll submit issue
1378 (socket3.diff) first, and you'll have to do a bunch of cleanup.
Or, if you like, I can submit that now and you can do the cleanup this
afternoon. (Basically, we can d
Guido van Rossum added the comment:
Patch anyone?
--
nosy: +gvanrossum
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1445>
__
___
Python-bugs-list
Guido van Rossum added the comment:
Thanks! To be continued in issue 1378...
--
resolution: -> accepted
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Guido van Rossum added the comment:
Hold on, socket3.diff breaks four unit tests:
test_ftplib test_poplib test_smtplib test_urllib2net
> newfd = _socket.dup(socket_instance)
But that doesn't allow fromfd to work. I found some real use cases for
fromfd where the fd is passed in thro
Guido van Rossum added the comment:
Crys, since you apparently have working sound on Windows, could you have
a look at this? There's also an (unrelated) issue with sunau.py on
Py3k, it doesn't work (but the unittests aren't strong enough to
discover that :-).
--
assi
Guido van Rossum added the comment:
Thanks! roudkerk's patch is submitted as revision 59004.
BTW I need to go back to the drawing board for the rest of the socket
patch here. Using dup() in makefile() doesn't work for the
ssl.SSLSocket class. Maybe the explicit reference counting i
Guido van Rossum added the comment:
I don't think tokenizer.py needs to be changed -- it never interpreted
backslashes in string literals anyway (not even in regular, non-raw
literals).
The tokenizer.c cleanup is submitted as revision 59007.
I still am not warming up towards the no-raw-es
Guido van Rossum added the comment:
I've submitted socket2.diff plus small changes to ssl.py.
This seems the best I can do given that I don't think I can make dup()
work on ssl sockets.
--
resolution: -> accepted
status: open -> closed
__
Guido van Rossum added the comment:
This depends on the version of Make used. See the man page for Make.
--
nosy: +gvanrossum
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Guido van Rossum added the comment:
I think you misunderstand. Passing a variable to configure makes that
setting have effect *during the configure run*.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Guido van Rossum added the comment:
> Any "standard" way to add custom compilation flags?.
Beats me. I'm no autoconf expert.
--
resolution: -> wont fix
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<
Guido van Rossum added the comment:
I think this was fixed in svn this week! See issue 1265. Let me know
if your issue is different.
--
nosy: +gvanrossum
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Guido van Rossum added the comment:
Thanks anyway!
--
resolution: -> duplicate
status: open -> closed
superseder: -> pdb bug with "with" statement
__
Tracker <[EMAIL PROTECTED]>
<http
Guido van Rossum added the comment:
I can look into this, as I have OSX on my laptop.
_
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1739468>
_
___
Pyth
Guido van Rossum added the comment:
Right.
--
nosy: +gvanrossum
resolution: -> wont fix
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Guido van Rossum added the comment:
Actually the failures aren't OSX-specific:
==
FAIL: test_directory (__main__.CmdLineTest)
--
Traceback (most recent
Guido van Rossum added the comment:
Oops, those are failures under 3.0, probably due to Crys's merge. On
Linux, the 2.6 version of the test doesn't fail. I see 2 failing tests
on OSX with the 2.6 version, which I will look into.
_
Tracker <[EM
Guido van Rossum added the comment:
Fixed the OSX failure in revision 59055; it was due to /tmp being a
symlink, and fixed by application of realpath().
Keeping this open until the 3.0 version is working.
_
Tracker <[EMAIL PROTECTED]>
<http://bugs.p
Guido van Rossum added the comment:
No. If you're testing something that's not implemented, it is correct to
see that as a failure. Talk to anyone doing TDD.
--
nosy: +gvanrossum
resolution: -> wont fix
status: open -> closed
__
Guido van Rossum added the comment:
3.0 fix committed as revision 59058.
--
resolution: -> accepted
status: open -> closed
versions: +Python 3.0
_
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.o
Guido van Rossum added the comment:
Sorry, just comment out those tests until you're ready to write the code.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python
Guido van Rossum added the comment:
Sorry Erik, but I don't think you should try to compensate for your
flawed methodology by trying to change the unittest framework. End of
discussion.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python
Changes by Guido van Rossum:
--
nosy: -gvanrossum
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1328>
__
___
Python-bugs-list mailing list
Unsubs
Guido van Rossum added the comment:
IDLE stuff is never mine.
--
assignee: gvanrossum -> kbk
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1374>
__
Guido van Rossum added the comment:
I have no way to test this.
--
assignee: gvanrossum ->
priority: high -> normal
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Guido van Rossum added the comment:
Note that the OP was complaining about Stackless. This is not the place
to report issues with that.
--
priority: normal -> low
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.o
Guido van Rossum added the comment:
I have no idea. I'm no asynchat expert. Let Thomas look into this once
he's back from vacation.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.p
Guido van Rossum added the comment:
Is this still relevant?
--
assignee: -> janssen
priority: urgent -> normal
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Guido van Rossum added the comment:
This would be easier to fix if we didn't have unbound methods. I'm
going to ask the py3k list if anybody really cares about having those.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.p
Guido van Rossum added the comment:
I've submitted this as revision 59106. Thanks so much for your effort!
I cleaned up the layout of some of the files, and I had to undo a
diffing mistake -- somehow your patch undid some changes to
collections.py and test_collections.py about ren
Changes by Guido van Rossum:
--
assignee: -> janssen
nosy: +janssen
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1489>
__
___
Python-bugs-li
Guido van Rossum added the comment:
I'm waiting for those failing tests to magically start passing. :-)
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1493>
__
_
Guido van Rossum added the comment:
IMO it should be set to 10.4 since we want binaries that run on that
platform too. Is this something we can fix in the configure script?
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Guido van Rossum added the comment:
I don't see an issue to be fixed here; adding special tests in order to
provide more detailed error messages is rarely a good idea.
Also, PEP 8 has said for years now that modules should *not* be named
the same as classes. Yes, there are a few such mo
Guido van Rossum added the comment:
Looks good from a functionality POV.
I wonder if we couldn't change the dict though to always map ordinals to
strings? Deletions can be mapped to "". We could warn about non-string
values in the 2.6 version of this code, and make it a (laz
Guido van Rossum added the comment:
On Nov 24, 2007 11:37 AM, Christian Heimes <[EMAIL PROTECTED]> wrote:
> Do you still believe in the tooth fairy, too? :p
Yes, and in the Easter Bunny, Santa Claus, and Sinterklaas. But in
this particular case I believe in Kaboutertjes. (Dutch gnomes
New submission from Guido van Rossum:
In http://bugs.python.org/issue1774369 I mentioned that I wanted to
rename __builtins__ to __rootns__. Though right now I think something
longer and less cryptic might be better. The reason is to avoid for
once and for all the confusion between __builtin__
Guido van Rossum added the comment:
OK, then we need to agree on a new name. I find __root__ too short,
__rootns__ too cryptic, and __root_namespace__ too long. :-) What else
have we got?
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Guido van Rossum added the comment:
OK. Some code review comments:
- Please clean up the comment in classobject.c starting with "Method
objects are used for one purposes:" -- to begin with, "one purposes" is
ungrammatical. Best to remove the (a) bullet and rephrase the w
Guido van Rossum added the comment:
Time for a quick poll on the list.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1498>
__
___
Python-bugs-list mailing list
Guido van Rossum added the comment:
BTW I'm okay with submitting this as is (plus docs and tests) and
tighten the spec later.
--
assignee: gvanrossum -> georg.brandl
keywords: +patch, py3k
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pyt
Guido van Rossum added the comment:
Bill, is there a code example that should work but breaks because of
that close()? ATM, there doesn't seem to be anything in the tests that
breaks...
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python
Guido van Rossum added the comment:
2 *is* a prime number.
--
nosy: +gvanrossum
resolution: -> invalid
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Guido van Rossum added the comment:
So is this a Mac-only issue?
And couldn't the GIL state cleanup also invoke user code, which might be
abused to create more threads, wreaking havoc that way? I'm kind of
worried about putting this into 2.5.2 and breaking somebody's worki
Guido van Rossum added the comment:
(Can you also submit a doc fix that would have prevented issue 1500? :-)
--
nosy: +gvanrossum
priority: -> low
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.o
Guido van Rossum added the comment:
I'm okay with adding this to 2.6 (and hence 3.0) but not with doing this
to 2.5.
--
nosy: +gvanrossum
priority: -> low
resolution: -> accepted
versions: -Python 2.4, Python 2.5, Python 3.0
__
Trac
Guido van Rossum added the comment:
I'm not sure I understand why anyone would ever want to send a 100
response anyway.
If I were to add support for this, I'd probably refactor send_response()
so that there's a lower-level function send_response_only() that *only*
sends the resp
Guido van Rossum added the comment:
Obviously Ping isn't listening, so waiting for him is not productive.
Looking at the issue more, I can't really see a bug in inspect -- it's
the class definitions that are broken. So closing as "rejected".
> Due to this bu
New submission from Guido van Rossum:
See e.g.:
http://www.python.org/dev/buildbot/3.0/ppc%20Debian%20unstable%203.0/builds/303/step-test/0
Note how it fails the first time and passes on the re-run. I've seen
this before (just not on any of my own systems). I've also seen it fail
Guido van Rossum added the comment:
Crys, why don't you give it a try yourself? It's quite easy to write
such a simple substitution.
--
nosy: +gvanrossum
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.p
Guido van Rossum added the comment:
> No, _PyGILState_Fini does not invoke any python code
You're right. It calls PyThread_delete_key(). I thought this would
delete entries from a dictionary (thereby potentially invoking Python
code via Py_DECREF()), but it doesn't -- it just free
Guido van Rossum added the comment:
It works, though the "__self__.__class__" substitution is technically
wrong -- it creates a single NAME node whose contents is that string,
while in the parse tree it should really be three tokens. But as it
works, I wouldn't worry about it.
I
Guido van Rossum added the comment:
A fixer for new.instancemethod would be nice, though I doubt that there
will be many uses. We could also go a different way: since new.py has a
comment stating it is deprecated (in 2.5 already), perhaps we should
just kill in in 3.0 and add an explicit 3.0
Guido van Rossum added the comment:
There's C code like this:
if (Py_Py3kWarningFlag &&
PyErr_Warn(PyExc_DeprecationWarning,
"apply() not supported in 3.x") < 0)
return NULL;
I don't know how to check
Changes by Guido van Rossum:
--
assignee: -> theller
nosy: +theller
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1506>
__
___
Python-bugs-li
Guido van Rossum added the comment:
> Looking at the subprocess.py code it occurred to me that it never
> checks if the value of self.pid returned by os.fork is -1
What makes you think os.fork(0 can return -1? It's not C you know...
_
Trac
Guido van Rossum added the comment:
Committed revision 59203.
Anthony, is this OK to backport to 2.5.2?
--
assignee: -> anthonybaxter
nosy: +anthonybaxter, gvanrossum
resolution: -> accepted
__
Tracker <[EMAIL PROTECTED]>
<http://
Guido van Rossum added the comment:
Yes, like all system calls in the os module.
_
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1731717>
_
___
Python-bugs-
Guido van Rossum added the comment:
This is not a bug. There's not much point is supporting cmp(None, None)
when cmp(None, ) would still fail. cmp() should only be
used when you know that the arguments belong to an orderable type.
--
resolution: -> rejected
status: open -
Guido van Rossum added the comment:
All three of those are errors in 3.0.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1513>
__
___
Python-bugs-list
Guido van Rossum added the comment:
Hm... What if we just put these names in sys?
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1522>
__
___
Python-bugs-list
Guido van Rossum added the comment:
I can reproduce the segfault in 2.2 through 2.4; in 2.5 and 2.6 the
output is this instead:
Test 1, using __eq__(a, b).__nonzero__()
this is never the right answer
*
Test 2, using tuple's tp_richcompare
New Watch 0xf7f8cbac
New Watch 0xf7f8cc0c
Del
Guido van Rossum added the comment:
Oops, the same code appeared twice. The new fix fixes both places.
Added file: http://bugs.python.org/file8827/fix1517.diff
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Changes by Guido van Rossum:
Removed file: http://bugs.python.org/file8826/fix1517.diff
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1517>
__
___
Python-bugs-
Guido van Rossum added the comment:
Committed revision 59222 (2.5.2).
Committed revision 59223 (2.6).
Thanks rhamporyncus and jorendorff!!
--
keywords: +patch
resolution: -> fixed
status: open -> closed
__
Tracker <[EMAIL PROTECTE
Guido van Rossum added the comment:
> I don't see it as an option. I'd rather keep the types in the 'types'
> module than to add them to the sys module.
Why such a strong opinion? 'sys' is pretty close to the VM too...
Guido van Rossum added the comment:
> sys is a very important and often used module, too. I don't like the
> idea to remove one module (types) and clutter an important module with
> its content.
Well, it is already pretty cluttered -- it contains many items that
*I* d
Changes by Guido van Rossum:
--
keywords: +patch
nosy: +gvanrossum
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1518>
__
___
Python-bugs-list
Guido van Rossum added the comment:
> I like to apply the py3k_add_types_to_h.patch before the next alpha and
> discuss the fate of pyvm after the alpha.
Sure, go ahead and submit the uncontroversial part.
__
Tracker <[EMAIL PROTECTED]>
<http://
Guido van Rossum added the comment:
ping?
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1414>
__
___
Python-bugs-list mailing list
Unsubscribe:
http://mai
Changes by Guido van Rossum:
--
priority: -> low
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1527>
__
___
Python-bugs-list mailing list
Uns
Changes by Guido van Rossum:
--
priority: -> normal
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1528>
__
___
Python-bugs-list mailing list
Uns
New submission from Guido van Rossum:
Modern Unix systems have a fchmod() system call, which is like chmod()
but takes a file descriptor instead of a filename. Python's os module
(via the posix module) should support this if it exists on the target
platform.
--
messages: 57997
Guido van Rossum added the comment:
I'm not Barry or Benjamin, but having followed the thread on p...@python.org,
this certainly looks like a security issue to me. As a second pair of eyes, I
recommend MvL, who builds our Windows installers.
--
nosy: +gvanrossum, l
Guido van Rossum added the comment:
I like how we're actually converging on an implementable and
maximally-useful algorithm.
--
___
Python tracker
<http://bugs.python.org/is
Guido van Rossum added the comment:
I think there's nothing to be done for a bug this general.
If you find a specific object whose repr() is awkward, go ahead and file a
specific bug.
In most cases I think people who parse repr() output know they are on thin ice,
and would prefer tha
Guido van Rossum added the comment:
What's holding this up?
--
___
Python tracker
<http://bugs.python.org/issue13224>
___
___
Python-bugs-list mailing list
Guido van Rossum added the comment:
On Wed, Nov 2, 2011 at 9:31 AM, Éric Araujo wrote:
>
> Éric Araujo added the comment:
>
> I’ve updated my patch to handle modules and functions too, but there is a
> decision to make. The functions of built-in modules are implemented by
&
Guido van Rossum added the comment:
As I wrote in python-dev:
I agree with Raymond that this should be treated as a feature request and not
"fixed" in 2.7 / 3.2. (However the mention of 'find' in the error message for
'index' is a bug and should be fixed.)
Guido van Rossum added the comment:
This will not be fixed. For one thing, the letter 'i' or upper case 'I' look
too much like digits. The way numbers are parsed either by the language parser
(in source code) or by the built-in functions (int, float, complex) should no
Guido van Rossum added the comment:
@Retro, stop reopening bugs. This is very much a matter of personal taste and
the existing way is fine.
--
resolution: remind -> rejected
status: open -> closed
___
Python tracker
<http://bugs.p
Guido van Rossum added the comment:
Are you sure? The way I read the PEP, it just said that str(cls) and
str(func) should *use* qualname. That could mean returning '' or ''.
On Tue, Nov 22, 2011 at 7:27 AM, Éric Araujo wrote:
>
> Éric Araujo added the comment:
&g
Guido van Rossum added the comment:
Hm, this change allows many other *undesirable* objects pass the test as well.
I'd prefer to stick to the rule, "when in doubt, raise an error".
Maybe using == instead of 'is' as the test would be acceptable?
---
Guido van Rossum added the comment:
What you're seeing here is just one of may things that go subtly wrong when you
reload a class. I don't think we should fix this one aspect while leaving so
many other bugs due to the same root cause.
It would be better to focus your energy o
Guido van Rossum added the comment:
I *thought* I mimicked what C stdio did ~20 years ago... I'd be happy to
follow what it does today if it changed or if I made a mistake.
That said, IMO:
Line-buffering should be good enough since in practice errors messages are
always terminated
Guido van Rossum added the comment:
(This is in reference to issue 11662.)
I can't think of a way that this proposed change would bring back the original
vulnerability, so go ahead.
--
___
Python tracker
<http://bugs.python.org/is
Changes by Guido van Rossum :
--
nosy: +gvanrossum
___
Python tracker
<http://bugs.python.org/issue13703>
___
___
Python-bugs-list mailing list
Unsubscribe:
Guido van Rossum added the comment:
I'm with Antoine -- turn it on by default. Maybe there should be a release
candidate to test the waters.
--
___
Python tracker
<http://bugs.python.org/is
Guido van Rossum added the comment:
On my system (Snow Leopard OSX 10.6.8, Xcode 4.1) there are several different
versions of gcc available in /usr/bin/. Some are symlinks to others; in
particular gcc links to llvm-gccc-4.2. By using "./configure CC=gcc-4.2" I get
a working conf
Guido van Rossum added the comment:
In the python-ideas discussion people have argued that flush=False should or
could be interpreted as "definitely do not flush" which is unimplementable (the
buffer may be full, or the stream may be unbuffered, and there is no way to
tell a write
Guido van Rossum added the comment:
I'd ignore the failure. It could easily mask some other more interesting error.
--
___
Python tracker
<http://bugs.python.org/is
Guido van Rossum added the comment:
Ok, I'm fine with passing through the exception from flush().
--
___
Python tracker
<http://bugs.python.org/is
Guido van Rossum added the comment:
Anatoly, duly noted, and disagreed with.
--
___
Python tracker
<http://bugs.python.org/issue13761>
___
___
Python-bugs-list m
Guido van Rossum added the comment:
Uh, not until I've seen a lot more evidence that people are habitually writing
"TAU = 2 * math.pi" in their programs...
--
nosy: +gvanrossum
___
Python tracker
<http://bugs.pyt
Guido van Rossum added the comment:
Wow. A very educational discussion. We will be referencing this issue for
many years to come.
As long as the buck stops with me, I feel strongly that *today* changing
indexing from O(1) to O(log N) is a bad idea, partly for technical reasons,
partly
Guido van Rossum added the comment:
This bug could do with a little less attitude. That said, I think it is a bug
and should be fixed, at the very least for Python 3.3. As always, it is a
matter of much debate to what extent bugs can be fixed in previous Python
versions (specifically, 2.7
701 - 800 of 5563 matches
Mail list logo