Change by Eric Snow :
--
keywords: +patch
pull_requests: +11123
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Eric Snow :
--
keywords: +patch, patch
pull_requests: +11123, 11124
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Eric Snow :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Eric Snow :
--
pull_requests: +11360
___
Python tracker
<https://bugs.python.org/issue33608>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Eric Snow :
--
pull_requests: +11360, 11361
___
Python tracker
<https://bugs.python.org/issue33608>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Eric Snow :
--
pull_requests: +11360, 11361, 11362
___
Python tracker
<https://bugs.python.org/issue33608>
___
___
Python-bugs-list mailing list
Unsub
Eric Snow added the comment:
Hi Ma Lin! Thanks for the suggestion. We appreciate your interest in making
Python better.
It's unclear from your messages what is motivating your request. You mentioned
middle school students, but that didn't sound like your actual motivator.
Kn
New submission from Eric Snow :
tl;dr Should all objects in sys.modules look like module objects?
In #35791 Ronald described a problem with a "module" added to sys.modules that
does not have all the attributes a module should have. He also mentioned a
similar problem with ty
Eric Snow added the comment:
FYI, I opened #35806 for typing.io.
--
___
Python tracker
<https://bugs.python.org/issue35791>
___
___
Python-bugs-list mailin
Eric Snow added the comment:
Thanks for clarifying, Ma Lin. At this point there just isn't enough strong
justification for making any change here. So I'm closing the issue.
Also, making a PR for this likely wouldn't be the best use of your time.
However, if you
Eric Snow added the comment:
Thanks for doing this, Raymond!
FYI, I found a couple of places where it still refers to OrderedDict:
1. in the doc entry in collections.rst [1]
2. in the docstring [2]
[1]
https://github.com/python/cpython/commit/0bb4bdf0d93b301407774c4ffd6df54cff947df8#diff
Eric Snow added the comment:
Also, there's a potentially misleading detail that you might consider
correcting in the text. However, making it correct might make it slightly less
clear, so it's a bit of a judgement call on how important it is to be explicit
here. (FWIW, I think
Eric Snow added the comment:
If you prefer, I'd be glad to open separate issues for either thing.
--
___
Python tracker
<https://bugs.python.org/is
Eric Snow added the comment:
FWIW, both PEP 468 (kwargs order) and PEP 520 (class definition order) specify
order-preserving mapping rather than dict. The main difference is that they
are about language features rather than something out of the stdlib
Change by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<https://bugs.python.org/issue35134>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<https://bugs.python.org/issue35258>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Eric Snow :
In November Victor created the Include/cpython directory and moved a decent
amount of public (but not limited) API there. This included the
PyInterpreterState struct. I'd like to move it into the "internal" headers
since it is somewhat
Change by Eric Snow :
--
keywords: +patch
pull_requests: +11623
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Eric Snow :
--
keywords: +patch, patch
pull_requests: +11623, 11624
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Eric Snow :
--
keywords: +patch, patch, patch
pull_requests: +11623, 11624, 11625
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Eric Snow added the comment:
FWIW, I was hoping to the same for PyThreadState but it looks like 6 of its
fields are exposed in "stable" header files via the following macros:
# Include/object.h
Py_TRASHCAN_SAFE_BEGIN
Py_TRASHCAN_SAFE_END
Include.ceval.h
Py_EnterRec
Eric Snow added the comment:
FTR, I've had a number of extensive conversations with Davin (over the last
year and a half) about this feature. His choices seemed reasonable (caveat:
I'm not an expert on multiprocessing) and the feature seemed desirable. I did
not rev
Change by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<https://bugs.python.org/issue32417>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
tl;dr It's too late to change anything here. Also, is it actually a problem in
practice?
At this point enhancements can not go into 2.7 (you're welcome to appeal to the
release manager). The changes to `PyStructSequence` (from bpo-1820) appea
Eric Snow added the comment:
[1] https://devguide.python.org/#status-of-python-branches
--
___
Python tracker
<https://bugs.python.org/issue35914>
___
___
Pytho
Eric Snow added the comment:
FWIW, if folks *are* checking for tuple (and I'd love to know why) then I'd
recommend that they not. :) A more Pythonic (and arguably generally better)
approach would be to stick tightly to what data you need and take advantage of
duck-typing. Whe
Eric Snow added the comment:
Sounds good. I hope that helped.
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Eric Snow :
--
pull_requests: -11713
___
Python tracker
<https://bugs.python.org/issue28411>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Eric Snow :
--
pull_requests: -11714
___
Python tracker
<https://bugs.python.org/issue28411>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
FTR, gh-9047 (for issue #34572) mentions this issue.
--
___
Python tracker
<https://bugs.python.org/issue28411>
___
___
Python-bug
Change by Eric Snow :
--
assignee: -> eric.snow
type: -> behavior
___
Python tracker
<https://bugs.python.org/issue28411>
___
___
Python-bugs-list
Eric Snow added the comment:
Perhaps PyImport_GetModule() should aquire-release the module's lock before the
lookup? This would effectively be a call to _lock_unlock_module() in
importlib._bootstrap.
The alternative is to encourage using PyImport_Import() instead, like the PR
has
Change by Eric Snow :
--
pull_requests: -11625
___
Python tracker
<https://bugs.python.org/issue35886>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Eric Snow :
--
pull_requests: -11624
___
Python tracker
<https://bugs.python.org/issue35886>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
Thanks, Antoine.
--
___
Python tracker
<https://bugs.python.org/issue34572>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
Yeah, that makes sense.
--
___
Python tracker
<https://bugs.python.org/issue35943>
___
___
Python-bugs-list mailing list
Unsub
Eric Snow added the comment:
@Victor, do you see any problems with doing this? It will help simplify other
changes I'm working on.
--
___
Python tracker
<https://bugs.python.org/is
Change by Eric Snow :
--
nosy: +ncoghlan
___
Python tracker
<https://bugs.python.org/issue35886>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Eric Snow :
(also see issue #35886)
In November Victor created the Include/cpython directory and moved a decent
amount of public (but not limited) API there. This included the PyThreadState
struct. I'd like to move it into the "internal" headers since
Eric Snow added the comment:
Is "long long" (AKA int64_t) 32 bits or 64 bits on a 32-bit platform? It it's
always 32 bits then there is no problem here. Otherwise I agree we have a
problem to fix. My understanding is that it is the former
Eric Snow added the comment:
Having slept on it and given the extra info you've provided I'm more
comfortable with the proposed solution now. :)
So the result will be that on 32-bit architectures only 32-bit (signed) ints
will be allowed through channels. On 64-bit platforms (
Change by Eric Snow :
--
components: +Interpreter Core -Extension Modules
stage: patch review -> commit review
status: open -> pending
___
Python tracker
<https://bugs.python.org/i
Eric Snow added the comment:
FTR, issue #34569 covered similar ground.
--
status: pending -> open
___
Python tracker
<https://bugs.python.org/issu
Eric Snow added the comment:
+Nick (who may have some insight here)
--
nosy: +eric.snow, ncoghlan
___
Python tracker
<https://bugs.python.org/issue35
Eric Snow added the comment:
On Tue, Feb 12, 2019 at 3:57 AM STINNER Victor wrote:
> A long term solution would to enable -I behavior by default: don't add the
> current directory to sys.path when using -c CMD.
>From what I can recall, it was a conscious decision to
Eric Snow added the comment:
related: issue #13475
--
___
Python tracker
<https://bugs.python.org/issue35969>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
@Guido, I recall a while back you explained the value of adding CWD to
sys.path. Would you mind providing some insight here?
--
nosy: +gvanrossum
___
Python tracker
<https://bugs.python.org/issue35
Eric Snow added the comment:
related: issue #13475
--
___
Python tracker
<https://bugs.python.org/issue35971>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
Note that I've asked Guido to comment about CWD in sys.path on issue #35969.
--
___
Python tracker
<https://bugs.python.org/is
Eric Snow added the comment:
New changeset 16f842da3c862d76a1177bd8ef9579703c24fa5a by Eric Snow (Alexey
Izbyshev) in branch 'master':
bpo-35972: _xxsubinterpreters: Fix potential integer truncation on 32-bit in
channel_send() (gh-11822)
https://github.com/python/cpyt
Eric Snow added the comment:
Thanks, Alexey!
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Eric Snow added the comment:
FWIW, subclassing builtin types is a relatively new thing. There are still a
number of lingering (older) implementation details throughout CPython that were
written assuming no subclassing. I'd guess that this is one of them.
--
nosy: +eric.snow
Eric Snow added the comment:
ack
--
___
Python tracker
<https://bugs.python.org/issue35972>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.pyth
Eric Snow added the comment:
Alexey, even though the refleak does not appear to be related to your earlier
PR, you are welcome to keep working on this issue. :) If you do then please
add me as a reviewer on whatever PR you make. Also, I'd be glad to answer any
questions you have abou
Eric Snow added the comment:
FYI, the _xxsubinterpreters module serves several purposes. First, it allows
us to more thoroughly test the subinterpreter functionality of CPython (doing
so via _testembed and _testcapi is messy), effectively in
test__xxsubinterpreters. Second, it is the
Eric Snow added the comment:
On Wed, Feb 13, 2019 at 8:42 AM Antoine Pitrou wrote:
> Antoine Pitrou added the comment:
>
> By "relatively new thing", you mean less than 20 years old? :-)
Yeah, looks like it was in the 2.2 release (Dec 2001) for PEP 253.
Anyway, I know o
Eric Snow added the comment:
On Wed, Feb 13, 2019 at 10:56 AM Steve Dower wrote:
> Nick, Victor, Eric, (others?) - are you interested in having a virtual
> whiteboard session to brainstorm how the "perfect" initialization looks? And
> probably a follow-up to brainsto
Eric Snow added the comment:
On Wed, Feb 13, 2019 at 5:09 PM Steve Dower wrote:
> This is why I'm keen to design the ideal *user* API first (that is, write the
> examples of how you would use it) and then figure out how we can make it fit.
> It's kind of the opposite
Eric Snow added the comment:
Thanks, Serhiy. While the benchmark suite is our best tool available for
measuring performance, I'm not sure what slowdown is significant in those
results.
@Victor, any thoughts?
--
___
Python tracker
&
Eric Snow added the comment:
Thanks, Alexey. I've merged the PR.
As to finding and fixing leaks, I'd welcome any help you have to offer. :)
Feel free to open an separate issue. One issue covering all the ones you find
should be enough. If you find any non-trivial leaks or ot
Change by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<https://bugs.python.org/issue35810>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
Thanks, Victor!
python-dev:
https://mail.python.org/pipermail/python-dev/2019-February/156344.html
Also, my PR already has a What's New entry in the porting section. :)
--
___
Python tracker
<https://bugs.py
Eric Snow added the comment:
@Stefan, is it a problem for Cython if the relevant fields are exposed via
C-API functions rather than directly on PyThreadState?
--
___
Python tracker
<https://bugs.python.org/issue35
Eric Snow added the comment:
Thanks for clarifying. :)
On Mon, Feb 18, 2019 at 1:17 PM Stefan Behnel wrote:
> The exception fields are performance critical, and we try hard to make them
> visible to the C compiler so that swapping around exception state eats up as
> little CP
Changes by Eric Snow :
--
nosy: +eric.snow
___
Python tracker
<http://bugs.python.org/issue29723>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
pull_requests: +1732
___
Python tracker
<http://bugs.python.org/issue28411>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
pull_requests: +1734
___
Python tracker
<http://bugs.python.org/issue29102>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
Yes, I still need it. :)
--
___
Python tracker
<http://bugs.python.org/issue29102>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
pull_requests: +1818
___
Python tracker
<http://bugs.python.org/issue22257>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
pull_requests: +1819
___
Python tracker
<http://bugs.python.org/issue22257>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
New changeset e377416c10eb0bf055b0728cdcdc4488fdfd3b5f by Eric Snow in branch
'master':
bpo-29102: Add a unique ID to PyInterpreterState. (#1639)
https://github.com/python/cpython/commit/e377416c10eb0bf055b0728cdcdc44
Changes by Eric Snow :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Eric Snow added the comment:
New changeset 6b4be195cd8868b76eb6fbe166acc39beee8ce36 by Eric Snow in branch
'master':
bpo-22257: Small changes for PEP 432. (#1728)
https://github.com/python/cpython/commit/6b4be195cd8868b76eb6fbe166acc3
New submission from Eric Snow:
For a variety of reasons, I'd like to be able to manage subinterpreters from
Python code. An initial effort would add a _interpreters module to the stdlib
that exposes the basic functionality of the corresponding C-API.
--
assignee: eric.snow
compo
Changes by Eric Snow :
--
pull_requests: +1839
___
Python tracker
<http://bugs.python.org/issue30439>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
The change in Lib/test/coding20731.py was the result of running
PCbuild/fix_encoding.py.
--
status: open -> pending
___
Python tracker
<http://bugs.python.org/issu
Changes by Eric Snow :
--
pull_requests: +1846
status: pending -> open
___
Python tracker
<http://bugs.python.org/issue22257>
___
___
Python-bugs-list mai
Eric Snow added the comment:
New changeset e0918ecf93a458d4e005650f816d64654e73fc2a by Eric Snow in branch
'master':
bpo-22257: Fix CLI by using int instead of char (compares to EOF). (#1765)
https://github.com/python/cpython/commit/e0918ecf93a458d4e005650f816d64
Changes by Eric Snow :
--
pull_requests: +1852
___
Python tracker
<http://bugs.python.org/issue22257>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
reverting the change to that test: https://github.com/python/cpython/pull/1770
--
___
Python tracker
<http://bugs.python.org/issue22
Changes by Eric Snow :
--
pull_requests: +1853
___
Python tracker
<http://bugs.python.org/issue22257>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
Thanks for pointing this out, Serhiy. I'll take a look in the morning.
--
___
Python tracker
<http://bugs.python.org/is
Eric Snow added the comment:
Yeah, I some extra checks (involving pointers) to that test and some platforms
don't work as expected. I'll take a look in the morning.
--
___
Python tracker
<http://bugs.python.o
Eric Snow added the comment:
That looks similar to other failures due to an issue fixed in a later PR. It
shouldn't be an issue any longer. I'll double check in the morning.
--
___
Python tracker
<http://bugs.python.o
Eric Snow added the comment:
New changeset 1abcf6700b4da6207fe859de40c6c1bada6b4fec by Eric Snow in branch
'master':
bpo-22257: Private C-API for core runtime initialization (PEP 432). (#1772)
https://github.com/python/cpython/commit/1abcf6700b4da6207fe859de40c6c1
Eric Snow added the comment:
New changeset c7ec9985bbdbb2b073f2c37febd18268817da29a by Eric Snow in branch
'master':
bpo-22257: Private C-API for main interpreter initialization (PEP 432). (#1729)
https://github.com/python/cpython/commit/c7ec9985bbdbb2b073f2c37febd182
Eric Snow added the comment:
Apparently it is PRId64.
--
___
Python tracker
<http://bugs.python.org/issue29102>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
pull_requests: +1874
___
Python tracker
<http://bugs.python.org/issue30447>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
(see issue30447)
--
___
Python tracker
<http://bugs.python.org/issue29102>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
pull_requests: +1885
___
Python tracker
<http://bugs.python.org/issue30439>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Eric Snow :
--
pull_requests: +1886
___
Python tracker
<http://bugs.python.org/issue30439>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
New changeset d1c3c13fedaf62b71445ccd048e395aa4a7d510f by Eric Snow in branch
'master':
bpo-30447: Fix/skip the subinterpreters test on some platforms. (#1791)
https://github.com/python/cpython/commit/d1c3c13fedaf62b71445ccd048e395
Eric Snow added the comment:
I've fixed the compiler warning via d1c3c13fedaf62b71445ccd048e395aa4a7d510f.
--
status: open -> closed
___
Python tracker
<http://bugs.python.org
Changes by Eric Snow :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue30447>
___
Changes by Eric Snow :
--
pull_requests: +1903
___
Python tracker
<http://bugs.python.org/issue22257>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
proposed: https://mail.python.org/pipermail/python-ideas/2017-May/045765.html
--
___
Python tracker
<http://bugs.python.org/issue30
New submission from Eric Snow:
Per Object/dictobject.c, PyDict_GetItemWithError() returns a borrowed
reference. However, the documentation does not say so. That should be fixed.
--
messages: 294506
nosy: eric.snow
priority: normal
severity: normal
status: open
title: Docs for
Changes by Eric Snow :
--
assignee: -> eric.snow
components: +Documentation
stage: -> needs patch
versions: +Python 3.7
___
Python tracker
<http://bugs.python.org/i
Changes by Eric Snow :
--
pull_requests: +1904
___
Python tracker
<http://bugs.python.org/issue30475>
___
___
Python-bugs-list mailing list
Unsubscribe:
Eric Snow added the comment:
At this point I'm not convinced the failure is due to my recent changes.
Regardless, I do agree with you about detecting hard crashes.
--
___
Python tracker
<http://bugs.python.org/is
901 - 1000 of 2629 matches
Mail list logo