Changes by Brian Curtin :
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue14108>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brian Curtin added the comment:
> For some functions/methods being able to pass keyword args make the code more
> readable/flexible, but for some other there's no real gain.
I know what you're saying with the last part, but I think everyone becomes a
winner in the consis
Brian Curtin added the comment:
Hyphenation changes are not going to be made unless the current text is
actually incorrect, confusing, or leads to people misunderstanding what is
meant.
--
nosy: +brian.curtin
resolution: -> rejected
stage: patch review -> committed/rejected
Changes by Brian Curtin :
--
nosy: -brian.curtin
___
Python tracker
<http://bugs.python.org/issue14164>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Brian Curtin :
--
nosy: -brian.curtin
___
Python tracker
<http://bugs.python.org/issue7652>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brian Curtin added the comment:
The @support.skip_unless_symlink decorator could be helpful there.
--
___
Python tracker
<http://bugs.python.org/issue6
Brian Curtin added the comment:
file, and the Python 3 version contains the posix__getfinalpathname entry
point, but the Python 2 version does not.
>
> I presume that PyWin32 could also be used to work around this. Too bad
it isn't automatically included with Python:
> http://s
New submission from Brian Curtin :
After talks at PyCon with several people, python.exe will live in
C:\Python33\bin rather than C:\Python33 to come more in line with the Unix
layout.
This will also simplify another issue with the Path option for the 3.3
installer as well as packaging&#
Brian Curtin added the comment:
If that thread ever comes to a conclusion, can someone summarize it here?
Also, is there a reason distutils even matters here?
--
___
Python tracker
<http://bugs.python.org/issue14
Brian Curtin added the comment:
It'll break tools who just look for "C:\\Python%d%d\python.exe" % (x, y) or
some variation, but that's not a very dependable solution. If you're using the
registry to find actual install locations, I think you'll be alright.
Wh
Brian Curtin added the comment:
A suggested solution to that was to add BinaryPath to give them the proper path.
We could potentially expose BinaryPath in older installers, just pointing at
the same value as InstallPath. It's an installer-only change and very low (no?)
risk, just prep
Brian Curtin added the comment:
Nothing's keeping it from moving forward at this point. Progress stagnated the
last few months because I was busy doing organizational and PR work for PyCon.
Now that the conference has passed, this and installer changes are on the top
of my list. I
Brian Curtin added the comment:
I just get a MemoryError. Do you actually receive a crash?
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue14
Brian Curtin added the comment:
On 2 and 4, see #3561 for that discussion. A short answer would be that we're
consenting adults. Additionally, the current Path-adding installer handles
uninstallation.
--
___
Python tracker
<http://bugs.py
Brian Curtin added the comment:
> Additionally, the current Path-adding installer handles uninstallation.
--
___
Python tracker
<http://bugs.python.org/issu
Changes by Brian Curtin :
--
keywords: +needs review
nosy: +gps
stage: -> patch review
versions: -Python 2.6, Python 3.1, Python 3.2, Python 3.3, Python 3.4
___
Python tracker
<http://bugs.python.org/issu
Brian Curtin added the comment:
Please don't close it. Users in this situation can't use IDLE. We should at
least try alternative locations to create this directory or perhaps prompt them
for a directory they'd like to use.
--
___
Changes by Brian Curtin :
--
assignee: -> brian.curtin
components: +Extension Modules
stage: -> needs patch
___
Python tracker
<http://bugs.python.org/i
Brian Curtin added the comment:
> So it's not an issue, try calling memoryview(fdopen( 0,1,2>) and it'll work.
This is exactly why it's an issue. Python should not crash.
--
nosy: +brian.curtin
status: closed -> open
_
Brian Curtin added the comment:
Maybe it's a different reason, but some part of something about this crashes on
Windows. "python.exe has stopped working" is a crash dialog.
--
___
Python tracker
<http://bugs.pyt
Brian Curtin added the comment:
-1
0 has no special meaning on Windows so I'd rather not add another special case
for posix emulation. Additionally, 0 unfortunately already means two things as
it is: signal.CTRL_C_EVENT and the int 0.
--
status: open ->
Brian Curtin added the comment:
I can't find where we talked about this, maybe just IRC, but that's there
(perhaps poorly) as a special case.
0 is 0, but signal.CTRL_C_EVENT is also 0. We try the signal version first then
fall back to TerminateProcess.
I was just looking at this
Brian Curtin added the comment:
I don't remember exactly why, but it can be removed. It may have just been left
in while I was debugging it.
As for the second point, why else are you calling os.kill if you don't want to
kill the given process? I don't disagree that it's
Brian Curtin added the comment:
I meant that in the underlying, such as in the TerminateProcess API, 0 doesn't
mean anything special. As is being debated over on #14484 we currently take all
integers to be passed to TerminateProcess (the int becomes the killed proc's
return code
Changes by Brian Curtin :
--
priority: critical -> release blocker
___
Python tracker
<http://bugs.python.org/issue14470>
___
___
Python-bugs-list mai
Brian Curtin added the comment:
Attached is issue3561.diff which adds a path option, off by default, as a
feature to be installed. I've tested installation and un-installation with the
feature both installed and not installed and it seems to work fine for me.
http://briancurtin.com/p
Changes by Brian Curtin :
Removed file: http://bugs.python.org/file24574/prependpath_in-progress.diff
___
Python tracker
<http://bugs.python.org/issue3561>
___
___
Pytho
Brian Curtin added the comment:
I unlinked the old diff. issue3561.diff is the one that matters.
As for what happens with multiple installations, it's no different than how
you'd already be managing it or anything else like it. If you install 2.7 with
the path option enabled an
Brian Curtin added the comment:
> UI-wise, I'm not sure why it looks like an installable component rather than
> a separate checkbox. Is it a limitation of the installation software?
I originally did it as a separate check box UI-wise but couldn't hook that into
be an actual
Brian Curtin added the comment:
Agreed. I will work up a more friendly text to go along with the feature.
--
___
Python tracker
<http://bugs.python.org/issue3
Changes by Brian Curtin :
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue14578>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brian Curtin added the comment:
I don't think we need the vcproj file, unless I missed something.
--
___
Python tracker
<http://bugs.python.org/is
Brian Curtin added the comment:
pythoncore.vcproj)
> > * no changes to pcbuild.sln needed
> > * removed reference to 'win32_functions.c' in setup.py
>
> I think the module would be better named _win32, since that's the name
> of the API (like POSIX under Uni
Changes by Brian Curtin :
--
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
New submission from Brian Curtin :
Antoine mentioned in email that the reference handling should be changed, so
here's a shot at it. I also condensed and renamed the convenience functions - I
was paying too much attention to the surrounding conventions and made this
harder than it had
Brian Curtin added the comment:
Not sure why test_extension_import_fail is failing - not seeing that here.
--
___
Python tracker
<http://bugs.python.org/issue14
Brian Curtin added the comment:
How about this patch? Adds NULL checking and merges PyErr_SetExcWithArgsKwargs
inside PyErr_SetImportError since it's not needed by itself. Docs are also
updated in line with these changes.
--
Added file: http://bugs.python.org/file25248/issue
Brian Curtin added the comment:
New changeset e394ba32147f687b6bc7518d461f1d84211698e0 by Brian Curtin
(Charles-Axel Dein) in branch 'master':
bpo-35404: Clarify how to import _structure in email.message doc (GH-10886)
https://github.com/python/cpyt
Brian Curtin added the comment:
New changeset 478f8291327a3e3ab17b5857699565df43a9e952 by Brian Curtin (Ashwin
Ramaswami) in branch 'master':
bpo-21257: document http.client.parse_headers (GH-11443)
https://github.com/python/cpython/commit/478f8291327a3e3ab17b5857699565
Changes by Brian Curtin :
--
nosy: -brian.curtin
___
Python tracker
<http://bugs.python.org/issue29553>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brian Curtin added the comment:
New changeset 3d707be950b387552585451071928e7b39cdfa53 by Brian Curtin (Jim
DeLaHunt) in branch 'master':
bpo-29521 Fix two minor documentation build warnings (#41)
https://github.com/python/cpython/commit/3d707be950b387552585451071928e
New submission from Brian Curtin :
It would be helpful to clarify what the *predicate* callable will be called
with. I had to look into the source in order to figure out what it was going to
receive.
--
assignee: brian.curtin
components: Documentation
messages: 315824
nosy
Change by Brian Curtin :
--
keywords: +patch
pull_requests: +6311
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Brian Curtin :
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue33371>
___
___
Pyth
New submission from Brian Curtin :
Since 1993, aifc.openfp has simply pointed to aifc.open as a matter of
backwards compatibility. See
https://github.com/python/cpython/commit/7bc817d5ba917528e8bd07ec461c635291e7b06a
for the exact change.
aifc.openfp is both undocumented and untested, and in
Change by Brian Curtin :
--
keywords: +patch
pull_requests: +4302
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Brian Curtin added the comment:
i was going to do them as separate bugs and PRs per module, but if one is fine
then i can do that.
Updating the title as well since nothing is beings removed (was originally
going to suggest skipping to removal but won’t do that).
--
title: Deprecate
Brian Curtin added the comment:
Serhiy, where should a common test that covers all three of these go? I'm not
seeing an obvious place for it.
--
___
Python tracker
<https://bugs.python.org/is
Brian Curtin added the comment:
I think https://github.com/python/cpython/pull/4344 covers what you're looking
for.
--
___
Python tracker
<https://bugs.python.org/is
Brian Curtin added the comment:
New changeset 9f914a01affc55abe799afc521ce71612bb495a5 by Brian Curtin in
branch 'master':
bpo-31985: Deprecate openfp in aifc, sunau, and wave (#4344)
https://github.com/python/cpython/commit/9f914a01affc55abe799afc521ce71
Brian Curtin added the comment:
New changeset eef059657d6b10babdb4831e1148d60cc644ee9a by Brian Curtin (Zackery
Spytz) in branch 'master':
bpo-31370: Remove references to threadless builds (#8805)
https://github.com/python/cpython/commit/eef059657d6b10babdb4831e1148d6
Brian Curtin added the comment:
New changeset e45473e3ca31e5b78dc85cab575f5bb60d5b7f8f by Brian Curtin (Zackery
Spytz) in branch 'master':
bpo-27351: Fix ConfigParser.read() documentation and docstring (GH-8123)
https://github.com/python/cpyt
Brian Curtin added the comment:
New changeset b0b8f9bd4e6f78ac7383b4e56cfb6cbacc77da89 by Brian Curtin (Miss
Islington (bot)) in branch '3.7':
bpo-27351: Fix ConfigParser.read() documentation and docstring (GH-8123)
https://github.com/python/cpyt
Brian Curtin added the comment:
New changeset 3cd5e8e83c9785d9f505138903c7a50dc964101e by Brian Curtin (Miss
Islington (bot)) in branch '3.6':
bpo-27351: Fix ConfigParser.read() documentation and docstring (GH-8123)
https://github.com/python/cpyt
Brian Curtin added the comment:
New changeset 8d3b0f49021e6cd25030a1eb979218cfceb44061 by Brian Curtin (Andrés
Delfino) in branch '2.7':
[2.7] bpo-13407: Mention that bz2/tarfile doesn't support multi-stream bzip2
files (GH-8428)
https://github.com/python
Change by Brian Curtin :
--
assignee: docs@python -> brian.curtin
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python
Changes by Brian Curtin :
--
nosy: -brian.curtin
___
Python tracker
<http://bugs.python.org/issue8112>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Brian Curtin :
--
nosy: -brian.curtin
___
Python tracker
<http://bugs.python.org/issue2554>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brian Curtin added the comment:
Can't this just be a Python script?
--
___
Python tracker
<http://bugs.python.org/issue16895>
___
___
Python-bugs-list m
Brian Curtin added the comment:
Don't we already require an existing Python to build some of the third-party
stuff, e.g., OpenSSL?
I don't think the bootstrapping issue holds that much weight. Adding some huge
batch script that maybe one or two people even know how to modify is a mu
Changes by Brian Curtin :
--
nosy: -brian.curtin
___
Python tracker
<http://bugs.python.org/issue7883>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brian Curtin added the comment:
Sorry, I don't think this is something we can do. We're not going to put an
image link into an exception message or docstring.
--
nosy: +brian.curtin
stage: -> committed/rejected
status: open -> closed
__
Changes by Brian Curtin :
--
nosy: -brian.curtin
___
Python tracker
<http://bugs.python.org/issue9097>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brian Curtin added the comment:
Can you say why?
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue18354>
___
___
Python-bugs-list mailin
Brian Curtin added the comment:
Fixed in r14798 of the site.
--
assignee: docs@python -> brian.curtin
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python
Brian Curtin added the comment:
Benjamin probably has the final say on backporting this to 2.7. I'm doing the
3.3/default commit right now.
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/is
Brian Curtin added the comment:
^That takes care of default. I misspoke in an earlier comment about 3.3 - that
should probably be determined by that RM (Georg?)
--
___
Python tracker
<http://bugs.python.org/issue18
Brian Curtin added the comment:
Here's a patch with better wording, and here's a screenshot of what the feature
selection looks like with that text: http://i.imgur.com/k7e12.png
--
Added file: http://bugs.python.org/file25255/issue35
Brian Curtin added the comment:
The attached patch changes the feature text to "Add python.exe to Path". I'm
not sure the word "search" adds much there anyway.
An additional change here that I think would be beneficial is a better
description text, immediately cov
New submission from Brian Curtin :
Now that #3561 is in, it needs to be mentioned in at least the following places:
Doc\whatsnew\3.3.rst
Doc\faq\windows.rst
http://python.org/download/windows/ could use an update, but that's on a
separate SVN repository
--
assignee: brian.c
Brian Curtin added the comment:
Now that the feature is in, I'm going to track the few places we need to
document it in #14668.
--
resolution: -> fixed
stage: commit review -> committed/rejected
status: open -> closed
___
Python
Changes by Brian Curtin :
--
nosy: -brian.curtin
___
Python tracker
<http://bugs.python.org/issue8304>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brian Curtin added the comment:
James, since you attached a Windows executable I'll assume that's the platform
you're on.
Try the following:
1. Open the Start menu
2. Choose "All Programs" (or "Programs" on XP, I think)
3. Scroll to where you see "P
Brian Curtin added the comment:
I recently added what you just mentioned in the vs2010port branch for WSA and
non-WSA to work together. I still need to figure out some distutils/packaging
failures, but the port is nearly ready*.
* I've only focused on 32-bit debug builds, but updatin
Brian Curtin added the comment:
No, this is the real thing. Python 3.3 distributed on VS2010.
In order to ship a fully built Python 3.3 MSI for users, I've found it's not
just as easy as updating errno. I'll strip out all of the project file changes
and whatnot and post a patc
Brian Curtin added the comment:
Also, I personally don't care about distutils, but I need all of the tests to
pass before I can consider merging this. Distutils and packaging need a few
changes to be able to compile extensions and create setups and whatever with
V
Brian Curtin added the comment:
Yes.
--
___
Python tracker
<http://bugs.python.org/issue13210>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brian Curtin added the comment:
I don't have a link handy, but from what I've read we could go from VS2010 to
VS2012 with relative ease since it's supposed to be able to work with 2010
solutions/project files. I haven't tried this with the beta, b
Brian Curtin added the comment:
VS11 opened the VS2010 project fine without doing conversion. Note that this
just uses VS11 to work with the project in VS2010 mode with the 2010 compiler.
Doing the conversion to VS11's compiler is another thing to consider, although
probably not unt
Brian Curtin added the comment:
We do the runtime checks for a few things in winreg as well as the os.symlink
implementation and i think a few other supplemental functions for symlinking.
--
___
Python tracker
<http://bugs.python.org/issue11
Brian Curtin added the comment:
The test for this issue seems to fail about half of the time on Windows.
==
ERROR: test_race (test.test_logging.HandlerTest
Brian Curtin added the comment:
As of a40f47cc7691, Richard's idea is now the implementation, which seems to
work well and has simplified the changes quite well. Attached is
code_changes.diff which shows all of the necessary code changes as of now.
The test_import failure you were origi
Brian Curtin added the comment:
I'm seeing this with the current tip 8635825b9734.
I wouldn't trust the build slaves with a race condition test since they're
incredibly slow machines, but this issue isn't about the race. That path really
should be accessible so I'm
Brian Curtin added the comment:
I have exemptions set in AV for my dev folders for exactly that reason :)
I'll try and poke around and get more info.
--
___
Python tracker
<http://bugs.python.org/is
Brian Curtin added the comment:
Reproduced here as well.
--
___
Python tracker
<http://bugs.python.org/issue14750>
___
___
Python-bugs-list mailing list
Unsub
Brian Curtin added the comment:
The tip of the vs2010 branch now works just as well as default does. There are
no outstanding test failures that aren't seen on default -- test_email still
fails for some line ending stuff, but that's not relevant here.
Attached is a patch showin
Brian Curtin added the comment:
Attached is full_vs2010_port.diff. It's 13000 lines, mostly taken up by the
conversion of project, filter, and solution files - tons of XML.
--
Added file: http://bugs.python.org/file25504/full_vs2010_port
New submission from Brian Curtin :
Attached is a patch to return the final destination of files or directories
sent through shutil's copy, copy2, and move functions. This removes the need to
construct the destination path on your own.
This is especially useful for copy/copy2 where you c
Brian Curtin added the comment:
Here's a patch that fixes the trailing whitespace Hynek noticed as well as adds
an additional test case for copy/copy2.
--
Added file: http://bugs.python.org/file25526/issue14772.diff
___
Python tracker
Brian Curtin added the comment:
Added another test using move as renaming the destination file.
--
Added file: http://bugs.python.org/file25527/issue14772_v2.diff
___
Python tracker
<http://bugs.python.org/issue14
Brian Curtin added the comment:
When you say "needs that", do you mean the patch as-is, or Hynek's suggestion
to return consistently?
--
___
Python tracker
<http://bugs.pyt
Brian Curtin added the comment:
What I just pushed has functioning debug and release builds for both 32 and 64
bit, and the tests introduce no new failures.
As noted on python-dev, we may not have build slaves setup for this change yet,
so the Windows builds may appear broken.
I'll
Brian Curtin added the comment:
Thanks for noticing. I moved them out to PC\VS9.0 rather than outright deleting.
--
___
Python tracker
<http://bugs.python.org/issue13
Brian Curtin added the comment:
Thanks for your report. Unfortunately Python 3.2 won't ever work in this way
because changing compilers would be a new feature, and bug fix releases like
3.2 don't receive new features. Yesterday we completed the transition to VS2010
as a step towar
Brian Curtin added the comment:
+1 on the patch. It fixes a bunch of things that I entered unnecessarily (like
explicit .pyd names to fix the warnings), but after staring at the screen for a
long time I couldn't figure out what I was doing wrong to need them for some
reason.
I'm
Brian Curtin added the comment:
Hm, actually, doing a 64-bit debug build fails with that patch. ctypes,
_testbuffer, and xxlimited, the projects I originally had trouble with in the
settings, don't link properly.
--
___
Python tracker
Brian Curtin added the comment:
Correction, both 64-bit debug and release fail.
--
___
Python tracker
<http://bugs.python.org/issue13210>
___
___
Python-bug
New submission from Brian Curtin :
With the addition of #3561, I think we might want to have the file association
feature follow it in not being a default feature. It seems a bit off that we
don't want to change the way "python" reacts on the command line by default,
but we do
Brian Curtin added the comment:
> Are there any features which make VS 2010 easier to use for us?
I don't do much with the IDE besides the basics of writing the code and
building it, so I can't really say if it makes anything easier on us. I think
the change is just going to
Brian Curtin added the comment:
Does that failure happen to you every time? I occasionally see those RSP files
causing some failures, but those are something created by Visual Studio (2008
as well) and they sometimes get held open or cause problems being deleted. I've
always had success
801 - 900 of 1382 matches
Mail list logo
