Brian Curtin added the comment:
Can you add your test(s) in Lib/test/test_doctest.py ? That way it will be run
with the Python regression suite. Ideally a documentation update would come
with the patch. Also, line length should ideally be capped at 79 characters
(re: PEP-8).
Might as well
Brian Curtin added the comment:
With patch #25, I get 6 test failures: test_glob, test_os, test_platform,
test_posixpath, test_shutil, and test_tarfile.
This is interesting because the failures are different depending on how I
compile Python. Running in WOW64 (32-bit Python on 64-bit
Changes by Brian Curtin :
--
keywords: +needs review
type: behavior -> feature request
versions: -Python 3.1
___
Python tracker
<http://bugs.python.org/iss
Brian Curtin added the comment:
I'll look into whatever other trickery could be applied to 2.6/3.1.
The patch against trunk works correctly for Win7, Win 2003 Server SP1, Win XP
SP2, and Win 2000 Server SP2. platform.platform() outputs the same info for the
latter three OSes whether o
Brian Curtin added the comment:
False alarm, the failures are my fault. I had a previous version of
symlink_support, and applying patch 25 added the contents of symlink_support to
the file again, thus causing an ImportError on that file. Sorry about that.
I removed the file, applied patch 25
Brian Curtin added the comment:
Can you provide a test case which can reproduce the issue? Specifically one
which doesn't require the use of your DatabaseLibrary package?
--
nosy: +brian.curtin
priority: -> normal
stage: -> test needed
type: performance ->
Changes by Brian Curtin :
--
components: +Windows
keywords: +needs review, patch
priority: -> normal
stage: -> patch review
type: -> behavior
versions: +Python 3.1, Python 3.2 -Python 2.5
Added file: http://bugs.python.org/file16210/issue
Brian Curtin added the comment:
Prashanth, I'm not even sure what to do with that file.
Can you provide a Python script which demonstrates your issue? It should be
something that myself or others could run on their computer, free of any third
party packages. This will isolate the iss
Brian Curtin added the comment:
> It may be better for the test method to take arguments, and
> be decorated as a parameterized test, with the decorator
> providing the parameters.
+1 on something like this. That's also how NUnit supports parameterized tests.
--
nosy:
Changes by Brian Curtin :
--
resolution: -> invalid
type: compile error -> behavior
___
Python tracker
<http://bugs.python.org/issue7914>
___
___
Pyth
Brian Curtin added the comment:
Here's a patch which corrects executemany, along with execute and
executescript. An explicit title is used, with a reference to the underlying
Cursor methods.
--
keywords: +needs review, patch
nosy: +brian.curtin
priority: -> low
stage:
Brian Curtin added the comment:
"This module also defines two shortcut functions"
I think given that we say the calls are shortcuts, and that their arguments are
the same as Popen, I take that to mean that subprocess.call experiences the
same situations as subprocess.Popen.
If
Changes by Brian Curtin :
--
resolution: -> invalid
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue7948>
___
___
Python-bugs-list
Brian Curtin added the comment:
The bug tracker is not the right place to release your modules. If you have a
distributable module rather than a patch, PyPi may be a better place to put
your results.
--
nosy: +brian.curtin
resolution: -> rejected
status: open ->
Brian Curtin added the comment:
Does anyone prefer if this should be done on a patch-per-module basis, or just
throw together one huge change?
Also, I've found a few places where context managers aren't supported where
they probably should be, so I'll spin off separate i
Brian Curtin added the comment:
Here is a patch which expands on Jaime's patch. I was converting tests for
#7944 and looked at test_tarfile, and implemented the same feature that he did.
All places where context managers should be used in the test, they are used.
Includes a doc update w
Brian Curtin added the comment:
I'm going to go ahead with the patch-per-module approach, but anyone feel free
to stop me from doing that.
Here's a patch for test_gzip on trunk.
--
Added file: http://bugs.python.org/file16286/issue7944
Brian Curtin added the comment:
Here's a patch for test_tempfile on trunk. The rest will just be silently added
since this is already annoying.
--
Added file: http://bugs.python.org/file16289/issue7944_tempfile.diff
___
Python tracker
Brian Curtin added the comment:
The last patch does more than it should for this issue. Here is a minimal patch
with the change, test, and doc updates.
--
Added file: http://bugs.python.org/file16307/issue7232.diff
___
Python tracker
<h
New submission from Brian Curtin :
After discussion on numerous issues, python-dev, and here at the PyCon sprints,
it seems to be a good idea to move timemodule.c to _timemodule.c and convert as
much as possible into pure Python. The same change seems good for datetime.c as
well
Brian Curtin added the comment:
Correct, your wording is better than mine.
I'll ask around and see where that datetime module may be and what it's state
is.
--
___
Python tracker
<http://bugs.python.
Brian Curtin added the comment:
Whoops, sorry. Here is the change as requested. It reverts to the old way when
needed, which hardcodes the version to VER_NT_WORKSTATION as it effectively
used to.
Outside of a hackish and incredibly slow method, I have no idea how to figure
out workstation
Brian Curtin added the comment:
I'm not able to reproduce this any of the python.org installers, or the current
trunk. I am running 64-bit Windows 7, though, whereas you are running 32-bit. I
don't imagine there should be a difference, but I'll try to obtain a 32-bit box
a
Brian Curtin added the comment:
I did both of those things and I'm still not able to reproduce it. Do you have
any specific language settings enabled?
One thing I meant to ask in my last message was if you had a copy of what you
tried to paste into the window. I've pasted a 500
Brian Curtin added the comment:
This patch should cover everything, and it works with 2.6 as well. In order to
figure out workstation vs. server, it uses the ProductName from the registry
when it can't the info from getwindowsversion. If it finds a server name, it's
a server,
Brian Curtin added the comment:
That solution will work if you have 1 file or 1000 files. The note on the
documentation is very clear on what has to happen.
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue7
Brian Curtin added the comment:
Good point. How about version 5? It uses base Exception in the context manager,
which will allow us to differentiate between no exception being raised, and the
wrong one being raised. After the context manager, we check the type of the
exception to make sure
Brian Curtin added the comment:
That seems reasonable. We already have subprocess.call, the thin wrapper around
Popen. Maybe add this as subprocess.call_shell and call_exec?
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.
Brian Curtin added the comment:
Even if we changed the ACL of the executable, any user could still add
malicious code to be executed on import, as the C:\PythonXY directory doesn't
require specific privileges for writing to it, and it shouldn't by default.
When installed to "C
Brian Curtin added the comment:
I've uploaded the patch to http://codereview.appspot.com/223088
--
___
Python tracker
<http://bugs.python.org/issue7347>
___
___
Changes by Brian Curtin :
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue1284316>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Brian Curtin :
Most file or file-like objects operate as context managers, except for mmap
(and maybe a few others?). Attached is a patch with tests and documentation.
The patch also introduces an additional attribute to mmap, "closed".
--
components: Li
Brian Curtin added the comment:
The list2cmdline function checks spaces, tabs, etc in line 521 of
subprocess.py. In your first test case, it ends up checking if a string is
contained in a bytes object, which is a TypeError for the str not supporting
the buffer API.
Would it be acceptable
Changes by Brian Curtin :
--
assignee: -> michael.foord
nosy: +michael.foord
priority: -> normal
stage: -> needs patch
versions: -Python 3.1, Python 3.3
___
Python tracker
<http://bugs.python.o
Brian Curtin added the comment:
#6716 is a related issue, but isn't exactly a duplicate.
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/i
Changes by Brian Curtin :
--
components: +Windows
priority: -> high
stage: -> needs patch
type: -> behavior
___
Python tracker
<http://bugs.python.o
Brian Curtin added the comment:
As documented, this is not supported on Windows.
http://docs.python.org/dev/library/os#os.uname
os.uname is generated in Modules/posixmodule.c, not in platform.py
--
nosy: +brian.curtin
resolution: -> invalid
status: open ->
Brian Curtin added the comment:
FWIW, _winreg.ExpandEnvironmentStrings does the right thing.
D:\python-dev\trunk>PCbuild\amd64\python.exe
Python 2.7a3+ (trunk, Feb 23 2010, 20:22:24) [MSC v.1500 64 bit (AMD64)] on
win32
Type "help", "copyright", "credits"
Brian Curtin added the comment:
Here is a patch for trunk.
It works for me, but my Unicode knowledge isn't the strongest. I believe
sys.getfilesystemencoding() is what we want here. Can anyone confirm?
--
keywords: +patch
nosy: +loewis
Added file: http://bugs.python.org/file
Changes by Brian Curtin :
--
components: +Library (Lib)
priority: -> normal
stage: -> needs patch
versions: +Python 2.7, Python 3.2
___
Python tracker
<http://bugs.python.org/
Brian Curtin added the comment:
I don't really think this is a documentation bug, more of an issue you have
with the policy, in which case this is better being discussed on python-dev.
--
nosy: +brian.curtin
___
Python tracker
Changes by Brian Curtin :
--
components: +Windows
nosy: +brian.curtin
priority: -> normal
stage: -> needs patch
type: -> behavior
___
Python tracker
<http://bugs.python.o
Brian Curtin added the comment:
I've reviewed the patch and do not see any unnecessary whitespace changes in
his patch.
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/i
Changes by Brian Curtin :
--
priority: -> low
stage: -> needs patch
type: -> behavior
___
Python tracker
<http://bugs.python.org/issue8090>
___
___
P
New submission from Brian Curtin :
Creating an mmap object can crash the interpreter on Windows if a file
descriptor is passed in which is outside of the range for _get_osfhandle. I
noticed the crash possibility while reviewing the Modules/mmapmodule.c code for
work on another issue related
Changes by Brian Curtin :
Removed file: http://bugs.python.org/file16515/mmap_crash.diff
___
Python tracker
<http://bugs.python.org/issue8105>
___
___
Python-bugs-list m
Changes by Brian Curtin :
Added file: http://bugs.python.org/file16516/mmap_crash.diff
___
Python tracker
<http://bugs.python.org/issue8105>
___
___
Python-bugs-list m
Brian Curtin added the comment:
I should add that I tried the same thing on linux and no crash occured, it
properly raised an exception.
--
___
Python tracker
<http://bugs.python.org/issue8
Changes by Brian Curtin :
--
nosy: +janssen
priority: -> normal
___
Python tracker
<http://bugs.python.org/issue8106>
___
___
Python-bugs-list mailing list
Un
Brian Curtin added the comment:
In a command prompt window, type the following:
C:\>set TCL_LIBRARY=
C:\>set TK_LIBRARY=
C:\>C:\Python31\python.exe C:\Python31\Lib\idlelib\idle.py
--
nosy: +brian.curtin
___
Python tracker
<http://bug
Changes by Brian Curtin :
--
components: +Windows
priority: -> normal
stage: -> test needed
versions: -Python 3.3
___
Python tracker
<http://bugs.python.org/
Brian Curtin added the comment:
Also, using platform.system() == 'Windows' would exclude IronPython running on
Mono.
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.
Brian Curtin added the comment:
Amaury is right. On Windows, _subprocess is a built-in, so the platform stuff
just currently enables further failure.
Dave: My C# skills aren't the greatest, but looking at PC/_subprocess.c there
are a few Win32 functions you might need to P/Invoke,
Brian Curtin added the comment:
Can you provide a test case which reproduces your issue?
--
components: +Library (Lib)
nosy: +brian.curtin
stage: -> test needed
___
Python tracker
<http://bugs.python.org/iss
Brian Curtin added the comment:
That was an example of the cmd prompt.
Just type "set TCL_LIBRARY=" without the quotes, along with the contents of the
other three lines except for the "C:\>".
--
___
Python tracker
Brian Curtin added the comment:
Just delete the Python22 folder.
Typing "set TCL_LIBRARY=" (note the equal sign) will unset the environment
variable for that command prompt. Can you try running the steps from msg100786?
--
___
Pyth
Changes by Brian Curtin :
--
components: +Library (Lib) -Build
priority: -> normal
stage: -> test needed
type: -> behavior
___
Python tracker
<http://bugs.python.o
Brian Curtin added the comment:
Also, keep in mind that shutil.copytree is more of an example than the
be-all-end-all directory copy function, as stated in both the documentation and
source code.
--
nosy: +brian.curtin
___
Python tracker
<h
Brian Curtin added the comment:
Your MSI works for me and fixes problem 1.
--
___
Python tracker
<http://bugs.python.org/issue6716>
___
___
Python-bugs-list m
Brian Curtin added the comment:
That would depend on the implementation of the system() call on your platform.
There are already two notes for Unix and Windows right below that paragraph.
Going further into lower level specifics of the system() call is outside the
scope of that documentation
Brian Curtin added the comment:
You'll want to look at
http://wiki.python.org/moin/PythonWebsiteCreatingNewTickets
Win 2000 is currently supported, although there have been rumblings of
beginning to drop that support.
The info exists in PEP-11 for now, but I agree that a sentence woul
Changes by Brian Curtin :
--
nosy: +vinay.sajip
priority: -> normal
stage: -> test needed
___
Python tracker
<http://bugs.python.org/issue8148>
___
___
Changes by Brian Curtin :
Removed file: http://bugs.python.org/file16156/issue7347.diff
___
Python tracker
<http://bugs.python.org/issue7347>
___
___
Python-bugs-list m
Brian Curtin added the comment:
Fixed a few a/an word changes and a few tab/space issues. Re-uploaded to
Rietveld at http://codereview.appspot.com/580041
--
Added file: http://bugs.python.org/file16558/issue7347.diff
___
Python tracker
<h
Changes by Brian Curtin :
--
priority: -> normal
stage: -> needs patch
type: -> behavior
versions: +Python 3.1
___
Python tracker
<http://bugs.python.o
Brian Curtin added the comment:
Duplicate of #7773 which was fixed with r77735.
--
nosy: +brian.curtin
resolution: -> duplicate
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Changes by Brian Curtin :
--
nosy: +vinay.sajip
priority: -> normal
versions: +Python 3.1, Python 3.2
___
Python tracker
<http://bugs.python.org/iss
Brian Curtin added the comment:
#7347 depends on this for proper testing, and arch_misrepresented.diff seems to
have been labeled as acceptable. Would anyone be willing to check it in?
--
___
Python tracker
<http://bugs.python.org/issue7
Brian Curtin added the comment:
This was fixed in r78206 for trunk, but it doesn't look like it made it's way
into any of the other branches.
--
nosy: +brian.curtin
priority: -> low
type: -> behavior
___
Python tracker
<htt
Brian Curtin added the comment:
RegDeleteKeyEx will only work on a Windows version of 5.2 or greater (Vista/XP
x64), and XP is 5.1, so RegDeleteKeyEx can't be a simple drop-in under the
"DeleteKey" name.
CreateKeyEx is different though since it goes as far back as Win2k, and i
Changes by Brian Curtin :
--
resolution: -> invalid
status: open -> closed
title: Hohe Qualitaet und beste Preise garantiert. -> spam
___
Python tracker
<http://bugs.python.o
Changes by Brian Curtin :
--
resolution: -> invalid
status: open -> closed
title: Online kaufen die beste Software! -> spam
___
Python tracker
<http://bugs.python.o
Brian Curtin added the comment:
I'll reopen this for now, no need for duplicate issues.
http://www.python.org/psf/contrib/ has the relevant contributor agreement that
should be signed.
--
resolution: rejected ->
status: closed -> open
___
Brian Curtin added the comment:
Ah, that's simple enough :)
Minor changes to the test patch: uname caches it's results, so I added a few
lines to clear the cache before the uname calls. In order to not affect other
tests, the whole thing is in a try/finally so we don't leave
Brian Curtin added the comment:
Given that this is a feature request, it would go into 2.7 rather than 2.6.
The patch will need a test (see Lib/test/test_zipfile.py) and a documentation
update (see Doc/library/zipfile.rst).
--
nosy: +brian.curtin
priority: -> normal
stage: ->
Brian Curtin added the comment:
Actually this was recently fixed on trunk (r78097) and py3k (r78098). See #6003.
--
resolution: -> duplicate
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Changes by Brian Curtin :
--
nosy: +benjamin.peterson
priority: -> normal
stage: -> needs patch
type: -> behavior
___
Python tracker
<http://bugs.python.o
Changes by Brian Curtin :
--
nosy: +brian.curtin
priority: -> normal
stage: -> test needed
___
Python tracker
<http://bugs.python.org/issue8224>
___
___
Brian Curtin added the comment:
I believe the problem is with pydoc. In the case of xml.etree, I don't think it
should be displaying anything for MODULE DOCS.
help(xml.etree.ElementTree) does display the proper link.
The attached patch and test fixes the problem.
--
ass
Changes by Brian Curtin :
--
type: performance -> behavior
___
Python tracker
<http://bugs.python.org/issue8225>
___
___
Python-bugs-list mailing list
Unsubscri
Brian Curtin added the comment:
Are you running a service? I can't say I'm too familiar with the file you
uploaded, but the file contains a few things that lead me to believe you may
be. As David said, it would be helpful to know what you were doing.
--
nosy: +br
Brian Curtin added the comment:
I just reproduced this by removing write access from my user for my home
directory.
It seems odd that you wouldn't have write access to your home directory in the
first place, but that's tangent to the issue. I'll see if there are other
accep
Brian Curtin added the comment:
(adding myself to the nosy list as a Windows dev)
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue7
Brian Curtin added the comment:
On Windows, the WindowsDefault class gets used and it doesn't make use of
anything other than the URL (no 'new' or 'autoraise'). All it does is pass the
URL onto os.startfile.
It should make a better attempt at running the URL. Patches
Changes by Brian Curtin :
--
title: webbrowser open(), open_new(), and open_new_tab() Broken Functionality
-> webbrowser.open incomplete on Windows
___
Python tracker
<http://bugs.python.org/iss
Brian Curtin added the comment:
Minor correction: BackgroundBrowser gets used in this case, but it still lacks
in the same area and causes what you are seeing.
--
___
Python tracker
<http://bugs.python.org/issue8
Brian Curtin added the comment:
Fixed in trunk (r79430), release26-maint (r79631), py3k (r79434), and
release31-maint (r79435). Thanks for the patch.
--
assignee: georg.brandl -> brian.curtin
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open ->
Brian Curtin added the comment:
This is fixed as of r79248.
--
nosy: +brian.curtin
priority: -> normal
resolution: -> duplicate
status: open -> closed
___
Python tracker
<http://bugs.python.o
Brian Curtin added the comment:
I have this working with process IDs and my vote would be to keep it that way,
as it would stay in-line with the other platforms, and it seems to work so far.
I would imagine that was also IronPython's goal.
I'm still working on the test portion of
Brian Curtin added the comment:
I went through and made a lot of grammar corrections and rewording throughout
the file. See attached patch.
I have no idea if this doc is technically correct. I only made grammar changes
since I'm not a big web developer, but it could probably use a look
Changes by Brian Curtin :
Removed file: http://bugs.python.org/file16692/issue8218_v2.diff
___
Python tracker
<http://bugs.python.org/issue8218>
___
___
Python-bugs-list m
Brian Curtin added the comment:
My first patch removed a lot of the he/him/his wording, but now that you
mentioned it found another one. Updated the patch.
--
Added file: http://bugs.python.org/file16693/issue8218_v3.diff
___
Python tracker
<h
Brian Curtin added the comment:
Duplicate of #5689.
--
nosy: +brian.curtin
resolution: -> duplicate
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Brian Curtin added the comment:
Here is a patch with some tests and doc changes.
I'm having trouble coming up with tests which will work with CTRL_C_EVENT and
CTRL_BREAK_EVENT. Based on my understanding of GenerateConsoleCtrlEvent, I
figured this example
(http://msdn.microsoft.com/
Changes by Brian Curtin :
Removed file: http://bugs.python.org/file16703/issue1220212.patch
___
Python tracker
<http://bugs.python.org/issue1220212>
___
___
Python-bug
Brian Curtin added the comment:
Removed an unnecessary goto and fixed a few tab/space inconsistencies (ugh).
--
Added file: http://bugs.python.org/file16704/issue1220212.patch
___
Python tracker
<http://bugs.python.org/issue1220
Brian Curtin added the comment:
Fixed in trunk (r79518), release26-maint (r79519), py3k (r79520), and
release31-maint (r79521).
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
versions: +Python 2.7, Python 3.1, P
Brian Curtin added the comment:
Anyone opposed to this being checked in? Other than some style issues which
I'll fix on checkin, I believe this is ready to go. I'd like to get it in so I
can backport it to 2.7 before the beta on Saturday.
--
assignee: eric.smith ->
Brian Curtin added the comment:
Good catch. That was intended to be a single tuple because the other check
above is a tuple, but because this really only checks one thing it could be a
!= until its necessary to be a tuple. I'll f
Brian Curtin added the comment:
Made the change in r79529 through 79532.
--
___
Python tracker
<http://bugs.python.org/issue8225>
___
___
Python-bugs-list mailin
601 - 700 of 1382 matches
Mail list logo