Changes by Brian Curtin :
--
keywords: +needs review
priority: -> normal
stage: -> test needed
___
Python tracker
<http://bugs.python.org/issue7826>
___
__
Changes by Brian Curtin :
--
priority: -> normal
stage: -> test needed
___
Python tracker
<http://bugs.python.org/issue7827>
___
___
Python-bugs-list
Brian Harring added the comment:
*Cough*.
Ya, going to blame the bugzie on that one. right, it's at fault rather than me
being a complete freaking moron.
Patch attached, hopefully with far less idiocy than I've demonstrated thus
far
Pardon.
--
Added
Brian Harring added the comment:
Related note, don't be drunk when posting the missing patch- sorry for the
noise, here is the caching version,, daftly presumed the early patch contained
lib2to3.caching
Now I'm going to go crawl in a corner, if you need me, I'll be there.
Dou
Changes by Brian Harring :
Removed file: http://bugs.python.org/file16078/2to3-caching.patch
___
Python tracker
<http://bugs.python.org/issue7826>
___
___
Python-bug
Changes by Brian Harring :
Removed file: http://bugs.python.org/file16080/2to3-caching.patch
___
Python tracker
<http://bugs.python.org/issue7826>
___
___
Python-bug
Brian Curtin added the comment:
The patch intentionally doesn't use assertIsInstance because that method
doesn't exist in 2.6.
--
___
Python tracker
<http://bugs.python.
Changes by Brian Curtin :
--
components: +Windows
keywords: +needs review
nosy: +brian.curtin
priority: -> normal
stage: -> test needed
type: -> behavior
___
Python tracker
<http://bugs.python.o
Changes by Brian Curtin :
Removed file: http://bugs.python.org/file15665/issue4772.diff
___
Python tracker
<http://bugs.python.org/issue4772>
___
___
Python-bugs-list m
Brian Curtin added the comment:
Minor change to the patch to correct for Antoine's suggestion.
--
Added file: http://bugs.python.org/file16089/issue4772.diff
___
Python tracker
<http://bugs.python.org/i
Changes by Brian Curtin :
Removed file: http://bugs.python.org/file16089/issue4772.diff
___
Python tracker
<http://bugs.python.org/issue4772>
___
___
Python-bugs-list m
Changes by Brian Curtin :
Added file: http://bugs.python.org/file16090/issue4772.diff
___
Python tracker
<http://bugs.python.org/issue4772>
___
___
Python-bugs-list mailin
Brian Curtin added the comment:
I haven't yet had a chance to look into what caused the failures, but
test_tarfile did not pass. This is on Windows 7 x64.
==
ERROR: test_extract_hardlink (__main__.MiscRea
Brian Curtin added the comment:
Most of the guts have already been reviewed, but here are some mainly minor
comments on the last patch.
Lib/test/symlink_support.py
- No need to import print_function
- I'd just put the docstrings on one line
- A bunch of if tests are one-lined
Lib
Brian Curtin added the comment:
The raw_input() doesn't provide anything. I'd just drop that and pass the
string directly to shlex.split.
"Do not put an argument-taking option together with its argument as a single
item in the *args* list"
-- Something like "Argum
Changes by Brian Curtin :
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue7316>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Brian Curtin :
--
keywords: +needs review
priority: -> normal
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue5099>
___
__
New submission from Brian Curtin :
On Windows, the subprocess module makes use of functions publicly exposed by
PC/_subprocess.c to interact with Win32 API functions. However, no
documentation exists for these functions, neither in the online docs nor in
docstrings.
--
assignee
Brian Curtin added the comment:
Attached is a patch which adds docstrings to the functions in PC/_subprocess.c,
documents the functions in Doc/library/subprocess.rst, and removes a chunk of
unneeded import code from Lib/subprocess.py
--
keywords: +needs review, patch
stage: needs
Changes by Brian Curtin :
Removed file: http://bugs.python.org/file16110/issue7838.diff
___
Python tracker
<http://bugs.python.org/issue7838>
___
___
Python-bugs-list m
Changes by Brian Curtin :
Added file: http://bugs.python.org/file16111/issue7838.diff
___
Python tracker
<http://bugs.python.org/issue7838>
___
___
Python-bugs-list mailin
Brian Curtin added the comment:
True. Is there value in eventually privatizing these functions?
It feels weird having them exposed but not documented at all...maybe just keep
the docstrings around?
--
status: open -> pending
___
Python trac
Changes by Brian Curtin :
--
keywords: +needs review
priority: -> normal
stage: -> test needed
type: -> behavior
versions: +Python 2.6, Python 2.7, Python 3.1, Python 3.2 -Python 2.5
___
Python tracker
<http://bugs.python.o
Brian Curtin added the comment:
Here's a patch which keeps docstrings, and explicitly qualifies the Windows
specific functions from _subprocess rather than using import * (which causes a
couple of lines just over 79 chars). Now the functions are more hidden than
before.
Ran the tests
Brian Curtin added the comment:
I just saw this today while installing the 3.1.1 final MSI on a Server 2003 box.
--
components: +Windows
nosy: +brian.curtin
priority: -> high
stage: -> needs patch
type: compile error -> behavior
___
Pytho
Changes by Brian Curtin :
--
___
Python tracker
<http://bugs.python.org/issue7854>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/m
Brian Curtin added the comment:
Rather than calling QueryValue and using fail(...) if it doesn't throw,
assertRaises(...) would do the trick.
--
assignee: theller ->
keywords: +needs review
nosy: +brian.curtin, michael.foord
priority: -> normal
stage: ->
New submission from Brian Curtin :
When running 32-bit Python on a 64-bit version of Windows, therefore running
the process in WOW64 mode, platform.machine returns a misleading value. When
running in WOW64, the processor architecture is masked to appear as "x86" when
the machine i
Changes by Brian Curtin :
Removed file: http://bugs.python.org/file15960/issue4722.diff
___
Python tracker
<http://bugs.python.org/issue4722>
___
___
Python-bugs-list m
Brian Curtin added the comment:
Note that this will also need the Workstation check that 6.0 has right above
this, because both Windows 7 and Windows Server 2008 R2 are version 6.1.x.
Also of note is that sys.getwindowsversion (renamed as GetVersionEx here) has
been expanded to make use of
Brian Curtin added the comment:
Here's a patch which fixes this on trunk.
2.6/3.1 is a different story as there doesn't appear to be a way to get the
platform type to differentiate workstation/server. #7766 is what makes it easy
on trunk, but it's a new feature and i
Brian Curtin added the comment:
This needs #7860 for properly figuring out the machine architecture for some
32-bit Python on 64-bit Windows tests.
--
dependencies: +32-bit Python on 64-bit Windows reports incorrect architecture
___
Python tracker
Brian Curtin added the comment:
Attached is what I believe is the complete patch. You'll need to apply the
patch on #7860 for proper test coverage of a 32-bit Python running on 64-bit
Windows.
Here's a summary of what's contained:
1. Documented and tested the previously u
Changes by Brian Curtin :
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue7867>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Brian Curtin :
Removed file: http://bugs.python.org/file15889/issue7301.diff
___
Python tracker
<http://bugs.python.org/issue7301>
___
___
Python-bugs-list m
Brian Curtin added the comment:
Updated patch, tests weren't working.
--
Added file: http://bugs.python.org/file16157/issue7301.diff
___
Python tracker
<http://bugs.python.org/i
Changes by Brian Curtin :
--
components: +Library (Lib) -2to3 (2.x to 3.0 conversion tool)
nosy: +vinay.sajip
priority: -> normal
stage: -> test needed
versions: +Python 3.1 -Python 2.5
___
Python tracker
<http://bugs.python.org/
New submission from Brian Curtin :
While EnumKey and EnumValue directly implement the underlying Windows calls of
the same name, they don't feel very Pythonic. The user has to create their own
loop and increment a counter to get all of the keys or values, stopping the
loop when Windows
Changes by Brian Curtin :
--
stage: -> test needed
___
Python tracker
<http://bugs.python.org/issue5802>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Brian Curtin :
--
priority: -> normal
stage: -> test needed
type: crash -> behavior
___
Python tracker
<http://bugs.python.org/issue7884>
___
___
Brian Curtin added the comment:
Is the situation any different if you install Python to "C:\Program Files"?
This seems to be at least part of the reason IronPython installs to "C:\Program
Files", which was discussed on the IronPython list [1] a few mon
Brian Curtin added the comment:
That change works for me.
--
nosy: +brian.curtin
priority: -> normal
stage: -> test needed
___
Python tracker
<http://bugs.python.org/
Brian Curtin added the comment:
Interesting, I'll take a look and see why that's happening.
Good point about the names.
--
___
Python tracker
<http://bugs.python.
Brian Harring added the comment:
Contributor agreement form is enroute via snail mail... kind of wish y'all
accepted pdf's via email though ;)
As for the print("cache hit"), that should be punted- not very useful in it's
current form (doesn't indicate what
Brian Curtin added the comment:
With the latest patch I get one failure: test_bufio. I piped that test to a
file and attached the results here. There are numerous "Permission denied:
@test" IOErrors.
--
Added file: http://bugs.python.org/file16181/test_bufio.
Brian Curtin added the comment:
Yep, that's the only one failing. The output I attached is the result of
running the test alone.
--
___
Python tracker
<http://bugs.python.org/i
Brian Curtin added the comment:
I don't think altzone was incorrect, but it could also use a little rewording.
Attached is a patch which rewords daylight and altzone. Thoughts?
--
keywords: +needs review
priority: -> normal
stage: -> patch review
versions: -Python 2.4,
Changes by Brian Curtin :
--
type: crash -> behavior
___
Python tracker
<http://bugs.python.org/issue3771>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Brian Curtin :
--
type: crash -> behavior
___
Python tracker
<http://bugs.python.org/issue4713>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Brian Curtin :
--
priority: -> normal
type: crash -> behavior
versions: +Python 3.1, Python 3.2 -Python 3.0
___
Python tracker
<http://bugs.python.org/
Changes by Brian Curtin :
--
priority: -> normal
stage: -> test needed
type: crash -> behavior
___
Python tracker
<http://bugs.python.org/issue4891>
___
___
Changes by Brian Curtin :
--
priority: -> normal
stage: -> test needed
type: crash -> behavior
___
Python tracker
<http://bugs.python.org/issue6815>
___
___
Changes by Brian Curtin :
--
priority: -> normal
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue5223>
___
___
Python-bugs-list
Changes by Brian Curtin :
--
priority: -> normal
stage: -> needs patch
type: crash -> behavior
___
Python tracker
<http://bugs.python.org/issue5527>
___
___
Changes by Brian Curtin :
--
priority: -> normal
type: crash -> behavior
___
Python tracker
<http://bugs.python.org/issue4918>
___
___
Python-bugs-list
Changes by Brian Curtin :
--
priority: -> normal
stage: -> patch review
type: crash -> behavior
versions: +Python 3.2 -Python 2.5, Python 3.0
___
Python tracker
<http://bugs.python.o
Changes by Brian Curtin :
--
type: crash -> behavior
___
Python tracker
<http://bugs.python.org/issue6470>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Brian Curtin :
--
priority: -> normal
type: crash -> behavior
versions: +Python 2.7, Python 3.1, Python 3.2 -Python 2.4, Python 2.5
___
Python tracker
<http://bugs.python.org/
Changes by Brian Curtin :
--
type: crash -> behavior
___
Python tracker
<http://bugs.python.org/issue6668>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Brian Curtin :
--
priority: -> normal
type: crash -> behavior
___
Python tracker
<http://bugs.python.org/issue6863>
___
___
Python-bugs-list
Changes by Brian Curtin :
--
keywords: +needs review
priority: -> normal
stage: -> patch review
type: crash -> behavior
___
Python tracker
<http://bugs.python.o
Brian Curtin added the comment:
What is the output of your example? I'm not on Linux at the moment, but I'm
trying to see if this is actually a crash.
--
nosy: +brian.curtin
priority: -> normal
stage: -> test needed
versio
Changes by Brian Curtin :
--
type: crash -> behavior
___
Python tracker
<http://bugs.python.org/issue6895>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Brian Curtin :
--
priority: -> normal
stage: -> test needed
___
Python tracker
<http://bugs.python.org/issue7424>
___
___
Python-bugs-list
Brian Curtin added the comment:
The patch could use a test (which doesn't require sgmlop).
--
keywords: +needs review
nosy: +brian.curtin
priority: -> normal
stage: -> test needed
title: Installing sgmlop can crash xmlrpclib -> Installing sgmlop causes
x
Changes by Brian Curtin :
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue7893>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Brian Curtin :
--
assignee: -> ronaldoussoren
components: +Macintosh
nosy: +ronaldoussoren
___
Python tracker
<http://bugs.python.org/iss
Brian Curtin added the comment:
With Ezio's latest patch (sent via IRC), test_bufio still fails and
additionally test_mailbox fails.
If I apply the patch on #7443 along with Ezio's patch, everything looks fine. I
haven't thoroughly looked at that issue, but on the surface i
Brian Curtin added the comment:
Can you add your test(s) in Lib/test/test_doctest.py ? That way it will be run
with the Python regression suite. Ideally a documentation update would come
with the patch. Also, line length should ideally be capped at 79 characters
(re: PEP-8).
Might as well
Brian Curtin added the comment:
With patch #25, I get 6 test failures: test_glob, test_os, test_platform,
test_posixpath, test_shutil, and test_tarfile.
This is interesting because the failures are different depending on how I
compile Python. Running in WOW64 (32-bit Python on 64-bit
Changes by Brian Curtin :
--
keywords: +needs review
type: behavior -> feature request
versions: -Python 3.1
___
Python tracker
<http://bugs.python.org/iss
Brian Curtin added the comment:
I'll look into whatever other trickery could be applied to 2.6/3.1.
The patch against trunk works correctly for Win7, Win 2003 Server SP1, Win XP
SP2, and Win 2000 Server SP2. platform.platform() outputs the same info for the
latter three OSes whether o
Brian Curtin added the comment:
False alarm, the failures are my fault. I had a previous version of
symlink_support, and applying patch 25 added the contents of symlink_support to
the file again, thus causing an ImportError on that file. Sorry about that.
I removed the file, applied patch 25
Brian Curtin added the comment:
Can you provide a test case which can reproduce the issue? Specifically one
which doesn't require the use of your DatabaseLibrary package?
--
nosy: +brian.curtin
priority: -> normal
stage: -> test needed
type: performance ->
Changes by Brian Curtin :
--
components: +Windows
keywords: +needs review, patch
priority: -> normal
stage: -> patch review
type: -> behavior
versions: +Python 3.1, Python 3.2 -Python 2.5
Added file: http://bugs.python.org/file16210/issue
Brian Curtin added the comment:
Prashanth, I'm not even sure what to do with that file.
Can you provide a Python script which demonstrates your issue? It should be
something that myself or others could run on their computer, free of any third
party packages. This will isolate the iss
Brian Curtin added the comment:
> It may be better for the test method to take arguments, and
> be decorated as a parameterized test, with the decorator
> providing the parameters.
+1 on something like this. That's also how NUnit supports parameterized tests.
--
nosy:
Changes by Brian Curtin :
--
resolution: -> invalid
type: compile error -> behavior
___
Python tracker
<http://bugs.python.org/issue7914>
___
___
Pyth
Brian Harring added the comment:
@benjamin:
Tests can be written; the reason this patch doesn't bundle tests up front is
that I wasn't going to burn the time till I knew they were needed since I
expected the concept to require some debate.
As for the hacks angle, there isn&
Brian Curtin added the comment:
Here's a patch which corrects executemany, along with execute and
executescript. An explicit title is used, with a reference to the underlying
Cursor methods.
--
keywords: +needs review, patch
nosy: +brian.curtin
priority: -> low
stage:
Brian Curtin added the comment:
"This module also defines two shortcut functions"
I think given that we say the calls are shortcuts, and that their arguments are
the same as Popen, I take that to mean that subprocess.call experiences the
same situations as subprocess.Popen.
If
Changes by Brian Curtin :
--
resolution: -> invalid
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue7948>
___
___
Python-bugs-list
Brian Curtin added the comment:
The bug tracker is not the right place to release your modules. If you have a
distributable module rather than a patch, PyPi may be a better place to put
your results.
--
nosy: +brian.curtin
resolution: -> rejected
status: open ->
Brian Curtin added the comment:
Does anyone prefer if this should be done on a patch-per-module basis, or just
throw together one huge change?
Also, I've found a few places where context managers aren't supported where
they probably should be, so I'll spin off separate i
Brian Curtin added the comment:
Here is a patch which expands on Jaime's patch. I was converting tests for
#7944 and looked at test_tarfile, and implemented the same feature that he did.
All places where context managers should be used in the test, they are used.
Includes a doc update w
Brian Curtin added the comment:
I'm going to go ahead with the patch-per-module approach, but anyone feel free
to stop me from doing that.
Here's a patch for test_gzip on trunk.
--
Added file: http://bugs.python.org/file16286/issue7944
Brian Curtin added the comment:
Here's a patch for test_tempfile on trunk. The rest will just be silently added
since this is already annoying.
--
Added file: http://bugs.python.org/file16289/issue7944_tempfile.diff
___
Python tracker
Brian Curtin added the comment:
The last patch does more than it should for this issue. Here is a minimal patch
with the change, test, and doc updates.
--
Added file: http://bugs.python.org/file16307/issue7232.diff
___
Python tracker
<h
New submission from Brian Curtin :
After discussion on numerous issues, python-dev, and here at the PyCon sprints,
it seems to be a good idea to move timemodule.c to _timemodule.c and convert as
much as possible into pure Python. The same change seems good for datetime.c as
well
Brian Curtin added the comment:
Correct, your wording is better than mine.
I'll ask around and see where that datetime module may be and what it's state
is.
--
___
Python tracker
<http://bugs.python.
Brian Curtin added the comment:
Whoops, sorry. Here is the change as requested. It reverts to the old way when
needed, which hardcodes the version to VER_NT_WORKSTATION as it effectively
used to.
Outside of a hackish and incredibly slow method, I have no idea how to figure
out workstation
Brian Curtin added the comment:
I'm not able to reproduce this any of the python.org installers, or the current
trunk. I am running 64-bit Windows 7, though, whereas you are running 32-bit. I
don't imagine there should be a difference, but I'll try to obtain a 32-bit box
a
Brian Curtin added the comment:
I did both of those things and I'm still not able to reproduce it. Do you have
any specific language settings enabled?
One thing I meant to ask in my last message was if you had a copy of what you
tried to paste into the window. I've pasted a 500
Brian Curtin added the comment:
This patch should cover everything, and it works with 2.6 as well. In order to
figure out workstation vs. server, it uses the ProductName from the registry
when it can't the info from getwindowsversion. If it finds a server name, it's
a server,
Brian Curtin added the comment:
That solution will work if you have 1 file or 1000 files. The note on the
documentation is very clear on what has to happen.
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue7
Brian Curtin added the comment:
Good point. How about version 5? It uses base Exception in the context manager,
which will allow us to differentiate between no exception being raised, and the
wrong one being raised. After the context manager, we check the type of the
exception to make sure
Brian Curtin added the comment:
That seems reasonable. We already have subprocess.call, the thin wrapper around
Popen. Maybe add this as subprocess.call_shell and call_exec?
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.
Brian Curtin added the comment:
Even if we changed the ACL of the executable, any user could still add
malicious code to be executed on import, as the C:\PythonXY directory doesn't
require specific privileges for writing to it, and it shouldn't by default.
When installed to "C
Brian Curtin added the comment:
I've uploaded the patch to http://codereview.appspot.com/223088
--
___
Python tracker
<http://bugs.python.org/issue7347>
___
___
Changes by Brian Curtin :
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue1284316>
___
___
Python-bugs-list mailing list
Unsubscribe:
701 - 800 of 1992 matches
Mail list logo