Brian Curtin added the comment:
Updated patch - c&p mistake in a comment
--
Added file: http://bugs.python.org/file15360/winreg_add_createkeyex.patch
___
Python tracker
<http://bugs.python.org/is
Brian Curtin added the comment:
After looking at this more, I poked around and found a whole lot of
things either missing or broken with _winreg.
Changes:
- documentation missing for *ReflectionKey, and updated a few
incorrectly documented exceptions in the docstrings
- QueryReflectionKey
Brian Curtin added the comment:
Here is a patch against r76432 which implements a "which" generator
function in shutil that yields full file paths where the searched file
exists on the PATH. Includes doc change and a test. It is pretty similar
to what edemaine had suggested.
This cou
Changes by Brian Curtin :
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue1222585>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brian Curtin added the comment:
#1286 looks related
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue7426>
___
___
Python-bugs-list mailin
Changes by Brian Curtin :
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue7471>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brian Curtin added the comment:
Removing versions that this wouldn't apply to if it were accepted.
--
versions: +Python 3.2 -Python 2.6, Python 3.0, Python 3.1
___
Python tracker
<http://bugs.python.org/i
Brian Curtin added the comment:
True, that slipped by me - thanks.
Updated the patch against r76850.
--
Added file: http://bugs.python.org/file15566/winsound_test_skipping_v2.diff
___
Python tracker
<http://bugs.python.org/issue7
Brian Curtin added the comment:
In the test, should you verify that the correct data comes back from
io.BufferedReader? After the r.close() on line 90 of test_gzip.py,
adding something like "self.assertEqual("".join(lines), data1*50)" would
do th
Brian Curtin added the comment:
I think both AF_BLUETOOTH and AF_TIPC should raise ValueError since the
type of the argument is correct but it's not a good value. I piggybacked
on Amaury's patch and changed the exceptions with a patch against r77004.
--
nosy: +brian.curtin
Brian Curtin added the comment:
Has there been any consensus about what to do with this? I know there
was some chatter on python-dev about assertions causing problems with
buildbots (6 months ago?) but I don't think anything came out of it.
The code change is small and looks good. Is it
New submission from Brian Curtin :
Patch to provide docstrings throughout the msvcrt module.
--
assignee: georg.brandl
components: Documentation, Windows
files: msvcrt_docstrings.diff
keywords: patch
messages: 96893
nosy: brian.curtin, georg.brandl
severity: normal
status: open
title
Brian Curtin added the comment:
I fixed up the bodies of the docstrings, removed the weird quotes around
"pushed back" (copy/paste error), and got the heapmin/locking name fixed up.
Thanks for taking a look at this.
--
Added file: http://bugs.python.org/file15684/msvcrt_doc
Brian Curtin added the comment:
I don't think the conditional checks around the timestamps are
necessary. Couldn't you just put the \t directly in the string that gets
yielded? That way the chunk headers always follow the same format.
--
nosy: +br
Brian Curtin added the comment:
Look at time.timezone -
http://docs.python.org/library/time.html#time.timezone
# I'm in US Central time, so it's -6 from UTC
>>> import time
>>> tz = time.timezone
>>> tz
21600
>>>
Brian Curtin added the comment:
Looks cleaner and works for me.
One very minor comment: the spaces inside the parenthesis on the
time.localtime call are inconsistent and don't comply with PEP-8.
--
___
Python tracker
<http://bugs.py
Brian Curtin added the comment:
Shouldn't the patch tool handle that? FWIW, both the "svn diff" and *nix
diff utilities produce headers with the parts split by a tab character.
Would the code in example.py work in your tool to handle both tabs and
spaces?
--
A
New submission from Brian Harring :
Currently, shlex.shlex's internal read_token is a bit of a nasty mess to
follow and pretty poorly performant.
The refactoring I'll be attaching essentially inverts the state machine
approach read_token uses- instead, converting it over to a more
Brian Curtin added the comment:
It looks like this was changed in r70837
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue7588>
___
___
Brian Curtin added the comment:
I agree that splitting with a tab character is good, but I think it
should be split by a tab character in every case.
If the separator is different based on what data is provided, then it
complicates parsing and would have to be explained in documentation that
Brian Curtin added the comment:
I just noticed that this already exists in py3k, added in r57823 (lacks
docs but I'll cover them in the py3k fix for #7579)
--
___
Python tracker
<http://bugs.python.org/i
New submission from Brian Harring :
Everything I've read about __slots__, seen w/ them, etc, they're
effectively just a change in the underlying allocation- yes they can
limit the attributes, but that's about it.
Specifically, for general attribute access/mangling, best I ca
Changes by Brian Harring :
--
type: -> behavior
___
Python tracker
<http://bugs.python.org/issue7604>
___
___
Python-bugs-list mailing list
Unsubscri
Brian Curtin added the comment:
How does this patch look?
For the sake of consistency it changes back to start=curdir. Then, if
the `path` parameter is type bytes and the `start` parameter equals
`curdir`, `start` is set to the bytes version of `curdir`.
--
keywords: +patch
nosy
Brian Harring added the comment:
Any chance of this landing in py2.7? It's really a nasty wrench in the
works for some a mapping object essentially maps onto __slots__ for
memory efficiency...
--
___
Python tracker
<http://bugs.py
Brian Curtin added the comment:
Here is a patch for py3k. It uses the same contents as before but with
changes to the str/bytes wording on getch_doc, putch_doc, and
ungetch_doc. Includes updates to the msvcrt.rst file. Let me know if the
wording seems correct (or if I left anything out).
I
Changes by Brian Curtin :
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue5115>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brian Curtin added the comment:
warnings_rst_reword.diff proposes slightly different wording on the "Updating
Code..." section of documentation.
--
nosy: +brian.curtin
Added file: http://bugs.python.org/file15743/warnings_rst_reword.diff
Brian Curtin added the comment:
The name should probably be "add" rather than "update", sticking with the name
of the action being done on the underlying set (as update takes an iterable).
Agree/disagree?
I need to add tests and docs to the patch I wrote up - I'll
Brian Curtin added the comment:
After looking into it, I'm thinking this may be better off as a custom option
inherited from optparse.Option. I already wrote the patch since it was small
and a way to poke around optparse some more, so we'll see if anyone else likes
Brian Curtin added the comment:
custom_add.py gives an example of how you could complete this on your own
without a change to optparse. Running "custom_add.py -a foo -a bar -a foo"
should print out "set(['foo', 'bar'])" - ultimately the
Brian Curtin added the comment:
The wording of the documentation flows and is arranged better than before.
However, there is a test failure:
test_exceptions.testDeprecatedMessageAttribute depends on the deprecation
warning always occuring.
@unittest.skipIf(DeprecationWarning in [filter[2
Brian Curtin added the comment:
I think this would be a good addition so I took Adrian's patch and brought it
up to date. I'll need to expand the testing, but I think Benjamin's 1 and 3 are
covered.
--
nosy: +brian.curtin
Added file: http://bugs.python.org/file15769
Changes by Brian Curtin :
--
stage: -> test needed
versions: +Python 2.7, Python 3.2 -Python 3.0
___
Python tracker
<http://bugs.python.org/issue1034>
___
_
Changes by Brian Curtin :
Removed file: http://bugs.python.org/file15743/warnings_rst_reword.diff
___
Python tracker
<http://bugs.python.org/issue7319>
___
___
Python-bug
Changes by Brian Curtin :
--
type: -> feature request
___
Python tracker
<http://bugs.python.org/issue1034>
___
___
Python-bugs-list mailing list
Unsubscri
Brian Curtin added the comment:
>Antoine> (2to3 should be able to do the module rename -- Benjamin, does it?).
2to3 will rename cPickle to pickle.
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/
Brian Curtin added the comment:
I think it's overkill, especially given the easy alternatives.
--
___
Python tracker
<http://bugs.python.org/issue7636>
___
___
Changes by Brian Curtin :
--
priority: -> normal
stage: -> needs patch
type: -> behavior
versions: +Python 2.6, Python 2.7, Python 3.2
___
Python tracker
<http://bugs.python.o
Changes by Brian Curtin :
--
priority: -> normal
stage: -> needs patch
versions: +Python 3.1, Python 3.2 -Python 3.0
___
Python tracker
<http://bugs.python.org/
Changes by Brian Curtin :
Removed file: http://bugs.python.org/file15313/issue2777.patch
___
Python tracker
<http://bugs.python.org/issue2777>
___
___
Python-bugs-list m
Brian Curtin added the comment:
Minor patch change
--
keywords: +needs review
stage: -> patch review
versions: +Python 2.7, Python 3.1, Python 3.2 -Python 3.0
Added file: http://bugs.python.org/file15777/issue2777.patch
___
Python tracker
&l
Brian Curtin added the comment:
It seems a bit wordy. I propose an alternate wording in the attached patch.
--
keywords: +needs review, patch
nosy: +brian.curtin
priority: -> low
stage: -> patch review
versions: +Python 2.7, Python 3.1, Python 3.2
Added file: http://bugs.pyth
Brian Curtin added the comment:
>mark> (1) Could we unify test_decimal and test_cdecimal somehow?
>mark> This would avoid them getting out of sync when new tests are
>mark> added, and would make it clear what the differences between
>mark> them are. It looks like th
Brian Curtin added the comment:
It seems like this may have been the result of registry redirection. Jason
didn't say if the 2.5.1 install he went back to was 64-bit or not, but that
could have been the difference. Given how old this is, I doubt he remembers :)
wxPython has 32 and 6
Brian Curtin added the comment:
Can you confirm that this is still an issue on a version >= 2.6?
--
nosy: +brian.curtin
versions: +Python 2.6 -Python 2.5
___
Python tracker
<http://bugs.python.org/iss
Changes by Brian Curtin :
--
stage: -> needs patch
___
Python tracker
<http://bugs.python.org/issue7657>
___
___
Python-bugs-list mailing list
Unsubscri
Brian Curtin added the comment:
The 3.x documentation[1] has this:
"object does not have a __dict__, so you can’t assign arbitrary attributes to
an instance of the object class."
- 2.x doesn't have that same blurb -- it looks like it should.
AttributeError vs. TypeError seems
Brian Curtin added the comment:
Using time.daylight is incorrect. time.daylight specifies the number of hours
that the daylight offset is, not a flag to specify whether or not daylight
savings time is in effect.
Steven's suggestion of using time.localtime().tm_isdst seems to be the b
Brian Curtin added the comment:
I think this would be nice, but see msg97471 from your diff.py ISO timestamp
issue. time.daylight should probably be time.localtime().tm_isdst.
--
nosy: +brian.curtin
type: -> feature request
versions: -Python
Brian Curtin added the comment:
The documentation could use some work. It means that if the timezone does use a
daylight savings time period, time.daylight specifies the amount of the offset.
In my timezone this value is 1. However, time.localtime().is_dst is currently
0, because we are not
Brian Curtin added the comment:
http://msdn.microsoft.com/en-us/library/2t504ch6%28VS.80%29.aspx has some info
for how this is implemented on Windows, and I get the same results on my Mac.
On Linux an AttributeError is raised time.struct_time not having an attribute
is_dst, and
Brian Curtin added the comment:
Whoops, nevermind the Linux comment on that last one. My typo there caused the
exception. The result there is the same as the other platforms.
--
___
Python tracker
<http://bugs.python.org/issue7
Brian Curtin added the comment:
Christopher, are you willing to update your patch for the current trunk (2.7)?
--
nosy: +brian.curtin
stage: -> needs patch
versions: +Python 2.7 -Python 2.4
___
Python tracker
<http://bugs.python.org/iss
Brian Curtin added the comment:
Here is blunck2's patch updated against r77393. Once I have a better
understanding of the issue I'll see if I can write tests (eg. I don't know the
significance of 8002 on line 675, etc).
--
stage: needs patch
Changes by Brian Curtin :
--
keywords: +patch
Added file: http://bugs.python.org/file15824/issue2449.diff
___
Python tracker
<http://bugs.python.org/issue2
Brian Curtin added the comment:
Do you have a test case to reproduce the errors?
I see that we call msync followed by munmap, neither one checked.
--
nosy: +brian.curtin
stage: -> test needed
___
Python tracker
<http://bugs.python.org/iss
Brian Curtin added the comment:
This patch should address all but #2. I'm not exactly sure of the use-case
blunck2 had in mind so I'm not sure how the message would be used.
--
Added file: http://bugs.python.org/file15825/issue24
Changes by Brian Curtin :
Removed file: http://bugs.python.org/file15824/issue2449.diff
___
Python tracker
<http://bugs.python.org/issue2449>
___
___
Python-bugs-list m
Changes by Brian Curtin :
--
priority: -> normal
___
Python tracker
<http://bugs.python.org/issue2644>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Brian Curtin :
--
priority: -> normal
stage: -> needs patch
versions: +Python 2.6, Python 2.7, Python 3.1, Python 3.2
___
Python tracker
<http://bugs.python.org/
Changes by Brian Curtin :
--
nosy: +brian.curtin
___
Python tracker
<http://bugs.python.org/issue1023290>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Brian Curtin :
--
priority: -> low
stage: -> needs patch
versions: +Python 2.7, Python 3.1, Python 3.2 -Python 3.0
___
Python tracker
<http://bugs.python.org/
Brian Curtin added the comment:
See #2796
--
keywords: +needs review
nosy: +brian.curtin
priority: -> normal
resolution: -> duplicate
stage: -> patch review
status: open -> closed
superseder: -> Build issues in DragonFly BSD
versions: +Python 2.7, Python
Changes by Brian Curtin :
Added file: http://bugs.python.org/file15832/dragonfly-python-trunk.patch
___
Python tracker
<http://bugs.python.org/issue2796>
___
___
Pytho
Brian Curtin added the comment:
In your example, the "n_frames" name does not exist, which is causing the
problem. In your first comment, "framerate" also did not exist.
I don't know what a proper frame rate value is, but I just put 10 in there and
it wor
Changes by Brian Curtin :
--
priority: -> normal
stage: -> needs patch
type: -> behavior
___
Python tracker
<http://bugs.python.org/issue2554>
___
Brian Curtin added the comment:
Added the FlushViewOfFile calls, and an msync call to the close method. Not
sure how to explicitly test this, if it's possible. Current tests pass on
Windows, I'll need to check *NIX when I have the access later today.
As for justification
Changes by Brian Curtin :
Removed file: http://bugs.python.org/file15838/issue2643.diff
___
Python tracker
<http://bugs.python.org/issue2643>
___
___
Python-bugs-list m
Brian Curtin added the comment:
tab/space issue, updated the patch
--
Added file: http://bugs.python.org/file15839/issue2643.diff
___
Python tracker
<http://bugs.python.org/issue2
Brian Curtin added the comment:
There is no crash, but I see what you are saying now.
Patch to correct the two divisions and a test similar to your example.
--
keywords: +needs review, patch
stage: needs patch -> patch review
title: Incorrect division in [wave.py] causing cr
Changes by Brian Curtin :
--
priority: -> normal
stage: -> needs patch
___
Python tracker
<http://bugs.python.org/issue7686>
___
___
Python-bugs-list
Brian Curtin added the comment:
This won't solve the problem of dual installations, but it'll leave things how
you were expecting... There is an option in the installer on the customize page
for "Register Extensions". Choosing to not install that item will keep the
inst
Changes by Brian Curtin :
--
stage: -> needs patch
versions: +Python 3.2 -Python 3.0
___
Python tracker
<http://bugs.python.org/issue2375>
___
___
Python-
Brian Curtin added the comment:
You could use assertIsInstance(s, unicode, '%r is not unicode' % s) in the
tests instead of your assertTrue.
I think the rest of it looks good. Works for me.
--
nosy: +brian.curtin
___
Python trac
Changes by Brian Curtin :
--
priority: -> normal
stage: needs patch -> patch review
___
Python tracker
<http://bugs.python.org/issue4870>
___
___
Pyth
Changes by Brian Curtin :
--
priority: -> normal
stage: -> needs patch
versions: +Python 2.7 -Python 2.5
___
Python tracker
<http://bugs.python.org/
Changes by Brian Curtin :
--
stage: test needed -> patch review
___
Python tracker
<http://bugs.python.org/issue444582>
___
___
Python-bugs-list mailing list
Un
Changes by Brian Curtin :
--
priority: -> normal
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue5115>
___
___
Python-bugs-list
Changes by Brian Curtin :
--
priority: -> normal
stage: -> patch review
type: -> behavior
___
Python tracker
<http://bugs.python.org/issue7579>
___
Changes by Brian Curtin :
--
priority: -> normal
type: -> behavior
versions: +Python 2.7, Python 3.1, Python 3.2 -Python 3.0
___
Python tracker
<http://bugs.python.org/
Changes by Brian Curtin :
--
keywords: +needs review
priority: -> normal
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue7306>
___
__
Changes by Brian Curtin :
--
priority: -> normal
stage: -> test needed
___
Python tracker
<http://bugs.python.org/issue7347>
___
___
Python-bugs-list
Changes by Brian Curtin :
--
keywords: +needs review
priority: -> normal
stage: -> patch review
versions: -Python 2.5
___
Python tracker
<http://bugs.python.org/
Changes by Brian Curtin :
--
keywords: +needs review
priority: -> normal
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue7301>
___
__
Changes by Brian Curtin :
--
priority: -> normal
stage: -> patch review
type: -> behavior
___
Python tracker
<http://bugs.python.org/issue5774>
___
Changes by Brian Curtin :
Removed file: http://bugs.python.org/file15262/issue5774_20091104_v1.patch
___
Python tracker
<http://bugs.python.org/issue5774>
___
___
Pytho
Changes by Brian Curtin :
--
keywords: +needs review
Added file: http://bugs.python.org/file15850/issue5774.patch
___
Python tracker
<http://bugs.python.org/issue5
Changes by Brian Curtin :
--
keywords: +26backport -needs review, patch, patch
stage: -> needs patch
versions: -Python 3.0, Python 3.1
___
Python tracker
<http://bugs.python.org/iss
Changes by Brian Curtin :
--
stage: -> needs patch
___
Python tracker
<http://bugs.python.org/issue7588>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Brian Curtin :
--
keywords: +needs review
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue1222585>
___
___
Python-bugs-lis
Brian Curtin added the comment:
Here tadek's patch updated for trunk, with a test added to it.
I feel like this should be documented somewhere, but Doc/Library/gzip.rst
doesn't feel right. Maybe it just needs a mention in the "What's new" or
something?
--
a
Changes by Brian Curtin :
Removed file: http://bugs.python.org/file15851/issue2846.diff
___
Python tracker
<http://bugs.python.org/issue2846>
___
___
Python-bugs-list m
Brian Curtin added the comment:
Updated patch with some documentation
--
Added file: http://bugs.python.org/file15852/issue2846.diff
___
Python tracker
<http://bugs.python.org/issue2
Brian Curtin added the comment:
This is already fixed in trunk and the various 3.x branches.
--
nosy: +brian.curtin
priority: -> normal
resolution: -> invalid
stage: -> committed/rejected
status: open -> closed
___
Python tr
Changes by Brian Curtin :
Removed file: http://bugs.python.org/file15852/issue2846.diff
___
Python tracker
<http://bugs.python.org/issue2846>
___
___
Python-bugs-list m
Brian Curtin added the comment:
Thanks for taking a look! Patch updated with that try/except removed.
--
Added file: http://bugs.python.org/file15856/issue2846.diff
___
Python tracker
<http://bugs.python.org/issue2
Changes by Brian Curtin :
--
priority: -> normal
stage: -> needs patch
___
Python tracker
<http://bugs.python.org/issue7662>
___
___
Python-bugs-list
Changes by Brian Curtin :
--
priority: -> normal
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue2796>
___
___
Python-bugs-list
Brian Curtin added the comment:
If this stuff needs to be removed it should probably go through the deprecation
process.
--
keywords: +needs review
nosy: +brian.curtin
priority: -> low
stage: -> patch review
type: -> behavior
versions: +Python 3.2 -P
1601 - 1700 of 1998 matches
Mail list logo