[issue15131] Document py/pyw launchers

2012-06-21 Thread Brian Curtin
Changes by Brian Curtin : -- assignee: docs@python -> brian.curtin ___ Python tracker <http://bugs.python.org/issue15131> ___ ___ Python-bugs-list mai

[issue444582] Finding programs in PATH, adding shutil.which

2012-06-21 Thread Brian Curtin
Brian Curtin added the comment: Here's a patch that also works on linux. A pathext specific test is now skipped since that only matters on Windows, and I forgot a chmod that was making two tests fail on linux. -- Added file: http://bugs.python.org/file26078/issue444582_v3

[issue444582] Finding programs in PATH, adding shutil.which

2012-06-22 Thread Brian Curtin
Brian Curtin added the comment: Attached is a patch which fixes your review comments in Lib/shutil.py, and it makes an adjustment in the wording of the documentation. The documentation is a bit more strong in wording that the current directory is always prepended to the path whether its a

[issue444582] Finding programs in PATH, adding shutil.which

2012-06-22 Thread Brian Curtin
Brian Curtin added the comment: I don't know. It makes sense to me. I'll try to find someone else to look at it and adjust it. -- ___ Python tracker <http://bugs.python.or

[issue444582] Finding programs in PATH, adding shutil.which

2012-06-22 Thread Brian Curtin
Brian Curtin added the comment: > I don't really understand why you call abspath(). If the caller wants an > absolute path, they can call abspath() themselves. Because that is what `which` does. I just pushed the change before I saw this message, so it went in as the patch sh

[issue15148] shutil.which() docstring could be clearer

2012-06-22 Thread Brian Curtin
Brian Curtin added the comment: I updated file to command in 973b4806f760. It needs to be command so it matches the implementation's argument name, and because it doesn't exactly take a file. Alexander, can you explain the part about finding a file on PYTHONPATH? I don't

[issue15150] Windows build does not link

2012-06-22 Thread Brian Curtin
New submission from Brian Curtin : 6>python3.def : error LNK2001: unresolved external symbol PyState_AddModule 6>python3.def : error LNK2001: unresolved external symbol PyState_RemoveModule 6>C:\python-dev\cpython\PCbuild\python3.lib : fatal error LNK1120: 2 unresolved

[issue15148] shutil.which() docstring could be clearer

2012-06-22 Thread Brian Curtin
Brian Curtin added the comment: No, reverting. -- ___ Python tracker <http://bugs.python.org/issue15148> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

2012-06-22 Thread Brian Curtin
Brian Curtin added the comment: So I have a patch that does most of what my previous message shows, but I can't seem to complete it. I don't know if I'm misunderstanding something or this just can't be done, but I could use the help of someone who understands MSI thing

[issue14578] importlib doesn't check Windows registry for paths

2012-06-24 Thread Brian Curtin
Brian Curtin added the comment: I will take a look at it shortly...was too busy with installer/path issues and then PEP 397 last week. -- ___ Python tracker <http://bugs.python.org/issue14

[issue15011] Change Scripts to bin on Windows

2012-06-26 Thread Brian Curtin
Changes by Brian Curtin : -- versions: +Python 3.4 -Python 3.3 ___ Python tracker <http://bugs.python.org/issue15011> ___ ___ Python-bugs-list mailing list Unsub

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

2012-07-03 Thread Brian Curtin
Brian Curtin added the comment: > == Suggestion 1 == I don't think it's that unexpected. I certainly didn't come up with the idea myself - I've seen them before. Surely it might be new to some people, but is it confusing? For one, we think it's an option users s

[issue3561] Windows installer should add Python and Scripts directories to the PATH environment variable

2012-07-04 Thread Brian Curtin
Brian Curtin added the comment: We don't need to stay with some paradigm if it's not the best way. If I can get any of these ways to work, I may post some type of survey on python-dev. Adding to the end wouldn't make this much of a feature. Most users have already put anot

[issue11908] Weird `slice.stop or sys.maxint`

2012-07-07 Thread Brian Brazil
Brian Brazil added the comment: The attached patch fixes this -- keywords: +patch nosy: +bbrazil Added file: http://bugs.python.org/file26283/issue11908-islice-docs.patch ___ Python tracker <http://bugs.python.org/issue11

[issue15130] remove redundant paragraph in socket howto

2012-07-07 Thread Brian Brazil
Brian Brazil added the comment: Issue confirmed, patch looks good. -- nosy: +bbrazil ___ Python tracker <http://bugs.python.org/issue15130> ___ ___ Python-bug

[issue15094] Incorrectly placed #endif in _tkinter.c.

2012-07-07 Thread Brian Brazil
Brian Brazil added the comment: Issue confirmed, patch looks good. -- nosy: +bbrazil ___ Python tracker <http://bugs.python.org/issue15094> ___ ___ Python-bug

[issue15002] urllib2 does not download 4 MB file completely using ftp

2012-07-07 Thread Brian Brazil
Brian Brazil added the comment: I've tested this on head, and the issue appears to be buggy ftp code in python. >From the attached tcpdump for fetching delegated-ripencc-20120706: 12:57:19.933607 IP myhost.39627 > ftp.ripe.net.ftp: Flags [.], ack 511, win 115, options [nop

[issue15002] urllib2 does not download 4 MB file completely using ftp

2012-07-07 Thread Brian Brazil
Brian Brazil added the comment: More particularly, the ftpwrapper's ftp member is being GCed sometime after FtpHandler.ftp_open returns. -- ___ Python tracker <http://bugs.python.org/is

[issue10248] Fix resource warnings in test_xmlrpclib

2012-07-07 Thread Brian Brazil
Brian Brazil added the comment: Looks like someone else has already fixed this. -- resolution: -> out of date status: open -> closed ___ Python tracker <http://bugs.python.org/i

[issue15277] Fix resource leak in support.py:_is_ipv6_enabled

2012-07-07 Thread Brian Brazil
New submission from Brian Brazil : I'm running Ubuntu Precise and have net.ipv6.conf.all.disable_ipv6 = 1 in my sysctl.conf. With this configuration at head there's a fd leak in _is_ipv6_enabled in support.py when the bind fails, which the attached patch should fix. --

[issue15280] Don't use builtins as variable names in urllib.request

2012-07-07 Thread Brian Brazil
New submission from Brian Brazil : See attached patch, there's still self.type in places. I also converted one map to a list comprehension. -- components: Library (Lib) files: urllib-request-cleanup-builtin-names.patch keywords: patch messages: 164874 nosy: bbrazil priority: n

[issue15284] Handle ipv6 not being enabled in test_socket

2012-07-07 Thread Brian Brazil
New submission from Brian Brazil : If ipv6 is compiled in but disabled in the kernel then test_socket attempts to bind to ports and gets lots of stack traces. The attached patch skips the relevant tests. -- components: Tests files: ipv6-disabled-test-socket.patch keywords: patch

[issue15228] os.utime() docs not clear on behavior on nonexistant files

2012-07-07 Thread Brian Brazil
Brian Brazil added the comment: Here's a patch that should clarify this. -- keywords: +patch nosy: +bbrazil Added file: http://bugs.python.org/file26306/issue15228-utime-touch-doc.patch ___ Python tracker <http://bugs.python.org/is

[issue15286] normpath does not work with local literal paths

2012-07-07 Thread Brian Curtin
Brian Curtin added the comment: Hi mandel :) With the exception of the "import string" inside of _get_letters (policy is to do all imports at the top), it looks ok just by reading. Assigning to myself to complete it after I return from holiday in a few days (unless someon

[issue15285] test_timeout failure when system on IPv4 10.x.x.x subnet

2012-07-08 Thread Brian Brazil
Brian Brazil added the comment: I don't think anything in 127/8 is going to work, all Debian/Ubuntu systems I'm aware of have all of 127/8 equivalent to 127.0.0.1. Maybe 192.0.2.0/24 per RFC 5737? A better solution might be to chose some host/port on a python.org server and set

[issue15284] Handle ipv6 not being enabled in test_socket

2012-07-08 Thread Brian Brazil
Changes by Brian Brazil : -- resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/issue15284> ___ ___ Python-bugs-list

[issue15323] Provide target name in output message when Mock.assert_called_once_with fails

2012-07-10 Thread Brian Jones
New submission from Brian Jones : In Python 3.3.0b1, if the number of calls to a mock is, say, zero, and you call assert_called_once_with() on that mock, it will throw an exception which says "Expected to be called once. Called 0 times." This is nice, but it would be nicer if

[issue14600] Change ImportError reference handling, naming

2012-07-13 Thread Brian Curtin
Changes by Brian Curtin : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python.or

[issue15280] Don't use builtins as variable names in urllib.request

2012-07-14 Thread Brian Brazil
Brian Brazil added the comment: This patch is a result of frustration encountered when debugging #15002. Not being able to use 'type' directly is rather annoying, so after figuring that bug out I set some time aside to make it easier for the next person. This could be considered

[issue15359] Sockets support for CAN_BCM

2012-07-15 Thread Brian Thorne
New submission from Brian Thorne : In addition to CAN_RAW introduced in Python 3.3, it would be really useful to expose the CAN_BCM protocol. Effectively it hands off as much to the kernel as possible which gives Python programs the ability to send and receive many periodic messages with

[issue15359] Sockets support for CAN_BCM

2012-07-15 Thread Brian Thorne
Brian Thorne added the comment: Once I've got more complete examples, I can update the patch to include a testcase. -- ___ Python tracker <http://bugs.python.org/is

[issue12428] functools test coverage

2012-07-16 Thread Brian Thorne
Changes by Brian Thorne : -- nosy: +jackdied ___ Python tracker <http://bugs.python.org/issue12428> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue13785] Make concurrent.futures.Future state public

2012-07-18 Thread Brian Quinlan
Brian Quinlan added the comment: My current thinking is that adding a "state" property probably isn't worth it given the fact that you can construct this yourself and the requirement for a "history" property is too specialized. The callback idea seams reasonable an

[issue14578] importlib doesn't check Windows registry for paths

2012-07-21 Thread Brian Curtin
Brian Curtin added the comment: Sorry, I've been too busy to get caught up with this. I'm away most of today but I can try to take a look tonight. -- ___ Python tracker <http://bugs.python.o

[issue14578] importlib doesn't check Windows registry for paths

2012-07-21 Thread Brian Curtin
Brian Curtin added the comment: Can someone tell me where you want this changed? I guess Lib/imp.py in the find_module function, based on previous mention of imp.find_module? That's shown as deprecated so I'm hesitant to start there. I don't really know anything about import

[issue14578] importlib doesn't check Windows registry for paths

2012-07-22 Thread Brian Curtin
Brian Curtin added the comment: I'm not sure what the deal is but I can't get the changes to apply (fitting Amaury's patch into _boostrap.py), meaning nothing I change to the _boostrap.py file changes how anything operates. I don't have much time to learn all of this st

[issue12428] functools test coverage

2012-07-23 Thread Brian Thorne
Brian Thorne added the comment: Thanks Antoine, the __class__ attribute wasn't useful, I've removed that. Overriding the __setattr__ and __delattr__ gives consistent behaviour with the both versions - allowing the unittest reuse. Also I've changed thread back to _thre

[issue15285] test_timeout failure when system on IPv4 10.x.x.x subnet

2012-07-24 Thread Brian Brazil
Brian Brazil added the comment: There's already existing infrastructure not to run certain tests when there's no internet connection, no ipv6, no tk etc. -- ___ Python tracker <http://bugs.python.o

[issue14578] importlib doesn't check Windows registry for paths

2012-07-27 Thread Brian Curtin
Brian Curtin added the comment: > I would really like to release beta2 this weekend. Is it possible to get > this resolved by then? As others stated, I'm not sure it's entirely necessary. Given the two dependencies that need to be fixed before this one can move forward, I d

[issue15496] harden directory removal for tests on Windows

2012-08-04 Thread Brian Curtin
Brian Curtin added the comment: > Without some change, the Win64 buildbot is relatively irrelevant as it is nearly always in a state of failure due to these errors. Not that some change isn't necessary, but what else are you running on your build slave? I ran a Windows 2008 R2 x64 s

[issue12428] functools test coverage

2012-08-05 Thread Brian Thorne
Brian Thorne added the comment: Back to a simpler closure implementation of partial and skip the repr test for python implementation. -- Added file: http://bugs.python.org/file26697/functools.patch ___ Python tracker <http://bugs.python.

[issue4508] distutils compiler not handling spaces in path to output/src files

2012-08-05 Thread Brian Thorne
Brian Thorne added the comment: I've put together a patch adding the test requested. There is no problem on my Ubuntu machine with python 3.3. There is a comment in the file saying Don't load the xx module more than once, I am unsure whether my patch (using a renamed c file) vio

[issue15567] threading.py contains undefined name in self-test code

2012-08-09 Thread Brian Curtin
Changes by Brian Curtin : -- assignee: -> brian.curtin nosy: +brian.curtin resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python

[issue15496] harden directory removal for tests on Windows

2012-08-13 Thread Brian Curtin
Brian Curtin added the comment: The latest patch to test.support looks reasonable. Go for it. -- ___ Python tracker <http://bugs.python.org/issue15496> ___ ___

[issue15496] harden directory removal for tests on Windows

2012-08-13 Thread Brian Curtin
Changes by Brian Curtin : -- assignee: -> brian.curtin components: +Windows resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python

[issue15131] Document py/pyw launchers

2012-08-19 Thread Brian Curtin
Brian Curtin added the comment: This was added by Vinay in 4a3439ef552c. -- resolution: -> invalid stage: needs patch -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python.or

[issue15769] urllib.request.urlopen with cafile or capath set overrides any previous Handlers

2012-08-22 Thread Brian Turek
New submission from Brian Turek: Using the code snippet below: cj = http.cookiejar.CookieJar() opener = urllib.request.build_opener(urllib.request.HTTPCookieProcessor()) urllib.request.install_opener(opener) request = urllib.request.Request(url, data, headers) # url is https://something sock

[issue15769] urllib.request.urlopen with cafile or capath set overrides any previous Handlers

2012-08-23 Thread Brian Turek
Brian Turek added the comment: I was actually going to come up with a patch that does the same thing orsenthil mentioned until I too was stymied by the use of bisect.insort Does anyone know why bisect.insort was used instead of just list.append? I don't see an obvious reason so I think

[issue15772] Unresolved symbols in Windows 64-bit python

2012-08-23 Thread Brian Curtin
Changes by Brian Curtin : -- components: +Build nosy: +brian.curtin, loewis ___ Python tracker <http://bugs.python.org/issue15772> ___ ___ Python-bugs-list mailin

[issue15769] urllib.request.urlopen with cafile or capath set overrides any previous Handlers

2012-08-23 Thread Brian Turek
Brian Turek added the comment: So I'm not saying the attached patch is the *best* solution but it doesn't mangle the existing urllib.request._opener too much. -- keywords: +patch Added file: http://bugs.python.org/file26977/request.patch

[issue15779] socket error [Errno 10013] when creating SMTP object

2012-08-24 Thread Brian Curtin
Changes by Brian Curtin : -- nosy: -brian.curtin ___ Python tracker <http://bugs.python.org/issue15779> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue1005895] curses for win32

2012-09-11 Thread Brian Curtin
Changes by Brian Curtin : -- nosy: -brian.curtin ___ Python tracker <http://bugs.python.org/issue1005895> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue15946] Windows 8 x64 - IO-Error

2012-09-15 Thread Brian Curtin
Brian Curtin added the comment: I'm not sure Microsoft is going to change anything about this - it has done this for a long time, if not forever. We recently had #15496 receive changes, and #7443 is in the same area and has more details and some patches, so I'd suggest tak

[issue15966] concurrent.futures: Executor.submit keyword arguments may not be called 'fn' (or 'self')

2012-09-18 Thread Brian Curtin
Changes by Brian Curtin : -- assignee: -> bquinlan nosy: +bquinlan ___ Python tracker <http://bugs.python.org/issue15966> ___ ___ Python-bugs-list mai

[issue16081] Fix compile warnings in thread_pthread.h

2012-09-28 Thread Brian Brazil
New submission from Brian Brazil: Please see attached patch to fix warnings about error being set but not used, I've eliminated error except for the one function that was using it. -- components: Interpreter Core files: pthread-warnings.patch keywords: patch messages: 171432

[issue15350] {urllib,urllib.parse}.urlencode.__doc__ is unclear

2012-09-28 Thread Brian Brazil
Brian Brazil added the comment: How does the attached patch look? I also reworded the first line to be a bit clearer, and be under 80 chars. -- keywords: +patch nosy: +bbrazil Added file: http://bugs.python.org/file27329/issue15350.patch ___ Python

[issue15677] Gzip/zlib allows for compression level=0

2012-09-28 Thread Brian Brazil
Brian Brazil added the comment: The attached patch fixes this. -- keywords: +patch nosy: +bbrazil Added file: http://bugs.python.org/file27330/issue15677.patch ___ Python tracker <http://bugs.python.org/issue15

[issue16081] Fix compile warnings in thread_pthread.h

2012-09-30 Thread Brian Brazil
Brian Brazil added the comment: I'm on gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3, this was the only warning I saw (though I don't have all the optional libraries installed). -- ___ Python tracker <http://bugs.python.o

[issue9650] format codes in time.strptime docstrings

2012-10-02 Thread Brian Curtin
Changes by Brian Curtin : -- nosy: -brian.curtin ___ Python tracker <http://bugs.python.org/issue9650> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue14668] Document the path option in the Windows installer

2012-10-06 Thread Brian Curtin
Changes by Brian Curtin : -- resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python.or

[issue16176] platform.platform() identifies Windows 8 as post2008Server

2012-10-09 Thread Brian Curtin
New submission from Brian Curtin: >>> platform.platform() 'Windows-post2008Server-6.2.9200' The change is trivial, just accounting for a point release of 2 (from the major release 6). --- a/Lib/platform.py +++ b/Lib/platform.py @@ -595,8 +595,13 @@

[issue16175] Add I/O Completion Ports wrapper

2012-10-09 Thread Brian Curtin
Changes by Brian Curtin : -- nosy: +brian.curtin ___ Python tracker <http://bugs.python.org/issue16175> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue16177] IDLE Crash on Open Parens

2012-10-09 Thread Brian Keegan
Brian Keegan added the comment: I moved the idlerc to the disabled folder like you recommended and I haven't been able to reproduce the error again. I'll cautiously take this as an indication of a fix, but will update if it changes. Thank you! On Tue, Oct 9, 2012 at 2:40 PM, Ned De

[issue16192] ctypes - documentation example

2012-10-10 Thread Brian Thorne
New submission from Brian Thorne: The Python docs for ctypes have embedded examples including: >>> c_int() c_long(0) But on my machine I get the (more expected?): >>> c_int() c_int(0) Perhaps if some machines expect otherwise that should be documented, otherwise mi

[issue16192] ctypes - documentation example

2012-10-11 Thread Brian Thorne
Brian Thorne added the comment: > The very beginning of the ctypes documentation has documentation to that > effect >Does that address your suggestion? Thanks Chris, that explains why the difference is present on non 32 bit platforms. Would using c_long for the examples produce the

[issue16197] Several small errors in winreg documentation

2012-10-11 Thread Brian Curtin
Brian Curtin added the comment: The patch looks alright, but I would remove the lining up of definitions. It's probably easiest to do a patch against 3.2 and I can handle the porting on commit. -- assignee: docs@python -> brian.curtin components: +Windows type: -&g

[issue16176] platform.platform() identifies Windows 8 as post2008Server

2012-10-11 Thread Brian Curtin
Changes by Brian Curtin : -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python.or

[issue16197] Several small errors in winreg documentation

2012-10-15 Thread Brian Curtin
Brian Curtin added the comment: Docs should match code. If we did it the other way around we'd probably break something. Thanks for looking into this. I've been busy the last few days but I will get to the review and application of the patch

[issue16284] concurrent.futures ThreadPoolExecutor keeps unnecessary references to worker functions.

2012-10-21 Thread Brian Quinlan
Brian Quinlan added the comment: The concurrent.futures stuff looks good to me. Could you add a comment explaining why the delete is necessary? And, as Antoine said, the test should be CPython only. -- ___ Python tracker <http://bugs.python.

[issue15966] concurrent.futures: Executor.submit keyword arguments may not be called 'fn' (or 'self')

2012-10-21 Thread Brian Quinlan
Brian Quinlan added the comment: This has come up before. Did you actually bang into this? Because the fix seems pretty ugly to me and the work-around (using functools.partial) is pretty easy. But, if people are actually hitting this, then your is probably the best that we can do

[issue13785] Make concurrent.futures.Future state public

2012-10-21 Thread Brian Quinlan
Changes by Brian Quinlan : -- stage: -> needs patch ___ Python tracker <http://bugs.python.org/issue13785> ___ ___ Python-bugs-list mailing list Unsubscri

[issue8792] Support Apache extensions to XML-RPC in xmlrpclib

2012-10-21 Thread Brian Quinlan
Brian Quinlan added the comment: I'm closing this since the filer hasn't specified exactly what they want. -- status: open -> closed ___ Python tracker <http://bugs.pyth

[issue11271] concurrent.futures.ProcessPoolExecutor.map() doesn't batch function arguments by chunks

2012-10-21 Thread Brian Quinlan
Changes by Brian Quinlan : -- status: open -> closed ___ Python tracker <http://bugs.python.org/issue11271> ___ ___ Python-bugs-list mailing list Unsubscri

[issue16197] Several small errors in winreg documentation

2012-10-29 Thread Brian Curtin
Brian Curtin added the comment: Pushed fixes for 3.2+ Thanks for the patch! -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python.or

[issue900092] hotshot.stats.load fails with AssertionError

2014-03-19 Thread Brian Curtin
Brian Curtin added the comment: It was brought to my attention that this is still an issue and that it was closed. Reopening. -- resolution: wont fix -> status: closed -> open ___ Python tracker <http://bugs.python.org/is

[issue900092] hotshot.stats.load fails with AssertionError

2014-03-19 Thread Brian Curtin
Brian Curtin added the comment: It remains a valid issue. Time is not a factor. -- ___ Python tracker <http://bugs.python.org/issue900092> ___ ___ Python-bug

[issue21346] typos in test_itertools.py

2014-04-24 Thread Brian Kearns
Changes by Brian Kearns : -- files: test_itertools_typos-py27.patch keywords: patch nosy: bdkearns priority: normal severity: normal status: open title: typos in test_itertools.py type: enhancement versions: Python 2.7 Added file: http://bugs.python.org/file35025/test_itertools_typos

[issue21349] crash in winreg SetValueEx with memoryview

2014-04-24 Thread Brian Kearns
Changes by Brian Kearns : Removed file: http://bugs.python.org/file35030/fix_winreg_setvalueex-py27.patch ___ Python tracker <http://bugs.python.org/issue21349> ___ ___

[issue21349] crash in winreg SetValueEx with memoryview

2014-04-24 Thread Brian Kearns
Changes by Brian Kearns : -- files: fix_winreg_setvalueex-py27.patch keywords: patch nosy: bdkearns priority: normal severity: normal status: open title: crash in winreg SetValueEx with memoryview type: crash versions: Python 2.7 Added file: http://bugs.python.org/file35030

[issue21349] crash in winreg SetValueEx with memoryview

2014-04-24 Thread Brian Kearns
Changes by Brian Kearns : Added file: http://bugs.python.org/file35031/fix_winreg_setvalueex-py27.patch ___ Python tracker <http://bugs.python.org/issue21349> ___ ___

[issue21350] bug in file.writelines accepting buffers

2014-04-25 Thread Brian Kearns
New submission from Brian Kearns: In file.writelines, the conditions in this if statement are bogus. If f->f_binary and AsReadBuffer succeeds (returns 0), AsCharBuf is still tried. So, for example, passing an array('c') to a file('wb').writelines fails, when it seems th

[issue21350] bug in file.writelines accepting buffers

2014-04-25 Thread Brian Kearns
Changes by Brian Kearns : Removed file: http://bugs.python.org/file35036/fix_file_writelines-py27.patch ___ Python tracker <http://bugs.python.org/issue21350> ___ ___

[issue21350] bug in file.writelines accepting buffers

2014-04-25 Thread Brian Kearns
Changes by Brian Kearns : Added file: http://bugs.python.org/file35037/fix_file_writelines-py27.patch ___ Python tracker <http://bugs.python.org/issue21350> ___ ___ Pytho

[issue21349] crash in winreg SetValueEx with memoryview

2014-04-25 Thread Brian Kearns
Brian Kearns added the comment: Oops, updated test. -- Added file: http://bugs.python.org/file35038/fix_winreg_setvalueex-py27.patch ___ Python tracker <http://bugs.python.org/issue21

[issue21349] crash in winreg SetValueEx with memoryview

2014-04-25 Thread Brian Kearns
Changes by Brian Kearns : Removed file: http://bugs.python.org/file35031/fix_winreg_setvalueex-py27.patch ___ Python tracker <http://bugs.python.org/issue21349> ___ ___

[issue21349] crash in winreg SetValueEx with memoryview

2014-04-25 Thread Brian Kearns
Brian Kearns added the comment: Are you aware of the old/new buffer interfaces and their usages? Did you actually try the code? "crash" would be obvious. Objects that support only the new buffer interface define tp_as_buffer with fields representing the old buffer interface as

[issue21362] concurrent.futures does not validate that max_workers is proper

2014-04-29 Thread Brian Quinlan
Brian Quinlan added the comment: The patch looks good to me too. I'll commit it soon. -- assignee: -> bquinlan ___ Python tracker <http://bugs.python.org

[issue21395] runtests.rst: link "build Python" to setup.rst#compiling

2014-04-30 Thread Brian Gesiak
New submission from Brian Gesiak: runtests.rst insists that readers must build Python before running the tests. For those readers that have not yet built Python, add a link to more information on how to do so. -- components: Devguide files: runtests.rst.patch hgrepos: 243 keywords

[issue21397] tempfile.py: Fix grammar in docstring, comment typos

2014-04-30 Thread Brian Gesiak
New submission from Brian Gesiak: Commit 1: tempfile.py: Fix grammar in docstring Meaning of "just below" in docstring is unclear; it could mean either "the interfaces listed immediately below this docstring", or "only the interfaces listed as safe below". Fix

[issue21350] bug in file.writelines accepting buffers

2014-05-07 Thread Brian Kearns
Brian Kearns added the comment: So, for example: >>> f = open('blah', 'wb') >>> f.write(array.array('c', 'test')) >>> f.writelines([array.array('c', 'test')]) Traceback (most recent call last): File &q

[issue21362] concurrent.futures does not validate that max_workers is proper

2014-05-17 Thread Brian Quinlan
Brian Quinlan added the comment: Committed, thanks for the fix! -- resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/i

[issue9194] winreg:fixupMultiSZ should check that P < Q in the inner loop

2014-06-06 Thread Brian Curtin
Changes by Brian Curtin : -- nosy: -brian.curtin ___ Python tracker <http://bugs.python.org/issue9194> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue8576] test_support.find_unused_port can cause socket conflicts on Windows

2014-06-07 Thread Brian Curtin
Changes by Brian Curtin : -- nosy: -brian.curtin ___ Python tracker <http://bugs.python.org/issue8576> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue1559298] test_popen fails on Windows if installed to "Program Files"

2014-06-07 Thread Brian Curtin
Changes by Brian Curtin : -- nosy: -brian.curtin ___ Python tracker <http://bugs.python.org/issue1559298> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue10765] Build regression from automation changes on windows

2014-06-07 Thread Brian Curtin
Changes by Brian Curtin : -- nosy: -brian.curtin ___ Python tracker <http://bugs.python.org/issue10765> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue13101] Module Doc viewer closes when browser window closes on Windows 8

2014-06-10 Thread Brian Curtin
Changes by Brian Curtin : -- nosy: -brian.curtin ___ Python tracker <http://bugs.python.org/issue13101> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue9191] winreg.c:Reg2Py() may leak memory (in unusual circumstances)

2014-06-17 Thread Brian Curtin
Changes by Brian Curtin : -- nosy: -brian.curtin ___ Python tracker <http://bugs.python.org/issue9191> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue16218] Python launcher does not support non ascii characters

2012-11-02 Thread Brian Curtin
Changes by Brian Curtin : -- nosy: -brian.curtin ___ Python tracker <http://bugs.python.org/issue16218> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue12428] functools test coverage

2012-11-13 Thread Brian Thorne
Brian Thorne added the comment: > * Why the try block when there wasn't one before? > * Should reduce be added to __all__ only conditionally? My mistake, the try block should have just covered the import of partial - that is after all the exceptional circumstance we can deal with b

[issue16558] multiprocessing fails to raise exception with parameters

2012-11-26 Thread Brian Candler
New submission from Brian Candler: Probably best demonstrated by example. import multiprocessing class Myerror(ValueError): def __init__(self,a): self.a = a def __str__(self): return repr(self.a) def foo(arg): raise Myerror(arg) #foo

<    9   10   11   12   13   14   15   16   17   18   >