Barry A. Warsaw added the comment:
This and the _PyObject_FastCall* APIs really do need to be documented,
especially if they're going to be used in the interpreter itself. The leading
underscore signifies that it's not part of the public API (well, METH_FASTCALL
doesn't
New submission from Barry A. Warsaw :
I already added a section to the C API docs for some useful macros. I didn't
know about this one when I did that, but it seems like a useful macro to
document, so I will do that.
--
assignee: barry
components: Documentation
messages: 303707
Change by Barry A. Warsaw :
--
keywords: +patch
pull_requests: +3864
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue31693>
___
___
Py
Change by Barry A. Warsaw :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Barry A. Warsaw :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Barry A. Warsaw added the comment:
On Oct 6, 2017, at 15:04, Serhiy Storchaka wrote:
> Serhiy Storchaka added the comment:
>
> Another solution (works in 3.6 too): set idpattern to
> r'(?-i:[_a-zA-Z][_a-zA-Z0-9]*)'.
>
> This looks pretty weird, setting the
Barry A. Warsaw added the comment:
With some comments to clarify of course.
--
___
Python tracker
<https://bugs.python.org/issue31672>
___
___
Python-bugs-list m
Change by Barry A. Warsaw :
--
nosy: +barry
___
Python tracker
<https://bugs.python.org/issue31756>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Barry A. Warsaw :
__spec__ is defined in PEP 451. If you search for "__spec__" in the docs, you
get a number of hits.
https://docs.python.org/3/search.html?q=__spec__&check_keywords=yes&area=default
Click on the first link:
https://docs.python.org/3/ref
Change by Barry A. Warsaw :
--
keywords: +patch
pull_requests: +3984
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue31799>
___
___
Py
Change by Barry A. Warsaw :
--
nosy: +barry
___
Python tracker
<https://bugs.python.org/issue25711>
___
___
Python-bugs-list mailing list
Unsubscribe:
Barry A. Warsaw added the comment:
I've landed here after chatting with @brett.cannon. I have a use case for this
(making pex startup faster by bypassing pkg_resources) but I need to hack
around the limitation of dlopen'ing .so's from zips. Our idea was to have a
zipimport
Barry A. Warsaw added the comment:
New changeset 191e3138200906e43cba9347177914325b54843f by Barry Warsaw in
branch 'master':
bpo-31799: Make module.__spec__ more discoverable (#4010)
https://github.com/python/cpython/commit/191e3138200906e43cba9347177914
Barry A. Warsaw added the comment:
New changeset 858ea4354fafa36e57859d2dfd70f8a057984075 by Barry Warsaw (Miss
Islington (bot)) in branch '3.6':
[3.6] bpo-31799: Make module.__spec__ more discoverable (GH-4010) (#4021)
https://github.com/python/cpyt
Change by Barry A. Warsaw :
--
stage: patch review -> resolved
status: open -> closed
versions: -Python 3.4, Python 3.5
___
Python tracker
<https://bugs.python.org/i
Change by Barry A. Warsaw :
--
pull_requests: +3998
___
Python tracker
<https://bugs.python.org/issue25711>
___
___
Python-bugs-list mailing list
Unsubscribe:
Barry A. Warsaw added the comment:
I've ported the patch to a branch on GH. See PR 4023. I started from
zipimport-2.patch. It doesn't work, but it will be easier to work on as a PR
rather than a patch.
Contributions welcome! Let's see if we can
Change by Barry A. Warsaw :
--
pull_requests: +4205
stage: resolved -> patch review
___
Python tracker
<https://bugs.python.org/issue31415>
___
___
Python-
Barry A. Warsaw added the comment:
I like this a lot and while the issue is still open, I'm piggybacking my PR
4240 on this one.
I have a use case for enabling this feature via environment variable, so PR
4240 adds PYTHONPROFILEIMPORTTIME which also enables this feature.
We build our
Barry A. Warsaw added the comment:
This is defined behavior, not a bug. See the end of the section on string
literals:
https://docs.python.org/3/reference/lexical_analysis.html#string-and-bytes-literals
--
nosy: +barry
resolution: -> not a bug
stage: -> resolved
status
Barry A. Warsaw added the comment:
New changeset 700d2e4755921d6c339ff20dacecde1aea64de34 by Barry Warsaw in
branch 'master':
bpo-31415: Support PYTHONPROFILEIMPORTTIME envvar equivalent to -X importtime
(#4240)
https://github.com/python/cpyt
Barry A. Warsaw added the comment:
On Nov 2, 2017, at 22:50, INADA Naoki wrote:
>
> When adding environment variable option, it should be documented in
> man page and `python -h`.
I thought about that, but the problem is that none of the -X options are
documented in the —help outpu
Change by Barry A. Warsaw :
--
nosy: +barry
versions: +Python 3.7 -Python 3.8
___
Python tracker
<https://bugs.python.org/issue31936>
___
___
Python-bugs-list m
Change by Barry A. Warsaw :
--
keywords: +patch
pull_requests: +4219
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue31936>
___
___
Py
Barry A. Warsaw added the comment:
Re-reading the paragraph now, it also parsed weirdly for me. See the linked PR
for a suggested improvement, along with your change.
Thanks!
--
___
Python tracker
<https://bugs.python.org/issue31
Barry A. Warsaw added the comment:
On Nov 3, 2017, at 11:05, Serhiy Storchaka wrote:
>
> But now, after adding the environment variable, do we still need the -X
> option? From a user side I don't see much difference between specifying an
> option and an environment varia
Barry A. Warsaw added the comment:
New changeset 93952f881500053057c2e08c4b253ac61233d7db by Barry Warsaw in
branch 'master':
Fix a grammatical problem and reword for clarity. (#4257)
https://github.com/python/cpython/commit/93952f881500053057c2e08c4b253a
Change by Barry A. Warsaw :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Barry A. Warsaw added the comment:
-1 until we have something we can call a "mifflin".
(Kidding of course!)
--
nosy: +barry
___
Python tracker
<https://bugs.python.o
Barry A. Warsaw added the comment:
On Nov 3, 2017, at 14:41, Serhiy Storchaka wrote:
>
> Note that with environment variable you get more information.
Fun!
--
___
Python tracker
<https://bugs.python.org/i
Barry A. Warsaw added the comment:
On Nov 3, 2017, at 14:23, Terry J. Reedy wrote:
>
> Does it set the EV for the entire session (which one likely would not want),
> or just the one command (which has no Windows equivalent that I know of)?
> Please leave the easily remember
Barry A. Warsaw added the comment:
Okay, given the non-propagation and Windows issues. I'm -1 on removing -X, +1
on fixing the negative cache.
--
___
Python tracker
<https://bugs.python.org/is
Barry A. Warsaw added the comment:
On Nov 4, 2017, at 14:29, Terry J. Reedy wrote:
> The importtime output is sent to stderr. Should this be documented?
Yes. :)
--
___
Python tracker
<https://bugs.python.org/issu
New submission from Barry A. Warsaw :
Issue bpo-26182 added DeprecationWarnings for "import async" and "import await"
since both of those pseudo-keywords were to become actual reserved keywords in
Python 3.7. This latter has now happened, but the fix in bpo-26182 is
inco
Change by Barry A. Warsaw :
--
nosy: +barry
___
Python tracker
<https://bugs.python.org/issue31975>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Barry A. Warsaw :
--
nosy: +barry
___
Python tracker
<https://bugs.python.org/issue31984>
___
___
Python-bugs-list mailing list
Unsubscribe:
Barry A. Warsaw added the comment:
I think there is nothing left to do for this issue, so I'm closing it.
--
status: open -> closed
___
Python tracker
<https://bugs.python.org
Change by Barry A. Warsaw :
--
nosy: +barry
___
Python tracker
<https://bugs.python.org/issue32030>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Barry A. Warsaw :
timeit is cool, but it's not appropriate for all performance testing. For
example, since it uses only a single Python process, anything that's cached is
not a good candidate for timeit profiling. The classic example is timing
imports. E.g.
Barry A. Warsaw added the comment:
On Nov 15, 2017, at 17:00, Serhiy Storchaka wrote:
>
> +1 to all said by Raymond. But this is rather the matter of a special article
> or blog post than a note in the documentation.
Maybe a HOWTO on performance testing and analysis? We already ha
Change by Barry A. Warsaw :
--
nosy: +barry
___
Python tracker
<https://bugs.python.org/issue32043>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Barry A. Warsaw :
--
nosy: +barry
___
Python tracker
<https://bugs.python.org/issue32088>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Barry A. Warsaw :
--
pull_requests: +4420
___
Python tracker
<https://bugs.python.org/issue31672>
___
___
Python-bugs-list mailing list
Unsubscribe:
Barry A. Warsaw added the comment:
@inada.naoki - I think changing this to ?a will make things more clear. I
submitted a PR for that, and then once it lands, we can close this issue.
--
___
Python tracker
<https://bugs.python.org/issue31
Barry A. Warsaw added the comment:
Yeah, I find it pretty common to set both stdout and stderr to PIPE, but I'm
with you in hesitating to add YAO to the subprocess API. If you do move
forward with this though, I think capture_output would have to be mutually
exclusive to stdout and s
Barry A. Warsaw added the comment:
New changeset e256b408889eba867e1d90e5e1a0904843256255 by Barry Warsaw in
branch 'master':
bpo-31672 - Add one last minor clarification for idpattern (#4483)
https://github.com/python/cpython/commit/e256b408889eba867e1d90e5e1a090
Change by Barry A. Warsaw :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Barry A. Warsaw :
The check_node() function in test_uuid.py uses the wrong bitmask, causing the
tests to fail on valid MAC addresses. Also, the description in the comment is
incorrect. From my reading of the wikipedia page, the test is trying to ensure
that the MAC
Change by Barry A. Warsaw :
--
keywords: +patch
pull_requests: +4431
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue32107>
___
___
Py
Barry A. Warsaw added the comment:
Pure chance I believe. It all depends on the MAC address of the machines the
test runs on (which is perhaps an unacceptable environmental variability in the
test suite, and should be fixed/mocked?).
FWIW, I saw the failures on my 2017 MacBook Pro, where
Barry A. Warsaw added the comment:
Yikes. It's entirely possible that these tests are tainted by environmental
leakage. I was looking into why Travis fails on my PR:
https://travis-ci.org/python/cpython/jobs/305433725
and stepping through _ifconfig_getnode() on my Mac. The &qu
Barry A. Warsaw added the comment:
On Nov 21, 2017, at 15:47, Serhiy Storchaka wrote:
> If your fix is correct (and it looks correct to me), we should fix not only
> the test, but, first of all, the _*_getnode functions. Perhaps they should
> ignore locally administered MAC addr
Barry A. Warsaw added the comment:
On Nov 23, 2017, at 11:24, Serhiy Storchaka wrote:
> Wait, now I understand the purpose of the current test! There is just a typo
> in a comment, should be 41 instead of 47. The test itself is correct. If the
> address is obtained from network
Barry A. Warsaw added the comment:
On Nov 26, 2017, at 12:40, Serhiy Storchaka wrote:
>
> Serhiy Storchaka added the comment:
>
> If I understand correctly, the original problem was that tests failed in some
> environments, right? In that case we should either change the
Barry A. Warsaw added the comment:
On Nov 26, 2017, at 14:07, Serhiy Storchaka wrote:
>
> Universally/locally administered MAC addresses doesn't have relation to this
> issue. My assumption was about the multicast bit (1<<40).
AFAICT, the multicast bit is only required
Change by Barry A. Warsaw :
--
pull_requests: +4504
___
Python tracker
<https://bugs.python.org/issue32107>
___
___
Python-bugs-list mailing list
Unsubscribe:
Barry A. Warsaw added the comment:
PR #4576 includes all related changes.
--
___
Python tracker
<https://bugs.python.org/issue32107>
___
___
Python-bugs-list m
Barry A. Warsaw added the comment:
On Nov 27, 2017, at 01:24, Serhiy Storchaka wrote:
>
> 3. Makes methods for getting the address of the real network card preferring
> universally administered addresses and falling back to locally administered
> address only if universally
Barry A. Warsaw added the comment:
New changeset 9522a218f7dff95c490ff359cc60e8c2af35f5c8 by Barry Warsaw in
branch 'master':
bpo-32107 - Better merge of #4494 (#4576)
https://github.com/python/cpython/commit/9522a218f7dff95c490ff359cc60e8
Barry A. Warsaw added the comment:
On Nov 27, 2017, at 15:18, Serhiy Storchaka wrote:
>
> My apologies for my dim comment and my obliviousness that leaded to spending
> your time on trying to fix a wrong issue.
No worries at all. Thanks for working with me to make the fix as g
Change by Barry A. Warsaw :
--
pull_requests: +4514
___
Python tracker
<https://bugs.python.org/issue32107>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Barry A. Warsaw :
--
pull_requests: +4515
___
Python tracker
<https://bugs.python.org/issue32107>
___
___
Python-bugs-list mailing list
Unsubscribe:
Barry A. Warsaw added the comment:
On Nov 27, 2017, at 16:08, Serhiy Storchaka wrote:
>
> We shouldn't check the 42nd bit in maintenance releases. This check will fail
> on some computers.
Oh, without the preferential return of the universally administered MAC, you’re
right.
Barry A. Warsaw added the comment:
On Nov 27, 2017, at 16:21, Ned Deily wrote:
>
> The latest checkin seems to have broken several buildbots:
>
> http://buildbot.python.org/all/#builders/47/builds/243
> http://buildbot.python.org/all/#builders/88/builds/248
> http://build
Barry A. Warsaw added the comment:
On Nov 27, 2017, at 18:38, STINNER Victor wrote:
>
> STINNER Victor added the comment:
>
> The commit 9522a218f7dff95c490ff359cc60e8c2af35f5c8 broke multiple buildbots.
> Since I don't how to fix it, I reverted it, to get more time to
Change by Barry A. Warsaw :
--
pull_requests: +4520
___
Python tracker
<https://bugs.python.org/issue32107>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Barry A. Warsaw :
--
title: test_uuid uses the incorrect bitmask -> Improve MAC address calculation
and fix test_uuid.py
___
Python tracker
<https://bugs.python.org/issu
Change by Barry A. Warsaw :
--
nosy: +barry
___
Python tracker
<https://bugs.python.org/issue32158>
___
___
Python-bugs-list mailing list
Unsubscribe:
Barry A. Warsaw added the comment:
New changeset 23df2d1304ece169d7e0dfc843dfb8026b413d9f by Barry Warsaw in
branch 'master':
bpo-32107 - Improve MAC address calculation and fix test_uuid.py (#4600)
https://github.com/python/cpython/commit/23df2d1304ece169d7e0dfc843dfb8
Barry A. Warsaw added the comment:
New changeset 56e444f8df34cd502d6e3b110c90aed086883a72 by Barry Warsaw in
branch '2.7':
[2.7] bpo-32107 - Backport bitmask check fix (GH-4576) (#4590)
https://github.com/python/cpython/commit/56e444f8df34cd502d6e3b110c90ae
Barry A. Warsaw added the comment:
New changeset 23cc8c0f9ece32f1f96133b9db2cb30c64f23a0e by Barry Warsaw in
branch '3.6':
[3.6] bpo-32107 - Backport bitmask check fix (GH-4576) (#4591)
https://github.com/python/cpython/commit/23cc8c0f9ece32f1f96133b9db2cb3
Change by Barry A. Warsaw :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Barry A. Warsaw :
--
nosy: +barry
___
Python tracker
<https://bugs.python.org/issue32192>
___
___
Python-bugs-list mailing list
Unsubscribe:
Barry A. Warsaw added the comment:
> Sorry, but I can't understand how 23df2d1304ece169d7e0dfc843dfb8026b413d9f
> could break getnode() on Android and how your changes can fix this. The only
> effect of this change is that an error in _random_getnode() no longer
> silenced
Barry A. Warsaw added the comment:
I missed it too. Serhiy, do you want to add that fix to your already open PR
4677?
--
___
Python tracker
<https://bugs.python.org/issue32
Barry A. Warsaw added the comment:
Over in the PR I suggested:
Here's another thought: what if you just added another getter that calls ip
link list and placed that after one that calls ip link. Wouldn't that
accomplish both goals? Then if ip link fails, we fall back to the old beh
Barry A. Warsaw added the comment:
On Dec 5, 2017, at 16:28, Xavier de Gaye wrote:
>
> The result of various 'ip' commands on Android, the last 'ip link list'
> command is run as root and succeeds (did not think about trying that before):
>
> generic_x86_
Barry A. Warsaw added the comment:
On Dec 6, 2017, at 02:06, Xavier de Gaye wrote:
>
> Whatever the change made to fix this issue, it is not possible to add a test
> case for this change.
Even with say, exception raising mocks for the getters?
> So following the suggestion made
Barry A. Warsaw added the comment:
> Maybe we should just close this issue as 'wont fix' then.
I would be okay with any of these resolutions:
* Close as `wont fix`
* Just call `ip link` (without list)
* Add a new getter such that both `ip link` and `ip link list` are called.
Barry A. Warsaw added the comment:
Yes, I think this is a good idea. Would you like to submit a PR for it?
FWIW, we have this code in Mailman 3:
class Mailbox(MMDF):
"""A mailbox that interoperates with the 'with' statement."""
def __enter__(s
Barry A. Warsaw added the comment:
LGTM, and thanks!
--
___
Python tracker
<https://bugs.python.org/issue32199>
___
___
Python-bugs-list mailing list
Unsub
New submission from Barry A. Warsaw :
We intend to port importlib_resources to Python 3.7 as importlib.resources,
with a provisional API. There's also a ResourceReader ABC to include, along
with documentation and tests.
Nosying Brett and assigning to myself, but if Brett *wants* to d
Change by Barry A. Warsaw :
--
nosy: +barry
___
Python tracker
<https://bugs.python.org/issue32263>
___
___
Python-bugs-list mailing list
Unsubscribe:
Barry A. Warsaw added the comment:
On Dec 10, 2017, at 14:36, Raymond Hettinger wrote:
>
> Raymond Hettinger added the comment:
>
> We can remove the word "normal" but otherwise the docs read fairly well.
+1
> FWIW, when there docs were written, the {} new-style
Barry A. Warsaw added the comment:
It's possible that the Mailman example can just assume that the mailbox will be
flushed and unlocked on __exit__(), so it could just call .close(). Then the
question is whether entering the CM should lock the mailbox. The two cases are:
1. It doesn&
Barry A. Warsaw added the comment:
I wasn't even aware that pop_all() tries to create the concrete subtype. I
wonder how common subclassing ExitStack is in practice. (Of course, the answer
is that we'll never know.)
For 3.7, we should probably delegate instance creation to
Change by Barry A. Warsaw :
--
nosy: +barry
___
Python tracker
<https://bugs.python.org/issue31554>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Barry A. Warsaw :
--
nosy: +barry
___
Python tracker
<https://bugs.python.org/issue21762>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Barry A. Warsaw :
Let's say I have a namespace package:
>>> importlib_resources.tests.data03.namespace
This package has a non-None __loader__ but a None __spec__.loader:
>>> importlib_resources.tests.data03.namespace.__loader__
<_frozen_importlib
New submission from Barry A. Warsaw :
Along the lines of Issue32303 there's another inconsistency in namespace
package metadata. Let's say I have a namespace package:
>>> importlib_resources.tests.data03.namespace
The package has no __file__ attribute, and it has a
Change by Barry A. Warsaw :
--
nosy: +barry
___
Python tracker
<https://bugs.python.org/issue32333>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Barry A. Warsaw :
--
nosy: +barry
___
Python tracker
<https://bugs.python.org/issue20891>
___
___
Python-bugs-list mailing list
Unsubscribe:
Barry A. Warsaw added the comment:
I have the tests and code ported, but there are still a few things to do, but
here's a question:
We're using type annotations in importlib_resources, which of course is the
right decision. But I think we still have a moratorium on typing in t
Change by Barry A. Warsaw :
--
pull_requests: +4805
___
Python tracker
<https://bugs.python.org/issue32248>
___
___
Python-bugs-list mailing list
Unsubscribe:
Barry A. Warsaw added the comment:
PR 4911 implements the importlib.resources API, along with tests and
documentation.
@brett.cannon - I'm thinking we should do the native ResourceReader
implementations for the built-in loaders as a separate b
Barry A. Warsaw added the comment:
On Dec 25, 2017, at 18:51, Nick Coghlan wrote:
>
> 3. A for-subclasses-only "self._clone()" API could work as follows:
>
>def _clone(self, new_instance=None):
>if new_instance is None:
>new_instance = t
Barry A. Warsaw added the comment:
On Dec 26, 2017, at 18:17, Antoine Pitrou wrote:
>
> I'd really like it if we could get rid of the Setup/Setup.dist thing. It's a
> distraction to have to type `cp -f Modules/Setup.dist Modules/Setup` from
> time to time... ev
Barry A. Warsaw added the comment:
On Dec 29, 2017, at 08:40, Nick Coghlan wrote:
>
> I'm not clear on what you mean about allowing arbitrary names for the
> instance creation function -
What I meant was that I don’t see `def _make_instance()` defined in your
example, so I
New submission from Barry A. Warsaw :
Currently get_data() only accepts a string. It should also accept a os.PathLike
--
messages: 309178
nosy: barry, brett.cannon
priority: normal
severity: normal
status: open
title: ResourceLoader.get_data() should accept a PathLike
versions: Python
Barry A. Warsaw added the comment:
@yselivanov - thanks for adding this, it's a huge win.
I think the feature is significant enough for a What's New entry.
--
___
Python tracker
<https://bugs.python.o
1601 - 1700 of 2726 matches
Mail list logo
