Change by Anthony Sottile :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Anthony Sottile :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Anthony Sottile :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Anthony Sottile :
--
keywords: +patch
pull_requests: +18379
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/19030
___
Python tracker
<https://bugs.python.org/issu
Anthony Sottile added the comment:
one example is here:
https://github.com/pre-commit/pre-commit/blob/bb6f1efe63c168d9393d520bd60e16c991a57059/pre_commit/store.py#L137-L139
where I would want cleanup in the exceptional case
another (related but different) closed-source use case involves
Anthony Sottile added the comment:
oh! that's neat, yeah hadn't been following closely enough it seems, good to
hear that the readonly thing is fixed!
--
___
Python tracker
<https://bugs.python.o
Anthony Sottile added the comment:
fwiw, astpretty's output looks like the black output:
https://github.com/asottile/astpretty
>>> astpretty.pprint(ast.parse('if x == y: y += 4').body[0])
If(
lineno=1,
col_offset=0,
test=Compare(
lineno
Anthony Sottile added the comment:
Serhiy's comment provides workarounds but are still (imo) inferior to
supporting this.
I would really like for this api to match that of NamedTemporaryFile which has
the same `delete=...` option
--
___
P
Anthony Sottile added the comment:
the differences are api compatibility with context manager protocol and
equivalence with NamedTemporaryFile
NamedTemporaryFile(delete=False) is just `mkstemp` afaict and the api is there
--
___
Python tracker
Anthony Sottile added the comment:
you are right though, the effect is the same as just using mkdtemp
--
___
Python tracker
<https://bugs.python.org/issue25
Change by Anthony Sottile :
--
nosy: +Anthony Sottile
nosy_count: 6.0 -> 7.0
pull_requests: +18644
pull_request: https://github.com/python/cpython/pull/10021
___
Python tracker
<https://bugs.python.org/issu
New submission from Anthony Sottile :
Haven't yet bisected, but noticed this in the nightly builds I provide for
ubuntu deadsnakes https://github.com/deadsnakes/nightly -- I believe it to be
this patch so I've added to nosy: https://github.com/python/cpython/pull/19082
Both pyt
Anthony Sottile added the comment:
yes, it is still broken, now with fewer errors:
2020-04-13T15:06:34.7330649Z x86_64-linux-gnu-gcc -pthread -fPIC -Wdate-time
-D_FORTIFY_SOURCE=2 -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3
-Wall -g -fstack-protector -Wformat -Werror=format
Anthony Sottile added the comment:
this is still broken even with the latest patch:
https://bugs.python.org/issue40266
--
nosy: +Anthony Sottile
___
Python tracker
<https://bugs.python.org/issue39
Anthony Sottile added the comment:
This patch has broken debian's builds due to use of modulefinder -- notably the
type of `file_info` changed as a side-effect of this patch and is now causing:
../debian/pymindeps.py:29: DeprecationWarning: the imp module is deprecated in
favo
Anthony Sottile added the comment:
I'm admittedly a little unfamiliar with what it does as well -- I'm mostly
repackaging debian sources for deadsnakes. If I'm correct in my assumption, it
is attempting to find a minimal set of modules to package into
`python3-minimal` and e
Anthony Sottile added the comment:
(additionally, I'm not sure this should be backported to python3.8, especially
with changed behaviour)
--
___
Python tracker
<https://bugs.python.org/is
New submission from Anthony Sottile :
this was noticed in pyflakes's testsuite:
https://github.com/PyCQA/pyflakes/pull/532#pullrequestreview-396059622
I've created a small script to reproduce the problem
```
import sys
SRC = b"""\
def foo():
'&#
Change by Anthony Sottile :
--
nosy: +pablogsal
___
Python tracker
<https://bugs.python.org/issue40335>
___
___
Python-bugs-list mailing list
Unsubscribe:
Anthony Sottile added the comment:
This is still failing, but now in a different way:
Traceback (most recent call last):
File "../debian/pymindeps.py", line 185, in
main(sys.argv[1:])
File "../debian/pymindeps.py", line 178, in main
mf.run_script(arg)
Anthony Sottile added the comment:
The failure above is `fp` is now a text file but before it was a binary file.
this causes `fp.read()` + `b'\n'` to fail
I can send a patch -- I don't think the `b'\n'` is necessary any more (as far
as I can tell it used to be th
Change by Anthony Sottile :
--
pull_requests: +18965
pull_request: https://github.com/python/cpython/pull/19641
___
Python tracker
<https://bugs.python.org/issue40
Anthony Sottile added the comment:
actually I said that backwards in the previous message -- it was a text file
and now it's a binary file
--
___
Python tracker
<https://bugs.python.org/is
Anthony Sottile added the comment:
debian has its own implementation of find_modules which still returns a text
file for PY_SOURCE
changing the type of that io object is the "breaking change" and maybe
shouldn't be backported to python3.8 in
Anthony Sottile added the comment:
The trailing newline was added in 1.5.1
78fc3634cbfd65a6be8abfd1b7fc7cbd0ccbfb39 -- back then `compile(...)` could not
take strings which did not end in newlines
now it can, so it is safe to remove -- I did the same triage on another PR
here: https
New submission from Anthony Sottile :
compare the following:
```
if False: 'foo'(1)
```
$ python3.9
Python 3.9.0a5 (default, Mar 23 2020, 23:11:30)
[GCC 7.5.0] on linux
Type "help", "copyright", "credits" or "license" for more information
Anthony Sottile added the comment:
This seems to have regressed again
$ ./python --version --version
Python 3.9.0a5+ (heads/master:503de7149d, Apr 24 2020, 13:34:49)
[GCC 7.5.0]
$ ./python t.py
File "/home/asottile/workspace/cpython/t.py&quo
Anthony Sottile added the comment:
I would really like to be able to trigger all warnings consistently and
statically without executing the code.
This is useful (for instance) for this simple script which validates the ast:
https://github.com/pre-commit/pre-commit-hooks/blob/master
Anthony Sottile added the comment:
pyflakes's testsuite has many failures under the new parser -- is the
expectation that those will be fixed by 3.9 final?
--
___
Python tracker
<https://bugs.python.org/is
Anthony Sottile added the comment:
:waves: -- seeing a lot of failures in pyflakes' testsuite around SyntaxErrors
https://github.com/PyCQA/pyflakes/pull/532
(you can reproduce with `path/to/python -m unittest discover pyflakes` without
needing any dependencies installed)
--
Anthony Sottile added the comment:
cool, reported there as well!
--
___
Python tracker
<https://bugs.python.org/issue40335>
___
___
Python-bugs-list mailin
New submission from Anthony Sottile :
unclear if this is intentional or not, I noticed this while seeing that
`ast.Subscript.slice` is no longer `Index` / `Slice` / `ExtSlice`
# python3.8
>>> isinstance(ast.Slice(), ast.slice)
True
# python3.9a6
>>> isinstance(ast.Slice()
New submission from Anthony Sottile :
just spent quite a bit of time debugging this, here's a minimal example:
```bash
# rm -rf a (if you want to reset)
cd /tmp
mkdir -p a/b
echo 'import os; os.chdir("..")' > a/b/c.py
cd a/b
python3 -m cProfile -o log.pstats c.py
l
Change by Anthony Sottile :
--
keywords: +patch
pull_requests: +19225
pull_request: https://github.com/python/cpython/pull/19910
___
Python tracker
<https://bugs.python.org/issue40
New submission from Anthony Sottile :
```console
$ ln -s 'import os; os.system("echo hi")' __main__.py
$ ls -al
total 8
drwxr-xr-x 2 asottile asottile 4096 May 5 15:55 .
drwxr-xr-x 3 asottile asottile 4096 May 5 14:50 ..
lrwxrwxrwx 1 asottile asottile 31 May 5 15:55 __
Anthony Sottile added the comment:
one way might be to give the groups "unique" names (perhaps hashing the input
string?) ((this is what I attempted to do in a little bit of code which tried
to "backport" (group)*+ and (group)++))
--
no
Anthony Sottile added the comment:
fwiw virtualenv 20.x uses `.pth` now as well to fix some issues with
`venv`-based environments
--
___
Python tracker
<https://bugs.python.org/issue33
Anthony Sottile added the comment:
@serhiy: this was pretty straightfowrard to fix as you suspected -- would you
be able to review it?
--
___
Python tracker
<https://bugs.python.org/issue40
New submission from Anthony Sottile :
here's a sample file. this is distilled down from an example which broke a
code formatter here: https://github.com/asottile/add-trailing-comma/issues/106
def f():
x = (
'PERL_MM_OPT', (
f'INSTALL-BA
Anthony Sottile added the comment:
+peg parser individuals to nosy
--
nosy: +gvanrossum, lys.nikolaou, pablogsal
___
Python tracker
<https://bugs.python.org/issue42
Anthony Sottile added the comment:
I didn't initially, but now I have and it has the same bug in the current
master: 3bf05327c2b25d42b92795d9d280288c22a0963d
--
___
Python tracker
<https://bugs.python.org/is
Anthony Sottile added the comment:
by the way, here's a much smaller case which has a similar problem
```
x = (
f" {test(t)}"
)
```
--
___
Python tracker
<https://bugs.pyt
Anthony Sottile added the comment:
should the minimum sphinx version be bumped and/or this reverted:
https://github.com/python/cpython/blob/f7f0ed59bcc41ed20674d4b2aa443d3b79e725f4/Doc/conf.py#L48
this change breaks, for example, sphinx 1.8.5 while building for ubuntu 20.04
The directive
New submission from Anthony Sottile :
I did some profiling (attached a few files here with svgs) of running this
script:
```python
import io
import tokenize
# picked as the second longest file in cpython
with open('Lib/test/test_socket.py', 'rb') as f:
bio = io.Byt
Change by Anthony Sottile :
Added file: https://bugs.python.org/file49760/out.svg
___
Python tracker
<https://bugs.python.org/issue43014>
___
___
Python-bugs-list mailin
Change by Anthony Sottile :
Added file: https://bugs.python.org/file49761/out2.pstats
___
Python tracker
<https://bugs.python.org/issue43014>
___
___
Python-bugs-list m
Change by Anthony Sottile :
Added file: https://bugs.python.org/file49762/out2.svg
___
Python tracker
<https://bugs.python.org/issue43014>
___
___
Python-bugs-list mailin
Change by Anthony Sottile :
--
keywords: +patch
pull_requests: +23130
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/24311
___
Python tracker
<https://bugs.python.org/issu
Anthony Sottile added the comment:
admittedly anecdotal but here's another data point in addition to the profiles
attached
test.test_tokenize suite before:
$ ./python -m test.test_tok
Change by Anthony Sottile :
Added file: https://bugs.python.org/file49763/out3.pstats
___
Python tracker
<https://bugs.python.org/issue43014>
___
___
Python-bugs-list m
Anthony Sottile added the comment:
attached out3.pstats / out3.svg which represent the optimization using
lru_cache instead
--
Added file: https://bugs.python.org/file49764/out3.svg
___
Python tracker
<https://bugs.python.org/issue43
Anthony Sottile added the comment:
just noticed this PR -- you might be interested in pyupgrade which automates
some of these things -- here's (for example) `git ls-files -- Lib/idlelib |
grep '\.py$' | xargs pyupgrade --py36-plus
```diff
diff --git a/Lib/idlelib/calltip_w.p
Anthony Sottile added the comment:
> Anthony: removing 'set' from 'list(set(interable))' is wrong if 'set' were
> added to remove duplicates.
It's not removed, it's changed to a set comprehension (which was added in 2.7
and 3.0)
pyupgrade
Anthony Sottile added the comment:
Serhiy Storchaka is this still blocked? it's been a few years on either this
or the linked issue and I'm reaching for this one :)
--
nosy: +Anthony Sottile
___
Python tracker
<https://bugs.python.
Anthony Sottile added the comment:
I'm interested in it because the `tokenize` module is painfully slow
--
___
Python tracker
<https://bugs.python.org/i
Anthony Sottile added the comment:
you already have that right now because the `tokenize` module is exposed.
(except that every change to the tokenization requires it to be implemented
once in C and once in python)
it's much more frustrating when the two differ as well
I don't
Anthony Sottile added the comment:
private api sounds fine too -- I thought it was necessary to implement the
module (as it needs external linkage) but if it isn't then even better
--
___
Python tracker
<https://bugs.python.org/i
Anthony Sottile added the comment:
Either works for me, would you be able to point me to the starting bits as to
how `_ast` becomes builtin?
--
___
Python tracker
<https://bugs.python.org/issue3
Anthony Sottile added the comment:
I haven't looked into or thought about that yet, it might not be possible
It might also make sense to build new tokenize.py apis avoiding the
`readline()` api -- I always found it painful to work
Anthony Sottile added the comment:
via
https://github.com/python/cpython/commit/b4d4aef8433da2657c8d80207686124d15d32054
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/i
Anthony Sottile added the comment:
There's current expectation in a lot of linters / code formatters that the
*lineno and *col_offset attributes will be missing if they are not attached to
the node
setting them to None is going to break a lot of those, if possible I'd suggest
goi
Anthony Sottile added the comment:
pre-commit uses this to do deterministic shuffling, please don't remove this
https://github.com/pre-commit/pre-commit/issues/1479
--
nosy: +Anthony Sottile
___
Python tracker
<https://bugs.python.org/is
Change by Anthony Sottile :
--
nosy: +Anthony Sottile
nosy_count: 4.0 -> 5.0
pull_requests: +20235
pull_request: https://github.com/python/cpython/pull/21066
___
Python tracker
<https://bugs.python.org/issu
Anthony Sottile added the comment:
This appears to have broken pydoc of the select module, I've attached a patch
$ python3.8 -m pydoc select
Traceback (most recent call last):
File "/usr/lib/python3.8/inspect.py", line 2004, in wrap_value
value = eval(s, module_dict)
Change by Anthony Sottile :
--
pull_requests: +20264
pull_request: https://github.com/python/cpython/pull/21097
___
Python tracker
<https://bugs.python.org/issue31
Change by Anthony Sottile :
--
pull_requests: +20265, 20266, 20267
pull_request: https://github.com/python/cpython/pull/21098
___
Python tracker
<https://bugs.python.org/issue31
Change by Anthony Sottile :
--
pull_requests: +20265
pull_request: https://github.com/python/cpython/pull/21098
___
Python tracker
<https://bugs.python.org/issue31
Change by Anthony Sottile :
--
pull_requests: +20265, 20266
pull_request: https://github.com/python/cpython/pull/21098
___
Python tracker
<https://bugs.python.org/issue31
Change by Anthony Sottile :
--
keywords: +patch
nosy: +Anthony Sottile
nosy_count: 3.0 -> 4.0
pull_requests: +20269
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/21066
___
Python tracker
<https://bugs.p
Anthony Sottile added the comment:
Looking into this, it appears to be due to the default value and not due to the
newline
I've stumbled upon two simplifications to the routines in inspect but not a fix
for this
1. https://github.com/python/cpython/pull/21100
2. https://github.com/p
Anthony Sottile added the comment:
this breaks builds for ubuntu, I'd suggest reverting this (especially because
it appears to build fine without this patch)
2020-06-29T08:52:56.8303672Z x86_64-linux-gnu-gcc -pthread -fPIC -Wdate-time
-D_FORTIFY_SOURCE=2 -Wno-unused-result -Wsign-co
Anthony Sottile added the comment:
especially this late in the beta period for 3.9 -- it would be unfortunate for
3.10 but it's an explicit break of feature freeze for 3.9
--
___
Python tracker
<https://bugs.python.org/is
Anthony Sottile added the comment:
reverting this patch passes all the tests, what's the motivation and why were
there no code reviews for this?
--
___
Python tracker
<https://bugs.python.org/is
Anthony Sottile added the comment:
I package pythons for ubuntu:
https://github.com/deadsnakes/python3.9-nightly/actions/runs/151286686
https://github.com/deadsnakes/python3.10-nightly/actions/runs/151287821
--
___
Python tracker
<ht
Anthony Sottile added the comment:
> Otherwise, why use the system libmpdec at all and not the version
shipped with Python?
the packages are faithful reproductions of upstream packages, deviating from
those introduces surprises for downstreams
> If I install into a venv, I also don
Anthony Sottile added the comment:
Łukasz: what would you recommend for downstream packagers?
I have essentially two options (assuming this isn't reverted in cpython master
which I believe makes the most sense since cpython still works fine with older
libmpdec):
- revert this indiv
New submission from Anthony Sottile :
C:
https://github.com/python/cpython/blob/8b33961e4bc4020d8b2d5b949ad9d5c669300e89/Modules/_datetimemodule.c#L3183
pure python:
https://github.com/python/cpython/blob/8b33961e4bc4020d8b2d5b949ad9d5c669300e89/Lib/datetime.py#L927
this makes it difficult
Anthony Sottile added the comment:
awesome, I'm going to work through this with someone in my discord as a demo /
mentorship opportunity -- hope that's ok!
--
___
Python tracker
<https://bugs.python.o
Change by Anthony Sottile :
--
nosy: +Anthony Sottile
nosy_count: 3.0 -> 4.0
pull_requests: +20834
pull_request: https://github.com/python/cpython/pull/21100
___
Python tracker
<https://bugs.python.org/issu
New submission from Anthony Sottile :
For example:
>>> import pwd
>>> pwd.getpwnam("test")
Traceback (most recent call last):
File "", line 1, in
KeyError: "getpwnam(): name not found: 'test'"
An improvement would be som
Change by Anthony Sottile :
--
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue41767>
___
___
Python-bugs-list
Anthony Sottile added the comment:
(I know this is old and closed but I've just run into the same thing with
pwd.getpwnam in issue41767)
KeyError: "getpwnam(): name not found: 'test'"
would it be possible / make sense to extend `KeyError` with a
named-only-argu
Anthony Sottile added the comment:
Seems to be due to https://bugs.python.org/issue40187
--
nosy: +Anthony Sottile, serhiy.storchaka
___
Python tracker
<https://bugs.python.org/issue41
Change by Anthony Sottile :
--
pull_requests: +21715
pull_request: https://github.com/python/cpython/pull/22752
___
Python tracker
<https://bugs.python.org/issue40
Change by Anthony Sottile :
--
pull_requests: +21718
pull_request: https://github.com/python/cpython/pull/22755
___
Python tracker
<https://bugs.python.org/issue40
New submission from Anthony Sottile :
this was originally pointed out in a comment on my youtube video here:
https://youtu.be/Xf_82stIbB8
here's a reproduction:
1. produce 5000 characters of output: python3 -c 'print("a"*5000)'
2. copy that to the clipboard
3. run
Anthony Sottile added the comment:
indeed! that's it -- you learn something every day :)
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.pyth
Change by Anthony Sottile :
--
keywords: +patch
pull_requests: +13312
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/iss
Anthony Sottile added the comment:
still not able to answer the why, but at least I can answer the what here:
https://github.com/python/cpython/blob/f665b96e92a6a6943e312e2c606f348db95939ab/Parser/tokenizer.c#L984-L987
cpython adds a newline during tokenization if the file does not end in a
Anthony Sottile added the comment:
there's other optional fields in the ast, type ignores don't seem essential to
the `Module`, could those be made optional as well?
--
nosy: +Anthony Sottile
___
Python tracker
<https://bugs.python.o
New submission from Anthony Sottile :
notably it is missing ForwardRef, OrderedDict, ChainMap in python3.8
it is missing others in other versions
I'm going to attempt to write a test which should classify things that should
belong there
--
components: Library (Lib)
messages: 3
Change by Anthony Sottile :
--
keywords: +patch
pull_requests: +13365
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue36983>
___
_
Anthony Sottile added the comment:
using the same heuristic as the test uses, here's what's been missing from
__all__ historically
(note: I _manually_ skipped `Final` for 3.5.0-3)
===(3, 5, 0)===
+FrozenSet
+Sup
New submission from Anthony Sottile :
expanding on https://bugs.python.org/issue36983
the docs are also a bit out of date in places
I'm not sure how to document something that appeared in two versions, but I'll
leave that part to review.
Using data generated / collected
Change by Anthony Sottile :
--
keywords: +patch
pull_requests: +13366
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue36984>
___
_
New submission from Anthony Sottile :
- New since 3.7.0
- is exposed by some public apis:
- the `__doc__` attribute of `typing` mentions `ForwardRef`
- `get_type_hints` can expose an instance of it:
https://bugs.python.org/issue35834
Should this be documented? including in __all__
Anthony Sottile added the comment:
You want:
os.execl('/bin/bash', 'bash', '--init-file', ...)
argv[0] is supposed to be the program name, your example puts `--init-file` as
the program name
------
nosy: +Anthony Sottile
Anthony Sottile added the comment:
They're thin wrappers around the same C functions -- that's just how C works
it is also documented: https://docs.python.org/3/library/os.html#os.execvpe
> In either case, the arguments to the child process **should start with the
> nam
Anthony Sottile added the comment:
yep, happy to do that -- I know I'll need to do 3.7, but should I also do 3.6?
3.5?
--
___
Python tracker
<https://bugs.python.org/is
Change by Anthony Sottile :
--
pull_requests: +13553
pull_request: https://github.com/python/cpython/pull/13662
___
Python tracker
<https://bugs.python.org/issue36
101 - 200 of 403 matches
Mail list logo
