Change by anthony shaw :
--
nosy: +dstufft, ncoghlan
___
Python tracker
<https://bugs.python.org/issue5243>
___
___
Python-bugs-list mailing list
Unsubscribe:
anthony shaw added the comment:
The discussion on python-ideas has some unresolved questions. Wren, did you get
a definitive answer on this idea?
--
nosy: +anthonypjshaw
___
Python tracker
<https://bugs.python.org/issue31
Change by anthony shaw :
--
keywords: +patch
pull_requests: +13040
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue34946>
___
___
Py
anthony shaw added the comment:
Submitted PR to add the deprecation warning, since this initial discussion,
some other functions also raise DeprecationWarning's in code.
--
nosy: +anthonypjshaw
___
Python tracker
<https://bugs.py
anthony shaw added the comment:
Hi Peter, this proposal would be easier to review as a GitHub Pull Request.
--
nosy: +anthonypjshaw
___
Python tracker
<https://bugs.python.org/issue28
anthony shaw added the comment:
This issue was never responded to, are you still having this issue? Which
version of CPython are you using and can you please provide steps to reproduce
the problem.
--
nosy: +anthonypjshaw
___
Python tracker
anthony shaw added the comment:
Revisiting this issue as it's still open. The original patch was for 3.3a0,
there have been many changes to both IDLE and the Windows build since,
including the recent IDLE entry point in the new Windows installer.
Steve, Terry, please could you revi
anthony shaw added the comment:
The assertions in the attached test still fail on master (3.8a3), so this still
applies.
Michael, are you able to look at this, the code hasn't changed since the
original PEP417 implementation, which doesn't specify if this behaviour should
be
Change by anthony shaw :
--
keywords: +patch
pull_requests: +13050
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue24939>
___
___
Py
anthony shaw added the comment:
Eric, there have been further changes to Objects/stringlib/unicode_format.h
since this original note, I've raised a PR with the intent of your note from
2015.
There also hasn't been any change to the situation, unicode_format.h is onl
anthony shaw added the comment:
> The things that are in this file but are unrelated to unicodeobject.c
are the support routines for implementing string.Formatter.
I'm not sure which functions that relates to, if you could let me know I'd be
happy to add th
Change by anthony shaw :
--
assignee: docs@python -> Mariatta
nosy: +Mariatta
___
Python tracker
<https://bugs.python.org/issue33971>
___
___
Python-bugs-lis
anthony shaw added the comment:
NB: This issue would be good for PyCon sprints
--
nosy: +anthonypjshaw
___
Python tracker
<https://bugs.python.org/issue33
anthony shaw added the comment:
hi, which version of Python were you using to do this? Please could you provide
the full code snippet to reproduce the issue.
The following example binds to the correct namespace
from socket import *
sock = socket(AF_UNIX, SOCK_STREAM)
sock.bind(&qu
Change by anthony shaw :
--
pull_requests: -9605
___
Python tracker
<https://bugs.python.org/issue32971>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by anthony shaw :
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue32971>
___
___
Pyth
Change by anthony shaw :
--
nosy: +giampaolo.rodola
___
Python tracker
<https://bugs.python.org/issue34368>
___
___
Python-bugs-list mailing list
Unsubscribe:
anthony shaw added the comment:
The code is mostly:
FieldNameIterator * related functions
FormatterIterator * related functions
MarkupIterator * related functions
There are a few other utility methods in there as well
--
___
Python tracker
Change by anthony shaw :
--
pull_requests: +13053
___
Python tracker
<https://bugs.python.org/issue31968>
___
___
Python-bugs-list mailing list
Unsubscribe:
anthony shaw added the comment:
Added a PR for the documentation clarification.
--
nosy: +anthonypjshaw
___
Python tracker
<https://bugs.python.org/issue31
anthony shaw added the comment:
Hi Nofar are you still interested on working on this request?
--
nosy: +anthonypjshaw
___
Python tracker
<https://bugs.python.org/issue28
anthony shaw added the comment:
Closing as 3rd party feature for setuptools
--
nosy: +anthonypjshaw
resolution: -> third party
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
anthony shaw added the comment:
It would be great for this issue to be revisited, there has been some further
interest from users.
--
nosy: +anthonypjshaw
___
Python tracker
<https://bugs.python.org/issue27
Change by anthony shaw :
--
pull_requests: +13055
___
Python tracker
<https://bugs.python.org/issue28367>
___
___
Python-bugs-list mailing list
Unsubscribe:
anthony shaw added the comment:
Converted the original patch as a PR GH-13142 this seems like a good idea and
an easy change
--
nosy: +anthonypjshaw
___
Python tracker
<https://bugs.python.org/issue28
New submission from anthony shaw :
I noticed that the termios.c module is largely untested.
There is some coverage via test_pty, test_ioctl and test_getpass, but there is
nothing to cover regression and the behaviours in the module functions.
Tests are required for:
- termios.tcgetattr
anthony shaw added the comment:
This could be a good issue for the PyCon sprints, otherwise I'm happy to
implement it
--
___
Python tracker
<https://bugs.python.org/is
anthony shaw added the comment:
Easily reproduced on master, thanks
(lldb) run encode_crash.py
Process 14743 launched: '/Users/anthonyshaw/repo/cpython/python.exe' (x86_64)
Objects/unicodeobject.c:448: _PyUnicode_CheckConsistency: Assertion
"((PyObject*)(op))->ob_type))
anthony shaw added the comment:
Verified on master
Python 3.8.0a3+ (heads/bpo-28367:373c7aa098, May 6 2019, 17:34:39)
[Clang 10.0.1 (clang-1001.0.46.4)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>>
Change by anthony shaw :
--
keywords: +patch
pull_requests: +13057
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue36814>
___
___
Py
anthony shaw added the comment:
Raised a fix in GH-13144
--
stage: patch review ->
___
Python tracker
<https://bugs.python.org/issue36814>
___
___
Python-
anthony shaw added the comment:
Issue is in parse_file_actions
parse_file_actions(PyObject *file_actions,
posix_spawn_file_actions_t *file_actionsp,
PyObject *temp_buffer)
{
PyObject *seq;
PyObject *file_action = NULL;
PyObject *tag_obj
anthony shaw added the comment:
After patch:
Python 3.8.0a3+ (heads/31968-dirty:c664b342a4, May 6 2019, 18:06:21)
[Clang 10.0.1 (clang-1001.0.46.4)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>>
New submission from Anthony Sottile :
This appears to be a regression between 3.8a3 and 3.8a4 -- though it may be
intentional and I'm missing something?
I noticed this while packaging 3.8 for deadsnakes
https://github.com/deadsnakes/python3.8
I've created a minimal reproductio
Anthony Sottile added the comment:
+vstinner
Hmmm, actually the relevant commit appears to be
6c44fde3e03079e0c69f823dafbe04af50b5bd0d and intentional
(I ran a git bisect to find this!)
https://github.com/python/cpython/pull/12931
Does PEP 3149 require an update with this change, it still
Anthony Sottile added the comment:
seems intentional => closing
--
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
anthony shaw added the comment:
Hi,
This discussion came to a stop, but it doesn't seem conclusive.
PEP discussions are now in GitHub on https://github.com/python/peps/issues so
I'm going to close this BPO issue.
There is no additional section in PEP 7 for this level of detail
anthony shaw added the comment:
thanks, will wait for a review from Serhiy, Rbcollins or ezio
--
___
Python tracker
<https://bugs.python.org/issue24263>
___
___
Change by anthony shaw :
--
keywords: +patch
pull_requests: +13126
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue36862>
___
___
Py
New submission from anthony shaw :
The PCBuild tool should support VS2019 but default to 2017 as per documentation.
PR to follow.
--
assignee: anthonypjshaw
components: Build
messages: 341963
nosy: anthonypjshaw
priority: normal
severity: normal
status: open
title: Add Visual Studio
Change by anthony shaw :
--
nosy: +steve.dower
stage: patch review ->
___
Python tracker
<https://bugs.python.org/issue36862>
___
___
Python-bugs-list mai
Change by anthony shaw :
--
assignee: -> anthonypjshaw
nosy: +anthonypjshaw
___
Python tracker
<https://bugs.python.org/issue36551>
___
___
Python-bugs-lis
Change by anthony shaw :
--
assignee: -> anthonypjshaw
nosy: +anthonypjshaw
___
Python tracker
<https://bugs.python.org/issue36552>
___
___
Python-bugs-lis
Change by anthony shaw :
--
assignee: -> anthonypjshaw
nosy: +anthonypjshaw
___
Python tracker
<https://bugs.python.org/issue36500>
___
___
Python-bugs-lis
Change by anthony shaw :
--
nosy: +anthonypjshaw
___
Python tracker
<https://bugs.python.org/issue35668>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by anthony shaw :
--
resolution: -> rejected
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
anthony shaw added the comment:
thanks, your code example zero-pads the socket address, and looking at the
socketmodule.c code it does some padding under certain circumstances.
https://github.com/python/cpython/blob/master/Modules/socketmodule.c#L1318-L1330
The Unix man page specify the same
Change by anthony shaw :
--
versions: +Python 3.8 -Python 2.7, Python 3.4, Python 3.7
___
Python tracker
<https://bugs.python.org/issue25541>
___
___
Python-bug
anthony shaw added the comment:
The existing tests in place add the null-termination bytes in the test string:
def testLinuxAbstractNamespace(self):
address = b"\x00python-test-hello\x00\xff"
with socket.socket(socket.AF_UNIX, socket.SOCK_STREAM) as s1:
anthony shaw added the comment:
Closing as duplicate of 36882
--
nosy: +anthonypjshaw
___
Python tracker
<https://bugs.python.org/issue36883>
___
___
Python-bug
Change by anthony shaw :
--
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue36883>
___
___
Python-bugs-list
anthony shaw added the comment:
"When the C library is called in ctypes to return the c_char_p type, the
problem that only the string before \0 can be obtained when the string contains
\\0"
This function is specifically for null-terminated strings (\0), please could
you be mor
anthony shaw added the comment:
Thanks, I'll check this out
--
assignee: -> anthonypjshaw
nosy: +anthonypjshaw
___
Python tracker
<https://bugs.python.org
anthony shaw added the comment:
The documentation says:
>>
Note Make sure you keep references to CFUNCTYPE() objects as long as they are
used from C code. ctypes doesn’t, and if you don’t, they may be garbage
collected, crashing your program when a callback is made.
Also, note that
anthony shaw added the comment:
>From lldb
(lldb) run ~/cpython/test_gc_ctypes.py
Process 20059 launched: '/Users/anthonyshaw/CLionProjects/cpython/python.exe'
(x86_64)
Fatal Python error: deallocating None
Current thread 0x0001005c85c0 (most recent call first):
anthony shaw added the comment:
Full trace for reference:
(lldb) bt all
* thread #1, queue = 'com.apple.main-thread', stop reason = signal SIGABRT
* frame #0: 0x7fff5984f2c6 libsystem_kernel.dylib`__pthread_kill + 10
frame #1: 0x7fff59904bf1 libsystem_pthread.dylib`pt
anthony shaw added the comment:
In the stack it's calling none_dealloc() which should never happen.
Assume this is being triggered by ctypes PyCFuncPtr_call.
The stacktrace I'm getting comes after the double decref so it's not showing
the root cause. Someone who knows ctypes
anthony shaw added the comment:
Thanks Eryk that saved a lot of debugging.
dgelessus - if you want to write a patch for CPython am happy to take you
through this and get it over the line.
Else: am Happy to write a test against the gc counter and a patch for this
anthony shaw added the comment:
If you can write a test similar to the AnotherLeak.test_callback test case, and
commit that first.
It will show in the CI/CD log as failed and verify the issue (incase it comes
up in PR review)
Then add another commit with the patch itself and we should see
New submission from Anthony Sottile :
More fallout from the Constant change in https://bugs.python.org/issue32892
minimal reproduction:
import ast
class V(ast.NodeVisitor):
def visit_Str(self, node):
print(node.s)
def main():
V().visit(ast.parse('x = "hi"&#
Anthony Sottile added the comment:
wrong bpo, this is the right one: https://bugs.python.org/issue32892
--
___
Python tracker
<https://bugs.python.org/issue36
Anthony Sottile added the comment:
hitting this in https://bugs.python.org/issue36917?
Is the simplification here really worth the breaking change to consumers?
I now have to write something that's essentially this to work around this which
feels more like the complexity has just
Anthony Sottile added the comment:
There would still be a breakage for that if someone was defining py36+
`visit_Constant` (which would clobber the `ast.NodeVisitor.visit_Constant` if
we were to add it)
--
___
Python tracker
<ht
Anthony Sottile added the comment:
spent some more time thinking about this and I think we should strongly
consider reverting. simplification in the core interpreter should not be
weighed lightly against complexity and breaking changes for users.
the change is also unfortunate because it
Anthony Sottile added the comment:
The simplest case is just the addition of an `isinstance` check:
https://github.com/asottile/dead/blob/85f5edbb84b5e118beab4be3346a630e41418a02/dead.py#L165-L170
class V(ast.NodeVisitor):
def visit_Str(self, node):
...
def visit_Constant
Anthony Sottile added the comment:
> You can not use the same implementation of the visitor for Num, Str,
> NameConstant and Ellipsis, because all these classes use different attribute
> for saving the value
ah yes, this is true -- maybe the better change would be to just add `
New submission from Anthony Sottile :
On windows, a deep path can be accessed by prefixing the path with \\?\
https://msdn.microsoft.com/en-us/library/windows/desktop/aa365247(v=vs.85).aspx?f=255&MSPPError=-2147217396#maxpath
The call to `listdir()` fails because it uses a posix separator
Change by Anthony Sottile :
--
keywords: +patch
pull_requests: +5023
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue32539>
___
___
Py
New submission from Anthony Flury :
The first example given for collections.Counter is misleading - the
documentation ideally should show the 'best' (one and only one) way to do
something and the example is this :
>>> # Tally occurrences of words in a list
>>> cnt
Anthony Flury added the comment:
Raymond,
I completely understand your comment but I do disagree.
My view would be that the documentation of the stdlib should document the entry
level use cases.
The first example given uses nothing special from the Counter class - you could
implement
Anthony Flury added the comment:
Cheryl :
When you iterate around a counter instance it does return keys in the order
they are first encountered/inserted - so I agree with you that it is an ordered
collection from Python 3.7 onwards (although the iteration and the repr are
ordered in
Anthony Sottile added the comment:
Seeing this as well when running the cpython test suite in docker:
```
$ ./python -m test.test_asyncio
...
[18 similar traces omitted]
==
ERROR: test_sock_sendfile_zero_size
Anthony Sottile added the comment:
Actually, my issue seems to be something more strange.
The host being passed in is `localhost` which resolves to:
```
>>> pprint.pprint(socket.getaddrinfo('localhost', 80))
[(,
,
6,
'',
('127.0.0.1', 80)),
Anthony Sottile added the comment:
Applying this patch makes the tests pass for me, but I don't think the patch is
appropriate (just hides the bug):
```
$ git diff
diff --git a/Lib/test/test_asyncio/test_unix_events.py
b/Lib/test/test_asyncio/test_unix_events.py
index 5bd76d3..ff6c4e1 1
New submission from Anthony Flury :
Using the unittest.mock helper mock_open with multi-line read data, although
readlines method will work on the mocked open data, the commonly used iterator
idiom on an open file returns the equivalent of an empty file.
from unittest.mock import
Change by Anthony Flury :
--
type: -> behavior
___
Python tracker
<https://bugs.python.org/issue32933>
___
___
Python-bugs-list mailing list
Unsubscrib
Anthony Sottile added the comment:
Still a problem in 3.7:
$ python3.7
Python 3.7.0b2 (default, Feb 28 2018, 06:59:18)
[GCC 5.4.0 20160609] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import ast
&g
Change by Anthony Flury :
--
keywords: +patch
pull_requests: +5740
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue32933>
___
___
Py
Change by Anthony Flury :
--
pull_requests: +5741
___
Python tracker
<https://bugs.python.org/issue32933>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Anthony Flury :
--
pull_requests: +5742
___
Python tracker
<https://bugs.python.org/issue32933>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Anthony Flury :
--
pull_requests: +5743
___
Python tracker
<https://bugs.python.org/issue32933>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Anthony Flury :
--
keywords: +patch
pull_requests: +5748
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Anthony Flury :
--
keywords: +patch
pull_requests: +5782
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue33006>
___
___
Py
Change by Anthony Sottile :
--
pull_requests: +5909
___
Python tracker
<https://bugs.python.org/issue31550>
___
___
Python-bugs-list mailing list
Unsubscribe:
Anthony Sottile added the comment:
I made a new PR which instead *reverts* the python2.7 patch to restore
consistency
--
___
Python tracker
<https://bugs.python.org/issue31
Anthony Sottile added the comment:
I think the main concern here is ease in portability coupled with the
incorrectness of the current message (pointed out in
https://bugs.python.org/issue31550#msg302738)
For instance it was consistent in 2.7.1, but not later on in the 2.7.x tree.
*And
Anthony Sottile added the comment:
The intention of the change in issue 26510 was to pick the least surprising
behaviour for the default value of subparsers -- the compatiblity with the
behaviour before the regression was introduced in 3.3 was a nice side-effect.
As with the rest of
Anthony Sottile added the comment:
Grabbed the wrong SO link, I believe this is the one I meant to link to:
https://stackoverflow.com/a/18283730/812183
--
___
Python tracker
<https://bugs.python.org/issue33
Anthony Sottile added the comment:
Yeah, I picked the default value `True` because I couldn't actually find a user
of subparsers that _wanted_ optional subparsers. ¯\_(ツ)_/¯
--
___
Python tracker
<https://bugs.python.org/is
Anthony Flury added the comment:
No - it isn't related.
In the case of mock_open; it isn't intended to be a simple MagicMock - it is
meant to be a mocked version of open, and so to be useful as a testing tool, it
should emulate a file as much as possible.
When a mock_open is cr
Anthony Flury added the comment:
Strictly speaking the official Python2 reference document isn't a great example
- for instance:
' If function is None, the identity function is assumed, that is, all elements
of iterable that are false are removed.'
Implies that items are r
New submission from anthony shaw :
observing a behaviour on Python 3.7 b2 that doesn't match what's documented in
PEP 538
PEP 538 states that the locale coercion behaviour can be disabled through the
PYTHONCOERCECLOCALE environment variable.
I would then expect the stdin encoding
Anthony Sottile added the comment:
According to the other bugs, the change in 3.3 was an inadvertent regression.
The fact that it didn't get fixed for so long is mostly due to the unmaintained
state of argparse in the stdlib. The change in behaviour here is the _fix_ of
that regre
Anthony Sottile added the comment:
Shouldn't you wait for Raymond's arguments before outright closing the PR?
--
___
Python tracker
<https://bugs.python.o
New submission from Anthony Flury :
In the Python version pull down list on docs.python.org, Python3.5 used to be
listed, but has now been removed; the list only contains 2.7, 3.6 & 3.7.
Python 3.5 is still the official Python 3.5 release in the Ubuntu repository,
and still a suppo
Anthony Flury added the comment:
Isn't Python 2.7 in Security Fix only as well ?
It seems strange; Python 3.5 probably the most heavily installed Python 3
release (every Ubuntu installation has Python 3.5 installed by default - and
neither Python 3.6 or 3.7 are available from the sta
New submission from Anthony Sottile :
Fortunately, this can be reproduced with the testsuite:
```
==
ERROR: test_copystat_symlinks (__main__.TestShutil
Anthony Sottile added the comment:
Here's one idea for a patch (inspired by the rest of the function):
```
diff --git a/Lib/shutil.py b/Lib/shutil.py
index 464ee91..2099289 100644
--- a/Lib/shutil.py
+++ b/Lib/shutil.py
@@ -213,6 +213,13 @@ def copystat(src, dst, *, follow_symlinks
Change by Anthony Sottile :
--
keywords: +patch
pull_requests: +4230
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue31940>
___
___
Py
Change by Anthony Sottile :
--
pull_requests: +4684
___
Python tracker
<https://bugs.python.org/issue31940>
___
___
Python-bugs-list mailing list
Unsubscribe:
501 - 600 of 738 matches
Mail list logo
