[issue5109] array.array constructor very slow when passed an array object.

2011-01-11 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Georg, Is it too late to commit this for 3.2? -- nosy: +georg.brandl ___ Python tracker <http://bugs.python.org/issue5

[issue9860] Building python outside of source directory fails

2011-01-11 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Here is a related bug: $ make patchcheck ./python.exe ../py3k-commit/Tools/scripts/patchcheck.py Getting the list of files that have been added/changed ... need a checkout to get modified files [49399 refs] make: *** [patchcheck] Error 1

[issue9305] Don't use east/west of UTC in date/time documentation

2011-01-11 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: I've noticed that the time module docstring handles this issue rather nicely: >>> help('time') ... timezone -- difference in seconds between UTC and local standard time altzone -- difference in seconds between UTC and lo

[issue7229] Manual entry for time.daylight can be misleading

2011-01-11 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: On Tue, Jan 11, 2011 at 11:20 AM, Tomas Kubes wrote: .. > You should try to think like a person that does not have any background > knowledge of underlying libraries but > just looks through the time library trying to solve the question -

[issue7229] Manual entry for time.daylight can be misleading

2011-01-11 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: On Tue, Jan 11, 2011 at 1:56 PM, Georg Brandl wrote: .. > It seems to me that the quoted function from bzr ... > would be very helpful to add to the `time` module docs as an example. The problem with this function is the same as with the doc p

[issue7229] Manual entry for time.daylight can be misleading

2011-01-11 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: On Tue, Jan 11, 2011 at 4:15 PM, anatoly techtonik wrote: .. > To summarize: What is wrong with my previous proposal if we remove t > from params? Not much is wrong with it. If it would come in a form of a patch and without typos or mark-up mi

[issue5109] array.array constructor very slow when passed an array object.

2011-01-11 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Committed in revision 87942. @Georg: Yes, I ran coverage and all branches are covered. @Meador: I don't think the old len calculation could handle the case of array object in initial. In any case, I don't find the new code much more compli

[issue5109] array.array constructor very slow when passed an array object.

2011-01-11 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Committed to 2.7 in revision 87944. -- stage: commit review -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python.org/

[issue5109] array.array constructor very slow when passed an array object.

2011-01-11 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Reverted backport in r87945. -- versions: -Python 2.7 ___ Python tracker <http://bugs.python.org/issue5109> ___ ___ Pytho

[issue8957] strptime('%c', ..) fails to parse output of strftime('%c', ..) in non-English locale

2011-01-11 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: > time.strptime(s, '%c' ) ? Oh my. It certainly took a long time to recognize a silly mistake! Thanks. -- dependencies: -Use locale.nl_langinfo in _strptime resolution: -> invalid __

[issue8957] strptime('%c', ..) fails to parse output of strftime('%c', ..) in non-English locale

2011-01-11 Thread Alexander Belopolsky
Changes by Alexander Belopolsky : -- status: open -> closed ___ Python tracker <http://bugs.python.org/issue8957> ___ ___ Python-bugs-list mailing list Un

[issue10225] Fix doctest runable examples in python manual

2011-01-11 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: On Tue, Jan 11, 2011 at 6:10 PM, Terry J. Reedy wrote: .. > Doctest runs on .rst files, which are plain text files, finds and reports > errors, and reports no errors when the errors are fixed. > See #10875 where is was very helpful. So your las

[issue8957] strptime('%c', ..) fails to parse output of strftime('%c', ..) in non-English locale

2011-01-11 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: My tests were wrong but the problem does exist. I am attaching a script that tests strptime(.., '%c') for all locales installed on my system (an unmodified US Mac OS X 10.6.6). The only failing locale that I recognize is Hebrew (he_IL).

[issue8957] strptime(.., '%c') fails to parse output of strftime('%c', ..) in some locales

2011-01-11 Thread Alexander Belopolsky
Changes by Alexander Belopolsky : -- title: strptime('%c', ..) fails to parse output of strftime('%c', ..) in non-English locale -> strptime(.., '%c') fails to parse output of strftime('%c', ..) in some locales __

[issue9419] RUNSHARED needs LDFLAGS

2011-01-11 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: > build outside source tree fail for me and pass for python > developers :). So no idea how to convince them to fix this issue. I am collecting out of tree build failures in issue 9860. One issue that is easily reproducible is triggered when the

[issue8957] strptime(.., '%c') fails to parse output of strftime('%c', ..) in some locales

2011-01-11 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: On Tue, Jan 11, 2011 at 7:26 PM, Roumen Petrov wrote: .. > - locales with %A and %B are broken on this platform as %c is "Appropriate > date and time representation (%c) with abbreviations" According to what standard? POSIX defines it

[issue7662] time.utcoffset()

2011-01-11 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: I am going to close this as superseded by #9527. All these issues, current, #9527, and #1647654 are really about Python's lack of access to the system timezone information and #9527 seem to be the most appropriate solution. My specific concern

[issue5516] equality not symmetric for subclasses of datetime.date and datetime.datetime

2011-01-11 Thread Alexander Belopolsky
Changes by Alexander Belopolsky : -- keywords: -patch ___ Python tracker <http://bugs.python.org/issue5516> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue10225] Fix doctest runable examples in python manual

2011-01-11 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: On Tue, Jan 11, 2011 at 10:03 PM, Terry J. Reedy wrote: .. > What is the alternative? I am attaching an alternative patch for sorting howto. You can run the doctests in it as follows: $ python2.7 tools/sphinx-build.py -b doctest -d build/doctr

[issue10225] Fix doctest runable examples in python manual

2011-01-12 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: I have updated Sphinx and rerun py3k doctests. It looks like the newest Sphinx does not check examples unless the file has a .. testsetup:: directive somewhere. This is nice because it focuses on the files that are clearly intended to be doctest

[issue10225] Fix doctest runable examples in python manual

2011-01-12 Thread Alexander Belopolsky
Changes by Alexander Belopolsky : Added file: http://bugs.python.org/file20376/issue10225-py3k.diff ___ Python tracker <http://bugs.python.org/issue10225> ___ ___ Pytho

[issue10225] Fix doctest runable examples in python manual

2011-01-12 Thread Alexander Belopolsky
Changes by Alexander Belopolsky : Removed file: http://bugs.python.org/file20375/issue10225-py3k.diff ___ Python tracker <http://bugs.python.org/issue10225> ___ ___ Pytho

[issue9941] Unify trace and profile interfaces

2011-01-12 Thread Alexander Belopolsky
Changes by Alexander Belopolsky : -- versions: +Python 3.3 -Python 3.2 ___ Python tracker <http://bugs.python.org/issue9941> ___ ___ Python-bugs-list mailin

[issue10225] Fix doctest runable examples in python manual

2011-01-12 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Committed the simple fixes in r87957. Updated the patch to include only the remaining changes. -- Added file: http://bugs.python.org/file20377/issue10225-py3k.diff ___ Python tracker <http://bugs.python.

[issue10225] Fix doctest runable examples in python manual

2011-01-12 Thread Alexander Belopolsky
Changes by Alexander Belopolsky : Removed file: http://bugs.python.org/file20376/issue10225-py3k.diff ___ Python tracker <http://bugs.python.org/issue10225> ___ ___ Pytho

[issue766910] fix one or two bugs in trace.py

2011-01-12 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: On Sat, Dec 4, 2010 at 3:34 AM, Eli Bendersky wrote: >.. > However, while experimenting, I think I ran into much larger problems. Either > that or I've forgotten > how to use the module :-) I am afraid it is the latter. :-) The

[issue766910] fix one or two bugs in trace.py

2011-01-12 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: On Wed, Jan 12, 2011 at 12:17 PM, Alexander Belopolsky wrote: .. > The counts should grow in repeated runs. I did not pay attention: the numbers in summary are numbers of lines, not execution counts. The execution counts in .cover file grow as expec

[issue766910] fix one or two bugs in trace.py

2011-01-12 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: On Sat, Dec 4, 2010 at 3:34 AM, Eli Bendersky wrote: .. > I reviewed the patch and ported the changes to the newest sources Eli, I don't think you ever posted an updated patch. Do you still have it? This may be a good starting issue for

[issue9268] Document annotation option to pickletools.dis

2011-01-13 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Committed documentation changes in revision 87990. -- resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python.o

[issue6697] Check that _PyUnicode_AsString() result is not NULL

2011-01-13 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: I am replacing issue6697-lsprof.diff with a (hopefully) more carefully written version that addresses the issues that Victor noted. Victor, I take your comment as +1 for adding PyModule_GetNameObject(). I started looking into adding unit tests that

[issue6697] Check that _PyUnicode_AsString() result is not NULL

2011-01-13 Thread Alexander Belopolsky
Changes by Alexander Belopolsky : Removed file: http://bugs.python.org/file19980/issue6697-lsprof.diff ___ Python tracker <http://bugs.python.org/issue6697> ___ ___ Pytho

[issue7662] time.utcoffset()

2011-01-13 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Just to clarify: Anatoly changed the resolution, not status (and I agree that was not appropriate.) The status was set to "pending" and that would change to "open" automatically if a new comment is posted. As for the substance of

[issue1647654] No obvious and correct way to get the time zone offset

2011-01-13 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Closing this in favor of #9527. See msg126064 for more details. -- stage: patch review -> committed/rejected ___ Python tracker <http://bugs.python.org/issue1

[issue6083] Reference counting bug in PyArg_ParseTuple and PyArg_ParseTupleAndKeywords

2011-01-13 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Let me summarize the issue: the PyArg_ParseTuple format code 'O' returns a borrowed reference. However, when the 'O' code appears inside parenthesis, there may not be an object to hold the reference to borrow from. This is what

[issue6083] Reference counting bug in PyArg_ParseTuple and PyArg_ParseTupleAndKeywords

2011-01-13 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Attached patch passes the regrtest and makes test-functools.py raise an exception rather than crash. The proposed change will make functions like partial.__setstate__ require tuple argument even though currently it would accept any container. This is

[issue10904] PYTHONIOENCODING is not in manpage

2011-01-14 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: What "manpage" are you reporting? In py3k branch, $ groff -Tascii -man Misc/python.man .. PYTHONIOENCODING If this is set before running the interpreter, it overrides the encoding used for stdin/stdout/

[issue10904] PYTHONIOENCODING is not in manpage

2011-01-14 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: On the second thought, maybe "de manpage" is not a misspelling of "the manpage", but a reference to a German locale manpage? I don't think python.org releases include manpage translations. You may need to report

[issue9527] Add aware local time support to datetime module

2011-01-14 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Following Anatoly's review, I renamed datetime argument and a local variable, added comments and expanded docstring. I am uploading a new patch: datetime-localtime-proto-1.diff. Martin, I could not figure out how to add the new patch to rietveld

[issue9527] Add aware local time support to datetime module (issue9527)

2011-01-14 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Forwarding Rietveld conversation to the tracker. It looks like Rietveld integration has a bug and sends reviews to n...@psf.upfronthosting.co.za rather than to rep...@bugs.python.org. Forwarded conversation Subject: Add aware local time support to

[issue9527] Add aware local time support to datetime module

2011-01-14 Thread Alexander Belopolsky
Changes by Alexander Belopolsky : -- title: Add aware local time support to datetime module (issue9527) -> Add aware local time support to datetime module ___ Python tracker <http://bugs.python.org/iss

[issue10908] Improvements to trace._Ignore

2011-01-15 Thread Alexander Belopolsky
Changes by Alexander Belopolsky : -- nosy: +eli.bendersky ___ Python tracker <http://bugs.python.org/issue10908> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue8957] strptime(.., '%c') fails to parse output of strftime('%c', ..) in some locales

2011-01-15 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: On Sat, Jan 15, 2011 at 2:20 AM, Eli Bendersky wrote: .. > This solution is a hack, but so is the whole __calc_date_time function :-) > [IMHO] > I am not sure how to proceed. On one hand, I opened this issue to demonstrate that th

[issue8957] strptime(.., '%c') fails to parse output of strftime('%c', ..) in some locales

2011-01-15 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: 6. datetime.find(self.f_month[m]) >= 0 -> self.f_month[m] in datetime Python is not C! -- ___ Python tracker <http://bugs.python.org/

[issue8957] strptime(.., '%c') fails to parse output of strftime('%c', ..) in some locales

2011-01-15 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: You pretty much hit the nail on the head. Some platforms don't have strptime or did not have it at the time this code was written. The locale module is probably more recent than this code as well. -- nosy: +Alexander.Belop

[issue10921] imaplib: Internaldate2tuple() crashes, does not handle negative TZ offsets, does not handle DST correctly

2011-01-17 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: > 1. It crashes with "KeyError". ... I assume this means it raises a KeyError when given a bytes object as an argument. >>> Internaldate2tuple(b'INTERNALDATE "01-Jan-2000 12:00:00 +"') Traceback (mos

[issue4892] Sending Connection-objects over multiprocessing connections fails

2011-01-17 Thread Tim Alexander
Tim Alexander added the comment: Wanted to quickly comment here, as I'm dealing with this issue as well, that I did find a workaround for avoiding it as far back as 2.6 (and it's not "don't pass a Pipe through a Pipe") multiprocessing.reduction can already do this

[issue10921] imaplib: Internaldate2tuple() string/bytes issues, does not handle negative TZ offsets, does not handle DST correctly

2011-01-17 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: There are at least 3 issues here: a documentation issue, a py3k bug and at least one feature request. Given that the logistics are different for different kinds of issues, I think it would be best to split them on the tracker. Here is how I see what

[issue10921] imaplib: Internaldate2tuple() string/bytes issues, does not handle negative TZ offsets, does not handle DST correctly

2011-01-19 Thread Alexander Belopolsky
Changes by Alexander Belopolsky : -- resolution: -> duplicate stage: unit test needed -> committed/rejected superseder: -> imaplib: Internaldate2tuple() is documented to return UTC, but it returns local time ___ Python track

[issue10934] imaplib: Internaldate2tuple() is documented to return UTC, but it returns local time

2011-01-19 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: It makes sense that Internaldate2tuple() returns local time because timetuple (with its tm_isdst flag) strongly suggests local time. (See also issue 9004.) If UTC or any other timezone time is needed, it would be best to provide a function that would

[issue10934] imaplib: Internaldate2tuple() is documented to return UTC, but it returns local time

2011-01-19 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Committed in revision 88114. -- ___ Python tracker <http://bugs.python.org/issue10934> ___ ___ Python-bugs-list mailin

[issue10934] imaplib: Internaldate2tuple() is documented to return UTC, but it returns local time

2011-01-19 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Merged to 2.7 in revision 88116. -- stage: commit review -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python.org/i

[issue10939] imaplib: Internaldate2tuple raises KeyError parsing month and does not work with negative TZ offset due to bytes/str issues

2011-01-19 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Georg, This is an obvious artifact of an untested py3k port. Can this go in 3.2? The patch looks good except for a long line in the test which I can take care of. -- assignee: -> belopolsky nosy: +belopolsky, georg.brandl stage: ->

[issue10941] imaplib: Internaldate2tuple produces wrong result if date is near a DST change

2011-01-19 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: I agree that this is a bug and the solution is right, I am not sure this should be applied during RC period. The bug has been present and known for a long time, so affected parties probably have a work-around in place already. -- nosy

[issue10947] imaplib: Internaldate2tuple and ParseFlags require (and latter returns) bytes arrays; should allow/return str

2011-01-19 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: David, Can you weigh in on this? I am -1 on improving Internaldate2tuple(). I think the module should provide a function that would return an aware datetime object instead of a timetuple. The proposed patch will make error reporting from

[issue10947] imaplib: Internaldate2tuple and ParseFlags require (and latter returns) bytes arrays; should allow/return str

2011-01-19 Thread Alexander Belopolsky
Changes by Alexander Belopolsky : -- stage: -> patch review ___ Python tracker <http://bugs.python.org/issue10947> ___ ___ Python-bugs-list mailing list Un

[issue10952] Don't normalize module names to NFKC?

2011-01-19 Thread Alexander Belopolsky
Changes by Alexander Belopolsky : -- nosy: +belopolsky ___ Python tracker <http://bugs.python.org/issue10952> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue10952] Don't normalize module names to NFKC?

2011-01-19 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: This proposal makes sense because it would make import µTorrent behave the same as µTorrent = __import__('µTorrent') However, I think this is a feature request and a language change because the current grammar is import_stmt ::= "

[issue10952] Don't normalize module names to NFKC?

2011-01-19 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: On Wed, Jan 19, 2011 at 9:21 PM, STINNER Victor wrote: .. > New problem: if the parser doesn't normalize module names on import, it does > still > normalize module names on other instructions. > > Example: "import \xB5Torrent; d

[issue10952] Don't normalize module names to NFKC?

2011-01-19 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Victor> Ok, I think that it is possible. While it is possible, I am not sure it is a good idea. For example, if a filesystem uses encoding that is capable of distinguishing between "\xB5Torrent.py" and "\u03BCTorrent.py", sho

[issue3080] Full unicode import system

2011-01-19 Thread Alexander Belopolsky
Changes by Alexander Belopolsky : -- nosy: +belopolsky ___ Python tracker <http://bugs.python.org/issue3080> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue10953] safely eval serialized dict/list data from arbitrary string over web with no side effects

2011-01-19 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: > rather than serialize python dicts & list to json ... > its more efficient to just serialize w/ repr() & then use eval() Do you have benchmarks that support this claim? -- nosy: +belopolsky versions

[issue10952] Don't normalize module names to NFKC?

2011-01-19 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: On Thu, Jan 20, 2011 at 1:19 AM, Martin v. Löwis wrote: .. > I'd like to request that PEP 3131 is followed as it stands: identifier lookup > uses NFKC, > period. This gives two issues: a) how can users make sure that they name the >

[issue10952] Don't normalize module names to NFKC?

2011-01-20 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: On Thu, Jan 20, 2011 at 8:06 AM, STINNER Victor wrote: .. >> There is also issue c) what if the filesystem encoding can only >> represent a compatibility character, say U+00B5, but not its NFKC >> equivalent, U+03BC? > > It is t

[issue4819] Misc/cheatsheet needs updating

2011-01-20 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Misc/cheatsheet has been removed in r88127. Should this be closed? -- ___ Python tracker <http://bugs.python.org/issue4

[issue4819] Misc/cheatsheet needs updating

2011-01-20 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: FWIW, I updated the first couple of pages. If anyone finds my changes useful, here they are in issue4819.diff. -- keywords: +patch Added file: http://bugs.python.org/file20476/issue4819.diff ___ Python

[issue10968] Timer class inheritance issue

2011-01-20 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Works for me: >>> from timeit import Timer >>> class A(Timer): pass ... (Tested with Python 3.1 and 3.2 on OSX.) -- nosy: +belopolsky ___ Python tracker <http://bugs.

[issue10947] imaplib: Internaldate2tuple and ParseFlags require (and latter returns) bytes arrays; should allow/return str

2011-01-20 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: On Thu, Jan 20, 2011 at 10:08 PM, R. David Murray wrote: .. > (*) The asymetry in the names of these two functions is already a wart. Not to mention the use of CamelCase. -- ___ Python tracker &l

[issue10572] Move test sub-packages to Lib/test

2011-01-25 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Changing the title to reflect broader scope of this issue. Json tests were moved to Lib/test/json_tests in r86875. -- title: Move unittest test package to Lib/test -> Move test sub-packages to Lib/t

[issue11024] imaplib: Time2Internaldate() returns localized strings

2011-01-28 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Two nitpicks: 1. To avoid repetition, I would now define Mon2num as Mon2num = dict(zip(_month_names, range(1, 13))) 2. Please keep lines under 79 characters long. This does not seem important enough to push to RC2, but if you think otherwise please

[issue11024] imaplib: Time2Internaldate() returns localized strings

2011-01-28 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Also, isn't day supposed to be space- rather than 0- padded? -- ___ Python tracker <http://bugs.python.org/is

[issue11024] imaplib: Time2Internaldate() returns localized strings

2011-01-28 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: On Fri, Jan 28, 2011 at 2:44 PM, Alexander Belopolsky wrote: .. > Also, isn't day supposed to be space- rather than 0- padded? To the best of my understanding, rfc 2060 requires space-padded day (strftime code %e): """ date_day_

[issue11024] imaplib: Time2Internaldate() returns localized strings

2011-01-28 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: I would write the formatting code as follows: ('"%2d-%s-%04d %02d:%02d:%02d %+03d%02d"' % ((tt[2], _month_names[tt[1]], tt[0]) + tt[3:6] + divmod(zone//60, 60))) The above also assumes that month names are stored in a 1-based

[issue10939] imaplib: Internaldate2tuple raises KeyError parsing month and does not work with negative TZ offset due to bytes/str issues

2011-01-28 Thread Alexander Belopolsky
Changes by Alexander Belopolsky : -- assignee: belopolsky -> georg.brandl ___ Python tracker <http://bugs.python.org/issue10939> ___ ___ Python-bugs-list mai

[issue10939] imaplib: Internaldate2tuple raises KeyError parsing month and does not work with negative TZ offset due to bytes/str issues

2011-01-29 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Attached patch fixes the test (hopefully we don't have to support systems with non-POSIX epoch) and cleans up whitespace. -- resolution: -> accepted stage: patch review -> commit review Added file: http://bugs.python.org/file20604

[issue10939] imaplib: Internaldate2tuple raises KeyError parsing month and does not work with negative TZ offset due to bytes/str issues

2011-01-29 Thread Alexander Belopolsky
Changes by Alexander Belopolsky : Removed file: http://bugs.python.org/file20604/issue10939.diff ___ Python tracker <http://bugs.python.org/issue10939> ___ ___ Python-bug

[issue10939] imaplib: Internaldate2tuple raises KeyError parsing month and does not work with negative TZ offset due to bytes/str issues

2011-01-29 Thread Alexander Belopolsky
Changes by Alexander Belopolsky : Added file: http://bugs.python.org/file20605/issue10939.diff ___ Python tracker <http://bugs.python.org/issue10939> ___ ___ Python-bug

[issue10939] imaplib: Internaldate2tuple raises KeyError parsing month and does not work with negative TZ offset due to bytes/str issues

2011-01-29 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Committed in revision 88231. -- ___ Python tracker <http://bugs.python.org/issue10939> ___ ___ Python-bugs-list mailin

[issue10939] imaplib: Internaldate2tuple raises KeyError parsing month and does not work with negative TZ offset due to bytes/str issues

2011-01-29 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Merged to 3.1 in r88233. -- nosy: +benjamin.peterson resolution: accepted -> fixed stage: commit review -> committed/rejected versions: +Python 3.1 ___ Python tracker <http://bugs.python.org/i

[issue10939] imaplib: Internaldate2tuple raises KeyError parsing month and does not work with negative TZ offset due to bytes/str issues

2011-01-29 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: It looks like my test is not robust enough: http://www.python.org/dev/buildbot/all/builders/x86%20OpenIndiana%203.1/builds/298 -- ___ Python tracker <http://bugs.python.org/issue10

[issue10939] imaplib: Internaldate2tuple raises KeyError parsing month and does not work with negative TZ offset due to bytes/str issues

2011-01-29 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Some systems don't like times too close to epoch. Fixed in revision 88239. -- ___ Python tracker <http://bugs.python.org/is

[issue10939] imaplib: Internaldate2tuple raises KeyError parsing month and does not work with negative TZ offset due to bytes/str issues

2011-01-29 Thread Alexander Belopolsky
Changes by Alexander Belopolsky : -- status: open -> closed ___ Python tracker <http://bugs.python.org/issue10939> ___ ___ Python-bugs-list mailing list Un

[issue10939] imaplib: Internaldate2tuple raises KeyError parsing month and does not work with negative TZ offset due to bytes/str issues

2011-01-29 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: On Sat, Jan 29, 2011 at 5:48 PM, Joe Peterson wrote: .. > Note that this also exposes another problem with Time2Internaldate(), since > it uses > time.timezone/time.altzone, which are only valid for the current rules, not > old rules as i

[issue9527] Add aware local time support to datetime module

2011-01-29 Thread Alexander Belopolsky
Changes by Alexander Belopolsky : -- dependencies: +Time zone-capable variant of time.localtime ___ Python tracker <http://bugs.python.org/issue9527> ___ ___ Pytho

[issue9527] Add aware local time support to datetime module

2011-01-29 Thread Alexander Belopolsky
Changes by Alexander Belopolsky : -- dependencies: +No obvious and correct way to get the time zone offset ___ Python tracker <http://bugs.python.org/issue9

[issue1667546] Time zone-capable variant of time.localtime

2011-01-29 Thread Alexander Belopolsky
Changes by Alexander Belopolsky : -- status: open -> closed ___ Python tracker <http://bugs.python.org/issue1667546> ___ ___ Python-bugs-list mailing list Un

[issue1647654] No obvious and correct way to get the time zone offset

2011-01-29 Thread Alexander Belopolsky
Changes by Alexander Belopolsky : -- status: open -> closed ___ Python tracker <http://bugs.python.org/issue1647654> ___ ___ Python-bugs-list mailing list Un

[issue10941] imaplib: Internaldate2tuple produces wrong result if date is near a DST change

2011-01-29 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: On Sat, Jan 29, 2011 at 4:45 PM, Joe Peterson wrote: .. > I have added code that sets the TZ to one that works, and then reverts the > temporary > TZ change after the test. > Your test will not restore TZ if it fails. This is not nice.

[issue9527] Add aware local time support to datetime module

2011-01-29 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: On Sat, Jan 29, 2011 at 11:56 PM, Raymond Hettinger wrote: .. > Also, I question whether the proposed API is correct.  ISTM that any code > that sets the *dst* > parameter is guaranteed to be wrong (hardwiring-in a value that will change &g

[issue11048] "import ctypes" causes segfault on read-only filesystem

2011-01-30 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: It would be nice to add a unit test to this patch. I don't think messing with read-only filesystems is feasible in regrtest, but it seems from reading _ctypes_alloc_callback() source that similar behavior can be triggered by passing a fa

[issue11071] What's New review comments

2011-01-31 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Please consider mentioning that several modules can now be called with -m: pickle, pickletools and tkinter. -- nosy: +belopolsky ___ Python tracker <http://bugs.python.org/issue11

[issue8973] Inconsistent docstrings in struct module

2011-01-31 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: The proposed patch looks fine to me, but it is attached to the wrong issue. It belongs to #8973 or better yet to follow RC2 rules pedantically, it should be posted in a separate issue. This is important, because this issue is limited to docstrings and

[issue8973] Inconsistent docstrings in struct module

2011-01-31 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Wait, #8973 *is* this issue. But r81947 is clearly not about docstrings. We definitely need a saparate issue. This is too confusing. -- ___ Python tracker <http://bugs.python.org/issue8

[issue8973] Inconsistent docstrings in struct module

2011-01-31 Thread Alexander Belopolsky
Changes by Alexander Belopolsky : -- Removed message: http://bugs.python.org/msg127607 ___ Python tracker <http://bugs.python.org/issue8973> ___ ___ Python-bug

[issue8973] Inconsistent docstrings in struct module

2011-01-31 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: Wait, #8973 *is* this issue. But r81947 is clearly not only about docstrings. We definitely need a separate issue. This is too confusing. -- ___ Python tracker <http://bugs.python.org/issue8

[issue1252236] Simplying Tkinter's event loop

2011-01-31 Thread Alexander Belopolsky
Changes by Alexander Belopolsky : -- nosy: +PythonInTheGrass -BreamoreBoy resolution: wont fix -> status: closed -> open ___ Python tracker <http://bugs.python.org/iss

[issue11077] Tkinter is not thread safe

2011-01-31 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: One possible solution was presented in issue1252236: move tkinter event loop into Python main loop. However, to consider this report a bug, we need an example code that shows the behavior that you consider incorrect. Even then, it is likely that

[issue11078] Have test___all__ check for duplicates

2011-01-31 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: +1. This is a fairly common mistake. Usually benign, but as issue 8973 shows, may highlight a visible error. -- nosy: +belopolsky ___ Python tracker <http://bugs.python.org/issue11

[issue11078] Have test___all__ check for duplicates

2011-01-31 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: On Mon, Jan 31, 2011 at 12:09 PM, R. David Murray wrote: .. > On linux, the dups are putenv and unsetenv.  And yes, deeper investigation of > why > os.py is adding them is required to fix this :) Too bad __all__ cannot be specified

[issue11081] from struct import * misses pack_into

2011-01-31 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: I would say if anything can go in after rc2 at all, this should be accepted. George? I ran a few sanity checks with the patch applied: >>> set(struct.__all__) - set(dir(struct)) set() >>> set(dir(struct)) - set(struct.__all__) {'

[issue11078] Have test___all__ check for duplicates

2011-01-31 Thread Alexander Belopolsky
Changes by Alexander Belopolsky : -- dependencies: +from struct import * misses pack_into ___ Python tracker <http://bugs.python.org/issue11078> ___ ___ Python-bug

<    5   6   7   8   9   10   11   12   13   14   >