[issue643841] New class special method lookup change

2008-05-22 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: If it's so specialized then I'm not sure it should be in the stdlib - maybe as a private API, if there was a user. Having a reference implementation is noble, but this isn't the right way to do it. Maybe as an example in D

[issue643841] New class special method lookup change

2008-05-23 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: Surely remote proxies fall under what would be expected for a "proxy mixin"? If it's in the stdlib it should be a canonical implementation, NOT a reference implementation. At the moment I can think up 3 use cases: * weakre

[issue3001] RLock's are SLOW

2008-05-29 Thread Adam Olsen
Changes by Adam Olsen <[EMAIL PROTECTED]>: -- nosy: +Rhamphoryncus ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue3001> ___ __

[issue2507] Exception state lives too long in 3.0

2008-05-30 Thread Adam Olsen
Changes by Adam Olsen <[EMAIL PROTECTED]>: -- nosy: +Rhamphoryncus ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue2507> ___ __

[issue2833] __exit__ silences the active exception

2008-05-30 Thread Adam Olsen
Changes by Adam Olsen <[EMAIL PROTECTED]>: -- nosy: +Rhamphoryncus ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue2833> ___ __

[issue3021] Lexical exception handlers

2008-06-02 Thread Adam Olsen
Changes by Adam Olsen <[EMAIL PROTECTED]>: -- nosy: +Rhamphoryncus ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue3021> ___ __

[issue1758146] Crash in PyObject_Malloc

2008-06-03 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: Does the PythonInterpreter option create multiple interpreters within a single process, rather than spawning separate processes? IMO, that API should be ripped out. They aren't truly isolated interpreters and nobody I've asked

[issue1758146] Crash in PyObject_Malloc

2008-06-03 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: Right, so it's only the python modules loaded as part of the app that need to be isolated. You don't need the stdlib or any other part of the interpreter to be isolated. This could be done either by not using the normal import

[issue643841] New class special method lookup change

2008-06-05 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: The inplace operators aren't right for weakref proxies. If a new object is returned there likely won't be another reference to it and the weakref will promptly be cleared. This could be fixed with another property like _target,

[issue3042] Add PEP 8 compliant aliases to threading module

2008-06-05 Thread Adam Olsen
Changes by Adam Olsen <[EMAIL PROTECTED]>: -- nosy: +Rhamphoryncus ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue3042> ___ __

[issue3021] Lexical exception handlers

2008-06-06 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: PEP 3134's implicit exception chaining (if accepted) would require your semantic, and your semantic is simpler anyway (even if the implementation is non-trivial), so consider my objections to be dropped. PEP 3134 also proposes implic

[issue3021] Lexical exception handlers

2008-06-06 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: PEP 3134 gives reason to change it. __context__ should be set from whatever exception is "active" from the try/finally, thus it should be the inner block, not the outer except block. This flipping of behaviour, and the general a

[issue3021] Lexical exception handlers

2008-06-06 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: I agree, the argument for a syntax error is weak. It's more instinct than anything else. I don't think I'd be able to convince you unless Guido had the same instinct I do. ;) ___ P

[issue3070] Wrong size calculation in posix_execve

2008-06-09 Thread Adam Olsen
New submission from Adam Olsen <[EMAIL PROTECTED]>: In 2.x, the size of C string needed for an environment variable used by posix_execve was calculated using PyString_GetSize. In 3.0 this is translated to PyUnicode_GetSize. However, in 3.0 the C string is the UTF-8 encoded version

[issue2320] Race condition in subprocess using stdin

2008-06-10 Thread Adam Olsen
Changes by Adam Olsen <[EMAIL PROTECTED]>: -- nosy: +Rhamphoryncus ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue2320> ___ __

[issue1683] Thread local storage and PyGILState_* mucked up by os.fork()

2008-06-11 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: Updated version of roudkerk's patch. Adds the new function to pythread.h and is based off of current trunk. Note that Parser/intrcheck.c isn't used on my box, so it's completely untested. roudkerk's original analys

[issue1683] Thread local storage and PyGILState_* mucked up by os.fork()

2008-06-11 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: Incidentally, it doesn't seem necessary to reinitialize the lock. Posix duplicates the lock, so if you hold it when you fork your child will be able to unlock it and use it as normal. Maybe there's some non-Posix behaviour o

[issue3093] Namespace polution from multiprocessing

2008-06-12 Thread Adam Olsen
New submission from Adam Olsen <[EMAIL PROTECTED]>: All these in multiprocessing.h are lacking suitable py/_py/Py/_Py/PY/_PY prefixes: PyObject *mp_SetError(PyObject *Type, int num); extern PyObject *pickle_dumps; extern PyObject *pickle_loads; extern PyObject *pickle_protocol; extern Py

[issue3095] multiprocessing initializes flags dict unsafely

2008-06-12 Thread Adam Olsen
New submission from Adam Olsen <[EMAIL PROTECTED]>: multiprocessing.c currently has code like this: temp = PyDict_New(); if (!temp) return; if (PyModule_AddObject(module, "flags", temp) < 0) return; PyModule_Add

[issue3093] Namespace polution from multiprocessing

2008-06-12 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: The directory is irrelevant. C typically uses a flat namespace for symbols. If python loads this library it will conflict with any other libraries using the same name. This has happened numerous times in the past, so there's no ques

[issue3095] multiprocessing initializes flags dict unsafely

2008-06-12 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: This doesn't look right. PyDict_SetItemString doesn't steal the references passed to it, so your reference to flags will be leaked each time. Besides, I think it's a little cleaner to INCREF it before call PyModule_AddObje

[issue3100] segfault after loading multiprocessing.reduction

2008-06-12 Thread Adam Olsen
New submission from Adam Olsen <[EMAIL PROTECTED]>: $ ./python Python 2.6a3+ (unknown, Jun 12 2008, 20:10:55) [GCC 4.2.3 (Debian 4.2.3-1)] on linux2 Type "help", "copyright", "credits" or "license" for more information. >>> import

[issue3100] segfault after loading multiprocessing.reduction

2008-06-12 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: op is a KeyedRef instance. The instance being cleared from the module is the multiprocessing.util._afterfork_registry. Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 0xb7d626b0 (LWP 2287)] 0x0809a

[issue3100] segfault from multiprocessing.util.register_after_fork

2008-06-12 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: More specific test case. -- title: segfault after loading multiprocessing.reduction -> segfault from multiprocessing.util.register_after_fork Added file: http://bugs.python.org/file10610/register_after_fork

[issue3100] segfault from multiprocessing.util.register_after_fork

2008-06-12 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: Very specific test case, eliminating multiprocessing entirely. It may be an interaction between having the watched obj as its own key in the WeakValueDictionary and the order in which the two modules are cleared. Added file

[issue3100] segfault from multiprocessing.util.register_after_fork

2008-06-12 Thread Adam Olsen
Changes by Adam Olsen <[EMAIL PROTECTED]>: Added file: http://bugs.python.org/file10612/inner.py ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue3100] segfault from multiprocessing.util.register_after_fork

2008-06-12 Thread Adam Olsen
Changes by Adam Olsen <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file10610/register_after_fork-crash.py ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue3100] segfault with WeakValueDictionary and module clearing

2008-06-12 Thread Adam Olsen
Changes by Adam Olsen <[EMAIL PROTECTED]>: -- title: segfault from multiprocessing.util.register_after_fork -> segfault with WeakValueDictionary and module clearing ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.py

[issue3100] weakref subclass segfault

2008-06-12 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: Specific enough yet? Seems the WeakValueDictionary and the module clearing aren't necessary. A subclass of weakref is created. The target of this weakref is added as an attribute of the weakref. So long as a callback is present th

[issue3100] weakref subclass segfault

2008-06-12 Thread Adam Olsen
Changes by Adam Olsen <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file10612/inner.py ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue3100] weakref subclass segfault

2008-06-12 Thread Adam Olsen
Changes by Adam Olsen <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file10611/outer.py ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue3100] weakref subclass segfault

2008-06-12 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: 1. MyRef is released from the module as part of shutdown 2. MyRef's subtype_dealloc DECREFs its dictptr (not clearing it, as MyRef is dead and should be unreachable) 3. the dict DECREFs the Dummy (MyRef's target) 4. Dummy's

[issue3100] weakref subclass segfault

2008-06-12 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: Ahh, I missed a detail: when the callback is called the weakref has a refcount of 0, which is ICNREFed to 1 when getting put in the args, then drops down to 0 again when the args are DECREFed (causing it to get _Py_ForgetReference to be ca

[issue3100] weakref subclass segfault

2008-06-12 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: Patch to add extra sanity checks to Py_INCREF (only if Py_DEBUG is set). If the refcount is 0 or negative if calls Py_FatalError. This should catch revival bugs such as this one a little more clearly. The patch also adds a little more ch

[issue3095] multiprocessing initializes flags dict unsafely

2008-06-13 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: Aww, that's cheating. (Why didn't I think of that?) ___ Python tracker <[EMAIL PROTECTED]> <http://

[issue3100] weakref subclass segfault

2008-06-13 Thread Adam Olsen
Changes by Adam Olsen <[EMAIL PROTECTED]>: -- nosy: +jnoller ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue3100> ___ ___ Python

[issue3100] weakref subclass segfault

2008-06-13 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: Well, my attempt at a patch didn't work, and yours does, so I guess I have to support yours. ;) Can you review my python-incref-from-zero patch? It verifies the invariant that you need, that once an object hits a refcount of 0 i

[issue3100] weakref subclass segfault

2008-06-13 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: Ahh, it seems gcmodule already considers the weakref to be reachable when it calls the callbacks, so it shouldn't be a problem. ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.

[issue3100] weakref subclass segfault

2008-06-13 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: Another minor nit: "if(current->ob_refcnt > 0)" should have a space after the "if". Otherwise it's looking good. ___ Python tracker <[EMAIL PROTE

[issue2320] Race condition in subprocess using stdin

2008-06-14 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: This is messy. File descriptors from other threads are leaking into child processes, and if the write end of a pipe never gets closed in all of them the read end won't get EOF. I suspect "cat"'s stdin is getting d

[issue3088] test_multiprocessing hangs on OS X 10.5.3

2008-06-14 Thread Adam Olsen
Changes by Adam Olsen <[EMAIL PROTECTED]>: -- nosy: +Rhamphoryncus ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue3088> ___ __

[issue3114] bus error on lib2to3

2008-06-14 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: I'm not sure that fix is 100% right - it fixes safety, but not correctness. Wouldn't it be more correct to move all 3 into temporaries, assign from tstate, then XDECREF the temporaries? Otherwise you're going to exp

[issue3114] bus error on lib2to3

2008-06-15 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: Looking good. ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue3114> ___ ___ Python-bugs

[issue3125] test_multiprocessing causes test_ctypes to fail

2008-06-16 Thread Adam Olsen
Changes by Adam Olsen <[EMAIL PROTECTED]>: -- nosy: +Rhamphoryncus, jnoller ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue3125> ___ _

[issue3125] test_multiprocessing causes test_ctypes to fail

2008-06-16 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: Jesse, can you be more specific? Thomas, do you have a specific command to reproduce this? It runs fine if I do "./python -m test.regrtest -v test_multiprocessing test_ctypes". That's with amaury'

[issue3125] test_multiprocessing causes test_ctypes to fail

2008-06-16 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: I see no common symbols between #3102 and #3092, so unless I missed something, they shouldn't be involved. I second the notion that multiprocessing's use of pickle is the triggering factor. Registering so many types is

[issue3100] weakref subclass segfault

2008-06-16 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: Unfortunately, Py_INCREF is sometimes used in an expression (followed by a comma). I wouldn't expect an assert to be valid there (and I'd want to check ISO C to make sure it's portable, not just accepted by GCC). I&#x

[issue3107] memory leak in make test (in "test list"), 2.5.2 not 2.5.1, Linux 64bit

2008-06-16 Thread Adam Olsen
Changes by Adam Olsen <[EMAIL PROTECTED]>: -- nosy: +Rhamphoryncus ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue3107> ___ __

[issue3111] multiprocessing ppc Debian/ ia64 Ubuntu compilation error

2008-06-17 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: I don't see a problem with skipping it, but if chroot is the problem, maybe the chroot environment should be fixed to include /dev/shm? ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.

[issue3111] multiprocessing ppc Debian/ ia64 Ubuntu compilation error

2008-06-17 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: I agree with your agreement. ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue3111> ___ __

[issue3153] sqlite leaks on error

2008-06-20 Thread Adam Olsen
New submission from Adam Olsen <[EMAIL PROTECTED]>: Found in Modules/_sqlite/cursor.c: self->statement = PyObject_New(pysqlite_Statement, &pysqlite_StatementTy pe); if (!self->statement) { goto error; } rc = pysqlite_statement_create

[issue3154] "Quick search" box renders too long on FireFox 3

2008-06-20 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: Works for me. -- nosy: +Rhamphoryncus ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue3154] "Quick search" box renders too long on FireFox 3

2008-06-20 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: That's the same version I'm using. Maybe there's some font size differences? I'm also on a 64-bit AMD. ___ Python tracker <[EMAIL PROTECTED]> &

[issue3155] Python should expose a pthread_cond_timedwait API for threading

2008-06-21 Thread Adam Olsen
Changes by Adam Olsen <[EMAIL PROTECTED]>: -- nosy: +Rhamphoryncus ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue3155> ___ __

[issue3112] implement PEP 3134 exception reporting

2008-06-22 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: * cause/context cycles should be avoided. Naive traceback printing could become confused, and I can't think of any accidental way to provoke it (besides the problem mentioned here.) * I suspect PyErr_Display handled string except

[issue3112] implement PEP 3134 exception reporting

2008-06-22 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: On Sun, Jun 22, 2008 at 8:07 AM, Antoine Pitrou <[EMAIL PROTECTED]> wrote: > You mean they should be detected when the exception is set? I was afraid > that it may make exception raising slower. Reporting is not performa

[issue3112] implement PEP 3134 exception reporting

2008-06-22 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: On Sun, Jun 22, 2008 at 1:04 PM, Antoine Pitrou <[EMAIL PROTECTED]> wrote: > > Antoine Pitrou <[EMAIL PROTECTED]> added the comment: > > Le dimanche 22 juin 2008 à 17:17 +, Adam Olsen a écrit : >> I mean

[issue3112] implement PEP 3134 exception reporting

2008-06-22 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: On Sun, Jun 22, 2008 at 1:48 PM, Antoine Pitrou <[EMAIL PROTECTED]> wrote: > > Antoine Pitrou <[EMAIL PROTECTED]> added the comment: > > Le dimanche 22 juin 2008 à 19:23 +, Adam Olsen a écrit : >> For this

[issue3112] implement PEP 3134 exception reporting

2008-06-22 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: On Sun, Jun 22, 2008 at 2:20 PM, Antoine Pitrou <[EMAIL PROTECTED]> wrote: > > Antoine Pitrou <[EMAIL PROTECTED]> added the comment: > > Le dimanche 22 juin 2008 à 19:57 +, Adam Olsen a écrit : >> T

[issue3112] implement PEP 3134 exception reporting

2008-06-22 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: On Sun, Jun 22, 2008 at 2:56 PM, Antoine Pitrou <[EMAIL PROTECTED]> wrote: > Le dimanche 22 juin 2008 à 20:40 +, Adam Olsen a écrit : >> Passing in e.args is probably sufficient. > > I think it's very optimisti

[issue3154] "Quick search" box renders too long on FireFox 3

2008-06-27 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: I've checked it again, using the font preferences rather than the zoom setting, and I can reproduce the problem. Part of the problem stems from using pixels to set the margin, rather than ems (or whatever the text box is based on

[issue3088] test_multiprocessing hangs on OS X 10.5.3

2008-07-02 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: On Wed, Jul 2, 2008 at 3:44 PM, Mark Dickinson <[EMAIL PROTECTED]> wrote: > > Mark Dickinson <[EMAIL PROTECTED]> added the comment: > >> Mark, can you try commenting out _TestCondition and seeing if you can >&g

[issue3088] test_multiprocessing hangs on OS X 10.5.3

2008-07-02 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: On Wed, Jul 2, 2008 at 5:08 PM, Mark Dickinson <[EMAIL PROTECTED]> wrote: > > Mark Dickinson <[EMAIL PROTECTED]> added the comment: > > Okay. I just got about 5 perfect runs of the test suite, followed by:

[issue3088] test_multiprocessing hangs on OS X 10.5.3

2008-07-02 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: That looks better. It crashed while deleting an exception, who's args tuple has a bogus refcount. Could be a refcount issue of the exception or the args, or of something that that references them, or a dangling pointer, or a buffer o

[issue3088] test_multiprocessing hangs on OS X 10.5.3

2008-07-02 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: Also, make sure you do a "make clean" since you last updated the tree or touched any file or ran configure. The automatic dependency checking isn't 100% reliable. ___ Python tracker <

[issue3268] Cleanup of tp_basicsize inheritance

2008-07-02 Thread Adam Olsen
New submission from Adam Olsen <[EMAIL PROTECTED]>: inherit_special contains logic to inherit the base type's tp_basicsize if the new type doesn't have it set. The logic was spread over several lines, but actually does almost nothing (presumably an artifact of previous versio

[issue874900] threading module can deadlock after fork

2008-07-08 Thread Adam Olsen
Changes by Adam Olsen <[EMAIL PROTECTED]>: -- nosy: +Rhamphoryncus ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue874900> ___ __

[issue1758146] Crash in PyObject_Malloc

2008-07-08 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: Apparently modwsgi uses subinterpreters because some third-party packages aren't sufficiently thread-safe - modwsgi can't fix those packages, so subinterpreters are the next best thing. http://groups.google.com/group/modwsgi/b

[issue1758146] Crash in PyObject_Malloc

2008-07-08 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: Ahh, I did miss that bit, but it doesn't really matter. Tell modwsgi to only use the main interpreter ("PythonInterpreter main_interpreter"), and if you want multiple modules of the same name put them in different packages

[issue1758146] Crash in PyObject_Malloc

2008-07-08 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: Franco, you need to look at the line above that check: PyThreadState *check = PyGILState_GetThisThreadState(); if (check && check->interp == newts->interp && check != newts) Py_FatalErr

[issue1758146] Crash in PyObject_Malloc

2008-07-08 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: It's only checking that the original tstate *for the current thread* and the new tstate have a different subinterpreter. A subinterpreter can have multiple tstates, so long as they're all in different threads. The documentat

[issue874900] threading module can deadlock after fork

2008-07-09 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: In general I suggest replacing the lock with a new lock, rather than trying to release the existing one. Releasing *might* work in this case, only because it's really a semaphore underneath, but it's still easier to think about b

[issue874900] threading module can deadlock after fork

2008-07-09 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: Looking over some of the other platforms for thread_*.h, I'm sure replacing the lock is the right thing. ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.py

[issue3329] API for setting the memory allocator used by Python

2008-07-09 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: How would this allow you to free all memory? The interpreter will still reference it, so you'd have to have called Py_Finalize already, and promise not to call Py_Initialize afterwords. This further supposes the process will live

[issue3329] API for setting the memory allocator used by Python

2008-07-10 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: Basically you just want to kick the malloc implementation into doing some housekeeping, freeing its caches? I'm kinda surprised you don't add the hook directly to your libc's malloc. IMO, there's no use-case for

[issue3297] Python interpreter uses Unicode surrogate pairs only before the pyc is created

2008-07-11 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: Simpler way to reproduce this (on linux): $ rm unicodetest.pyc $ $ python -c 'import unicodetest' Result: False Len: 2 1 Repr: u'\ud800\udd23' u'\U00010123' $ $ python -c 'import unicodetest

[issue3297] Python interpreter uses Unicode surrogate pairs only before the pyc is created

2008-07-11 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: No, the configure options are wrong - we do use UTF-16 and UTF-32. Although modern UCS-4 has been restricted down to the range of UTF-32 (it used to be larger!), UCS-2 still doesn't support the supplementary planes (ie no surrogat

[issue3297] Python interpreter uses Unicode surrogate pairs only before the pyc is created

2008-07-12 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: Marc, perhaps Unicode has refined their definitions since you last looked? Valid UTF-8 *cannot* contain surrogates[1]. If it does, you have CESU-8[2][3], not UTF-8. So there are two bugs: first, the UTF-8 codec should refuse to load surr

[issue3297] Python interpreter uses Unicode surrogate pairs only before the pyc is created

2008-07-12 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: Err, to clarify, the parse/compile/whatever stages is producing broken UTF-32 (surrogates are ill-formed there too), and that gets transformed into CESU-8 when the .pyc is saved. ___ Python tracker &

[issue3299] invalid object destruction in re.finditer()

2008-07-19 Thread Adam Olsen
Changes by Adam Olsen <[EMAIL PROTECTED]>: -- nosy: +Rhamphoryncus ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue3299> ___ __

[issue1758146] Crash in PyObject_Malloc

2008-07-21 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: Graham, I appreciate the history of sub-interpreters and how entrenched they are. Changing those practises requires a significant investment. This is an important factor to consider. The other factor is the continuing maintenan

[issue1674032] Make threading.Event().wait(timeout=3) return isSet

2008-08-20 Thread Adam Milner
Adam Milner <[EMAIL PROTECTED]> added the comment: I would like to add my support for this change. As David described, it is often useful to know why the x.wait() has returned, not just that it has. -- nosy: +carmiac ___ Python tracker &

[issue3672] Ill-formed surrogates not treated as errors during encoding/decoding

2008-08-24 Thread Adam Olsen
New submission from Adam Olsen <[EMAIL PROTECTED]>: The Unicode FAQ makes it quite clear that any surrogates in UTF-8 or UTF-32 should be treated as errors. Lone surrogates in UTF-16 should probably be treated as errors too (but only during encoding/decoding; unicode objects on UTF-16

[issue3672] Ill-formed surrogates not treated as errors during encoding/decoding

2008-08-24 Thread Adam Olsen
Changes by Adam Olsen <[EMAIL PROTECTED]>: -- components: +Unicode type: -> behavior ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.py

[issue2001] Pydoc interactive browsing enhancement

2008-08-31 Thread Ron Adam
Ron Adam <[EMAIL PROTECTED]> added the comment: New patch to replace outdated patch due to other changes to pydoc. The easies way to try this out is to: >> import pydoc >> pydoc.gui() Try it before and after the patch. I think most people will prefer the patch.

[issue2001] Pydoc interactive browsing enhancement

2008-08-31 Thread Ron Adam
Changes by Ron Adam <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file9350/pydocnotk.diff ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue2001] Pydoc interactive browsing enhancement

2008-08-31 Thread Ron Adam
Changes by Ron Adam <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file9423/pydocnotk.diff ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue2001] Pydoc interactive browsing enhancement

2008-08-31 Thread Ron Adam
Changes by Ron Adam <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file9448/pydocnotk.diff ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue3297] Python interpreter uses Unicode surrogate pairs only before the pyc is created

2008-09-01 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: Marc, I don't understand what you're saying. UTF-16's surrogates are not optional. Unicode 2.0 and later require them, and Python is supposed to support it. Likewise, UCS-4 originally allowed a much larger range of c

[issue3297] Python interpreter uses Unicode surrogate pairs only before the pyc is created

2008-09-01 Thread Adam Olsen
Adam Olsen <[EMAIL PROTECTED]> added the comment: I've got another report open about the codecs not properly reporting errors relating to surrogates: issue 3672 ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.

[issue7784] patch for making list/insert at the top of the list avoid memmoves

2010-01-26 Thread Adam Olsen
Adam Olsen added the comment: $ ./python -m timeit -s 'from collections import deque; c = deque(range(100))' 'c.append(c.popleft())' 100 loops, best of 3: 0.29 usec per loop $ ./python -m timeit -s 'c = range(100)' 'c.append(c.pop(0))' 1

[issue7975] dbshelve.py throws exception: AttributeError: 'DB' object has no attribute '__iter__'

2010-02-21 Thread Adam Collard
New submission from Adam Collard : Originally reported at: https://bugs.edge.launchpad.net/bugs/384602 In Python 2.6, the dbshelve.py module throws an AttributeError exception whenever a call is made to a method that depends upon an __iter__ method. The exception is: File "/us

[issue7975] dbshelve.py throws exception: AttributeError: 'DB' object has no attribute '__iter__'

2010-02-21 Thread Adam Collard
Adam Collard added the comment: Attached a simple example. -- Added file: http://bugs.python.org/file16280/dbshelve_example.py ___ Python tracker <http://bugs.python.org/issue7

[issue2001] Pydoc interactive browsing enhancement

2010-03-09 Thread Ron Adam
Changes by Ron Adam : Removed file: http://bugs.python.org/file16411/pydoc_gui.diff ___ Python tracker <http://bugs.python.org/issue2001> ___ ___ Python-bugs-list mailin

[issue2001] Pydoc interactive browsing enhancement

2010-03-09 Thread Ron Adam
Ron Adam added the comment: Missed a buffer write in the gettopic() method. Fixed. Plus some minor doc string changes. Can someone change the stage to "patch review". I can't do that myself. Or is there something else I need to do first? -- Added file: http://

[issue8188] Unified hash for numeric types.

2010-03-20 Thread Adam Olsen
Adam Olsen added the comment: Why aren't you using 64-bit hashes on 64-bit architectures? -- nosy: +Rhamphoryncus ___ Python tracker <http://bugs.python.org/i

[issue8188] Unified hash for numeric types.

2010-03-20 Thread Adam Olsen
Adam Olsen added the comment: I assume you mean 63. ;) -- ___ Python tracker <http://bugs.python.org/issue8188> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue8525] Small enhancement to help()

2010-04-24 Thread Ron Adam
Changes by Ron Adam : -- nosy: +ron_adam ___ Python tracker <http://bugs.python.org/issue8525> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue1564547] Py_signal_pipe

2007-12-09 Thread Adam Olsen
Adam Olsen added the comment: The minimal patch doesn't initialize dummy_char or dummy_c. It's harmless here, but please fix it. ;) sizeof(dummy_char) will always be 1 (C defines sizeof as multiples of char.) The convention seems to be hardcoding

[issue1583] Patch for signal.set_wakeup_fd

2007-12-10 Thread Adam Olsen
New submission from Adam Olsen: This adds signal.set_wakeup_fd(fd), which allows a single library to be woken when a signal comes in. -- files: python2.6-set_wakeup_fd1.diff messages: 58385 nosy: rhamphoryncus severity: normal status: open title: Patch for signal.set_wakeup_fd Added

<    1   2   3   4   5   6   7   >