[issue45395] Frozen stdlib modules are discarded if custom frozen modules added.

2021-10-19 Thread Eric Snow
Eric Snow added the comment: On Tue, Oct 19, 2021 at 10:47 AM Marc-Andre Lemburg wrote: > Ok, I'll start looking into this and post updates here. Thanks! -- ___ Python tracker _

[issue45020] Freeze all modules imported during startup.

2021-10-19 Thread Eric Snow
Eric Snow added the comment: On Mon, Oct 18, 2021 at 7:14 PM Guido van Rossum wrote: > Is gh-28940 only for UNIX? It wasn't meant to be. :( > I built on Windows with default options (PCbuild\build.bat) and it looks like > the frozen modules are used by default even though I am running in th

[issue45500] Rewrite test_dbm

2021-10-19 Thread Łukasz Langa
Change by Łukasz Langa : -- pull_requests: +27337 pull_request: https://github.com/python/cpython/pull/29069 ___ Python tracker ___ _

[issue45494] [fuzzer] Parser null deref with continuation characters and generator parenthesis error

2021-10-19 Thread Łukasz Langa
Change by Łukasz Langa : -- pull_requests: +27338 pull_request: https://github.com/python/cpython/pull/29070 ___ Python tracker ___ _

[issue45506] Out of source tree builds failing on main - test_importlib others unreliable

2021-10-19 Thread Eric Snow
Eric Snow added the comment: New changeset f4b12440cf24d7636755aac5b2645e47713557c7 by Eric Snow in branch 'main': bpo-45506: Go back to not running most of test_embed in out-of-tree builds. (gh-29063) https://github.com/python/cpython/commit/f4b12440cf24d7636755aac5b2645e47713557c7 --

[issue25327] Python 3.5 Windows 10 Installation Fails With Corrupt Directory Error

2021-10-19 Thread Irit Katriel
Change by Irit Katriel : -- stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue45494] [fuzzer] Parser null deref with continuation characters and generator parenthesis error

2021-10-19 Thread Łukasz Langa
Change by Łukasz Langa : -- pull_requests: +27339 pull_request: https://github.com/python/cpython/pull/29071 ___ Python tracker ___ _

[issue25116] It failed to install Py3.5 on win2008R2

2021-10-19 Thread Irit Katriel
Change by Irit Katriel : -- stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue45500] Rewrite test_dbm

2021-10-19 Thread Łukasz Langa
Łukasz Langa added the comment: New changeset 325b2c223453203b2fa9ce7b9bcebdbef03adf70 by Łukasz Langa in branch '3.10': [3.10] bpo-45500: Rewrite test_dbm (GH-29002) (GH-29069) https://github.com/python/cpython/commit/325b2c223453203b2fa9ce7b9bcebdbef03adf70 --

[issue25222] 3.5.0 regression - Fatal Python error: Cannot recover from stack overflow

2021-10-19 Thread Irit Katriel
Irit Katriel added the comment: There was work on recursion in recent versions and the Fatal Error is less likely now. We will not investigate recursion issues on 3.5, so I will close this and request that you create a new issue if you have problem with a current Python version. --

[issue39679] functools: singledispatchmethod doesn't work with classmethod

2021-10-19 Thread miss-islington
Change by miss-islington : -- nosy: +miss-islington nosy_count: 12.0 -> 13.0 pull_requests: +27340 pull_request: https://github.com/python/cpython/pull/29072 ___ Python tracker ___

[issue39679] functools: singledispatchmethod doesn't work with classmethod

2021-10-19 Thread Łukasz Langa
Łukasz Langa added the comment: New changeset ad6d162e518963711d24c80f1b7d6079bd437584 by Alex Waygood in branch 'main': bpo-39679: Add tests for classmethod/staticmethod singledispatchmethods (GH-29034) https://github.com/python/cpython/commit/ad6d162e518963711d24c80f1b7d6079bd437584 -

[issue45494] [fuzzer] Parser null deref with continuation characters and generator parenthesis error

2021-10-19 Thread Łukasz Langa
Łukasz Langa added the comment: New changeset 5c9cab595e56aeb118bff77ece784dbac30b4338 by Łukasz Langa in branch '3.10': [3.10] bpo-45494: Fix parser crash when reporting errors involving invalid continuation characters (GH-28993) (GH-29070) https://github.com/python/cpython/commit/5c9cab595e

[issue42064] Convert sqlite3 to multi-phase initialisation (PEP 489)

2021-10-19 Thread Erlend E. Aasland
Change by Erlend E. Aasland : -- pull_requests: +27341 pull_request: https://github.com/python/cpython/pull/29073 ___ Python tracker ___ ___

[issue25355] Windows installer does not add py.exe launcher to "App Paths" key

2021-10-19 Thread Steve Dower
Steve Dower added the comment: Somewhat deliberate. We moved to properly support side-by-side installs, which can't be done with this key - App Paths would end up out of sync with PATH... almost instantly, really. (However, the Windows Store package manages this correctly in line with its PA

[issue45500] Rewrite test_dbm

2021-10-19 Thread Łukasz Langa
Change by Łukasz Langa : -- pull_requests: +27342 pull_request: https://github.com/python/cpython/pull/29074 ___ Python tracker ___ _

[issue45521] obmalloc radix tree typo in code

2021-10-19 Thread Neil Schemenauer
Neil Schemenauer added the comment: I have not yet been able to reproduce methane's crash. My guess it it's not related. An explanation of what I think the impact of this bug is: The radix tree is used to determine if memory is from obmalloc or from the system malloc (i.e return value from

[issue45436] test_tk.test_configure_type() failed on x86 Gentoo Non-Debug with X 3.x with Tcl/Tk 8.6.11

2021-10-19 Thread Ned Deily
Change by Ned Deily : -- pull_requests: -27336 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue45436] test_tk.test_configure_type() failed on x86 Gentoo Non-Debug with X 3.x with Tcl/Tk 8.6.11

2021-10-19 Thread Ned Deily
Ned Deily added the comment: There are similar test failures on macOS with the current Tk 8.6.11.1 on both 3.10 and 3.11. -- nosy: +ned.deily stage: patch review -> needs patch versions: +Python 3.10 ___ Python tracker

[issue45528] mmap: constants not listed in the documentation

2021-10-19 Thread Michael Wayne Goodman
Change by Michael Wayne Goodman : -- keywords: +patch pull_requests: +27343 stage: -> patch review pull_request: https://github.com/python/cpython/pull/29075 ___ Python tracker __

[issue45436] test_tk.test_configure_type() fails with Tcl/Tk 8.6.11

2021-10-19 Thread STINNER Victor
Change by STINNER Victor : -- title: test_tk.test_configure_type() failed on x86 Gentoo Non-Debug with X 3.x with Tcl/Tk 8.6.11 -> test_tk.test_configure_type() fails with Tcl/Tk 8.6.11 ___ Python tracker __

[issue45529] checking any object for attr "get" always returns True with `hasattr`

2021-10-19 Thread Clay Massok
New submission from Clay Massok : Any time you use `hasattr` to check if a dict has the attr "get", it returns true. Uploaded `.py` file has bug example. -- components: macOS files: bug.py messages: 404353 nosy: m.c.massok, ned.deily, ronaldoussoren priority: normal severity: normal s

[issue45520] Frozen dataclass deep copy doesn't work with __slots__

2021-10-19 Thread Josh Rosenberg
Josh Rosenberg added the comment: You're right that in non-dataclass scenarios, you'd just use __slots__. The slots=True thing was necessary for any case where any of the dataclass's attributes have default values (my_int: int = 0), or are defined with fields (my_list: list = field(default_f

[issue45529] checking any object for attr "get" always returns True with `hasattr`

2021-10-19 Thread Ned Deily
Ned Deily added the comment: That is expected behavior. "get" is a method of "dict". >>> payload = {} >>> dir(payload) ['__class__', '__class_getitem__', '__contains__', '__delattr__', '__delitem__', '__dir__', '__doc__', '__eq__', '__format__', '__ge__', '__getattribute__', '__getitem__', '

[issue11173] Undocumented public APIs in Python 3.2

2021-10-19 Thread Irit Katriel
Irit Katriel added the comment: PyAST_CompileEx was removed in 3.10 and PyType_FromSpec, PyStructSequence_* are documented now. PyThread_acquire_lock_timed is not, but I understand this is deliberate. I think this is complete, so I'll close this if nobody will object. -- nosy: +irit

[issue45528] mmap: constants not listed in the documentation

2021-10-19 Thread Michael Wayne Goodman
Michael Wayne Goodman added the comment: I have added a draft PR on GitHub that adds the lists of constants. As mentioned in the PR, there are a few things that I think could be added before merging: 1. Update descriptions in mmap.mmap, and maybe the intro, to link to relevant sections. 2.

[issue45494] [fuzzer] Parser null deref with continuation characters and generator parenthesis error

2021-10-19 Thread Łukasz Langa
Łukasz Langa added the comment: Note: this *does* fail on 3.9, too. Even if it doesn't crash the production build, it does fail an assertion in a pydebug build: test_error_offset_continuation_characters (test.test_exceptions.ExceptionTests) ... Assertion failed: (!_PyErr_Occurred(tstate)), f

[issue45530] Improve listobject.c's unsafe_tuple_compare()

2021-10-19 Thread Tim Peters
New submission from Tim Peters : The code could typically be faster if it did what its comments imply it does: skip the expense of PyObject_RichCompareBool() entirely for the first pair of tuple elements. It actually always calls PyObject_RichCompareBool() on the first pair, and only if that

[issue45530] Improve listobject.c's unsafe_tuple_compare()

2021-10-19 Thread Tim Peters
Tim Peters added the comment: FYI, this is fallout from a StackOverflow mystery: https://stackoverflow.com/questions/69468552/efficiency-of-sorting-by-multiple-keys-in-python/69610671# -- ___ Python tracker ___

[issue39679] functools: singledispatchmethod doesn't work with classmethod

2021-10-19 Thread Łukasz Langa
Łukasz Langa added the comment: New changeset c15ba304f35362470e29ea5626fed28366bc9571 by Miss Islington (bot) in branch '3.10': bpo-39679: Add tests for classmethod/staticmethod singledispatchmethods (GH-29034) (GH-29072) https://github.com/python/cpython/commit/c15ba304f35362470e29ea5626fed

[issue39679] functools: singledispatchmethod doesn't work with classmethod

2021-10-19 Thread Łukasz Langa
Łukasz Langa added the comment: Thanks for the new tests, Alex. Not closing this just yet because maybe we find a way to fix it in 3.9.8+. -- ___ Python tracker ___ __

[issue45530] Improve listobject.c's unsafe_tuple_compare()

2021-10-19 Thread Tim Peters
Tim Peters added the comment: The attached tupsort.py gives a simple. focused example. Typical output on my box: float 3.10 (float,) 11.75 [float]25.68 It's sorting a large list of floats. In the first line the list contains plain floats. In the second line, each float was wrapp

[issue26155] 3.5.1 installer issue on Win 7 32 bit

2021-10-19 Thread Irit Katriel
Change by Irit Katriel : -- resolution: -> out of date stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Python

[issue35673] Loader for namespace packages

2021-10-19 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: I don't know. What benefit would be gained? That should probably be a separate issue/PR in either case. -- ___ Python tracker ___ ___

[issue28983] Windows: Python 3.5.2 won't install on my computer

2021-10-19 Thread Irit Katriel
Change by Irit Katriel : -- resolution: -> out of date stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Python

[issue24343] Installing 3.4.3 gives error codes 2503 and 2502 on windows 8

2021-10-19 Thread Irit Katriel
Change by Irit Katriel : -- resolution: -> out of date stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Python

[issue26631] Unable to install Python 3.5.1 on Windows 10 - Error 0x80070643: Failed to install MSI package.

2021-10-19 Thread Irit Katriel
Change by Irit Katriel : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-

[issue25625] "chdir" Contex manager for pathlib

2021-10-19 Thread Łukasz Langa
Łukasz Langa added the comment: New changeset 3592980f9122ab0d9ed93711347742d110b749c2 by Filipe Laíns in branch 'main': bpo-25625: add contextlib.chdir (GH-28271) https://github.com/python/cpython/commit/3592980f9122ab0d9ed93711347742d110b749c2 -- nosy: +lukasz.langa __

[issue20983] Python 3.4 'repair' Windows installation does not install pip & setuptools packages

2021-10-19 Thread Zachary Ware
Zachary Ware added the comment: The installer system for v3.4 and before has long since been retired. -- resolution: -> out of date stage: -> resolved status: open -> closed ___ Python tracker

[issue25625] "chdir" Contex manager for pathlib

2021-10-19 Thread Łukasz Langa
Łukasz Langa added the comment: Thanks for perservering, Filipe! ✨ 🍰 ✨ Per Steering Council decision, the context manager is approved: https://github.com/python/steering-council/issues/77 -- resolution: rejected -> fixed versions: +Python 3.11 -Python 3.9 ___

[issue28584] ICC compiler check is too permissive

2021-10-19 Thread Zachary Ware
Change by Zachary Ware : -- versions: +Python 3.10, Python 3.11, Python 3.9 -Python 3.8 ___ Python tracker ___ ___ Python-bugs-list

[issue39293] Windows 10 64-bit needs reboot after install

2021-10-19 Thread Zachary Ware
Change by Zachary Ware : -- resolution: -> works for me stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Pytho

[issue31875] Error 0x80070642: Failed to install MSI package.

2021-10-19 Thread Irit Katriel
Change by Irit Katriel : -- components: +Windows -Installation nosy: +paul.moore, steve.dower, tim.golden, zach.ware ___ Python tracker ___

[issue41603] Compilation issue 3.8.5 with Redhat 7.8 and gcc version 4.8.5 20150623 (Red Hat 4.8.5-39) (GCC)

2021-10-19 Thread Irit Katriel
Change by Irit Katriel : -- nosy: +vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue37981] Can't install Python 3.7.4 x64 on Win 8.1

2021-10-19 Thread Irit Katriel
Change by Irit Katriel : -- resolution: -> works for me stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Pytho

[issue41603] Compilation issue 3.8.5 with Redhat 7.8 and gcc version 4.8.5 20150623 (Red Hat 4.8.5-39) (GCC)

2021-10-19 Thread STINNER Victor
STINNER Victor added the comment: Python 3.8 is no longer supported. Can you reproduce the issue with Python 3.11? I fixed bugs like this one in the meanwhile. -- ___ Python tracker

[issue28576] Uninstalling Py352 x86 with /uninstall option does not remove prepended paths

2021-10-19 Thread Irit Katriel
Change by Irit Katriel : -- resolution: -> out of date stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Python

[issue31875] Error 0x80070642: Failed to install MSI package.

2021-10-19 Thread Steve Dower
Steve Dower added the comment: We'd also need the other log files from %TEMP% in this case, but I suspect we're not going to get them now. The associated PR is not related to this bug. -- resolution: -> out of date stage: patch review -> resolved status: open -> closed

[issue24873] Add "full cleanup" checkbox to uninstaller

2021-10-19 Thread Irit Katriel
Change by Irit Katriel : -- versions: +Python 3.11 -Python 3.5, Python 3.6 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue11173] Undocumented public APIs in Python 3.2

2021-10-19 Thread STINNER Victor
STINNER Victor added the comment: > I think this is complete, so I'll close this if nobody will object. I concur, please close it ;-) -- status: pending -> open ___ Python tracker __

[issue11173] Undocumented public APIs in Python 3.2

2021-10-19 Thread Irit Katriel
Change by Irit Katriel : -- stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue37274] Scripts folder is empty in python 3.7.3 for windows.

2021-10-19 Thread Irit Katriel
Irit Katriel added the comment: There was no reply to followup questions so we can't do anything about this. Also 3.7 is no longer in maintenance. Please create a new issue if you are having problems with a current (>= 3.9) version of Python. -- nosy: +iritkatriel resolution: -> ou

[issue31011] Users (except from the one who installed) not able to see python in add remove programs.

2021-10-19 Thread Irit Katriel
Change by Irit Katriel : -- components: +Windows -Installation nosy: +paul.moore, steve.dower, tim.golden, zach.ware ___ Python tracker ___

[issue45523] Python3 ThreadingHTTPServer fails to send chunked encoded response

2021-10-19 Thread Martin Panter
Martin Panter added the comment: Looks like you forgot to encode the length of ten in hexadecimal. I don't think the HTTP server module has any special handling for chunked responses, so this up to the user and isn't a bug in Python. -- nosy: +martin.panter resolution: -> not a bug

[issue34036] ModuleNotFoundError: No module named '_ctypes' when install Python 3.7 on Linux

2021-10-19 Thread Irit Katriel
Irit Katriel added the comment: 3.7 is no longer maintained. Please create a new issue if you are still having this problem with a current version of python (3.9+). -- nosy: +iritkatriel resolution: -> out of date stage: -> resolved status: open -> closed __

[issue38704] Prevent installation on unsupported Windows versions

2021-10-19 Thread Irit Katriel
Change by Irit Katriel : -- versions: +Python 3.11 -Python 3.8, Python 3.9 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue39490] Python Uninstaller fails to clean up the old path variables when uninstalling

2021-10-19 Thread Irit Katriel
Change by Irit Katriel : -- components: +Windows -Installation nosy: +paul.moore, steve.dower, tim.golden, zach.ware ___ Python tracker ___

[issue39490] Python Uninstaller fails to clean up the old path variables when uninstalling

2021-10-19 Thread Irit Katriel
Irit Katriel added the comment: Actually I don't know if this is a windows issue, the report doesn't say. -- nosy: +iritkatriel ___ Python tracker ___

[issue34737] Python upgrade with SYSTEM account uninstalls python

2021-10-19 Thread Irit Katriel
Change by Irit Katriel : -- resolution: -> out of date stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Python

[issue44525] Implement CALL_FUNCTION adaptive interpreter optimizations

2021-10-19 Thread Mark Shannon
Mark Shannon added the comment: New changeset 3163e68c342434db37c69669017f96a4bb2d5f13 by Ken Jin in branch 'main': bpo-44525: Specialize ``CALL_FUNCTION`` for C function calls (GH-26934) https://github.com/python/cpython/commit/3163e68c342434db37c69669017f96a4bb2d5f13 -- _

[issue45459] Limited API support for Py_buffer

2021-10-19 Thread STINNER Victor
STINNER Victor added the comment: Maybe a PEP is needed to collect usages of the Py_buffer API and check if the ABI is future proof. A PEP may help to discuss with other projects which currently consume this API. I suggest to start with the smallest possible API and then slowly extend it. I

[issue45531] field "mro" behaves strangely in dataclass

2021-10-19 Thread Finite State Machine
New submission from Finite State Machine : The following Python script: from dataclasses import dataclass @dataclass class A: mro: object x: object Results in the following unexpected exception: Traceback (most recent call last): File "/Users/dsuffling/.

[issue21969] WindowsPath constructor does not check for invalid characters

2021-10-19 Thread Irit Katriel
Change by Irit Katriel : -- type: -> enhancement versions: +Python 3.11 -Python 3.4, Python 3.5 ___ Python tracker ___ ___ Python-b

[issue25355] Windows installer does not add py.exe launcher to "App Paths" key

2021-10-19 Thread Eryk Sun
Eryk Sun added the comment: > IMO, this makes it the 'system' Python. "App Paths" entries can be used like versioned symlinks in POSIX. For example, an "App Paths" entry for "python3.exe" can refer to a particular installation's "python.exe". That said, "App Paths" is only used by the shell

[issue45531] field "mro" behaves strangely in dataclass

2021-10-19 Thread Eric V. Smith
Change by Eric V. Smith : -- assignee: -> eric.smith nosy: +eric.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue45532] Replace 'default' with 'main' as default in sys.version

2021-10-19 Thread Ezio Melotti
New submission from Ezio Melotti : sys.version returns '3.10.0 (default, Oct 5 2021, 23:49:26) [GCC 10.2.1 20210110]' 'default' is supposed to represent the name of the branch, and it's been there since the HG days: https://github.com/python/cpython/blob/fc64c351c7757f0ebdb7da65cb74871e494a

[issue45530] Improve listobject.c's unsafe_tuple_compare()

2021-10-19 Thread Tim Peters
Change by Tim Peters : -- keywords: +patch pull_requests: +27345 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/29076 ___ Python tracker __

[issue45531] field "mro" behaves strangely in dataclass

2021-10-19 Thread Eric V. Smith
Eric V. Smith added the comment: I agree on your analysis. You'll get the same error on any name that type defines (like __class__), but "mro" looks like the only one without dunders. I'm not sure the best way to fix this. I'll give it some thought. Another problem is that assigning a defaul

[issue25355] Windows installer does not add py.exe launcher to "App Paths" key

2021-10-19 Thread Steve Dower
Steve Dower added the comment: > The store app doesn't add "App Paths" entries for "python.exe" and > "python3.exe". You're right, it's not following the aliases, but the actual executable. For 3.7, we had them as "python.exe", but from 3.8 they became "python3.8.exe" with a "python.exe" al

[issue45530] Improve listobject.c's unsafe_tuple_compare()

2021-10-19 Thread Tim Peters
Change by Tim Peters : -- assignee: -> tim.peters ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue45532] Replace 'default' with 'main' as default in sys.version

2021-10-19 Thread Dong-hee Na
Change by Dong-hee Na : -- nosy: +corona10 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue45532] Replace 'default' with 'main' as default in sys.version

2021-10-19 Thread Dong-hee Na
Dong-hee Na added the comment: +1 -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org

[issue45532] Replace 'default' with 'main' as default in sys.version

2021-10-19 Thread Dong-hee Na
Change by Dong-hee Na : -- keywords: +easy (C) ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue45436] test_tk.test_configure_type() fails with Tcl/Tk 8.6.11

2021-10-19 Thread Zachary Ware
Change by Zachary Ware : -- nosy: +zach.ware nosy_count: 6.0 -> 7.0 pull_requests: +27346 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/29077 ___ Python tracker _

[issue45530] Improve listobject.c's unsafe_tuple_compare()

2021-10-19 Thread Raymond Hettinger
Change by Raymond Hettinger : -- nosy: +rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue45532] Replace 'default' with 'main' as default in sys.version

2021-10-19 Thread Dong-hee Na
Dong-hee Na added the comment: > youknowone Do you want to take a look? -- nosy: +youknowone ___ Python tracker ___ ___ Python-bug

[issue45436] test_tk.test_configure_type() fails with Tcl/Tk 8.6.11

2021-10-19 Thread Zachary Ware
Zachary Ware added the comment: AFAICT, this is just a couple of tests that are testing something that's no longer an error, though anyone with deeper knowledge is more than welcome to disagree with my diagnosis :). I've posted PR29077 to fix the tests. Ned and Łukasz, will you want this bac

[issue33277] Deprecate __loader__, __package__, and __cached__ on modules

2021-10-19 Thread Barry A. Warsaw
Change by Barry A. Warsaw : -- keywords: +patch pull_requests: +27347 stage: test needed -> patch review pull_request: https://github.com/python/cpython/pull/29078 ___ Python tracker _

[issue45530] Improve listobject.c's unsafe_tuple_compare()

2021-10-19 Thread Stefan Pochmann
Stefan Pochmann added the comment: That's how Elliot did it in the original proposal: https://bugs.python.org/issue28685 Back then you pointed out that "Else we can assume u[0] == v[0]" isn't true for float('nan') values: https://github.com/python/cpython/pull/582#issuecomment-285838656 http

[issue45530] Improve listobject.c's unsafe_tuple_compare()

2021-10-19 Thread Tim Peters
Tim Peters added the comment: Stefan, I have scant memory of ever caring, but, if I did, I got over it ;-) >>> math.nan == math.nan False >>> {math.nan : 5}[math.nan] 5 That is, PyObject_RichCompareBool() takes object identity as overriding __eq__; that's why the dict lookup works. But this

[issue45436] test_tk.test_configure_type() fails with Tcl/Tk 8.6.11

2021-10-19 Thread miss-islington
Change by miss-islington : -- nosy: +miss-islington nosy_count: 8.0 -> 9.0 pull_requests: +27348 pull_request: https://github.com/python/cpython/pull/29080 ___ Python tracker _

[issue45436] test_tk.test_configure_type() fails with Tcl/Tk 8.6.11

2021-10-19 Thread Zachary Ware
Zachary Ware added the comment: New changeset 4fe454c6f54b0948af67b53af6c2f35af6377e69 by Zachary Ware in branch 'main': bpo-45436: Fix tkinter tests with Tcl/Tk 8.6.11+ (GH-29077) https://github.com/python/cpython/commit/4fe454c6f54b0948af67b53af6c2f35af6377e69 --

[issue45436] test_tk.test_configure_type() fails with Tcl/Tk 8.6.11

2021-10-19 Thread miss-islington
Change by miss-islington : -- pull_requests: +27349 pull_request: https://github.com/python/cpython/pull/29081 ___ Python tracker ___ __

[issue38371] Tkinter: deprecate the split() method

2021-10-19 Thread Zachary Ware
Change by Zachary Ware : -- nosy: +zach.ware nosy_count: 2.0 -> 3.0 pull_requests: +27350 pull_request: https://github.com/python/cpython/pull/29082 ___ Python tracker ___

[issue45530] Improve listobject.c's unsafe_tuple_compare()

2021-10-19 Thread Stefan Pochmann
Stefan Pochmann added the comment: > What justifies "shouldn't"? I based that on your old comments. Looked like tuple comparison results in sorting shouldn't differ from tuple comparison results elsewhere. I had actually proposed this exact method in a comment under your stackoverflow answe

[issue37815] 'Make Test' error while trying to install Python 3.7.4 on Linux Mint

2021-10-19 Thread Zachary Ware
Zachary Ware added the comment: I can't reproduce this on Pop_OS! 20.04 with libreadline-gplv2-dev, so I'm going to assume it's been fixed somewhere along the way. If anyone else can still reproduce with up-to-date versions of everything involved, please post the relevant versions and steps

[issue38371] Tkinter: deprecate the split() method

2021-10-19 Thread Zachary Ware
Zachary Ware added the comment: New changeset 085ccb0f177988065dbe9ef4c5cda434560066bc by Zachary Ware in branch 'main': bpo-38371: Remove remaining use of tk.split from bigmem tcl test (GH-29082) https://github.com/python/cpython/commit/085ccb0f177988065dbe9ef4c5cda434560066bc --

[issue43656] TracebackException or StackSummary.extract with capture_locals=True fail to catch exceptions raised by repr() on value of frame local variable in FrameSummary.__init__.

2021-10-19 Thread Andrei Kulakov
Andrei Kulakov added the comment: Joe: I would argue that it should be expected that every object instantiated from a class should have a safe __repr__, because you will have logging and if a __repr__ is broken in some rare circumstances, it may bring down your production system in the wors

[issue45530] Improve listobject.c's unsafe_tuple_compare()

2021-10-19 Thread Tim Peters
Tim Peters added the comment: Stefan, I looked at that old PR and can't find anywhere I suggested that he change the unsafe_tuple_compare() logic. I just _asked_ him "I'm curious about what the patched Python prints for this program:". And, in fact, that program showed that CPython was _alre

[issue45530] Improve listobject.c's unsafe_tuple_compare()

2021-10-19 Thread Stefan Pochmann
Stefan Pochmann added the comment: I misinterpreted you then, sorry. I guess also because Elliot shortly after retrated from the approach, saying he "rewrote unsafe_tuple_compare to move the less-than after the equality testing, to make sure it's 100% consistent". I'd say the inconsistency t

[issue45530] Improve listobject.c's unsafe_tuple_compare()

2021-10-19 Thread Tim Peters
Tim Peters added the comment: > Elliot shortly after retrated from the approach, saying he > rewrote unsafe_tuple_compare to move the less-than after > the equality testing, to make sure it's 100% consistent". I remember at the time having no idea what he meant by that comment - and I still h

[issue42092] test_host_resolution_bad_address does not always fail as expected

2021-10-19 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Woot! I finally figured out the problem and how to fix it. It has nothing to do with Python and everything to do with AT&T. They run a service called DNS Error Assist, quoting: "Sometimes we enter a wrong search word, or a wrong web address, or maybe the

[issue42092] test_host_resolution_bad_address does not always fail as expected

2021-10-19 Thread Barry A. Warsaw
Change by Barry A. Warsaw : -- pull_requests: +27351 pull_request: https://github.com/python/cpython/pull/29085 ___ Python tracker ___ _

<    1   2