[issue40686] Compiler warnings in _zoneinfo.c on Windows build in 64-bit

2020-12-16 Thread STINNER Victor
STINNER Victor added the comment: Paul created a follow-up issue: bpo-42660. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue42660] _zoneinfo.c incorrectly checks bounds of `day` variable in calenderrule_new

2020-12-16 Thread Paul Ganssle
Paul Ganssle added the comment: As I mentioned, it's a style issue. Yes this did not introduce any user-observable bugs, nor should it have changed the machine code emitted by the assembly on any competent compiler. The issue is that I had deliberately chosen to do a "redundant" check to imp

[issue42660] _zoneinfo.c incorrectly checks bounds of `day` variable in calenderrule_new

2020-12-16 Thread Ammar Askar
Ammar Askar added the comment: > Some compilers complain about checking `day < 0`, because `day` is an > unsigned type Just my two cents, this isn't just "some compilers". Everything from gcc, msvc, C# to the rust compiler complain about this sort of code. As they should, this is effectivel

[issue42660] _zoneinfo.c incorrectly checks bounds of `day` variable in calenderrule_new

2020-12-16 Thread Paul Ganssle
Paul Ganssle added the comment: > Just my two cents, this isn't just "some compilers". Everything from gcc, > msvc, C# to the rust compiler complain about this sort of code. As they > should, this is effectively dead code. They complain because most of the time it's a sign that people were i

[issue42556] unittest.mock.patch() cannot properly mock methods

2020-12-16 Thread Mario Corchero
Mario Corchero added the comment: Right, I believe this is indeed broken. This code: ``` class A: def m(self, a=None): pass from unittest import mock with mock.patch.object(A, "m", autospec=True): A.m.side_effect = print A().m(1) ``` prints: <__main__.A object at 0x7f69cc7dc6a0>

[issue1571878] Improvements to socket module exceptions

2020-12-16 Thread Irit Katriel
Irit Katriel added the comment: This was indeed done by now - all these exception types now extend OSErrors, the hierarchy is very close to the one suggested here (with the exception of the AddressError superclass, which I don't think is that useful to have), and they have an errno field (de

[issue41354] filecmp.cmp documentation does not match actual code

2020-12-16 Thread Scott
Scott added the comment: I suggest changing the documentation rather than the code. The mix up is in the wording. Documentation below "If shallow is true, files with identical os.stat() signatures are taken to be equal. Otherwise, the contents of the files are compared." The "Otherwise" ap

[issue42660] _zoneinfo.c incorrectly checks bounds of `day` variable in calenderrule_new

2020-12-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I propose to change the type of day to int. It will remove any objections againsy the range check and make the code less error-prone for integer overflow and sign loss. -- ___ Python tracker

[issue39041] Support GitHub Actions in CI

2020-12-16 Thread Daniel Hahler
Daniel Hahler added the comment: Is it planned to enable coverage uploads for PRs? This would really help with seeing if code (to be merged) is covered etc. -- nosy: +blueyed2 ___ Python tracker

[issue38323] asyncio: MultiLoopWatcher has a race condition (test_asyncio: test_close_kill_running() hangs on AMD64 RHEL7 Refleaks 3.x)

2020-12-16 Thread miss-islington
Change by miss-islington : -- pull_requests: +22667 pull_request: https://github.com/python/cpython/pull/23807 ___ Python tracker ___ __

[issue38323] asyncio: MultiLoopWatcher has a race condition (test_asyncio: test_close_kill_running() hangs on AMD64 RHEL7 Refleaks 3.x)

2020-12-16 Thread Andrew Svetlov
Andrew Svetlov added the comment: New changeset 66d3b589c44fcbcf9afe1e442d9beac3bd8bcd34 by Chris Jerdonek in branch 'master': bpo-38323: Add guard clauses in MultiLoopChildWatcher. (#22756) https://github.com/python/cpython/commit/66d3b589c44fcbcf9afe1e442d9beac3bd8bcd34 -- __

[issue38323] asyncio: MultiLoopWatcher has a race condition (test_asyncio: test_close_kill_running() hangs on AMD64 RHEL7 Refleaks 3.x)

2020-12-16 Thread miss-islington
Change by miss-islington : -- nosy: +miss-islington nosy_count: 7.0 -> 8.0 pull_requests: +22666 pull_request: https://github.com/python/cpython/pull/23806 ___ Python tracker _

[issue39101] IsolatedAsyncioTestCase freezes when exception is raised

2020-12-16 Thread miss-islington
miss-islington added the comment: New changeset d549d0b5575b390431b7b26999151f79f74d4516 by Miss Islington (bot) in branch '3.8': bpo-39101: Fixes BaseException hang in IsolatedAsyncioTestCase. (GH-22654) https://github.com/python/cpython/commit/d549d0b5575b390431b7b26999151f79f74d4516

[issue39101] IsolatedAsyncioTestCase freezes when exception is raised

2020-12-16 Thread miss-islington
miss-islington added the comment: New changeset 9d409d6b474c188feca6213b9601e06f97715b72 by Miss Islington (bot) in branch '3.9': bpo-39101: Fixes BaseException hang in IsolatedAsyncioTestCase. (GH-22654) https://github.com/python/cpython/commit/9d409d6b474c188feca6213b9601e06f97715b72

[issue38323] asyncio: MultiLoopWatcher has a race condition (test_asyncio: test_close_kill_running() hangs on AMD64 RHEL7 Refleaks 3.x)

2020-12-16 Thread miss-islington
miss-islington added the comment: New changeset bf0eed3e60acc7e4969a4fae940bc615fa924c30 by Miss Islington (bot) in branch '3.9': bpo-38323: Add guard clauses in MultiLoopChildWatcher. (GH-22756) https://github.com/python/cpython/commit/bf0eed3e60acc7e4969a4fae940bc615fa924c30 -- _

[issue42661] Hashlib Bug

2020-12-16 Thread Samit Mohnot
New submission from Samit Mohnot : Complete output (6 lines): Traceback (most recent call last): File "", line 1, in File "C:\Users\Username\AppData\Local\Temp\pip-install-uyjqlzx9\hashlib_973e0ee3f102447498d1d4dca94b7942\setup.py", line 68 print "unknown OS, please up

[issue38323] asyncio: MultiLoopWatcher has a race condition (test_asyncio: test_close_kill_running() hangs on AMD64 RHEL7 Refleaks 3.x)

2020-12-16 Thread miss-islington
miss-islington added the comment: New changeset dd262ef46d2e2fff4c413cfa5faa9e72cd36220e by Miss Islington (bot) in branch '3.8': bpo-38323: Add guard clauses in MultiLoopChildWatcher. (GH-22756) https://github.com/python/cpython/commit/dd262ef46d2e2fff4c413cfa5faa9e72cd36220e -- _

[issue42660] _zoneinfo.c incorrectly checks bounds of `day` variable in calenderrule_new

2020-12-16 Thread Paul Ganssle
Paul Ganssle added the comment: There are at least two issues with this: 1. This is a constructor for a struct, and the struct would really unnecessarily balloon in size if we switched everything over to be 32-bit integers (which I think is your suggestion?). This is not a major concern beca

[issue42661] Hashlib Bug

2020-12-16 Thread Zachary Ware
Zachary Ware added the comment: `hashlib` is part of the standard library and thus does not need to be (and should not be :)) installed via pip. -- nosy: +zach.ware resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tra

[issue42660] _zoneinfo.c incorrectly checks bounds of `day` variable in calenderrule_new

2020-12-16 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I propose to change types of function parameters and local variables. In any case the constructor checks the range of parameters, so there is no problem with packing them into compact structure. This will help to avoid errors of implicit conversion between

[issue42660] _zoneinfo.c incorrectly checks bounds of `day` variable in calenderrule_new

2020-12-16 Thread Paul Ganssle
Paul Ganssle added the comment: > Adding a static assertion about the signedness of uint8_t looks meaningless > to me. My proposal is to add a static assertion that `day` is an unsigned type. In the code it would look something like it does in the backports.zoneinfo code (https://github.com

[issue42662] Propose: Data model explict about __annotations__ key ordering.

2020-12-16 Thread Paul Bryan
New submission from Paul Bryan : Currently the data model documentation does not specify the order of keys in __annotations__ dictionary. It is currently in the order that arguments or attributes are declared. I propose to make this explicit. Rationale: Having order explicitly specified in th

[issue42662] Propose: Data model explict about __annotations__ key ordering.

2020-12-16 Thread Paul Bryan
Change by Paul Bryan : -- keywords: +patch pull_requests: +22668 stage: -> patch review pull_request: https://github.com/python/cpython/pull/23808 ___ Python tracker ___ _

[issue42662] Propose: Data model explict about __annotations__ key ordering.

2020-12-16 Thread Paul Bryan
Paul Bryan added the comment: Retracting. -- resolution: -> not a bug stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue42663] zoneinfo does not support full range of allowed transition hours in fallback string

2020-12-16 Thread Paul Ganssle
New submission from Paul Ganssle : TZif files consist of a list of transitions followed by a POSIX TZ var-style string of a form like "AAA3BBB,M3.2.0/01:30,M11.1.0/02:15:45", which decodes to "AAA (UTC-3) is the standard time and BBB (UTC-2) is the DST time, DST applies starting at 02:15:45 lo

[issue37961] Tracemalloc traces do not include original stack trace length

2020-12-16 Thread STINNER Victor
STINNER Victor added the comment: New changeset 051b9818671625d125dee8198e0d2af5ad4c85b8 by Daniel Hahler in branch 'master': bpo-37961: Fix regression in tracemalloc.Traceback.__repr__ (GH-23805) https://github.com/python/cpython/commit/051b9818671625d125dee8198e0d2af5ad4c85b8 --

[issue37961] Tracemalloc traces do not include original stack trace length

2020-12-16 Thread miss-islington
Change by miss-islington : -- nosy: +miss-islington nosy_count: 3.0 -> 4.0 pull_requests: +22670 pull_request: https://github.com/python/cpython/pull/23809 ___ Python tracker _

[issue40421] [C API] Add getter functions for PyFrameObject and maybe move PyFrameObject to the internal C API

2020-12-16 Thread STINNER Victor
STINNER Victor added the comment: New changeset 166286849048eccadecf02b242dbc4042b780944 by Victor Stinner in branch '3.9': Add symbols of the stable ABI to python3dll.c (GH-23598) (GH-23801) https://github.com/python/cpython/commit/166286849048eccadecf02b242dbc4042b780944 -- _

[issue37194] Move new vector private declarations to the internal C API

2020-12-16 Thread STINNER Victor
STINNER Victor added the comment: New changeset 166286849048eccadecf02b242dbc4042b780944 by Victor Stinner in branch '3.9': Add symbols of the stable ABI to python3dll.c (GH-23598) (GH-23801) https://github.com/python/cpython/commit/166286849048eccadecf02b242dbc4042b780944 -- _

[issue39947] [C API] Make the PyThreadState structure opaque (move it to the internal C API)

2020-12-16 Thread STINNER Victor
STINNER Victor added the comment: New changeset 166286849048eccadecf02b242dbc4042b780944 by Victor Stinner in branch '3.9': Add symbols of the stable ABI to python3dll.c (GH-23598) (GH-23801) https://github.com/python/cpython/commit/166286849048eccadecf02b242dbc4042b780944 -- _

[issue42415] python3.lib in Python3.9.0 Windows distribution does not contain PyObject_CallNoArgs symbol

2020-12-16 Thread STINNER Victor
STINNER Victor added the comment: Thanks David Hewitt for the bug report, and Zackery Spytz for your fix! 3.9 fix: commit 166286849048eccadecf02b242dbc4042b780944 Author: Victor Stinner Date: Wed Dec 16 22:41:47 2020 +0100 Add symbols of the stable ABI to python3dll.c (GH-23598) (GH-2

[issue42125] linecache cannot get source for the __main__ module with a custom loader

2020-12-16 Thread Brett Cannon
Change by Brett Cannon : -- nosy: -brett.cannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue39041] Support GitHub Actions in CI

2020-12-16 Thread Brett Cannon
Brett Cannon added the comment: Your question is best directed at https://discuss.python.org/c/core-workflow/8, Daniel. -- ___ Python tracker ___

[issue37961] Tracemalloc traces do not include original stack trace length

2020-12-16 Thread miss-islington
miss-islington added the comment: New changeset 78062e07bc7c3b47ffdcdec786b259dda376370c by Miss Islington (bot) in branch '3.9': bpo-37961: Fix regression in tracemalloc.Traceback.__repr__ (GH-23805) https://github.com/python/cpython/commit/78062e07bc7c3b47ffdcdec786b259dda376370c

[issue42659] Objects of uname_result Class Cannot be Successfully Pickled

2020-12-16 Thread Jason R. Coombs
Jason R. Coombs added the comment: The PR for the related issue does address pickling. Do you expect pickles to work across Python versions? -- ___ Python tracker ___ ___

[issue42659] Objects of uname_result Class Cannot be Successfully Pickled

2020-12-16 Thread CrocoDuck
CrocoDuck added the comment: Hi, I somehow missed the other issue while searching for something similar to this, sorry about that. The main issue is that files pickled with python 3.9.0 cannot be read back by using python 3.9.0 if they contain a `uname_result` object. As for expecting pickl

[issue39041] Support GitHub Actions in CI

2020-12-16 Thread Daniel Hahler
Change by Daniel Hahler : -- nosy: +blueyed -blueyed2 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue39041] Support GitHub Actions in CI

2020-12-16 Thread Daniel Hahler
Daniel Hahler added the comment: Brett, thanks for the reference. I've found https://discuss.python.org/t/coverage-report-in-github-ci-for-standard-library/2836/11, and https://bugs.python.org/issue40993 through it. -- ___ Python tracker

[issue1635741] Py_Finalize() doesn't clear all Python objects at exit

2020-12-16 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +22671 pull_request: https://github.com/python/cpython/pull/23811 ___ Python tracker ___

[issue42664] strptime(%c) fails to parse the output of strftime(%c)

2020-12-16 Thread sds
New submission from sds : >>> import datetime, locale >>> locale.getlocale() ('en_US', 'UTF-8') >>> datetime.datetime.strptime("%c",datetime.datetime.now().strftime("%c")) Traceback (most recent call last): File "", line 1, in File "/usr/lib/python3.8/_strptime.py", line 568, in _strptime_d

[issue41478] Empty representation of AssertionError

2020-12-16 Thread Irit Katriel
Change by Irit Katriel : -- resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Python-b

[issue42090] zipfile.Path.joinpath API inconsistent with pathlib.Path.joinpath

2020-12-16 Thread Jason R. Coombs
Change by Jason R. Coombs : -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___

[issue42664] strptime(%c) fails to parse the output of strftime(%c)

2020-12-16 Thread Eric V. Smith
Eric V. Smith added the comment: You have the parameters to strptime backward. >>> datetime.datetime.strptime(datetime.datetime.now().strftime("%c"), "%c") datetime.datetime(2020, 12, 16, 20, 51, 38) -- nosy: +eric.smith ___ Python tracker

[issue42664] strptime(%c) fails to parse the output of strftime(%c)

2020-12-16 Thread Eric V. Smith
Change by Eric V. Smith : -- resolution: -> not a bug stage: -> resolved status: open -> closed type: -> behavior ___ Python tracker ___

[issue42659] Objects of uname_result Class Cannot be Successfully Pickled

2020-12-16 Thread Jason R. Coombs
Change by Jason R. Coombs : -- keywords: +patch pull_requests: +22672 stage: -> patch review pull_request: https://github.com/python/cpython/pull/23010 ___ Python tracker ___

[issue17140] Document multiprocessing.pool.ThreadPool

2020-12-16 Thread Matt Wozniski
Change by Matt Wozniski : -- keywords: +patch nosy: +godlygeek nosy_count: 7.0 -> 8.0 pull_requests: +22673 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/23812 ___ Python tracker

[issue41960] Add globalns and localns to the inspect.signature and inspect.Signature.from_callable

2020-12-16 Thread Guido van Rossum
Guido van Rossum added the comment: It's been a while, I've lost context for this idea. What problem are you trying to solve here? Are there issues where people have reported problems that this would allow them to solve? -- ___ Python tracker

[issue42651] Recursive traceback crashes Python Interpreter

2020-12-16 Thread Xinmeng Xia
Change by Xinmeng Xia : -- title: Title: Recursive traceback crashes Python Interpreter -> Recursive traceback crashes Python Interpreter ___ Python tracker ___

[issue41804] test_epoll fails test_control_and_wait() randomly on aarch64 RHEL8 Refleaks 3.9

2020-12-16 Thread miss-islington
Change by miss-islington : -- nosy: +miss-islington nosy_count: 1.0 -> 2.0 pull_requests: +22674 pull_request: https://github.com/python/cpython/pull/23813 ___ Python tracker _

[issue41804] test_epoll fails test_control_and_wait() randomly on aarch64 RHEL8 Refleaks 3.9

2020-12-16 Thread miss-islington
Change by miss-islington : -- pull_requests: +22675 pull_request: https://github.com/python/cpython/pull/23814 ___ Python tracker ___ __

[issue41804] test_epoll fails test_control_and_wait() randomly on aarch64 RHEL8 Refleaks 3.9

2020-12-16 Thread STINNER Victor
STINNER Victor added the comment: Oh, test_epoll failed on 3.9. So I backported my change to 3.8 and 3.9, to see if it helps or not. s390x RHEL8 Refleaks 3.9: https://buildbot.python.org/all/#builders/326/builds/159 Traceback (most recent call last): File "/home/dje/cpython-buildarea/3.9.

[issue31904] Python should support VxWorks RTOS

2020-12-16 Thread Peixing Xin
Change by Peixing Xin : -- pull_requests: +22676 pull_request: https://github.com/python/cpython/pull/23815 ___ Python tracker ___ _

<    1   2