[issue40952] GCC overflow warnings (format-overflow, stringop-overflow)

2020-06-12 Thread Christian Heimes
New submission from Christian Heimes : I'm getting a couple of compiler warnings with gcc-10.1.1 (Fedora 32) with an asan and ubsan build: Parser/string_parser.c: In function ‘decode_unicode_with_escapes’: Parser/string_parser.c:100:17: warning: null destination pointer [-Wformat-overflow=]

[issue40953] _PyWideStringList_Copy breaks asan builds

2020-06-12 Thread Christian Heimes
New submission from Christian Heimes : It's not possible to build Python with address sanitizer and memory leak checker asan. $ ./configure --with-address-sanitizer --with-undefined-behavior-sanitizer $ make ... ./python -E -S -m sysconfig --generate-posix-vars ;\ if test $? -ne 0 ; then \

[issue40890] Dict views should be introspectable

2020-06-12 Thread Dennis Sweeney
Dennis Sweeney added the comment: Would it be better to have a dictview.mapping() method rather than an attribute, since it constructs a new object of a different type and since that's what keys(), values(), and items() are? -- ___ Python tracker

[issue36225] [subinterpreters] Lingering subinterpreters should be implicitly cleared on shutdown

2020-06-12 Thread Ned Deily
Ned Deily added the comment: I note this is marked as a 3.7regression and still open. Since the cutoff for the final 3.7 bugfix mode release is in a few days, I'm assuming this means that 3.7 users will have to live with this regression. If you feel that is a problem, speak up now. ---

[issue37193] Memory leak while running TCP/UDPServer with socketserver.ThreadingMixIn

2020-06-12 Thread Ned Deily
Ned Deily added the comment: I note this is marked as a 3.7regression and still open. Since the cutoff for the final 3.7 bugfix mode release is in a few days, I'm assuming this means that 3.7 users will have to live with this regression. If you feel that is a problem, speak up now. ---

[issue34226] cgi.parse_multipart() requires undocumented CONTENT-LENGTH in Python 3.7

2020-06-12 Thread Ned Deily
Ned Deily added the comment: I note this is marked as a 3.7regression and still open. Since the cutoff for the final 3.7 bugfix mode release is in a few days, I'm assuming this means that 3.7 users will have to live with this regression. If you feel that is a problem, speak up now. ---

[issue36403] AsyncIterator on 3.7: __aiter__ no longer honors finally blocks

2020-06-12 Thread Ned Deily
Ned Deily added the comment: I note this is marked as a 3.7regression and still open. Since the cutoff for the final 3.7 bugfix mode release is in a few days, I'm assuming this means that 3.7 users will have to live with this regression. If you feel that is a problem, speak up now. ---

[issue40954] freeze.py aborts on macOS

2020-06-12 Thread 小本健司
New submission from 小本健司 : freeze.py (in cpython/Tools/freeze) fails with the folloing error. ``` $ ~/.pyenv/versions/3.8.0/bin/python freeze.py Error: needed directory /Users/k-omoto/.pyenv/versions/3.8.0/lib/python3.8/config-3.8 not found Use ``freeze.py -h'' for help ``` -- componen

[issue40164] Upgrade Windows and macOS installer builds to OpenSSL 1.1.1g

2020-06-12 Thread Ned Deily
Ned Deily added the comment: Any chance of getting the Windows builds using 1.1.1g for the upcoming 3.7.8? -- ___ Python tracker ___ __

[issue28068] Error in freeze.py due to unguarded sys.abiflags usage under Windows

2020-06-12 Thread Ned Deily
Ned Deily added the comment: This appears to be a duplicate of Issue32217 which was fixed in 3.7.4 and 3.8.0. If that doesn't solve the problem, please reopen with a current failure. -- nosy: +ned.deily resolution: -> duplicate stage: patch review -> resolved status: open -> closed v

[issue40954] freeze.py aborts on macOS

2020-06-12 Thread Ned Deily
Ned Deily added the comment: Thank you for the report. At first glance, it looks like this might be a duplicate of languishing Issue24871 for which a patch exists. Perhaps you could try applying the patch there to freeze.py and see whether that helps. Unfortunately, freeze.py does not get a

[issue40955] subprocess_fork_exec leaks memory

2020-06-12 Thread Christian Heimes
New submission from Christian Heimes : asan has detected a minor memory leak in subprocess_fork_exec: Direct leak of 8 byte(s) in 1 object(s) allocated from: #0 0x7f008bf19667 in __interceptor_malloc (/lib64/libasan.so.6+0xb0667) #1 0x7f007a0bee4a in subprocess_fork_exec /home/heimes/d

[issue40955] subprocess_fork_exec leaks memory

2020-06-12 Thread Christian Heimes
Change by Christian Heimes : -- keywords: +patch pull_requests: +20020 stage: -> patch review pull_request: https://github.com/python/cpython/pull/20825 ___ Python tracker ___

[issue40956] Use Argument Clinic in sqlite3

2020-06-12 Thread Erlend Egeberg Aasland
New submission from Erlend Egeberg Aasland : Use Argument Clinic in sqlite3. -- components: Library (Lib) messages: 371347 nosy: erlendaasland priority: normal severity: normal status: open title: Use Argument Clinic in sqlite3 type: enhancement versions: Python 3.10 __

[issue40956] Use Argument Clinic in sqlite3

2020-06-12 Thread Erlend Egeberg Aasland
Change by Erlend Egeberg Aasland : -- keywords: +patch pull_requests: +20021 stage: -> patch review pull_request: https://github.com/python/cpython/pull/20826 ___ Python tracker _

[issue40498] Holding spacebar on button widget permanently makes it SUNKEN even after release (and wait).

2020-06-12 Thread E. Paine
E. Paine added the comment: I agree this is a Windows issue (though I haven't tested on MacOS), but I don't think it is a tkinter issue. Running 'wish' on the following, behaves exactly the same: pack [button .button1 -text {click me}] Thank you for reporting this, but unless this behaviour

[issue40957] _Py_fopen_obj leaks reference on audit error

2020-06-12 Thread Christian Heimes
New submission from Christian Heimes : Direct leak of 50 byte(s) in 1 object(s) allocated from: #0 0x7f429c681667 in __interceptor_malloc (/lib64/libasan.so.6+0xb0667) #1 0x487496 in _PyBytes_FromSize Objects/bytesobject.c:81 #2 0x487496 in PyBytes_FromStringAndSize Objects/bytesobje

[issue40957] _Py_fopen_obj leaks reference on audit error

2020-06-12 Thread Christian Heimes
Change by Christian Heimes : -- keywords: +patch pull_requests: +20022 stage: -> patch review pull_request: https://github.com/python/cpython/pull/20827 ___ Python tracker ___

[issue34226] cgi.parse_multipart() requires undocumented CONTENT-LENGTH in Python 3.7

2020-06-12 Thread Niklas Sombert
Niklas Sombert added the comment: Since there's the easy workaround of just setting pdict["CONTENT-LENGTH"] I personally don't have a problem with this staying the way it is. But it would be really nice if this were documented somewhere. -- ___ Py

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Christian Heimes
New submission from Christian Heimes : ASAN/UBSAN has detected a heap-buffer-overflow in pegen.c ==1625693==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x60626b71 at pc 0x0073574d bp 0x7fff297284f0 sp 0x7fff297284e0 READ of size 1 at 0x60626b71 thread T0 #0 0x73574

[issue40219] ttk LabeledScale: label covered by hidden element

2020-06-12 Thread E. Paine
E. Paine added the comment: This is indeed a tkinter issue and is caused by the placeholder label. As the main label is added to the frame using the place manager, this placeholder is required to make the frame the correct height. I have attached a small diff which lowers this placeholder, f

[issue40959] Remove unused and unneeded function declaration from sqlite3 header files

2020-06-12 Thread Erlend Egeberg Aasland
New submission from Erlend Egeberg Aasland : The following function declarations can safely be removed because they're either unused or unneeded. In Modules/_sqlite/cache.h: pysqlite_node_init() // unused; no function definition pysqlite_node_dealloc() // unneeded; file scope pysqlite_cac

[issue40959] Remove unused and unneeded function declaration from sqlite3 header files

2020-06-12 Thread Erlend Egeberg Aasland
Change by Erlend Egeberg Aasland : -- keywords: +patch pull_requests: +20023 stage: -> patch review pull_request: https://github.com/python/cpython/pull/20828 ___ Python tracker _

[issue40960] Fix the example in hashlib documentarion

2020-06-12 Thread Marcelo
New submission from Marcelo : The documentation found in https://docs.python.org/2/library/hashlib.html give us the following example: ``` More condensed: >>> hashlib.sha224("Nobody inspects the spammish repetition").hexdigest() 'a4337bc45a8fc544c03f52dc550cd6e1e87021bc896588bd79e901e2' ```

[issue40960] Fix the example in hashlib documentarion

2020-06-12 Thread Cheryl Sabella
Cheryl Sabella added the comment: Hi Marcelo, Thanks for the report. The version of the documentation that you linked to is for Python 2. At the top of that page, there is a redirect to the Python 3 documentation at https://docs.python.org/3/library/hashlib.html. You'll see that the Pyth

[issue38905] venv python reports wrong sys.executable in a subprocess on Windows

2020-06-12 Thread Steve Dower
Steve Dower added the comment: Thanks for confirming that reality aligns with the documentation. > when doing the same and passing `shell=True` to the POpen() call, there is no > such initial folder in the lookup Correct, because a fully qualified path to cmd.exe is used, and cmd.exe's appl

[issue33881] dataclasses should use NFKC to find duplicate members

2020-06-12 Thread Cheryl Sabella
Cheryl Sabella added the comment: The pull request that was opened for this has been closed due to inactivity, so this issue is available for anyone to work on. -- nosy: +cheryl.sabella versions: +Python 3.10, Python 3.8, Python 3.9 -Python 3.7 ___

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- nosy: +lys.nikolaou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Lysandros, could you take a look? -- ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Christian, what test are you running to get the error? -- ___ Python tracker ___ ___ Pytho

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: > Lysandros, could you take a look? Yup, I'm on it. -- ___ Python tracker ___ ___ Python-bug

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Note that although we could just exit if the length of the line is smaller than the column offset before calling https://github.com/python/cpython/blob/master/Parser/pegen.c#L148 (I assume that is the problem) is more important to understand how are w

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: Agreed. For that I'd probably need the input Christian is getting the error with. I'm currently trying things out, but haven't gotten the error yet. -- ___ Python tracker _

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Seems that just this (at top level): >> yield from is able to produce a situation where the column offset is bigger than the line length: Col offset is 11 and line is 10 -- ___ Python tracker

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- Removed message: https://bugs.python.org/msg371364 ___ Python tracker ___ ___ Python-bugs-list

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: You can get an assert failure without ASAN with this patch: diff --git a/Parser/pegen.c b/Parser/pegen.c index e29910bf86..65fa44921f 100644 --- a/Parser/pegen.c +++ b/Parser/pegen.c @@ -145,6 +145,9 @@ byte_offset_to_character_offset(PyObject *line, in

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Correcting my previous post (deleted): You can get an assert failure without ASAN with this patch: diff --git a/Parser/pegen.c b/Parser/pegen.c index e29910bf86..65fa44921f 100644 --- a/Parser/pegen.c +++ b/Parser/pegen.c @@ -145,6 +145,9 @@ byte_offse

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: I theorize that this happens when the error points to the end of the line. I assume that the difference between col_offset and PyUnicode_GET_LENGTH(line) may be still bigger than 1 if the line contains some Unicode stuff like with: >> "Ṕýţĥòñ" + but I

[issue34226] cgi.parse_multipart() requires undocumented CONTENT-LENGTH in Python 3.7

2020-06-12 Thread Senthil Kumaran
Senthil Kumaran added the comment: I will spend time on this on 12-June or 13-June, 2020. At the very least, if no changes are required, I will document this for 3.7 and higher versions. -- assignee: docs@python -> orsenthil ___ Python tracker

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Christian Heimes
Christian Heimes added the comment: I'm using an ASAN UBSAN build of Python: $ make clean $ ./configure --with-address-sanitizer --with-undefined-behavior-sanitizer $ cat > asan-suppression.txt << EOF # Python/initconfig.c leak:_PyWideStringList_Copy EOF $ LSAN_OPTIONS="suppressions=asan-suppr

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: I cannot reproduce this on my Ubuntu 20.04: ➜ cpython git:(master) ✗ LSAN_OPTIONS="suppressions=asan-suppression.txt,print_suppressions=0" ./python -m test -v test_eof Modules/posixmodule.c:14682:9: runtime error: left shift of 34 by 26 places cannot be

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: Running Pablo's examples in the REPL does not reproduce the errors either: ➜ cpython git:(master) ✗ LSAN_OPTIONS="suppressions=asan-suppression.txt,print_suppressions=0" ./python Modules/posixmodule.c:14682:9: runtime error: left shif

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Christian Heimes
Christian Heimes added the comment: Did you clean and compile with asan/ubsan? Older compilers may not detect the issue. My system has GCC 10: libubsan-10.1.1-1.fc32.x86_64 gcc-10.1.1-1.fc32.x86_64 libasan-10.1.1-1.fc32.x86_64 -- ___ Python tracker

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Lysandros, are you using a debug build? The assert() won't trigger if you don't have run configure with --with-pydebug. I would recommend to: make distclean && ./configure --with-pydebug && make -- ___ Pyth

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: Let me try that. I'm currently using gcc 9.3. -- ___ Python tracker ___ ___ Python-bugs-list

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: I now configured Python with ./configure --with-pydebug --with-address-sanitizer --with-undefined-behavior-sanitizer. -- ___ Python tracker

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: > Lysandros, are you using a debug build? The assert() won't trigger if you > don't have run configure with --with-pydebug. BTW I'm not talking about the assert not triggering. I'm only saying that ASAN/UBSAN do not report an error when running `yield fr

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Oh, I was confused by this: > Running Pablo's examples in the REPL does not reproduce the errors either: I thought you meant that you could not reproduce the crash also with my patch. For the ASAN, you may need the newer gcc and other stuff. I was no

[issue40961] os.putenv should be documented as not affecting os.getenv's return value

2020-06-12 Thread Daniel Martin
New submission from Daniel Martin : I find this behavior extremely surprising: $ ABC=def python Python 3.7.4 (v3.7.4:e09359112e, Jul 8 2019, 14:54:52) [Clang 6.0 (clang-600.0.57)] on darwin Type "help", "copyright", "credits" or "license" for more information. >>> import os >>> os.getenv('ABC'

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: Is the only way to get gcc-10.1 to build from source? Because currently my internet connection is too slow to get all of gcc downloaded and `apt install gcc-10` installs 10.0.1, which I'm getting totally unrelated erros with. --

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > Is the only way to get gcc-10.1 to build from source? Because currently my > internet connection is too slow to get all of gcc downloaded and `apt install > gcc-10` installs 10.0.1, which I'm getting totally unrelated erros with. If your package man

[issue39035] Travis CI fail on backports: pyvenv not installed

2020-06-12 Thread Larry Hastings
Larry Hastings added the comment: New changeset f88b578949a034f511dd1b4c1c161351b3ee0db8 by Inada Naoki in branch '3.5': bpo-39035: travis: Update image to xenial (#17623) https://github.com/python/cpython/commit/f88b578949a034f511dd1b4c1c161351b3ee0db8 -- nosy: +larry

[issue40955] subprocess_fork_exec leaks memory when extra_groups are supplied

2020-06-12 Thread Gregory P. Smith
Change by Gregory P. Smith : -- title: subprocess_fork_exec leaks memory -> subprocess_fork_exec leaks memory when extra_groups are supplied ___ Python tracker ___ ___

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: > Note that although we could just exit if the length of the line is smaller > than the column offset before calling > https://github.com/python/cpython/blob/master/Parser/pegen.c#L148 (I assume > that is the problem) is more important to understand how

[issue40670] supplying an empty string to timeit causes an IndentationError

2020-06-12 Thread Roundup Robot
Change by Roundup Robot : -- nosy: +python-dev nosy_count: 6.0 -> 7.0 pull_requests: +20024 pull_request: https://github.com/python/cpython/pull/20830 ___ Python tracker ___ __

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > returns an object that is one character shorter than the col_offset and > that's how we get to the situation you mentioned. What happens with: >>> "Ṕýţĥòñ" + -- ___ Python tracker

[issue40945] TKinter.Tk.geometry(Tk.winfo_geometry()) should be idempotent

2020-06-12 Thread Ben Li-Sauerwine
Ben Li-Sauerwine added the comment: Thanks for clarifying. Using Tk.geometry() instead of Tk.winfo_geometry() does indeed resolve the issue on Linux. Weird that using Tk.winfo_geometry() is idempotent under Windows, though. -- ___ Python tracker

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: > What happens with: >>> "Ṕýţĥòñ" + Exact same thing. The offset is 16 at the start and gets decreased to 15 in the line I linked to in my previous post. And then col_offset gets converted to col_number which is 9, which seems correct. Although it is co

[issue40935] Links to Python3 docs for some libs return 404

2020-06-12 Thread Edison Abahurire
Edison Abahurire added the comment: @Ned, I'm going to search through the docs for any links that may need redirecting, and provide their python3 alternatives. -- ___ Python tracker

[issue39073] [security] email module incorrect handling of CR and LF newline characters in Address objects.

2020-06-12 Thread Larry Hastings
Larry Hastings added the comment: New changeset f91a0b6df14d6c5133fe3d5889fad7d84fc0c046 by Victor Stinner in branch '3.5': bpo-39073: validate Address parts to disallow CRLF (#19007) (#20450) https://github.com/python/cpython/commit/f91a0b6df14d6c5133fe3d5889fad7d84fc0c046 -- nosy:

[issue40962] Add documentation for asyncio._set_running_loop()

2020-06-12 Thread Eugene Huang
New submission from Eugene Huang : In the pull request https://github.com/python/asyncio/pull/452#issue-92245081 the linked comment says that `asyncio._set_running_loop()` is part of the public asyncio API and will be documented, but I couldn't find any references to this function in

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Well, I think the solution here is to clip the col_offset to the line length and maybe adding assert that the difference is not bigger than 1. -- ___ Python tracker

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: I'm guessing that some parts of the conversion code were only there to circumvent issues in displaying the error messages that weren't pegen's fault. These were fixed by Guido in GH-20072, so I think we can delete some of them. For example, this patch wo

[issue40219] ttk LabeledScale: label covered by hidden element

2020-06-12 Thread Terry J. Reedy
Terry J. Reedy added the comment: Right. LabelScale is a tkinter.ttk extension, like OptionMenu. If I do the PR, I would call the placeholder 'dummy' since it is permanent (not removed after initialization). I'd like to see what happens without it and expand the comment to a line like

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Can you run the test suite before/after of pyflakes to make sure we don't introduce any regression to double check? If everything looks fine, open a PR :) -- ___ Python tracker

[issue40955] subprocess_fork_exec leaks memory when extra_groups are supplied

2020-06-12 Thread miss-islington
miss-islington added the comment: New changeset 0d3350daa8123a3e16d4a534b6e873eb12c10d7c by Christian Heimes in branch 'master': bpo-40955: Fix memory leak in subprocess module (GH-20825) https://github.com/python/cpython/commit/0d3350daa8123a3e16d4a534b6e873eb12c10d7c -- nosy: +mis

[issue40955] subprocess_fork_exec leaks memory when extra_groups are supplied

2020-06-12 Thread miss-islington
Change by miss-islington : -- pull_requests: +20025 pull_request: https://github.com/python/cpython/pull/20831 ___ Python tracker ___ __

[issue40955] subprocess_fork_exec leaks memory when extra_groups are supplied

2020-06-12 Thread miss-islington
Change by miss-islington : -- pull_requests: +20026 pull_request: https://github.com/python/cpython/pull/20832 ___ Python tracker ___ __

[issue40955] subprocess_fork_exec leaks memory when extra_groups are supplied

2020-06-12 Thread miss-islington
Change by miss-islington : -- pull_requests: +20027 pull_request: https://github.com/python/cpython/pull/20833 ___ Python tracker ___ __

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: > Can you run the test suite before/after of pyflakes to make sure we don't > introduce any regression to double check? If everything looks fine, open a PR > :) The exact same errors before and after! I'll wait on the PR though till someone has checked

[issue39827] setting a locale that uses comma as decimal separator breaks tkinter.DoubleVar

2020-06-12 Thread E. Paine
E. Paine added the comment: Is this a problem exclusive to tkinter? I ran the following code, and it appears to be an issue with the builtin 'float' method: >>> import locale >>> locale.setlocale(locale.LC_NUMERIC, 'de_DE.utf8') 'de_DE.utf8' >>> float("1,2") ValueError: could not convert stri

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Ok, I was able to reproduce: ❯ gcc --version gcc (GCC) 10.1.0 Copyright (C) 2020 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR

[issue40955] subprocess_fork_exec leaks memory when extra_groups are supplied

2020-06-12 Thread miss-islington
miss-islington added the comment: New changeset ee3f7fee94915ab4f34c92d6c89b211de476660d by Miss Islington (bot) in branch '3.9': bpo-40955: Fix memory leak in subprocess module (GH-20825) https://github.com/python/cpython/commit/ee3f7fee94915ab4f34c92d6c89b211de476660d --

[issue40955] subprocess_fork_exec leaks memory when extra_groups are supplied

2020-06-12 Thread Christian Heimes
Christian Heimes added the comment: 3.8 and 3.7 don't have the code path and are not affected. -- components: +Extension Modules -FreeBSD resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 3.7, Python 3.8 ___

[issue40890] Dict views should be introspectable

2020-06-12 Thread Raymond Hettinger
Raymond Hettinger added the comment: New changeset 3ee0e48b0376a710c08eec6f30e4181563b192a2 by Dennis Sweeney in branch 'master': bpo-40890: Add `mapping` property to dict views (GH-20749) https://github.com/python/cpython/commit/3ee0e48b0376a710c08eec6f30e4181563b192a2 --

[issue40890] Dict views should be introspectable

2020-06-12 Thread Raymond Hettinger
Change by Raymond Hettinger : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: > +Py_ssize_t linesize = PyUnicode_GET_LENGTH(line); This line is wrong though, since PyUnicode_GET_LENGTH returns the length in code points and PyUnicode_DecodeUTF8 expects the number of bytes. For non-ascii input this would push the caret further to

[issue40963] distutils make_zipfile uses random order

2020-06-12 Thread ghost43
New submission from ghost43 : I am trying to generate .zip sdists for a project in a reproducible manner, using setuptoools. The generated zips differ in the order of packed files. The root cause of the non-determinicity is using os.walk() in make_zipfile here: https://github.com/python/cpytho

[issue40164] Upgrade Windows and macOS installer builds to OpenSSL 1.1.1g

2020-06-12 Thread Steve Dower
Steve Dower added the comment: Yeah, I'll get onto it now. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40164] Upgrade Windows and macOS installer builds to OpenSSL 1.1.1g

2020-06-12 Thread శ్రీనివాస్ రెడ్డి తాటిపర్తి
Change by Srinivas Reddy Thatiparthy(శ్రీనివాస్ రెడ్డి తాటిపర్తి) : -- nosy: +thatiparthy nosy_count: 9.0 -> 10.0 pull_requests: +20028 pull_request: https://github.com/python/cpython/pull/20834 ___ Python tracker

[issue40164] Upgrade Windows and macOS installer builds to OpenSSL 1.1.1g

2020-06-12 Thread శ్రీనివాస్ రెడ్డి తాటిపర్తి
Srinivas Reddy Thatiparthy(శ్రీనివాస్ రెడ్డి తాటిపర్తి) added the comment: Steve, I have done it. And I didn't see your reply. -- ___ Python tracker ___ __

[issue40855] statistics.stdev ignore xbar argument

2020-06-12 Thread Raymond Hettinger
Change by Raymond Hettinger : -- keywords: +patch pull_requests: +20029 stage: -> patch review pull_request: https://github.com/python/cpython/pull/20835 ___ Python tracker __

[issue40964] Connection to IMAP server cyrus.andrew.cmu.edu hangs

2020-06-12 Thread Christian Heimes
New submission from Christian Heimes : All buildbots and tests are currently failing because connections cyrus.andrew.cmu.edu:143 (IMAP) and cyrus.andrew.cmu.edu:993 (IMAPS) are hanging. -- components: Tests messages: 371403 nosy: christian.heimes, lukasz.langa, ned.deily priority: re

[issue40964] Connection to IMAP server cyrus.andrew.cmu.edu hangs

2020-06-12 Thread Christian Heimes
Change by Christian Heimes : -- assignee: -> christian.heimes ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40164] Upgrade Windows and macOS installer builds to OpenSSL 1.1.1g

2020-06-12 Thread Steve Dower
Steve Dower added the comment: Thanks. Your PR will start to work once I've done the updated build, so don't worry about the failure right now. OpenSSL updates require build manager involvement, so it's blocked on me :) -- ___ Python tracker

[issue40964] Connection to IMAP server cyrus.andrew.cmu.edu hangs

2020-06-12 Thread Christian Heimes
Change by Christian Heimes : -- keywords: +patch pull_requests: +20030 stage: -> patch review pull_request: https://github.com/python/cpython/pull/20836 ___ Python tracker ___

[issue33881] dataclasses should use NFKC to find duplicate members

2020-06-12 Thread శ్రీనివాస్ రెడ్డి తాటిపర్తి
Change by Srinivas Reddy Thatiparthy(శ్రీనివాస్ రెడ్డి తాటిపర్తి) : -- nosy: +thatiparthy nosy_count: 4.0 -> 5.0 pull_requests: +20031 pull_request: https://github.com/python/cpython/pull/20837 ___ Python tracker

[issue40958] ASAN/UBSAN: heap-buffer-overflow in pegen.c

2020-06-12 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > This line is wrong though, since PyUnicode_GET_LENGTH returns the length in > code points Whoops! Thanks for pointing that out. In any case, the patch still shows that the ASAN error goes away by limiting the access to the string so I suppose that

[issue40964] Connection to IMAP server cyrus.andrew.cmu.edu hangs

2020-06-12 Thread Ned Deily
Ned Deily added the comment: New changeset 08b1bbab6bfa1ff726db13a9fc3885329f73dca4 by Christian Heimes in branch 'master': bpo-40964: disable remote IMAP tests (GH-20836) https://github.com/python/cpython/commit/08b1bbab6bfa1ff726db13a9fc3885329f73dca4 -- _

[issue40964] Connection to IMAP server cyrus.andrew.cmu.edu hangs

2020-06-12 Thread Christian Heimes
Christian Heimes added the comment: The remote server is having intermittent issues. Sometimes all three servers behind the host are gone, sometimes they block all packages. # nmap -vv cyrus.andrew.cmu.edu Starting Nmap 7.80 ( https://nmap.org ) at 2020-06-12 20:52 CEST Warning: Hostname cyru

[issue40913] time.sleep ignores errors on Windows

2020-06-12 Thread Steve Dower
Steve Dower added the comment: ... equally happy without an explicit test in anything that's only prerelease right now. -- ___ Python tracker ___

[issue40913] time.sleep ignores errors on Windows

2020-06-12 Thread Steve Dower
Steve Dower added the comment: You could test this by getting the event and CloseHandle-ing it. A function to do this could be added to _testcapimodule. It'd have to run in its own process, but we have (a few) helpers around for this. Given the concerns, I don't think we should change this i

[issue40964] Connection to IMAP server cyrus.andrew.cmu.edu hangs

2020-06-12 Thread Christian Heimes
Change by Christian Heimes : -- type: -> behavior ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue40964] Connection to IMAP server cyrus.andrew.cmu.edu hangs

2020-06-12 Thread Ned Deily
Ned Deily added the comment: New changeset f91917908749cb595113f8d8428ae1d6241f0392 by Ned Deily (Christian Heimes) in branch '3.9': bpo-40964: disable remote IMAP tests (GH-20836) https://github.com/python/cpython/commit/f91917908749cb595113f8d8428ae1d6241f0392 --

[issue40964] Connection to IMAP server cyrus.andrew.cmu.edu hangs

2020-06-12 Thread Ned Deily
Ned Deily added the comment: New changeset adce133378be75bcac4d61fd62a151852555000f by Ned Deily (Christian Heimes) in branch '3.8': bpo-40964: disable remote IMAP tests (GH-20836) https://github.com/python/cpython/commit/adce133378be75bcac4d61fd62a151852555000f --

[issue40964] Connection to IMAP server cyrus.andrew.cmu.edu hangs

2020-06-12 Thread Ned Deily
Ned Deily added the comment: New changeset 0abb70ec93bfc6724199b7dd6c89294ce7d83072 by Ned Deily (Christian Heimes) in branch '3.7': bpo-40964: disable remote IMAP tests (GH-20836) https://github.com/python/cpython/commit/0abb70ec93bfc6724199b7dd6c89294ce7d83072 --

[issue40913] time.sleep ignores errors on Windows

2020-06-12 Thread Eryk Sun
Eryk Sun added the comment: If WaitForSingleObjectEx fails, do you think the system error code should be raised as an OSError? Probably an invalid-handle or access-denied error is too cryptic here. It may be better to raise something like RuntimeError('time.sleep(): invalid SIGINT event hand

[issue40164] Upgrade Windows and macOS installer builds to OpenSSL 1.1.1g

2020-06-12 Thread Steve Dower
Steve Dower added the comment: Okay, new sources and build are up, so I retriggered the PR. If it's all good, I'll merge and backport. -- ___ Python tracker ___ _

[issue37910] argparse wrapping fails with metavar="" (no metavar)

2020-06-12 Thread Raymond Hettinger
Change by Raymond Hettinger : -- versions: +Python 3.10 -Python 2.7, Python 3.5, Python 3.6, Python 3.7, Python 3.8, Python 3.9 ___ Python tracker ___

[issue37910] argparse wrapping fails with metavar="" (no metavar)

2020-06-12 Thread Raymond Hettinger
Raymond Hettinger added the comment: Paul, what do you think about the PR? -- nosy: +rhettinger ___ Python tracker ___ ___ Python-b

  1   2   >