[issue40360] Deprecate lib2to3 (and 2to3) for future removal

2020-04-22 Thread Carl Meyer
Carl Meyer added the comment: I opened a PR. It deprecates the lib2to3 library to discourage future use of it for Python3, but not the 2to3 tool. This of course means that the lib2to3 module will in practice stick around in the stdlib as long as 2to3 is still bundled with Python. It seems l

[issue39939] PEP 616: Add str.removeprefix and str.removesuffix methods

2020-04-22 Thread STINNER Victor
STINNER Victor added the comment: Well done Dennis Sweeney! You got a PEP approved and now the implementation is merged! Maybe the documentation will need more reviews, but that can be done later. I prefer to get the implementation merged as soon as possible (it will likely be part of the

[issue40368] os.path.realpath uppercases Windows drive letter on Python 3.8

2020-04-22 Thread Kagami Sascha Rosylight
New submission from Kagami Sascha Rosylight : ``` $ python3.7 Python 3.7.4 (tags/v3.7.4:e09359112e, Jul 8 2019, 20:34:20) [MSC v.1916 64 bit (AMD64)] on win32 Type "help", "copyright", "credits" or "license" for more information. >>> import os;os.path.realpath('c:/') 'c:\\' ``` ``` $ python3.

[issue40368] os.path.realpath uppercases Windows drive letter on Python 3.8

2020-04-22 Thread Eryk Sun
Eryk Sun added the comment: > This behavior is inconsistent with `os.path.abspath` where it always > returns lowercased drive letter, ntpath.abspath calls GetFullPathNameW, which generally preserves the input case of the device/drive component. But it doesn't always preserve drive-letter c

[issue39939] PEP 616: Add str.removeprefix and str.removesuffix methods

2020-04-22 Thread Dennis Sweeney
Dennis Sweeney added the comment: There's a failure here: https://buildbot.python.org/all/#/builders/64/builds/656 Failed subtests: test_killed_child - test.test_concurrent_futures.ProcessPoolSpawnProcessPoolExecutorTest Traceback (most recent call last): ... OSError

[issue39939] PEP 616: Add str.removeprefix and str.removesuffix methods

2020-04-22 Thread STINNER Victor
STINNER Victor added the comment: > This should be unrelated to the patch, right? It's unrelated. It smells like bpo-39995. -- ___ Python tracker ___

[issue40334] PEP 617: new PEG-based parser

2020-04-22 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset c5fc15685202cda73f7c3f5c6f299b0945f58508 by Pablo Galindo in branch 'master': bpo-40334: PEP 617 implementation: New PEG parser for CPython (GH-19503) https://github.com/python/cpython/commit/c5fc15685202cda73f7c3f5c6f299b0945f58508 ---

[issue40334] PEP 617: new PEG-based parser

2020-04-22 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +18988 pull_request: https://github.com/python/cpython/pull/19664 ___ Python tracker ___ ___

[issue40346] Add random.BaseRandom to ease implementation of subclasses

2020-04-22 Thread STINNER Victor
STINNER Victor added the comment: Ok, PR 19631 is now ready for a review. I completed the documentation to better explain the rationale. Copy of the What's New in Python 3.9 documentation: "Add a new random.BaseRandom class: random number generator base class. A random.BaseRandom subclass m

[issue40334] PEP 617: new PEG-based parser

2020-04-22 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +18989 pull_request: https://github.com/python/cpython/pull/19666 ___ Python tracker ___ ___

[issue40334] PEP 617: new PEG-based parser

2020-04-22 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 458004bf7914f96b20bb76bc3584718cf83f652e by Pablo Galindo in branch 'master': bpo-40334: Fix errors in parse_string.c with old compilers (GH-19666) https://github.com/python/cpython/commit/458004bf7914f96b20bb76bc3584718cf83f652e --

[issue40334] PEP 617: new PEG-based parser

2020-04-22 Thread STINNER Victor
STINNER Victor added the comment: > bpo-40334: Fix errors in parse_string.c with old compilers (GH-19666) Pablo told me in private that he plans to add a buildbot worker to test the old parser. So this change is fine. -- ___ Python tracker

[issue40334] PEP 617: new PEG-based parser

2020-04-22 Thread Ned Deily
Ned Deily added the comment: Looks like the build changes do not work with a build directory outside of the source directory: mkdir build && cd build && ../configure && make gcc -c -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3 -Wall-std=c99 -Wextra -Wno-un

[issue40366] Start giving deprecation warnings for obsoleted flags in compile

2020-04-22 Thread Batuhan Taskaya
Batuhan Taskaya added the comment: As suggestion of @vstinner, instead of deprecation we decided to remove support for these flags immediately. -- ___ Python tracker ___

[issue40366] Remove support for obsolete flags in compile function

2020-04-22 Thread Batuhan Taskaya
Change by Batuhan Taskaya : -- title: Start giving deprecation warnings for obsoleted flags in compile -> Remove support for obsolete flags in compile function ___ Python tracker

[issue40334] PEP 617: new PEG-based parser

2020-04-22 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > Looks like the build changes do not work with a build directory outside of > the source directory: Opened https://github.com/python/cpython/pull/19667. Ned, could you review? -- ___ Python tracker

[issue40334] PEP 617: new PEG-based parser

2020-04-22 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +18990 pull_request: https://github.com/python/cpython/pull/19667 ___ Python tracker ___ ___

[issue40334] PEP 617: new PEG-based parser

2020-04-22 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +18992 pull_request: https://github.com/python/cpython/pull/19670 ___ Python tracker ___ __

[issue40334] PEP 617: new PEG-based parser

2020-04-22 Thread Lysandros Nikolaou
Change by Lysandros Nikolaou : -- pull_requests: +18991 pull_request: https://github.com/python/cpython/pull/19669 ___ Python tracker ___ __

[issue40334] PEP 617: new PEG-based parser

2020-04-22 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +18993 pull_request: https://github.com/python/cpython/pull/19668 ___ Python tracker ___ ___

[issue40334] PEP 617: new PEG-based parser

2020-04-22 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset a25f3c4c8f7d4878918ce1d3d67db40ae255ccc6 by Pablo Galindo in branch 'master': bpo-40334: Fix builds outside the source directory and regenerate autoconf files (GH-19667) https://github.com/python/cpython/commit/a25f3c4c8f7d4878918ce1d3d6

[issue36299] array: Deprecate 'u' type in array module

2020-04-22 Thread Inada Naoki
Inada Naoki added the comment: While array('u') doesn't use deprecated API with GH-19653, I still don't like 'u' because: * I don't have any reason to use platform dependant wchar_t. [1] * It is not consistent with PEP-3118. [1]: https://mail.python.org/pipermail/python-dev/2019-March/156807

[issue40334] PEP 617: new PEG-based parser

2020-04-22 Thread STINNER Victor
STINNER Victor added the comment: New changeset 1def7754b7a41fe57efafaf5eff24cfa15353444 by Victor Stinner in branch 'master': bpo-40334: Rename PyConfig.use_peg to _use_peg_parser (GH-19670) https://github.com/python/cpython/commit/1def7754b7a41fe57efafaf5eff24cfa15353444 -- _

[issue40334] PEP 617: new PEG-based parser

2020-04-22 Thread STINNER Victor
STINNER Victor added the comment: > bpo-40334: Rename PyConfig.use_peg to _use_peg_parser (GH-19670) This change removes sys.flags.use_peg which was only used in tests. If someone sees a good reason, we may add it back. In the meanwhile, test.support.use_old_parser() can be used. I didn't l

[issue40334] PEP 617: new PEG-based parser

2020-04-22 Thread STINNER Victor
STINNER Victor added the comment: test_peg_generator emits compiler warnings: https://buildbot.python.org/all/#/builders/612/builds/283 0:08:01 load avg: 1.40 [423/423/1] test_peg_generator passed (7 min 4 sec) /tmp/tmp0vbqe8gp/parse.c: In function ‘start_rule’: /tmp/tmp0vbqe8gp/parse.c:32:35:

[issue40334] PEP 617: new PEG-based parser

2020-04-22 Thread Lysandros Nikolaou
Lysandros Nikolaou added the comment: > test_peg_generator emits compiler warnings These are expected. Is this a problem? -- ___ Python tracker ___ __

[issue40334] PEP 617: new PEG-based parser

2020-04-22 Thread Wade Sanchez
Change by Wade Sanchez : -- type: -> resource usage ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue40334] PEP 617: new PEG-based parser

2020-04-22 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +18994 pull_request: https://github.com/python/cpython/pull/19671 ___ Python tracker ___ ___

[issue40361] Darwin systems using win settings for webbrowser.py

2020-04-22 Thread Viraat Das
Viraat Das added the comment: When loading Jupyter Notebook, a NotADirectoryError: [Errno 20] Not a directory: 'xdg-settings' error was showing. This seems to be because Darwin systems were using Win settings. The pull request has addressed this by modifying the webbrowser.py code. ---

[issue40334] PEP 617: new PEG-based parser

2020-04-22 Thread Ned Deily
Ned Deily added the comment: > These are expected. Is this a problem? People and bots running tests normally expect to not see any output from each test in the default case unless there are errors. If these are supposed to be emitted, we should find a way to hide them (and check the results

[issue40334] PEP 617: new PEG-based parser

2020-04-22 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +18996 pull_request: https://github.com/python/cpython/pull/19672 ___ Python tracker ___ ___

[issue40361] Darwin systems using win settings for webbrowser.py

2020-04-22 Thread Éric Araujo
Éric Araujo added the comment: xdg-settings is a program used on linux systems, not windows. Also it is an executable file, not a directory, so something weird is going on. Could you diagnose more? The proposed PR does not seem to make sense: platform can’t be both darwin and win32/nt. ---

[issue40334] PEP 617: new PEG-based parser

2020-04-22 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset ee40e4b8563e6e1bc2bfb267da5ffc9a2293318d by Pablo Galindo in branch 'master': bpo-40334: Don't downcast from Py_ssize_t to int (GH-19671) https://github.com/python/cpython/commit/ee40e4b8563e6e1bc2bfb267da5ffc9a2293318d --

[issue40369] Use PEP 590 vectorcall to speed up GenericAlias.

2020-04-22 Thread Dong-hee Na
New submission from Dong-hee Na : Since PEP 560 was approved, The following syntax has become available. from queue import Queue v = Queue[int] It's a very shiny feature. Given the direction of programming language, it's probably a very useful feature that users will use very often in the ne

[issue40334] PEP 617: new PEG-based parser

2020-04-22 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > test_peg_generator emits compiler warnings: This is fixed by https://github.com/python/cpython/pull/19672 -- ___ Python tracker ___

[issue40369] Use PEP 590 vectorcall to speed up GenericAlias.

2020-04-22 Thread Dong-hee Na
Change by Dong-hee Na : -- assignee: -> corona10 type: -> performance ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue40334] PEP 617: new PEG-based parser

2020-04-22 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Those warnings are legitimate: we cannot cast function pointers that have different return types from one to the other. This only happens in the test, but could happen in the grammar if we use lookahead with NAME (&NAME). -- _

[issue40346] Add random.BaseRandom to ease implementation of subclasses

2020-04-22 Thread Raymond Hettinger
Raymond Hettinger added the comment: This is a breaking change. The published API says that random() is the base method and that getrandbits() is optional. It is not okay to flat out ignore the opposing comments from the module maintainers. Being on the steering committee isn't a license t

[issue37465] Incorrect documentation for `s#` arguments in C API argument parsing

2020-04-22 Thread Inada Naoki
Inada Naoki added the comment: Fixed via GH-18663. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue37846] declare that Text I/O use buffer inside

2020-04-22 Thread Inada Naoki
Inada Naoki added the comment: I still think it's too detailed. Reading C and Python code is much better way to understand such implementation detail. -- resolution: -> rejected stage: -> resolved status: open -> closed ___ Python tracker

[issue38784] ip_network does not clear/update the broadcast_address cache when network_address is changed.

2020-04-22 Thread Inada Naoki
Inada Naoki added the comment: I close this issue as rejected. If you have opinion about this issue, please post to python-dev mailing list or discuss.python.org. -- resolution: -> rejected stage: -> resolved status: open -> closed ___ Python trac

[issue40370] AIX: ld_so_aix not found during test of test_peg_generator

2020-04-22 Thread Michael Felt
New submission from Michael Felt : As part, I assume, of PR19503, that includes 91 changed files with 27,058 additions and 147 deletions the AIX buildbot is broken. Rather than looking/finding Modules/ld_so_aix (where I expect it to be) tests are failing, ulitmately because they look/expect i

[issue37626] Documentation:conflict between docs

2020-04-22 Thread Inada Naoki
Inada Naoki added the comment: I don't think they are conflict. "now required to have a valid name." "were allowed to have name set to None [snip] This is no longer permitted." "None" is not "valid name". -- resolution: -> not a bug stage: -> resolved status: open -> closed _

[issue40370] AIX: ld_so_aix not found during test of test_peg_generator

2020-04-22 Thread Ned Deily
Change by Ned Deily : -- nosy: +pablogsal ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue40370] AIX: ld_so_aix not found during test of test_peg_generator

2020-04-22 Thread Ned Deily
Ned Deily added the comment: It looks like the newly added test_peg_gemerator tries to build C code at run time as part of executing the test. So most likely the test is not invoking distutils with the same set of options and/or environment variable values that the main Python setup.py does

[issue40334] PEP 617: new PEG-based parser

2020-04-22 Thread Ned Deily
Ned Deily added the comment: Issue40370 documents test_peg_generator breakage on an AIX buildbot. -- ___ Python tracker ___ ___ Pyt

<    1   2