[issue38449] regression - mimetypes guess_type is confused by ; in the filename

2019-10-11 Thread Ned Deily
Ned Deily added the comment: Thanks for looking into this, @maxking. With both 3.8.0 final and 3.7.5 final scheduled for just a few days away, I wonder if the best thing to do at this point is to revert them and work on a more robust fix targeted for the next maintenance releases since the o

[issue38452] unittest setUpClass missing 1 required positional argument: 'cls'

2019-10-11 Thread Zachary Ware
Zachary Ware added the comment: `setUpClass` and `tearDownClass` are classmethods and must be decorated as such (`@classmethod`). -- nosy: +zach.ware resolution: -> not a bug status: open -> pending ___ Python tracker

[issue38401] Make dataclass attribute docstrings accessible

2019-10-11 Thread Tal Einat
Tal Einat added the comment: Thanks for this suggestion John! Unfortunately, only the first string literal in the example is a doc-string, and the rest indeed are not. (PEP-258 suggested adding such doc-strings, but it was rejected.) There is currently no standard way to attach a doc-string

[issue38422] Clarify docstrings of pathlib suffix(es)

2019-10-11 Thread Tal Einat
Tal Einat added the comment: >From the PR, the rationale for this suggestion is: "Whenever I use path.suffix I have to check again whether it includes the dot or not. I decided to add it to the docstring so I won't have to keep checking." -- nosy: +taleinat _

[issue38453] ntpath.realpath() should make absolute path earlier

2019-10-11 Thread Steve Dower
New submission from Steve Dower : Because the abspath() call is deferred until the end of the resolution process, if the current working directory is not already a real path, it will not be fully resolved. By passing it through abspath() at the start of the function, we ensure that the corre

[issue38440] Possible new issues with IDLE

2019-10-11 Thread Tal Einat
Change by Tal Einat : -- nosy: +taleinat ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue38445] os.path.exists() takes bool as argument and returns True

2019-10-11 Thread Tal Einat
Tal Einat added the comment: Mariano Anaya, you're welcome to work on this and create a PR. There's no need to have this issue assigned to you: feel free to just begin working. Anyone reading this will know that you intended to work on this. (FYI, we only assign issues to core developers, an

[issue38450] 3.8 Release Notes: IDLE section dupe

2019-10-11 Thread A.M. Kuchling
Change by A.M. Kuchling : -- pull_requests: +16300 pull_request: https://github.com/python/cpython/pull/16621 ___ Python tracker ___ ___

[issue38453] ntpath.realpath() should make absolute path earlier

2019-10-11 Thread Steve Dower
Steve Dower added the comment: Updating change_cwd() in Lib/test/support/__init__.py to call chdir(realpath(path)) also fixes the test issues I was facing, but the realpath() implementation needs fixing. -- ___ Python tracker

[issue38453] ntpath.realpath() should make absolute path earlier

2019-10-11 Thread Steve Dower
Change by Steve Dower : -- keywords: +patch pull_requests: +16301 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/16723 ___ Python tracker _

[issue38453] ntpath.realpath() should make absolute path earlier

2019-10-11 Thread Steve Dower
Steve Dower added the comment: PR 16723 is just for the test fix. The realpath() fix should get tests that chdir (without change_cwd()) into a symlink and then realpath() on a relative path. Today, that should fail to resolve the sections in the CWD, and with the fix it should resolve the en

[issue38449] regression - mimetypes guess_type is confused by ; in the filename

2019-10-11 Thread Abhilash Raj
Abhilash Raj added the comment: Yeah, I agree. I'll submit a PR for reverting the commits. -- ___ Python tracker ___ ___ Python-bug

[issue38449] regression - mimetypes guess_type is confused by ; in the filename

2019-10-11 Thread Abhilash Raj
Change by Abhilash Raj : -- keywords: +patch pull_requests: +16302 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16724 ___ Python tracker ___ ___

[issue22347] mimetypes.guess_type("//example.com") misinterprets host name as file name

2019-10-11 Thread Abhilash Raj
Change by Abhilash Raj : -- pull_requests: +16303 pull_request: https://github.com/python/cpython/pull/16724 ___ Python tracker ___

[issue38445] os.path.exists() takes bool as argument and returns True

2019-10-11 Thread Eryk Sun
Eryk Sun added the comment: > Maybe os.fspath() can be used I think that would already be the case if genericpath.exists didn't have to support file descriptors. It's documented that the path argument "refers to an existing path or an open file descriptor". Modifying _fd_converter would pro

[issue38378] os.sendfile() has improperly named parameter

2019-10-11 Thread Giampaolo Rodola'
Giampaolo Rodola' added the comment: I’m for renaming both. Since the function is about transmitting or copying (on Linux) files src_fd and dst_fd could also be good candidates. -- nosy: +giampaolo.rodola ___ Python tracker

[issue38424] typing.Generator shorthand

2019-10-11 Thread Dima Tisnek
Dima Tisnek added the comment: Clearly my attention span does not exceed 5 paragraphs, so sorry! -- ___ Python tracker ___ ___ Pyth

[issue38451] Datetime definition does not work in function definition as list definition

2019-10-11 Thread Terry J. Reedy
Terry J. Reedy added the comment: Without more information, we cannot do anything with this. -- nosy: +terry.reedy status: open -> pending versions: -Python 2.7, Python 3.5, Python 3.6, Python 3.7, Python 3.8 ___ Python tracker

[issue38454] test_listdir is failing on ubuntu with WSL

2019-10-11 Thread Batuhan
New submission from Batuhan : Run tests sequentially 0:00:00 load avg: 0.52 [1/1] test_os test test_os failed -- Traceback (most recent call last): File "/home/isidentical/cpython/Lib/test/test_os.py", line 2059, in test_listdir self.assertEqual(found, expected) AssertionError: Items in th

[issue38451] Datetime definition does not work in function definition as list definition

2019-10-11 Thread Pouria
Pouria added the comment: For example Def a(time=datetime.datetime.today()): Print(time) Output: The output of each run is equal to the first time output For exaple : If you run a() Sleep(10) a() Sleep(10) a() You see one output thre

[issue38451] Datetime definition does not work in function definition as list definition

2019-10-11 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Default arguments are evaluated only once as the function is defined and not per call. This is a common gotcha : https://stackoverflow.com/questions/1132941/least-astonishment-and-the-mutable-default-argument -- __

[issue22347] mimetypes.guess_type("//example.com") misinterprets host name as file name

2019-10-11 Thread miss-islington
Change by miss-islington : -- pull_requests: +16305 pull_request: https://github.com/python/cpython/pull/16725 ___ Python tracker ___ __

[issue22347] mimetypes.guess_type("//example.com") misinterprets host name as file name

2019-10-11 Thread miss-islington
miss-islington added the comment: New changeset 19a3d873005e5730eeabdc394c961e93f2ec02f0 by Miss Islington (bot) (Abhilash Raj) in branch 'master': bpo-38449: Revert "bpo-22347: Update mimetypes.guess_type to allow oper parsing of URLs (GH-15522)" (GH-16724) https://github.com/python/cpython

[issue38449] regression - mimetypes guess_type is confused by ; in the filename

2019-10-11 Thread miss-islington
miss-islington added the comment: New changeset 19a3d873005e5730eeabdc394c961e93f2ec02f0 by Miss Islington (bot) (Abhilash Raj) in branch 'master': bpo-38449: Revert "bpo-22347: Update mimetypes.guess_type to allow oper parsing of URLs (GH-15522)" (GH-16724) https://github.com/python/cpython

[issue38449] regression - mimetypes guess_type is confused by ; in the filename

2019-10-11 Thread miss-islington
Change by miss-islington : -- pull_requests: +16304 pull_request: https://github.com/python/cpython/pull/16725 ___ Python tracker ___ __

[issue38449] regression - mimetypes guess_type is confused by ; in the filename

2019-10-11 Thread Dong-hee Na
Dong-hee Na added the comment: I'd like to suggest add unit test for the report case. So that we can detect future regression issue :) -- nosy: +corona10 ___ Python tracker __

[issue38449] regression - mimetypes guess_type is confused by ; in the filename

2019-10-11 Thread Dong-hee Na
Dong-hee Na added the comment: And I aplogize for my patch which makes regrssion issue. -- ___ Python tracker ___ ___ Python-bugs-l

<    1   2