[issue37531] Fix regrtest timeout for subprocesses: regrtest -jN --timeout=SECONDS

2019-09-17 Thread STINNER Victor
STINNER Victor added the comment: New changeset b9877cd2cc47b6f3512c171814c4f630286279b9 by Victor Stinner in branch 'master': bpo-37531: Skip test_regrtest.test_multiprocessing_timeout() on Windows (GH-16247) https://github.com/python/cpython/commit/b9877cd2cc47b6f3512c171814c4f630286279b9

[issue38205] Python no longer compiles without small integer singletons

2019-09-17 Thread Ma Lin
Ma Lin added the comment: This commit changed Py_UNREACHABLE() five days ago: https://github.com/python/cpython/commit/3ab61473ba7f3dca32d779ec2766a4faa0657923 If remove this change, it can be compiled successfully. -- nosy: +Ma Lin ___ Python tra

[issue38206] Clarify that tp_dealloc must decref for heap allocated type

2019-09-17 Thread Ammar Askar
Change by Ammar Askar : -- keywords: +patch pull_requests: +15844 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16248 ___ Python tracker ___

[issue38205] Python no longer compiles without small integer singletons

2019-09-17 Thread Ma Lin
Ma Lin added the comment: We can change Py_UNREACHABLE() to assert(0) in longobject.c Or remove the article in Py_UNREACHABLE() -- ___ Python tracker ___ _

[issue38205] Python no longer compiles without small integer singletons

2019-09-17 Thread STINNER Victor
STINNER Victor added the comment: See https://bugs.python.org/issue37812#msg352670 and https://bugs.python.org/issue38015 -- ___ Python tracker ___ __

[issue38203] regrtest fails to stop test_multiprocessing_spawn worker process

2019-09-17 Thread STINNER Victor
Change by STINNER Victor : -- keywords: +patch pull_requests: +15845 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16249 ___ Python tracker ___ _

[issue38203] regrtest fails to stop test_multiprocessing_spawn worker process

2019-09-17 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +15846 pull_request: https://github.com/python/cpython/pull/16250 ___ Python tracker ___ __

[issue37657] ERROR: grip 4.5.2 requires docopt>=0.4.0, which is not installed.

2019-09-17 Thread Dima Tisnek
Dima Tisnek added the comment: I've just got it again, when running `Install Certificates.command` after installing Python 3.8.0b4. Yes I do have Python 3.7 installed and had earlier 3.8 builds installed. Could it be referenced by `pip`? Or `certifi` itself? I can't find any references...

[issue37657] ERROR: grip 4.5.2 requires docopt>=0.4.0, which is not installed.

2019-09-17 Thread Dima Tisnek
Dima Tisnek added the comment: I've nuked 3.8/.../site-packages and the problem is gone; confirmed by reinstalling 3.8 from scratch. It must've been something in the my environment, if/when I find what it was, I'll open a bug in the respective package. -- stage: -> resolved status:

[issue37812] Make implicit returns explicit in longobject.c (in CHECK_SMALL_INT)

2019-09-17 Thread Raymond Hettinger
Raymond Hettinger added the comment: Victor, I agree that both changes should be reverted. We should avoid churning long stable, bug free code for minimal aesthetic value. -- ___ Python tracker ___

[issue36546] Add quantiles() to the statistics module

2019-09-17 Thread Raymond Hettinger
Change by Raymond Hettinger : -- pull_requests: +15847 pull_request: https://github.com/python/cpython/pull/16252 ___ Python tracker ___ ___

[issue27970] ssl: can't verify a trusted site with imcomplete certificate chain

2019-09-17 Thread Greg Lindahl
Change by Greg Lindahl : -- nosy: +wumpus ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue36546] Add quantiles() to the statistics module

2019-09-17 Thread Raymond Hettinger
Raymond Hettinger added the comment: New changeset 272d0d017aef585acf84bb0af99a90a2a8582b2c by Raymond Hettinger in branch 'master': bpo-36546: No longer a need to make "data" positional only (GH-16252) https://github.com/python/cpython/commit/272d0d017aef585acf84bb0af99a90a2a8582b2c --

[issue36546] Add quantiles() to the statistics module

2019-09-17 Thread miss-islington
Change by miss-islington : -- pull_requests: +15848 pull_request: https://github.com/python/cpython/pull/16253 ___ Python tracker ___ __

[issue36546] Add quantiles() to the statistics module

2019-09-17 Thread Raymond Hettinger
Raymond Hettinger added the comment: New changeset 31af1cce9d799475ba8c3dec3e239b4a75ce268f by Raymond Hettinger (Miss Islington (bot)) in branch '3.8': bpo-36546: No longer a need to make "data" positional only (GH-16252) (GH-16253) https://github.com/python/cpython/commit/31af1cce9d799475ba

[issue37812] Make implicit returns explicit in longobject.c (in CHECK_SMALL_INT)

2019-09-17 Thread Greg Price
Greg Price added the comment: Thanks Victor for linking that issue back here. > A first change converted a macro to a static inline function. The second > change converted the static inline fnuction to a macro Not quite. The first change converted a macro `CHECK_SMALL_INT` to an equivalent

[issue37812] Make implicit returns explicit in longobject.c (in CHECK_SMALL_INT)

2019-09-17 Thread Ma Lin
Ma Lin added the comment: > It's not clear to me if anyone benchmarked to see if the > conversion to a macro had any measurable performance benefit. I tested on that day, also use this command: python.exe -m pyperf timeit -s "from collections import deque; consume = deque(maxlen=0).extend;

[issue37812] Make implicit returns explicit in longobject.c (in CHECK_SMALL_INT)

2019-09-17 Thread Raymond Hettinger
Raymond Hettinger added the comment: Sorry Greg, I know you're enthusiastic about this but I think both changes were a mistake. As the person who merged them, I've decided to revert them in favor of stable code (FWIW, I do care about Ma Lin's concerns in the other BPO and I don't want the g

[issue37812] Make implicit returns explicit in longobject.c (in CHECK_SMALL_INT)

2019-09-17 Thread Greg Price
Greg Price added the comment: > if using a static inline function is causing issues Separately from whether there was or wasn't such an issue here, I think it's interesting to note that the build failure bpo-38205 is an example of exactly the opposite! It was caused by a combination of (a)

[issue38015] inline function generates slightly inefficient machine code

2019-09-17 Thread Greg Price
Greg Price added the comment: See followup at https://bugs.python.org/issue38205 and https://bugs.python.org/issue37812#msg352670 . The patch in GH-15710 had a side effect of introducing a call to `Py_UNREACHABLE` inside a comma-expression. A subsequent commit 3ab61473b changed `Py_UNREACH

[issue37812] Make implicit returns explicit in longobject.c (in CHECK_SMALL_INT)

2019-09-17 Thread Ma Lin
Ma Lin added the comment: > I agree that both changes should be reverted. There is another commit after the two commits: https://github.com/python/cpython/commit/c6734ee7c55add5fdc2c821729ed5f67e237a096 It is troublesome to revert them. PR 16146 is on-going, maybe we can request the author t

[issue37812] Make implicit returns explicit in longobject.c (in CHECK_SMALL_INT)

2019-09-17 Thread Greg Price
Greg Price added the comment: > We're wasted a lot of dev time on something that never promised much value in > the first place. So, I'll revert and close this tracker issue OK, so be it. I'll certainly agree that this series of threads consumed a lot more time than I anticipated or hoped,

[issue37812] Make implicit returns explicit in longobject.c (in CHECK_SMALL_INT)

2019-09-17 Thread Raymond Hettinger
Raymond Hettinger added the comment: Greg, would you be willing to work on a PR that reverts pr15216 and pr15710 while preserving the efforts of pr15192 ? -- ___ Python tracker _

[issue38200] Adding itertools.pairwise to the standard library?

2019-09-17 Thread Raymond Hettinger
Raymond Hettinger added the comment: FWIW, pairwise() is in the more-itertools module. A quick code search does show occasional use in the wild: https://github.com/search?q=language%3Apython+more_itertools.pairwise&type=Code In my own code, I've had some cases that almost fit but they n

[issue18236] str.isspace should use the Unicode White_Space property

2019-09-17 Thread Greg Price
Change by Greg Price : -- keywords: +patch pull_requests: +15849 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/16254 ___ Python tracker __

[issue38191] typing.NamedTuple() should prefix parameters with '_'

2019-09-17 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 2adcd79bf90415147691a51a4cb046d5920f6ce7 by Serhiy Storchaka in branch '3.8': bpo-38191: Use positional-only parameters in TypedDict(). (GH-16240) https://github.com/python/cpython/commit/2adcd79bf90415147691a51a4cb046d5920f6ce7 --

[issue38191] typing.NamedTuple() should prefix parameters with '_'

2019-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue37760] Refactor makeunicodedata.py: dedupe parsing, use dataclass

2019-09-17 Thread Greg Price
Greg Price added the comment: Thanks Benjamin for reviewing and merging this series! -- ___ Python tracker ___ ___ Python-bugs-list

[issue38208] Simplify string.Template by using __init_subclass__()

2019-09-17 Thread Serhiy Storchaka
New submission from Serhiy Storchaka : Currently string.Template uses a metaclass. It is possible to get rid of it and use __init_subclass__() instead. -- components: Library (Lib) messages: 352699 nosy: serhiy.storchaka priority: normal severity: normal status: open title: Simplify st

[issue38205] Python no longer compiles without small integer singletons

2019-09-17 Thread Sergey Fedoseev
Sergey Fedoseev added the comment: I believe that the problem is caused by the change in Py_UNREACHABLE() (https://github.com/python/cpython/commit/3ab61473ba7f3dca32d779ec2766a4faa0657923). Before the mentioned commit Py_UNREACHABLE() was an expression, now it's a block. Py_UNREACHABLE() ma

[issue38203] regrtest fails to stop test_multiprocessing_spawn worker process

2019-09-17 Thread STINNER Victor
STINNER Victor added the comment: New changeset da57599af51c602b015b6880123fef6eccdabcf5 by Victor Stinner in branch 'master': bpo-38203: regrtest: put a 2 min timeout on Python exit (GH-16250) https://github.com/python/cpython/commit/da57599af51c602b015b6880123fef6eccdabcf5 -- ___

[issue38209] Simplify dataclasses.InitVar by using __class_getitem__()

2019-09-17 Thread Serhiy Storchaka
New submission from Serhiy Storchaka : Currently dataclasses.InitVar uses a metaclass. It is possible to get rid of it and use __class_getitem__() instead. -- components: Library (Lib) messages: 352702 nosy: eric.smith, serhiy.storchaka priority: normal severity: normal status: open ti

[issue38209] Simplify dataclasses.InitVar by using __class_getitem__()

2019-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +15850 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16255 ___ Python tracker ___

[issue38208] Simplify string.Template by using __init_subclass__()

2019-09-17 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +15851 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16256 ___ Python tracker ___

[issue38205] Python no longer compiles without small integer singletons

2019-09-17 Thread Sergey Fedoseev
Sergey Fedoseev added the comment: Also quote from Py_UNREACHABLE() doc: > Use this in places where you might be tempted to put an assert(0) or abort() > call. https://github.com/python/cpython/commit/6b519985d23bd0f0bd072b5d5d5f2c60a81a19f2 does exactly that, it replaces assert(0) with Py

<    1   2