[issue38063] Modify test_socket.py to use unittest test discovery

2019-09-09 Thread STINNER Victor
STINNER Victor added the comment: > See also #14408 In 2012, test_main() was used to skip a few test cases. But since that time, the availability tests were moved from test_main() to the test case classes directly using unittest.skipIf or unittest.skipUnless decorators. So now using unitte

[issue37383] call count in not registered in AsyncMock till the coroutine is awaited

2019-09-09 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: > I wonder if `await_count` is really necessary, since it is essentially the > same as `call_count`. Would it be too late or confusing to remove it now? IMO if we are to document that mock_calls is recorded over await then we can have both call_cou

[issue33523] loop.run_until_complete re-entrancy to support more complicated codebases in transition to asyncio

2019-09-09 Thread Andrew Svetlov
Andrew Svetlov added the comment: Let's close the issue as "won't fix". Third-party loop implementation *can* be reentrant but we don't want to encourage people to use this pattern in stdlib. -- resolution: -> wont fix stage: patch review -> resolved status: open -> closed

[issue37909] Thread pool return ref hold memory

2019-09-09 Thread Andrew Svetlov
Change by Andrew Svetlov : -- resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Python

[issue37212] ordered keyword arguments in unittest.mock.call repr and error messages

2019-09-09 Thread Zachary Ware
Zachary Ware added the comment: New changeset 9d607061c9c888913ae2c18543775cf360d55f27 by Zachary Ware (Xtreak) in branch 'master': bpo-37212: Preserve keyword argument order in unittest.mock.call and error messages (GH-14310) https://github.com/python/cpython/commit/9d607061c9c888913ae2c185

[issue33523] loop.run_until_complete re-entrancy to support more complicated codebases in transition to asyncio

2019-09-09 Thread Yury Selivanov
Yury Selivanov added the comment: 🙏 -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.or

[issue38065] Document the datetime capsule API

2019-09-09 Thread Paul Ganssle
New submission from Paul Ganssle : The datetime module has a capsule API, which is very useful for other languages' bindings, but the C API documentation for datetime only covers the C macros: https://docs.python.org/3/c-api/datetime.html The current extent of the documentation is that everyo

[issue37212] ordered keyword arguments in unittest.mock.call repr and error messages

2019-09-09 Thread miss-islington
Change by miss-islington : -- pull_requests: +15408 pull_request: https://github.com/python/cpython/pull/15755 ___ Python tracker ___ __

[issue37383] call count in not registered in AsyncMock till the coroutine is awaited

2019-09-09 Thread Lisa Roach
Lisa Roach added the comment: I think you are right, I'd prefer to leave it in. It also helps users who are switching from AsyncTest to the std lib AsyncMock, they can keep using `await_count`. I'll update the docs! -- ___ Python tracker

[issue37212] ordered keyword arguments in unittest.mock.call repr and error messages

2019-09-09 Thread Zachary Ware
Change by Zachary Ware : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.8 ___ Python tracker ___ __

[issue37841] Python store app launcher has dependency on msvcp140.dll

2019-09-09 Thread miss-islington
Change by miss-islington : -- pull_requests: +15409 pull_request: https://github.com/python/cpython/pull/15756 ___ Python tracker ___ __

[issue37589] Missing dependences in the Makefile

2019-09-09 Thread Thomas Wouters
Change by Thomas Wouters : -- keywords: +patch pull_requests: +15410 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15757 ___ Python tracker ___ _

[issue37683] Use importlib.resources in venv

2019-09-09 Thread Vinay Sajip
Vinay Sajip added the comment: The install_scripts() API is intended to allow users to add their own venv-specific scripts from their own project folders. We could add an install_resources() method, which would add all the resources in a given package. The signature would be def install

[issue34652] never enable lchmod on Linux

2019-09-09 Thread Benjamin Peterson
Change by Benjamin Peterson : -- pull_requests: +15411 pull_request: https://github.com/python/cpython/pull/15758 ___ Python tracker ___ ___

[issue37283] Unexpected behavior when running installer a second time with the same arguments or unattend.xml

2019-09-09 Thread Steve Dower
Change by Steve Dower : -- keywords: +patch pull_requests: +15412 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/15759 ___ Python tracker _

[issue36250] pdb: interaction might cause "ValueError: signal only works in main thread"

2019-09-09 Thread miss-islington
miss-islington added the comment: New changeset 87a5a331eab5a99538d60a6dab25bdf299a68e3e by Miss Islington (bot) in branch '3.8': bpo-36250: ignore ValueError from signal in non-main thread (GH-12251) https://github.com/python/cpython/commit/87a5a331eab5a99538d60a6dab25bdf299a68e3e

[issue34596] [unittest] raise error if @skip is used with an argument that looks like a test method

2019-09-09 Thread Zachary Ware
Zachary Ware added the comment: I think we need Michael's ruling on which way to go here. I'm fine with either an exception or a default reason, but still lean towards the default. I don't think `skipIf` or `skipUnless` really need a change either way; they both require two arguments and t

[issue36876] Global C variables are a problem.

2019-09-09 Thread Eric Snow
Change by Eric Snow : -- pull_requests: +15413 pull_request: https://github.com/python/cpython/pull/15760 ___ Python tracker ___ ___

[issue37754] Consistency of Unix's shared_memory implementation with windows

2019-09-09 Thread Davin Potts
Davin Potts added the comment: A shared semaphore approach for the resource tracker sounds appealing as a way to make the behavior on Windows and posix systems more consistent. However this might get implemented, we should not artificially prevent users from having some option to persist be

[issue37383] call count in not registered in AsyncMock till the coroutine is awaited

2019-09-09 Thread Lisa Roach
Change by Lisa Roach : -- keywords: +patch pull_requests: +15414 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15761 ___ Python tracker ___ _

[issue38066] Hide internal asyncio.Stream methods

2019-09-09 Thread Andrew Svetlov
New submission from Andrew Svetlov : As discussed in discussion https://github.com/python/cpython/pull/14488#discussion_r322176319 Hide feed_eof(), feed_data(), set_exception() and set_transport() methods. -- components: asyncio messages: 351433 nosy: asvetlov, yselivanov priority: no

[issue37841] Python store app launcher has dependency on msvcp140.dll

2019-09-09 Thread miss-islington
miss-islington added the comment: New changeset 58a7f809ac978ed54034b7b48f2ea64000aa4661 by Miss Islington (bot) in branch '3.7': bpo-37841: Remove python_uwp dependency on msvcp140.dll (GH-15253) https://github.com/python/cpython/commit/58a7f809ac978ed54034b7b48f2ea64000aa4661 --

[issue38066] Hide internal asyncio.Stream methods

2019-09-09 Thread Andrew Svetlov
Change by Andrew Svetlov : -- keywords: +patch pull_requests: +15415 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15762 ___ Python tracker ___ _

[issue37212] ordered keyword arguments in unittest.mock.call repr and error messages

2019-09-09 Thread miss-islington
miss-islington added the comment: New changeset bee8bfe5f440c2dde7f5af189febdbf81b27abd5 by Miss Islington (bot) in branch '3.8': bpo-37212: Preserve keyword argument order in unittest.mock.call and error messages (GH-14310) https://github.com/python/cpython/commit/bee8bfe5f440c2dde7f5af189f

[issue34652] never enable lchmod on Linux

2019-09-09 Thread Benjamin Peterson
Benjamin Peterson added the comment: New changeset bed04b664729e3e6fcee42daa108936360bac6ea by Benjamin Peterson in branch 'master': bpo-34652 again: Remove lchmod from the default AC_CHECK_FUNCS list. (GH-15758) https://github.com/python/cpython/commit/bed04b664729e3e6fcee42daa108936360bac6e

[issue34652] never enable lchmod on Linux

2019-09-09 Thread miss-islington
Change by miss-islington : -- pull_requests: +15416 pull_request: https://github.com/python/cpython/pull/15763 ___ Python tracker ___ __

[issue37283] Unexpected behavior when running installer a second time with the same arguments or unattend.xml

2019-09-09 Thread Steve Dower
Steve Dower added the comment: New changeset 3a0ddbcdfcbc0f4372905fabf81e093f1b043e99 by Steve Dower in branch 'master': bpo-37283: Ensure command-line and unattend.xml setting override previously detected states in Windows installer (GH-15759) https://github.com/python/cpython/commit/3a0ddb

[issue37283] Unexpected behavior when running installer a second time with the same arguments or unattend.xml

2019-09-09 Thread miss-islington
Change by miss-islington : -- pull_requests: +15418 pull_request: https://github.com/python/cpython/pull/15765 ___ Python tracker ___ __

[issue37283] Unexpected behavior when running installer a second time with the same arguments or unattend.xml

2019-09-09 Thread miss-islington
Change by miss-islington : -- pull_requests: +15417 pull_request: https://github.com/python/cpython/pull/15764 ___ Python tracker ___ __

[issue32587] Make REG_MULTI_SZ support zero-length strings

2019-09-09 Thread Steve Dower
Change by Steve Dower : -- pull_requests: +15419 pull_request: https://github.com/python/cpython/pull/15766 ___ Python tracker ___ _

[issue37705] winerror_to_errno implementation

2019-09-09 Thread Steve Dower
Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ P

[issue37589] Missing dependences in the Makefile

2019-09-09 Thread Thomas Wouters
Thomas Wouters added the comment: New changeset b4612f5d54aced5bc37f1b85bf50b4cafa2480f0 by T. Wouters in branch 'master': bpo-37589: Add a few missing dependencies on .h files in the Makefile. (GH-15757) https://github.com/python/cpython/commit/b4612f5d54aced5bc37f1b85bf50b4cafa2480f0 ---

[issue37589] Missing dependences in the Makefile

2019-09-09 Thread miss-islington
Change by miss-islington : -- pull_requests: +15420 pull_request: https://github.com/python/cpython/pull/15767 ___ Python tracker ___ __

[issue37662] Document venv.EnvBuilder.upgrade_dependencies()

2019-09-09 Thread Vinay Sajip
Change by Vinay Sajip : -- keywords: +patch pull_requests: +15421 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15768 ___ Python tracker ___

[issue37589] Missing dependences in the Makefile

2019-09-09 Thread Thomas Wouters
Change by Thomas Wouters : -- pull_requests: +15422 pull_request: https://github.com/python/cpython/pull/15769 ___ Python tracker ___ __

[issue38066] Hide internal asyncio.Stream methods

2019-09-09 Thread Yury Selivanov
Yury Selivanov added the comment: BTW, if we are doing this -- maybe not expose the underlying transport at all? I don't like that we do that currently, and there multiple ways for the user to screw up the Stream object (and potentially break start_tls()/sendfile() etc) --

[issue38067] Add headers parameter on RobotFileParser

2019-09-09 Thread Emmanuel Arias
New submission from Emmanuel Arias : Hello I open an issue from a PR that I think need discussion: I write here the @fuwaraido's PR description: > I found some website like "sony.co.jp" requests User-Agent field in headers > when I try to fetch their robots.txt. Unless they returns 403 Forbid

[issue37702] memory leak in ssl certification

2019-09-09 Thread Steve Dower
Steve Dower added the comment: Thanks for the simpler patch. I'm happier taking that one, given we know the rest of the code already works. -- ___ Python tracker ___

[issue37702] memory leak in ssl certification

2019-09-09 Thread Steve Dower
Steve Dower added the comment: New changeset ed70129e15ea028469145111044a4349960a4e6f by Steve Dower (neonene) in branch 'master': bpo-37702: Fix SSL's certificate-store leak on Windows (GH-15632) https://github.com/python/cpython/commit/ed70129e15ea028469145111044a4349960a4e6f --

[issue37702] memory leak in ssl certification

2019-09-09 Thread miss-islington
Change by miss-islington : -- pull_requests: +15424 pull_request: https://github.com/python/cpython/pull/15770 ___ Python tracker ___ __

[issue37185] use os.memfd_create in multiprocessing.shared_memory?

2019-09-09 Thread Davin Potts
Davin Potts added the comment: Unless I am missing something, memfd_create appears to be specific to the Linux kernel still so we would need to replicate its behavior on all of the other unix systems. To your point, but quoting from the docs, "separate invocations of memfd_create with the s

[issue37702] memory leak in ssl certification

2019-09-09 Thread Steve Dower
Change by Steve Dower : -- pull_requests: +15425 pull_request: https://github.com/python/cpython/pull/15771 ___ Python tracker ___ _

[issue34596] [unittest] raise error if @skip is used with an argument that looks like a test method

2019-09-09 Thread Michael Foord
Michael Foord added the comment: I'm in favour of a default and "Unconditionally skipped" is fine with me. Although "Skipped" would also be fine. Making @skip work with no arguments is fine. Having to pass in arguments message arguments you don't want is a pain and there's no need to force t

[issue37488] Document the "gotcha" behaviors in utcnow() and utcfromtimestamp()

2019-09-09 Thread Joannah Nanjekye
Change by Joannah Nanjekye : -- keywords: +patch pull_requests: +15426 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/15773 ___ Python tracker

[issue37754] Consistency of Unix's shared_memory implementation with windows

2019-09-09 Thread Vinay Sharma
Vinay Sharma added the comment: Hi @davin, I researched on lots of approaches to solve this problem, and I have listed down some of the best ones. 1. As Eryk Sun suggested initially to use advisory locking to implement a reference count type of mechanism. I implemented this in the current Pu

[issue38068] clean up configure logic for gettimeofday

2019-09-09 Thread Benjamin Peterson
New submission from Benjamin Peterson : We assume gettimeofday exists, so we don't need a configure test for it. We should also assume it always takes a second argument per POSIX. -- messages: 351446 nosy: benjamin.peterson priority: normal severity: normal status: open title: clean up

[issue15733] PEP 3121, 384 Refactoring applied to winapi module

2019-09-09 Thread Joannah Nanjekye
Change by Joannah Nanjekye : -- keywords: +patch pull_requests: +15427 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15773 ___ Python tracker ___

[issue38068] clean up configure logic for gettimeofday

2019-09-09 Thread Benjamin Peterson
Change by Benjamin Peterson : -- keywords: +patch pull_requests: +15428 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15775 ___ Python tracker __

[issue36580] unittest.mock does not understand dataclasses

2019-09-09 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Closing this as not a bug since autospeccing with create_autospec can be used and spec only does attribute access validation. Thanks -- resolution: -> not a bug stage: -> resolved status: open -> closed __

[issue38054] enhance pdb.set_trace() to run when the specified condition is true

2019-09-09 Thread Lisa Roach
Lisa Roach added the comment: Does this flag make things much easier? You would still need an if statement in order to correctly pass in True/False for the trigger flag. -- nosy: +lisroach ___ Python tracker __

[issue34652] never enable lchmod on Linux

2019-09-09 Thread miss-islington
miss-islington added the comment: New changeset 12acb5b9c8c21e486083483bded422d8443c38a7 by Miss Islington (bot) in branch '3.8': bpo-34652 again: Remove lchmod from the default AC_CHECK_FUNCS list. (GH-15758) https://github.com/python/cpython/commit/12acb5b9c8c21e486083483bded422d8443c38a7

[issue37283] Unexpected behavior when running installer a second time with the same arguments or unattend.xml

2019-09-09 Thread miss-islington
miss-islington added the comment: New changeset 2a4a982cbccf66dd8d29439dbd232c79fe3ec44e by Miss Islington (bot) in branch '3.8': bpo-37283: Ensure command-line and unattend.xml setting override previously detected states in Windows installer (GH-15759) https://github.com/python/cpython/comm

[issue38053] Update plistlib documentation

2019-09-09 Thread Jon Janzen
Jon Janzen added the comment: >* Remove notes about the new API being added in 3.4 since 3.4 is no longer >supported Per discussion in the PR, this is no longer a goal of this issue -- ___ Python tracker _

[issue37499] test_gdb.test_pycfunction should use dedicated test functions

2019-09-09 Thread Petr Viktorin
Change by Petr Viktorin : -- pull_requests: +15429 pull_request: https://github.com/python/cpython/pull/15776 ___ Python tracker ___ ___

[issue26185] zipfile.ZipInfo slots can raise unexpected AttributeError

2019-09-09 Thread Dino Viehland
Dino Viehland added the comment: New changeset 992347d7376765fe3f4fc958fb1be193ba21f6c3 by Dino Viehland (Mickaël Schoentgen) in branch 'master': bpo-26185: Fix repr() on empty ZipInfo object (#13441) https://github.com/python/cpython/commit/992347d7376765fe3f4fc958fb1be193ba21f6c3 -

[issue37936] gitignore file is too broad

2019-09-09 Thread Zachary Ware
Zachary Ware added the comment: New changeset 9ae9ac1061c76d637ebe9c1d6c6c802311d6ddba by Zachary Ware (Miss Islington (bot)) in branch '3.7': bpo-37936: Avoid ignoring files that we actually do track. (GH-15451) (GH-15748) https://github.com/python/cpython/commit/9ae9ac1061c76d637ebe9c1d6c6c

[issue16575] ctypes: unions as arguments

2019-09-09 Thread Vinay Sajip
Vinay Sajip added the comment: Link to issue has changed to: https://github.com/libffi/libffi/issues/33 -- ___ Python tracker ___

[issue37283] Unexpected behavior when running installer a second time with the same arguments or unattend.xml

2019-09-09 Thread miss-islington
miss-islington added the comment: New changeset d3b8a6bf7c5f7574a3256468c4d0a755ba7a9048 by Miss Islington (bot) in branch '3.7': bpo-37283: Ensure command-line and unattend.xml setting override previously detected states in Windows installer (GH-15759) https://github.com/python/cpython/comm

[issue32587] Make REG_MULTI_SZ support zero-length strings

2019-09-09 Thread Jason R. Coombs
Jason R. Coombs added the comment: New changeset ef66f31ce21cd759cc0c618c5c42ba6da0a06834 by Jason R. Coombs (Steve Dower) in branch 'master': bpo-32587: Fixes unsafe downcast in PC/winreg.c (GH-15766) https://github.com/python/cpython/commit/ef66f31ce21cd759cc0c618c5c42ba6da0a06834 ---

[issue32587] Make REG_MULTI_SZ support zero-length strings

2019-09-09 Thread miss-islington
Change by miss-islington : -- pull_requests: +15430 pull_request: https://github.com/python/cpython/pull/15777 ___ Python tracker ___ __

[issue32587] Make REG_MULTI_SZ support zero-length strings

2019-09-09 Thread miss-islington
Change by miss-islington : -- pull_requests: +15431 pull_request: https://github.com/python/cpython/pull/15778 ___ Python tracker ___ __

[issue38061] FreeBSD: Optimize subprocess.Popen(close_fds=True) using closefrom()

2019-09-09 Thread Kubilay Kocak
Kubilay Kocak added the comment: > Would it be possible to modify FreeBSD to enable it by default? Or is there a > reason to not enable it by default? That's very unlikely to happen. I believe it was added as an opt-in feature for some linux compatibility situations. The correct solution is

[issue37589] Missing dependences in the Makefile

2019-09-09 Thread miss-islington
miss-islington added the comment: New changeset 248387f3f1182087da8f432c989ac6f18315b50f by Miss Islington (bot) in branch '3.8': bpo-37589: Add a few missing dependencies on .h files in the Makefile. (GH-15757) https://github.com/python/cpython/commit/248387f3f1182087da8f432c989ac6f18315b50

[issue32587] Make REG_MULTI_SZ support zero-length strings

2019-09-09 Thread Steve Dower
Steve Dower added the comment: Fixed, assuming the backports merge okay. -- assignee: -> steve.dower resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker _

[issue37283] Unexpected behavior when running installer a second time with the same arguments or unattend.xml

2019-09-09 Thread Steve Dower
Steve Dower added the comment: This will be fixed in the next release. Thanks for the report! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker __

[issue38061] FreeBSD: Optimize subprocess.Popen(close_fds=True) using closefrom()

2019-09-09 Thread STINNER Victor
STINNER Victor added the comment: > That's very unlikely to happen. I believe it was added as an opt-in feature > for some linux compatibility situations. The correct solution is to use > closefrom(2), as it is the optimal current solution, and in our case, safe to > use. If you have like 5

[issue37589] Missing dependences in the Makefile

2019-09-09 Thread miss-islington
miss-islington added the comment: New changeset 64f7f6efa0b6ccd5f942b0dd7c63978957d1660e by Miss Islington (bot) (T. Wouters) in branch '3.7': [3.7] bpo-37589: Add a few missing dependencies on .h files in the Makefile. (GH-15757) (GH-15769) https://github.com/python/cpython/commit/64f7f6efa

[issue37702] memory leak in ssl certification

2019-09-09 Thread Steve Dower
Steve Dower added the comment: Closing now, as we're just waiting on the backports to clear CI. Thanks for your contributions! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue37702] memory leak in ssl certification

2019-09-09 Thread miss-islington
miss-islington added the comment: New changeset 472f37ab9a33050d7d50d1ebe33ba324a51c52c2 by Miss Islington (bot) in branch '3.7': bpo-37702: Fix SSL's certificate-store leak on Windows (GH-15632) https://github.com/python/cpython/commit/472f37ab9a33050d7d50d1ebe33ba324a51c52c2 -- no

[issue38061] FreeBSD: Optimize subprocess.Popen(close_fds=True) using closefrom()

2019-09-09 Thread Kubilay Kocak
Kubilay Kocak added the comment: On "close_except", close_range and posix_spawn(close_fds=True), I'll talk to my interested FreeBSD colleagues about potential inroads in that regard. In the meantime, we're good on closefrom(2) anywhere it can be used in Python -- ___

[issue38037] reference counter issue in signal module

2019-09-09 Thread STINNER Victor
STINNER Victor added the comment: New changeset 77643c486fd22d8030e0d82c13012684b4ab6df1 by Victor Stinner (animalize) in branch 'master': bpo-38037: Fix reference counters in signal module (GH-15753) https://github.com/python/cpython/commit/77643c486fd22d8030e0d82c13012684b4ab6df1

[issue38037] reference counter issue in signal module

2019-09-09 Thread miss-islington
Change by miss-islington : -- pull_requests: +15432 pull_request: https://github.com/python/cpython/pull/15779 ___ Python tracker ___ __

[issue37702] memory leak in ssl certification

2019-09-09 Thread Steve Dower
Steve Dower added the comment: New changeset 5d695b6b7bcccf5f028cdacd986096de15bc0ca6 by Steve Dower in branch '3.8': bpo-37702: Fix SSL's certificate-store leak on Windows (GH-15632) https://github.com/python/cpython/commit/5d695b6b7bcccf5f028cdacd986096de15bc0ca6 -- _

[issue34155] [CVE-2019-16056] email.utils.parseaddr mistakenly parse an email

2019-09-09 Thread Matej Cepl
Change by Matej Cepl : -- nosy: +mcepl ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.or

[issue37662] Document venv.EnvBuilder.upgrade_dependencies()

2019-09-09 Thread Vinay Sajip
Vinay Sajip added the comment: New changeset 264e034f990240e2aa379d8484b15b9e70c1fad5 by Vinay Sajip in branch 'master': bpo-37662: Documented venv.EnvBuilder.upgrade_dependencies(). (GH-15768) https://github.com/python/cpython/commit/264e034f990240e2aa379d8484b15b9e70c1fad5 -- ___

[issue38069] Make _posixsubprocess PEP-384 compatible

2019-09-09 Thread Dino Viehland
Change by Dino Viehland : -- assignee: dino.viehland components: Extension Modules nosy: dino.viehland, eric.snow priority: normal severity: normal status: open title: Make _posixsubprocess PEP-384 compatible versions: Python 3.9 ___ Python tracker

[issue38069] Make _posixsubprocess PEP-384 compatible

2019-09-09 Thread Dino Viehland
Change by Dino Viehland : -- keywords: +patch pull_requests: +15433 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15780 ___ Python tracker ___ __

[issue37589] Missing dependences in the Makefile

2019-09-09 Thread Thomas Wouters
Change by Thomas Wouters : -- assignee: -> twouters resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue25597] unittest.mock does not wrap dunder methods (__getitem__ etc)

2019-09-09 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: This seems to a reasonable change to me since dict.get returns the value then making a contains check dict.__contains__ should return True instead of the fixed return value of False. Below is a patch where the mock_wraps attribute is set with the r

[issue38070] visit_decref(): add an assertion to check that the object is not freed

2019-09-09 Thread STINNER Victor
New submission from STINNER Victor : This issue is related to bpo-36389 "Add gc.enable_object_debugger(): detect corrupted Python objects in the GC. I propose to call _PyObject_IsFreed() in visit_decref() in debug mode, to get a better error message if something goes wrong. visit_decref() is

[issue34596] [unittest] raise error if @skip is used with an argument that looks like a test method

2019-09-09 Thread Roundup Robot
Roundup Robot added the comment: New changeset d5fd75c53fad7049fc640c9a6162d35f0c5bea03 by Michael Foord (Naitree Zhu) in branch 'master': bpo-34596: Fallback to a default reason when @unittest.skip is uncalled (#9082) https://github.com/python/cpython/commit/d5fd75c53fad7049fc640c9a6162d35f0

[issue34596] [unittest] raise error if @skip is used with an argument that looks like a test method

2019-09-09 Thread miss-islington
Change by miss-islington : -- pull_requests: +15434 pull_request: https://github.com/python/cpython/pull/15781 ___ Python tracker ___ __

[issue38070] visit_decref(): add an assertion to check that the object is not freed

2019-09-09 Thread STINNER Victor
Change by STINNER Victor : -- keywords: +patch pull_requests: +15435 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15782 ___ Python tracker ___ _

[issue37857] Setting logger.level directly has no effect due to caching in 3.7+

2019-09-09 Thread Zane Bitter
Zane Bitter added the comment: > That code in the wild that sets the level attribute directly is wrong and > should be changed, right? It definitely should be changed (and in our case we did change it once we found it). Whether it's "wrong" is more of a philosophical question ;). But the pr

[issue38070] visit_decref(): add an assertion to check that the object is not freed

2019-09-09 Thread STINNER Victor
STINNER Victor added the comment: > visit_decref() is commonly found in C traceback (ex: gdb backtrace) of bugs > related to the garbage collector. Example with attached bpo-38037-bug.patch: you can apply this patch on the master branch to reintroduce bpo-38037 bug. vstinner@apu$ git apply

[issue38053] Update plistlib documentation

2019-09-09 Thread Ronald Oussoren
Ronald Oussoren added the comment: New changeset 24b11b8c95e96cf9c93fb7fc253e6e96506f2d77 by Ronald Oussoren (Jon Janzen) in branch 'master': bpo-38053 Update documentation for plistlib (GH-15727) https://github.com/python/cpython/commit/24b11b8c95e96cf9c93fb7fc253e6e96506f2d77 --

[issue38053] Update plistlib documentation

2019-09-09 Thread Ronald Oussoren
Change by Ronald Oussoren : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bu

[issue38059] Using sys.exit() over exit() in inspect.py

2019-09-09 Thread Steve Dower
Steve Dower added the comment: New changeset e3c59a75279b0df4e7553d6f0031e202de434e43 by Steve Dower (Alan Yee) in branch 'master': bpo-38059: Using sys.exit() over exit() in inspect.py (GH-15666) https://github.com/python/cpython/commit/e3c59a75279b0df4e7553d6f0031e202de434e43 -- n

[issue38059] Using sys.exit() over exit() in inspect.py

2019-09-09 Thread miss-islington
Change by miss-islington : -- pull_requests: +15437 pull_request: https://github.com/python/cpython/pull/15784 ___ Python tracker ___ __

[issue38059] Using sys.exit() over exit() in inspect.py

2019-09-09 Thread miss-islington
Change by miss-islington : -- keywords: +patch pull_requests: +15436 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15783 ___ Python tracker ___ _

[issue38059] Using sys.exit() over exit() in inspect.py

2019-09-09 Thread Steve Dower
Steve Dower added the comment: Thanks! This helps people who use the "-S" option. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker __

[issue38007] Regression: name of PyType_Spec::slots conflicts with Qt macro

2019-09-09 Thread Steve Dower
Steve Dower added the comment: Yes, even as a struct member name (at least in the definition), the C preprocessor will substitute a macro. It sounds like Qt defines a macro "slots", and so the definition of the struct will be broken. Unfortunately, this would be a more significant change tha

[issue32587] Make REG_MULTI_SZ support zero-length strings

2019-09-09 Thread miss-islington
miss-islington added the comment: New changeset 44729c9f5198211faf533da49fa0fa26693a1993 by Miss Islington (bot) in branch '3.8': bpo-32587: Fixes unsafe downcast in PC/winreg.c (GH-15766) https://github.com/python/cpython/commit/44729c9f5198211faf533da49fa0fa26693a1993 --

[issue32587] Make REG_MULTI_SZ support zero-length strings

2019-09-09 Thread miss-islington
miss-islington added the comment: New changeset 55a6f73b49625ebff575521c3a0b919880f5f0ec by Miss Islington (bot) in branch '3.7': bpo-32587: Fixes unsafe downcast in PC/winreg.c (GH-15766) https://github.com/python/cpython/commit/55a6f73b49625ebff575521c3a0b919880f5f0ec --

[issue38071] Make termios PEP-384 compatible

2019-09-09 Thread Dino Viehland
Change by Dino Viehland : -- components: Extension Modules nosy: dino.viehland, eric.snow priority: normal severity: normal status: open title: Make termios PEP-384 compatible type: enhancement versions: Python 3.9 ___ Python tracker

[issue38071] Make termios PEP-384 compatible

2019-09-09 Thread Dino Viehland
Change by Dino Viehland : -- keywords: +patch pull_requests: +15438 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15785 ___ Python tracker ___ __

[issue37857] Setting logger.level directly has no effect due to caching in 3.7+

2019-09-09 Thread Vinay Sajip
Vinay Sajip added the comment: > There's no way to be sure. But if you have a public (i.e. > non-underscore-prfixed) attribute then some percentage of people are going to > set it, particularly if it seems to work. Well, reading it isn't problematic, so there's no leading underscore. (The s

[issue30782] Allow limiting the number of concurrent tasks in asyncio.as_completed

2019-09-09 Thread Lisa Roach
Lisa Roach added the comment: I would like to see this implemented. I run into memory and speed issues when running with 1000+ tasks quite frequently, and have to write my own rate limiters around it. It doesn't look to me that it is adding a large amount of complexity to as_completed. This

[issue30782] Allow limiting the number of concurrent tasks in asyncio.as_completed

2019-09-09 Thread Yury Selivanov
Yury Selivanov added the comment: We want to add TaskGroups to asyncio (a similar concept to Trio's nurseries). TaskGroups use the `async with` statement to clearly define where Tasks are created and at which point they are expected to be completed or destroyed. asyncio.gather(), asyncio.as

[issue38037] reference counter issue in signal module

2019-09-09 Thread miss-islington
miss-islington added the comment: New changeset b150d0bf1bb4c3203bb3293625e32aed01b25887 by Miss Islington (bot) in branch '3.8': bpo-38037: Fix reference counters in signal module (GH-15753) https://github.com/python/cpython/commit/b150d0bf1bb4c3203bb3293625e32aed01b25887 -- nosy:

<    1   2   3   4   >