[issue37380] subprocess.Popen._cleanup() "The handle is invalid" error when some old process is gone

2019-06-25 Thread STINNER Victor
STINNER Victor added the comment: > See issue 36067 for a related discussion. The _active list and _cleanup > function are not required in Windows. When a process exits, it gets rundown > to free its handle table and virtual memory. Only the kernel object remains, > which is kept alive by po

[issue37244] test_multiprocessing_forkserver: test_resource_tracker() failed on x86 Gentoo Refleaks 3.8

2019-06-25 Thread miss-islington
miss-islington added the comment: New changeset dd4edbc5ad4cdb47e051e7cc0801d31d3786588b by Miss Islington (bot) in branch '3.8': bpo-37244: Fix test_multiprocessing.test_resource_tracker() (GH-14288) https://github.com/python/cpython/commit/dd4edbc5ad4cdb47e051e7cc0801d31d3786588b

[issue37388] unknown error handlers should be reported early

2019-06-25 Thread STINNER Victor
STINNER Victor added the comment: New changeset 22eb689cf3de7972a2789db3ad01a86949508ab7 by Victor Stinner in branch 'master': bpo-37388: Development mode check encoding and errors (GH-14341) https://github.com/python/cpython/commit/22eb689cf3de7972a2789db3ad01a86949508ab7 -- _

[issue37406] Disable runtime checks in release mode

2019-06-25 Thread STINNER Victor
New submission from STINNER Victor : A Python debug build is ABI compatible with a Python release build since Python 3.8 on most platforms (except Windows, Cygwin and Android): https://docs.python.org/3.8/whatsnew/3.8.html#debug-build-uses-the-same-abi-as-release-build It should now be way eas

[issue37406] Disable debug runtime checks in release mode

2019-06-25 Thread STINNER Victor
Change by STINNER Victor : -- title: Disable runtime checks in release mode -> Disable debug runtime checks in release mode ___ Python tracker ___

[issue37406] Disable debug runtime checks in release mode

2019-06-25 Thread STINNER Victor
Change by STINNER Victor : -- keywords: +patch pull_requests: +14198 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14384 ___ Python tracker ___ _

[issue37163] dataclasses.replace() fails with the field named "obj"

2019-06-25 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue37163] dataclasses.replace() fails with the field named "obj"

2019-06-25 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: fixed -> status: closed -> open ___ Python tracker ___ ___ Python-bugs-list mailin

[issue37388] unknown error handlers should be reported early

2019-06-25 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +14199 pull_request: https://github.com/python/cpython/pull/14385 ___ Python tracker ___ __

[issue37244] test_multiprocessing_forkserver: test_resource_tracker() failed on x86 Gentoo Refleaks 3.8

2019-06-25 Thread STINNER Victor
STINNER Victor added the comment: Thanks Pierre Glaser. I close the issue. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.9 ___ Python tracker ___

[issue37396] [2.7] PCbuild/pythoncore.vcxproj kills the wrong program

2019-06-25 Thread STINNER Victor
STINNER Victor added the comment: My question was more for Zachary who proposed: "backporting GH-9901 to 2.7 would probably also be good even though it was solving a different issue". But as I wrote, I'm not comfortable to backport such change in Python 2.7. I prefer to avoid changes except

[issue37388] unknown error handlers should be reported early

2019-06-25 Thread STINNER Victor
STINNER Victor added the comment: New changeset ed076ed467264b43ed01a8223ca65b133b590919 by Victor Stinner in branch 'master': bpo-37388: Add PyUnicode_Decode(str, 0) fast-path (GH-14385) https://github.com/python/cpython/commit/ed076ed467264b43ed01a8223ca65b133b590919 -- _

[issue37388] unknown error handlers should be reported early

2019-06-25 Thread STINNER Victor
STINNER Victor added the comment: I compared ref (commit e1a63c4f21011a3ae77dff624196561070c83446) to patch (commit ed076ed467264b43ed01a8223ca65b133b590919). I ran bench.py using: # edit Makefile.pre.in to use: PROFILE_TASK=-m test.regrtest --pgo test_unicode test_codecs ./configure --enabl

[issue37388] unknown error handlers should be reported early

2019-06-25 Thread STINNER Victor
STINNER Victor added the comment: Ok, the encoding and errors are now checked in almost all cases if you enable the development mode using -X dev command line option. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed _

[issue37406] Disable debug runtime checks in release mode

2019-06-25 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +14200 pull_request: https://github.com/python/cpython/pull/14386 ___ Python tracker ___ __

[issue23014] Don't have importlib.abc.Loader.create_module() be optional

2019-06-25 Thread Anthony Sottile
Anthony Sottile added the comment: Hi! just stumbled on this as I was updating pytest's import hook. I notice in PEP 451 this is still marked as optional (then again, I don't know whether PEPs are supposed to be living standards or not, or if there was a PEP which supersedes that one with b

[issue37406] Disable debug runtime checks in release mode

2019-06-25 Thread STINNER Victor
STINNER Victor added the comment: New changeset c6a2320e876354ee62cf8149b849bcff9492d38a by Victor Stinner in branch 'master': bpo-37406: sqlite3 raises TypeError for wrong operation type (GH-14386) https://github.com/python/cpython/commit/c6a2320e876354ee62cf8149b849bcff9492d38a --

[issue36917] ast.NodeVisitor no longer calls visit_Str

2019-06-25 Thread Daniel Hilst Selli
Change by Daniel Hilst Selli : -- nosy: +dhilst ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue37380] subprocess.Popen._cleanup() "The handle is invalid" error when some old process is gone

2019-06-25 Thread Steve Dower
Steve Dower added the comment: The handle can deliberately live beyond the process, but it does not have to. If it is closed early then the kernel object will be freed when no handles remain, which will be at process exit. So it's a classic __exit__/__del__ case, where both are needed if you

[issue29412] IndexError thrown on email.message.Message.get

2019-06-25 Thread Abhilash Raj
Change by Abhilash Raj : -- pull_requests: +14201 pull_request: https://github.com/python/cpython/pull/14387 ___ Python tracker ___

[issue37405] socket.getsockname() returns string instead of tuple

2019-06-25 Thread Brent Gardner
Brent Gardner added the comment: Changed caused by commit effc12f8e9e20d0951d2ba5883587666bd8218e3 to cpython/Modules/socketmodule.c on Sep 6, 2017. -- components: +Extension Modules ___ Python tracker

[issue37405] socket.getsockname() returns string instead of tuple

2019-06-25 Thread Brent Gardner
Brent Gardner added the comment: Correction, change caused by a30f6d45ac3e72761b96a8df0527182029eaee24 to cpython/Modules/socketmodule.c on Aug 28, 2017. -- ___ Python tracker __

[issue37380] subprocess.Popen._cleanup() "The handle is invalid" error when some old process is gone

2019-06-25 Thread Eryk Sun
Eryk Sun added the comment: > One issue on Linux is that the zombie process keeps the pid used until > the parent reads the child exit status, and Linux pids are limited to > 32768 by default. Windows allocates Process and Thread IDs out of a kernel handle table, which can grow to about 2**2

[issue13127] xml.dom.Attr.name is not labeled as read-only

2019-06-25 Thread Giovanni Cappellotto
Giovanni Cappellotto added the comment: I took a quick look at `minidom.py` and `test_minidom.py`. It seems that you should always use `doc.renameNode(attr, namespace, new_name)` for renaming an attribute (or an element). When `doc.renameNode` is applied on an attribute node, it removes the

[issue37251] Mocking a MagicMock with a function spec results in an AsyncMock

2019-06-25 Thread Lisa Roach
Lisa Roach added the comment: Yes, sorry I wasn't clear, I was thinking about the functions and testing without your PR. I think removing the __code__ object (or working around it) is the correct way to go, but just removing it wouldn't solve this particular problem. "If I understand the aw

[issue37407] Update imaplib.py to account for additional padding

2019-06-25 Thread Edward Smith
New submission from Edward Smith : Regex for imaplib should account for IMAP servers which return one or two whitespaces after the * in responses. For example when using davmail as an interpreter between exchange to IMAP Acceptable response is as follows: ``` 58:24.54 > PJJD3 EXAMINE INBOX

[issue37405] socket.getsockname() returns string instead of tuple

2019-06-25 Thread Ned Deily
Change by Ned Deily : -- nosy: +christian.heimes ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue37391] MacOS Touchpad scrolling crashes IDLE

2019-06-25 Thread Terry J. Reedy
Terry J. Reedy added the comment: It seems that the current warning WARNING: The version of Tcl/Tk (8.5.9) in use may be unstable. Visit http://www.python.org/download/mac/tcltk/ for current information. is not visible or strong enough to prevent spurious issues like this. I would like to

<    1   2