[issue36583] Do not swallow exceptions in the _ssl module

2019-04-10 Thread Serhiy Storchaka
New submission from Serhiy Storchaka : Currently some exceptions can be swallowed in the _ssl module. The proposed PR fixes this. Some examples: * Use PyDict_GetItemWithError() instead of PyDict_GetItem(). The latter swallows any exceptions. Although it is very unlikely that an exception be

[issue36584] cython nametuple TypeError

2019-04-10 Thread beruhan
New submission from beruhan : I have a class that inherits from NamedTuple,I have compile it to pyd file on windows use cython,when I import the class and create a object in another py file,It throws error 'TypeError: __new__() takes 1 positional argument but 4 were given' when I don't comp

[issue36417] unicode.isdecimal bug in online Python 2 documentation

2019-04-10 Thread zheng
Change by zheng : -- keywords: +patch pull_requests: +12684 stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bug

[issue36584] cython nametuple TypeError

2019-04-10 Thread beruhan
beruhan added the comment: the class definitions as follows: from typing import NamedTuple class Info(NamedTuple): service: str damage: str privilege: str info = Info("http", "no", "no") -- ___ Python tracker

[issue35459] Use PyDict_GetItemWithError() instead of PyDict_GetItem()

2019-04-10 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: There are few occurrences of PyDict_GetItem(), PyDict_GetItemString() and _PyDict_GetItemId() in cases where they are unlikely failed. These cases will be considered in separate issues. -- resolution: -> fixed stage: patch review -> resolved statu

[issue36417] unicode.isdecimal bug in online Python 2 documentation

2019-04-10 Thread zheng
zheng added the comment: I propose we copy over the exact changes made to the Python 3 documentation. I looked through the code mentioned in the other thread. Namely, `Objects/unicodeobject.c` and `Tools/unicode/makeunicodedata.py`. The implementation is identical between python 2 and python

[issue36584] cython nametuple TypeError

2019-04-10 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This is a bug tracker of CPython -- the C implementation of Python. For bugs in Cython use different tracker. -- nosy: +serhiy.storchaka resolution: -> third party stage: -> resolved status: open -> closed ___

[issue36559] "import random" should import hashlib on demand (nor load OpenSSL)

2019-04-10 Thread Inada Naoki
Inada Naoki added the comment: * Is hashlib large, slow to import library? -- Yes. * random module use hashlib only for specific (rare) use case? -- Yes. * Does user of random module needs hashlib in most case? -- No. For example, tmpfile user may not need hashlib. I'm +1 on PR 12728. -

[issue36583] Do not swallow exceptions in the _ssl module

2019-04-10 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +12686 stage: -> patch review ___ Python tracker ___ ___ Python-bug

[issue35906] [CVE-2019-9947] Header Injection in urllib

2019-04-10 Thread STINNER Victor
STINNER Victor added the comment: According to https://bugzilla.redhat.com/show_bug.cgi?id=1695572, the CVE-2019-9947 has been assigned to this issue. -- nosy: +vstinner title: Header Injection in urllib -> [CVE-2019-9947] Header Injection in urllib __

[issue14826] urlopen URL with unescaped space

2019-04-10 Thread Gregory P. Smith
Change by Gregory P. Smith : -- pull_requests: +12687 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue14826] urlopen URL with unescaped space

2019-04-10 Thread Gregory P. Smith
Gregory P. Smith added the comment: urllib.request.URLopener() and FancyURLopener() automatically quote() URLs for the user. Those APIs are marked deprecated since 3.3 but have no timeline for removal. urllib.request.urlopen() does not use those, so URLs passed in are not auto-quoted. i'l

[issue918368] urllib doesn't correct server returned urls

2019-04-10 Thread STINNER Victor
STINNER Victor added the comment: > For the other referenced issue1153027, bug is not reproducible in the > trunk and I see that fix has been made in revision 43132. This change was a fix for bpo-1353433: commit ddb84d7c69addc5d5e2ab3e327260d97b52af3a7 Author: Georg Brandl Date: Sat Mar 18

[issue30458] [CVE-2019-9740][security] CRLF Injection in httplib

2019-04-10 Thread Gregory P. Smith
Change by Gregory P. Smith : -- keywords: +patch pull_requests: +12688 stage: -> patch review ___ Python tracker ___ ___ Python-bug

[issue1353433] Http redirection error in urllib2.py

2019-04-10 Thread STINNER Victor
STINNER Victor added the comment: > Added a fix in rev. 43132. In Git, it became the commit: commit ddb84d7c69addc5d5e2ab3e327260d97b52af3a7 Author: Georg Brandl Date: Sat Mar 18 11:35:18 2006 + Bug #1353433: be conciliant with spaces in redirect URLs -- nosy: +vstinner

[issue14826] urlopen URL with unescaped space

2019-04-10 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 2fb2bc81c3f40d73945c6102569495140e1182c7 by Gregory P. Smith in branch 'master': bpo-14826: document that URLopener quotes fullurl. (GH-12758) https://github.com/python/cpython/commit/2fb2bc81c3f40d73945c6102569495140e1182c7 --

[issue14826] urlopen URL with unescaped space

2019-04-10 Thread miss-islington
Change by miss-islington : -- pull_requests: +12689 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue14826] urlopen URL with unescaped space

2019-04-10 Thread miss-islington
Change by miss-islington : -- pull_requests: +12690 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue30458] [CVE-2019-9740][security] CRLF Injection in httplib

2019-04-10 Thread Gregory P. Smith
Gregory P. Smith added the comment: Martin claimed "Actually, the CRLF + space can be injected via percent encoding" I am unable to reproduce that behavior using urllib.request.urlopen() or urllib.request.URLopener.open() in my master/3.8 tree. -- nosy: +gregory.p.smith

[issue30458] [CVE-2019-9740][security] CRLF Injection in httplib

2019-04-10 Thread Gregory P. Smith
Change by Gregory P. Smith : -- assignee: -> gregory.p.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue14826] urlopen URL with unescaped space

2019-04-10 Thread miss-islington
miss-islington added the comment: New changeset 9d2ccf173e2e8ff069153f603d2e5b1ea757e734 by Miss Islington (bot) in branch '3.7': bpo-14826: document that URLopener quotes fullurl. (GH-12758) https://github.com/python/cpython/commit/9d2ccf173e2e8ff069153f603d2e5b1ea757e734 -- nosy:

[issue35906] [CVE-2019-9947] Header Injection in urllib

2019-04-10 Thread Gregory P. Smith
Gregory P. Smith added the comment: my fix proposed in issue30458 fixes this issue. i do not think this one deserved its own CVE; at least https://nvd.nist.gov/vuln/detail/CVE-2019-9947's current text also points to the other one. -- nosy: +gregory.p.smith resolution: -> duplicate

[issue35906] [CVE-2019-9947] Header Injection in urllib

2019-04-10 Thread Gregory P. Smith
Change by Gregory P. Smith : -- stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-list m

[issue1153027] http_error_302() crashes with 'HTTP/1.1 400 Bad Request

2019-04-10 Thread STINNER Victor
STINNER Victor added the comment: > Sorry, I meant fixed in revision 72351. Commit in Git: commit 690ce9b353bc0a86d0886470adbaa50e813de3b8 Author: Senthil Kumaran Date: Tue May 5 18:41:13 2009 + Fix for issue1153027, making Py3k changes similar to fix in issue918368. This will

[issue36585] test_posix.py fails due to unsupported RWF_HIPRI

2019-04-10 Thread Jeroen Demeyer
New submission from Jeroen Demeyer : On Linux with an old kernel: 0:03:59 load avg: 5.97 [300/420/1] test_posix failed -- running: test_tools (1 min 11 sec), test_concurrent_futures (2 min 42 sec) test test_posix failed -- Traceback (most recent call last): File "/usr/local/src/sage-config/l

[issue27860] Improvements to ipaddress module

2019-04-10 Thread Inada Naoki
Inada Naoki added the comment: @moritzs Would you create a pull request on GitHub? Or may I create a pull request for your patch? -- nosy: +inada.naoki ___ Python tracker ___

[issue30458] [CVE-2019-9740][security] CRLF Injection in httplib

2019-04-10 Thread STINNER Victor
STINNER Victor added the comment: Oh, I didn't recall that this issue (this class of security vulnerabilities) has a so old history. I found *A LOT* of similar open issues. Here are my notes. Maybe most open issues should be closed as duplicate of this one to clarify the status of urllib in

[issue30458] [CVE-2019-9740][security] CRLF Injection in httplib

2019-04-10 Thread STINNER Victor
Change by STINNER Victor : -- versions: +Python 3.5, Python 3.6, Python 3.7, Python 3.8 ___ Python tracker ___ ___ Python-bugs-list

[issue36586] multiprocessing.Queue.close doesn't behave as documented

2019-04-10 Thread Thomas Grainger
New submission from Thomas Grainger : The docs for https://docs.python.org/3/library/multiprocessing.html#multiprocessing.Queue.close read: > Indicate that no more data will be put on this queue by the current process. > The background thread will quit once it has flushed all buffered data t

[issue30458] [CVE-2019-9740][CVE-2019-9947][security] CRLF Injection in httplib

2019-04-10 Thread STINNER Victor
STINNER Victor added the comment: > * 2019, bpo-35906: "[CVE-2019-9947] Header Injection in urllib" (another CVE!) Gregory P. Smith just marked bpo-35906 as a duplicate of this issue. Copy of his msg339842: """ my fix proposed in issue30458 fixes this issue. i do not think this one deserved

[issue36586] multiprocessing.Queue.close doesn't behave as documented

2019-04-10 Thread Thomas Grainger
Thomas Grainger added the comment: Should the docs be: > Indicate that no more data will be put on or got from this queue by the > current process. The background thread will quit once it has flushed all > buffered data to the pipe. This is called automatically when the queue is > garbage c

[issue30458] [CVE-2019-9740][CVE-2019-9947][security] CRLF Injection in httplib

2019-04-10 Thread STINNER Victor
STINNER Victor added the comment: > The CVE-2019-9740 has been assigned to the bpo-36276 I don't know how CVE are assigned. Since this issue started with "the patch in CVE-2016-5699 can be broke by an addition space", would it make sense to reuse CVE-2016-5699 rather than using a new CVE? -

[issue30458] [CVE-2019-9740][CVE-2019-9947][security] CRLF Injection in httplib

2019-04-10 Thread STINNER Victor
STINNER Victor added the comment: > Closed issues: I forgot: * 2017, bpo-30713: "Reject newline character (U+000A) in URLs in urllib.parse" Rejected: the ftplib vulnerabilty has been fixed by bpo-30119 with commmit 8c2d4cf092c5f0335e7982392a33927579c4d512. -- ___

[issue30458] [security][CVE-2019-9740][CVE-2019-9947] HTTP Header Injection (follow-up of CVE-2016-5699)

2019-04-10 Thread STINNER Victor
Change by STINNER Victor : -- title: [CVE-2019-9740][CVE-2019-9947][security] CRLF Injection in httplib -> [security][CVE-2019-9740][CVE-2019-9947] HTTP Header Injection (follow-up of CVE-2016-5699) ___ Python tracker

[issue36585] test_posix.py fails due to unsupported RWF_HIPRI

2019-04-10 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +12691 stage: -> patch review ___ Python tracker ___ ___ Pytho

[issue30458] [security][CVE-2019-9740][CVE-2019-9947] HTTP Header Injection (follow-up of CVE-2016-5699)

2019-04-10 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: As @gregory.p.smith noted in GitHub [0] this fixes only protocol level bugs. There are some parsing ambiguities in urllib that are potential security issues still to be fixed. issue20271 - urllib.urlparse('http://benign.com\[attacker.com]') returns

[issue30458] [security][CVE-2019-9740][CVE-2019-9947] HTTP Header Injection (follow-up of CVE-2016-5699)

2019-04-10 Thread Martin Panter
Martin Panter added the comment: Gregory, I haven’t tried recent Python code, but I expect the problem with percent decoding is still there. If you did try my example, what results did you see? Be aware that these techniques only work if the OS co-operates and connects to localhost when you g

[issue29284] Include thread_name_prefix in the concurrent.futures.ThreadPoolExecutor example 17.4.2.1

2019-04-10 Thread Cheryl Sabella
Cheryl Sabella added the comment: This seems like a reasonable request. A description of `thread_name_prefix` should probably also be added to the body of the class description instead of just in the versionadded directive. Assigning to @Mariatta for the sprints. Nosying @gregory.p.smith a

[issue32008] Example suggest to use a TLSv1 socket

2019-04-10 Thread Cheryl Sabella
Cheryl Sabella added the comment: @christian.heimes, this one looks ready to merge and close. Please take a look when you get a chance. Thanks! -- ___ Python tracker ___ __

[issue28626] Tutorial: rearrange discussion of output formatting to encourage f-strings

2019-04-10 Thread Cheryl Sabella
Change by Cheryl Sabella : -- keywords: -needs review, patch resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue36583] Do not swallow exceptions in the _ssl module

2019-04-10 Thread Christian Heimes
Change by Christian Heimes : -- assignee: -> serhiy.storchaka type: -> enhancement ___ Python tracker ___ ___ Python-bugs-list mai

[issue31226] shutil.rmtree fails when target has an internal directory junction (Windows)

2019-04-10 Thread Vidar Fauske
Vidar Fauske added the comment: I think the submitted PR could need a pair of eyes now. I've sorted the merge conflicts, and addressed the previous review points by eryksun. -- ___ Python tracker __

[issue30458] [security][CVE-2019-9740][CVE-2019-9947] HTTP Header Injection (follow-up of CVE-2016-5699)

2019-04-10 Thread STINNER Victor
STINNER Victor added the comment: bpo-36276 has been marked as a duplicate of this issue. According to the following message, urllib3 is also vulnerable to HTTP Header Injection: https://bugs.python.org/issue36276#msg337837 Copy of Alvin Chang's msg337837: """ I am also seeing the same issu

[issue30458] [security][CVE-2019-9740][CVE-2019-9947] HTTP Header Injection (follow-up of CVE-2016-5699)

2019-04-10 Thread STINNER Victor
STINNER Victor added the comment: > According to the following message, urllib3 is also vulnerable to HTTP Header > Injection: (...) And the issue has been reported to urllib3: https://github.com/urllib3/urllib3/issues/1553 Copy of the first message: """ At https://bugs.python.org/issue3627

[issue34698] urllib.request.Request.set_proxy doesn't (necessarily) replace type

2019-04-10 Thread Cheryl Sabella
Change by Cheryl Sabella : -- nosy: +orsenthil versions: +Python 3.8 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue36533] logging regression with threading + fork are mixed in 3.7.1rc2 (deadlock potential)

2019-04-10 Thread STINNER Victor
Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue36549] str.capitalize should titlecase the first character not uppercase

2019-04-10 Thread STINNER Victor
Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue36235] distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is set

2019-04-10 Thread STINNER Victor
STINNER Victor added the comment: Good, my change fixed x86-64 High Sierra 2.7 buildbot: https://buildbot.python.org/all/#/builders/140/builds/216 I wrote PR 12764 to forward-port the fix to the master branch. -- ___ Python tracker

[issue36235] distutils.sysconfig.customize_compiler() overrides CFLAGS var with OPT var if CFLAGS env var is set

2019-04-10 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +12692 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue36346] Prepare for removing the legacy Unicode C API

2019-04-10 Thread Inada Naoki
Inada Naoki added the comment: I think these ABI incompatible options are used many people. But it is helpful to find extensions which using legacy APIs before Python 3.10 is released. I had found ujson and MarkupSafe used legacy APIs. I fixed MarkupSafe. I don't care ujson because it is wra

[issue30458] [security][CVE-2019-9740][CVE-2019-9947] HTTP Header Injection (follow-up of CVE-2016-5699)

2019-04-10 Thread STINNER Victor
STINNER Victor added the comment: Since this issue has a long history and previously attempts to fix it failed, it seems like the Internet is a black or white world, more like a scale of gray... *Maybe* we need to provide a way to allow to pass junk characters in an URL? (disable URL validat

[issue21318] sdist fails with symbolic links do non-existing files

2019-04-10 Thread Cheryl Sabella
Cheryl Sabella added the comment: This was fixed under issue 12885. -- nosy: +cheryl.sabella resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> distutils.filelist.findall() fails on broken symlink in Py2.x ___ Pytho

[issue36533] logging regression with threading + fork are mixed in 3.7.1rc2 (deadlock potential)

2019-04-10 Thread cagney
cagney added the comment: > nope. the contrived emit() pseudocode from msg339650 never defined b in the > first place. that code, if massaged into python syntax would raise an > UnboundLocalError no matter who executed it. a fork() from another thread > would not change that. There is no

[issue24011] Add error checks to PyInit_signal()

2019-04-10 Thread Cheryl Sabella
Change by Cheryl Sabella : -- stage: patch review -> needs patch versions: +Python 3.7, Python 3.8 -Python 3.4, Python 3.5 ___ Python tracker ___ __

[issue36533] logging regression with threading + fork are mixed in 3.7.1rc2 (deadlock potential)

2019-04-10 Thread cagney
cagney added the comment: BTW, non-visible change might be to use a global readers-writer lock where fork() is the writer. https://en.wikipedia.org/wiki/Readers%E2%80%93writer_lock -- ___ Python tracker __

[issue30612] Unusual Windows registry path syntax

2019-04-10 Thread Cheryl Sabella
Cheryl Sabella added the comment: @chrullrich, were you still interested in creating a PR for this? Thanks! -- nosy: +cheryl.sabella versions: +Python 3.8 -Python 3.6 ___ Python tracker

[issue36587] race in logging code when fork()

2019-04-10 Thread cagney
New submission from cagney : Buried in issue36533; it should probably be turned into a test case. Exception ignored in: Traceback (most recent call last): File "/home/python/v3.7.3/lib/python3.7/logging/__init__.py", line 269, in _after_at_fork_weak_calls _at_fork_weak_calls('release')

[issue19476] Add a dedicated specification for module "reloading" to the language reference

2019-04-10 Thread Cheryl Sabella
Cheryl Sabella added the comment: Hi Eric, Is this still a concern since PEP 451 has been implemented for over 5 years now? Thanks! -- nosy: +cheryl.sabella -BreamoreBoy ___ Python tracker ___

[issue36587] race in logging code when fork()

2019-04-10 Thread SilentGhost
Change by SilentGhost : -- nosy: +gregory.p.smith, vinay.sajip type: crash -> behavior ___ Python tracker ___ ___ Python-bugs-list m

[issue19476] Add a dedicated specification for module "reloading" to the language reference

2019-04-10 Thread Eric Snow
Eric Snow added the comment: Thanks for checking in, Cheryl! Clearly no one picked up this banner. :) Furthermore, I'm not aware of any reload-related complaints coming from the community. I know of only a couple major use cases for reload(): refresh parts of a running app during develop

[issue36588] change sys.platform() to just "aix" for AIX

2019-04-10 Thread Michael Felt
New submission from Michael Felt : This is something that probably shouts - boring - but back in 2012 it was a hot topic for linux2 and linux3. Maybe - as far back as 1996 (when AIX4 was new) "aix3" and "aix4" made sense. Whether that is true, or not - is pointless these days - for Python3.

[issue36588] change sys.platform() to just "aix" for AIX

2019-04-10 Thread STINNER Victor
STINNER Victor added the comment: I like the idea. Would you like to propose a patch? I suggest to only make such change in Python 3.8 and properly document it. -- nosy: +vstinner ___ Python tracker ___

[issue1583] Patch for signal.set_wakeup_fd

2019-04-10 Thread Adam Olsen
Adam Olsen added the comment: signal-safe is different from thread-safe (despite conceptual similarities), but regardless it's been a long time since I last delved into this so I'm quite rusty. I could be doing it all wrong. -- ___ Python tracker

[issue36588] change sys.platform() to just "aix" for AIX

2019-04-10 Thread Michael Felt
Michael Felt added the comment: On 10/04/2019 17:05, STINNER Victor wrote: > STINNER Victor added the comment: > > I like the idea. Would you like to propose a patch? I suggest to only make > such change in Python 3.8 and properly document it. > > -- > nosy: +vstinner > > _

[issue36579] test_venv: test_with_pip() hangs on PPC64 AIX 3.x

2019-04-10 Thread Michael Felt
Michael Felt added the comment: On 09/04/2019 18:51, STINNER Victor wrote: > New submission from STINNER Victor : > > https://buildbot.python.org/all/#/builders/10/builds/2389 > > 0:45:36 [412/420/1] test_venv crashed (Exit code 1) > Timeout (0:15:00)! > Thread 0x0001 (most recent call firs

[issue1583] Patch for signal.set_wakeup_fd

2019-04-10 Thread Guido van Rossum
Change by Guido van Rossum : -- nosy: -gvanrossum ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue19770] NNTP.post broken

2019-04-10 Thread Cheryl Sabella
Cheryl Sabella added the comment: Hi David, You wrote: > It might be worth adding a post_message method, analogous to the send_message > method I added to smtplib. Do you still think this would be worthwhile to add? If so, do you think this would be a good task for someone to work on at th

[issue36579] test_venv: test_with_pip() hangs on PPC64 AIX 3.x

2019-04-10 Thread STINNER Victor
STINNER Victor added the comment: "I am looking into this - but as it seems to have gone away again - is there a simple way to get that code back, and/or see what the diff is, before/badrun/after?" Maybe it's just a flacky test. It's hard to guess. You can get the Git revision of a build by l

[issue36346] Prepare for removing the legacy Unicode C API

2019-04-10 Thread STINNER Victor
Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue36475] PyEval_AcquireLock() and PyEval_AcquireThread() do not handle runtime finalization properly.

2019-04-10 Thread Joannah Nanjekye
Joannah Nanjekye added the comment: @eric do we need any tests for this? -- ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue34144] venv activate.bat reset codepage fails on windows 10

2019-04-10 Thread miss-islington
miss-islington added the comment: New changeset 6955d44b41058e3bcc59ff41860bd4cc8948c441 by Miss Islington (bot) (Lorenz Mende) in branch 'master': bpo-34144: Fix of venv acvtivate.bat for win 10 (GH-8321) https://github.com/python/cpython/commit/6955d44b41058e3bcc59ff41860bd4cc8948c441 ---

[issue24011] Add error checks to PyInit_signal()

2019-04-10 Thread Joannah Nanjekye
Change by Joannah Nanjekye : -- pull_requests: +12693 stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue36549] str.capitalize should titlecase the first character not uppercase

2019-04-10 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This issue is easy if you know C. * Find the implementation of str.capitalize in unicodeobject.c and make it using the title case. See on the implementation of str.title for example. * Find tests for str.capitalize and aďd new cases. Finding the proper plac

[issue19770] NNTP.post broken

2019-04-10 Thread R. David Murray
R. David Murray added the comment: I do, and sure. I won't be able to review it, though :( -- ___ Python tracker ___ ___ Python-bu

[issue36587] race in logging code when fork()

2019-04-10 Thread Gregory P. Smith
Change by Gregory P. Smith : -- assignee: -> gregory.p.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue36587] race in logging code when fork()

2019-04-10 Thread Gregory P. Smith
Gregory P. Smith added the comment: yeah i saw that bug buried in there, this weakset goes away with my proposed PR. -- ___ Python tracker ___

[issue36589] Incorrect error handling in curses.update_lines_cols()

2019-04-10 Thread Zackery Spytz
New submission from Zackery Spytz : update_lines_cols() returns 0 if an error occurs, but the generated AC code checks for a return value of -1. -- components: Extension Modules messages: 339881 nosy: ZackerySpytz priority: normal severity: normal status: open title: Incorrect error ha

[issue36533] logging regression with threading + fork are mixed in 3.7.1rc2 (deadlock potential)

2019-04-10 Thread Gregory P. Smith
Gregory P. Smith added the comment: The problem i am fixing is merely making Python's logging library not the source of this deadlock because it was not the source in the past. I am solving a regression in CPython behavior between 3.7.0 and 3.7.1 that led to a logging.Handler lock related d

[issue36589] Incorrect error handling in curses.update_lines_cols()

2019-04-10 Thread Zackery Spytz
Change by Zackery Spytz : -- keywords: +patch pull_requests: +12694 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-l

[issue36501] Remove POSIX.1e ACLs in tests that rely on default permissions behavior

2019-04-10 Thread Ivan Pozdeev
Ivan Pozdeev added the comment: Given the downsides, I think the proposed solution as it's now is too hacky to be a net improvement. "Skip mode_t checks" looks like the only way to go (since I've no idea how to "create temporary dirs" transparently for arbitrary test logic). But skipping te

[issue36586] multiprocessing.Queue.close doesn't behave as documented

2019-04-10 Thread Brett Cannon
Change by Brett Cannon : -- components: +Library (Lib) nosy: +davin, pitrou ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue26389] Expand traceback module API to accept just an exception as an argument

2019-04-10 Thread Brett Cannon
Brett Cannon added the comment: Boy, having a postional-only parameter in that first position would have been handy when we created this API (as Matthias pointed out). :) The 'exec' keyword-only parameter is obviously the safest option here. Making the first parameter positional-only and the

[issue30458] [security][CVE-2019-9740][CVE-2019-9947] HTTP Header Injection (follow-up of CVE-2016-5699)

2019-04-10 Thread Gregory P. Smith
Gregory P. Smith added the comment: > *Maybe* we need to provide a way to allow to pass junk characters in an URL? > (disable URL validation) We should not do this in our http protocol stack code. Anyone who _wants_ that is already intentionally violating the http protocol which defeats the

[issue30274] Make importlib.abc.ExtensionFileLoader.__init__() documentation match code

2019-04-10 Thread Brett Cannon
Brett Cannon added the comment: I realized another solution to this is to make the argument positional-only, then the name simply doesn't matter. Probably unnecessary breakage, though. -- versions: +Python 3.8 ___ Python tracker

[issue36559] "import random" should import hashlib on demand (nor load OpenSSL)

2019-04-10 Thread Raymond Hettinger
Change by Raymond Hettinger : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue36559] "import random" should import hashlib on demand (nor load OpenSSL)

2019-04-10 Thread Raymond Hettinger
Raymond Hettinger added the comment: New changeset d914596a671c4b0f13641359cf43aa0d6fc05070 by Raymond Hettinger (Christian Heimes) in branch 'master': bpo-36559: random module: optimize sha512 import (GH-12742) https://github.com/python/cpython/commit/d914596a671c4b0f13641359cf43aa0d6fc05070

[issue36590] Add Bluetooth RFCOMM Support for Windows

2019-04-10 Thread Greg Bowser
New submission from Greg Bowser : socketmodule supports Bluetooth RFCOMM sockets for Linux. Given that winsock supports this under windows, it is possible to add windows support as well. -- components: IO, Windows messages: 339888 nosy: Greg Bowser, paul.moore, steve.dower, tim.golden,

[issue36555] PEP484 @overload vs. str/bytes

2019-04-10 Thread Guido van Rossum
Guido van Rossum added the comment: > Mypy already takes first overload for ambiguous arguments. This is true, but it requires that the return types match (covariantly, IIUC) for the overlapping types. So you can have @overload def foo(x: int) -> int: ... @overload def foo(x: float) -> float

[issue36549] str.capitalize should titlecase the first character not uppercase

2019-04-10 Thread Kingsley McDonald
Kingsley McDonald added the comment: Thanks for clarifying all of that! I now have the patch and tests working locally. However, I'm not too sure what documentation needs to be changed for str.title. Should it specify that only the first letter of digraphs are capitalised, rather than the fu

[issue36590] Add Bluetooth RFCOMM Support for Windows

2019-04-10 Thread Roundup Robot
Change by Roundup Robot : -- keywords: +patch pull_requests: +12695 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-l

[issue24116] --with-pydebug has no effect when the final python binary is compiled

2019-04-10 Thread Cheryl Sabella
Cheryl Sabella added the comment: If this is a documentation issue on the build, then I think this issue should be moved to the devguide repo on GitHub. I'm not sure if it's still unclear though, so maybe this could just be closed? -- nosy: +cheryl.sabella _

[issue1583] Patch for signal.set_wakeup_fd

2019-04-10 Thread Jeroen Demeyer
Jeroen Demeyer added the comment: > signal-safe is different from thread-safe I know, but I think that other threads can receive signals too. So in that case, it needs to be signal-safe as well as thread-safe. -- ___ Python tracker

[issue1222585] C++ compilation support for distutils

2019-04-10 Thread STINNER Victor
Change by STINNER Victor : -- nosy: +vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue36591] Should be a typing.UserNamedTuple

2019-04-10 Thread Terry Davis
New submission from Terry Davis : There should be a builtin alias for `Type[NamedTuple]` so that library authors user-supplied `NamedTuple`s can properly type-check their code. Here's a code sample that causes an issue in my IDE (PyCharm) from typing import Na

[issue19770] NNTP.post broken

2019-04-10 Thread STINNER Victor
Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue30458] [security][CVE-2019-9740][CVE-2019-9947] HTTP Header Injection (follow-up of CVE-2016-5699)

2019-04-10 Thread STINNER Victor
STINNER Victor added the comment: > Will this break something in the world other than our own test_xmlrpc test? > Probably. Do they have a right to complain about it? Not one we need listen > to. I understand. But. Can we consider that for old Python versions like Python 2.7 and 3.5? Thi

[issue36588] change sys.platform() to just "aix" for AIX

2019-04-10 Thread STINNER Victor
STINNER Victor added the comment: > However, I am less familiar with (where) the appropriate documentation is. A > pointer to the documentation is appreciated. It would be nice to add a note to: * https://docs.python.org/dev/whatsnew/3.8.html#changes-in-the-python-api * https://docs.python.o

[issue18564] Integer overflow in socketmodule

2019-04-10 Thread Cheryl Sabella
Cheryl Sabella added the comment: Michele Orrù, Would you be interested in making a GitHub pull request for your patch? Thanks! -- nosy: +cheryl.sabella ___ Python tracker __

[issue1583] Patch for signal.set_wakeup_fd

2019-04-10 Thread Adam Olsen
Adam Olsen added the comment: signalmodule.c has a hack to limit it to the main thread. Otherwise there's all sorts of platform-specific behaviour. -- ___ Python tracker ___

[issue31904] Python should support VxWorks RTOS

2019-04-10 Thread STINNER Victor
STINNER Victor added the comment: Please stop adding more pull requests, I cannot review too many at the same time. I would prefer to have a limit of 4 open PRs. I don't propose to close existing ones. Just stop to add more :-) -- ___ Python track

  1   2   >