[issue34866] CGI DOS vulnerability via long post list

2018-10-30 Thread STINNER Victor
STINNER Victor added the comment: I suggest to not add the new parameter to 3.4 and 3.5 branches, even if it's a security fix. The fix requires to *use* the parameter, and I don't expect applications on Python 3.4 and 3.5 to be modified to use it. --

[issue33376] [pysqlite] Duplicate rows can be returned after rolling back a transaction

2018-10-30 Thread cary
Change by cary : -- keywords: +patch pull_requests: +9564 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailin

[issue35034] Add closing and iteration to threading.Queue

2018-10-30 Thread Vladimir Filipović
Vladimir Filipović added the comment: Hi Raymond! I've posted to python-ideas: https://mail.python.org/pipermail/python-ideas/2018-October/054238.html The amount of attention it got was modest, so I couldn't exactly say the community has thoroughly vetted and enthusiastically endorsed this p

[issue34866] CGI DOS vulnerability via long post list

2018-10-30 Thread Matthew Belisle
Matthew Belisle added the comment: That makes sense Victor, I agree. Thanks for merging those PRs. -- ___ Python tracker ___ ___ Py

[issue34866] CGI DOS vulnerability via long post list

2018-10-30 Thread STINNER Victor
STINNER Victor added the comment: Thanks Matthew Belisle for the nice security counter-measure! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 3.4, Python 3.5 ___ Python tracker

[issue35109] Doctest in CI uses python binary built from master causing DeprecationWarnings

2018-10-30 Thread Julien Palard
Change by Julien Palard : -- nosy: +matrixise ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue35109] Doctest in CI uses python binary built from master causing DeprecationWarnings

2018-10-30 Thread Julien Palard
Julien Palard added the comment: > I propose using stable version of Python like python 3.7 If we do so, we won't be able to write doctest about new features (existing in 3.8, not existing in 3.7), which is worse than having warnings. I think the right move is to do some PR on remote project

[issue35109] Doctest in CI uses python binary built from master causing DeprecationWarnings

2018-10-30 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: I have an open PR for babel https://github.com/python-babel/babel/pull/608 . The problem is merging them and cutting a new release depends on the maintainers availability. Once it's fixed we have to make sure dependencies of babel like sphinx use t

[issue35109] Doctest in CI uses python binary built from master causing DeprecationWarnings

2018-10-30 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: > If we do so, we won't be able to write doctest about new features (existing > in 3.8, not existing in 3.7), which is worse than having warnings. I agree with the same. Maybe I am running doctest wrong locally? I use make venv and make doctest. So

[issue33376] [pysqlite] Duplicate rows can be returned after rolling back a transaction

2018-10-30 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue35109] Doctest in CI uses python binary built from master causing DeprecationWarnings

2018-10-30 Thread Julien Palard
Julien Palard added the comment: > Maybe I am running doctest wrong locally? Dunno. IIRC we had problems running doctest with a Python 3.7 on the 3.8 branch, which make sense. Anyway, if it works today, the first developper writing doctest about a 3.8 feature will cause a doctest failure so

[issue35109] Doctest in CI uses python binary built from master causing DeprecationWarnings

2018-10-30 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: > Anyway, if it works today, the first developper writing doctest about a 3.8 > feature will cause a doctest failure so no we can't use 3.7 to test 3.8. Agreed that we need to run on the master branch binary for 3.8 only features like PEP 572 which

[issue34788] ipaddress module fails on rfc4007 scoped IPv6 addresses

2018-10-30 Thread Lisa Roach
Lisa Roach added the comment: I think this is something that would be good to have. Jeremy would you care to make a PR for this? -- nosy: +lisroach ___ Python tracker ___ ___

[issue33376] [pysqlite] Duplicate rows can be returned after rolling back a transaction

2018-10-30 Thread Maxime Belanger
Change by Maxime Belanger : -- nosy: +Maxime Belanger ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue35110] Fix more spaces around hyphens and dashes

2018-10-30 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 3f819ca138db6945ee4271bf13e42db9f9b3b1e4 by Serhiy Storchaka in branch 'master': bpo-35110: Fix unintentional spaces around hyphens and dashes. (GH-10231) https://github.com/python/cpython/commit/3f819ca138db6945ee4271bf13e42db9f9b3b1e4

[issue33138] Improve standard error for uncopyable types

2018-10-30 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 0353b4eaaf451ad463ce7eb3074f6b62d332f401 by Serhiy Storchaka in branch 'master': bpo-33138: Change standard error message for non-pickleable and non-copyable types. (GH-6239) https://github.com/python/cpython/commit/0353b4eaaf451ad463ce7eb307

[issue33138] Improve standard error for uncopyable types

2018-10-30 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue33533] Provide an async-generator version of as_completed

2018-10-30 Thread Michael DePalatis
Change by Michael DePalatis : -- keywords: +patch pull_requests: +9565 stage: -> patch review ___ Python tracker ___ ___ Python-bug

[issue35118] Add peek() or first() method in queue

2018-10-30 Thread Windson Yang
New submission from Windson Yang : I found other languages like Java and C++ have the method to access the first value in Queue like first() and peek(). Since we use deque_ to create Queue now, it's easy to implement in python using the index. Otherwise, we can add this to the document? I als

[issue35118] Add peek() or first() method in queue

2018-10-30 Thread Raymond Hettinger
Change by Raymond Hettinger : -- assignee: docs@python -> rhettinger nosy: +rhettinger ___ Python tracker ___ ___ Python-bugs-list m

[issue35117] set.discard should return True or False based on if element existed.

2018-10-30 Thread Raymond Hettinger
Change by Raymond Hettinger : -- assignee: -> rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: htt

[issue35117] set.discard should return True or False based on if element existed.

2018-10-30 Thread Windson Yang
Windson Yang added the comment: I guess we can implement using ref_count? However, I agreed "The use of variables that haven't been defined or set (implicitly or explicitly) is almost always a bad thing in any language since it indicates that the logic of the program hasn't been thought thr

[issue35118] Add peek() or first() method in queue

2018-10-30 Thread Raymond Hettinger
Raymond Hettinger added the comment: For deque, we have d[0]. Is anything more needed? Even lists don't require a peek. For Queue, I'm not sure I've ever seen any use case for peek. What do you have in mind? * https://docs.oracle.com/javase/7/docs/api/java/util/Queue.html#peek() -

[issue35119] Customizing module attribute access example raises RecursionError

2018-10-30 Thread Denis Osipov
New submission from Denis Osipov : Customizing module attribute access example raises RecursionError: >>> import sys >>> from types import ModuleType >>> class VerboseModule(ModuleType): ... def __repr__(self): ... return f'Verbose {self.__name__}' ... def __setattr__(self, attr

[issue35111] Make Custom Object Classes JSON Serializable

2018-10-30 Thread Raymond Hettinger
Change by Raymond Hettinger : -- assignee: -> bob.ippolito nosy: +bob.ippolito ___ Python tracker ___ ___ Python-bugs-list mailing

[issue35118] Add peek() or first() method in queue

2018-10-30 Thread Windson Yang
Windson Yang added the comment: For deque, we can add peek() function to deque or just make it clear in the document that we can use deque[0] to access the first element(I can only find index method in the document) For Queue, I found Java and C++ has the function like first() or peek(), I'm

[issue35111] Make Custom Object Classes JSON Serializable

2018-10-30 Thread Raymond Hettinger
Raymond Hettinger added the comment: > If you can serialize an object using pickle, > why not have the ability to serialize objects using json? One reason would be that the JSON spec was intentionally designed to handle a limited number of types so that it would have maximum interoperability

[issue35118] Add peek() or first() method in queue

2018-10-30 Thread Raymond Hettinger
Raymond Hettinger added the comment: In the absence of good use cases, I'll decline the API expansion. Feel free to post a PR to have the deque documentation to mention d[0] indexing more prominently. Am not really sure that is needed though, we don't have to point out the same thing for li

[issue35120] SSH tunnel support to ftp lib

2018-10-30 Thread Mohit Sharma
New submission from Mohit Sharma : SSH tunnel forwarding doesn't work with ftp lib -- messages: 328970 nosy: msharma priority: normal severity: normal status: open title: SSH tunnel support to ftp lib type: enhancement versions: Python 2.7 ___ Python

[issue35111] Make Custom Object Classes JSON Serializable

2018-10-30 Thread Bob Ippolito
Bob Ippolito added the comment: The trouble with having such a hook is that it would take precedence over any customization you might want or need to do to satisfy the protocol you're implementing. Other than the limited set of types that are part of the JSON specification, there's essential

[issue35117] set.discard should return True or False based on if element existed.

2018-10-30 Thread Raymond Hettinger
Raymond Hettinger added the comment: We already have ways to do it (use the in-operator to test membership or put a remove() call in a try/except). Since already we have ways to do it and since those patterns are rare in practice, an API extension doesn't seem warranted. Also, I don't reall

[issue35121] Cookie domain check returns incorrect results

2018-10-30 Thread 西田雄治
New submission from 西田雄治 : http.cookiejar.DefaultPolicy.domain_return_ok returns incorrect results. So, HTTP clients send cookies which issued from wrong server. policy = http.cookiejar.DefaultCookiePolicy() req = urllib.request.Request('https://xxxfoo.co.jp/') print(policy.domain_return_ok('fo

<    1   2