[issue30811] A venv created and activated from within a virtualenv uses the outer virtualenv's site-packages rather than its own.

2018-06-19 Thread Josh Holland
Change by Josh Holland : -- nosy: +anowlcalledjosh ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue33906] IDLE: change windows.py to window.py

2018-06-19 Thread Terry J. Reedy
New submission from Terry J. Reedy : Change module 'windows' to 'window':: 1. 'calltips' and 'windows' are the only two plural module names. 2. The top menu entry was changed from 'Windows' to 'Window' some time ago. 3. 'windows' is also a OS. With all modules at least imported in a test, all i

[issue33906] IDLE: rename windows.py as window.py

2018-06-19 Thread Terry J. Reedy
Change by Terry J. Reedy : -- title: IDLE: change windows.py to window.py -> IDLE: rename windows.py as window.py ___ Python tracker ___ __

[issue33904] IDLE: In rstrip, rename class RstripExtension as Rstrip

2018-06-19 Thread Terry J. Reedy
Change by Terry J. Reedy : -- title: IDLE: In rstrip, change class RstripExtension to Rstrip -> IDLE: In rstrip, rename class RstripExtension as Rstrip ___ Python tracker ___

[issue33907] IDLE: Rename calltips and CallTips as calltip and Calltip.

2018-06-19 Thread Terry J. Reedy
New submission from Terry J. Reedy : Rename module 'calltips' as 'calltip' 1. 'calltips' and 'windows' are the only two plural module names. 2. 'calltip' fits better with 'calltip_w' (which may, however, be merged in 'calltip'. Module rename can be checked as with 'window', #33906. and class C

[issue33839] IDLE tooltips.py: refactor and add docstrings and tests

2018-06-19 Thread Terry J. Reedy
Terry J. Reedy added the comment: I am going to change calltips.py and CallTips to calltip.py and Calltip in #33907, but will not change tooltip.py there as I would expect a merge conflict. Once the change is made elsewhere, change should be made to tooltip and test_tooltip directly. -

[issue33855] IDLE: Minimally test every non-startup module.

2018-06-19 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 4d92158f4c3917fc4fbfebff15224e74782abf79 by Terry Jan Reedy in branch 'master': bpo-33855: Still more edits and minimal tests for IDLE (GH-7784) https://github.com/python/cpython/commit/4d92158f4c3917fc4fbfebff15224e74782abf79 -- ___

[issue33855] IDLE: Minimally test every non-startup module.

2018-06-19 Thread miss-islington
Change by miss-islington : -- pull_requests: +7411 stage: test needed -> patch review ___ Python tracker ___ ___ Python-bugs-list ma

[issue33855] IDLE: Minimally test every non-startup module.

2018-06-19 Thread miss-islington
Change by miss-islington : -- pull_requests: +7412 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue33301] Add __contains__ to pathlib

2018-06-19 Thread Andrew Berger
Andrew Berger added the comment: I think the idea is that either a subdir or file could be valid inputs. So `Path('/usr/bar') in Path('/etc/foo')` return True if `Path('/etc/foo/usr/bar')` is either a dir or file. As for PurePath, I did overlook that accessing an inode via a call to stat w

[issue33855] IDLE: Minimally test every non-startup module.

2018-06-19 Thread miss-islington
miss-islington added the comment: New changeset cbaee6fe02d22f357c2edf4e463c240d5df22f14 by Miss Islington (bot) in branch '3.7': bpo-33855: Still more edits and minimal tests for IDLE (GH-7784) https://github.com/python/cpython/commit/cbaee6fe02d22f357c2edf4e463c240d5df22f14 -- _

[issue33855] IDLE: Minimally test every non-startup module.

2018-06-19 Thread miss-islington
miss-islington added the comment: New changeset 90209a172c5b629f512cf292a22950285a2c3d81 by Miss Islington (bot) in branch '3.6': bpo-33855: Still more edits and minimal tests for IDLE (GH-7784) https://github.com/python/cpython/commit/90209a172c5b629f512cf292a22950285a2c3d81 -- _

[issue23548] TypeError in event loop finalizer, new in Python 3.4.3

2018-06-19 Thread William Woodall
William Woodall added the comment: Just an update to my previous post. We ran into this issue again, but only noticed later because we do not see this problem on Ubuntu Bionic with Python 3.6.5, but we did see it again when we tested later on Ubuntu Xenial with Python 3.5.1. See: https://gi

[issue33907] IDLE: Rename calltips and CallTips as calltip and Calltip.

2018-06-19 Thread Terry J. Reedy
Change by Terry J. Reedy : -- keywords: +patch pull_requests: +7413 stage: needs patch -> patch review ___ Python tracker ___ ___ Py

[issue33855] IDLE: Minimally test every non-startup module.

2018-06-19 Thread Terry J. Reedy
Terry J. Reedy added the comment: Still open for a patch explaining idle_test.template in README. I opened #33904 for rstrip, #33905 for stackbrowser, #33906 for windows, and #33907 for calltips/CallTip renaming. -- stage: patch review -> test needed

[issue33907] IDLE: Rename calltips and CallTips as calltip and Calltip.

2018-06-19 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 06e2029dfa500a42e3565ed7ba8573412f153d1c by Terry Jan Reedy in branch 'master': bpo-33907: Rename an IDLE module and class. (GH-7807) https://github.com/python/cpython/commit/06e2029dfa500a42e3565ed7ba8573412f153d1c -- ___

[issue33907] IDLE: Rename calltips and CallTips as calltip and Calltip.

2018-06-19 Thread miss-islington
Change by miss-islington : -- pull_requests: +7414 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue33907] IDLE: Rename calltips and CallTips as calltip and Calltip.

2018-06-19 Thread miss-islington
miss-islington added the comment: New changeset b89a376b3b9bdc3b6f1b7d05ff64babcbfd93cc2 by Miss Islington (bot) in branch '3.7': bpo-33907: Rename an IDLE module and class. (GH-7807) https://github.com/python/cpython/commit/b89a376b3b9bdc3b6f1b7d05ff64babcbfd93cc2 -- nosy: +miss-is

[issue33907] IDLE: Rename calltips and CallTips as calltip and Calltip.

2018-06-19 Thread Terry J. Reedy
Change by Terry J. Reedy : -- pull_requests: +7415 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue33907] IDLE: Rename calltips and CallTips as calltip and Calltip.

2018-06-19 Thread Terry J. Reedy
Terry J. Reedy added the comment: I also changed calltips.CallTips to calltip.Calltip, which is the same class name as for calltip_w.Calltip (formerly CallTip). This is confusing now and would block merging the files. Change the latter to calltip_w.CalltipW (for Window). -- nosy:

[issue33907] IDLE: Rename calltips and CallTips as calltip and Calltip.

2018-06-19 Thread Terry J. Reedy
Terry J. Reedy added the comment: The calltip window class name is only used in 4 places, so I decided to expand to CalltipWindow. -- ___ Python tracker ___ _

[issue33301] Add __contains__ to pathlib

2018-06-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: There was a similar (closed) issue about making Path an iterable. The problem with both these related ideas is that they are ambiguous. Does it means that a directory contains a specified file, or that a path contains a specified path component, or that a

[issue33907] IDLE: Rename calltips and CallTips as calltip and Calltip.

2018-06-19 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset e97a685185b82ba6de6de576fc2a4cf3cd6192af by Terry Jan Reedy in branch '3.6': [3.6] bpo-33907: Rename an IDLE module and class. (GH-7807) (GH-7809) https://github.com/python/cpython/commit/e97a685185b82ba6de6de576fc2a4cf3cd6192af --

[issue33907] IDLE: Rename calltips and CallTips as calltip and Calltip.

2018-06-19 Thread Terry J. Reedy
Change by Terry J. Reedy : -- pull_requests: +7416 stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list ma

[issue33908] remove unecessary variable assignments

2018-06-19 Thread Srinivas Reddy T
New submission from Srinivas Reddy T : https://github.com/python/cpython/pull/7116 -- messages: 320018 nosy: thatiparthy priority: normal severity: normal status: open title: remove unecessary variable assignments type: resource usage versions: Python 3.7, Python 3.8 _

[issue33908] remove unecessary variable assignments

2018-06-19 Thread Srinivas Reddy T
Change by Srinivas Reddy T : -- keywords: +patch pull_requests: +7417 stage: -> patch review ___ Python tracker ___ ___ Python-bug

[issue33908] remove unecessary variable assignments

2018-06-19 Thread Xiang Zhang
Change by Xiang Zhang : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed type: resource usage -> versions: -Python 3.7 ___ Python tracker ___ _

[issue33904] IDLE: In rstrip, rename class RstripExtension as Rstrip

2018-06-19 Thread Srinivas Reddy T
Change by Srinivas Reddy T : -- keywords: +patch pull_requests: +7418 stage: needs patch -> patch review ___ Python tracker ___ ___

[issue30462] urllib does not support NO_PROXY environment variable containing domain with asterisk

2018-06-19 Thread Xiang Zhang
Xiang Zhang added the comment: Hi, Jiri. Could you update your PR and let's continue with this issue? -- versions: +Python 3.8 -Python 3.7 ___ Python tracker ___ _

[issue33907] IDLE: Rename calltips and CallTips as calltip and Calltip.

2018-06-19 Thread Terry J. Reedy
Terry J. Reedy added the comment: New changeset 9af1836664d241fec6e62955ffaa559b3a2eaf1b by Terry Jan Reedy in branch 'master': bpo-33907: Rename an IDLE module and classes. (GH-7810) https://github.com/python/cpython/commit/9af1836664d241fec6e62955ffaa559b3a2eaf1b -- _

[issue33907] IDLE: Rename calltips and CallTips as calltip and Calltip.

2018-06-19 Thread miss-islington
Change by miss-islington : -- pull_requests: +7419 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue33907] IDLE: Rename calltips and CallTips as calltip and Calltip.

2018-06-19 Thread miss-islington
Change by miss-islington : -- pull_requests: +7420 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue33839] IDLE tooltips.py: refactor and add docstrings and tests

2018-06-19 Thread Terry J. Reedy
Terry J. Reedy added the comment: I just merged 2nd PR for #33907. Combined effect is that module calltips and its class CallTips are now calltip and Calltip. In module calltip_w class CallTip is now CalltipWindow. -- ___ Python tracker

[issue33839] IDLE tooltips.py: refactor and add docstrings and tests

2018-06-19 Thread Tal Einat
Tal Einat added the comment: >> TclError from widget.destroy suggests that we *might* be able to cleanup >> better. > Any suggestions for a better cleanup mechanism? (Following up my own question with another question...) Would it be better to check self.winfo_exists() instead of the try/ex

[issue33839] IDLE tooltips.py: refactor and add docstrings and tests

2018-06-19 Thread Tal Einat
Tal Einat added the comment: > I [...] would like the popups to respond keyboard (Tab) focus changes as well > as mouse movement focus changes. Should tooltips also be shown automatically when the keyboard focus is on a widget? Using the same delay as for the mouse hover, perhaps? I've nev

[issue33907] IDLE: Rename calltips and CallTips as calltip and Calltip.

2018-06-19 Thread miss-islington
miss-islington added the comment: New changeset ce52f5ee0925925f5662f6b34cc637cfe6c0a46e by Miss Islington (bot) in branch '3.7': bpo-33907: Rename an IDLE module and classes. (GH-7810) https://github.com/python/cpython/commit/ce52f5ee0925925f5662f6b34cc637cfe6c0a46e -- nosy: +miss-

[issue33907] IDLE: Rename calltips and CallTips as calltip and Calltip.

2018-06-19 Thread miss-islington
miss-islington added the comment: New changeset 17d4c53fa3516f78df3c4f343bc6d2007af157cf by Miss Islington (bot) in branch '3.6': bpo-33907: Rename an IDLE module and classes. (GH-7810) https://github.com/python/cpython/commit/17d4c53fa3516f78df3c4f343bc6d2007af157cf -- ___

[issue33907] IDLE: Rename calltips and CallTips as calltip and Calltip.

2018-06-19 Thread Terry J. Reedy
Change by Terry J. Reedy : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue33906] IDLE: rename windows.py as window.py

2018-06-19 Thread Terry J. Reedy
Terry J. Reedy added the comment: Also rename idle_test.test_windows as test_window with git mv. Imports: F:\dev\3x\lib\idlelib\editor.py: 28: from idlelib import windows F:\dev\3x\lib\idlelib\idle_test\test_windows.py: 3: from idlelib import windows F:\dev\3x\lib\idlelib\macosx.py: 131:

[issue33905] IDLE: stackbrowser.Stackbrowser should accept exception.

2018-06-19 Thread Terry J. Reedy
Terry J. Reedy added the comment: Only one of tb and exc may be passed. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue33906] IDLE: rename windows.py as window.py

2018-06-19 Thread Srinivas Reddy T
Change by Srinivas Reddy T : -- keywords: +patch pull_requests: +7421 stage: needs patch -> patch review ___ Python tracker ___ ___

[issue33839] IDLE tooltips.py: refactor and add docstrings and tests

2018-06-19 Thread Tal Einat
Tal Einat added the comment: > I just merged 2nd PR for #33907. I've merged master into the PR branch for this issue and fixed the merge issues. -- ___ Python tracker ___ ___

<    1   2