[issue33863] Enum doc correction relating to __members__

2018-06-14 Thread Andrés Delfino
Andrés Delfino added the comment: IMHO, the Glossary is just a quick & dirty reference. I wouldn't search for hard definitions in there. See Built-in Types: "dictionary" is used specifically for dict. I believe we should make clear use of definitions so users known exactly what they get. I k

[issue33866] Stop using OrderedDict in enum

2018-06-14 Thread INADA Naoki
Change by INADA Naoki : -- components: Library (Lib) nosy: inada.naoki priority: normal severity: normal status: open title: Stop using OrderedDict in enum versions: Python 3.8 ___ Python tracker

[issue33866] Stop using OrderedDict in enum

2018-06-14 Thread INADA Naoki
Change by INADA Naoki : -- keywords: +patch pull_requests: +7314 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue33860] doc Avoid "ordered dictionary" references now that dictionaries are ordered

2018-06-14 Thread Andrés Delfino
Andrés Delfino added the comment: Perhaps we can continue the discussion on #33863 as there are more argumnets there, from all points of view, and when a decision is taken there, we can apply it here too. -- ___ Python tracker

[issue33863] Enum doc correction relating to __members__

2018-06-14 Thread Andrés Delfino
Andrés Delfino added the comment: To be a little more clear about this: I don't think one implements a dict-like object by reading the Glossary reference. At least, we shouldn't expect nor encourage this. -- ___ Python tracker

[issue33863] Enum doc correction relating to __members__

2018-06-14 Thread INADA Naoki
INADA Naoki added the comment: I feel "dictionary" implies "most likely dict or it's subclass" too. But I don't think "ordered dictionary" is bad wording because: * Historically, dict didn't preserve insertion order. * Dict subclass can provide other ordering. So "ordered dictionary" implie

[issue33863] Enum doc correction relating to __members__

2018-06-14 Thread Andrés Delfino
Andrés Delfino added the comment: The problem here is that while the historical issue is real, new programmers will come and they won't see a "non-ordered" dict, and having this "dictionaries" vs "ordered dictionaries" that aren't actual OrderedDict objects (which have the common name "ordere

[issue33867] Module dicts are wiped on module garbage collection

2018-06-14 Thread natedogith1
New submission from natedogith1 : When a module is garbage collected, it fills it's __dict__ with None. issue19255 and issue18214 seem to suggest that this was fixed, along with github pull request 7140 (commit 196b0925ca55bf22ffbb97733cff3e63d4fb6e18). However, this still seems to be an is

[issue33863] Enum doc correction relating to __members__

2018-06-14 Thread Andrés Delfino
Andrés Delfino added the comment: Something I forgot: we shouldn't write documentation that expects the user *not* to know that dictionaries are ordered now. It's described in What's New and in Built-in Types. That's why "ordered dictionaries" seems so wrong to me. -- ___

[issue33863] Enum doc correction relating to __members__

2018-06-14 Thread INADA Naoki
INADA Naoki added the comment: > A dictionary (treated as a synonym for dict) can't have an order different > than insertion order, because that is one of the guarantees a *dictionary* > provides. When subclassing dict and overrides `__iter__` etc., the subclass is dict (isinstance(subclass

[issue19102] Add tests for CLI of the tabnanny module

2018-06-14 Thread Jaysinh shukla
Change by Jaysinh shukla : -- pull_requests: +7315 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue19102] Add tests for CLI of the tabnanny module

2018-06-14 Thread Jaysinh shukla
Jaysinh shukla added the comment: @vstinner I have created the PR here. I wasn't sure so linked the PR with this issue. Thanks! PR URL: https://github.com/python/cpython/pull/7699 -- ___ Python tracker ___

[issue14102] argparse: add ability to create a man page

2018-06-14 Thread Pavel Raiskup
Pavel Raiskup added the comment: On Friday, June 15, 2018 1:52:41 AM CEST Ben Finney wrote: > On Thu, 2018-06-14 23:46 +, Aaron Meurer wrote: > > Couldn't such a tool exist outside the standard library. > > I've tried writing such a tool. It would ideally re-use as much as feasible of > th

[issue32839] Add after_info as a function to tkinter

2018-06-14 Thread Terry J. Reedy
Terry J. Reedy added the comment: Real use case for after_info() (with not arg): #33855 is about minimally testing all IDLE modules. At least import the module and create class instances when easily possible. For test_editor, I started with def test_init(self): # Temporary. e

[issue33866] Stop using OrderedDict in enum

2018-06-14 Thread Ethan Furman
Change by Ethan Furman : -- assignee: -> ethan.furman nosy: +barry, eli.bendersky, ethan.furman ___ Python tracker ___ ___ Python-b

[issue33860] doc Avoid "ordered dictionary" references now that dictionaries are ordered

2018-06-14 Thread Ethan Furman
Ethan Furman added the comment: As I said on the PR: This feels like an unnecessary change. The phrase "ordered dictionary" does not always refer to an 'OrderedDict`, and there is more than one way to order a dictionary besides insertion order. As a side note: it's generally better to have

<    1   2