[issue31764] sqlite3.Cursor.close() crashes in case the Cursor object is uninitialized

2017-11-06 Thread STINNER Victor
STINNER Victor added the comment: New changeset edb13ae48c17210fa4b2d40a6833ca09db5c121b by Victor Stinner (Oren Milman) in branch 'master': bpo-31764: Prevent a crash in sqlite3.Cursor.close() in case the Cursor object is uninitialized (#3958) https://github.com/python/cpython/commit/edb13ae

[issue31764] sqlite3.Cursor.close() crashes in case the Cursor object is uninitialized

2017-11-06 Thread Roundup Robot
Change by Roundup Robot : -- pull_requests: +4266 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue31764] sqlite3.Cursor.close() crashes in case the Cursor object is uninitialized

2017-11-06 Thread STINNER Victor
STINNER Victor added the comment: @Oren: The 2.7 backport is not straighforward. Would you mind to backport the fix to 2.7, please? -- ___ Python tracker ___ _

[issue31271] an assertion failure in io.TextIOWrapper.write

2017-11-06 Thread STINNER Victor
STINNER Victor added the comment: New changeset 30537698b607d53fa9ce18522abb88469d5814b6 by Victor Stinner (Oren Milman) in branch '2.7': [2.7] bpo-31271: Fix an assertion failure in io.TextIOWrapper.write. (GH-3201) (#3951) https://github.com/python/cpython/commit/30537698b607d53fa9ce18522ab

[issue31271] an assertion failure in io.TextIOWrapper.write

2017-11-06 Thread STINNER Victor
STINNER Victor added the comment: Serhiy: "You are right. But in any case the test should be fixed for 2.7." Done: I merged Oren's PR 3951. It seems like the bug was fixed in all (maintained) branches, so I close the issue. Thank you again Oren Milman for *reporting* and *fixing* the bug! -

[issue31940] copystat on symlinks fails for alpine -- faulty lchmod implementation?

2017-11-06 Thread STINNER Victor
STINNER Victor added the comment: If lchmod() fails with [Errno 95] Not supported, IMHO chmod(path, mode, follow_symlinks=False) should behaves as lchmod() doesn't exist and falls back to the next case, as if HAVE_LCHMOD wasn't defined, but implement such falls back at runtime. So the "broke

[issue31770] crash and refleaks when calling sqlite3.Cursor.__init__() more than once

2017-11-06 Thread STINNER Victor
STINNER Victor added the comment: New changeset 9684cf69e32ae442c7be54521073ac78557f3bbf by Victor Stinner (Miss Islington (bot)) in branch '3.6': bpo-31770: Prevent a crash and refleaks when calling sqlite3.Cursor.__init__() more than once (GH-3968) (#4301) https://github.com/python/cpython/

[issue31770] crash and refleaks when calling sqlite3.Cursor.__init__() more than once

2017-11-06 Thread STINNER Victor
STINNER Victor added the comment: Thank you Oren Milman for your bug report and the bug fix! I merged your PR and backported it Python 3.6 and 2.7. -- versions: +Python 2.7, Python 3.6 ___ Python tracker ___

[issue31764] sqlite3.Cursor.close() crashes in case the Cursor object is uninitialized

2017-11-06 Thread STINNER Victor
Change by STINNER Victor : -- versions: +Python 2.7, Python 3.6 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue31770] crash and refleaks when calling sqlite3.Cursor.__init__() more than once

2017-11-06 Thread STINNER Victor
STINNER Victor added the comment: New changeset 4b544aadd54fd2337d2ab5c137389cae8d1fd781 by Victor Stinner (Miss Islington (bot)) in branch '2.7': bpo-31770: Prevent a crash and refleaks when calling sqlite3.Cursor.__init__() more than once (GH-3968) (#4302) https://github.com/python/cpython/

[issue31843] sqlite3.connect() should accept PathLike objects

2017-11-06 Thread STINNER Victor
STINNER Victor added the comment: New changeset a22a127458d75b9b7e65e058f5db5ff705df5696 by Victor Stinner (Anders Lorentsen) in branch 'master': bpo-31843: sqlite3.connect() now accepts PathLike objects as database name (#4299) https://github.com/python/cpython/commit/a22a127458d75b9b7e65e05

[issue31764] sqlite3.Cursor.close() crashes in case the Cursor object is uninitialized

2017-11-06 Thread STINNER Victor
STINNER Victor added the comment: New changeset b0331c94c2a210d50e43d99b249ec83ee165e70c by Victor Stinner (Miss Islington (bot)) in branch '3.6': bpo-31764: Prevent a crash in sqlite3.Cursor.close() in case the Cursor object is uninitialized (GH-3958) (#4303) https://github.com/python/cpytho

[issue31843] sqlite3.connect() should accept PathLike objects

2017-11-06 Thread STINNER Victor
STINNER Victor added the comment: Thank you Allen Li for your feature request. Thank you very much Anders Lorentsen for addressing all my annoying comments on the pull request, and congratulations for your first contribution to CPython! It's a nice once ;-) -- resolution: -> fixed s

[issue31770] crash and refleaks when calling sqlite3.Cursor.__init__() more than once

2017-11-06 Thread STINNER Victor
Change by STINNER Victor : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue27666] "stack smashing detected" in PyCursesWindow_Box

2017-11-06 Thread STINNER Victor
STINNER Victor added the comment: The Python 2.7 backport (commit b694770a2b23cd485c98bf673a8b2dc1a865d9df) is wrong. The _curses module cannot be compiled anymore: Example of compilation errors: /home/haypo/prog/python/2.7/Modules/_cursesmodule.c: In function 'PyCursesWindow_Box': /home/hay

[issue31964] [3.4][3.5] pyexpat: compilaton of libexpat fails with: ISO C90 forbids mixed declarations and code

2017-11-06 Thread STINNER Victor
New submission from STINNER Victor : /home/haypo/prog/python/3.5/Modules/expat/xmltok.c: In function 'utf8_toUtf8': /home/haypo/prog/python/3.5/Modules/expat/xmltok.c:408:3: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement] const char * const fromLimBefo

[issue31964] [3.4][3.5] pyexpat: compilaton of libexpat fails with: ISO C90 forbids mixed declarations and code

2017-11-06 Thread STINNER Victor
STINNER Victor added the comment: Python 3.6 is not affected since it uses ISO C99 which allows "mixed declarations and code". Python 2.7 is not affected since it doesn't use -Werror=declaration-after-statement. -- ___ Python tracker

[issue31963] AMD64 Debian PGO 3.x buildbot: compilation failed with an internal compiler error in create_edge

2017-11-06 Thread Gregory P. Smith
Gregory P. Smith added the comment: On Mon, Nov 6, 2017 at 3:11 PM Neil Schemenauer wrote: > > Neil Schemenauer added the comment: > > Hi Victor, > > My first guess is that the build bot is not cleaning the fprofile > information after updating the source tree. A few options: > But it is.

[issue31963] AMD64 Debian PGO 3.x buildbot: compilation failed with an internal compiler error in create_edge

2017-11-06 Thread Neil Schemenauer
Neil Schemenauer added the comment: Oh I see. I'm at a loss then as to why the build is failing. A possible clue is the errors like: profiling:/var/lib/buildbot/slaves/enable-optimizations-bot/3.x.gps-debian-profile-opt.nondebug/build/Objects/setobject.gcda:Merge mismatch for function 10 A

[issue28791] update sqlite to latest version before beta 1

2017-11-06 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: New changeset 31af650ee25f65794b75d4dfefed6fe4758781c1 by Mariatta in branch 'master': bpo-28791: Update Windows builds to use SQLite 3.21.0. (GH-4246) https://github.com/python/cpython/commit/31af650ee25f65794b75d4dfefed6fe4758781c1 -- ___

[issue31961] subprocess._execute_child doesn't accept a single PathLike argument for args

2017-11-06 Thread Anders Lorentsen
Anders Lorentsen added the comment: I was able to make a test that reproduces your code, and expectedly fails. Also implemented a fix for it. See a temporary diff here: https://pastebin.com/C9JWkg0i However, there is also a specific MS Windows version of _execute_child() (a phrase only compu

[issue31950] Default event loop policy doc lacks precision

2017-11-06 Thread Guido van Rossum
Guido van Rossum added the comment: Agreed that this needs more clarification. Is something stopping you from submitting a PR? Note that the thing about non-main-threads is mentioned in the docstring for BaseDefaultEventLoopPolicy. I agree that the best way to create a new policy is to study

[issue31415] Add -X option to show import time

2017-11-06 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 088929cf62fa22c06f6a44e25915abce9048a545 by Serhiy Storchaka in branch 'master': bpo-31415: Improve error handling and caching of the importtime option. (#4138) https://github.com/python/cpython/commit/088929cf62fa22c06f6a44e25915abce9048a545

[issue31965] Incorrect documentation for multiprocessing.connection.{Client, Listener}

2017-11-06 Thread Jelle Zijlstra
New submission from Jelle Zijlstra : https://docs.python.org/3/library/multiprocessing.html#multiprocessing.connection.Client claims that there is an "authenticate" argument, but it does not exist in the implementation (https://github.com/python/cpython/blob/master/Lib/multiprocessing/connecti

[issue27666] "stack smashing detected" in PyCursesWindow_Box

2017-11-06 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- pull_requests: +4268 stage: resolved -> patch review ___ Python tracker ___ ___ Python-bugs-list mail

[issue21862] cProfile command-line should accept "-m module_name" as an alternative to script path

2017-11-06 Thread Nick Coghlan
Nick Coghlan added the comment: Interesting - I'd never looked at how cProfile works before, and the fact it already doesn't support the "-i" (interactive) switch makes it much simpler to handle than the pdb case. So from a runpy perspective, this approach gets a +1 from me, but I'd prefer if

[issue9325] Add an option to pdb/trace/profile to run library module as a script

2017-11-06 Thread Nick Coghlan
Nick Coghlan added the comment: Issue 21862 is a related issue specifically for the cProfile module. In that case, cProfile's command line invocation *doesn't* use the main module, so the patch is able to just create a synthetic call to runpy.run_module as a string and compile that as the cod

[issue31954] Don't prevent dict optimization by coupling with OrderedDict

2017-11-06 Thread INADA Naoki
INADA Naoki added the comment: Quick microbench: ``` $ ./python -m perf timeit --compare-to=`pwd`/python.master -s 'd = dict.fromkeys(range(1000))' -- "for i in range(1000): del d[i] d[i]=i " python.master: . 124 us +- 9 us python: . 116 us +- 0 us

[issue27666] "stack smashing detected" in PyCursesWindow_Box

2017-11-06 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 69ea4b4deb123c9a3c986b7afb85183732784f4f by Serhiy Storchaka in branch '2.7': Fix bpo-27666 backporting error in _cursesmodule.c (#4305) https://github.com/python/cpython/commit/69ea4b4deb123c9a3c986b7afb85183732784f4f -- resolution:

[issue27666] "stack smashing detected" in PyCursesWindow_Box

2017-11-06 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you for catching this Victor. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue19982] Add a "target" parameter to runpy.run_path and runpy.run_module

2017-11-06 Thread Nick Coghlan
Nick Coghlan added the comment: See issue 21862 and issue 9325 as potential use cases for this feature. While it looks like issue 21862 (-m switch support in cProfile) can be implemented just fine without it, this feature will be needed for the modules that execute the given scripts directly

[issue19982] Add a "target" parameter to runpy.run_path and runpy.run_module

2017-11-06 Thread Nick Coghlan
Change by Nick Coghlan : -- versions: +Python 3.7 -Python 3.5 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

<    1   2