[issue30891] importlib: _find_and_load() race condition on sys.modules[name] check

Łukasz Langa added the comment: If you're looking at this issue because it still happens to you, you are probably using zipimport. Stop using zipimport. -- nosy: +lukasz.langa ___ Python tracker _

[issue31455] ElementTree.XMLParser() mishandles exceptions

Stefan Behnel added the comment: Feel free to provide a separate pull request. These issues seem independent of the exception handling problem that I wrote a fix for. -- ___ Python tracker ___

[issue28556] typing.py upgrades

Changes by Ivan Levkivskyi : -- keywords: +patch pull_requests: +3543 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-

[issue31336] Speed up _PyType_Lookup() for class creation

Stefan Behnel added the comment: > Is it correct to call _PyType_Lookup() with an exception set? The general rule of thumb is that it's not safe to call any user code with a live exception set, and lookups can call into user code. I quickly looked through all occurrences (there aren't that man

[issue31353] Implement PEP 553 - built-in debug()

Dawid Gosławski added the comment: Will that be backported also to Python2.7 ? I personally do not see a reason to teach old dog new tricks but it seems appropriate in such core things. New users could transition easier, otherwise this would be next py2<->py3 difference to explain every time s

[issue31353] Implement PEP 553 - built-in debug()

R. David Murray added the comment: It is a new feature, so no it would not be backported. -- nosy: +r.david.murray type: -> enhancement ___ Python tracker ___ _

[issue31457] LoggerAdapter

New submission from Łukasz Langa: LoggerAdapter objects cannot be nested in Python 3 due to their `log()` and `isEnabledFor()` methods addressing attributes that are not present on the proxy. Adding the missing attributes fixes the issue. -- assignee: lukasz.langa messages: 302111 nos

[issue31457] LoggerAdapter objects cannot be nested

Changes by Łukasz Langa : -- title: LoggerAdapter -> LoggerAdapter objects cannot be nested ___ Python tracker ___ ___ Python-bugs-li

[issue31457] LoggerAdapter objects cannot be nested

Changes by Łukasz Langa : -- keywords: +patch pull_requests: +3544 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue31457] LoggerAdapter objects cannot be nested

Changes by Łukasz Langa : -- versions: +Python 3.6, Python 3.7 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue31234] Make support.threading_cleanup() stricter

STINNER Victor added the comment: New changeset ace1ecc00b35a8b1dc6e352d547dde07913017bb by Victor Stinner in branch 'master': bpo-31234: threading_cleanup() now warns immediately (#3138) https://github.com/python/cpython/commit/ace1ecc00b35a8b1dc6e352d547dde07913017bb -- ___

[issue31234] Make support.threading_cleanup() stricter

Changes by Roundup Robot : -- pull_requests: +3545 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue19985] Not so correct error message when initializing Struct with ill argument

Martin Panter added the comment: For Python 2.7, this change doesn’t seem important enough for a bug fix. -- ___ Python tracker ___ _

[issue31234] Make support.threading_cleanup() stricter

Changes by STINNER Victor : -- pull_requests: +3546 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue31424] test_socket hangs on x86 Gentoo Installed with X 3.x

STINNER Victor added the comment: Hum, the test passed the following 17 builds. -- ___ Python tracker ___ ___ Python-bugs-list mailin

[issue31323] test_ssl: reference cycle between ThreadedEchoServer and its ConnectionHandler

Changes by STINNER Victor : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue31234] Make support.threading_cleanup() stricter

STINNER Victor added the comment: Hum, test_barrier of test_thread failed: http://buildbot.python.org/all/builders/AMD64%20FreeBSD%2010.x%20Shared%203.x/builds/880/steps/test/logs/stdio 0:02:09 load avg: 2.50 [106/405/1] test_thread failed (env changed) -- running: test_multiprocessing_spawn (

[issue30246] fix several error messages in struct

Martin Panter added the comment: FWIW a similar change to the Struct constructor message was also proposed in Issue 19985. -- ___ Python tracker ___ ___

[issue31458] Broken link to Misc/NEWS in What's New page

New submission from Mariatta Wijaya: In "What's new in Python" page: (https://docs.python.org/3.7/whatsnew/index.html) The link to Misc/NEWS is 404. The text is: The “Changelog” is a HTML version of the file Misc/NEWS which contains all nontrivial changes to Python for the current version.

[issue31458] Broken link to Misc/NEWS in What's New page

Changes by Mariatta Wijaya : -- versions: +Python 3.6, Python 3.7 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue31459] IDLE: Remane Class Browser as Module Browser

New submission from Terry J. Reedy: 'ClassBrowser' expanded to a module browser years ago. Change the name in the menu, multiple places in browser.py, and wherever the class is referenced. If one clicks the menu entry while not editing a Python file, an Open Module entry box is displayed. Ot

[issue31458] Broken link to Misc/NEWS in What's New page

Changes by Mariatta Wijaya : -- keywords: +patch pull_requests: +3547 stage: needs patch -> patch review ___ Python tracker ___ ___ P

[issue31460] IDLE: Revise ModuleBrowser API

New submission from Terry J. Reedy: The signature of browser.ClassBrowser(to be renamed ModuleBrowser).__init__ is def __init__(self, flist, name, path, _htest=False, _utest=False) flist is only used to access the application root. Change it to master. Then text can directly pass the test ro

[issue31447] proc communicate not exiting on python subprocess timeout using PIPES

Martin Panter added the comment: . Isn’t your use of “cmd” similar enough to shell=True? I.e. isn’t that a “cmd” parent process spawning a “waitfor” child? If your 4 s “subprocess.run” call times out, does it kill the “waitfor” process, or leave it running? Could the “waitfor” process write to

[issue31234] Make support.threading_cleanup() stricter

STINNER Victor added the comment: Source_ModuleLockAsRLockTests.test_different_thread() of test.test_importlib.test_locks failed: http://buildbot.python.org/all/builders/x86-64%20El%20Capitan%203.x/builds/758/steps/test/logs/stdio test_different_thread (test.test_importlib.test_locks.Source_M

[issue31461] IDLE: Enhance class browser

New submission from Terry J. Reedy: This is an index issue for keeping track of improvements to IDLE's class browser. They should mostly (or all?) be done in separate issues and PRs. Existing issues with patches. Only the first, a 'must', is recently reviewed. #1612262 Use 3.7 enhanced pyc

[issue30891] importlib: _find_and_load() race condition on sys.modules[name] check

STINNER Victor added the comment: Łukasz Langa: "If you're looking at this issue because it still happens to you, you are probably using zipimport. Stop using zipimport." Hum, do you mean that zipimport also has an issue? Maybe open a new issue? --

[issue31461] IDLE: Enhance class browser

Changes by Terry J. Reedy : -- dependencies: +Class Browser doesn't show internal classes, IDLE: Remane Class Browser as Module Browser, IDLE: Revise ModuleBrowser API ___ Python tracker _

[issue30442] Skip test_xml_etree under coverage

STINNER Victor added the comment: New changeset 860839cc8e0a4a0890418f77c984955697f96828 by Victor Stinner (Miss Islington (bot)) in branch '2.7': [2.7] bpo-30442: Skips refcount test in test_xml_etree under coverage (GH-1767) (#3549) https://github.com/python/cpython/commit/860839cc8e0a4a0890

[issue31418] assertion failure in PyErr_WriteUnraisable() in case of an exception with a bad __module__

Changes by Serhiy Storchaka : -- versions: +Python 3.6 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue31418] assertion failure in PyErr_WriteUnraisable() in case of an exception with a bad __module__

Serhiy Storchaka added the comment: New changeset f6e61df01536493f1280cd07639c7ff9bffb2cdc by Serhiy Storchaka (Oren Milman) in branch 'master': bpo-31418: Fix an assertion failure in PyErr_WriteUnraisable() in case of an exception with a bad __module__ attribute. (#3539) https://github.com/py

[issue31418] assertion failure in PyErr_WriteUnraisable() in case of an exception with a bad __module__

Changes by Roundup Robot : -- pull_requests: +3548 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue28411] Eliminate PyInterpreterState.modules.

Eric Snow added the comment: FYI, this broke some (very) corner cases. See issue #31404. -- ___ Python tracker ___ ___ Python-bugs-l

[issue31234] Make support.threading_cleanup() stricter

STINNER Victor added the comment: New changeset d99e85b9f6422dd5e4f2eb1539368fc4003d4c8b by Victor Stinner (Miss Islington (bot)) in branch '3.6': [3.6] bpo-31234, socket.create_connection(): Fix ref cycle (GH-3546) (#3552) https://github.com/python/cpython/commit/d99e85b9f6422dd5e4f2eb1539368f

[issue31234] Make support.threading_cleanup() stricter

STINNER Victor added the comment: New changeset ef323e8d82b07d4e7e4303c360dc32d3de0b3147 by Victor Stinner in branch '3.6': [3.6] bpo-31234: Fix dangling thread in test_ftp/poplib (#3554) https://github.com/python/cpython/commit/ef323e8d82b07d4e7e4303c360dc32d3de0b3147 -- ___

[issue31234] Make support.threading_cleanup() stricter

Changes by STINNER Victor : -- pull_requests: +3549 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue31447] proc communicate not exiting on python subprocess timeout using PIPES

Eryk Sun added the comment: > the process terminates, but "communicate" doesn't exit. It doesn't > say "communicate will hang as long as the pipes are open". I think the problem with leaked handles does warrant a note. It can be a difficult problem to diagnose otherwise. If communicate() rais

[issue28556] typing.py upgrades

Łukasz Langa added the comment: New changeset 65bc62052fe5d550cb14c0033e8a2550618fb7b9 by Łukasz Langa (Ivan Levkivskyi) in branch 'master': bpo-28556: Minor updates to typing module (#3550) https://github.com/python/cpython/commit/65bc62052fe5d550cb14c0033e8a2550618fb7b9 -- nosy: +lu

[issue28556] typing.py upgrades

Changes by Roundup Robot : -- pull_requests: +3550 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue31234] Make support.threading_cleanup() stricter

STINNER Victor added the comment: New changeset 096ae3373abac2c8b3a26a3fe33cc8bd4cbccd4e by Victor Stinner in branch 'master': bpo-31234: Try to fix lock_tests warning (#3557) https://github.com/python/cpython/commit/096ae3373abac2c8b3a26a3fe33cc8bd4cbccd4e -- ___

[issue31458] Broken link to Misc/NEWS in What's New page

Mariatta Wijaya added the comment: New changeset 1b8f612e1800b6e58472113f4abe8ee7c31f4db7 by Mariatta in branch 'master': bpo-31458: Update Misc/NEWS link in What's New page (GH-3555) https://github.com/python/cpython/commit/1b8f612e1800b6e58472113f4abe8ee7c31f4db7 -- ___

[issue28556] typing.py upgrades

Łukasz Langa added the comment: New changeset 9e3cd78ec18b2d2078d30b04307916acd68be37a by Łukasz Langa (Miss Islington (bot)) in branch '3.6': [3.6] bpo-28556: Minor updates to typing module (GH-3550) (#3558) https://github.com/python/cpython/commit/9e3cd78ec18b2d2078d30b04307916acd68be37a --

[issue31438] IDLE 3 crashes and quits when caret character typed

Terry J. Reedy added the comment: Ned, is 3.6.2 tkinter on Mac supposed to work with tcl/tk 8.6.6? -- ___ Python tracker ___ ___ Pyth

[issue31461] IDLE: Enhance class browser

Changes by Terry J. Reedy : -- nosy: +csabella ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue31458] Broken link to Misc/NEWS in What's New page

Changes by Mariatta Wijaya : -- pull_requests: +3551 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue31438] IDLE 3 crashes and quits when caret character typed

Terry J. Reedy added the comment: If your installed Python with the 64/32 Mac installer from python.org, follow the instruction, on the link given, to install Active 8.5.18 and *not* 8.6. I believe the issue is that the _tkinter binary is compiled to work with 8.5, not 8.6. If you used any o

[issue30246] fix several error messages in struct

Xiang Zhang added the comment: New changeset c3e97d9d984130d1c2aceedc4dfcd603b3162688 by Xiang Zhang in branch 'master': bpo-30246: fix several error messages which only mention bytes in struct (#1421) https://github.com/python/cpython/commit/c3e97d9d984130d1c2aceedc4dfcd603b3162688 -

[issue31458] Broken link to Misc/NEWS in What's New page

Mariatta Wijaya added the comment: New changeset 905e4ef86e86dbf8f28b2f6e45af31a6eea84e10 by Mariatta in branch '3.6': [3.6] bpo-31458: Update Misc/NEWS link in What's New page (GH-3555) (GH-3560) https://github.com/python/cpython/commit/905e4ef86e86dbf8f28b2f6e45af31a6eea84e10 -- __

[issue31458] Broken link to Misc/NEWS in What's New page

Changes by Mariatta Wijaya : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue30246] fix several error messages in struct

Changes by Xiang Zhang : -- keywords: +patch pull_requests: +3552 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue30246] fix several error messages in struct

Xiang Zhang added the comment: New changeset fa82dda1012b406a7091587fc65384ce11528346 by Xiang Zhang in branch '3.6': [3.6] bpo-30246: fix several error messages which only mention bytes in struct (#3561) https://github.com/python/cpython/commit/fa82dda1012b406a7091587fc65384ce11528346 -

[issue30246] fix several error messages in struct

Changes by Xiang Zhang : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 3.5 ___ Python tracker ___ __

[issue19985] Not so correct error message when initializing Struct with ill argument

Changes by Xiang Zhang : -- dependencies: +fix several error messages in struct -Document whether it's safe to use bytes for struct format string resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker

[issue19985] Not so correct error message when initializing Struct with ill argument

Changes by Xiang Zhang : -- versions: +Python 3.6, Python 3.7 -Python 3.3, Python 3.4 ___ Python tracker ___ ___ Python-bugs-list mai

[issue31462] Remove trailing whitespaces

New submission from Serhiy Storchaka: Proposed PR removes trailing whitespaces from CPython source files. Some of them were added since the last trailing whitespaces removing. Some text files were omitted in previous trailing whitespaces removings. Now I consider them safe to cleanup. ---

[issue31462] Remove trailing whitespaces

Changes by Serhiy Storchaka : -- keywords: +patch pull_requests: +3553 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue31404] undefined behavior and crashes in case of a bad sys.modules

Changes by Eric Snow : -- keywords: +patch pull_requests: +3554 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list m

[issue28411] Eliminate PyInterpreterState.modules.

Changes by Eric Snow : -- pull_requests: +3555 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue28411] Eliminate PyInterpreterState.modules.

Eric Snow added the comment: We're reverting this (see #31404), so back to the drawing board... -- resolution: fixed -> stage: resolved -> needs patch status: closed -> open ___ Python tracker ___

[issue31441] Descriptor example in documentation is confusing, possibly wrong

Raymond Hettinger added the comment: The example should be modernized to show-off the new __set_name__() part of the descriptor protocol. Computing the name on-demand is better that relying an optional user entered alternate name and having to store that name for future reference. --

[issue31462] Remove trailing whitespaces

Serhiy Storchaka added the comment: New changeset 13ad3b7a82bf56d803fbe48ee5df6c4b08986c78 by Serhiy Storchaka in branch 'master': bpo-31462: Remove trailing whitespaces. (#3564) https://github.com/python/cpython/commit/13ad3b7a82bf56d803fbe48ee5df6c4b08986c78 --

[issue31418] assertion failure in PyErr_WriteUnraisable() in case of an exception with a bad __module__

Serhiy Storchaka added the comment: New changeset 5dbb28ececdd0382d85b164aaf37bec1ae08036c by Serhiy Storchaka (Miss Islington (bot)) in branch '3.6': [3.6] bpo-31418: Fix an assertion failure in PyErr_WriteUnraisable() in case of an exception with a bad __module__ attribute. (GH-3539) (#3556)

[issue31447] proc communicate not exiting on python subprocess timeout using PIPES

Leonardo Francalanci added the comment: I have a workaround, and I guess this means there's a bug in the current implementation of stdout/stderr=subprocess.PIPE; if I open my own pipes instead of using subprocess.PIPE everything seems to work (provided I close the pipe before reading from it):

[issue31462] Remove trailing whitespaces

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue31463] test_multiprocessing_fork hangs test_subprocess

New submission from Benjamin Peterson: This hangs reliably for me on master: $ ./python -m test.regrtest test_multiprocessing_fork test_subprocess It looks like test_multiprocessing_fork doesn't clean up some of its subprocesses and then test_subprocess hangs on waitpid(0) forever. --

[issue31418] assertion failure in PyErr_WriteUnraisable() in case of an exception with a bad __module__

Changes by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue31404] undefined behavior and crashes in case of a bad sys.modules

Eric Snow added the comment: New changeset 93c92f7d1dbb6e7e472f1d0444c6968858113de2 by Eric Snow in branch 'master': bpo-31404: Revert "remove modules from Py_InterpreterState (#1638)" (#3565) https://github.com/python/cpython/commit/93c92f7d1dbb6e7e472f1d0444c6968858113de2 -- __

[issue28411] Eliminate PyInterpreterState.modules.

Eric Snow added the comment: New changeset 93c92f7d1dbb6e7e472f1d0444c6968858113de2 by Eric Snow in branch 'master': bpo-31404: Revert "remove modules from Py_InterpreterState (#1638)" (#3565) https://github.com/python/cpython/commit/93c92f7d1dbb6e7e472f1d0444c6968858113de2 -- __

<    1   2