[issue19903] Idle: Use inspect.signature for calltips

2017-05-02 Thread Louie Lu
Louie Lu added the comment: ah, there are still some corner case about _first_param.sub(), some of them in signature will be like `(ci)`, not `(self, ci)`, and the regex will replace the first params to `()`, which is not correct. -- ___ Python trac

[issue28315] incorrect "in ?" output in 'divide' example at "Defining Clean-up Actions" in tutorial

2017-05-02 Thread Jaysinh shukla
Changes by Jaysinh shukla : -- pull_requests: +1480 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30223] Add Lib/test/__main__.py in 2.7

2017-05-02 Thread STINNER Victor
STINNER Victor added the comment: Oh yes, I always wanted this tiny feature! It's painful to have to adapt my command for Python 2 after testing Python 3. -- nosy: +haypo ___ Python tracker ___

[issue30223] Add Lib/test/__main__.py in 2.7

2017-05-02 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- pull_requests: +1481 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue30223] Add Lib/test/__main__.py in 2.7

2017-05-02 Thread Xiang Zhang
Xiang Zhang added the comment: +1. Every time when I want to run tests for 2.7, I have to type twice. Once python -m test, error and then python -m test.regrtest. -- nosy: +xiang.zhang ___ Python tracker _

[issue30224] remove outdated checks in struct

2017-05-02 Thread Xiang Zhang
New submission from Xiang Zhang: Reading struct's code I find some checks seem outdated. They seemly exists because there are two kinds of integer in 2.x. I wrote a patch to remove them but maybe they exist for other reasons I don't see. Sorry if I misunderstand them. :-( -- component

[issue30224] remove outdated checks in struct

2017-05-02 Thread Xiang Zhang
Changes by Xiang Zhang : -- pull_requests: +1482 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue15987] Provide a way to compare AST nodes for equality recursively

2017-05-02 Thread Louie Lu
Changes by Louie Lu : -- pull_requests: +1483 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue30225] EBADF error on x86 Tiger 3.x buildbot

2017-05-02 Thread STINNER Victor
New submission from STINNER Victor: test_http_body_pipe() of test_urllib2 uses a subprocess, no idea if it's related: cmd = [sys.executable, "-c", r"pass"] for headers in {}, {"Content-Length": 30}: with subprocess.Popen(cmd, stdout=subprocess.PIPE) as proc:

[issue30104] clang 4.0 miscompiles dtoa.c, giving broken float parsing and printing

2017-05-02 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +1484 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue29943] PySlice_GetIndicesEx change broke ABI in 3.5 and 3.6 branches

2017-05-02 Thread Charalampos Stratakis
Charalampos Stratakis added the comment: For what it's worth, in Fedora 26 we already rebased Python to 3.6.1, so this issue now is non existent for our ecosystem, and we are not shipping 3.6.0 in any way now. -- ___ Python tracker

[issue29943] PySlice_GetIndicesEx change broke ABI in 3.5 and 3.6 branches

2017-05-02 Thread Miro Hrončok
Miro Hrončok added the comment: > For what it's worth, in Fedora 26 we already rebased Python to 3.6.1, so this > issue now is non existent for our ecosystem, and we are not shipping 3.6.0 in > any way now. Except of course if 3.6.2 would be fixed in a way that 3.6.1 would be considered broke

[issue30104] clang 4.0 miscompiles dtoa.c, giving broken float parsing and printing

2017-05-02 Thread STINNER Victor
STINNER Victor added the comment: New changeset 809101f14f27ddb394cd77c477470761ecf99f41 by Victor Stinner in branch '3.6': bpo-30104: Use -fno-strict-aliasing on clang (#1376) https://github.com/python/cpython/commit/809101f14f27ddb394cd77c477470761ecf99f41 -- __

[issue30226] Modernize make_ssl_certs

2017-05-02 Thread Christian Heimes
New submission from Christian Heimes: Lib/test/make_ssl_certs.py is used to generate and re-generate certificates and keys for SSL tests. The script and certificates have various smaller issues, e.g. RSA 1024bit certs with SHA-1 signature. Some certificates lack v3 extensions, too. The script

[issue30104] clang 4.0 miscompiles dtoa.c, giving broken float parsing and printing

2017-05-02 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +1485 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30104] clang 4.0 miscompiles dtoa.c, giving broken float parsing and printing

2017-05-02 Thread STINNER Victor
STINNER Victor added the comment: New changeset 03a7ab77d2f75323e1f3e8b6a1c164e701d58bfb by Victor Stinner in branch '3.5': bpo-30104: Use -fno-strict-aliasing on clang (#1376) (#1377) https://github.com/python/cpython/commit/03a7ab77d2f75323e1f3e8b6a1c164e701d58bfb -- __

[issue30108] test_site modifies sys.path

2017-05-02 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +1486 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30108] test_site modifies sys.path

2017-05-02 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +1487 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30212] test_ssl.py is broken in Centos7

2017-05-02 Thread Xiang Zhang
Xiang Zhang added the comment: The failure can't be reproduced by me, 3.5 on CentOS 7.1. -- ___ Python tracker ___ ___ Python-bugs-lis

[issue7283] test_site failure when .local/lib/pythonX.Y/site-packages hasn't been created yet

2017-05-02 Thread STINNER Victor
STINNER Victor added the comment: It seems like the original bug report was fixed, so I close it. @Berker Peksag: Please open a new bug report if you see again the PermissionError error on Windows. I didn't see it recently. > Well, I'm not sure the symlink is actually the problem. Apparently

[issue30108] test_site modifies sys.path

2017-05-02 Thread STINNER Victor
STINNER Victor added the comment: New changeset 33a5d40de997fff5b60157c546a3bf711e083bcc by Victor Stinner in branch '3.6': bpo-30108: Restore sys.path in test_site (#1197) (#1378) https://github.com/python/cpython/commit/33a5d40de997fff5b60157c546a3bf711e083bcc -- __

[issue30108] test_site modifies sys.path

2017-05-02 Thread STINNER Victor
STINNER Victor added the comment: New changeset 092f4602c329e23b863692249cc630a3eba5b6b5 by Victor Stinner in branch '3.5': bpo-30108: Restore sys.path in test_site (#1197) (#1379) https://github.com/python/cpython/commit/092f4602c329e23b863692249cc630a3eba5b6b5 -- __

[issue30223] Add Lib/test/__main__.py in 2.7

2017-05-02 Thread Nick Coghlan
Nick Coghlan added the comment: +1 from me. We hadn't done this (or the test.support backport) previously due to the "no new features" guideline, but I think simplifying cross-branch maintenance overrides that concerns. -- ___ Python tracker

[issue30212] test_ssl.py is broken in Centos7

2017-05-02 Thread STINNER Victor
STINNER Victor added the comment: @david-cpi: Can you please elaborate? * What is your Centos full version? * How do you get Python 3.5? Tarball from python.org? * What is the error message? "except: pass" is bad practice, you must catch a specific exception type. It seems very strange to have

[issue30212] test_ssl.py is broken in Centos7

2017-05-02 Thread STINNER Victor
STINNER Victor added the comment: Oh, I missed the attached test.log file. So, it's CentOS 7.3.1611 and the full error message is: == CPython 3.5.2 (default, Apr 29 2017, 16:07:16) [GCC 4.8.5 20150623 (Red Hat 4.8.5-11)] == Linux-3.10.0-514.16.1.el7.x86_64-x86_64-with-centos-7.3.1611-Core l

[issue30212] test_ssl.py is broken in Centos7

2017-05-02 Thread STINNER Victor
STINNER Victor added the comment: David: can you please check if you get the same error with Python 3.6, or even the development version (Git master branch)? -- ___ Python tracker _

[issue30227] test_site must not write outside the build directory: must not write into $HOME/.local/

2017-05-02 Thread STINNER Victor
New submission from STINNER Victor: test_site creates the $HOME/.local/lib/python3.7/site-packages/ directory, or parent directories if needed. That's wrong. An unit test must not modify its environment, especially the home directory! The unit test must mock $HOME environment variable and mock

[issue30132] [Windows] test_distutils leaks a vc140.pdb file

2017-05-02 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +1488 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30199] Warning -- asyncore.socket_map was modified by test_ssl

2017-05-02 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +1489 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30132] [Windows] test_distutils leaks a vc140.pdb file

2017-05-02 Thread STINNER Victor
STINNER Victor added the comment: I'm unable to run test_distutils on Windows using python_d.exe: I get link error 1101. LINK : fatal error LNK1101: incorrect MSPDB140.DLL version; recheck installation of this product I ran manually the following command, but it didn't help: "%VS140COMNTO

[issue19903] Idle: Use inspect.signature for calltips

2017-05-02 Thread Louie Lu
Changes by Louie Lu : -- pull_requests: +1490 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue19903] Idle: Use inspect.signature for calltips

2017-05-02 Thread Louie Lu
Louie Lu added the comment: @Terry, the PR is created, it is now serving with signature. The two exception (object not callable, invalid method signature) will return the corresponding message. The only thing I didn't figure out it how to change the color, so I didn't test for this feature.

[issue30219] webbrowser.open outputs xdg-open deprecation warning

2017-05-02 Thread desbma
desbma added the comment: I'm on Arch Linux with Cinnamon, all packages up to date and xdg-utils 1.1.1 (https://www.archlinux.org/packages/extra/any/xdg-utils/). The fix you mention has not been included in a release yet, last release of xdg-utils is from 2015 (https://portland.freedesktop.org

[issue30219] webbrowser.open outputs xdg-open deprecation warning

2017-05-02 Thread desbma
desbma added the comment: Also most other Popen calls in the webbrowser module already silence the called program's output, so it makes sense to do the same for the BackgroundBrowser class. Here is a small patch for discussion. -- keywords: +patch Added file: http://bugs.python.org/fi

[issue30228] Open a file in text mode requires too many syscalls

2017-05-02 Thread STINNER Victor
New submission from STINNER Victor: Example: with open("x", "w", encoding="utf-8") as fp: fp.write("HERE") fp.close() syscalls: 14249 open("x", O_WRONLY|O_CREAT|O_TRUNC|O_CLOEXEC, 0666) = 3 14249 fstat(3, {st_mode=S_IFREG|0664, st_size=0, ...}) = 0 14249 ioctl(3, TCGETS, 0x7fff07d43330

[issue30132] [Windows] test_distutils leaks a vc140.pdb file

2017-05-02 Thread STINNER Victor
STINNER Victor added the comment: New changeset 92fd6c9ef54a857815e3dca8ee74b2b4f5cdf154 by Victor Stinner in branch 'master': bpo-30132: distutils BuildExtTestCase use temp_cwd (#1380) https://github.com/python/cpython/commit/92fd6c9ef54a857815e3dca8ee74b2b4f5cdf154 -- _

[issue30199] Warning -- asyncore.socket_map was modified by test_ssl

2017-05-02 Thread STINNER Victor
STINNER Victor added the comment: New changeset 1dae7450c68bad498e57800387b24cb103c461fa by Victor Stinner in branch 'master': bpo-30199: test_ssl closes all asyncore channels (#1381) https://github.com/python/cpython/commit/1dae7450c68bad498e57800387b24cb103c461fa -- ___

[issue30212] test_ssl.py is broken in Centos7

2017-05-02 Thread david-cpi
david-cpi added the comment: Hi Victor, I will try during the day and get back with the logs. -- ___ Python tracker ___ ___ Python-bug

[issue30228] Open a file in text mode requires too many syscalls

2017-05-02 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +1491 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30224] remove outdated checks in struct

2017-05-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Could you please run microbenchmarks for affected code to be sure that changes don't hit performance (if for example PyLong_FromLongLong is significantly slower than PyLong_FromLong)? -- nosy: +serhiy.storchaka __

[issue30228] Open a file in text mode requires too many syscalls

2017-05-02 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +1492 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30228] Open a file in text mode requires too many syscalls

2017-05-02 Thread STINNER Victor
Changes by STINNER Victor : -- components: +IO ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue30229] Closing a BufferedRandom calls lseek() mutliple times

2017-05-02 Thread STINNER Victor
New submission from STINNER Victor: Given the following snippet: with open("x", "w+", encoding="utf-8") as fp: pass Creating the TextIOWrapper object requires many syscall: see the issue #30228. But I also noticed that *closing* such object also requires multiple lseek() syscalls,

[issue30212] test_ssl.py is broken in Centos7

2017-05-02 Thread david-cpi
david-cpi added the comment: Hello Victor, in 3.6.1 the test passes but it's because on sub-test was removed. The one generating the issue is NetworkedBIOTests which is not found in 3.6.1. in 3.5.2: if support.is_resource_enabled('network'): tests.append(NetworkedTests) tes

[issue30212] test_ssl.py is broken in Centos7

2017-05-02 Thread STINNER Victor
STINNER Victor added the comment: > in 3.6.1 the test passes but it's because on sub-test was removed. The unit tests still exist and were enhanced. On Python 3.5, the BIO read-write data test used the external server self-signed.pythontest.net. On Python 3.6, the test now uses a server runnin

[issue30229] Closing a BufferedRandom calls lseek() mutliple times

2017-05-02 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +1493 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30228] Open a file in text mode requires too many syscalls

2017-05-02 Thread STINNER Victor
STINNER Victor added the comment: New changeset 999707373630ce090300c3c542066f493b12faa0 by Victor Stinner in branch 'master': bpo-30228: FileIO seek() and tell() set seekable (#1384) https://github.com/python/cpython/commit/999707373630ce090300c3c542066f493b12faa0 -- ___

[issue29641] ./configure --enable-optimizations && make && make install compiles Python twice

2017-05-02 Thread STINNER Victor
STINNER Victor added the comment: Ok, I tested again: in fact, "it works" but "make install" recompiles Python from scratch (1st build with -fprofile-generate, profile task, 2nd build with -fprofile-use) whereas "make" just succeeded to build Python!? -- title: make install failure whe

[issue30132] [Windows] test_distutils leaks a vc140.pdb file

2017-05-02 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +1494 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue29641] ./configure --enable-optimizations && make && make install compiles Python twice

2017-05-02 Thread STINNER Victor
STINNER Victor added the comment: Oh, it's just a duplicate of issue #29243. -- resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> --enable-optimizations makes common build commands always need to compile from scratch __

[issue30224] remove outdated checks in struct

2017-05-02 Thread Xiang Zhang
Xiang Zhang added the comment: There seems no significant regression in performance. A microbenchmark against nu_longlong: ./python3 -m perf timeit --duplicate=1000 --compare-to /home/angwer/repos/cpython/python -s 'import struct; p = struct.Struct("@L")' 'p.unpack(b"d\x00\x00\x00\x00\x00\x00

[issue30132] [Windows] test_distutils leaks a vc140.pdb file

2017-05-02 Thread STINNER Victor
STINNER Victor added the comment: New changeset 30768958490c658fba0fe24f1cabbdad44be22ff by Victor Stinner in branch '3.6': bpo-30132: distutils BuildExtTestCase use temp_cwd (#1387) https://github.com/python/cpython/commit/30768958490c658fba0fe24f1cabbdad44be22ff --

[issue30132] [Windows] test_distutils leaks a vc140.pdb file

2017-05-02 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +1495 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30131] test_logging leaks a "dangling" thread

2017-05-02 Thread STINNER Victor
STINNER Victor added the comment: Ok, this bug is now fixed in 3.5, 3.6 and master (3.7). -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker _

[issue30173] x86 Windows7 3.x buildbot has the issue #26624 bug

2017-05-02 Thread STINNER Victor
STINNER Victor added the comment: I don't see the bug again, I confirm that the bug was fixed. Thanks David. -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker __

[issue30228] Open a file in text mode requires too many syscalls

2017-05-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I don't like PR 1385. abs_pos is a private attribute used only in _io._Buffered.seek() for readable streams when whence is SEEK_SET or SEEK_CUR. There is no guarantee that it contains relevant value for non-readable stream. You could call buffer.seek(0, SEEK

[issue30124] Fix C aliasing issue in Python/dtoa.c to use strict aliasing on Clang 4.0

2017-05-02 Thread STINNER Victor
STINNER Victor added the comment: dtoa.c is now compiled with -fno-string-aliasing (for any clang version, not only clang 4.0) on Python 3.5, 3.6 and 3.7. It was decided to not touch dtoa.c to not diverge from upstream. Thanks Dimitry Andric and Mark Dickinson for your reviews and support in t

[issue30104] clang 4.0 miscompiles dtoa.c, giving broken float parsing and printing

2017-05-02 Thread STINNER Victor
STINNER Victor added the comment: dtoa.c is now compiled with -fno-string-aliasing (for any clang version, not only clang 4.0) on Python 3.5, 3.6 and 3.7. It was decided to not touch dtoa.c to not diverge from upstream. Thanks Dimitry Andric and Mark Dickinson for your reviews and support in t

[issue30224] remove outdated checks in struct

2017-05-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I see a tiny 3% regression. $ ./python -m timeit -s 'import struct; u = struct.Struct("10Q").unpack; b = b"abcd\0\0\0\0"*10' 'u(b)' Unpatched: 50 loops, best of 5: 9.34 msec per loop Patched:50 loops, best of 5: 9.66 msec per loop $ ./python -m

[issue30132] [Windows] test_distutils leaks a vc140.pdb file

2017-05-02 Thread STINNER Victor
STINNER Victor added the comment: New changeset 3ceeb84b5a90e327ef55190105e82c926b0b8aab by Victor Stinner in branch '3.5': bpo-30132: distutils BuildExtTestCase use temp_cwd (#1387) (#1388) https://github.com/python/cpython/commit/3ceeb84b5a90e327ef55190105e82c926b0b8aab --

[issue30199] Warning -- asyncore.socket_map was modified by test_ssl

2017-05-02 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +1496 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30199] Warning -- asyncore.socket_map was modified by test_ssl

2017-05-02 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +1497 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30230] Move quick test in PyObject_IsSubClass outside if PyType_CheckExact guard

2017-05-02 Thread Jim Fasarakis-Hilliard
New submission from Jim Fasarakis-Hilliard: Currently the first lines in PyObject_IsSubClass are: /* We know what type's __subclasscheck__ does. */ if (PyType_CheckExact(cls)) { /* Quick test for an exact match */ if (derived == cls) return 1; return r

[issue30125] test_SEH() of test_ctypes logs "Windows fatal exception: access violation"

2017-05-02 Thread STINNER Victor
STINNER Victor added the comment: faulthandler.disable() has been fixed on Windows in Python 3.6 and master (3.7). The test_ctypes warning has been made quiet in Python 3.6 and master (3.7) as well. -- resolution: -> fixed stage: -> resolved status: open -> closed __

[issue30230] Move quick test in PyObject_IsSubClass outside of PyType_CheckExact guard

2017-05-02 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- title: Move quick test in PyObject_IsSubClass outside if PyType_CheckExact guard -> Move quick test in PyObject_IsSubClass outside of PyType_CheckExact guard type: behavior -> performance ___ Python tracker

[issue30126] CheckTraceCallbackContent of test_sqlite3 fails on OS X Tiger

2017-05-02 Thread STINNER Victor
STINNER Victor added the comment: David: "Ok, this should be resolved." Oh, thank you! I confirm that test_sqlite3 pass again! -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker

[issue30169] test_multiprocessing_spawn crashed on AMD64 Windows8.1 Non-Debug 3.x buildbot

2017-05-02 Thread STINNER Victor
STINNER Victor added the comment: Sadly, the random issue didn't reoccur in the following 13 builds. So I close the issue. I will reopen it if I see the crash again. -- resolution: -> out of date stage: -> resolved status: open -> closed ___ Python

[issue30231] test_imaplib needs a TLS server accepting self-signed certificates

2017-05-02 Thread STINNER Victor
New submission from STINNER Victor: The public cyrus.andrew.cmu.edu IMAP server (port 993) doesn't accept TLS connection using our self-signed x509 certificate. The following two tests of test_imaplib were skipped by the issue #30175: * test_logincapa_with_client_certfile() of RemoteIMAP_SSLTe

[issue30175] Random test_imaplib.test_logincapa_with_client_certfile failure on x86 Gentoo Installed with X 3.x

2017-05-02 Thread STINNER Victor
STINNER Victor added the comment: Buildbots are now fixed, I close the issue. I created the issue #30231 to propose to run an IMAP server on pythontest.net, or to remove the two unit tests which are currently skipped. Thanks for your help Antoine Pitrou! -- resolution: -> fixed stage

[issue30199] Warning -- asyncore.socket_map was modified by test_ssl

2017-05-02 Thread STINNER Victor
STINNER Victor added the comment: New changeset 89a54c73746417bae003a9985668fa665040d5d9 by Victor Stinner in branch '3.5': bpo-30199: test_ssl closes all asyncore channels (#1381) (#1389) https://github.com/python/cpython/commit/89a54c73746417bae003a9985668fa665040d5d9 -- __

[issue30199] Warning -- asyncore.socket_map was modified by test_ssl

2017-05-02 Thread STINNER Victor
STINNER Victor added the comment: New changeset 3c422b92653df05c7034136b77f76376aa5aec4f by Victor Stinner in branch '3.6': bpo-30199: test_ssl closes all asyncore channels (#1381) (#1390) https://github.com/python/cpython/commit/3c422b92653df05c7034136b77f76376aa5aec4f -- __

[issue27593] Deprecate sys._mercurial and create sys._git

2017-05-02 Thread STINNER Victor
STINNER Victor added the comment: New changeset 2c7085fd7b00cba8b5ab258c62453b6a12418b73 by Victor Stinner in branch '2.7': bpo-27593: Get SCM build info from git instead of hg (#1327) https://github.com/python/cpython/commit/2c7085fd7b00cba8b5ab258c62453b6a12418b73 -- __

[issue30224] remove outdated checks in struct

2017-05-02 Thread Xiang Zhang
Xiang Zhang added the comment: The test on my box is reverse and stable, python3 is unpatched and python is patched. Anyway, it can't be called significant. ./python3 -m perf timeit --compare-to /home/angwer/repos/cpython/python -s 'import struct; u = struct.Struct("10Q").unpack; b=b"abc

[issue30232] configure: support Git worktree

2017-05-02 Thread STINNER Victor
New submission from STINNER Victor: configure.ac tests if .git/HEAD file exists to decide if it should get the git version / tag / branch. I use git worktree to get 2.7, 3.5, 3.6 and master in their own directory. When using git worktree, ".git" is a text file with a content like: haypo@selma

[issue30232] configure: support Git worktree

2017-05-02 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +1498 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30232] configure: support Git worktree

2017-05-02 Thread STINNER Victor
STINNER Victor added the comment: See the bpo-29798 which added support for Git worktree in `make patchcheck`. -- ___ Python tracker ___ _

[issue30205] socket.getsockname() type mismatch with AF_UNIX on Linux

2017-05-02 Thread Antoine Pitrou
Antoine Pitrou added the comment: New changeset 495b5021e73e3c4b6404417ecf4fa83aa10297f0 by Antoine Pitrou in branch 'master': bpo-30205: Fix getsockname() for unbound AF_UNIX sockets on Linux (#1370) https://github.com/python/cpython/commit/495b5021e73e3c4b6404417ecf4fa83aa10297f0 --

[issue30224] remove outdated checks in struct

2017-05-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Your patch LGTM. Current code in _struct.c is ugly. I just wonder if it is worth to optimize PyLong_FromLongLong and PyLong_FromUnsignedLongLong if they are slower than PyLong_FromLong and PyLong_FromUnsignedLong. --

[issue27593] Deprecate sys._mercurial and create sys._git

2017-05-02 Thread STINNER Victor
Changes by STINNER Victor : -- pull_requests: +1499 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue27593] Deprecate sys._mercurial and create sys._git

2017-05-02 Thread STINNER Victor
STINNER Victor added the comment: With https://github.com/python/cpython/pull/1392 Python 2.7 should up to date with Python master, and this issue should be fixed. Or did I miss something? -- ___ Python tracker __

[issue30223] Add Lib/test/__main__.py in 2.7

2017-05-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 43566aee12a177a7aef5d732abf768251e6b8a12 by Serhiy Storchaka in branch '2.7': [2.7] bpo-30223: Add Lib/test/__main__.py. (#1373) https://github.com/python/cpython/commit/43566aee12a177a7aef5d732abf768251e6b8a12 --

[issue30132] [Windows] test_distutils leaks a vc140.pdb file

2017-05-02 Thread STINNER Victor
STINNER Victor added the comment: Ok, this issue is now fixed in 3.5, 3.6 and master (3.7). -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___

[issue30205] socket.getsockname() type mismatch with AF_UNIX on Linux

2017-05-02 Thread Giampaolo Rodola'
Giampaolo Rodola' added the comment: Thanks. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue29992] Expose parse_string in JSONDecoder

2017-05-02 Thread Bob Ippolito
Bob Ippolito added the comment: That's not a very convincing argument. Python 2 only returns byte strings if the input is a byte string and the contents of the string are all ASCII. Facilitating that sort of behavior in 3 would probably cause more issues than it solves. -- __

[issue30233] [3.5] Warning -- locale was modified by test_idle

2017-05-02 Thread STINNER Victor
New submission from STINNER Victor: Importing idlelib.IOBinding modifies the LC_CTYPE locale. For example, this module is imported by idlelib.EditorWindow which is imported by idlelib.idle_test.test_formatparagraph. As a consequence, running test_idle changes locales and the following warning

[issue30234] Remove duplicate checks in test_isinstance

2017-05-02 Thread Jim Fasarakis-Hilliard
New submission from Jim Fasarakis-Hilliard: The test file duplicates some isinstance and issubclass checks due to the distinction of classes in Python 2. Proposed PR removes duplicate asserts. -- components: Tests messages: 292784 nosy: Jim Fasarakis-Hilliard priority: normal severit

[issue30234] Remove duplicate checks in test_isinstance

2017-05-02 Thread Jim Fasarakis-Hilliard
Changes by Jim Fasarakis-Hilliard : -- pull_requests: +1500 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: htt

[issue27593] Deprecate sys._mercurial and create sys._git

2017-05-02 Thread Brett Cannon
Brett Cannon added the comment: I think that covers it! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue30223] Add Lib/test/__main__.py in 2.7

2017-05-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: These new features affect only core developers and other contributors fixing bugs in 2.7. I don't think the "no new features" guideline is applicable here. -- resolution: -> fixed stage: -> resolved status: open -> closed __

[issue19903] Idle: Use inspect.signature for calltips

2017-05-02 Thread Terry J. Reedy
Terry J. Reedy added the comment: I will try to do that when I can. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue30235] Validate shutil supports path-like objects, update docs accordingly

2017-05-02 Thread Brett Cannon
New submission from Brett Cannon: If you look at the docs for shutil (https://docs.python.org/3/library/shutil.html), you will notice all over it says things like "path names given as strings". The question is whether that statement is true in the face of path-like objects? If it is true then

[issue30235] Validate shutil supports path-like objects, update docs accordingly

2017-05-02 Thread Brett Cannon
Changes by Brett Cannon : -- versions: +Python 3.6 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue28556] typing.py upgrades

2017-05-02 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: New changeset f06e0218ef6007667f5d61184b85a81a0466d3ae by Mariatta (Ivan Levkivskyi) in branch 'master': bpo-28556: Routine updates to typing (#1366) https://github.com/python/cpython/commit/f06e0218ef6007667f5d61184b85a81a0466d3ae -- __

[issue30235] Validate shutil supports path-like objects, update docs accordingly

2017-05-02 Thread Jelle Zijlstra
Changes by Jelle Zijlstra : -- pull_requests: +1501 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30236] Add options --match and --failfast for test.regrtest in 2.7

2017-05-02 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: Proposed patch adds options -m/--match and -G/--failfast for test.regrtest in 2.7. They are two the most wanted by me features absent in 2.7. I use them when add new test in long running test file. Often this needs running the test multiple times, incremen

[issue30236] Add options --match and --failfast for test.regrtest in 2.7

2017-05-02 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- pull_requests: +1502 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue30237] Access violation due to CancelSynchronousIo of console read

2017-05-02 Thread Eryk Sun
New submission from Eryk Sun: When ReadConsole is canceled by CancelSynchronousIo [1], for some reason the call still succeeds. It's probably related to the hack that maps STATUS_ALERTED to ERROR_OPERATION_ABORTED when a console read is interrupted by Ctrl+C. The problem is that, when canceled

[issue30233] [3.5] Warning -- locale was modified by test_idle

2017-05-02 Thread Terry J. Reedy
Terry J. Reedy added the comment: The warning, which became a failure in 3.6, was averted for 3.6 by #27372. I intentionally did not patch 3.5 and merge forward because the warning was neither unique nor a failure, while adding the merge would have been a considerable bother. Also, I anticip

[issue30237] Access violation due to CancelSynchronousIo of console read

2017-05-02 Thread Eryk Sun
Eryk Sun added the comment: Oops, I pasted the MSDN link for ReadConsole instead of CancelSynchronousIo [1]. [1]: https://msdn.microsoft.com/en-us/library/aa363794 -- ___ Python tracker ___

[issue30223] Add Lib/test/__main__.py in 2.7

2017-05-02 Thread Zachary Ware
Zachary Ware added the comment: Once again, I agree with the change, but I have an unhappy buildbot :) http://buildbot.python.org/all/builders/x86%20Gentoo%20Non-Debug%20with%20X%202.7/builds/124 This time it is due to python 2.4 not supporting the absolute_import __future__ feature. By this

  1   2   >