[issue29521] Minor warning messages when compiling documentation

2017-02-10 Thread Jim DeLaHunt
New submission from Jim DeLaHunt: When I build the documentation on the current CPython code, there are various error and warning messages on the console. Here's what my build output looks like. I've marked the messages I'm concerned about with a numbered >>0>> prefix. = (beginning of ou

[issue29507] Use FASTCALL in call_method() to avoid temporary tuple

2017-02-10 Thread INADA Naoki
INADA Naoki added the comment: performance benefit is small. https://gist.github.com/methane/32fe57cd4aaac1c5c37f75cbbfbe7562 -- Added file: http://bugs.python.org/file46619/callmethod3.patch ___ Python tracker ___

[issue29519] weakref spewing exceptions during finalization when combined with multiprocessing

2017-02-10 Thread Roundup Robot
Roundup Robot added the comment: New changeset 2cb530243943 by Łukasz Langa in branch '3.5': Fix #29519: weakref spewing exceptions during interp finalization https://hg.python.org/cpython/rev/2cb530243943 New changeset c5267272e66a by Łukasz Langa in branch '3.6': Merge 3.5 (fix #29519) https:/

[issue29519] weakref spewing exceptions during finalization when combined with multiprocessing

2017-02-10 Thread Łukasz Langa
Łukasz Langa added the comment: Given that the weakref behavior during shutdown with the repro was identical in 3.6.0, as well as in 3.5.2 and earlier, I patched this by binding the name to a local, therefore making it usable also during finalization. -- assignee: pitrou -> lukasz.lang

[issue29521] Minor warning messages when compiling documentation

2017-02-10 Thread Martin Panter
Martin Panter added the comment: Jim, regarding Doc/faq/windows.rst, this warning lead me to open Issue 29387. We already have discussed a patch for that, and I think it is ready to commit (when it gets to the top of my list, if nobody else beats me to it). Regarding Misc/NEWS, I think I was g

[issue29520] Documentation uses deprecated "defindex.html" Sphinx template

2017-02-10 Thread Jim DeLaHunt
Jim DeLaHunt added the comment: The other warnings in the "make html" output are the subject of http://bugs.python.org/issue29521 . -- ___ Python tracker ___ ___

[issue29521] Minor warning messages when compiling documentation

2017-02-10 Thread Martin Panter
Changes by Martin Panter : -- dependencies: +Tabs vs spaces FAQ out of date ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue29522] PyLong_AsDouble Behaviour is Weird

2017-02-10 Thread nico
New submission from nico: I'm using the pre-installed version of Python 2.7.12 on Ubuntu 16.04. Pretty straight forward error the following code: PyObject * intobj = PyInt_FromLong(10); double d1 = (double)PyLong_AsLong(intobj); double d2 = PyLong_AsDouble(intobj); printf("Should be the same: %

[issue29519] weakref spewing exceptions during finalization when combined with multiprocessing

2017-02-10 Thread Roundup Robot
Roundup Robot added the comment: New changeset 6c961c5a5396ef125dbbc47c060272a5d12c1646 by Łukasz Langa in branch 'master': Fix #29519: weakref spewing exceptions during interp finalization https://github.com/python/cpython/commit/6c961c5a5396ef125dbbc47c060272a5d12c1646 New changeset 39279a07

[issue29519] weakref spewing exceptions during finalization when combined with multiprocessing

2017-02-10 Thread Roundup Robot
Roundup Robot added the comment: New changeset 6c961c5a5396ef125dbbc47c060272a5d12c1646 by Łukasz Langa in branch '3.6': Fix #29519: weakref spewing exceptions during interp finalization https://github.com/python/cpython/commit/6c961c5a5396ef125dbbc47c060272a5d12c1646 New changeset 39279a07e8f

[issue29519] weakref spewing exceptions during finalization when combined with multiprocessing

2017-02-10 Thread Roundup Robot
Roundup Robot added the comment: New changeset 6c961c5a5396ef125dbbc47c060272a5d12c1646 by Łukasz Langa in branch '3.5': Fix #29519: weakref spewing exceptions during interp finalization https://github.com/python/cpython/commit/6c961c5a5396ef125dbbc47c060272a5d12c1646 --

[issue29507] Use FASTCALL in call_method() to avoid temporary tuple

2017-02-10 Thread STINNER Victor
STINNER Victor added the comment: >> I'm not sure about the change on PyObject_CallMethod*() only for empty >> format string. > > There are many place using _PyObject_CallMethodId() to call method without > args. I'm more interested by an optimization PyObject_CallMethod*() for any number of

[issue29522] PyLong_AsDouble Behaviour is Weird

2017-02-10 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This is incorrect use of PyLong_AsDouble(). It should be used with a long object, but you use it with an int object. -- nosy: +serhiy.storchaka resolution: -> not a bug stage: -> resolved status: open -> closed _

[issue29507] Use FASTCALL in call_method() to avoid temporary tuple

2017-02-10 Thread STINNER Victor
STINNER Victor added the comment: > performance benefit is small. > https://gist.github.com/methane/32fe57cd4aaac1c5c37f75cbbfbe7562 Are you using PGO+LTO compilation? Without PGO, the noise of code placement can be too high. In your "perf stat" comparisons, I see that "insn per cycle" is lowe

[issue23404] 'make touch' does not work with git clones of the source repository

2017-02-10 Thread Chi Hsuan Yen
Chi Hsuan Yen added the comment: Just tried boot-flag.patch with https://github.com/python/cpython/commit/16e07881bd3867d471dd0a25c5117672b65c90ee. Doesn't work out-of-box: #./Programs/_freeze_importlib \ ./Lib/importlib/_bootstrap.py Python/importlib.h /bin/sh: line 1: ./Lib/importlib/_bo

[issue29100] datetime.fromtimestamp() doesn't check min/max year anymore: regression of Python 3.6

2017-02-10 Thread STINNER Victor
STINNER Victor added the comment: I pushed timestamp_limits-2.patch. Thanks for the bug report Jordon Phillips, thanks for the review Serhiy Storshaka. -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker

[issue29100] datetime.fromtimestamp() doesn't check min/max year anymore: regression of Python 3.6

2017-02-10 Thread Roundup Robot
Roundup Robot added the comment: New changeset 383c0238b5b0 by Victor Stinner in branch '3.6': Fix datetime.fromtimestamp(): check bounds https://hg.python.org/cpython/rev/383c0238b5b0 -- nosy: +python-dev ___ Python tracker

[issue29507] Use FASTCALL in call_method() to avoid temporary tuple

2017-02-10 Thread INADA Naoki
INADA Naoki added the comment: Yes, I used --enable-optimization this time. But my patch is not good for branch prediction of my CPU in this time. I'm willing Object/call.c solves such placement issue. BTW, since benefit of GetMethod is small, how about this? * Add _PyMethod_FastCallKeywords *

[issue27744] Add AF_ALG (Linux Kernel crypto) to socket module

2017-02-10 Thread STINNER Victor
STINNER Victor added the comment: What is the status of this issue? test_aead_aes_gcm() fails on my Fedora 25 (Python: default branch). haypo@selma$ cat /etc/fedora-release Fedora release 25 (Twenty Five) haypo@selma$ uname -r 4.9.5-200.fc25.x86_64 test test_socket failed -- Traceback (most r

[issue29521] Minor warning messages when compiling documentation

2017-02-10 Thread Jim DeLaHunt
Jim DeLaHunt added the comment: Thanks, Martin, for your suggestions. In Misc/NEWS, I've respelled the ``char *`` as you suggested. In faq/windows.rst, I've used your wording from the discussion in http://bugs.python.org/issue29387 . Pull Request 76 https://github.com/python/cpython/pull/76 r

[issue29387] Tabs vs spaces FAQ out of date

2017-02-10 Thread Jim DeLaHunt
Jim DeLaHunt added the comment: I just created Pull Request 76 https://github.com/python/cpython/pull/76 to address http://bugs.python.org/issue29521 . In faq/windows.rst, I've used your wording from the discussion in of this bug. I may have address this issue completely, in fact. I did not

[issue29100] datetime.fromtimestamp() doesn't check min/max year anymore: regression of Python 3.6

2017-02-10 Thread Roundup Robot
Roundup Robot added the comment: New changeset 5b804b2fb0eaa2bacb4afcfe4cfa85b31475e87f by Victor Stinner in branch 'master': Fix datetime.fromtimestamp(): check bounds https://github.com/python/cpython/commit/5b804b2fb0eaa2bacb4afcfe4cfa85b31475e87f -- __

[issue29100] datetime.fromtimestamp() doesn't check min/max year anymore: regression of Python 3.6

2017-02-10 Thread Roundup Robot
Roundup Robot added the comment: New changeset 5b804b2fb0eaa2bacb4afcfe4cfa85b31475e87f by Victor Stinner in branch '3.6': Fix datetime.fromtimestamp(): check bounds https://github.com/python/cpython/commit/5b804b2fb0eaa2bacb4afcfe4cfa85b31475e87f -- _

[issue27744] Add AF_ALG (Linux Kernel crypto) to socket module

2017-02-10 Thread Christian Heimes
Christian Heimes added the comment: I'll look into the matter and push a fix after the migration to github today. -- ___ Python tracker ___ __

[issue27744] Add AF_ALG (Linux Kernel crypto) to socket module

2017-02-10 Thread Christian Heimes
Christian Heimes added the comment: By the way problem with AES-GCM is tracked in https://bugs.python.org/issue29324 . It was caused in a Kernel API change. Jan has provided a fix. I need to find some spare time to dig into Kernel sources and verify the patch. --

[issue29523] latest setuptools breaks virtualenvs due to unbundling dependencies

2017-02-10 Thread Charalampos Stratakis
New submission from Charalampos Stratakis: The latest versions of setuptools stopped bundling its dependencies and instead starting requiring them [0]. This seems to break virtualenvs as those dependencies are not bundled with python. In order to reproduce it, replace the setuptools-28.8.0-py2

[issue29387] Tabs vs spaces FAQ out of date

2017-02-10 Thread Marco Buttu
Marco Buttu added the comment: Thanks Jim. I tested thise exec() in Py2.7 and Py3 (3.5 - 3.7): exec("if True:\n" + " "*width + "1\n" + "\t2\n") * width == 0 raises a IndentationError both in Py2 and Py3 * width in range(1, 8) raises an IndentationError in Py2 and TabError in Py3 * width == 8 is

[issue27286] str object got multiple values for keyword argument

2017-02-10 Thread Mark Dickinson
Mark Dickinson added the comment: It's difficult to track down which versions of Python 3.5.x the bytecode change is in because the Misc/NEWS entry has vanished, apparently in this merge commit: https://github.com/python/cpython/commit/aa0f9d8f26bbe63adcbce950aaadc844d996e7ac -- nosy

[issue27286] str object got multiple values for keyword argument

2017-02-10 Thread Larry Hastings
Larry Hastings added the comment: Sorry about that! It's almost like manually updating Misc/NEWS is a bad design :( -- ___ Python tracker ___ __

[issue29100] datetime.fromtimestamp() doesn't check min/max year anymore: regression of Python 3.6

2017-02-10 Thread Roundup Robot
Roundup Robot added the comment: New changeset 1c6b87b07586 by Victor Stinner in branch '3.6': Fix test_datetime on system with 32-bit time_t https://hg.python.org/cpython/rev/1c6b87b07586 -- ___ Python tracker ___

[issue29324] test_aead_aes_gcm fails on Kernel 4.9

2017-02-10 Thread STINNER Victor
STINNER Victor added the comment: I confirm that test_socket pass with test_socket_aead_kernel49.patch on my Fedora 25 (kernel 4.9.5-200.fc25.x86_64). I would be nice to fix test_socket which is currently broken ;-) -- nosy: +haypo ___ Python tracke

[issue29518] 'for' loop not automatically breaking (index error on line of loop header)

2017-02-10 Thread Steven D'Aprano
Steven D'Aprano added the comment: I agree with Josh: the exception you are giving doesn't seem possible with the code snippet shown. Please COPY AND PASTE (not a screen shot) the text of the entire traceback, starting with the line "Traceback..." I suspect that you may have shadowed the built

[issue29176] /tmp does not exist on Android and is used by curses.window.putwin()

2017-02-10 Thread STINNER Victor
STINNER Victor added the comment: curses_temporaryfile.patch: Call tempfile.TemporaryFile in getwin() and putwin() to create the temporary file in a more portable and safer manner. The curses library requires a FILE* object, but TemporaryFile.close() must be called to remove the temporary file

[issue29176] /tmp does not exist on Android and is used by curses.window.putwin()

2017-02-10 Thread STINNER Victor
STINNER Victor added the comment: curses_fix_window_class_name.patch: Fix the name of the C window class: "_curses.window", not "_curses.curses window" (with a space in the class name) !? The following example current displays : --- import curses w = curses.initscr() curses.endwin() print(type

[issue29100] datetime.fromtimestamp() doesn't check min/max year anymore: regression of Python 3.6

2017-02-10 Thread Roundup Robot
Roundup Robot added the comment: New changeset a88f9614c672c3369cf03cdf51d012a42ae5665f by Victor Stinner in branch 'master': Fix test_datetime on system with 32-bit time_t https://github.com/python/cpython/commit/a88f9614c672c3369cf03cdf51d012a42ae5665f -- __

[issue29176] /tmp does not exist on Android and is used by curses.window.putwin()

2017-02-10 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Check that pickling/unpickling the windows object doesn't cause crash or undefined behaviour. Currently the pickling fails because the name of the class is not true name. -- ___ Python tracker

[issue27640] add the '--disable-test-suite' option to configure

2017-02-10 Thread STINNER Victor
STINNER Victor added the comment: I'm in favor of allowing to build a "subset" of Python. Not only it makes sense for embedded devices, but in many cases it's even not possible to do otherwise: "full" Python is too big for small devices. But I would prefer to see a public discussion on python-

[issue27640] add the '--disable-test-suite' option to configure

2017-02-10 Thread Chi Hsuan Yen
Changes by Chi Hsuan Yen : -- nosy: +Chi Hsuan Yen ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue20210] Provide configure options to enable/disable Python modules and extensions

2017-02-10 Thread STINNER Victor
STINNER Victor added the comment: Antoine Pitrou: "That's not really the point. The question is why we should have to maintain this ourselves. It is easy for interested people to maintain their own forks, especially when *removing* stuff." It's painful to have to maintain downstream patches. S

[issue29300] Modify the _struct module to use FASTCALL and Argument Clinic

2017-02-10 Thread STINNER Victor
STINNER Victor added the comment: I'm not aware of any pending issues, buildbots are happy, I'm happy, I close the issue :-) Don't hesitate to reopen it if I missed something. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed __

[issue20210] Provide configure options to enable/disable Python modules and extensions

2017-02-10 Thread Antoine Pitrou
Antoine Pitrou added the comment: > It's painful to have to maintain downstream patches. Supporting this feature > would make Python usable on more platforms. Who volunteers to support it? It's a PITA to maintain the configure script and setup.py, and adding options only makes it more painful

[issue29100] datetime.fromtimestamp() doesn't check min/max year anymore: regression of Python 3.6

2017-02-10 Thread Roundup Robot
Roundup Robot added the comment: New changeset 1555e7776321 by Victor Stinner in branch '3.6': Fix test_datetime on Windows https://hg.python.org/cpython/rev/1555e7776321 -- ___ Python tracker _

[issue29523] latest setuptools breaks virtualenvs due to unbundling dependencies

2017-02-10 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +jason.coombs ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue20210] Provide configure options to enable/disable Python modules and extensions

2017-02-10 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: I'm still -1 on the approach taken by the OP, but +1 on Martin's approach of making such configurations more easily possible via Modules/Setup. -- ___ Python tracker _

[issue29176] /tmp does not exist on Android and is used by curses.window.putwin()

2017-02-10 Thread STINNER Victor
STINNER Victor added the comment: Serhiy Storchaka: "Check that pickling/unpickling the windows object doesn't cause crash or undefined behaviour. Currently the pickling fails because the name of the class is not true name." Ah, good idea. I tested with curses_fix_window_class_name.patch: win

[issue20210] Provide configure options to enable/disable Python modules and extensions

2017-02-10 Thread STINNER Victor
STINNER Victor added the comment: Antoine Pitrou: " Who volunteers to support it? It's a PITA to maintain the configure script and setup.py, and adding options only makes it more painful. This kind of niche features needs some dedicated maintainer so that other core developers don't have to

[issue29100] datetime.fromtimestamp() doesn't check min/max year anymore: regression of Python 3.6

2017-02-10 Thread Roundup Robot
Roundup Robot added the comment: New changeset be363764cad68ad7b608ceed837cc01c2c3b4efc by Victor Stinner in branch 'master': Fix test_datetime on Windows https://github.com/python/cpython/commit/be363764cad68ad7b608ceed837cc01c2c3b4efc -- ___ Pyth

[issue27640] add the '--disable-test-suite' option to configure

2017-02-10 Thread STINNER Victor
STINNER Victor added the comment: > But I would prefer to see a public discussion on python-dev before going into > this direction. Ah, the discussion restarted on the other issue: http://bugs.python.org/issue20210#msg287516 -- ___ Python tracker <

[issue29100] datetime.fromtimestamp() doesn't check min/max year anymore: regression of Python 3.6

2017-02-10 Thread Roundup Robot
Roundup Robot added the comment: New changeset be363764cad68ad7b608ceed837cc01c2c3b4efc by Victor Stinner in branch '3.6': Fix test_datetime on Windows https://github.com/python/cpython/commit/be363764cad68ad7b608ceed837cc01c2c3b4efc -- ___ Python

[issue27286] str object got multiple values for keyword argument

2017-02-10 Thread Martin Panter
Martin Panter added the comment: Diff showing what changed relative to the main 3.5 branch when merging in the 3.5.2 release: . There are four news entries deleted from the 3.5.2rc1 section. Ideally they should have been moved to the

[issue29524] Move functions to call objects into a new Objects/call.c file

2017-02-10 Thread STINNER Victor
New submission from STINNER Victor: I propose to move functions to call objects into a new Objects/call.c file. It should easy maintainance since all moved functions are inter-dependent: it becomes easier to keep them consistent since they are in the same fle. I also have a small "hope" that m

[issue29524] Move functions to call objects into a new Objects/call.c file

2017-02-10 Thread STINNER Victor
STINNER Victor added the comment: See also issue #29502 "Should PyObject_Call() call the profiler on C functions, use C_TRACE() macro?": fixing this one should allow to remove fast-paths from ceval.c, since we now already have fast-paths in all "call" functions. -- ___

[issue29507] Use FASTCALL in call_method() to avoid temporary tuple

2017-02-10 Thread STINNER Victor
STINNER Victor added the comment: > I'm willing Object/call.c solves such placement issue. I also *hope* that a call.c file would *help* a little bit, but I'm not sure that it will fix *all* code placement issues. I created the issue #29524 with a patch creating Objects/call.c. -- __

[issue3955] maybe doctest doesn't understand unicode_literals?

2017-02-10 Thread Matthis Thorade
Matthis Thorade added the comment: I found this bug when trying to write a doctest that passes on Python 3.5 and Python 2.7.9. The following adapted example passes on Python2, but fails on Python3: # -*- coding: utf-8 -*- from __future__ import unicode_literals def f(): """ >>> f()

[issue29465] Add _PyObject_FastCall() to reduce stack consumption

2017-02-10 Thread Roundup Robot
Roundup Robot added the comment: New changeset f23fa1f7b68f by Victor Stinner in branch 'default': Issue #29465: Add Objects/call.c file https://hg.python.org/cpython/rev/f23fa1f7b68f -- ___ Python tracker

[issue29525] Python 2.7.13 for Windows broken (from prompt)

2017-02-10 Thread Frak N
New submission from Frak N: I used to have an older version of python 2.7 that has worked for years. I just upgraded to 2.7.13 for Windows, 32 bit and now, I can't get the interpreter to run from the command line. It just returns to the DOS prompt. c:\Python27>python Python 2.7.13 (v2.7.13:a06

[issue29525] Python 2.7.13 for Windows broken (from prompt)

2017-02-10 Thread Tim Golden
Tim Golden added the comment: Although I don't remember seeing a crash out as quick as this, common causes for this kind of thing are to do with environment variables pointing to still-existing or part-existing installations. Can you try: set PY from a command prompt, please, to see if any Py

[issue20210] Provide configure options to enable/disable Python modules and extensions

2017-02-10 Thread Antoine Pitrou
Antoine Pitrou added the comment: Victor, thanks for clarifying! That eliminates my objection, if there's a tacit agreement that the functionality can be broken by mistake and it's the dedicated maintainer (Xavier or someone else)'s job to repair it :-) -- ___

[issue29525] Python 2.7.13 for Windows broken (from prompt)

2017-02-10 Thread STINNER Victor
Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue29523] latest setuptools breaks virtualenvs due to unbundling dependencies

2017-02-10 Thread Jason R. Coombs
Jason R. Coombs added the comment: This approach, bundling the necessary dependencies to install setuptools, seems like exactly the right thing to do, assuming that ensurepip should install setuptools at all, and I don't want to challenge that assumption here. Looking at the patch and ensurepi

[issue29523] latest setuptools breaks virtualenvs due to unbundling dependencies

2017-02-10 Thread Jason R. Coombs
Jason R. Coombs added the comment: For convenience, here's a link to the rendered changelog in the docs, which provides hyperlinks to the relevant issues [0]. [0] https://setuptools.readthedocs.io/en/latest/history.html#v34-0-0 -- ___ Python tracker

[issue20210] Provide configure options to enable/disable Python modules and extensions

2017-02-10 Thread Matthias Klose
Matthias Klose added the comment: I don't see the point of having an option to do that. Will patches for third party projects be submitted as well, to not install the test suite? Or will pip gain such a feature? Note that removing the test suite completely, you'll make the test suites of som

[issue29526] Documenting format() function

2017-02-10 Thread Hugo Prod'homme
New submission from Hugo Prod'homme: Hello python contributors, this is my first time on python.org and I am coming with a suggestion. The idea is to help people that have to format strings containing numbers of various kinds, I am from the scientific domain but this should help everybody anyw

[issue29523] latest setuptools breaks virtualenvs due to unbundling dependencies

2017-02-10 Thread Donald Stufft
Donald Stufft added the comment: I haven't updated the bundled copy of ensurepip yet because of this. Most likely the way this will get resolved is that the PEP 518 PR will land in pip and we will no longer require setuptools to be pre-installed at all and ensurepip will go to only bundling pi

[issue29525] Python 2.7.13 for Windows broken (from prompt)

2017-02-10 Thread Steve Dower
Steve Dower added the comment: Readline is also a common culprit when it's crashing out at the interactive prompt. Try either uninstalling or upgrading any packages that may include a readline module. -- ___ Python tracker

[issue29515] socket module missing IPPROTO_IPV6, IPPROTO_IPV4 on Windows

2017-02-10 Thread Steve Dower
Steve Dower added the comment: We may just want to copy the values from the enum if there are different versions when they were introduced. But if that's not a problem, adding the MS_WINDOWS check is better than defining new macros. -- ___ Python tr

[issue29526] Documenting format() function

2017-02-10 Thread Eric V. Smith
Eric V. Smith added the comment: Since these codes don't apply to all types, you'll need some words saying what they do apply to. For example, None being the same as "g" is true for int, float, and Decimal; but None is "s" for strings. And, for example, none of the listed codes apply to dateti

[issue29523] latest setuptools breaks virtualenvs due to unbundling dependencies

2017-02-10 Thread Charalampos Stratakis
Charalampos Stratakis added the comment: @jason.coombs Already tried to just bump the setuptools version and bundle the other wheels but the result is still the same -- ___ Python tracker

[issue29526] Documenting format() function

2017-02-10 Thread R. David Murray
R. David Murray added the comment: Thanks for wanting to help improve python. I'm not entirely clear on what you are proposing. I *think* you want to add something to the 'format' docstring? As Eric mentioned the 'mini language' depends on the datatype, so it is going to be hard to cram accu

[issue29524] Move functions to call objects into a new Objects/call.c file

2017-02-10 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I like the idea of moving all code related to calling objects in one one file. But this has a drawback. This breaks a history. This makes harder code exploration and merging. I would delay pushing this change until CPython repository be converted to Git. I

[issue29523] latest setuptools breaks virtualenvs due to unbundling dependencies

2017-02-10 Thread Jason R. Coombs
Jason R. Coombs added the comment: Aah, yes. I see now. Ensure_pip uses _PROJECTS for three purposes: for defining additional_projects, extracting those packages to the tmpdir, and for declaring the installation of those projects. Only that last declaration is unnecessary. This patch looks goo

[issue29526] Documenting format() function

2017-02-10 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I think it would be worth to extend docstrings of __format__ methods of concrete types for including the description of type-specific format specifiers. But the docstring of format() shouldn't contain the description of format specifiers of all builtin types

[issue29526] Documenting format() function

2017-02-10 Thread Marco Buttu
Marco Buttu added the comment: > It may be worth to add a reference to FORMATTING from the > format() docstring. +1 :-) -- nosy: +marco.buttu ___ Python tracker ___

[issue29526] Documenting format() function

2017-02-10 Thread R. David Murray
R. David Murray added the comment: Serhiy: those are both great ideas. +1 from me too. Then we can even have the date formatting documented without cluttering up the main docstring, if we wish :) The format docstring should then also mention doing help on the __format__ method of concrete t

[issue29526] Documenting format() function

2017-02-10 Thread Hugo Prod'homme
Hugo Prod'homme added the comment: +1 : Adding the reference to help('FORMATTING') will indeed solve all the problems I was thinking about at first. -- I realized I was thinking only about a small part of the problem thanks to your answers. I wasn't even thinking about the dates and other typ

[issue29514] Add a test case that prevents magic number changes in minor releases

2017-02-10 Thread Brett Cannon
Brett Cannon added the comment: Why shouldn't the magic number be bumped when a bug in the bytecode is fixed in a bugfix release? How did this break Fedora? Are you not shipping source code but only .pyc files? I view the whole point of having the magic number is to cover things like this, ot

[issue29523] latest setuptools breaks virtualenvs due to unbundling dependencies

2017-02-10 Thread Charalampos Stratakis
Charalampos Stratakis added the comment: Will send a pull request which includes the extra wheels. -- ___ Python tracker ___ ___ Pytho

[issue29514] Add a test case that prevents magic number changes in minor releases

2017-02-10 Thread Nick Coghlan
Nick Coghlan added the comment: There are a couple of pieces to it: - first, there's the problem of breaking anyone that actually is doing pyc-only distribution, even though nothing in Fedora itself does that. While that aspect doesn't break Fedora per se, it does break Fedora's compatibility

[issue29514] Add a test case that prevents magic number changes in minor releases

2017-02-10 Thread Brett Cannon
Brett Cannon added the comment: OK, but how would you propose to fix broken bytecodes in a bugfix be fixed if you can't bump the magic number? And why aren't you regenerating the bytecode when updating Python or shipping the bytecode with the install (and I bet the answer is "RPM doesn't suppo

[issue29524] Move functions to call objects into a new Objects/call.c file

2017-02-10 Thread STINNER Victor
STINNER Victor added the comment: Serhiy Storchaka added the comment: > I would delay pushing this change until CPython repository be converted to > Git. I heard Git better supports moving a code between files. And perhaps it > might be easier to do this change by several commits -- separately

[issue29524] Move functions to call objects into a new Objects/call.c file

2017-02-10 Thread STINNER Victor
STINNER Victor added the comment: Oh, it's painful to have reviews and comments in two websites. Serhiy left a comment on the review in fact: "Should be added also in PCbuild/pythoncore.vcxproj.filters." -- ___ Python tracker

[issue29481] 3.6.0 doc describes 3.6.1 feature - typing.Deque

2017-02-10 Thread Ivan Levkivskyi
Changes by Ivan Levkivskyi : -- nosy: +levkivskyi ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.

[issue29514] Add a test case that prevents magic number changes in minor releases

2017-02-10 Thread Nick Coghlan
Nick Coghlan added the comment: We *do* ship the bytecode in the built RPMs - the issue is that Python maintenance releases shouldn't be triggering rebuilds of thousands of system components (cf http://fedora.portingdb.xyz/ ) and potentially breaking otherwise working end user applications. A

[issue29514] Add a test case that prevents magic number changes in minor releases

2017-02-10 Thread Nick Coghlan
Nick Coghlan added the comment: Note that Fedora doesn't even rebuild all the extension modules when bumping CPython to a new maintenance release, let alone rebuilding and re-releasing all the pure Python ones. (RPM supports doing that just fine, but it would mean shipping thousands of updated

[issue29524] Move functions to call objects into a new Objects/call.c file

2017-02-10 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: It is hard to make a review of changes of such kind. Common reviewing tools don't help with this. I would suggest you to make a series of commits that move a code from different files after migrating to Git. It may be easier to make a post-commit review. I

[issue29514] Add a test case that prevents magic number changes in minor releases

2017-02-10 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Feb 10, 2017, at 05:46 PM, Nick Coghlan wrote: >Note that Fedora doesn't even rebuild all the extension modules when bumping >CPython to a new maintenance release, let alone rebuilding and re-releasing >all the pure Python ones. (RPM supports doing that just

[issue29514] Add a test case that prevents magic number changes in minor releases

2017-02-10 Thread Petr Viktorin
Petr Viktorin added the comment: > How would you propose to fix broken bytecodes in a bugfix be fixed if you > can't bump the magic number? That would depend on the situation. I can imagine that if the bug is severe enough, the number could be bumped, after careful discussion, and with the ch

[issue29514] Add a test case that prevents magic number changes in minor releases

2017-02-10 Thread Nick Coghlan
Nick Coghlan added the comment: Ah, interesting. The install-time generation case is even trickier, since you presumably can't force in-place regeneration of existing pyc files on systems that previously had 3.5.2 and upgraded to 3.5.3. When I last spoke to Peter about this yesterday, he was e

[issue29514] Add a test case that prevents magic number changes in minor releases

2017-02-10 Thread Petr Viktorin
Petr Viktorin added the comment: According to issue27286, Ubuntu 16.04LTS has the fix and uses the new magic number. (And this is one reason undoing the change in CPython is out of the question.) The patch Nick mentioned is brewing at https://github.com/encukou/cpython/commit/magic-number-wo

[issue29438] use after free in key sharing dict

2017-02-10 Thread INADA Naoki
INADA Naoki added the comment: Since Python 3.5's key sharing dict allows deletion, py35-2.patch is slightly different from py36-2.patch. Since dictresize won't happen in normal (no weakref/__del__ callback) deletion, I removed `CACHED_KEYS(tp) = NULL` entirely. -- Added file: http:/

[issue29438] use after free in key sharing dict

2017-02-10 Thread INADA Naoki
INADA Naoki added the comment: I'll send PR to github. Please continue there. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue29481] 3.6.0 doc describes 3.6.1 feature - typing.Deque

2017-02-10 Thread Terry J. Reedy
Terry J. Reedy added the comment: The online docs are regenerated daily from the current repository, so the inclusion of typing.Deque in the doc is correct, given that it has been added to the module. IDLE aside, new features in bugfix releases are limited to provisional modules, such as typi

[issue29523] latest setuptools breaks virtualenvs due to unbundling dependencies

2017-02-10 Thread Charalampos Stratakis
Charalampos Stratakis added the comment: Second version of the patch: Adjusted the test_ensurepip test cases to account for the new modules -- Added file: http://bugs.python.org/file46627/bundle-setuptools-dependencies2.patch ___ Python tracker

[issue29518] 'for' loop not automatically breaking (index error on line of loop header)

2017-02-10 Thread Ezio Melotti
Changes by Ezio Melotti : -- nosy: +ezio.melotti ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue29505] Submit the re, json, & csv modules to oss-fuzz testing

2017-02-10 Thread Terry J. Reedy
Terry J. Reedy added the comment: It does not appear to me that targets have to be security critical, though that is certainly a good place to start. The Chrome tests found 100s of "security vulnerabilities and stability bugs". The important thing is that there be someone willing to receive a

[issue29511] Add 'find' as build-in method for lists

2017-02-10 Thread Terry J. Reedy
Terry J. Reedy added the comment: Lists, tuples, ranges, dicts, and other builtin collection objects already work with 'in'. >>> 1 in [1,2,3] True >>> 4 in range(9) True For historical reasons, stings have both 'find' and 'index'. The only difference is returning -1 (a C-ism) versus raising

[issue29526] Documenting format() function

2017-02-10 Thread Terry J. Reedy
Terry J. Reedy added the comment: +1 of Serhiy's ideas. I was not aware that FORMATTING had been added. And this could be specifically helpful. >>> help(int.__format__) Help on method_descriptor: __format__(...) default object formatter -- nosy: +terry.reedy ___

[issue29521] Minor warning messages when compiling documentation

2017-02-10 Thread Jim DeLaHunt
Jim DeLaHunt added the comment: My Pull Request was closed, because apparently https://github.com/python/cpython/ will not be the new GitHub repo for Python. The actual repo will open on 11. Feb, I'm told. I will repeat the PR there. Please stand by. -- _

[issue29511] Add 'find' as build-in method for lists

2017-02-10 Thread Steven D'Aprano
Steven D'Aprano added the comment: Terry, I'm not sure if you've read this enhancement request correctly or not, because your reply when closing covers over a lot of detail which is not relevant to this feature request. > Extending this idea to 'subsequence in sequence' or > sequence.index(su

[issue29527] Travis: doc job is broken

2017-02-10 Thread STINNER Victor
New submission from STINNER Victor: I suggest to disable the job until it's fixed, just to fix Travis right now. This issue will track the bug to find a solution. https://travis-ci.org/python/cpython/jobs/200517775 $ make html SPHINXBUILD="./venv/bin/python3 -m sphinx" SPHINXOPTS="-nW -q -b l

  1   2   >