[issue28180] sys.getfilesystemencoding() should default to utf-8

2017-01-06 Thread INADA Naoki
INADA Naoki added the comment: >> stderr is used to log errors. Getting a new error when trying to log >> an error is kind of annoying. > > Hm, what bad surprise/error could appear that would not appear with > backslashescape? $ cat badfilename.py badfn = "こんにちは".encode('euc-jp').decode('utf-8

[issue29182] Remove the warning in urllib docs that it doesn't do certificate validate by default.

2017-01-06 Thread Berker Peksag
Changes by Berker Peksag : -- stage: patch review -> commit review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue29189] Broken indentation in FancyURLopener documentation

2017-01-06 Thread Berker Peksag
New submission from Berker Peksag: I noticed this while taking a look at urllib docs for issue 29182. Indentation of prompt_user_passwd() is broken and it looks like it's part of the note directive: https://docs.python.org/2/library/urllib.html#urllib.FancyURLopener.prompt_user_passwd Python

[issue29189] Broken indentation in FancyURLopener documentation

2017-01-06 Thread Senthil Kumaran
Senthil Kumaran added the comment: The patch looks good to me, and can committed. Thanks! -- ___ Python tracker ___ ___ Python-bugs-li

[issue29189] Broken indentation in FancyURLopener documentation

2017-01-06 Thread Roundup Robot
Roundup Robot added the comment: New changeset 31172ecb9e40 by Berker Peksag in branch '2.7': Issue #29189: Fix broken indentation in FancyURLopener documentation https://hg.python.org/cpython/rev/31172ecb9e40 -- nosy: +python-dev ___ Python tracker

[issue29189] Broken indentation in FancyURLopener documentation

2017-01-06 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the review, Senthil. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue16026] csv.DictReader argument names documented incorrectly

2017-01-06 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patches James and Greg! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 3.5 ___ Python tracker

[issue16026] csv.DictReader argument names documented incorrectly

2017-01-06 Thread Roundup Robot
Roundup Robot added the comment: New changeset 198edd926751 by Berker Peksag in branch '3.6': Issue #16026: Fix parameter names of DictReader and DictWriter https://hg.python.org/cpython/rev/198edd926751 New changeset 63c5531cfdf7 by Berker Peksag in branch 'default': Issue #16026: Merge from 3.

[issue29133] Minor inaccuracy in shlex.shlex punctuation_chars example

2017-01-06 Thread Berker Peksag
Berker Peksag added the comment: I'd probably write it without the for loop: text = "a && b; c && d || e; f >'abc'; (def \"ghi\")" result = shlex.shlex(text) print(f"Old behavior: {list(result)}") result = shlex.shlex(text, punctuation_chars=True) print(f"New behavior: {lis

[issue29190] Avoid possible errors in comparing strings

2017-01-06 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: PyUnicode_Compare() and PyUnicode_RichCompare() can raise an exception if one of arguments is not ready unicode object. The result is not always checked for error. Proposed patch gets rid of possible bugs. PyUnicode_Compare() and PyUnicode_RichCompare() in

[issue29187] Pickle failure is raising AttributeError and not PicklingError

2017-01-06 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Python implementation of pickle still raises PicklingError. Seems this was not intentional change. >>> pickle._dumps(func()()) Traceback (most recent call last): File "/home/serhiy/py/cpython/Lib/pickle.py", line 918, in save_global obj2, parent = _geta

[issue29186] TimeoutError isn't being raised?

2017-01-06 Thread Xiang Zhang
Changes by Xiang Zhang : -- stage: -> resolved ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue29145] failing overflow checks in replace_*

2017-01-06 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: The code in PyUnicode_Join() checks on overflow after making an addition. sz += PyUnicode_GET_LENGTH(item); item_maxchar = PyUnicode_MAX_CHAR_VALUE(item); maxchar = Py_MAX(maxchar, item_maxchar); if (i != 0) sz += se

[issue28647] python --help: -u is misdocumented as binary mode

2017-01-06 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag stage: -> patch review type: -> behavior versions: +Python 3.6, Python 3.7 ___ Python tracker ___ ___

<    1   2