[issue13290] get vars for object with __slots__

2016-12-13 Thread Terry J. Reedy
Terry J. Reedy added the comment: Michelle (maker)'s patch was reviewed by Serhiy and Richard in msg171867 and following. It appears that stage should be 'needs revised patch'. -- ___ Python tracker _

[issue28966] Menu.add_checkbutton has no checkmark on OS X

2016-12-13 Thread Victor Sergienko
New submission from Victor Sergienko: On Linux, this code toggles the checkmark on a checkbutton in right-click menu. On OS X 10.12 it doesn't. OS X 10.12, python 3.6.0b4. #!/usr/bin/env python3 import tkinter as tk class NodePopup(tk.Menu): def __init__(self, master): super().__

[issue28956] return minimum of modes for a multimodal distribution instead of raising a StatisticsError

2016-12-13 Thread Steven D'Aprano
Steven D'Aprano added the comment: On Tue, Dec 13, 2016 at 10:08:10AM +, Srikanth Anantharam wrote: > Please see the updated pull request PR 50, with the changes. I'm rejecting that pull request. As I said, mode() intentionally returns only the single, unique mode. I may add a more advanced

[issue28956] return minimum of modes for a multimodal distribution instead of raising a StatisticsError

2016-12-13 Thread Steven D'Aprano
Steven D'Aprano added the comment: On Tue, Dec 13, 2016 at 10:17:21AM +, Srikanth Anantharam wrote: > > Srikanth Anantharam added the comment: > > @steven: > > data = [1, 2, 3, 4, 4, 4, 5, 6, 7, 7, 8, 8, 8, 8, 8, 8, 8, 9, 9] > is clearly unimodal with mode 8 > > data would have been bimod

[issue28966] Menu.add_checkbutton has no checkmark on OS X

2016-12-13 Thread Ned Deily
Ned Deily added the comment: I'm not totally sure what behavior you expect but it *seems* to work OK for me using the current Python 3.5.2 or the pre-release 3.6.0rc1 from python.org OS X installers and with current ActiveTcl 8.5.18 installed as suggested (https://www.python.org/download/mac/t

[issue28961] unittest.mock._Call ignores `name` parameter

2016-12-13 Thread Jiajun Huang
Jiajun Huang added the comment: Thanks for reply :) the patch has been uploaded. -- keywords: +patch Added file: http://bugs.python.org/file45883/mock_class_call.patch ___ Python tracker ___

[issue28959] Add a macro for dict size

2016-12-13 Thread INADA Naoki
INADA Naoki added the comment: I didn't know about PyObject_VAR_HEAD much. The comment of the macro says: /* PyObject_VAR_HEAD defines the initial segment of all variable-size * container objects. These end with a declaration of an array with 1 * element, but enough space is malloc'ed so that

[issue28961] unittest.mock._Call ignores `name` parameter

2016-12-13 Thread Jiajun Huang
Jiajun Huang added the comment: update the patch file follow the doc(https://docs.python.org/devguide/gitdevs.html) -- Added file: http://bugs.python.org/file45884/mock.patch ___ Python tracker ___

[issue26110] Speedup method calls 1.2x

2016-12-13 Thread INADA Naoki
INADA Naoki added the comment: I'm working on changing stack layout slightly current patch: callable | NULL | arg1 | ...argN next patch will: NULL | callable | arg1 | ...argN After benchmark with PGO build, I'll post it. -- ___ Python tracker

[issue26110] Speedup method calls 1.2x

2016-12-13 Thread INADA Naoki
INADA Naoki added the comment: I haven't noticed the patch is committed already. Changing stack layout slightly is for easy to document, not for performance. Please don't close this issue until adding document in Doc/library/dis.rst -- ___ Python tra

[issue28950] regrtest: -j0 fails the check -j is not allowed together with -T/-l

2016-12-13 Thread Xiang Zhang
Xiang Zhang added the comment: Thanks for your review kumaar.nd. :-) As for your suggestion, in this case adding can not be any harder than replacing. And the old cases could represent the truth value. -- ___ Python tracker

[issue28959] Add a macro for dict size

2016-12-13 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: list doesn't end with array too, but uses PyObject_VAR_HEAD. tp_itemsize is 0, therefore no additional space at the end is allocated. Maybe this is overuse of PyObject_VAR_HEAD. -- ___ Python tracker

[issue28961] unittest.mock._Call ignores `name` parameter

2016-12-13 Thread Jiajun Huang
Jiajun Huang added the comment: The new patch has been updated. :) -- Added file: http://bugs.python.org/file45885/mock.patch ___ Python tracker ___ _

[issue28967] copy.copy fails on threading.local subclass

2016-12-13 Thread Jelle Zijlstra
New submission from Jelle Zijlstra: Calling copy.copy on a threading.local subclass copies attributes over correctly in Python 2.7, but creates an empty object in Python 3.3-3.5 and fails with a pickle-related error in 3.6. Marking this as a release blocker and assigning to Ned because this ap

[issue26110] Speedup method calls 1.2x

2016-12-13 Thread INADA Naoki
Changes by INADA Naoki : Added file: http://bugs.python.org/file45888/patched.json.gz ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue26110] Speedup method calls 1.2x

2016-12-13 Thread INADA Naoki
INADA Naoki added the comment: PGO benchmark result https://gist.github.com/methane/64ab60c38324423ef27af70cc6db1dfd -- Added file: http://bugs.python.org/file45887/default.json.gz ___ Python tracker __

[issue28967] copy.copy fails on threading.local subclass

2016-12-13 Thread Jelle Zijlstra
Jelle Zijlstra added the comment: This might be due to issue22995. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubsc

[issue26110] Speedup method calls 1.2x

2016-12-13 Thread INADA Naoki
INADA Naoki added the comment: This patch modify stack layout slightly and adds document in Doc/library/dis.rst -- Added file: http://bugs.python.org/file45889/callmethod-doc.patch ___ Python tracker __

[issue28967] copy.copy fails on threading.local subclass

2016-12-13 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: copy.copy() didn't work correctly with threading.local in 3.x. It just silently created an empty instance (even not properly initialized, since __init__ is bypassed). Now it correctly raises TypeError. copy.copy() looks working in 2.7 because it copied the i

[issue5322] Python 2.6 object.__new__ argument calling autodetection faulty

2016-12-13 Thread Roundup Robot
Roundup Robot added the comment: New changeset 5315db3171b0 by Benjamin Peterson in branch '2.7': revert a37cc3d926ec (#5322) https://hg.python.org/cpython/rev/5315db3171b0 -- ___ Python tracker

<    1   2