[issue26741] subprocess.Popen should emit a ResourceWarning in destructor if the process is still running

2016-04-12 Thread Martin Panter
Martin Panter added the comment: I think the basic idea of adding the warning is good. I think this might be a bit like open(closefd=True) and socket.detach(). Normally, it is a bug not to close a file or socket, but the API is flexible and has a way to bypass this. Perhaps the term “daemon”

[issue26745] Redundant code in _PyObject_GenericSetAttrWithDict

2016-04-12 Thread Xiang Zhang
New submission from Xiang Zhang: It seems some code in _PyObject_GenericSetAttrWithDict is not necessary. There is no need to check data descriptor again using PyDescr_IsData. And the second if (f != NULL) {} will never function. -- components: Interpreter Core files: _PyObject_Generic

[issue26404] socketserver context manager

2016-04-12 Thread Roundup Robot
Roundup Robot added the comment: New changeset 5c4303c46a18 by Martin Panter in branch 'default': Issue #26404: Add context manager to socketserver, by Aviv Palivoda https://hg.python.org/cpython/rev/5c4303c46a18 -- nosy: +python-dev ___ Python tracke

[issue26624] Windows hangs in call to CRT setlocale()

2016-04-12 Thread Roundup Robot
Roundup Robot added the comment: New changeset 605fde022b15 by Steve Dower in branch '3.5': Closes #26624: Adds validation of ucrtbase[d].dll version with warning for old versions. https://hg.python.org/cpython/rev/605fde022b15 New changeset 6ff020df61b8 by Steve Dower in branch 'default': Clos

[issue26624] Windows hangs in call to CRT setlocale()

2016-04-12 Thread Roundup Robot
Roundup Robot added the comment: New changeset a352f7e96f85 by Steve Dower in branch 'default': Issue #26624: Adds recommendation to install updates of VS 2015. https://hg.python.org/devguide/rev/a352f7e96f85 -- ___ Python tracker

[issue26491] Defer DECREFs until enum object is in a consistent state for re-entrancy

2016-04-12 Thread Raymond Hettinger
Raymond Hettinger added the comment: Deferring decrefs as late as possible is a good practice, reducing the risk of bugs being introduced later. There have been other places where there were bugs that arose due to premature decreffing. I wrote the original code for enumerate, am the primary m

[issue25942] subprocess.call SIGKILLs too liberally

2016-04-12 Thread Mike Pomraning
Mike Pomraning added the comment: Yes, standard UNIX terminal behavior is to map Ctrl-C to a SIGINT sent to the foreground process group, so that every member of a pipeline (e.g.) or hidden helper children processes can be terminated by the interactive user and have the chance to clean up. Ha

[issue26404] socketserver context manager

2016-04-12 Thread Martin Panter
Martin Panter added the comment: Thanks for the patch Aviv. I made a few minor English grammar etc tweaks in the version I committed, as pointed out in the review comments. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed _

[issue26720] memoryview from BufferedWriter becomes garbage

2016-04-12 Thread Martin Panter
Martin Panter added the comment: The trouble with my original idea is that it is complex to implement, and inconsistent. If you wrote small amounts to your BufferedWriter, you would get a memoryview of bytes that you save for later. If there was a write of a large bytes object, we could pass a

[issue25496] tarfile: Default value for compresslevel is not documented

2016-04-12 Thread Roundup Robot
Roundup Robot added the comment: New changeset b1f3fe320adf by Martin Panter in branch '3.5': Issue #25496: Document compresslevel defaults to 9, by Hamza T Khan https://hg.python.org/cpython/rev/b1f3fe320adf New changeset a04455866ec7 by Martin Panter in branch 'default': Issue #25496: Merge ta

[issue25910] Fixing links in documentation

2016-04-12 Thread Roundup Robot
Roundup Robot added the comment: New changeset 4b65bee79dab by Georg Brandl in branch '2.7': Update susp-ignore file (#25910). https://hg.python.org/cpython/rev/4b65bee79dab -- ___ Python tracker __

[issue26491] Defer DECREFs until enum object is in a consistent state for re-entrancy

2016-04-12 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: This change is not broken. It is just redundant. If you are still inclined to apply this changes, I would suggest to factor out common code in enum_next_long and enum_next. > Oh, this change was not intended. I don't know how it occurred. Any reply changes

[issue26743] Unable to import random with python2.7 on power pc based machine

2016-04-12 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +mark.dickinson, rhettinger, serhiy.storchaka type: crash -> behavior ___ Python tracker ___ __

[issue26745] Redundant code in _PyObject_GenericSetAttrWithDict

2016-04-12 Thread Xiang Zhang
Changes by Xiang Zhang : -- nosy: +benjamin.peterson, pitrou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue26745] Redundant code in _PyObject_GenericSetAttrWithDict

2016-04-12 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue25942] subprocess.call SIGKILLs too liberally

2016-04-12 Thread Martin Panter
Martin Panter added the comment: When no timeout is specified, these are the options as I see them: 1. SIGKILL child immediately on the first KeyboardInterrupt (Victor’s behaviour since 3.3) 2. Give up and leave a zombie after the first KeyboardInterrupt (pre-3.3 behaviour) 3. Wait again aft

[issue26743] Unable to import random with python2.7 on power pc based machine

2016-04-12 Thread Raymond Hettinger
Raymond Hettinger added the comment: That's odd. Try: import math print math.sqrt(2.0) print math Post what you see. -- ___ Python tracker ___

[issue25496] tarfile: Default value for compresslevel is not documented

2016-04-12 Thread Martin Panter
Martin Panter added the comment: Thanks for the patch Hamza -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue26699] locale.str docstring is incorrect: "Convert float to integer"

2016-04-12 Thread Senthil Kumaran
Senthil Kumaran added the comment: Thanks. Fixed in https://hg.python.org/cpython/rev/2b35ef6a9853 https://hg.python.org/cpython/rev/ad5b079565ad https://hg.python.org/cpython/rev/125d27d9cf9b -- nosy: +orsenthil resolution: -> fixed stage: needs patch -> resolved status: open -> close

<    1   2