[issue17445] Handle bytes comparisons in difflib.Differ

2015-04-15 Thread Terry J. Reedy
Terry J. Reedy added the comment: Now the review button appears for the big patch. Lets see if another submission makes it appear for the smaller version. -- ___ Python tracker ___

[issue17445] Handle bytes comparisons in difflib.Differ

2015-04-15 Thread Augie Fackler
Augie Fackler added the comment: Changes to 3.4 aren't going to help Mercurial. Given that bytes formatting is new in 3.5, I won't be attempting a port that supports a version of Python 3 any older than 3.5. At this point, just a difflib.diff_bytes method in 3.5 would be sufficient to satisfy

[issue2292] Missing *-unpacking generalizations

2015-04-15 Thread Neil Girdhar
Changes by Neil Girdhar : Added file: http://bugs.python.org/file39059/starunpack41.diff ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue23883] __all__ lists are incomplete

2015-04-15 Thread Martin Panter
Martin Panter added the comment: Regarding tarfile: Two of the extra errors are documented, so I agree they should be added: * tarfile.StreamError * tarfile.ExtractError However I’m not so sure about main(), TarIter, and the HeaderError subclasses. They aren’t mentioned in the documentation.

[issue22278] urljoin duplicate slashes

2015-04-15 Thread Berker Peksag
Changes by Berker Peksag : -- stage: patch review -> resolved ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue23703] urljoin() with no directory segments duplicates filename

2015-04-15 Thread Roundup Robot
Roundup Robot added the comment: New changeset fc0e79387a3a by Berker Peksag in branch 'default': Issue #23703: Fix a regression in urljoin() introduced in 901e4e52b20a. https://hg.python.org/cpython/rev/fc0e79387a3a -- nosy: +python-dev ___ Python tr

[issue23703] urljoin() with no directory segments duplicates filename

2015-04-15 Thread Berker Peksag
Berker Peksag added the comment: Thanks! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue23971] dict(list) and dict.fromkeys() doesn't account for 2/3 fill ratio

2015-04-15 Thread Larry Hastings
New submission from Larry Hastings: Matt Mackall brought this over to me today. If list "l" has one million pairs and you do dict(l) it creates the dict, then resizes it to a million elements, then starts adding name/value pairs. But since it's sized to a million elements, it gets beyond it

[issue7159] Urllib2 authentication memory.

2015-04-15 Thread R. David Murray
R. David Murray added the comment: Added some review comments. I think the urllib documentation does not really explain how to *use* these classes, and it should, but that is a separate issue. -- ___ Python tracker

[issue18162] Add index attribute to IndexError

2015-04-15 Thread Ofer Schwarz
Changes by Ofer Schwarz : Added file: http://bugs.python.org/file39060/indexerror_all.patch ___ Python tracker ___ ___ Python-bugs-list mailin

[issue6818] remove/delete method for zipfile/tarfile objects

2015-04-15 Thread Dave Sawyer
Dave Sawyer added the comment: The zipfile way to delete or rename would be to just change the index. It really doesn't want to be re-written as it is designed to span disks. Many old versions of files can be scattered within the zip. In addition self-extracting zip files will have executable

[issue7159] Urllib2 authentication memory.

2015-04-15 Thread Akshit Khurana
Akshit Khurana added the comment: Updated patch with review changes -- Added file: http://bugs.python.org/file39062/auth10.patch ___ Python tracker ___ ___

[issue23971] dict(list) and dict.fromkeys() doesn't account for 2/3 fill ratio

2015-04-15 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +rhettinger type: behavior -> performance ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue23903] Generate PC/python3.def by scraping headers

2015-04-15 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-lis

[issue22980] C extension naming doesn't take bitness into account

2015-04-15 Thread Roundup Robot
Roundup Robot added the comment: New changeset 32c24eec035f by Ned Deily in branch 'default': Issues #22980, 23969: For OS X, use PEP 3149-style file names for extension https://hg.python.org/cpython/rev/32c24eec035f -- ___ Python tracker

[issue23969] please set a SOABI for MacOSX

2015-04-15 Thread Matthias Klose
Matthias Klose added the comment: what about iOS? isn't __APPLE__ there defined too? -- ___ Python tracker ___ ___ Python-bugs-list ma

[issue23969] please set a SOABI for MacOSX

2015-04-15 Thread Ned Deily
Ned Deily added the comment: "what about iOS? isn't __APPLE__ there defined too?" It is but we currently don't have any iOS-specific checks snywhere in CPython. I have an additional patch to handle iOS here but I didn't want to break builds until adding full support for iOS as part of Issue23

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

2015-04-15 Thread Christie
Christie added the comment: @r.david.murray and @flipmcf: I've audited all test modules using sys.executable for a starting point, and these tests look like they could benefit from helper methods to invoke python (probably the ones in script_helper, but we may want to create others if the use

[issue23971] dict(list) and dict.fromkeys() doesn't account for 2/3 fill ratio

2015-04-15 Thread Raymond Hettinger
Changes by Raymond Hettinger : -- assignee: -> rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http

[issue23670] Modifications to support iOS as a cross-compilation target

2015-04-15 Thread Matthias Klose
Matthias Klose added the comment: not reviewing everything, but - libffi_ios* will be bitrot. I understand that you'll need an unreleased version, however I would much prefer that any additional patches are added in the repo, and maybe then patching libffi from the iOS build system

[issue1346874] httplib simply ignores CONTINUE

2015-04-15 Thread Martin Panter
Martin Panter added the comment: This seems more like a new feature than a bug fix to me. Currently the behaviour is the same whether “Expect: 100-continue” is requested or not. According to , the client does not have to wait any specific length of

[issue23883] __all__ lists are incomplete

2015-04-15 Thread Joel Taddei
Changes by Joel Taddei : Removed file: http://bugs.python.org/file39051/Issue23883_tarfile_all.patch ___ Python tracker ___ ___ Python-bugs-li

[issue23670] Modifications to support iOS as a cross-compilation target

2015-04-15 Thread Russell Keith-Magee
Russell Keith-Magee added the comment: Hi Matthias: * The libffi situation on iOS is much the same as it is on OS/X - it needs to be pre-generated. This can't be driven by the existing build system - libffi's Makefile requires a separate pre-generation step. There's certainly potential for r

[issue23740] http.client request and send method have some datatype issues

2015-04-15 Thread Martin Panter
Martin Panter added the comment: The priority of file-like objects versus bytes-like and iterable objects should be well defined. See Issue 5038: mmap objects seem to satisfy all three interfaces, but the result may be different depending on the file position. -- _

[issue5038] urrlib2/httplib doesn't reset file position between requests

2015-04-15 Thread Martin Panter
Martin Panter added the comment: Actually, I do not think any “Expect: 100-continue” headers are explicitly sent by the Python standard library. The Python client does not support waiting for a “100 Continue” response; see Issue 1346874. There is Issue 23740 opened about fixing or clarifying t

[issue6818] remove/delete method for zipfile/tarfile objects

2015-04-15 Thread Dave Sawyer
Dave Sawyer added the comment: I can add some more tests to bring up the coverage, but wanted to get reviewer opinion on the direction of this before doing more work. -- hgrepos: +305 Added file: http://bugs.python.org/file39063/zipfile_filter.patch

[issue23935] Clean up Clinic's type expressions of buffers

2015-04-15 Thread Roundup Robot
Roundup Robot added the comment: New changeset 4f74452a11e5 by Larry Hastings in branch 'default': Issue #23935: Argument Clinic's understanding of format units https://hg.python.org/cpython/rev/4f74452a11e5 -- nosy: +python-dev ___ Python tracker

[issue23935] Clean up Clinic's type expressions of buffers

2015-04-15 Thread Larry Hastings
Larry Hastings added the comment: While cleaning this up I noticed that es# and et# should both require "nullable". Fixed that too. I sure hope it's all correct now! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed __

[issue23883] __all__ lists are incomplete

2015-04-15 Thread Joel Taddei
Joel Taddei added the comment: Thanks for the feedback. I was unsure how to proceed with the undocumented items that seemed to be categorized as exported. Thanks for catching ENCODING & *_FORMAT. -- Added file: http://bugs.python.org/file39064/Issue23883_tarfile_all.patch __

[issue23354] Loading 2 GiLOC file which raises exception causes wrong traceback

2015-04-15 Thread Ethan Furman
Ethan Furman added the comment: Considering how rare (hopefully!) files of that size are, I wouldn't be adverse to a "won't fix" resolution. -- ___ Python tracker ___ __

[issue23354] Loading 2 GiLOC file which raises exception causes wrong traceback

2015-04-15 Thread Ethan Furman
Ethan Furman added the comment: Considering how rare (hopefully!) files of that size are, I wouldn't be adverse to a "won't fix" resolution. -- priority: normal -> low ___ Python tracker __

[issue23883] __all__ lists are incomplete

2015-04-15 Thread Martin Panter
Martin Panter added the comment: Oh I see, TarIter is listed underneath a comment saying “Exported Classes”, and main() is listed underneath “exported functions”. If they are indeed meant to be exported, they should probably also be documented. Otherwise, maybe we can just add another comment

[issue23883] __all__ lists are incomplete

2015-04-15 Thread Joel Taddei
Changes by Joel Taddei : Removed file: http://bugs.python.org/file39064/Issue23883_tarfile_all.patch ___ Python tracker ___ ___ Python-bugs-li

[issue23883] __all__ lists are incomplete

2015-04-15 Thread Joel Taddei
Joel Taddei added the comment: Put HeaderError back in and removed the extra XHDTYPE. We can get more input on the type constants as well as the undocumented but exported items. Could just be cleared up with some edits to documentation. -- Added file: http://bugs.python.org/file39065/

[issue13866] {urllib, urllib.parse}.urlencode should not use quote_plus

2015-04-15 Thread Martin Panter
Martin Panter added the comment: New patch looks good. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https

[issue6818] remove/delete method for zipfile/tarfile objects

2015-04-15 Thread Christian Heimes
Christian Heimes added the comment: Around PyCon it might take a little longer than a week. IIRC Ewa does the paper work. She is also on the organizing committee of PyCon. -- ___ Python tracker

[issue23970] Update distutils.msvccompiler for VC14

2015-04-15 Thread Tim Golden
Tim Golden added the comment: Adding Paul Moore as he's essentially the intersection between distutils & Windows -- nosy: +paul.moore ___ Python tracker ___

[issue22848] Subparser help does not respect SUPPRESS argument

2015-04-15 Thread paul j3
paul j3 added the comment: It'll take me a while to work through this proposed patch. My first reaction is that I am uncomfortable with adding an attribute to all parsers just to implement this help feature. For one thing it seems to cross functionality boundaries. I need to review how subp

[issue23967] Make inspect.signature expression evaluation more powerful

2015-04-15 Thread Peter McCormick
Peter McCormick added the comment: This definitely works for the _socket.listen use case! In terms of generating such a signature using Argument Clinic, currently this is required: backlog: int(py_default="builtins.min(SOMAXCONN, 128)", c_default="Py_MIN(SOMAXCONN, 128)") = 000 The atta

<    1   2