[issue23835] configparser does not convert defaults to strings

Changes by Serhiy Storchaka : -- nosy: +lukasz.langa type: crash -> behavior versions: +Python 3.5 ___ Python tracker ___ ___ Python-b

[issue22035] Fatal error in dbm.gdbm

Serhiy Storchaka added the comment: The patch for issue3999 was rejected because Python internal state may be corrupted when the SIGSEGV signal is raised. This is not the case of this issue. gdbm fatal function is called when Python is in consistent state. So we free to use any Python C-API. B

[issue23834] socketmodule.c: add sock_call() to fix how the timeout is recomputed

STINNER Victor added the comment: sock_call-2.patch: add an inner looop in sock_call() to only retry func() when func() is interrupted by a signal. Limit also changes: try to only modify ctx around to call to sock_call(), move back some variables to the parent function. Rename the variable sto

[issue23618] PEP 475: handle EINTR in the socket module (connect)

Roundup Robot added the comment: New changeset 8ec4acfdb851 by Victor Stinner in branch 'default': Issue #23618: Fix EINTR handling on Windows https://hg.python.org/cpython/rev/8ec4acfdb851 -- ___ Python tracker __

[issue23836] PEP 475: Enhance faulthandler to handle better reentrant calls

New submission from STINNER Victor: While working on the PEP 475, I noticed that the faulthandler module doesn't handle well reentrant calls to its signal handlers. If a signal is received while faulthandler is displaying the traceback, faulthandler restarts to display a new traceback (and the

[issue23836] PEP 475: Enhance faulthandler to handle better reentrant calls

Changes by STINNER Victor : Added file: http://bugs.python.org/file38776/traceback_eintr.patch ___ Python tracker ___ ___ Python-bugs-list mai

[issue23836] PEP 475: Enhance faulthandler to handle better reentrant calls

Changes by STINNER Victor : Added file: http://bugs.python.org/file38777/faulthandler_eintr.patch ___ Python tracker ___ ___ Python-bugs-list

[issue23836] PEP 475: Enhance faulthandler to handle better reentrant calls

Changes by STINNER Victor : -- nosy: +neologix ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue23648] PEP 475 meta issue

STINNER Victor added the comment: New issue #23836: Enhance faulthandler to handle better reentrant calls. -- ___ Python tracker ___ _

[issue23648] PEP 475 meta issue

Changes by STINNER Victor : -- dependencies: +PEP 475: Enhance faulthandler to handle better reentrant calls ___ Python tracker ___ __

[issue22035] Fatal error in dbm.gdbm

STINNER Victor added the comment: 2015-04-01 10:39 GMT+02:00 Serhiy Storchaka : > Other external libraries used by the stdlib also can crash, and perhaps > crashes can be converted to exceptions. This issue is only first in the > series. I don't think that it's a good practice to try to workar

[issue23799] Join started threads in tests

Roundup Robot added the comment: New changeset f8358f6e50e7 by Serhiy Storchaka in branch '2.7': Issue #23799: Added test.test_support.start_threads() for running and https://hg.python.org/cpython/rev/f8358f6e50e7 New changeset 8987218adc99 by Serhiy Storchaka in branch '3.4': Issue #23799: Adde

[issue23837] read pipe transport tries to resume reading after loop is gone

New submission from Mathias Fröjdman: Script attached which reproduces the issue. Steps to reproduce: 0) Use python 3.4.3 on Linux. Does not repro with 3.4.0 or 3.4.2. 1) Create a child process with asyncio.create_child_exec and stdout=PIPE 2) loop yield from child.read(n) (i used n=2048, any ot

[issue23838] linecache and MemoryError

New submission from Serhiy Storchaka: When format a traceback of MemoryError, linecache tries to read all lines of source file and likely raises a MemoryError. For example: http://buildbot.python.org/all/builders/x86%20OpenIndiana%203.x/builds/9712/steps/test/logs/stdio Traceback (most recent

[issue23839] Clear caches after every test

New submission from Serhiy Storchaka: Some caches can grow unlimitedly during running the testsuite (in particular linecache). On some machines with limited resources this can cause multiple MemoryErrors. Many of these MemoryErrors can be avoided if clear caches between tests. Lib/test/regrtes

[issue23756] Tighten definition of bytes-like objects

Martin Panter added the comment: After doing a bit of reading and experimenting, I think we should at least restrict bytes-like objects to “C-contiguous”. Any looser definition risks memoryview(byteslike).tobytes() returning the bytes in a different order than their true in-memory order. Fortr

[issue23756] Tighten definition of bytes-like objects

Serhiy Storchaka added the comment: +1 for the idea overall and the patch LGTM. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue23838] linecache and MemoryError

STINNER Victor added the comment: > Proposed patch clears the cache and repeats an attempt to read source file, > and returns empty result if the second attempt fails (as when the source file > can't be read). IMO it's a bad idea. You should not retry an operation on MemoryError but only do y

[issue23840] tokenize.open() leaks an open binary file on TextIOWrapper error

New submission from STINNER Victor: If TextIOWrapper constructor fails in tokenize.open(), the open binary file is not closed and a ResourceWarning is emited. Try attached patch: $ python3 -Wd ~/tokenize_open_bug.py tokenize.open failed: unknown encoding for 'test.py': xxx /home/haypo/tokenize

[issue23840] tokenize.open() leaks an open binary file on TextIOWrapper error

STINNER Victor added the comment: I sent an email to the python core mentorship mailing list to find a volunteer to fix this easy issue. -- ___ Python tracker ___ __

[issue23838] linecache and MemoryError

STINNER Victor added the comment: Serhiy: you look to be interested in fixing Python to not fail badly under low memory condition. You may take a look at #19817 which proposes a function to arbitrary limit the memory allocated to Python. I fixed a lot of issues found by failmalloc, but they ar

[issue23838] linecache and MemoryError

Serhiy Storchaka added the comment: getlines() already returns an empty list on OSError. Clearing the cache on MemoryError will help to avoid other MemoryErrors. And after this there is a large chance the repeated reading will be successful. In any case it wouldn't make worse. If don't change

[issue23841] py34 OrderedDict is using weakref for root reference

New submission from sorin: The standard library implementation of an OrderedDict (which is included in Python 3.4) uses a weakref for the root reference. https://hg.python.org/cpython/file/534b26837a13/Lib/collections/__init__.py#l74 This was reported initially on https://github.com/kennethre

[issue23839] Clear caches after every test

STINNER Victor added the comment: Maybe tests known to fill caches should clear theirself caches at cleanup? Always clearing all caches may have an impact on performances and so makes tests longer. Caches are designed to speedup Python :-) We may add some helper functions in test.support for t

[issue23839] Clear caches after every test

Changes by STINNER Victor : -- nosy: +rbcollins ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue23841] py34 OrderedDict is using weakref for root reference

Changes by Serhiy Storchaka : -- nosy: +rhettinger type: compile error -> behavior ___ Python tracker ___ ___ Python-bugs-list mailing

[issue23838] linecache and MemoryError

STINNER Victor added the comment: 2015-04-01 14:02 GMT+02:00 Serhiy Storchaka : > getlines() already returns an empty list on OSError. Oh, I misread getlines(), you're right. > Clearing the cache on MemoryError will help to avoid other MemoryErrors. And > after this there is a large chance I

[issue12319] [http.client] HTTPConnection.putrequest not support "chunked" Transfer-Encodings to send data

Martin Panter added the comment: The incremental improvement thing sounds good. Here are some things which I think are orthogonal to sensible chunked encoding: * Automagic seeking to determine Content-Length * Setting Content-Length for iterables that are neither strings, iterators nor files (

[issue23841] py34 OrderedDict is using weakref for root reference

Changes by Piotr Dobrogost : -- nosy: +piotr.dobrogost ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue23839] Clear caches after every test

Serhiy Storchaka added the comment: We should try to know how it impacts a performance. I suppose not too much, but may be my intuition lies me. -- ___ Python tracker ___ __

[issue23756] Tighten definition of bytes-like objects

Stefan Krah added the comment: I have a somewhat general concern: In the last year or so, issues seem to expand far beyond the scope that's indicated by the issue title. For example, I don't particularly care about the definition of "bytes-like", but the patch contains changes to areas I *do* ca

[issue23839] Clear caches after every test

STINNER Victor added the comment: By the way, a workaround is also to run each test (file) in a new fresh process. It's a common way to work around memory fragmentation ;-) > On some machines with limited resources this can cause multiple MemoryErrors. Do you have an idea of the memory usage o

[issue9232] Allow trailing comma in any function argument list.

Martin Panter added the comment: Actual post by Raymond: Just noticed there are some arguments for trailing commas in the FAQ:

[issue23838] linecache and MemoryError

Serhiy Storchaka added the comment: OK, here is a patch that just clear the cache and returns an empty result. It is hard to write reliable test, but I think we will see the result on OpenIndiana buildbot. The question is left: should the patch be applied only on 3.5 or all versions?

[issue23839] Clear caches after every test

Serhiy Storchaka added the comment: max_rss is a little larger 500 MB after ran all testsuite (except bigmem tests) on 32-bit Linux. Only few tests needs more than 200 MB. But may be some 64-bit only tests consume more memory. If a test consume more than 1GiB of memory and is not decorated wit

[issue23840] tokenize.open() leaks an open binary file on TextIOWrapper error

Changes by Serhiy Storchaka : -- components: +Library (Lib) stage: -> needs patch type: -> resource usage ___ Python tracker ___ ___

[issue23838] linecache and MemoryError

STINNER Victor added the comment: > It is hard to write reliable test Ah? Why not using something like mock.patch('mock.updatecache', side_effect=MemoryError)? -- ___ Python tracker __

[issue23838] linecache and MemoryError

STINNER Victor added the comment: > The question is left: should the patch be applied only on 3.5 or all versions? linecache_memoryerror_2.patch looks good to me, but it would be better with an unit test. IMO Python 2.7 and 3.4 can be fixed too. -- ___

[issue23838] linecache and MemoryError

Serhiy Storchaka added the comment: This test depends on implementation details. I prefer to avoid adding such tests for trivial changes. -- ___ Python tracker ___ _

[issue23838] linecache and MemoryError

Changes by Serhiy Storchaka : -- type: -> resource usage versions: +Python 2.7, Python 3.4, Python 3.5 ___ Python tracker ___ ___ Pyt

[issue23779] imaplib authenticate raises TypeError if authenticator tries to abort

R. David Murray added the comment: Looks good to me, thanks. -- stage: patch review -> commit review ___ Python tracker ___ ___ Python

[issue23838] linecache and MemoryError

Serhiy Storchaka added the comment: On other side, linecache tests already use updatecache(). Here is a patch with a test. -- Added file: http://bugs.python.org/file38783/linecache_memoryerror_3.patch ___ Python tracker

[issue23838] linecache and MemoryError

STINNER Victor added the comment: linecache_memoryerror_3.patch reviewed (comments on Rietveld). -- ___ Python tracker ___ ___ Python-

[issue23833] email.header.Header folding modifies headers that include semi-colons

R. David Murray added the comment: The header folding algorithm is...not all that smart. There's a better one in the new policies in email in python3, which does not have this problem (it does have a few others, but the plan is to treat them as bugs and fix them :) IMO this isn't worth fixing

[issue2211] Cookie.Morsel interface needs update

R. David Murray added the comment: Heh, I thought it was closed. I guess my eyes were distracted by the 'fixed' resolution. -- ___ Python tracker ___ ___

[issue23824] in-place addition of a shadowed class field

R. David Murray added the comment: And I'm telling you that *this is how Python is designed*, and it is not going to change. Class attributes are *special*, for a reason. Please do not reopen this issue again. If you wish to pursue this further, the language design discussion forum is the py

[issue23484] SemLock acquire() keyword arg 'blocking' is invalid

R. David Murray added the comment: behavior vs enhancment for doc changes is really pretty meaningless/arbitrary, IMO. -- nosy: +r.david.murray ___ Python tracker ___ __

[issue23837] read pipe transport tries to resume reading after loop is gone

STINNER Victor added the comment: Oh, it looks like all pause_reading() and resume_reading() methods of transports check the status the transport (especially the _closing attribute), except two transports: _UnixReadPipeTransport and _SSLProtocolTransport. For _SSLProtocolTransport, I don't thi

[issue23838] linecache and MemoryError

Roundup Robot added the comment: New changeset d96e714a by Serhiy Storchaka in branch '2.7': Issue #23838: linecache now clears the cache and returns an empty result on https://hg.python.org/cpython/rev/d96e714a New changeset 88a0e6cd93c3 by Serhiy Storchaka in branch '3.4': Issue #23838

[issue23821] test_pdb fails under -O

Roundup Robot added the comment: New changeset 26778732099d by Serhiy Storchaka in branch '3.4': Issue #23821: Fixed test_pdb failure under -O. https://hg.python.org/cpython/rev/26778732099d New changeset 23442d957793 by Serhiy Storchaka in branch 'default': Issue #23821: Fixed test_pdb failure

[issue23821] test_pdb fails under -O

Serhiy Storchaka added the comment: Thank you for your review Xavier. -- assignee: -> serhiy.storchaka resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker __

[issue23838] linecache and MemoryError

Serhiy Storchaka added the comment: Thank you for your review Victor. Will look on OpenIndiana buildbot. -- assignee: -> serhiy.storchaka resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue23756] Tighten definition of bytes-like objects

R. David Murray added the comment: Oh, and about the general concern: I agree that this issue was apparently about the glossary entry, so making other changes is suspect and at a minimum requires adding relevant people from the experts list to nosy to get proper review of other proposed change

[issue23756] Tighten definition of bytes-like objects

R. David Murray added the comment: I found the explanation of C-contiguous vs Fortran-contiguous helpful (and I've programmed in both of those languages, though granted not much :). However, based on that it is not obvious to me why having a fortran-contiguous buffer prevents it from being us

[issue23756] Tighten definition of bytes-like objects

Serhiy Storchaka added the comment: What people are needed? The patch looks as great improvement to me. -- ___ Python tracker ___ ___

[issue23756] Tighten definition of bytes-like objects

R. David Murray added the comment: Stefan, since he's the current maintainer of the memoryview implementation. Fortunately he spotted the issue :) Maybe Antoine, too; he's done work in this area. I'll add him. -- nosy: +pitrou ___ Python tracker

[issue23756] Tighten definition of bytes-like objects

Serhiy Storchaka added the comment: See also issue23376. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: htt

[issue23830] Add AF_IUCV support to sockets

Amaury Forgeot d'Arc added the comment: Hi, First, please fill and submit a Contribution Agreement: https://www.python.org/psf/contrib/ Then about the patch: - This is a patch against Python2.7, which is frozen for new developments. This change will only be applied to python 3.5 or later. - Th

[issue23484] SemLock acquire() keyword arg 'blocking' is invalid

Berker Peksag added the comment: I use "enhancement" for non-trivial documentation patches. Also, quoting from https://docs.python.org/devguide/triaging.html#type "Also used for improvements in the documentation and test suite and for other refactorings." In this case, your patch fixes a docu

[issue22117] Rewrite pytime.h to work on nanoseconds

Roundup Robot added the comment: New changeset 65ac8e587bb0 by Victor Stinner in branch 'default': Issue #22117, issue #23485: Fix _PyTime_AsMilliseconds() and https://hg.python.org/cpython/rev/65ac8e587bb0 -- ___ Python tracker

[issue23731] Implement PEP 488

Changes by Brett Cannon : -- hgrepos: +303 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue23731] Implement PEP 488

Changes by Brett Cannon : -- keywords: +patch Added file: http://bugs.python.org/file38785/be7d966b660a.diff ___ Python tracker ___ __

[issue23485] PEP 475: handle EINTR in the select and selectors module

Roundup Robot added the comment: New changeset 65ac8e587bb0 by Victor Stinner in branch 'default': Issue #22117, issue #23485: Fix _PyTime_AsMilliseconds() and https://hg.python.org/cpython/rev/65ac8e587bb0 -- ___ Python tracker

[issue23731] Implement PEP 488

Changes by Brett Cannon : Added file: http://bugs.python.org/file38786/8ce8e9b1f3e7.diff ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue23731] Implement PEP 488

Changes by Brett Cannon : Removed file: http://bugs.python.org/file38785/be7d966b660a.diff ___ Python tracker ___ ___ Python-bugs-list mailing

[issue23731] Implement PEP 488

Brett Cannon added the comment: Here is a patch that implements PEP 488 **except** for Windows installer stuff. I don't think the Windows changes need to block this patch going in, but I will need someone on Windows to help fix up PC/, PCbuild/, Tools/msi, Lib/distutils/command/bdist_msi.py, a

[issue23830] Add AF_IUCV support to sockets

Neale Ferguson added the comment: Thanks. Question/responses in-line On 4/1/15, 11:14 AM, "Amaury Forgeot d'Arc" wrote: > >Amaury Forgeot d'Arc added the comment: > >Hi, >First, please fill and submit a Contribution Agreement: >https://www.python.org/psf/contrib/ Done but I never got the email

[issue23842] SystemError: ../Objects/longobject.c:998: bad argument to internal function

New submission from Matthias Klose: an unreleased version of cinder fails a test when run with python 2.7 from the branch. I don't have a test case yet, but looking at the error message and list of fixed issues after the 2.7.9 release, the fix for issue #23098 could be the culprit. FAIL: ci

[issue23830] Add AF_IUCV support to sockets

Terry J. Reedy added the comment: The CA ack is a * added after your name here. May take a week. If you are asking whether to submit a new patch against 3.5, with suggested fixes, yes, please do . -- nosy: +terry.reedy stage: -> patch review versions: +Python 3.5 -Python 2.7

[issue23842] SystemError: ../Objects/longobject.c:998: bad argument to internal function

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue23842] SystemError: ../Objects/longobject.c:998: bad argument to internal function

STINNER Victor added the comment: > return '%d:%d' % (os.major(st.st_rdev), os.minor(st.st_rdev)) Can you check if the error comes from os.major() or os.minor(), and please provide the value of st_rdev? You can modify the unit test to catch SystemError and raise a new exception with more info

[issue23836] PEP 475: Enhance faulthandler to handle better reentrant calls

Changes by STINNER Victor : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue23836] PEP 475: Enhance faulthandler to handle better reentrant calls

Roundup Robot added the comment: New changeset 60e001ec141d by Victor Stinner in branch 'default': Issue #23836: Add _Py_write_noraise() function https://hg.python.org/cpython/rev/60e001ec141d New changeset d9b9e2a68e7c by Victor Stinner in branch 'default': Issue #23836: Document functions rele

[issue23842] SystemError: ../Objects/longobject.c:998: bad argument to internal function

Matthias Klose added the comment: so the culprit is an "optimization": "Committed to 2.7 with small change: stat() and makedev() should return int instead of long if possible." the test case however expects a long. st_dev is now not always a long, but an int or long depending on the value. -

[issue23796] BufferedReader.peek() crashes if closed

John Hergenroeder added the comment: Thanks for the feedback, Berker! I've added a test case that closes a buffered reader and then attempts to both peek and read1 it. I tacked it onto the end of the BufferedReaderTest class in test_io, but let me know if there's a better place to put it. I'v

[issue23842] SystemError: ../Objects/longobject.c:998: bad argument to internal function

Matthias Klose added the comment: no, simpler: >>> import os >>> os.minor(os.makedev(8,65)) Traceback (most recent call last): File "", line 1, in SystemError: ../Objects/longobject.c:998: bad argument to internal function >>> os.major(os.makedev(8,65)) Traceback (most recent call last): Fi

[issue23842] SystemError: ../Objects/longobject.c:998: bad argument to internal function

Matthias Klose added the comment: casting to a long works ... >>> os.major(long(os.makedev(8,65))) 8 so maybe revert that optimization for the released branches? -- ___ Python tracker

[issue23842] SystemError: ../Objects/longobject.c:998: bad argument to internal function

Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue23842] SystemError: ../Objects/longobject.c:998: bad argument to internal function

Changes by Matthias Klose : -- nosy: +benjamin.peterson priority: normal -> release blocker ___ Python tracker ___ ___ Python-bugs-lis

[issue23843] ssl.wrap_socket doesn't handle virtual TLS hosts

New submission from John Nagle: ssl.wrap_socket() always uses the SSL certificate associated with the raw IP address, rather than using the server_host feature of TLS. Even when wrap_socket is used before calling "connect(port, host)", the "host" parameter isn't used by TLS. To get proper TLS

[issue6766] Cannot modify dictionaries inside dictionaries using Managers from multiprocessing

Changes by Dan O'Reilly : -- nosy: +dan.oreilly versions: +Python 3.3 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscr

[issue23731] Implement PEP 488

Steve Dower added the comment: I don't actually see any essential changes. The bdist_wininst and bdist_msi changes are just for usage help, and presumably they'll go from "do not compile .py to .pyo (optimized)" to "do not compile .py to optimized .pyc". I'd prefer to leave the .pyo file assoc

[issue23830] Add AF_IUCV support to sockets

Neale Ferguson added the comment: Updated patch - Removes tabs - Strips name/user/node returned by connect - Checks lengths of name/user/node -- Added file: http://bugs.python.org/file38788/af_iucv.patch ___ Python tracker

[issue23588] Errno conflicts in ssl.SSLError

John Nagle added the comment: If SSL error reporting is getting some attention, something should be done to provide better text messages for the SSL errors. All certificate verify exceptions return the string "certificate verify failed (_ssl.c:581)". The line number in _ssl.c is not particula

[issue23830] Add AF_IUCV support to sockets

Neale Ferguson added the comment: Corrected a length error in the strip routine Initialized the end of string indicator -- Added file: http://bugs.python.org/file38789/af_iucv.patch ___ Python tracker _

[issue23731] Implement PEP 488

Paul Moore added the comment: A few minor review comments. Nothing substantial, tbh. Looks good. -- ___ Python tracker ___ ___ Python-

[issue23796] BufferedReader.peek() crashes if closed

STINNER Victor added the comment: John Hergenroeder added the comment: > my assumption is that a 0-length read on a closed BufferReader should fail, > not return an empty bytestring. I agree. -- ___ Python tracker

[issue23842] SystemError: ../Objects/longobject.c:998: bad argument to internal function

STINNER Victor added the comment: Obviously, an unit test is missing ;) -- ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue23842] SystemError: ../Objects/longobject.c:998: bad argument to internal function

Serhiy Storchaka added the comment: Oh, this is a catch when backport to 2.7. Here is a patch that makes dev_t converter to support int and int-like types. Added tests (surprisingly there were no tests for makedev/major/minor at all). > so maybe revert that optimization for the released branch

[issue23842] SystemError: ../Objects/longobject.c:998: bad argument to internal function

Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list ma

[issue23834] socketmodule.c: add sock_call() to fix how the timeout is recomputed

Roundup Robot added the comment: New changeset 358a2bcd0d0b by Victor Stinner in branch 'default': Issue #23834: Add sock_call() helper function https://hg.python.org/cpython/rev/358a2bcd0d0b -- nosy: +python-dev ___ Python tracker

[issue23839] Clear caches after every test

Robert Collins added the comment: I'd like to see a definite profile of a bloated stdlib test process before we assume we know the issue - the usual leak I see in test code is used test objects, and I'm not sure we've ported the usual fix for that into unittest yet (we should). As far as line

[issue23839] Clear caches after every test

Robert Collins added the comment: +1 on moving to the summary classes rather than actual tracebacks in unittest. (Or perhaps even just serialised tracebacks like we do in testtools). -- ___ Python tracker

[issue23844] test_ssl: fails on recent libressl version with BAD_DH_P_LENGTH

New submission from Cédric Krier: Since [1], libressl fails if DH keys are too small (<1024). Here is a patch to increase the dh keys to 1024 for the tests. [1] http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/lib/libssl/src/ssl/s3_clnt.c?rev=1.108&content-type=text/x-cvsweb-markup -- file

[issue23840] tokenize.open() leaks an open binary file on TextIOWrapper error

shiyao.ma added the comment: ITSM it's not the TextIOWrapper but the detect_encoding fails and throws an error. So I wrapped a try/catch block around that. -- keywords: +patch nosy: +introom Added file: http://bugs.python.org/file38792/tokenize.patch __

[issue23840] tokenize.open() leaks an open binary file on TextIOWrapper error

Matt Chung added the comment: Comparing to introom. Any reason to not wrap the entire in a try? Attached patch. -- nosy: +itsmemattchung Added file: http://bugs.python.org/file38793/issue23840.patch ___ Python tracker

[issue23834] socketmodule.c: add sock_call() to fix how the timeout is recomputed

Roundup Robot added the comment: New changeset b3c7ae99b8e0 by Victor Stinner in branch 'default': Issue #23834: Modify socket.sendall() to reuse sock_call() with https://hg.python.org/cpython/rev/b3c7ae99b8e0 -- ___ Python tracker

[issue23840] tokenize.open() leaks an open binary file on TextIOWrapper error

Matt Chung added the comment: Curious, @haypo, are you looking for a new unittest or a function within an existing unit test? Perhaps go under TestTokenize? 1227 def test_main(): 1228 from test import test_tokenize 1229 support.run_doctest(test_tokenize, True) 1230 support.run_uni

[issue23756] Tighten definition of bytes-like objects

Martin Panter added the comment: I will to pull the stdtypes.rst changes out into a separate patch and issue, if that will make review easier. I think they are an improvement because the previous version was incorrect and misleading, but they are probably not necessary for people to understand

[issue23840] tokenize.open() leaks an open binary file on TextIOWrapper error

Matt Chung added the comment: I believe it goes here under the TestTokenize class. Going to give it a shot now. -- ___ Python tracker ___ ___

  1   2   >