[issue23708] PEP 475: Add _Py_read() and _Py_write() functions

2015-03-19 Thread STINNER Victor
STINNER Victor added the comment: I commited both patches. Thanks Antoine for the review of py_read_write-2.patch, I removed the commented assertion. -- resolution: -> fixed status: open -> closed ___ Python tracker

[issue23539] Content-length not set for HTTP methods expecting body when body is None

2015-03-19 Thread James Rutherford
James Rutherford added the comment: Updated 2.7 patch attached. -- Added file: http://bugs.python.org/file38570/issue23539-py27.patch ___ Python tracker ___ _

[issue23707] PEP 475: os.urandom() doesn't handle EINTR correctly

2015-03-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset e57b4d464d1c by Victor Stinner in branch 'default': Issue #23707: On UNIX, os.urandom() now calls the Python signal handler when https://hg.python.org/cpython/rev/e57b4d464d1c -- nosy: +python-dev ___ Pyt

[issue23709] Refactor ossaudiodev: use _Py_read and _Py_write with the Py_buffer

2015-03-19 Thread STINNER Victor
Changes by STINNER Victor : -- nosy: +neologix, pitrou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue23707] PEP 475: os.urandom() doesn't handle EINTR correctly

2015-03-19 Thread STINNER Victor
Changes by STINNER Victor : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue23700] tempfile.NamedTemporaryFile can close too early if used as iterator

2015-03-19 Thread STINNER Victor
STINNER Victor added the comment: test_csv now fails on Windows: http://buildbot.python.org/all/builders/x86 Windows7 3.x/builds/9421/ == ERROR: test_read_dict_fieldnames_from_file (test.test_csv.TestDictFields) ---

[issue23708] PEP 475: Add _Py_read() and _Py_write() functions

2015-03-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset 116e4c40115f by Victor Stinner in branch 'default': Issue #23708: Fix _Py_read() compilation error on Windows https://hg.python.org/cpython/rev/116e4c40115f -- ___ Python tracker

[issue23712] Experiment: Assume that exact unicode hashes are perfect discriminators

2015-03-19 Thread Donald Stufft
Donald Stufft added the comment: I'm not sure what you mean by "Siphash isn't cryptographically secure". One of the key points of Siphash is that it *is* cryptographically secure. It has a smaller space than your typical hash function (MD5, SHA1, SHA2, etc) which means that collisions themselv

[issue23646] PEP 475: handle EINTR in the time module, retry sleep()

2015-03-19 Thread STINNER Victor
Changes by STINNER Victor : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue23712] Experiment: Assume that exact unicode hashes are perfect discriminators

2015-03-19 Thread Donald Stufft
Donald Stufft added the comment: To be clear, I have no opinion on your specific proposal and I don't know if the difference between "cryptographically secure" and "not cryptographically secure" matters for it. I just wanted to be clear that with SipHash an attacker should *not* be able to cho

[issue16834] ioctl mutate_flag behavior in regard to the buffer size limit

2015-03-19 Thread Martin Panter
Martin Panter added the comment: Looking at the C code, if a writable buffer is passed, mutate_arg is false, and the buffer is longer than 1024 bytes, then a ValueError is raised: >>> ioctl(0, 0, bytearray(2048), False) Traceback (most recent call last): File "", line 1, in ValueError: ioctl

[issue23632] memoryview doesn't allow tuple-indexing

2015-03-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset 7d4eb5902f82 by Antoine Pitrou in branch 'default': Issue #23632: Memoryviews now allow tuple indexing (including for multi-dimensional memoryviews). https://hg.python.org/cpython/rev/7d4eb5902f82 -- nosy: +python-dev _

[issue23632] memoryview doesn't allow tuple-indexing

2015-03-19 Thread Antoine Pitrou
Antoine Pitrou added the comment: I didn't add the 2d example as the double cast is quite ugly. Probably we should allow casting when the format stays the same. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Pyth

[issue23686] Update Windows and OS X installer OpenSSL to 1.0.2a

2015-03-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset 447794596266 by Ned Deily in branch '2.7': Issue #23686: Update OS X 10.5 installer build to use OpenSSL 1.0.2a. https://hg.python.org/cpython/rev/447794596266 New changeset 59b8a83ea50b by Ned Deily in branch '3.4': Issue #23686: Update OS X 10.5 i

[issue23686] Update Windows and OS X installer OpenSSL to 1.0.2a

2015-03-19 Thread Ned Deily
Ned Deily added the comment: 1.0.2a is now available. https://www.openssl.org/source/openssl-1.0.2a.tar.gz The OS X 10.5 installer builds are now updated. Leaving the issue open for updates to the Windows installers. -- ___ Python tracker

[issue23709] Refactor ossaudiodev: use _Py_read and _Py_write with the Py_buffer

2015-03-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset d564695b67bb by Victor Stinner in branch 'default': Issue #23709: The ossaudiodev module now retries read/write when interrupted by https://hg.python.org/cpython/rev/d564695b67bb -- nosy: +python-dev ___

[issue23709] Refactor ossaudiodev: use _Py_read and _Py_write with the Py_buffer

2015-03-19 Thread STINNER Victor
STINNER Victor added the comment: I commited changes to use _Py_read() and _Py_write(). I attach an updated patch to use Py_ssize_t instead of int, and to use Py_buffer instead of char*. -- Added file: http://bugs.python.org/file38571/ossaudiodev-py_buffer.patch __

[issue23648] PEP 475 meta issue

2015-03-19 Thread STINNER Victor
STINNER Victor added the comment: unittest_setitimer.patch: hack unittest.TestCase.run() to inject signals every 1 ms, send the first signal in 100 ms. It should help to detect functions which doesn't retry on EINTR. -- keywords: +patch Added file: http://bugs.python.org/file38572/unit

[issue23711] ConfigParser module blames on section less ini file

2015-03-19 Thread Martin Panter
Martin Panter added the comment: I think this is already discussed in Issue 22253. -- nosy: +vadmium resolution: -> duplicate status: open -> closed superseder: -> ConfigParser does not handle files without sections ___ Python tracker

[issue23042] ctypes module doesn't build on FreeBSD x86

2015-03-19 Thread Davin Potts
Davin Potts added the comment: Inheriting the priority from issue22634 which has been marked closed->duplicate (duplicate of this issue). Previously issue22634 was given a priority of "release blocker" by @pitrou. Issue22634 described how this issue also afflicts 32-bit builds on multiple RH

[issue23342] run() - unified high-level interface for subprocess

2015-03-19 Thread Martin Panter
Martin Panter added the comment: One thing that just popped into my mind that I don’t think has been discussed: The patch adds the new run() function to subprocess.__all__, but the CompletedProcess class is still missing. Was that an oversight or a conscious decision? --

[issue23703] urljoin() with no directory segments duplicates filename

2015-03-19 Thread Demian Brecht
Demian Brecht added the comment: Yep, that's a lot cleaner and tests pass. I've updated the patch with that line. Thanks. -- Added file: http://bugs.python.org/file38573/issue23703_1.patch ___ Python tracker _

[issue23342] run() - unified high-level interface for subprocess

2015-03-19 Thread Thomas Kluyver
Thomas Kluyver added the comment: Thanks, that was an oversight. Patch 5 adds CompletedProcess to __all__. -- Added file: http://bugs.python.org/file38574/subprocess_run5.patch ___ Python tracker __

[issue23496] Steps for Android Native Build of Python 3.4.2

2015-03-19 Thread Ryan Gonzalez
Changes by Ryan Gonzalez : Added file: http://bugs.python.org/file38576/kbox_fix.patch ___ Python tracker ___ ___ Python-bugs-list mailing lis

[issue23496] Steps for Android Native Build of Python 3.4.2

2015-03-19 Thread Ryan Gonzalez
Changes by Ryan Gonzalez : Added file: http://bugs.python.org/file38577/issue_16353.patch ___ Python tracker ___ ___ Python-bugs-list mailing

[issue23496] Steps for Android Native Build of Python 3.4.2

2015-03-19 Thread Ryan Gonzalez
Ryan Gonzalez added the comment: I am slowly attaching the patches I created. Titles: - issue_16353.patch - Issue 16353 for tip - issue_20305_tweaked.patch - Issue 2305 for tip - rjmatthews62_fixes_tweaked.patch - rjmatthew...@gmail.com's Android fixes (a bit more modularized) - unused_var.pat

[issue23496] Steps for Android Native Build of Python 3.4.2

2015-03-19 Thread Ryan Gonzalez
Changes by Ryan Gonzalez : Added file: http://bugs.python.org/file38578/issue_20305_tweaked.patch ___ Python tracker ___ ___ Python-bugs-list

[issue23496] Steps for Android Native Build of Python 3.4.2

2015-03-19 Thread Ryan Gonzalez
Changes by Ryan Gonzalez : Added file: http://bugs.python.org/file38579/issue_20306.patch ___ Python tracker ___ ___ Python-bugs-list mailing

[issue23496] Steps for Android Native Build of Python 3.4.2

2015-03-19 Thread Ryan Gonzalez
Changes by Ryan Gonzalez : Added file: http://bugs.python.org/file38580/issue_21668.patch ___ Python tracker ___ ___ Python-bugs-list mailing

[issue23496] Steps for Android Native Build of Python 3.4.2

2015-03-19 Thread Ryan Gonzalez
Changes by Ryan Gonzalez : Added file: http://bugs.python.org/file38581/unused_var.patch ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue23496] Steps for Android Native Build of Python 3.4.2

2015-03-19 Thread Ryan Gonzalez
Changes by Ryan Gonzalez : Added file: http://bugs.python.org/file38582/rjmatthews62_fixes_tweaked.patch ___ Python tracker ___ ___ Python-bug

[issue23712] Experiment: Assume that exact unicode hashes are perfect discriminators

2015-03-19 Thread Josh Rosenberg
Josh Rosenberg added the comment: Assuming Siphash is in fact cryptographically secure (in the sense you can't choose a desired result hash with better odds that brute force), and it appears to be so, with a keyspace of 64 bits, if it's evenly distributed (which a cryptographically secure hash

[issue23539] Content-length not set for HTTP methods expecting body when body is None

2015-03-19 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue23646] PEP 475: handle EINTR in the time module, retry sleep()

2015-03-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset 9882cc2efd36 by Victor Stinner in branch 'default': Issue #23646: Enhance precision of time.sleep() and socket timeout when https://hg.python.org/cpython/rev/9882cc2efd36 -- ___ Python tracker

[issue23715] PEP 475: signal.sigtimedwait() must retry if sigtimedwait() failed with EINTR

2015-03-19 Thread STINNER Victor
New submission from STINNER Victor: Attached patch changes signal.sigtimedwait() to retry if sigtimedwait() failed with EINTR and the signal handler didn't raise an exception. -- files: sigtimedwait_eintr.patch keywords: patch messages: 238595 nosy: haypo priority: normal severity: norm

[issue23715] PEP 475: handle EINTR in the signal module

2015-03-19 Thread STINNER Victor
STINNER Victor added the comment: It looks like signal.sigwaitinfo() can also fail with InterruptedError. It should also be modified. -- title: PEP 475: signal.sigtimedwait() must retry if sigtimedwait() failed with EINTR -> PEP 475: handle EINTR in the signal module _

[issue23648] PEP 475 meta issue

2015-03-19 Thread STINNER Victor
STINNER Victor added the comment: New issue #23715: handle EINTR in the signal module. -- dependencies: +PEP 475: handle EINTR in the signal module ___ Python tracker ___ ___

[issue23001] Accept mutable bytes-like objects

2015-03-19 Thread Martin Panter
Martin Panter added the comment: I had a closer look at the changes, and most of them seem good. However I think I found one leak in fcntl(); see Reitveld. I noticed there is no test for “ossaudiodev”. Would that be too hard, or is it just an oversight? -- ___

[issue23646] PEP 475: handle EINTR in the time module, retry sleep()

2015-03-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset 1291649f38df by Victor Stinner in branch 'default': Issue #23646: Fix test_threading on Windows https://hg.python.org/cpython/rev/1291649f38df -- ___ Python tracker __

[issue23716] test_multiprocessing_spawn hangs on x86 Ubuntu Shared 3.x

2015-03-19 Thread STINNER Victor
New submission from STINNER Victor: It looks like the changeset 0b99d7043a99 (issue #23694) introduced a regression: http://buildbot.python.org/all/builders/x86%20Ubuntu%20Shared%203.x/builds/11358/ [340/393] test_multiprocessing_spawn Timeout (1:00:00)! Thread 0x55aacdc0 (most recent call firs

[issue23716] test_multiprocessing_spawn hangs on x86 Ubuntu Shared 3.x

2015-03-19 Thread STINNER Victor
STINNER Victor added the comment: Oops, I posted the output of http://buildbot.python.org/all/builders/x86%20Ubuntu%20Shared%203.x/builds/11359/steps/test/logs/stdio -- Other output: http://buildbot.python.org/all/builders/x86%20Ubuntu%20Shared%203.x/builds/11358/steps/test/logs/stdio [131/3

[issue22832] Tweak parameter names for fcntl module

2015-03-19 Thread Martin Panter
Changes by Martin Panter : -- nosy: +vadmium ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue23171] csv.writer.writerow() does not accept generator (must be coerced to list)

2015-03-19 Thread Martin Panter
Changes by Martin Panter : -- nosy: +vadmium ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue21802] Reader of BufferedRWPair is not closed if writer's close() fails

2015-03-19 Thread Martin Panter
Changes by Martin Panter : -- nosy: +vadmium ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue23681] Have -b warn when directly comparing ints and bytes

2015-03-19 Thread Martin Panter
Changes by Martin Panter : -- nosy: +vadmium ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue23676] Add support of UnicodeTranslateError in standard error handlers

2015-03-19 Thread Martin Panter
Changes by Martin Panter : -- nosy: +vadmium ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue22831] Use "with" to avoid possible fd leaks

2015-03-19 Thread Martin Panter
Changes by Martin Panter : -- nosy: +vadmium ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue15133] tkinter.BooleanVar.get() behavior and docstring disagree

2015-03-19 Thread Martin Panter
Changes by Martin Panter : -- nosy: +vadmium ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue22831] Use "with" to avoid possible fd leaks

2015-03-19 Thread Berker Peksag
Berker Peksag added the comment: Looks good. A couple of comments: * Doc/includes/email-* changes have already been committed. * There is a commented-out line in Tools/scripts/nm2def.py: -f.close() +# f.close() * The patch is huge, I'd commit Tools/ and Lib/test/ parts separately.

[issue22826] Support context management protocol in bkfile

2015-03-19 Thread Berker Peksag
Changes by Berker Peksag : -- assignee: -> serhiy.storchaka stage: patch review -> commit review ___ Python tracker ___ ___ Python-bu

[issue2211] Cookie.Morsel interface needs update

2015-03-19 Thread Demian Brecht
Demian Brecht added the comment: The attached patch reverts back to the old set() API, ignoring the parameter and adding a deprecation warning. I've also added a few versionchanged and deprecated tags in the Morsel docs. Other than the deprecation note in whatsnew/3.5.rst that was added, I'm n

[issue17535] IDLE: Add an option to show line numbers along the left side of the editor window, and have it enabled by default.

2015-03-19 Thread irdb
Changes by irdb : -- nosy: +irdb ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailma

[issue23539] Content-length not set for HTTP methods expecting body when body is None

2015-03-19 Thread Demian Brecht
Demian Brecht added the comment: One super minor comment left in Rietveld (py3 patch). Otherwise LGTM. -- ___ Python tracker ___ ___ P

[issue12006] strptime should implement %G, %V and %u directives

2015-03-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: The patch is synchronized with the tip, added the versionadded directives and whatsnews entry, addressed sasha's comment on Rietveld. Fixed a bug: %a and %A now are interchangeable with %u as well as with %w. I don't understand what more test are needed. Exi

[issue23700] tempfile.NamedTemporaryFile can close too early if used as iterator

2015-03-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Following patch fixes the issue, but I don't understand why. -- Added file: http://bugs.python.org/file38586/tempfile_iter_fix.patch ___ Python tracker __

[issue23001] Accept mutable bytes-like objects

2015-03-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you for your review Martin. Yes, the problem with fcntl() is not so easy and I'll left it for the separate issue. > I noticed there is no test for “ossaudiodev”. Would that be too hard, or is > it just an oversight? It is hard because test_ossaudiodev

<    1   2