[issue20780] Shadowed (duplicate name but different body) test in test_statistics

Mark Lawrence added the comment: @Steven would you like to formally review the patch please. At a very quick glance it looks okay to me. -- nosy: +BreamoreBoy ___ Python tracker __

[issue23521] OverflowError from timedelta * float in datetime.py

Alexander Belopolsky added the comment: > the bug in C implementation should be fixed. In the past (see #8860) we were not able to reach a consensus on which behavior is correct and which has a bug: >>> timedelta(seconds=1)*0.6112295 datetime.timedelta(0, 0, 611229) >>> timedelta(seconds=0.611

[issue20780] Shadowed (duplicate name but different body) test in test_statistics

Benjamin Peterson added the comment: The duplicate tests have been renamed already. -- nosy: +benjamin.peterson resolution: -> out of date status: open -> closed ___ Python tracker

[issue21293] Remove "capsule hack" from object.c?

Mark Lawrence added the comment: I've taken a bit of a liberty and picked the names of the last three guys who've worked on this file as I assume they're best qualified to comment. -- nosy: +BreamoreBoy, haypo, ncoghlan, pitrou ___ Python tracker

[issue23516] pip: urllib3 does not encode userinfo section of requests: parse_url() mishandles special characters when the URL specifies authentication credentials

Demian Brecht added the comment: FWIW, setting up a local authenticated (ncsa_auth) squid proxy, this breaks using pip 0.6.8: pip --proxy http://special:my?password@localhost:3128 install While the percent-encoded version is successful: pip --proxy http://special:my%3Fpassword@localhost:3128

[issue23521] OverflowError from timedelta * float in datetime.py

Alexander Belopolsky added the comment: I eliminated floating point arithmetics from the calculation completely and it now matches C. -- Added file: http://bugs.python.org/file38236/issue23521-3.patch ___ Python tracker

[issue23516] pip: urllib3 does not encode userinfo section of URL with authentication credentials

Changes by Demian Brecht : -- status: pending -> open title: pip: urllib3 does not encode userinfo section of requests: parse_url() mishandles special characters when the URL specifies authentication credentials -> pip: urllib3 does not encode userinfo section of URL with authenticatio

[issue23521] OverflowError from timedelta * float in datetime.py

Brian Kearns added the comment: Maybe we should also use divide_and_round for __truediv__ to match the C implementation calling divide_nearest there as well? -- ___ Python tracker _

[issue23521] OverflowError from timedelta * float in datetime.py

Alexander Belopolsky added the comment: > Maybe we should also use divide_and_round for __truediv__ You mean in timedelta / float case, right? You are probably right, but can you provide a test case in which it matters? -- ___ Python tracker

[issue23521] OverflowError from timedelta * float in datetime.py

Brian Kearns added the comment: td = timedelta(seconds=1) print(td / (1/0.6112295)) -- ___ Python tracker ___ ___ Python-bugs-list mai

[issue23521] OverflowError from timedelta * float in datetime.py

Alexander Belopolsky added the comment: >>> td = timedelta(seconds=1) >>> print(td / (1/0.6112295)) 0:00:00.611229 What is wrong with this answer? It is the same as in >>> print(td * 0.6112295) 0:00:00.611229 -- ___ Python tracker

[issue23521] OverflowError from timedelta * float in datetime.py

Alexander Belopolsky added the comment: I've got it: >>> import sys >>> sys.modules['_datetime'] = None >>> from datetime import * >>> td = timedelta(seconds=1) >>> print(td / (1/0.6112295)) 0:00:00.611230 -- ___ Python tracker

[issue23521] OverflowError from timedelta * float in datetime.py

Alexander Belopolsky added the comment: Fixed truediv in issue23521-4.patch. -- Added file: http://bugs.python.org/file38237/issue23521-4.patch ___ Python tracker ___ ___

[issue20703] RuntimeError caused by lazy imports in pdb

Josh Rosenberg added the comment: Is this worth fixing? Delve into the innards and you get weird behaviors. If you really need to iterate sys.modules (the example clearly doesn't, but that doesn't mean no one would), you could just copy the parts you need beforehand to get a consistent view, e

[issue20936] test_strftime: enormous allocation, fails under Clang sanitizer

Alexander Belopolsky added the comment: Can someone provide instructions for compiling python with AddressSanitizer? My naive attempt to run ./configure CC="clang -fsanitize=address" did not work. -- nosy: +belopolsky ___ Python tracker

[issue23523] cmath.atanh has wrong output

New submission from 夏熙临: When I was using cmath.atanh, I found that this function generates wrong output. For example: >>> import cmath >>> cmath.atanh(-1.89) (-0.5888951591901462+1.5707963267948966j) However, the correct output should be: (-0.5888951591901462-1.5707963267948966j) Clearly, th

[issue23523] cmath.atanh has wrong output

Changes by Ezio Melotti : -- nosy: +ezio.melotti, mark.dickinson, rhettinger, stutzbach ___ Python tracker ___ ___ Python-bugs-list ma

[issue6549] ttk.Style -- minor issues with element_names and configure

Ethan Furman added the comment: Redid patch against current branch, fixing the typos I had in them. Any reason not to move forward? -- nosy: +serhiy.storchaka Added file: http://bugs.python.org/file38238/issue6549.stoneleaf.01.patch ___ Python tracke

[issue23254] Document how to close the TCPServer listening socket

Demian Brecht added the comment: Left a couple small nitpicks in Rietveld. Otherwise LGTM. -- nosy: +demian.brecht ___ Python tracker ___

[issue23387] test_urllib2 fails with HTTP Error 502: Bad Gateway

Demian Brecht added the comment: LGTM -- nosy: +demian.brecht stage: patch review -> commit review ___ Python tracker ___ ___ Python-b

[issue20408] memoryview() constructor documentation error

Mark Lawrence added the comment: I think it's plain daft having "object" as a keyword argument. Is it too late to do anything about this, or could we go through a deprecation period, or what? -- nosy: +BreamoreBoy versions: +Python 3.5 -Python 3.3 _

[issue21889] https://docs.python.org/2/library/multiprocessing.html#process-and-exceptions doesn't explain exception

Mark Lawrence added the comment: What is "exception multiprocessing.BufferTooShort" at the bottom of the referenced section? -- nosy: +BreamoreBoy ___ Python tracker ___ ___

[issue23382] Maybe can not shutdown ThreadPoolExecutor when call the method of shutdown

Mark Lawrence added the comment: @Miles could you provide the code changes as a unified diff file, and if needed any changes to the test code as well, thanks. -- components: +Library (Lib) -2to3 (2.x to 3.x conversion tool) nosy: +BreamoreBoy type: -> behavior versions: +Python 2.7, Py

[issue18382] multiprocessing's overlapped PipeConnection issues on Windows 8

Steve Dower added the comment: Thanks Davin. I got onto a Windows 8 machine and confirmed the behaviour changed there, so the version check in my patch is correct. Anyone opposed to the extra logic and version check? -- ___ Python tracker

[issue23451] Deprecation warnings building 3.5 Visual Studio Windows 8.1 64 bit

Steve Dower added the comment: Anyone got a chance to double-check my patch for me? I think it's fine, unless someone really wants me to turn all the "#ifdef CMSG_LEN" checks into "#ifdef HAVE_CMSG" (which I *think* would require autoconf updates, which I am totally unqualified to do...)

[issue23523] cmath.atanh has wrong output

Benjamin Peterson added the comment: Both are correct, since atanh requires a branch cut. -- nosy: +benjamin.peterson resolution: -> not a bug status: open -> closed ___ Python tracker

[issue15955] gzip, bz2, lzma: add option to limit output size

Nikolaus Rath added the comment: Martin, I'll try to review your GzipFile patch. But maybe it would make sense to open a separate issue for this? I think the LZMAFile patch has not yet been reviewed or committed, and we probably want a patch for BZ2File too. The review page is already pretty

[issue23524] Use _set_thread_local_invalid_parameter_handler in posixmodule

New submission from Steve Dower: (Now that VS 2015 CTP 6 is public, here's the second half of #23314.) In posixmodule.c is a big section with the following comment: /* Microsoft CRT in VS2005 and higher will verify that a filehandle is * valid and raise an assertion if it isn't. * Normally, a

[issue23524] Use _set_thread_local_invalid_parameter_handler in posixmodule

Changes by Steve Dower : Added file: http://bugs.python.org/file38239/23524_1.patch ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue23525] isbuiltin, isroutine, etc.

New submission from Andrew Barnert: The documentation and implementation for `inspect.isbuiltin` and related functions do not match. While #4968 attempted to clarify things to make the documentation match the behavior, the actual committed changes are still wrong. `isbuiltin` says "Return true

[issue23510] multiprocessing bug SyncManager and 'with'

Davin Potts added the comment: I have a working patch that addresses this behavior and tests to go along with it but am still working on updating the docs. Updating the docs in 2.7 in a way to as closely match the docs in 3.4/3.5 as possible seems reasonable. It remains unclear why __enter__

[issue23521] OverflowError from timedelta * float in datetime.py

Serhiy Storchaka added the comment: Added comments on Rietveld. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscrib

[issue23526] Silence resource warnings in test_httplib

New submission from Alex Shkop: Three resource warnings are present in test_httplib. Patch closes HTTPSConnection in test_networked_noverification, test_networked_trusted_by_default_cert, test_networked_good_cert. -- components: Tests files: test_httplib_warnings.patch keywords: patch m

[issue20408] memoryview() constructor documentation error

Demian Brecht added the comment: > Oddly, memoryview accepts keyword arguments (for its one required value), and > the name of the argument is "object", not "obj". Positional parameters can also be treated as named arguments. > I think it's plain daft having "object" as a keyword argument. Tr

<    1   2