[issue22637] avoid using a shell in uuid: replce os.popen with subprocess.Popen

2014-10-15 Thread STINNER Victor
STINNER Victor added the comment: Arfrever wrote me on IRC: > Your patch for issue #22637 has print(executable) Ooops. Updated patch without the print. -- Added file: http://bugs.python.org/file36930/uuid_popen-2.patch ___ Python tracker

[issue22627] Calling timestamp() on a datetime object modifies the timestamp of a different datetime object.

2014-10-15 Thread Antoine Pitrou
Antoine Pitrou added the comment: Christopher, I've already pointed out a fix in another message: just remove ".replace(tzinfo=None)". Doing computations on UTC datetimes (rather than naive) should ensure you don't encounter any ambiguities. -- resolution: -> not a bug status: open ->

[issue21338] Silent mode for compileall

2014-10-15 Thread Roundup Robot
Roundup Robot added the comment: New changeset 34436ae65523 by Berker Peksag in branch 'default': Issue #21338: Add silent mode for compileall. https://hg.python.org/cpython/rev/34436ae65523 -- nosy: +python-dev ___ Python tracker

[issue21338] Silent mode for compileall

2014-10-15 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch, Thomas. -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue22638] ssl module: the SSLv3 protocol is vulnerable ("POODLE" attack)

2014-10-15 Thread Antoine Pitrou
Antoine Pitrou added the comment: Matthew Green posted a nice explanation of the attack: http://blog.cryptographyengineering.com/2014/10/attack-of-week-poodle.html In short, currently it requires injection of code into the "browser" (i.e. SSL client) to be exploitable. While that's easy on the

[issue22640] Add silent mode for py_compile

2014-10-15 Thread Berker Peksag
New submission from Berker Peksag: This is similar to issue 21338. It would be good to add a new option "-q" to the CLI interface and add a new parameter "quiet" to py_compile.compile() (e.g. if doraise is False and quiet is True, do not print anything). -- assignee: berker.peksag com

[issue22638] ssl module: the SSLv3 protocol is vulnerable ("POODLE" attack)

2014-10-15 Thread Antoine Pitrou
Antoine Pitrou added the comment: Hmm... of course, stdlib servers don't use create_stdlib_context() in 2.7. We'll have to do it by hand :) -- ___ Python tracker ___ ___

[issue22638] ssl module: the SSLv3 protocol is vulnerable ("POODLE" attack)

2014-10-15 Thread Cory Benfield
Cory Benfield added the comment: > I don't believe it's in OpenSSL though. There's an outstanding OpenSSL patch: http://marc.info/?l=openssl-dev&m=141333049205629&w=2 However, as Donald has pointed out, this is really only meaningful for servers and co-operating clients. It's not a useful pan

[issue3068] IDLE - Add an extension configuration dialog

2014-10-15 Thread Terry J. Reedy
Terry J. Reedy added the comment: This version only allows configuration of default configuration. Added sections (for added extensions) are ignored. That will be a future enhancement. Patch 5 makes changes in load_extensions and set_user_value so that var strings are compared to saved defau

[issue22631] Feature Request CAN_RAW_FD_FRAMES

2014-10-15 Thread Stefan Tatschner
Changes by Stefan Tatschner : -- title: Feature Request CAN_RAW_FD_FRAME -> Feature Request CAN_RAW_FD_FRAMES ___ Python tracker ___ _

[issue21991] The new email API should use MappingProxyType instead of returning new dicts.

2014-10-15 Thread Stéphane Wirtel
Stéphane Wirtel added the comment: Tell me if you will review this patch and maybe accept it ;-) In fact I checked all the return keywords in the email library and I didn't find any other copy of a dict. This is the reason why I am dubious about my patch ;-) -- __

[issue3068] IDLE - Add an extension configuration dialog

2014-10-15 Thread Terry J. Reedy
Terry J. Reedy added the comment: Patch 5 was missing the last change. Ignore it unless here is a problem with 5a -- Added file: http://bugs.python.org/file36932/cfg-ext-34-5a.diff ___ Python tracker ___

[issue22237] sorted() docs should state that the sort is stable

2014-10-15 Thread Mark Dickinson
Mark Dickinson added the comment: > when I grep the code, I don't find it The non-greppability is due to preprocessor evil. The culprit is this macro from Include/object.h: #define _Py_IDENTIFIER(varname) _Py_static_string(PyId_##varname, #varname) along with the declaration _Py_IDENTIFI

[issue22237] sorted() docs should state that the sort is stable

2014-10-15 Thread Stéphane Wirtel
Stéphane Wirtel added the comment: Hi Mark, Without your explanation, I was really lost. Thank you. -- ___ Python tracker ___ ___ Py

[issue22638] ssl module: the SSLv3 protocol is vulnerable ("POODLE" attack)

2014-10-15 Thread Antoine Pitrou
Antoine Pitrou added the comment: Update on 2.7: - there are no SSL servers in the stdlib (ha) - SSL clients don't do any auto-downgrading so it's not obvious we should patch something (if people choose to pass PROTOCOL_SSLv3, it's their problem). Update on 3.4: - the only SSL server in the st

[issue20386] socket.SocketType enum overwrites import of _socket.SocketType

2014-10-15 Thread Berker Peksag
Berker Peksag added the comment: + self.assertTrue(socket.SocketType is _socket.socket) You can use assertIs instead of assertTrue. -- nosy: +berker.peksag versions: +Python 3.5 ___ Python tracker

[issue22638] ssl module: the SSLv3 protocol is vulnerable ("POODLE" attack)

2014-10-15 Thread Martin Richard
Changes by Martin Richard : -- nosy: +martius ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue22237] sorted() docs should state that the sort is stable

2014-10-15 Thread Stéphane Wirtel
Stéphane Wirtel added the comment: My patch for the documentation of Python 3.5, just need a small feedback. If you agree with this patch, I will provide the same patch for 2.7 and 3.4 Thank you -- keywords: +patch Added file: http://bugs.python.org/file36933/issue22237.patch

[issue13236] unittest needs more flush calls

2014-10-15 Thread Stéphane Wirtel
Stéphane Wirtel added the comment: ping about this bug, do you have the same problem with the last version of Python 3.4 and with Python 2.7.8 ? -- nosy: +matrixise ___ Python tracker _

[issue17095] Modules/Setup *shared* support broken

2014-10-15 Thread Stéphane Wirtel
Stéphane Wirtel added the comment: Hi Ned, What are the news for this issue? -- nosy: +matrixise ___ Python tracker ___ ___ Python-bu

[issue11844] Update json to upstream simplejson latest release

2014-10-15 Thread Stéphane Wirtel
Stéphane Wirtel added the comment: Hi all, ping this issue for Python 3.5. -- nosy: +matrixise ___ Python tracker ___ ___ Python-bugs

[issue21991] The new email API should use MappingProxyType instead of returning new dicts.

2014-10-15 Thread Berker Peksag
Changes by Berker Peksag : -- stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue22638] ssl module: the SSLv3 protocol is vulnerable ("POODLE" attack)

2014-10-15 Thread Christian Heimes
Christian Heimes added the comment: There is no need for a "_create_stdlib_server_context()" function. _create_stdlib_context() takes a purpose argument, too. -- ___ Python tracker

[issue21991] The new email API should use MappingProxyType instead of returning new dicts.

2014-10-15 Thread Stéphane Wirtel
Changes by Stéphane Wirtel : Removed file: http://bugs.python.org/file36915/issue21991.patch ___ Python tracker ___ ___ Python-bugs-list maili

[issue22641] Use better default context in asyncio

2014-10-15 Thread Antoine Pitrou
New submission from Antoine Pitrou: asyncio is not yet bound by legacy use cases, so this patch switches asyncio to stronger default SSL settings for client connections. It also adds tests for that (the code path was untested). -- components: Library (Lib), asyncio files: asyncio_defau

[issue21991] The new email API should use MappingProxyType instead of returning new dicts.

2014-10-15 Thread Stéphane Wirtel
Stéphane Wirtel added the comment: New version of the patch -- Added file: http://bugs.python.org/file36935/issue21991.patch ___ Python tracker ___ __

[issue21991] The new email API should use MappingProxyType instead of returning new dicts.

2014-10-15 Thread Stéphane Wirtel
Stéphane Wirtel added the comment: sorry, but how to update a patch without losing the rietveld review? Is there a documentation about that? Thanks. Stephane -- ___ Python tracker ___

[issue22641] Use better default context in asyncio

2014-10-15 Thread Antoine Pitrou
Changes by Antoine Pitrou : Removed file: http://bugs.python.org/file36934/asyncio_default_context.patch ___ Python tracker ___ ___ Python-bug

[issue22641] Use better default context in asyncio

2014-10-15 Thread Antoine Pitrou
Changes by Antoine Pitrou : Added file: http://bugs.python.org/file36936/asyncio_default_context.patch ___ Python tracker ___ ___ Python-bugs-

[issue11844] Update json to upstream simplejson latest release

2014-10-15 Thread Antoine Pitrou
Antoine Pitrou added the comment: Development of simplejson and the standard json module has diverged. We may port selected fixes and features from simplejson, but I don't think a wholesale update is doable anymore. Please open separate issues for each feature you would like to see added to th

[issue22634] importing _ctypes failed: undefined symbol: ffi_call_win32

2014-10-15 Thread Matthias Klose
Matthias Klose added the comment: could somebody attach a build log from such a system? and the libffi config.log? -- ___ Python tracker ___ _

[issue22634] importing _ctypes failed: undefined symbol: ffi_call_win32

2014-10-15 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: +larry priority: normal -> release blocker versions: +Python 3.5 ___ Python tracker ___ ___ Pytho

[issue19450] Bug in sqlite in Windows binaries

2014-10-15 Thread Marc Schlaich
Marc Schlaich added the comment: I've now run various and partially complex applications including SQLAlchemy against SQLite 3.8.1 for months without having any issues. Right now I have run extensive database test suites against the current SQLite release 3.8.6 without any issues, too. So I w

[issue20386] socket.SocketType enum overwrites import of _socket.SocketType

2014-10-15 Thread koobs
koobs added the comment: This change looks to be implicated in a buildbot breakage on koobs-freebsd9 (3.4). I couldn't reproduce the test failure by re-running the build, so possibly intermittent or non-deterministic. Full build log attached. I'll leave the issue closed for now, please re-op

[issue19450] Bug in sqlite in Windows binaries

2014-10-15 Thread Antoine Pitrou
Antoine Pitrou added the comment: Steve is responsible for the Windows builds, but he always answered to your request above. -- nosy: +pitrou ___ Python tracker ___

[issue22638] ssl module: the SSLv3 protocol is vulnerable ("POODLE" attack)

2014-10-15 Thread Donald Stufft
Donald Stufft added the comment: I really don't think it's unreasonable to say "SSL 3.0 is insecure, if you rely on it then you need to pass this flag to use it". Passing a flag to do something insecure is hardly onerous. -- ___ Python tracker

[issue19450] Bug in sqlite in Windows binaries

2014-10-15 Thread Mark Lawrence
Mark Lawrence added the comment: A work around is already given in msg201796 and is reinforced by this https://mail.python.org/pipermail/python-list/2014-October/679369.html -- nosy: +zach.ware ___ Python tracker

[issue6171] IDLE - Class Browser selection in Ubuntu

2014-10-15 Thread Vandana Rao
Vandana Rao added the comment: This issue doesn't describe the above situation on Ubuntu 14.04. I use IDLE 3.4.0 and Python 3.4.0. When the Class browser is opened and if the function name or class name is double clicked, it highlights the corresponding section in the editor. It's perfectly wor

[issue21991] The new email API should use MappingProxyType instead of returning new dicts.

2014-10-15 Thread STINNER Victor
STINNER Victor added the comment: > sorry, but how to update a patch without losing the rietveld review? I see 3 patch sets at: http://bugs.python.org/review/21991/ No review is lost when you remove a patch. But it's better to attach a new patch with a different name. I like the name pattern:

[issue21991] The new email API should use MappingProxyType instead of returning new dicts.

2014-10-15 Thread STINNER Victor
STINNER Victor added the comment: issue21991.patch looks good to me. I didn't check if more methos should be modified. David knows that better than me :-) -- ___ Python tracker

[issue22638] ssl module: the SSLv3 protocol is vulnerable ("POODLE" attack)

2014-10-15 Thread STINNER Victor
STINNER Victor added the comment: I read the table explaining how SSL/TLS is negociated between the client and the server: https://docs.python.org/2.7/library/ssl.html#ssl.wrap_socket I don't understand how I can ask to "use TLS, prefer the most recent version, but don't use SSL"? Should I use

[issue22517] BufferedRWpair doesn't clear weakrefs

2014-10-15 Thread paul
paul added the comment: Why did the type changed from security to crash? -- ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue22638] ssl module: the SSLv3 protocol is vulnerable ("POODLE" attack)

2014-10-15 Thread Donald Stufft
Donald Stufft added the comment: The naming of SSLv23 is sort of unfortunate, that will negotiate the highest version of SSL 2.0, SSL 3.0, TLS 1.0, TLS 1.1, TLS 1.2 that both the client and the server support. You can modify the list of what protocols are supported using the ssl.OP_NO_* flags.

[issue22638] ssl module: the SSLv3 protocol is vulnerable ("POODLE" attack)

2014-10-15 Thread Ismail Donmez
Ismail Donmez added the comment: FWIW OpenSSL patch is now upstream https://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff;h=cf6da05304d554aaa885151451aa4ecaa977e601 https://git.openssl.org/gitweb/?p=openssl.git;a=commitdiff;h=fb0e87fb67a358b40a1d56d2df3a611a09899780 -- nosy: +cart

[issue22642] trace module: unclear error message

2014-10-15 Thread Giampaolo Rodola'
New submission from Giampaolo Rodola': $ python3.4 -m trace -l Traceback (most recent call last): File "/usr/local/lib/python3.4/runpy.py", line 170, in _run_module_as_main "__main__", mod_spec) File "/usr/local/lib/python3.4/runpy.py", line 85, in _run_code exec(code, run_globals)

[issue21991] The new email API should use MappingProxyType instead of returning new dicts.

2014-10-15 Thread R. David Murray
R. David Murray added the comment: Personally I would test that the returned object is read only, rather than checking for MappingProxyType explicitly, but you can argue either way as being better :) As for other occurrences, I must have been either misremembering, or I refactored the other o

[issue22445] Memoryviews require more strict contiguous checks then necessary

2014-10-15 Thread Antoine Pitrou
Antoine Pitrou added the comment: Is this related to the NPY_RELAXED_STRIDES_CHECKING compilation flag? -- nosy: +pitrou ___ Python tracker ___ __

[issue22638] ssl module: the SSLv3 protocol is vulnerable ("POODLE" attack)

2014-10-15 Thread Antoine Pitrou
Antoine Pitrou added the comment: Le 15/10/2014 14:03, STINNER Victor a écrit : > > create_default_context() uses PROTOCOL_SSLv23 with OP_NO_SSLv2 and OP_NO_SSLv3. I don't understand: we ask to use "SSL version 2 or 3" but we disable SSLv2 and SSLv3? PROTOCOL_SSLv23 is badly named (blame OpenSS

[issue17884] Try to reuse stdint.h types like int32_t

2014-10-15 Thread Alexander Belopolsky
Changes by Alexander Belopolsky : -- nosy: +belopolsky ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue22638] ssl module: the SSLv3 protocol is vulnerable ("POODLE" attack)

2014-10-15 Thread Antoine Pitrou
Antoine Pitrou added the comment: Le 15/10/2014 13:07, Donald Stufft a écrit : > > I really don't think it's unreasonable to say "SSL 3.0 is insecure, > if you rely on it then you need to pass this flag to use it". Passing a flag to do something insecure is hardly onerous. Your position is well

[issue9034] datetime module should use int32_t for date/time components

2014-10-15 Thread Alexander Belopolsky
Alexander Belopolsky added the comment: See also #17884. -- dependencies: +Try to reuse stdint.h types like int32_t ___ Python tracker ___

[issue22634] importing _ctypes failed: undefined symbol: ffi_call_win32

2014-10-15 Thread Siming Yuan
Siming Yuan added the comment: make log from RHEL 6.4 for python 3.4.2. Also got this on the STDERR: $ make > ../make.log build/temp.linux-x86_64-3.4/opt/python-3.4.2/Python-3.4.2/Modules/_ctypes/libffi/src/x86/ffi.o: In function `ffi_prep_closure_loc': /opt/python-3.4.2/Python-3.4.2/Modules/_

[issue22634] importing _ctypes failed: undefined symbol: ffi_call_win32

2014-10-15 Thread Siming Yuan
Siming Yuan added the comment: attached python 3.4.2 configure log on RHEL6.4 -- Added file: http://bugs.python.org/file36938/configure.log ___ Python tracker ___ ___

[issue22634] importing _ctypes failed: undefined symbol: ffi_call_win32

2014-10-15 Thread Siming Yuan
Siming Yuan added the comment: configure arguments: BASECFLAGS=-m32 LDFLAGS=-m32 CFLAGS=-m32 ./configure --prefix=/opt/python-3.4.2/ > ../configure.log attached system rpm information. no additional binaries/PATHs/LD_LIB_PATHs -- Added file: http://bugs.python.org/file36940/rpm.log _

[issue22641] Use better default context in asyncio

2014-10-15 Thread Guido van Rossum
Guido van Rossum added the comment: LGTM. Thanks! -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue22634] importing _ctypes failed: undefined symbol: ffi_call_win32

2014-10-15 Thread Matthias Klose
Matthias Klose added the comment: > checking build system type... x86_64-unknown-linux-gnu > checking host system type... x86_64-unknown-linux-gnu and using -m32 explicitly. so you'll get what you deserve ;-) -- ___ Python tracker

[issue21991] The new email API should use MappingProxyType instead of returning new dicts.

2014-10-15 Thread STINNER Victor
STINNER Victor added the comment: > Personally I would test that the returned object is read only I agree: write a short helper to check that modifying the dict fails. -- ___ Python tracker ___

[issue22634] importing _ctypes failed: undefined symbol: ffi_call_win32

2014-10-15 Thread Siming Yuan
Siming Yuan added the comment: [siyuan@siyuan-lnx:siyuan-ott]$ lsb_release -a LSB Version: :base-4.0-amd64:base-4.0-noarch:core-4.0-amd64:core-4.0-noarch:graphics-4.0-amd64:graphics-4.0-noarch:printing-4.0-amd64:printing-4.0-noarch Distributor ID: RedHatEnterpriseWorkstation Description:

[issue22639] test "test_bad_address" fails on Python 3.4.2 under Linux Mint 13 Maya

2014-10-15 Thread Steve P
Steve P added the comment: I saw that issue, or one like it. I was very tempted to not report but the README says if there are any test failures, there is a problem. (I suppose it could mean there is a problem with my ISP, not python.) The dilemma is that we want to be able to count on a c

[issue22643] Integer overflow in case_operation

2014-10-15 Thread paul
New submission from paul: Crashes python 3.4.1. # Objects\unicodeobject.c # # static PyObject * # case_operation(PyObject *self, #Py_ssize_t (*perform)(int, void *, Py_ssize_t, Py_UCS4 *, Py_UCS4 *)) # { # PyObject *res = NULL; # Py_ssize_t length, newlength = 0; #

[issue22641] Use better default context in asyncio

2014-10-15 Thread Roundup Robot
Roundup Robot added the comment: New changeset c2ccbcd11d47 by Antoine Pitrou in branch '3.4': Issue #22641: In asyncio, the default SSL context for client connections is now created using ssl.create_default_context(), for stronger security. https://hg.python.org/cpython/rev/c2ccbcd11d47 New ch

[issue22641] Use better default context in asyncio

2014-10-15 Thread Antoine Pitrou
Antoine Pitrou added the comment: Ok, I've now pushed it to 3.4 and 3.5. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue17884] Try to reuse stdint.h types like int32_t

2014-10-15 Thread Antoine Pitrou
Antoine Pitrou added the comment: I'm in favour of trying this in 3.5. A platform not supporting those types would not be able to run a lot of contemporary software, I think. -- nosy: +pitrou stage: -> patch review type: -> enhancement versions: +Python 3.5 -Python 3.4 __

[issue22643] Integer overflow in case_operation

2014-10-15 Thread STINNER Victor
Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue22643] Integer overflow in case_operation

2014-10-15 Thread STINNER Victor
Changes by STINNER Victor : -- components: +Unicode nosy: +ezio.melotti ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue22643] Integer overflow in case_operation

2014-10-15 Thread Ezio Melotti
Changes by Ezio Melotti : -- nosy: +benjamin.peterson, serhiy.storchaka type: security -> crash ___ Python tracker ___ ___ Python-bugs

[issue13236] unittest needs more flush calls

2014-10-15 Thread Antoine Pitrou
Antoine Pitrou added the comment: And if the issue still holds, please provide a patch adding the appropriate flush() calls. -- nosy: +pitrou ___ Python tracker ___

[issue22592] Drop support of Borland C compiler

2014-10-15 Thread STINNER Victor
STINNER Victor added the comment: It looks like Larry Hastings supports indirectly this issue :-) "We still have #ifdef's for Borland C--I'd be very surprised if anyone was compiling Python 3 with Borland C." https://mail.python.org/pipermail/python-dev/2014-October/136626.html --

[issue22592] Drop support of Borland C compiler

2014-10-15 Thread Antoine Pitrou
Antoine Pitrou added the comment: I don't know how reliable that Web site is, but apparently it may still be used for education: http://borlandc.org/ -- nosy: +mark.dickinson, pitrou ___ Python tracker ___

[issue22644] Update Windows installers to OpenSSL 1.0.1j

2014-10-15 Thread Alex Gaynor
New submission from Alex Gaynor: https://www.openssl.org/news/secadv_20141015.txt -- components: Extension Modules keywords: security_issue messages: 229462 nosy: alex, christian.heimes, dstufft, giampaolo.rodola, janssen, pitrou, steve.dower, tim.golden, zach.ware priority: normal seve

[issue19450] Bug in sqlite in Windows binaries

2014-10-15 Thread Marc Schlaich
Marc Schlaich added the comment: Yes, but this is no practical solution. Telling *all* my clients to update the sqlite3.dll after *every* Python update is just not feasible and will just not work out in practice. What would be the required steps to update the *.dll in the build? Just update

[issue19450] Bug in sqlite in Windows binaries

2014-10-15 Thread Antoine Pitrou
Antoine Pitrou added the comment: The main risk is if SQLite 3.8 changes some behaviours compared to older versions. This is why we generally choose to only apply bugfix releases of external libraries in our owbn bugfix branches. The question is whether this issue can be worked around without

[issue22645] Unable to install Python 3.4.2 amd64 on Windows 8.1 Update 1

2014-10-15 Thread Zac Greve
New submission from Zac Greve: I am unable to install Python 3.4.2 amd64 on Windows as the installer exits with an error stating that it cannot run a required program. -- components: Windows messages: 229465 nosy: Zac.Greve priority: normal severity: normal status: open title: Unable to

[issue22645] Unable to install Python 3.4.2 amd64 on Windows 8.1 Update 1

2014-10-15 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: +steve.dower, tim.golden, zach.ware ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue22645] Unable to install Python 3.4.2 amd64 on Windows 8.1 Update 1

2014-10-15 Thread Ezio Melotti
Ezio Melotti added the comment: Can you copy the exact error that you got? Have you tried redownloading it, and/or checking with a different version (x86 or Python 3.3)? Do you have admin privileges on your account? -- nosy: +ezio.melotti ___ Python

[issue22643] Integer overflow in case_operation

2014-10-15 Thread Roundup Robot
Roundup Robot added the comment: New changeset 449b1f427cc7 by Benjamin Peterson in branch '3.3': fix integer overflow in unicode case operations (closes #22643) https://hg.python.org/cpython/rev/449b1f427cc7 New changeset 570e70252d5d by Benjamin Peterson in branch '3.4': merge 3.3 (#22643) htt

[issue19450] Bug in sqlite in Windows binaries

2014-10-15 Thread Marc Schlaich
Marc Schlaich added the comment: Well, OSX release ships with 3.8.3.1, too: https://hg.python.org/cpython/file/2.7/Mac/BuildScript/build-installer.py#l290 -- ___ Python tracker

[issue19450] Bug in sqlite in Windows binaries

2014-10-15 Thread Antoine Pitrou
Antoine Pitrou added the comment: As I said, I think it's really Steve's choice here (as long as he is doing the Windows release builds). -- ___ Python tracker ___ _

[issue22643] Integer overflow in case_operation

2014-10-15 Thread STINNER Victor
STINNER Victor added the comment: Benjamin, could you please first propose a patch for review instead of commiting directly your change? Especially for security related changes. +if (length > PY_SSIZE_T_MAX / 3 || +length > PY_SIZE_MAX / (3 * sizeof(Py_UCS4))) { +PyErr_SetSt

[issue22643] Integer overflow in case_operation

2014-10-15 Thread STINNER Victor
STINNER Victor added the comment: Other changesets related to this issue: changeset: 93071:6a91e616485a branch: 3.3 parent: 93068:449b1f427cc7 user:Benjamin Peterson date:Wed Oct 15 11:51:05 2014 -0400 files: Objects/unicodeobject.c description: make sure lengt

[issue22643] Integer overflow in case_operation

2014-10-15 Thread Benjamin Peterson
Benjamin Peterson added the comment: Cool, I forgot about that. On Wed, Oct 15, 2014, at 12:11, STINNER Victor wrote: > > STINNER Victor added the comment: > > Other changesets related to this issue: > > changeset: 93071:6a91e616485a > branch: 3.3 > parent: 93068:449b1f427cc7 > us

[issue22643] Integer overflow in case_operation

2014-10-15 Thread Roundup Robot
Roundup Robot added the comment: New changeset f963cc1f96cf by Benjamin Peterson in branch '3.3': it suffices to check for PY_SSIZE_T_MAX overflow (#22643) https://hg.python.org/cpython/rev/f963cc1f96cf New changeset 8195d48a5c43 by Benjamin Peterson in branch 'default': merge 3.4 (closes #22643

[issue22445] Memoryviews require more strict contiguous checks then necessary

2014-10-15 Thread Sebastian Berg
Sebastian Berg added the comment: @pitrou, yes of course. This would make python do the same thing as numpy does (currently only with that compile flag given). About the time schedule, I think I will try to see if some other numpy dev has an opinion. Plus, should look into documenting it for th

[issue22592] Drop support of Borland C compiler

2014-10-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Antoine, antique Turbo Pascal 7.0 (for DOS!) [1] is widely used for education in xUSSR countries. Due to a bug [2] in the crt unit most education examples can't be ran on computers with modern processors (Pentium MMX and newer) and are ran under DosBox [3].

[issue22643] Integer overflow in case_operation

2014-10-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I think this is a place where _PyUnicodeWriter would be appropriate (of course this is different issue). -- ___ Python tracker ___ __

[issue22592] Drop support of Borland C compiler

2014-10-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: As for Borland C, it was reincarnated as Borland C++ Builder [1] and then as Embarcadero C++ Builder. I doubt that anyone was compiling Python 3 with it. [1] http://en.wikipedia.org/wiki/C%2B%2BBuilder -- ___ Pyth

[issue22643] Integer overflow in case_operation

2014-10-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: The test should be decorated with the bigmemtest decorator. And I think that condition sys.maxsize < 2**32 would be more robust. -- status: closed -> open ___ Python tracker ___

[issue22643] Integer overflow in case_operation

2014-10-15 Thread Benjamin Peterson
Benjamin Peterson added the comment: It's only 341 MB. On Wed, Oct 15, 2014, at 13:29, Serhiy Storchaka wrote: > > Serhiy Storchaka added the comment: > > The test should be decorated with the bigmemtest decorator. And I think > that condition sys.maxsize < 2**32 would be more robust. > > ---

[issue22643] Integer overflow in case_operation

2014-10-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: And this test is CPython only. It relies on specific implementation detail. After changing current implementation (which inefficiently uses memory) this test will be dropped. -- ___ Python tracker

[issue22643] Integer overflow in case_operation

2014-10-15 Thread Roundup Robot
Roundup Robot added the comment: New changeset 33290d0dd946 by Benjamin Peterson in branch '3.4': merge 3.3 (#22643) https://hg.python.org/cpython/rev/33290d0dd946 New changeset ffabb674140c by Benjamin Peterson in branch 'default': merge 3.4 (#22643) https://hg.python.org/cpython/rev/ffabb67414

[issue22643] Integer overflow in case_operation

2014-10-15 Thread Benjamin Peterson
Benjamin Peterson added the comment: Since the memory requirement is less than 500MB, I don't think it needs a bigmemtest decorator. -- status: open -> closed ___ Python tracker ___

[issue22643] Integer overflow in case_operation

2014-10-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > It's only 341 MB. It's 2**32//12*2 ~ 683 MiB for original string (but I'm not sure that non- ASCII string is needed for this test) + 2**32 = 4GiB if the test will fail for some reason. Some buildbots AFAIK have memory less than 683 MiB. -- ___

[issue22643] Integer overflow in case_operation

2014-10-15 Thread Benjamin Peterson
Benjamin Peterson added the comment: It's Latin 1, so the chars only use one byte: >>> sys.getsizeof("üü") - sys.getsizeof("ü") 1 On Wed, Oct 15, 2014, at 13:46, Serhiy Storchaka wrote: > > Serhiy Storchaka added the comment: > > > It's only 341 MB. > > It's 2**32//12*2 ~ 683 MiB for origina

[issue22643] Integer overflow in case_operation

2014-10-15 Thread Benjamin Peterson
Benjamin Peterson added the comment: More explicitly: >>> sys.getsizeof("ü"*(2**32//12 + 1))//1024//1024 341 -- ___ Python tracker ___ __

[issue22445] Memoryviews require more strict contiguous checks then necessary

2014-10-15 Thread Antoine Pitrou
Antoine Pitrou added the comment: Like Stefan I think this would be good to go in 3.5. The PyBuffer APIs are relatively new so there shouldn't be a lot of breakage. -- ___ Python tracker __

[issue22592] Drop support of Borland C compiler

2014-10-15 Thread Antoine Pitrou
Antoine Pitrou added the comment: Then +1 from me for removing support. -- stage: -> patch review ___ Python tracker ___ ___ Python-b

[issue22646] Set SMTPHandler's "credentials" through "logging.config.dictConfig".

2014-10-15 Thread panos black
New submission from panos black: If you configure logging using a JSON file, then, after you parse it and you pass it to logging.config.dictConfig(), you realize that when you define an SMTPHandler you can't set "credentials", or, more precisely, whether you set it or not the credentials value

[issue22592] Drop support of Borland C compiler

2014-10-15 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: The patch LGTM but there is Borland C support in distutils and there are several mentions in the documentation. May be there are mentions in some build-support files. -- ___ Python tracker

[issue17095] Modules/Setup *shared* support broken

2014-10-15 Thread Ned Deily
Ned Deily added the comment: Stéphane, as I understand it, this issue covers two problems: (1) Building and installing shared modules using Modules/Setup was broken for current Python 3 releases; (2) Using those shared modules when running Python from a build directory (rather than from a norma

[issue21907] Update Windows build batch scripts

2014-10-15 Thread David Bolen
David Bolen added the comment: Just thought I'd add a note here that after the most recent changes, my buildbots also appear to be back to quicker hg pulls rather than clones at the start of the process (see msg222592). Still not sure why that behavior changed, but we're back to the previous

  1   2   >