[issue22555] Tracking issue for adjustments to binary/text boundary handling

2014-10-05 Thread Nick Coghlan
Nick Coghlan added the comment: Assigning to myself, since there's nothing specifically to *do* for this bug, it's just to make it easier to track the status of the various other RFEs it depends on. -- assignee: -> ncoghlan type: -> enhancement __

[issue22546] Wrong default precision in documentation for format

2014-10-05 Thread Mark Dickinson
Mark Dickinson added the comment: Terry: your rewrite looks fine to me. +1 for committing that. -- ___ Python tracker ___ ___ Python-

[issue22556] datetime comparison with 'None' returning a TypeError

2014-10-05 Thread Ankit Dhebar
New submission from Ankit Dhebar: code snippet student_tuple = [ ('ykjsdf', 'A', 17, datetime.date(2014,10,15)), ('accjr', 'C', 11, datetime.date(2013,05,05)), ('dgekw', 'B', 5, datetime.date(1987,03,03)) ] Output for the above code works as expected. o/p : [('dgekw', 'B', 5, datetime.date(198

[issue22486] Add math.gcd()

2014-10-05 Thread Stefan Behnel
Stefan Behnel added the comment: Any objections to merging the last patch? -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue22486] Add math.gcd()

2014-10-05 Thread Mark Dickinson
Mark Dickinson added the comment: > Any objections to merging the last patch? Yes! Please don't make these changes to `Fractions.gcd`: they'll cause regressions for existing uses of `Fractions.gcd` with objects not of type `int`. -- ___ Python trac

[issue22486] Add math.gcd()

2014-10-05 Thread Stefan Behnel
Stefan Behnel added the comment: There are not such changes in patch 7. The fractions.gcd() function is unchanged but no longer used by the Fraction type, which now uses math.gcd() internally instead. -- ___ Python tracker

[issue22486] Add math.gcd()

2014-10-05 Thread Mark Dickinson
Mark Dickinson added the comment: Ah, I misread; thanks. What happens with this patch if a Fraction has been created with Integrals that aren't of type int? (E.g., with NumPy int32 instances, for example?) -- ___ Python tracker

[issue22486] Add math.gcd()

2014-10-05 Thread STINNER Victor
STINNER Victor added the comment: Why patching fraction.Fraction constructor instead of fractions.gcd()? I don't like the idea of having two functions, math.gcd and fractions.gcd, which do almost the same, but one is slow, whereas the other is fast. It's harder to write efficient code working

[issue22486] Add math.gcd()

2014-10-05 Thread Mark Dickinson
Mark Dickinson added the comment: > I suggest to modify fractions.gcd() to use math.gcd() if the two parameters > are int. Sounds fine to me, so long as the code (both fractions.gcd and the fractions.Fraction implementation) continues to function as before for objects that don't have exact ty

[issue22486] Add math.gcd()

2014-10-05 Thread Stefan Behnel
Stefan Behnel added the comment: +1 I mean, there is already such a type check in Fraction.__init__(), but I can see a case for also optimising fraction.gcd() for exact ints. -- ___ Python tracker ___

[issue22486] Add math.gcd()

2014-10-05 Thread Mark Dickinson
Mark Dickinson added the comment: One other suggestion: I think math.gcd should work with arbitrary Python objects implementing __index__, and not just with instances of int. -- ___ Python tracker

[issue22486] Add math.gcd()

2014-10-05 Thread Mark Dickinson
Mark Dickinson added the comment: > I mean, there is already such a type check in Fraction.__init__() That type-check doesn't protect us from non-int Integrals, though, as far as I can tell. It looks to me as though doing `Fraction(numpy.int32(3), numpy.int32(2))` would fail with a TypeError

[issue22448] call_at/call_later with Timer cancellation can result in (practically) unbounded memory usage.

2014-10-05 Thread STINNER Victor
STINNER Victor added the comment: > Please commit your change to the tulip repo too. Oh sorry. In fact, I made the commit but I forgot to push my change :-p -- ___ Python tracker __

[issue20997] Wrong URL fragment identifier in search result

2014-10-05 Thread Georg Brandl
Georg Brandl added the comment: Not a Python issue. -- status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue19361] Specialize exceptions thrown by JSON parser

2014-10-05 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Here is a patch which adopts JSONDecodeError from simplejson. Unlike to simplejson it is located in the json.decoder module (json uses different way to pass an error from scanner to decoder). -- assignee: -> serhiy.storchaka keywords: +needs review

[issue19361] Specialize exceptions thrown by JSON parser

2014-10-05 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- keywords: +patch Added file: http://bugs.python.org/file36810/json_JSONDecodeError.patch ___ Python tracker ___ _

[issue22486] Add math.gcd()

2014-10-05 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I suggest just add deprecation warning in fractions.gcd(). Or at least add notes which recommend math.gcd() in the docstring and the documentation of fractions.gcd(). > One other suggestion: I think math.gcd should work with arbitrary Python > objects implem

[issue18131] Tkinter Variables require a proper master

2014-10-05 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > I am thinking that all uses of _default_root should raise something like > WhateverError("An explicit master is required when _default_root is None or > deleted.") Serhiy, what do you think? Technically all works (raises some exception), but I agree that er

[issue22351] NNTP constructor exception leaves socket for garbage collector

2014-10-05 Thread Rishi
Rishi added the comment: Here is my attempt to fix this issue. This is my first patch ever :). IMO checking socket leaks in the constructor requires an actual server, so I create an actual localhost dummy server and test some error conditions that are encountered by the constructor. --

[issue22297] 2.7 json encoding broken for enums

2014-10-05 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- assignee: -> docs@python components: +Documentation -Library (Lib) nosy: +docs@python stage: test needed -> status: open -> pending ___ Python tracker

[issue21401] python2 -3 does not warn about str/unicode to bytes conversions and comparisons

2014-10-05 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > Python 3 warns even if strings are equal. Did you mean "not equal"? In Python 3 strings and bytes are always not equal. -- ___ Python tracker _

[issue11101] plistlib has no graceful way of handing None values

2014-10-05 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Note that binary plist format supports None. -- nosy: +serhiy.storchaka ___ Python tracker ___ ___

[issue22555] Tracking issue for adjustments to binary/text boundary handling

2014-10-05 Thread Barry A. Warsaw
Changes by Barry A. Warsaw : -- nosy: +barry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue22557] Locale import is too slow

2014-10-05 Thread Serhiy Storchaka
New submission from Serhiy Storchaka: Locale import is too slow in comparison with caching module in a global or even in sys.modules. >>> import timeit >>> def f(): ... import locale ... >>> min(timeit.repeat(f, number=10, repeat=10)) 0.450120013341 >>> _locale = None >>> def g():

[issue22557] Local import is too slow

2014-10-05 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- title: Locale import is too slow -> Local import is too slow ___ Python tracker ___ ___ Python-bugs-l

[issue17636] Modify IMPORT_FROM to fallback on sys.modules

2014-10-05 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue22557] Local import is too slow

2014-10-05 Thread Antoine Pitrou
Antoine Pitrou added the comment: This would sound reasonable to me, but I wonder if it may change behaviour with weird custom __import__ overrides. -- ___ Python tracker ___ __

[issue22558] Missing hint to source code - complete

2014-10-05 Thread Friedrich Spee von Langenfeld
New submission from Friedrich Spee von Langenfeld: As mentioned in Issue22528, in some modules´ documentation, the link to their source code is missing. To check the stdlib, I´ve written the script missing_hint.py. It seems that in the following module entries, there aren´t a link to their sou

[issue22558] Missing hint to source code - complete

2014-10-05 Thread SilentGhost
SilentGhost added the comment: Your code produces many false positives, would you care to reduce this list to only those modules that actually do not have a Source code link? -- nosy: +SilentGhost ___ Python tracker

[issue22557] Local import is too slow

2014-10-05 Thread Nick Coghlan
Nick Coghlan added the comment: __import__ is intended as an absolute override (including of the sys.modules cache lookup), so we can't bypass it without breaking backwards compatibility. It's possible there is room for other optimisations that don't break the import override semantics (such a

[issue22556] datetime comparison with 'None' returning a TypeError

2014-10-05 Thread Eric V. Smith
Eric V. Smith added the comment: You've identified the main problem: would None go first or last? Modify your key function to make the decision appropriate for you, returning either a very small or very large value for None, as appropriate. If you really want to see this behavior changed, you

[issue22557] Local import is too slow

2014-10-05 Thread Eric V. Smith
Changes by Eric V. Smith : -- nosy: +eric.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue17234] python-2.7.3-r3: crash in visit_decref()

2014-10-05 Thread Mark Lawrence
Mark Lawrence added the comment: Should this be closed as I'm not aware of any similar problems with 2.7, particularly when this addresses 2.7.3.rc3? -- ___ Python tracker ___ _

[issue19477] document tp_print() as being dead in Py3

2014-10-05 Thread Stefan Behnel
Stefan Behnel added the comment: Sure. -- keywords: +patch Added file: http://bugs.python.org/file36813/undocument_tp_print.patch ___ Python tracker ___ _

[issue17582] xml.etree.ElementTree does not preserve whitespaces in attributes

2014-10-05 Thread Stefan Behnel
Stefan Behnel added the comment: > Proper escaping should be added to the _escape_attrib() function into > /xml/etree/ElementTree.py (and equivalent for cElementTree). Agreed. Can you provide a patch? -- versions: -Python 2.7 ___ Python tracker

[issue22557] Local import is too slow

2014-10-05 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I'm not experienced in import machinery. Here is preliminary patch which implements my idea for particular case. Performance effect is almost so good as manual caching in a global. >>> import timeit >>> def f(): ... import locale ... >>> min(timeit.rep

[issue19477] document tp_print() as being dead in Py3

2014-10-05 Thread Stefan Behnel
Changes by Stefan Behnel : Removed file: http://bugs.python.org/file36813/undocument_tp_print.patch ___ Python tracker ___ ___ Python-bugs-lis

[issue19477] document tp_print() as being dead in Py3

2014-10-05 Thread Stefan Behnel
Changes by Stefan Behnel : Added file: http://bugs.python.org/file36815/undocument_tp_print.patch ___ Python tracker ___ ___ Python-bugs-list

[issue22558] Missing hint to source code - complete

2014-10-05 Thread R. David Murray
R. David Murray added the comment: And that have source code. That said, some modules may have been consciously omitted. -- nosy: +r.david.murray, rhettinger ___ Python tracker

[issue19477] document tp_print() as being dead in Py3

2014-10-05 Thread Roundup Robot
Roundup Robot added the comment: New changeset bead459ccce8 by Georg Brandl in branch '3.4': Closes #19477: remove outdated documentation of tp_print type object slot. https://hg.python.org/cpython/rev/bead459ccce8 -- nosy: +python-dev resolution: -> fixed stage: needs patch -> resolved

[issue22557] Local import is too slow

2014-10-05 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Second version of the patch uses fast patch only when builtin __import__ is not overridden. It is slightly slower (due to lookup of __import__). >>> import timeit >>> def f(): ... import locale ... >>> min(timeit.repeat(f, number=10, repeat=10)) 0.10

[issue22557] Local import is too slow

2014-10-05 Thread Antoine Pitrou
Antoine Pitrou added the comment: I would suggest factoring out IMPORT_NAME into a separate import_name() function, like is already one for import_from(). -- ___ Python tracker

[issue22557] Local import is too slow

2014-10-05 Thread Antoine Pitrou
Antoine Pitrou added the comment: Some more general comments about this: - Let's keep in mind the absolute numbers. 0.450120013341 for 10 iterations is 4.5ms per iteration. This is not very slow by CPython's standards. - I wonder if you ran your benchmark in debug mode or if your CPU i

[issue22332] test_multiprocessing_main_handling fail on buildbot "x86 FreeBSD 6.4 3.x"

2014-10-05 Thread STINNER Victor
Changes by STINNER Victor : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue22558] Missing hint to source code - complete

2014-10-05 Thread Friedrich Spee von Langenfeld
Friedrich Spee von Langenfeld added the comment: I decremented the shown number of modules by 25. Here is the new list: https://docs.python.org/3/library/base64.html https://docs.python.org/3/library/binhex.html https://docs.python.org/3/library/bz2.html https://docs.python.org/3/library/cgitb.h

[issue22331] test_io.test_interrupted_write_text() hangs on the buildbot FreeBSD 7.2

2014-10-05 Thread STINNER Victor
STINNER Victor added the comment: The test now pass on the buildbot FreeBSD 7.2. -- resolution: -> fixed status: open -> closed ___ Python tracker ___ __

[issue22332] test_multiprocessing_main_handling fail on buildbot "x86 FreeBSD 6.4 3.x"

2014-10-05 Thread STINNER Victor
STINNER Victor added the comment: The test_multiprocessing_main_handling test is now skipped, as expected, on on the buildbot "x86 FreeBSD 6.4 3.x". -- ___ Python tracker ___ __

[issue21965] Add support for Memory BIO to _ssl

2014-10-05 Thread Geert Jansen
Geert Jansen added the comment: Maybe an example is useful on how the Memory BIO stuff can be used to implement SSL on top of a proactor event loop. I just added support for this to my Gruvi project in the branch "feat-memory-bio": An "SslPipe" utility class that uses the memory BIOs: https:/

[issue22222] dtoa.c: remove custom memory allocator

2014-10-05 Thread STINNER Victor
STINNER Victor added the comment: I was no aware of the performance degradation when I created the issue. 18 KB of memory is too low to invest effort on optimizing the generic Python memory allocator, I prefer to keep the heavily optimized allocator in dtoa.c. -- resolution: -> not a

[issue22290] "AMD64 OpenIndiana 3.x" buildbot: assertion failed in PyObject_Call() in test_subprocess.test_preexec()

2014-10-05 Thread Roundup Robot
Roundup Robot added the comment: New changeset 0455cbfd7ae6 by Victor Stinner in branch '3.4': Issue #22290: Fix error handling in the _posixsubprocess module. https://hg.python.org/cpython/rev/0455cbfd7ae6 New changeset a74c73477a64 by Victor Stinner in branch 'default': (Merge 3.4) Issue #2229

[issue22290] "AMD64 OpenIndiana 3.x" buildbot: assertion failed in PyObject_Call() in test_subprocess.test_preexec()

2014-10-05 Thread STINNER Victor
STINNER Victor added the comment: I hope that my fix will be enough to fix the issue. Since it was only seen once, I prefer to close the issue. By the way, it would be nice to give more memory to this buildbot! -- resolution: -> fixed status: open -> closed __

[issue21965] Add support for Memory BIO to _ssl

2014-10-05 Thread Antoine Pitrou
Antoine Pitrou added the comment: SSLPipe looks interesting. I wonder if it can be used to reimplement _SelectorSslTransport in asyncio.selector_events (at least as an experiment). I'll take a look at the cumulated patch soon, thank you. -- ___ Pytho

[issue22390] test.regrtest should complain if a test doesn't remove temporary files

2014-10-05 Thread Roundup Robot
Roundup Robot added the comment: New changeset 8cf8bff3569e by Victor Stinner in branch '3.4': Issue #22390: Remove files created by tests https://hg.python.org/cpython/rev/8cf8bff3569e -- nosy: +python-dev ___ Python tracker

[issue16518] add "buffer protocol" to glossary

2014-10-05 Thread Roundup Robot
Roundup Robot added the comment: New changeset e7e8a218737a by R David Murray in branch 'default': #16518: Bring error messages in harmony with docs ("bytes-like object") https://hg.python.org/cpython/rev/e7e8a218737a -- ___ Python tracker

[issue22324] Use PyUnicode_AsWideCharString() instead of PyUnicode_AsUnicode()

2014-10-05 Thread STINNER Victor
STINNER Victor added the comment: > The cache is released when the string is released. While the string exists > it's wchar_t representation can be needed again. That is for what the cache > exists. I know. But I don't want to waste memory for this cache. I want to stop using it. IMO the perf

[issue16518] add "buffer protocol" to glossary

2014-10-05 Thread R. David Murray
R. David Murray added the comment: Committed the message changes to 3.5 only, since it will probably cause tests to fail in various projects, despite messages not being a formal part of the python API. Per IRC conversation with Ezio and Antoine, I posted a note to python-dev to let people k

[issue22324] Use PyUnicode_AsWideCharString() instead of PyUnicode_AsUnicode()

2014-10-05 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > In which use case do you think that the overhead of not using the cache would > be important enough? I suppose in the same use case that memory overhead of using the cache is important enough. We need results of performance and memory consumption effect o

[issue4343] New function in Tkinter.py: setup_master

2014-10-05 Thread R. David Murray
R. David Murray added the comment: Changing status back to 'needs patch' per Terry's comment that the patch needs to be updated (now for 3.5). -- assignee: gpolo -> nosy: +r.david.murray stage: commit review -> needs patch versions: +Python 3.5 -Python 3.4

[issue2552] test_ctypes failed Python 2.6a2 Solaris 10 SUN C

2014-10-05 Thread Mark Lawrence
Mark Lawrence added the comment: Can we close this as I cannot see how a test failure against a 6.5 year old alpha build can still be relevant? -- ___ Python tracker ___

[issue2552] test_ctypes failed Python 2.6a2 Solaris 10 SUN C

2014-10-05 Thread Gregory P. Smith
Changes by Gregory P. Smith : -- resolution: -> out of date status: languishing -> closed ___ Python tracker ___ ___ Python-bugs-list

[issue18161] call fchdir if subprocess.Popen(cwd=integer|fileobject)

2014-10-05 Thread Mark Lawrence
Mark Lawrence added the comment: mmarkk we're sorry about the delay in getting back to you. Who is best placed to reply to this enhancement request, the only name on the experts list is inactive? -- nosy: +BreamoreBoy versions: -Python 3.3, Python 3.4 ___

[issue14303] Incorrect documentation for socket.py on linux

2014-10-05 Thread Mark Lawrence
Mark Lawrence added the comment: Shane, there are major differences between the makefile docs versions 2 and 3, so could you prepare a patch for this addressed at version 2 only? -- nosy: +BreamoreBoy versions: -Python 2.6 ___ Python tracker

[issue18165] Add 'unexpected_type' to TypeError

2014-10-05 Thread Mark Lawrence
Mark Lawrence added the comment: Just a gentle reminder guys. -- nosy: +BreamoreBoy versions: +Python 3.5 -Python 3.4 ___ Python tracker ___ _

[issue18166] 'value' attribute for ValueError

2014-10-05 Thread Mark Lawrence
Mark Lawrence added the comment: Just a gentle reminder guys. -- nosy: +BreamoreBoy versions: +Python 3.5 -Python 3.4 ___ Python tracker ___ _

[issue18299] Change script_helper to use universal_newlines=True in _assert_python

2014-10-05 Thread Mark Lawrence
Mark Lawrence added the comment: Just a gentle reminder guys. -- nosy: +BreamoreBoy versions: +Python 3.5 -Python 3.4 ___ Python tracker ___ _

[issue16518] add "buffer protocol" to glossary

2014-10-05 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: There are other unfixed messages (may be introduced after 3.3): >>> b''.join(['']) Traceback (most recent call last): File "", line 1, in TypeError: sequence item 0: expected bytes, bytearray, or an object with the buffer interface, str found >>> str(42, '

[issue15729] PyStructSequence_NewType enhancement

2014-10-05 Thread Mark Lawrence
Mark Lawrence added the comment: I'm uncertain as to whether or not the patch can be considered stand alone, or whether the pep3121 keyword is also relevant here. -- nosy: +BreamoreBoy versions: +Python 3.5 -Python 3.4 ___ Python tracker

[issue18173] Add MixedTypeKey to reprlib

2014-10-05 Thread Mark Lawrence
Mark Lawrence added the comment: Just a gentle reminder guys. -- nosy: +BreamoreBoy versions: +Python 3.5 -Python 3.4 ___ Python tracker ___ _

[issue22364] Improve some re error messages using regex for hints

2014-10-05 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > As for #14, either UNICODE and LOCALE *are* compatible (for re) or this is > buggy. This is buggy (issue22407). -- title: Unify error messages of re and regex -> Improve some re error messages using regex for hints ___

[issue17580] ctypes: ARM hardfloat argument corruption calling functions with many float arguments

2014-10-05 Thread Mark Lawrence
Mark Lawrence added the comment: Could we have a reply to this from our ctypes experts, thanks. -- nosy: +BreamoreBoy versions: +Python 3.5 -Python 3.2, Python 3.3 ___ Python tracker ___

[issue18319] gettext() cannot find translations with plural forms

2014-10-05 Thread Mark Lawrence
Mark Lawrence added the comment: @Martin can you comment on this please. -- nosy: +BreamoreBoy, loewis type: -> behavior versions: +Python 2.7, Python 3.4, Python 3.5 ___ Python tracker ___

[issue18348] Additional code pages for EBCDIC

2014-10-05 Thread Mark Lawrence
Mark Lawrence added the comment: What do our unicode experts think about this enhancement request? -- nosy: +BreamoreBoy versions: +Python 3.5 ___ Python tracker ___

[issue12957] mmap.resize changes memory address of mmap'd region

2014-10-05 Thread Mark Lawrence
Mark Lawrence added the comment: @Michael can you provide a patch to this effect? -- nosy: +BreamoreBoy versions: +Python 3.5 -Python 3.3 ___ Python tracker ___ _

[issue19380] Optimize parsing of regular expressions

2014-10-05 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Here is a patch which addresses Yury's and Josh's comments. Also discarded few minor changes. -- Added file: http://bugs.python.org/file36818/re_parse_4.patch ___ Python tracker

[issue18372] _Pickler_New() doesn't call PyObject_GC_Track(self)

2014-10-05 Thread Mark Lawrence
Mark Lawrence added the comment: @Christian/Victor could either of you provide a patch for this, it's way beyond my knowledge I'm afraid. -- nosy: +BreamoreBoy versions: +Python 2.7, Python 3.4, Python 3.5 ___ Python tracker

[issue21173] WeakKeyDictionary.__len__ fragile w/ _IterationGuards

2014-10-05 Thread Roundup Robot
Roundup Robot added the comment: New changeset 657d21b4b121 by Antoine Pitrou in branch '3.4': Closes #21173: Fix len() on a WeakKeyDictionary when .clear() was called with an iterator alive. https://hg.python.org/cpython/rev/657d21b4b121 New changeset 27533444b964 by Antoine Pitrou in branch '

[issue18348] Additional code pages for EBCDIC

2014-10-05 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Currently Python includes codecs for cp037, cp273, and cp500. -- nosy: +serhiy.storchaka ___ Python tracker ___ __

[issue18459] readline: libedit support on non-apple platforms

2014-10-05 Thread Mark Lawrence
Mark Lawrence added the comment: Just a gentle reminder. -- components: +Extension Modules nosy: +BreamoreBoy versions: +Python 2.7, Python 3.5 ___ Python tracker ___ ___

[issue18493] make profile-opt fails with pre-existing python2.7 in path

2014-10-05 Thread Mark Lawrence
Mark Lawrence added the comment: Can somebody please take a look at the inline patch in msg193313. -- nosy: +BreamoreBoy type: -> behavior versions: +Python 3.4, Python 3.5 ___ Python tracker _

[issue18372] _Pickler_New() doesn't call PyObject_GC_Track(self)

2014-10-05 Thread Benjamin Peterson
Benjamin Peterson added the comment: Mark, could you please stop touching every issue on the tracker? I appreciate the effort, but giving thoughtful feedback, patches, or reviews on a just a few issues would be much more helpful. -- nosy: +benjamin.peterson ___

[issue4343] tkinter: add _get_master() and use it consistently

2014-10-05 Thread Terry J. Reedy
Terry J. Reedy added the comment: The new function should be private. I closed #18131 as partially a duplicate of this. It has a couple of other suggested wordings for the exception. I consider the current behavior, in particular the failure of Variable and subclasses when the supposedly opti

[issue21081] missing vietnamese codec TCVN 5712:1993 in Python

2014-10-05 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- nosy: +serhiy.storchaka stage: -> needs patch ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue18494] PyType_GenericSet/GetDict functions misnamed in docs?

2014-10-05 Thread Mark Lawrence
Mark Lawrence added the comment: Can someone with knowledge of the C code associated with the object/type system comment on this please. -- nosy: +BreamoreBoy ___ Python tracker ___

[issue18372] _Pickler_New() doesn't call PyObject_GC_Track(self)

2014-10-05 Thread Mark Lawrence
Mark Lawrence added the comment: Sorry but no, when I started out on this a couple of months ago there were over 600 issues that nobody had even bothered to reply to. That number is now down to 369. I believe that around 200 issues have been closed as a result of my efforts. Do you have a p

[issue21965] Add support for Memory BIO to _ssl

2014-10-05 Thread Roundup Robot
Roundup Robot added the comment: New changeset a79003f25a41 by Antoine Pitrou in branch 'default': Issue #21965: Add support for in-memory SSL to the ssl module. https://hg.python.org/cpython/rev/a79003f25a41 -- nosy: +python-dev ___ Python tracker <

[issue15273] Remove unnecessarily random behavior from test_unparse.py

2014-10-05 Thread Berker Peksag
Changes by Berker Peksag : -- components: +Tests nosy: +berker.peksag stage: needs patch -> patch review versions: +Python 3.5 ___ Python tracker ___

[issue18494] PyType_GenericSet/GetDict functions misnamed in docs?

2014-10-05 Thread eryksun
eryksun added the comment: See changeset 78f93eb7dd75. The names in the docs are wrong. -- nosy: +eryksun ___ Python tracker ___ ___ P

[issue22351] NNTP constructor exception leaves socket for garbage collector

2014-10-05 Thread Rishi
Rishi added the comment: patch updated to use just plain exception -- Added file: http://bugs.python.org/file36819/issue22351_1.patch ___ Python tracker ___ _

[issue18372] _Pickler_New() doesn't call PyObject_GC_Track(self)

2014-10-05 Thread Terry J. Reedy
Terry J. Reedy added the comment: Mark, I also appreciate your efforts, as I hope should be obvious from my prior responses to many of your other posts. I also agree that somewhat fewer, higher quality posts would be even more helpful. Please do not slip into a 'confrontational' mode, as you

[issue22559] [backport] ssl.MemoryBIO

2014-10-05 Thread Alex Gaynor
New submission from Alex Gaynor: Attached patch is a first-cut at a backport patch. Note that it is not quite a 1-1 with the original: The SSL module backport added a new field for the Python-level "SSLSocket" reference (ssl_sock), which was a different object from the _socket.socket (PySocke

[issue22559] [backport] ssl.MemoryBIO

2014-10-05 Thread Geert Jansen
Changes by Geert Jansen : -- nosy: +geertj ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue18372] _Pickler_New() doesn't call PyObject_GC_Track(self)

2014-10-05 Thread STINNER Victor
STINNER Victor added the comment: Le 5 oct. 2014 20:04, "Mark Lawrence" a écrit : > > > Mark Lawrence added the comment: > > @Christian/Victor could either of you provide a patch for this, it's way beyond my knowledge I'm afraid. I agree with Benjamin. Asking directly two developers to write a

[issue18372] _Pickler_New() doesn't call PyObject_GC_Track(self)

2014-10-05 Thread STINNER Victor
STINNER Victor added the comment: I don't know the PyObject_GC_Track() function. Why is it an issue to not call it? Can you elaborate Christian? What do you suggest? -- ___ Python tracker _

[issue21965] Add support for Memory BIO to _ssl

2014-10-05 Thread Geert Jansen
Geert Jansen added the comment: Thanks Antoine for merge! > SSLPipe looks interesting. I wonder if it can be used to reimplement > _SelectorSslTransport in asyncio.selector_events (at least as an experiment). Yes, it could be done quite easily. SslPipe has no dependency on other parts of Gruv

[issue18372] _Pickler_New() doesn't call PyObject_GC_Track(self)

2014-10-05 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: >From Doc/c-api/gcsupport.rst: > Constructors for container types must conform to two rules: > > #. The memory for the object must be allocated using :c:func:`PyObject_GC_New` >or :c:func:`PyObject_GC_NewVar`. > > #. Once all the fields which may contain

[issue21965] Add support for Memory BIO to _ssl

2014-10-05 Thread Antoine Pitrou
Antoine Pitrou added the comment: Le 05/10/2014 23:24, Geert Jansen a écrit : > > Yes, it could be done quite easily. SslPipe has no dependency on > other parts of Gruvi and if this is for Python 3.5 only then you don't need sslcompat either. Yes, it works. Note that I had to modify SSLPipe to

[issue21965] Add support for Memory BIO to _ssl

2014-10-05 Thread Roundup Robot
Roundup Robot added the comment: New changeset 8da1aa71cd73 by Antoine Pitrou in branch 'default': Remove unused "block" argument in SSLObject.do_handshake() (issue #21965) https://hg.python.org/cpython/rev/8da1aa71cd73 -- ___ Python tracker

[issue22559] [backport] ssl.MemoryBIO

2014-10-05 Thread Geert Jansen
Geert Jansen added the comment: It seems that SSLSocket.close() doesn't actually close the socket, and that's why the server side read() blocks. It's a bit of a mystery to me how socket.close(), which is called by SSLSocket to do the actual close, is supposed to work. I don't see any calls to

[issue21965] Add support for Memory BIO to _ssl

2014-10-05 Thread Antoine Pitrou
Antoine Pitrou added the comment: I'm closing this issue, and will open a new one for asyncio and/or SSLPipe. Thank you very much, Geert! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue22559] [backport] ssl.MemoryBIO

2014-10-05 Thread Alex Gaynor
Alex Gaynor added the comment: Right, socket._socketobject mearly nulls out the reference to _socket.socket, and lets reference counting take care of the rest. I've more of less got this figured out: * When do_handshake() raises an exception (say, a CertificateError), then a reference to a tr

  1   2   >