[issue19948] POSIX semantics of PATH search in execvpe is not respected

2013-12-10 Thread Eric V. Smith
Eric V. Smith added the comment: What platform is this on? Looking quickly through posix.execve (which is what I think gets called), it looks like it just calls C's execve(). Also, what's your use case for this? I realize it might be a standard behavior, but it seems like a bad idea to me. (No

[issue19572] Report more silently skipped tests as skipped

2013-12-10 Thread Zachary Ware
Zachary Ware added the comment: Fixed that last comment in the commit. Thank you for all the reviews, Serhiy! -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker

[issue19928] Implement cell repr test

2013-12-10 Thread Roundup Robot
Roundup Robot added the comment: New changeset 21a9abf6d428 by Zachary Ware in branch '2.7': Issue #19928: Fix test on Windows http://hg.python.org/cpython/rev/21a9abf6d428 New changeset a0f9f0778ce3 by Zachary Ware in branch '3.3': Issue #19928: Fix test on Windows http://hg.python.org/cpython/

[issue19928] Implement cell repr test

2013-12-10 Thread Zachary Ware
Zachary Ware added the comment: This was failing the Windows buildbots; the object addresses have capital letters instead of lower case. I'm sorry, I should have caught that at review. -- ___ Python tracker _

[issue19846] Python 3 raises Unicode errors with the C locale

2013-12-10 Thread STINNER Victor
STINNER Victor added the comment: 2013/12/10 Toshio Kuratomi : > if G_FILENAME_ENCODING: > charset = the first charset listed in G_FILENAME_ENCODING > if charset == '@locale': > charset = charset of user's locale > elif G_BROKEN_FILENAMES: > charset = charset of user's locale

[issue19946] Have multiprocessing raise ImportError when spawning a process that can't find the "main" module

2013-12-10 Thread Brett Cannon
Brett Cannon added the comment: So at the bare minimum, the multiprocessing code should raise an ImportError when it can't find the spec for the module to help debug this kind of thing. Also that typo should get fixed. Second, there is no way that 'nosetests' will ever succeed as an import sin

[issue17576] PyNumber_Index() is not int-subclass friendly (or operator.index() docos lie)

2013-12-10 Thread Mark Dickinson
Mark Dickinson added the comment: Thanks, Serhiy. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue19946] Have multiprocessing raise ImportError when spawning a process that can't find the "main" module

2013-12-10 Thread Richard Oudkerk
Richard Oudkerk added the comment: I guess this is a case where we should not be trying to import the main module. The code for determining the path of the main module (if any) is rather crufty. What is sys.modules['__main__'] and sys.modules['__main__'].__file__ if you run under nose? -

[issue1100942] Add datetime.time.strptime and datetime.date.strptime

2013-12-10 Thread Maciej Szulik
Changes by Maciej Szulik : -- nosy: +maciej.szulik ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue16244] TimedRotatingFileHandler forces "write" mode, should use "append"

2013-12-10 Thread axil
axil added the comment: This fix breaks the behavior of RotatingFileHandler. Maxbytes>0 can now be only used with backupCount>0 otherwise it is ignored. So all programs that are using Maxbytes>0 and backupCount=0 are now facing an infinitely growing logfile. -- nosy: +axil type: behav

[issue19846] Python 3 raises Unicode errors with the C locale

2013-12-10 Thread STINNER Victor
STINNER Victor added the comment: > It would interesting to test this approach (try utf-8 or use the locale > encoding) ... Oh, it may be easy to implement it for decoders, but what about encoders? Should os.fsencode() always use UTF-8?? -- ___ Pyth

[issue19940] ssl.cert_time_to_seconds() returns wrong results if local timezone is not UTC

2013-12-10 Thread akira
akira added the comment: gudge, There is also an issue with the current strptime format [1] (`"%b %d %H:%M:%S %Y GMT"`). It is locale-dependent and it may fail if a non-English locale is in effect. I don't know whether I should open a new issue on this or are you going to fix it too. `cert_t

[issue19944] Make importlib.find_spec load packages as needed

2013-12-10 Thread Arfrever Frehtes Taifersar Arahesis
Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue19914] help([object]) returns "Not enough memory." on standard Python types, object and object functions

2013-12-10 Thread HCT
HCT added the comment: the other issue I'm also seeing is that help() doesn't seem to take exactly an object as an optional argument. perhaps Python manual for help() should be updated according to the actual implementation? >>> help('hello') no Python documentation found for 'hello' >>> type

[issue17576] PyNumber_Index() is not int-subclass friendly (or operator.index() docos lie)

2013-12-10 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: What about PyLong_AsSsize_t(), PyLong_AsUnsignedLong(), and PyLong_AsSize_t()? They are ignore __int__(). PyLong_AsVoidPtr() calls PyLong_AsLong(), PyLong_AsUnsignedLong(), PyLong_AsLongLong(), or PyLong_AsUnsignedLongLong() (depending on pointer's size and

[issue19572] Report more silently skipped tests as skipped

2013-12-10 Thread Roundup Robot
Roundup Robot added the comment: New changeset ca9bca7aecda by Zachary Ware in branch '2.7': Issue #19572: Replace a return that shouldn't have been removed from test_os. http://hg.python.org/cpython/rev/ca9bca7aecda -- ___ Python tracker

[issue19950] Document that unittest.TestCase.__init__ is called once per test

2013-12-10 Thread Claudiu.Popa
New submission from Claudiu.Popa: I was surprised that in the following __init__ is actually called once per test function, although nothing in documentation implied so. a.py -- import unittest class A(unittest.TestCase): def __init__(self, *args, **kwargs): print('called only o

[issue19941] python -m imports non-ASCII .py file without encoding declaration

2013-12-10 Thread Nick Coghlan
Nick Coghlan added the comment: Quite plausibly a bug in the pkgutil import system emulation. Does the same inconsistency appear in 3.3 with non-UTF8 bytes? -- ___ Python tracker __

[issue19950] Document that unittest.TestCase.__init__ is called once per test

2013-12-10 Thread R. David Murray
R. David Murray added the comment: I'm guessing it is that a new TestCase instance is instantiated each time an individual test is run. I don't know that this is part of the API, though, so I'm not sure how it should be documented. -- nosy: +r.david.murray ___

[issue19950] Document that unittest.TestCase.__init__ is called once per test

2013-12-10 Thread Ned Batchelder
Ned Batchelder added the comment: This sentence seems to cover it: "Each instance of the TestCase will only be used to run a single test method, so a new fixture is created for each test." from http://docs.python.org/2/library/unittest.html The word "fixture" here is being used oddly, but tha

[issue19944] Make importlib.find_spec load packages as needed

2013-12-10 Thread Nick Coghlan
Nick Coghlan added the comment: They're fundamentally different operations though, with one being a single step of the other. I just think "do the full lookup" should have the more obvious name, with the "do a single level lookup" still as a public API, but with the less obvious name. --

[issue19950] Document that unittest.TestCase.__init__ is called once per test

2013-12-10 Thread Claudiu.Popa
Claudiu.Popa added the comment: "Each instance of the TestCase will only be used to run a single test method, so a new fixture is created for each test." Yes, this seems to be, but it is not clear what fixture means in this context (as in "the preparation needed to perform one or *more* tests"

[issue17576] PyNumber_Index() is not int-subclass friendly (or operator.index() docos lie)

2013-12-10 Thread Nick Coghlan
Nick Coghlan added the comment: The ssize_t functions deliberately ignore lossy int conversions (e.g. from floats) - that's why they only work on types that implement __index__. -- ___ Python tracker __

[issue19846] Python 3 raises Unicode errors with the C locale

2013-12-10 Thread Toshio Kuratomi
Toshio Kuratomi added the comment: Yes, it returns a list but unless I'm missing something in the general case it's the caller's responsibility to loop through the charsets to test for failure and try again. This is not done automatically. In the specific case we're talking about, first get_f

[issue19950] Document that unittest.TestCase.__init__ is called once per test

2013-12-10 Thread Michael Foord
Michael Foord added the comment: I'd be happy with a doc change from "fixture" to instance (or maybe add instance in parentheses). I'd rather a simple change than making the documentation much longer. The reason for a separate instance per test is for test isolation. Each test can create and

[issue18270] IDLE on OS X fails with Attribute Error if no initial shell and Tk out-of-date

2013-12-10 Thread Roundup Robot
Roundup Robot added the comment: New changeset 5becf8b612ee by Ned Deily in branch '2.7': Issue #18270: Prevent possible IDLE AttributeError on OS X when no initial http://hg.python.org/cpython/rev/5becf8b612ee New changeset 016c64e66a9e by Ned Deily in branch '3.3': Issue #18270: Prevent possib

[issue18270] IDLE on OS X fails with Attribute Error if no initial shell and Tk out-of-date

2013-12-10 Thread Ned Deily
Ned Deily added the comment: Thanks for the patch, Terry. I've pushed a slightly modified version for release in 2.7.7, 3.3.4, and 3.4.0. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker <

[issue17200] telnetlib.read_until() timeout uses the wrong units

2013-12-10 Thread Gregory P. Smith
Gregory P. Smith added the comment: Review comments added. I don't really see why the fix should not be as trivial as: diff -r ca9bca7aecda Lib/telnetlib.py --- a/Lib/telnetlib.py Tue Dec 10 16:06:46 2013 -0600 +++ b/Lib/telnetlib.py Tue Dec 10 18:08:37 2013 -0800 @@ -312,7 +312,9 @@

[issue17200] telnetlib.read_until() timeout uses the wrong units

2013-12-10 Thread Gregory P. Smith
Changes by Gregory P. Smith : -- assignee: -> gregory.p.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue14635] telnetlib uses select instead of poll - limited to FD_SETSIZE fds

2013-12-10 Thread Roundup Robot
Roundup Robot added the comment: New changeset d61e8050b7d7 by Gregory P. Smith in branch '2.7': Fixes Issue #17200: telnetlib's read_until and expect timeout was broken by the http://hg.python.org/cpython/rev/d61e8050b7d7 New changeset 46186736e91c by Gregory P. Smith in branch '3.3': Fixes Iss

[issue17200] telnetlib.read_until() timeout uses the wrong units

2013-12-10 Thread Roundup Robot
Roundup Robot added the comment: New changeset d61e8050b7d7 by Gregory P. Smith in branch '2.7': Fixes Issue #17200: telnetlib's read_until and expect timeout was broken by the http://hg.python.org/cpython/rev/d61e8050b7d7 New changeset 46186736e91c by Gregory P. Smith in branch '3.3': Fixes Iss

[issue19941] python -m imports non-ASCII .py file without encoding declaration

2013-12-10 Thread Benjamin Peterson
Benjamin Peterson added the comment: 3.x is afflicted. -- nosy: +benjamin.peterson versions: +Python 3.3, Python 3.4 -Python 2.7 ___ Python tracker ___ __

[issue15032] Provide a select.select implemented using select.poll

2013-12-10 Thread Éric Araujo
Éric Araujo added the comment: This may be obsoleted by the new selectors module. -- nosy: +eric.araujo, neologix ___ Python tracker ___ _

[issue15032] Provide a select.select implemented using select.poll

2013-12-10 Thread Gregory P. Smith
Changes by Gregory P. Smith : -- resolution: -> out of date stage: -> committed/rejected status: open -> closed ___ Python tracker ___ _

[issue12029] Catching virtual subclasses in except clauses

2013-12-10 Thread Nick Coghlan
Nick Coghlan added the comment: Ah, you're right - I found the example I was thinking of (Richard Jones's "Don't do this!" talk), and it was just demonstrating that the except clause accepts any expressions producing a tuple or BaseException instance, not that we call __iter__ at that point.

[issue18864] Implementation for PEP 451 (importlib.machinery.ModuleSpec)

2013-12-10 Thread Roundup Robot
Roundup Robot added the comment: New changeset e961a166dc70 by Eric Snow in branch 'default': Issue #18864: Add a setter for ModuleSpec.has_location. http://hg.python.org/cpython/rev/e961a166dc70 -- ___ Python tracker

[issue19700] Update runpy for PEP 451

2013-12-10 Thread Eric Snow
Eric Snow added the comment: patch LGTM -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.

[issue19944] Make importlib.find_spec load packages as needed

2013-12-10 Thread Eric Snow
Eric Snow added the comment: As a testament to counter-intuitive API, I did not even realize this about either find_loader() or find_spec() until the bug the other day with reloading submodules. So I'm on board! As to the best approach, I'll argue for keeping just 1 function. I tried out bo

[issue19701] Update multiprocessing for PEP 451

2013-12-10 Thread Eric Snow
Eric Snow added the comment: This came up in issue19946. -- nosy: +sbt ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue19946] Have multiprocessing raise ImportError when spawning a process that can't find the "main" module

2013-12-10 Thread Eric Snow
Eric Snow added the comment: There is definitely room for improvement relative to module specs and __main__ (that's the topic of issue #19701). That issue is waiting for __main__ to get a proper spec (see issues #19700 and #19697). -- ___ Python tr

[issue19713] Deprecate various things in importlib thanks to PEP 451

2013-12-10 Thread Eric Snow
Eric Snow added the comment: Here's a patch for the deprecations (and API additions) in the importlib docs. -- keywords: +patch Added file: http://bugs.python.org/file33088/issue19713-importlib-docs.diff ___ Python tracker

[issue19710] Make sure documentation for PEP 451 is finished

2013-12-10 Thread Eric Snow
Eric Snow added the comment: I've attached a patch to issue19713 (file33088) that adds documentation for the new APIs. Also, there were some good reviews in issue18864 (especially for file32381) that never got fully addressed. -- ___ Python tracker

[issue17200] telnetlib.read_until() timeout uses the wrong units

2013-12-10 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > Review comments added. Only original author can answer your questions. > I don't really see why the fix should not be as trivial as: Yes, these are simple and obvious, and only changes which I understand. -- _

[issue17576] PyNumber_Index() is not int-subclass friendly (or operator.index() docos lie)

2013-12-10 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > The ssize_t functions deliberately ignore lossy int conversions (e.g. from > floats) - that's why they only work on types that implement __index__. They ignore __index__. -- ___ Python tracker

[issue17576] PyNumber_Index() is not int-subclass friendly (or operator.index() docos lie)

2013-12-10 Thread Mark Dickinson
Mark Dickinson added the comment: Yes, the PyLong_As... conversions are a mess. In theory, they should all use __index__ if available, and ignore __int__. In practice, it's a mess that's difficult to change without breaking things. I think there are already some other issues open on this su

<    1   2