[issue17810] Implement PEP 3154 (pickle protocol 4)

2013-11-19 Thread Martin v . Löwis
Martin v. Löwis added the comment: Attached is a patch that takes a different approach to framing, putting it into an optional framing layer by means of a buffered reader/writer. The framing structure is the same as in PEP 3154; a separate PYFRAMES magic is prepended to guard against protocol

[issue19626] test_email and Lib/email/_policybase.py failures with -OO

2013-11-19 Thread Francisco Martín Brugué
Francisco Martín Brugué added the comment: small correction: a fresh clone, then: ./configure --with-pydebug make -j4 ./python -OO -m test -v test_email -- ___ Python tracker __

[issue19617] Fix usage of Py_ssize_t type in Python/compile.c

2013-11-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset ee4da7291211 by Victor Stinner in branch 'default': Issue #9566, #19617: New try to fix compilation on Windows http://hg.python.org/cpython/rev/ee4da7291211 -- ___ Python tracker

[issue9566] Compilation warnings under x64 Windows

2013-11-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset ee4da7291211 by Victor Stinner in branch 'default': Issue #9566, #19617: New try to fix compilation on Windows http://hg.python.org/cpython/rev/ee4da7291211 -- ___ Python tracker

[issue18294] zlib module is not completly 64-bit safe

2013-11-19 Thread STINNER Victor
STINNER Victor added the comment: zlib_64bit-3.patch: updated patch which fixes also the PyArg_ParseTuple() convert for C int and C unsigned int. -- Added file: http://bugs.python.org/file32710/zlib_64bit-3.patch ___ Python tracker

[issue19588] Silently skipped test in test_random

2013-11-19 Thread Julian Gindi
Julian Gindi added the comment: Maybe some documentation could help express the purpose of this test, but I was able to make the changes mentioned below and the test seems to work better than it used to. The test no longer returns if a value is 'skipped'. This is my first attempt at a patch so

[issue19637] test_subprocess.test_undecodable_env() failure on AIX

2013-11-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset e651036191ad by Victor Stinner in branch 'default': Issue #19637: fix test_undecodable_env() of test_subprocess on AIX http://hg.python.org/cpython/rev/e651036191ad -- nosy: +python-dev ___ Python tracker

[issue2943] Distutils should generate a better error message when the SDK is not installed

2013-11-19 Thread Matt Hickford
Matt Hickford added the comment: For comparison, Ruby ships with a package manager, Gem. If a user tries to install a package with C extensions, they are given this user-friendly message: > Please update your PATH to include build tools or download the DevKit from > 'http://rubyinstaller.org/d

[issue9566] Compilation warnings under x64 Windows

2013-11-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset 116bd550e309 by Victor Stinner in branch 'default': Issue #9566, #19617: Fix more compiler warnings in compile.c on Windows 64-bit http://hg.python.org/cpython/rev/116bd550e309 -- ___ Python tracker

[issue19617] Fix usage of Py_ssize_t type in Python/compile.c

2013-11-19 Thread Roundup Robot
Roundup Robot added the comment: New changeset 116bd550e309 by Victor Stinner in branch 'default': Issue #9566, #19617: Fix more compiler warnings in compile.c on Windows 64-bit http://hg.python.org/cpython/rev/116bd550e309 -- ___ Python tracker

[issue18295] Possible integer overflow in PyCode_New()

2013-11-19 Thread STINNER Victor
STINNER Victor added the comment: Here is a patch adding Py_SAFE_DOWNCAST(). For update_star_args(), I changed the type instead, because I prefer to avoid Py_SAFE_DOWNCAST() when possible. Modify PyEval_EvalCodeEx() and PyCode_New() to use Py_ssize_t would be more correct, but it may be slower

[issue19633] test_wave: failures on PPC64 buildbot

2013-11-19 Thread David Edelsohn
David Edelsohn added the comment: By the way, test_wave also fails on zLinux, which also is Big Endian. -- ___ Python tracker ___ ___

[issue19568] bytearray_setslice_linear() leaves the bytearray in an inconsistent state on memory allocation failure

2013-11-19 Thread STINNER Victor
STINNER Victor added the comment: > Can you suppress the MemoryError if deletion succeeds? That would be ok IMO. In case (1) and (3) (see below), the MemoryError might be suppressed, but I prefer to keep the exception to warn the user that something bad happened and its program will slowly lea

[issue19578] del list[a:b:c] doesn't handle correctly list_resize() failure

2013-11-19 Thread STINNER Victor
STINNER Victor added the comment: Hum, my explanation is maybe not clear. Without the patch, the operation succeed, but a MemoryError is raised, and the caller is not notified. So you enter an inconsistent state because your function may "succeed" whereas an exception is set. With the patch,

[issue19518] Add new PyRun_xxx() functions to not encode the filename

2013-11-19 Thread STINNER Victor
STINNER Victor added the comment: > Updated patch addressing some remarks of Serhiy and adding documentation. Anyone for a new review? -- ___ Python tracker ___

[issue19512] Avoid temporary Unicode strings, use identifiers to only create the string once

2013-11-19 Thread STINNER Victor
STINNER Victor added the comment: No reaction, I close the issue. Reopen it if you still have complains ;-) -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue19656] Add Py3k warning for non-ascii bytes literals

2013-11-19 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: +benjamin.peterson ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue19506] subprocess.communicate() should use a memoryview

2013-11-19 Thread STINNER Victor
STINNER Victor added the comment: Attached subprocess_memoryview.patch uses a memoryview() to avoid memory copies. The behaviour is undefined if two threads share the same Popen object and call the communicate() method at the same time. But I'm not sure that Popen is thread safe, it doesn't us

[issue19506] subprocess.communicate() should use a memoryview

2013-11-19 Thread Antoine Pitrou
Antoine Pitrou added the comment: Hi, why does your patch change listobject.c? -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue19506] subprocess.communicate() should use a memoryview

2013-11-19 Thread STINNER Victor
STINNER Victor added the comment: > Hi, why does your patch change listobject.c? Oops, the change is unrelated (#19578). -- ___ Python tracker ___ __

[issue19659] Document Argument Clinic?

2013-11-19 Thread STINNER Victor
New submission from STINNER Victor: While modifying zlibmodule.c, Serhiy told me that argument clinic is now used in zlibmodule.c. Running "./python Tools/clinic/clinic.py -f Modules/zlibmodule.c" does modify the file, so I misuse argument clinic. I saw Argument Clinic on Youtube but it didn't

[issue18294] zlib module is not completly 64-bit safe

2013-11-19 Thread STINNER Victor
STINNER Victor added the comment: zlib_64bit-4.patch: * fix usage of argument clinic, add a uint_converter * fix zlib_Decompress_decompress(): use an unsigned int, not an int (remove int_converter()) * fix two bugs and unit tests -- Added file: http://bugs.python.org/file32715/zlib_64b

[issue18566] In unittest.TestCase docs for setUp() and tearDown() don't mention AssertionError

2013-11-19 Thread Julian Gindi
Julian Gindi added the comment: I did some further testing and it seems that you are right, testcase.SkipTest() never causes an error in setUp or tearDown but "raise AssertionError" does (even in setUp or tearDown). I went ahead and made relevant documentation changes, let me know what you thi

[issue19652] test_asyncio: test_subprocess_send_signal() hangs on buildbot "AMD64 Snow Leop 3.x"

2013-11-19 Thread STINNER Victor
STINNER Victor added the comment: > I cannot help you unless you tell me which specific test is failing. Oh, I didn't notice that test_subprocess_send_signal() is part of a mixin: SubprocessTestsMixin. Configure output: checking sys/devpoll.h usability... no checking sys/devpoll.h presence...

[issue19660] decorator syntax: allow testlist instead of just dotted_name

2013-11-19 Thread James Powell
New submission from James Powell: Decorator syntax currently allows only a dotted_name after the @. As far as I can tell, this was a gut-feeling decision made by Guido. [1] I spoke with Nick Coghlan at PyTexas about this, and he suggested that if someone did the work, there might be interest i

[issue19660] decorator syntax: allow testlist instead of just dotted_name

2013-11-19 Thread James Powell
Changes by James Powell : -- keywords: +patch Added file: http://bugs.python.org/file32717/decorator-syntax.patch ___ Python tracker ___ _

[issue19183] PEP 456 Secure and interchangeable hash algorithm

2013-11-19 Thread Christian Heimes
Christian Heimes added the comment: The PEP should be ready now. I have addressed your input in http://hg.python.org/peps/rev/fbe779221a7a -- assignee: christian.heimes -> ncoghlan ___ Python tracker _

[issue19660] decorator syntax: allow testlist instead of just dotted_name

2013-11-19 Thread Eric V. Smith
Changes by Eric V. Smith : -- nosy: +eric.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue19652] test_asyncio: test_subprocess_send_signal() hangs on buildbot "AMD64 Snow Leop 3.x"

2013-11-19 Thread Guido van Rossum
Guido van Rossum added the comment: Oh, sorry, I didn't realize the name of the failing test was in the issue title. But even that's no excuse, because it's also in the log. :-( Fortunately the line where we're hanging is also in the log: line 291 in selectors.py is in PollSelector. So that's

[issue19653] Generalize usage of _PyUnicodeWriter for repr(obj): add _PyObject_ReprWriter()

2013-11-19 Thread Eric Snow
Eric Snow added the comment: As far as I'm aware, the performance of __repr__() for any object is not much of a concern. Repr is mostly for debugging and interactive use, so it's already fast/efficient enough for the target consumers: us. :) Making __repr__() easier to write or maintain is w

[issue19658] inspect.getsource weird case

2013-11-19 Thread Ronny Pfannschmidt
Changes by Ronny Pfannschmidt : -- components: +Library (Lib) ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: h

[issue18294] zlib module is not completly 64-bit safe

2013-11-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: LGTM. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pytho

[issue19653] Generalize usage of _PyUnicodeWriter for repr(obj): add _PyObject_ReprWriter()

2013-11-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: I supported patches for repr(list), repr(tuple) and repr(dict) because they made the code shorter and cleaner. But this patch is more questionable. -- ___ Python tracker ___

[issue19506] subprocess.communicate() should use a memoryview

2013-11-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: What is a performance for small chunks? -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Pyth

[issue3158] Doctest fails to find doctests in extension modules

2013-11-19 Thread Eric Snow
Eric Snow added the comment: Larry: thoughts? -- nosy: +larry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue19518] Add new PyRun_xxx() functions to not encode the filename

2013-11-19 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: PyRun_FileObject() looks misleading, because it works with FILE*, not with a file object. -- ___ Python tracker ___ _

[issue15204] Deprecate the 'U' open mode

2013-11-19 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : Removed file: http://bugs.python.org/file26198/deprecate-U-mode-stage2.patch ___ Python tracker ___ ___ Python-b

[issue15204] Deprecate the 'U' open mode

2013-11-19 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : Removed file: http://bugs.python.org/file27345/deprecate-U-mode-stage1_2.patch ___ Python tracker ___ ___ Python

<    1   2